[Samba] roaming profiles and folder redirection: programs 'not responding'
Hello, I've setup a PDC with Samba 3.0.31 and I am testing on a Windows Vista box (64 bits version). Often I get the message of programs that they are not responding and it takes about half a minute before I can use them again. Especially Mozilla Firefox has this problem often (allthough I'm using this program the most, so it is also the most obvious). I am using roaming profiles with folder redirection. I excluded all folders from the profile through a registry setting and redirected all folders in the user shell folders to network drivers, except the folders that appear in 'AppData/Local' (so the local, machine dependent settings are excluded from the profile and they are located on the local disk of the computer). Does anyone recognize these problems? Does anyone know a solution, or the best way to troubleshoot this? My roaming profiles are working fine otherwise, all settings are nicely stored in the profile, I don't get any error messages and the user has the proper rights to write to any network drive that is needed for this user. Also I have no problems with the network connection. I detected no packet loss and the response time is fast (tried pinging to the server while the problem occured, average time was 0 ms and 0% packet loss). The problem is by far not occuring as much when I'm logged in using a local profile on the machine, so I think it must be some problem with the PDC connecting with Vista. Greetings, Heiko -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Re: roaming profiles and folder redirection: programs 'not responding' (solved)
I seem to have solved the problem. While I had the 'wins' entry in /etc/nsswitch.conf of the samba machine, winbind wasn't installed, so it wasn't able to do a netbios lookup of the client machine. Since I fixed this problem, the 'not responding' problem didn't occur anymore. Greetings, Heiko 2008/8/10 Heiko Harders [EMAIL PROTECTED]: Hello, I've setup a PDC with Samba 3.0.31 and I am testing on a Windows Vista box (64 bits version). Often I get the message of programs that they are not responding and it takes about half a minute before I can use them again. Especially Mozilla Firefox has this problem often (allthough I'm using this program the most, so it is also the most obvious). I am using roaming profiles with folder redirection. I excluded all folders from the profile through a registry setting and redirected all folders in the user shell folders to network drivers, except the folders that appear in 'AppData/Local' (so the local, machine dependent settings are excluded from the profile and they are located on the local disk of the computer). Does anyone recognize these problems? Does anyone know a solution, or the best way to troubleshoot this? My roaming profiles are working fine otherwise, all settings are nicely stored in the profile, I don't get any error messages and the user has the proper rights to write to any network drive that is needed for this user. Also I have no problems with the network connection. I detected no packet loss and the response time is fast (tried pinging to the server while the problem occured, average time was 0 ms and 0% packet loss). The problem is by far not occuring as much when I'm logged in using a local profile on the machine, so I think it must be some problem with the PDC connecting with Vista. Greetings, Heiko -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Problem with permissions
Hi everyone. I have to task where i have to replace windows NT server by samba. The problem i facing is with permissions. In windows NT , administrator can provide a share permissision like , full control, read write but no delete and read. But i have provide same functionality in samba server. How can i set such permission , write but no delete in linux through samba. I have googled a lot but couldn't find the solution. Any help would be apperciated. Thanks -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Problem with permissions
Bikrish Amatya wrote: Hi everyone. I have to task where i have to replace windows NT server by samba. The problem i facing is with permissions. In windows NT , administrator can provide a share permissision like , full control, read write but no delete and read. But i have provide same functionality in samba server. How can i set such permission , write but no delete in linux through samba. I have googled a lot but couldn't find the solution. Any help would be apperciated. Thanks Hi Bikrish, If you setup ACL, you can actually set up permissions using the security tab in windows explorer from another windows box, you you can use the cmd line. You might have to remount your FS with acl enabled, what distro are you using? Check out http://www.bluelightning.org/linux/samba_acl_howto/ or google some other guides. I am setting this up atm so let me know if you get the Explorer thing to work! Keith -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
RE: [Samba] Machine-level shares on Windows server
-Original Message- From: Gerald (Jerry) Carter [mailto:[EMAIL PROTECTED] Sent: Friday, 8 August 2008 23:42 To: Jeremy Evans Cc: samba@lists.samba.org Subject: Re: [Samba] Machine-level shares on Windows server -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeremy Evans wrote: I've found that I can't access the share (or even get the list of shares as in the examples below) using the -P (--machine-password) switch, so I get the choice of $smbclient -P -L //sbs Failed to open /var/lib/samba/secrets.tdb ERROR: Unable to open secrets database You don't appear to be root. Secrets.tdb is rw for root only. I realise that. I *did* give a 2nd example in my original post: $sudo smbclient -P -L //sbs ERROR: Unable to fetch machine password net ads testjoin returns an OK result at my end the PDC shows the machine as joined to the domain at the other. What I don't seem to be able to find out is just how the Windows PDC Samba interact to ensure that the Samba machine is a [trusted?] member of the domain therefore how to use that fact to allow machine-level shares without having to perform a user-level login. Thx, Jeremy -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] unable to map windows to unix groups
As I said, I did a fresh install of opensuse 10.3, samba, ldap. During the process, I filled the ldap database directly with an ldif file built using smbldap tools. (one item in that file -- dn: cn=Domain Admins,ou=Groups,dc=ldap_hathor,dc=nwk objectClass: top objectClass: posixGroup objectClass: sambaGroupMapping gidNumber: 512 cn: Domain Admins memberUid: root sambaSID: S-1-5-21-3134345319-2430187646-2919245149-512 sambaGroupType: 2 displayName: Domain Admins description: Netbios Domain Administrators #sambaPrimaryGroupSID: SID of the user group (512 = Admins group) #description: Netbios Domain Administrators ) So you mean by doing this it is not necessary to map the native existing unix group ntadmin (gid 71) with Domain Admins ? (ntadmin appear in /etc/group and Domain Admins not) Reading the samba documentation was not very clear for me. jcdole Selon Douglas VanLeuven [EMAIL PROTECTED]: It looks like you already have an existing unix group called Domain Admins being pulled in from ldap. When that is true, there is no need for groupmap and indeed it would appear it is illegal to map a windows group that matches an existing unix group to another unix group. Doug [EMAIL PROTECTED] wrote: Hello. After fresh install. Samba and ldap seems to run normally ( I can join win2k workstation to linux samba pdc ). Using yast I create a system group named domadmin But I am unable to map Domain Admins to domadmin I am unable to map Domain Admins to existing ntadmin group I am unable to mofify mapping Domain Admins to domadmin group Thank you for helping. LINUX-SRV: # net groupmap add ntgroup=Domain Admins unixgroup=domadmin rid=512 type=d adding entry for group Domain Admins failed! LINUX-SRV: # LINUX-SRV: # net groupmap add ntgroup=Domain Admins unixgroup=ntadmin rid=512 type=d adding entry for group Domain Admins failed! LINUX-SRV: # LINUX-SRV: # net groupmap modify ntgroup=Domain Admins unixgroup=domadmin Can't map to an unknown group type. LINUX-SRV: # LINUX-SRV:~ # net groupmap modify ntgroup=Domain Admins unixgroup=domadmin type=d Could not update group database LINUX-SRV: # LINUX-SRV:~ net groupmap list request done: ld 0x55c881e0 msgid 1 request done: ld 0x55c881e0 msgid 2 Domain Admins (S-1-5-21-3134345319-2430187646-2919245149-512) - Domain Admins request done: ld 0x55c881e0 msgid 3 Domain Users (S-1-5-21-3134345319-2430187646-2919245149-513) - Domain Users request done: ld 0x55c881e0 msgid 4 Domain Guests (S-1-5-21-3134345319-2430187646-2919245149-514) - Domain Guests request done: ld 0x55c881e0 msgid 5 Domain Computers (S-1-5-21-3134345319-2430187646-2919245149-515) - Domain Computers request done: ld 0x55c881e0 msgid 6 Administrators (S-1-5-32-544) - Administrators request done: ld 0x55c881e0 msgid 7 Account Operators (S-1-5-32-548) - Account Operators request done: ld 0x55c881e0 msgid 8 Print Operators (S-1-5-32-550) - Print Operators request done: ld 0x55c881e0 msgid 9 Backup Operators (S-1-5-32-551) - Backup Operators request done: ld 0x55c881e0 msgid 10 Replicators (S-1-5-32-552) - Replicators request done: ld 0x55c881e0 msgid 11 Users (S-1-5-32-545) - 15000 LINUX-SRV: # LINUX-SRV: # getent group at:!:25: .. .. domadmin:x:114: root:x:0: ... .. users:x:100: +::0: request done: ld 0x618d10 msgid 1 Domain Admins:*:512:root,user_admin Domain Users:*:513: Domain Guests:*:514: Domain Computers:*:515: Administrators:*:544: Account Operators:*:548: Print Operators:*:550: Backup Operators:*:551: Replicators:*:552: request done: ld 0x618d10 msgid 2 It looks like you already have an existing unix group called Domain Admins being pulled in from ldap. When that is true, there is no need for groupmap and indeed it would appear it is illegal to map a windows group that matches an existing unix group to another unix group. Doug -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Cant Set Password on Windows Side.
Hello All. Samba ver 3.0.25b-1.1.cc SMB.Conf admin users = administrator unix password sync = yes os level = 65 domain master = yes domain logons = yes passwd program = /usr/sbin/userpasswd %u passwd chat = *password:* %n\n *password:* %n\n *successfully.* add machine script = /usr/sbin/useradd -d /dev/null -g samba-clients -s /bin/fa$ security = user encrypt passwords = yes smb passwd file = /etc/samba/smbpasswd syslog = false netbios name = server workgroup = WKGROUP realm = WKGROUP.LOCAL Is there anything in my config thag will lead to this error message? Domain users cant change their password by pressing control alt delete. They get an error message stating the domain doesnt exist. = The Secrets to Mastering Hypnosis Bennett/Stellar University is celebrating its 10th anniversary as a licensed and approved school providing comprehensive instruction and certifications in the field of hypnosis. http://a8-asy.a8ww.net/a8-ads/adftrclick?redirectid=d96ce8b93944a0986f30bde2b5f74bf2 -- Powered by Outblaze -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Cant Set Password on Windows Side.
There are several things that could be causing it. 1) is your passwd program really called userpasswd? 2) does the passwd chat really match what your passwd program expects? 3) have the windows machines joined the domain? 4) can the windows machines see the domain controller? Jeff L wrote: Hello All. Samba ver 3.0.25b-1.1.cc SMB.Conf admin users = administrator unix password sync = yes os level = 65 domain master = yes domain logons = yes passwd program = /usr/sbin/userpasswd %u passwd chat = *password:* %n\n *password:* %n\n *successfully.* add machine script = /usr/sbin/useradd -d /dev/null -g samba-clients -s /bin/fa$ security = user encrypt passwords = yes smb passwd file = /etc/samba/smbpasswd syslog = false netbios name = server workgroup = WKGROUP realm = WKGROUP.LOCAL Is there anything in my config thag will lead to this error message? Domain users cant change their password by pressing control alt delete. They get an error message stating the domain doesnt exist. = The Secrets to Mastering Hypnosis Bennett/Stellar University is celebrating its 10th anniversary as a licensed and approved school providing comprehensive instruction and certifications in the field of hypnosis. http://a8-asy.a8ww.net/a8-ads/adftrclick?redirectid=d96ce8b93944a0986f30bde2b5f74bf2 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] unable to map windows to unix groups
[EMAIL PROTECTED] wrote: As I said, I did a fresh install of opensuse 10.3, samba, ldap. During the process, I filled the ldap database directly with an ldif file built using smbldap tools. (one item in that file -- dn: cn=Domain Admins,ou=Groups,dc=ldap_hathor,dc=nwk objectClass: top objectClass: posixGroup objectClass: sambaGroupMapping gidNumber: 512 cn: Domain Admins memberUid: root sambaSID: S-1-5-21-3134345319-2430187646-2919245149-512 sambaGroupType: 2 displayName: Domain Admins description: Netbios Domain Administrators #sambaPrimaryGroupSID: SID of the user group (512 = Admins group) #description: Netbios Domain Administrators ) So you mean by doing this it is not necessary to map the native existing unix group ntadmin (gid 71) with Domain Admins ? (ntadmin appear in /etc/group and Domain Admins not) When you do getent group you're getting what's in the local /etc/group and what's defined in the ldap group membership. See gidNumber above. Using /etc/nsswitch.conf to define ldap lookups extends the /etc/passwd and /etc/group membership so passwd and group uid/gid's can be defined system wide and used by any unix machine. So yes. Users belonging to group 512 are Domain Admins. You need to add users to this group when you want them to have related security privileges. You should be able to chgrp 512 filename and have it show as Domain Admins when you ls the directory. I haven't used the smbldap tools package, but it looks like the most common windows groups have already been defined for you. All you need to do is avoid using the ldap passwd group uid/gids in the local files. Yast tools will probably not allow you to generate duplicates. And yes, you only need to map groups when the unix name doesn't match the windows name and you don't want samba to create the account on the fly using whatever idmap backend you pick. Your idmap backend should probably be idmap_ldap and accounts generated then become available system wide using the same uid/gid's and network file sharing offers the same membership security regardless of client machine access. This is probably in a FAQ somewhere where the answer would be more structured. I use the following to resolve my issues: http://us6.samba.org/samba/docs/man/Samba-HOWTO-Collection/ http://us6.samba.org/samba/docs/man/Samba-Guide/ Since samba is evolving almost daily, sometime the Howto syntax has been modified in the current manifestation of the command. Always refer to the current command documentation to resolve any discrepancies. Doug Reading the samba documentation was not very clear for me. jcdole Selon Douglas VanLeuven [EMAIL PROTECTED]: It looks like you already have an existing unix group called Domain Admins being pulled in from ldap. When that is true, there is no need for groupmap and indeed it would appear it is illegal to map a windows group that matches an existing unix group to another unix group. Doug [EMAIL PROTECTED] wrote: Hello. After fresh install. Samba and ldap seems to run normally ( I can join win2k workstation to linux samba pdc ). Using yast I create a system group named domadmin But I am unable to map Domain Admins to domadmin I am unable to map Domain Admins to existing ntadmin group I am unable to mofify mapping Domain Admins to domadmin group Thank you for helping. LINUX-SRV: # net groupmap add ntgroup=Domain Admins unixgroup=domadmin rid=512 type=d adding entry for group Domain Admins failed! LINUX-SRV: # LINUX-SRV: # net groupmap add ntgroup=Domain Admins unixgroup=ntadmin rid=512 type=d adding entry for group Domain Admins failed! LINUX-SRV: # LINUX-SRV: # net groupmap modify ntgroup=Domain Admins unixgroup=domadmin Can't map to an unknown group type. LINUX-SRV: # LINUX-SRV:~ # net groupmap modify ntgroup=Domain Admins unixgroup=domadmin type=d Could not update group database LINUX-SRV: # LINUX-SRV:~ net groupmap list request done: ld 0x55c881e0 msgid 1 request done: ld 0x55c881e0 msgid 2 Domain Admins (S-1-5-21-3134345319-2430187646-2919245149-512) - Domain Admins request done: ld 0x55c881e0 msgid 3 Domain Users (S-1-5-21-3134345319-2430187646-2919245149-513) - Domain Users request done: ld 0x55c881e0 msgid 4 Domain Guests (S-1-5-21-3134345319-2430187646-2919245149-514) - Domain Guests request done: ld 0x55c881e0 msgid 5 Domain Computers (S-1-5-21-3134345319-2430187646-2919245149-515) - Domain Computers request done: ld 0x55c881e0 msgid 6 Administrators (S-1-5-32-544) - Administrators request done: ld 0x55c881e0 msgid 7 Account Operators (S-1-5-32-548) - Account Operators request done: ld 0x55c881e0 msgid 8 Print Operators (S-1-5-32-550) - Print Operators request done: ld 0x55c881e0 msgid 9 Backup Operators (S-1-5-32-551) - Backup Operators request done: ld 0x55c881e0 msgid 10 Replicators (S-1-5-32-552) - Replicators request done: ld 0x55c881e0 msgid 11 Users (S-1-5-32-545) - 15000 LINUX-SRV: #
Re: [Samba] Cant Set Password on Windows Side.
Hi Gary, Yes to all of the above. Yes userpasswd is what we use on all of our servers. This one in particular is causing trouble. Is there a log file that gives more detail on the error? - Original Message - From: Gary Dale [EMAIL PROTECTED] To: Subject: Re: [Samba] Cant Set Password on Windows Side. Date: Sun, 10 Aug 2008 20:41:39 -0400 There are several things that could be causing it. 1) is your passwd program really called userpasswd? 2) does the passwd chat really match what your passwd program expects? 3) have the windows machines joined the domain? 4) can the windows machines see the domain controller? Jeff L wrote: Hello All. Samba ver 3.0.25b-1.1.cc SMB.Conf admin users = administrator unix password sync = yes os level = 65 domain master = yes domain logons = yes passwd program = /usr/sbin/userpasswd %u passwd chat = *password:* %n\n *password:* %n\n *successfully.* add machine script = /usr/sbin/useradd -d /dev/null -g samba-clients -s /bin/fa$ security = user encrypt passwords = yes smb passwd file = /etc/samba/smbpasswd syslog = false netbios name = server workgroup = WKGROUP realm = WKGROUP.LOCAL Is there anything in my config thag will lead to this error message? Domain users cant change their password by pressing control alt delete. They get an error message stating the domain doesnt exist. = The Secrets to Mastering Hypnosis Bennett/Stellar University is celebrating its 10th anniversary as a licensed and approved school providing comprehensive instruction and certifications in the field of hypnosis. http://a8-asy.a8ww.net/a8-ads/adftrclick?redirectid=d96ce8b93944a0986f30bde2b5f74bf2 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba = MRV-Firewall KVM Switch 48 server ports; 8 analog/3 IP users; 1U; UXGA 1600x1400 pixels. http://a8-asy.a8ww.net/a8-ads/adftrclick?redirectid=1925e125ed67ef034257c911b21d4c34 -- Powered by Outblaze -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] How to get AD computer name by winbind
Hello, I'm trying migration from AD 203 to Samba + LDAP using winbind, but I don't know how to use getent command to get AD 2003 computer name information. I tried to use man getent that does not has related information. Could anyone tell me how to do that ? Thanks _ Connect to the next generation of MSN Messenger http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-ussource=wlmailtagline-- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] How to get AD computer name by winbind
wilson kwok wrote: Hello, I'm trying migration from AD 203 to Samba + LDAP using winbind, but I don't know how to use getent command to get AD 2003 computer name information. I tried to use man getent that does not has related information. Could anyone tell me how to do that ? getent passwd|grep \\$: All the machine names end with $ in field 1 Doug -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Problem with permissions
Hi Keith I am using Centos 5.2 and? i installed samba through yum. The version of samba that is? installed is 3.0.28. I have done as you have told me. I enabled acl and tried to setup permission in security tab in windows. My requirement is? a group , say , group1 has full control on share? , say , share1 but group2 has only read , write but no delete and group3 can only read the share. I am able to set read and full control permission from windows but when i set read and write permission only from windows , after i click apply , it converts into full control , which means group2 also has full access to share. I want only group1 has full control and group 2 can read and write only. They can't rename and can't delete. I hope u understand my requirement Thanks for your help. bikrish -Original Message- From: Keith Sudbury [EMAIL PROTECTED] Cc: samba@lists.samba.org Sent: Sun, 10 Aug 2008 11:58 pm Subject: Re: [Samba] Problem with permissions Bikrish Amatya wrote:? Hi everyone.? ? I have to task where i have to replace windows NT server by samba. The problem i facing is with permissions. In windows NT , administrator can provide a share permissision like , full control, read write but no delete and read. But i have provide same functionality in samba server. How can i set such permission , write but no delete in linux through samba. I have googled a lot but couldn't find the solution.? ? Any help would be apperciated.? ? Thanks? Hi Bikrish,? ? If you setup ACL, you can actually set up permissions using the security tab in windows explorer from another windows box, you you can use the cmd line. You might have to remount your FS with acl enabled, what distro are you using? ? Check out http://www.bluelightning.org/linux/samba_acl_howto/ or google some other guides.? ? I am setting this up atm so let me know if you get the Explorer thing to work!? ? Keith? -- To unsubscribe from this list go to the following URL and read the? instructions: https://lists.samba.org/mailman/listinfo/samba? -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3565-g5913654
The branch, v3-3-test has been updated via 59136544ec16b6ceb14a75259aedd22856832bf1 (commit) from d52b9beede1fb14e1d7e3acd9765d6cd14dfcc3d (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log - commit 59136544ec16b6ceb14a75259aedd22856832bf1 Author: Volker Lendecke [EMAIL PROTECTED] Date: Sun Aug 10 11:33:15 2008 +0200 Remove an unused variable, process.c has its static copy --- Summary of changes: source/lib/util.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source/lib/util.c b/source/lib/util.c index b346254..27a1487 100644 --- a/source/lib/util.c +++ b/source/lib/util.c @@ -60,8 +60,6 @@ enum protocol_types Protocol = PROTOCOL_COREPLUS; /* this is used by the chaining code */ int chain_size = 0; -int trans_num = 0; - static enum remote_arch_types ra_type = RA_UNKNOWN; /*** -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-2801-g34b56cb
The branch, v3-2-test has been updated
via 34b56cb54e06f9b38d2bb0a626ec7b04030fc4fa (commit)
via 2abeea64e15f0e8e8c413744de9194bdcedd6f16 (commit)
from fc309e41a45079d58c03dc6fb0c35ceb4517f0ae (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit 34b56cb54e06f9b38d2bb0a626ec7b04030fc4fa
Author: Volker Lendecke [EMAIL PROTECTED]
Date: Sun Aug 10 17:53:35 2008 +0200
fix smb_len calculation for chained requests
I think chain_reply() is one of the most tricky parts of Samba. This
recursion
needs to go away, we need to sequentially walk the chain list.
commit 2abeea64e15f0e8e8c413744de9194bdcedd6f16
Author: Volker Lendecke [EMAIL PROTECTED]
Date: Sun Aug 10 17:37:08 2008 +0200
Fix andx offset calculation for more than 2 chained requests
Untested code is broken code Test follows later, it's quite an intrusive
change to libsmb/
---
Summary of changes:
source/smbd/process.c | 16
1 files changed, 12 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/smbd/process.c b/source/smbd/process.c
index 1c28f68..4989c8f 100644
--- a/source/smbd/process.c
+++ b/source/smbd/process.c
@@ -1636,6 +1636,7 @@ void chain_reply(struct smb_request *req)
char *outbuf = (char *)req-outbuf;
size_t outsize = smb_len(outbuf) + 4;
size_t outsize_padded;
+ size_t padding;
size_t ofs, to_move;
struct smb_request *req2;
@@ -1674,12 +1675,13 @@ void chain_reply(struct smb_request *req)
*/
outsize_padded = (outsize + 3) ~3;
+ padding = outsize_padded - outsize;
/*
* remember how much the caller added to the chain, only counting
* stuff after the parameter words
*/
- chain_size += outsize_padded - smb_wct;
+ chain_size += (outsize_padded - smb_wct);
/*
* work out pointers into the original packets. The
@@ -1787,17 +1789,17 @@ void chain_reply(struct smb_request *req)
SCVAL(outbuf, smb_vwv0, smb_com2);
SSVAL(outbuf, smb_vwv1, chain_size + smb_wct - 4);
- if (outsize_padded outsize) {
+ if (padding != 0) {
/*
* Due to padding we have some uninitialized bytes after the
* caller's output
*/
- memset(outbuf + outsize, 0, outsize_padded - outsize);
+ memset(outbuf + outsize, 0, padding);
}
- smb_setlen(outbuf, outsize2 + chain_size - 4);
+ smb_setlen(outbuf, outsize2 + caller_outputlen + padding - 4);
/*
* restore the saved data, being careful not to overwrite any data
@@ -1808,6 +1810,12 @@ void chain_reply(struct smb_request *req)
SAFE_FREE(caller_output);
TALLOC_FREE(req2);
+ /*
+* Reset the chain_size for our caller's offset calculations
+*/
+
+ chain_size -= (outsize_padded - smb_wct);
+
return;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3567-gaf2b01d
The branch, v3-3-test has been updated
via af2b01d85188d2301580643f7e862e3e3988aadc (commit)
via 0ff16e8573f3c312f10fc723648319fa1f514ac0 (commit)
from 59136544ec16b6ceb14a75259aedd22856832bf1 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -
commit af2b01d85188d2301580643f7e862e3e3988aadc
Author: Volker Lendecke [EMAIL PROTECTED]
Date: Sun Aug 10 17:53:35 2008 +0200
fix smb_len calculation for chained requests
I think chain_reply() is one of the most tricky parts of Samba. This
recursion
needs to go away, we need to sequentially walk the chain list.
commit 0ff16e8573f3c312f10fc723648319fa1f514ac0
Author: Volker Lendecke [EMAIL PROTECTED]
Date: Sun Aug 10 17:37:08 2008 +0200
Fix andx offset calculation for more than 2 chained requests
Untested code is broken code Test follows later, it's quite an intrusive
change to libsmb/
---
Summary of changes:
source/smbd/process.c | 16
1 files changed, 12 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/smbd/process.c b/source/smbd/process.c
index da11652..332a2e4 100644
--- a/source/smbd/process.c
+++ b/source/smbd/process.c
@@ -1653,6 +1653,7 @@ void chain_reply(struct smb_request *req)
char *outbuf = (char *)req-outbuf;
size_t outsize = smb_len(outbuf) + 4;
size_t outsize_padded;
+ size_t padding;
size_t ofs, to_move;
struct smb_request *req2;
@@ -1691,12 +1692,13 @@ void chain_reply(struct smb_request *req)
*/
outsize_padded = (outsize + 3) ~3;
+ padding = outsize_padded - outsize;
/*
* remember how much the caller added to the chain, only counting
* stuff after the parameter words
*/
- chain_size += outsize_padded - smb_wct;
+ chain_size += (outsize_padded - smb_wct);
/*
* work out pointers into the original packets. The
@@ -1804,17 +1806,17 @@ void chain_reply(struct smb_request *req)
SCVAL(outbuf, smb_vwv0, smb_com2);
SSVAL(outbuf, smb_vwv1, chain_size + smb_wct - 4);
- if (outsize_padded outsize) {
+ if (padding != 0) {
/*
* Due to padding we have some uninitialized bytes after the
* caller's output
*/
- memset(outbuf + outsize, 0, outsize_padded - outsize);
+ memset(outbuf + outsize, 0, padding);
}
- smb_setlen(outbuf, outsize2 + chain_size - 4);
+ smb_setlen(outbuf, outsize2 + caller_outputlen + padding - 4);
/*
* restore the saved data, being careful not to overwrite any data
@@ -1825,6 +1827,12 @@ void chain_reply(struct smb_request *req)
SAFE_FREE(caller_output);
TALLOC_FREE(req2);
+ /*
+* Reset the chain_size for our caller's offset calculations
+*/
+
+ chain_size -= (outsize_padded - smb_wct);
+
return;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3568-g3d4e7b2
The branch, v3-3-test has been updated
via 3d4e7b29c235e329aaea4fa2c2078df0ce3e59eb (commit)
from af2b01d85188d2301580643f7e862e3e3988aadc (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -
commit 3d4e7b29c235e329aaea4fa2c2078df0ce3e59eb
Author: Volker Lendecke [EMAIL PROTECTED]
Date: Sat Aug 9 21:39:18 2008 +0200
Make events robust against their event_context being freed
---
Summary of changes:
source/lib/events.c | 33 -
1 files changed, 28 insertions(+), 5 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/lib/events.c b/source/lib/events.c
index 7750176..f031387 100644
--- a/source/lib/events.c
+++ b/source/lib/events.c
@@ -63,7 +63,9 @@ static int timed_event_destructor(struct timed_event *te)
{
DEBUG(10, (Destroying timed event %lx \%s\\n, (unsigned long)te,
te-event_name));
- DLIST_REMOVE(te-event_ctx-timed_events, te);
+ if (te-event_ctx != NULL) {
+ DLIST_REMOVE(te-event_ctx-timed_events, te);
+ }
return 0;
}
@@ -131,9 +133,9 @@ struct timed_event *event_add_timed(struct event_context
*event_ctx,
static int fd_event_destructor(struct fd_event *fde)
{
- struct event_context *event_ctx = fde-event_ctx;
-
- DLIST_REMOVE(event_ctx-fd_events, fde);
+ if (fde-event_ctx != NULL) {
+ DLIST_REMOVE(fde-event_ctx-fd_events, fde);
+ }
return 0;
}
@@ -354,9 +356,30 @@ int event_loop_once(struct event_context *ev)
return 0;
}
+static int event_context_destructor(struct event_context *ev)
+{
+ while (ev-fd_events != NULL) {
+ ev-fd_events-event_ctx = NULL;
+ DLIST_REMOVE(ev-fd_events, ev-fd_events);
+ }
+ while (ev-timed_events != NULL) {
+ ev-timed_events-event_ctx = NULL;
+ DLIST_REMOVE(ev-timed_events, ev-timed_events);
+ }
+ return 0;
+}
+
struct event_context *event_context_init(TALLOC_CTX *mem_ctx)
{
- return TALLOC_ZERO_P(mem_ctx, struct event_context);
+ struct event_context *result;
+
+ result = TALLOC_ZERO_P(mem_ctx, struct event_context);
+ if (result == NULL) {
+ return NULL;
+ }
+
+ talloc_set_destructor(result, event_context_destructor);
+ return result;
}
int set_event_dispatch_time(struct event_context *event_ctx,
--
Samba Shared Repository
[SCM] CTDB repository - branch master updated - 29aaa339ef745208fb0b746db5cbc3a32d0d81b2
The branch, master has been updated
via 29aaa339ef745208fb0b746db5cbc3a32d0d81b2 (commit)
via db6bc3745a56cc12e60e727190a098a6527690d6 (commit)
from 3059ab5f3f21e331b80728773c36a74620e46677 (commit)
http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=master
- Log -
commit 29aaa339ef745208fb0b746db5cbc3a32d0d81b2
Author: Ronnie Sahlberg [EMAIL PROTECTED]
Date: Mon Aug 11 10:33:22 2008 +1000
new version 1.0.55
---
Summary of changes:
packaging/RPM/ctdb.spec |4 +++-
server/ctdb_takeover.c |7 ++-
2 files changed, 9 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/packaging/RPM/ctdb.spec b/packaging/RPM/ctdb.spec
index ea9ffbd..fedb26e 100644
--- a/packaging/RPM/ctdb.spec
+++ b/packaging/RPM/ctdb.spec
@@ -5,7 +5,7 @@ Vendor: Samba Team
Packager: Samba Team [EMAIL PROTECTED]
Name: ctdb
Version: 1.0
-Release: 54
+Release: 55
Epoch: 0
License: GNU GPL version 3
Group: System Environment/Daemons
@@ -118,6 +118,8 @@ fi
%{_includedir}/ctdb_private.h
%changelog
+* Mon Aug 11 2008: Version 1.0.55
+ - Fix the releaseip message we seond to samba.
* Fri Aug 8 2008 : Version 1.0.54
- fix a looping error in the transaction code
- provide a more detailed error code for persistent store errors
diff --git a/server/ctdb_takeover.c b/server/ctdb_takeover.c
index 10369d4..53f48c1 100644
--- a/server/ctdb_takeover.c
+++ b/server/ctdb_takeover.c
@@ -304,13 +304,18 @@ static void release_ip_callback(struct ctdb_context
*ctdb, int status,
/* send a message to all clients of this node telling them
that the cluster has been reconfigured and they should
release any sockets on this IP */
+#if 1
+ strncpy(ip, inet_ntoa(state-addr-ip.sin_addr), sizeof(ip)-1);
+#else
if (inet_ntop(state-addr-sa.sa_family, state-addr-sa.sa_data[0],
ip, sizeof(ip)) == NULL) {
DEBUG(DEBUG_ERR, (__location__ inet_ntop() failed\n));
}
-
+#endif
data.dptr = (uint8_t *)ip;
data.dsize = strlen(ip)+1;
+ DEBUG(DEBUG_INFO,(__location__ sending RELEASE_IP for '%s'\n,
data.dptr));
+
ctdb_daemon_send_message(ctdb, ctdb-pnn, CTDB_SRVID_RELEASE_IP, data);
/* kill clients that have registered with this IP */
--
CTDB repository
[SCM] CTDB repository - branch origin updated - db6bc3745a56cc12e60e727190a098a6527690d6
The branch, origin has been updated via db6bc3745a56cc12e60e727190a098a6527690d6 (commit) via 3059ab5f3f21e331b80728773c36a74620e46677 (commit) via b3b9707dd8244758ff1080401a9e03e74766e1ab (commit) via 7f29c50ccbc7789bfbc20bcb4b65758af9ebe6c5 (commit) via 7c6b621f7307dc39ffcd7d965ac613642af201b8 (commit) via e75cc3a030a8ccb43961cf80ff10d41ec81a24b0 (commit) via 2426b9010ef45f5e96ffc12b8a69a3b0566b4f98 (commit) via a4814aa8b0b165b9d6c4c55fc5aee33cd1a570bd (commit) via 7ed5fbe7fa3bc3cb729d9b516d2a73d52e28d22d (commit) via 6915661a460cd589b441ac7cd8695f35c4e83113 (commit) via 58e6dc722ad1e2415b71baf1d471885169dde14d (commit) via 0592ba2a4fbd1b3b7a6bd0780eadbd6d449baaad (commit) via bcbac6724840cdabe55e38a4c62779f853bd09ba (commit) via 66c61137a5c01afcbae329ffbe121e78ae087399 (commit) via c76c214be401cb116265ed17ffe6c77c979ded82 (commit) via 84236e03e40bcf46fa634d106903277c149a734f (commit) via 14f2f719e6ddc266aafde4d4bf80ed3a01e145fe (commit) via a9bce1ac9794f108825190948f404c864a533435 (commit) via d1d48f8661d83b01de6c552ee70021acdc6384cb (commit) via 09aa91224fe7b835dc0a2c58868cce28ce54809f (commit) via b6d9a0396fb4b325778d3810dc656f719f31b9f1 (commit) via f7a70a5f9043b1d7293a515abf5b5228365693da (commit) via aefcb1f817581ac8cd67712d07159fc802f96623 (commit) via fe55bfc8fb6dc628f72f220843e829a251d09936 (commit) via 3a71844cfdb9fe69208030432ddb547b0e215726 (commit) via 306af4ccef132ea023f1f01e11f877a3a742ee4c (commit) via bad53b2d342bb9760497e6f4a61e64ca50d6e771 (commit) via 9806d18b93218c216d538e28f9ed495269f0a938 (commit) via 71d9d24abae62f70acbd7c1ded8af0b817607c2a (commit) via 12087e7d751a8756076662cd8db5dcf35316c0c5 (commit) via 2bc7f3aef4668bd1680db87ef215c349280a84f2 (commit) via aab710f1c6bcdfd8ff2992f8adc15933276dc39e (commit) via 9ff3380099fe6f4d39de126db0826971a10ee692 (commit) via d5dcb46e182466e4b51c106f2491178c23babd8d (commit) via 4d205476d286570a6e1f52b59af42858ce051106 (commit) via 008533d971aec9c28c6e4750ef4677dd943633ff (commit) via d3f5d75665a78ae0081fda57e58384b27a6ae396 (commit) via 22f737be0e70fc043affaa4f953f60d852b7999a (commit) via ded1a974cdd86b436c6e5cba27069d1a3796dbe9 (commit) via 795c190b004d404b84dda053593139ed51d345e5 (commit) via b1fed105ad780e89a128a611ef0bd659818eeebf (commit) via 8fed021d11160b137f4140ea02947347250e2959 (commit) via e8ef9891aa31c374921b23cc74e1eda1f8218bf0 (commit) via 0de79352c9b36c118e36905f08ebbe38ecbb957e (commit) via b08a988fbdad0da850c9b79791c1a8970555147f (commit) via eca73bcaa33f88c683b79d57d85b590659018ad8 (commit) via e24152fbd06ba4c2b6cfd473751c7f00a676b9ae (commit) via c5035657606283d2e35bea40992505e84ca8e7be (commit) via 60e2cb175c449ae65793a3e1ffb60cf030a3a0d5 (commit) via 3d58f9b524a40c7b43a2a855212db090e9becefa (commit) via 554dcf16d37c8b9e4704df11d21fb272f30f5cec (commit) via 52716d26eb84104d65828bed38e69f214a5fa824 (commit) via 52a38487f981fd5981c02a7a063ad2c598591c10 (commit) via af38c8d4cc03e1b5a314ea2338346c5f8c80aa95 (commit) via ccf9334bd20b1398623dd649987aa15119dac14e (commit) via 1ffccb3e0b3b5bd376c5302304029af393709518 (commit) via 8140825e1d06053a900fd0adf0a150622c0fc146 (commit) via 05918bcb58acd2add7e13c028de09641a7519cd1 (commit) via d7e9c0010a40f9335d28cf108e8f5cf411970a03 (commit) via 9478852f2b4f530994b2211fff45413d1da82dd9 (commit) via 2b0bd6c302545f2533a7a67dfc6bb5f9f60799f7 (commit) via 9043913a54fe707083697f0587c6ffde86ca5a69 (commit) via 2fe52c7979ecd28250ec4ac195d3c316e573 (commit) via 495a6293c284a1e74b9c5e0c112e6ed5feead107 (commit) via c26afe26cc5c1f9cd9eef74166b5fc39dde591d3 (commit) via f8c5f6ff1cae747aae917c454b49dc5db227e140 (commit) via 1de62d1ad71fa784d5e93f76da8f872cad9b9f42 (commit) via 15bc66ae801b0c69a65a7a2acf5df151e76edc2a (commit) via f4a6dd98c86f2028c00b62313a071a94cafc95f9 (commit) via b18a1b59ecd8913e03a59b1a105002f2c9221324 (commit) via f7bdf96843a7e4ad61ad378786922d6281de9d93 (commit) via dfaf2c1581e547df831b3171ad47acd27b4ca2af (commit) via c47acc0eb2e1275a6c6fc05829bd1131d999f8fd (commit) via 2cc9aba3d7e608eccc29c897f710b69f30653bbf (commit) via 919af5aadb797cfdd10473b6a1269f4ae2a9dbda (commit) via d94e76bfb3e464c0540331caf282efc13ff60e42 (commit) via 563cdf2bd9cca358d234c797d8e1d9c8838c6ca6 (commit) via b2ccb891b81b041e2186e038b67bb4354b7892aa (commit) via 00025eef662b867293829228c681df491cd6f371 (commit) via 172d01fb34f032e098b1c77a7b0f17bf11301640 (commit)
[SCM] CTDB repository - branch master updated - c94b295b078dc009c18aa416d0de232a12241014
The branch, master has been updated
via c94b295b078dc009c18aa416d0de232a12241014 (commit)
from 29aaa339ef745208fb0b746db5cbc3a32d0d81b2 (commit)
http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=master
- Log -
commit c94b295b078dc009c18aa416d0de232a12241014
Author: Ronnie Sahlberg [EMAIL PROTECTED]
Date: Mon Aug 11 10:36:38 2008 +1000
fix the date soe rpmbuild works
---
Summary of changes:
packaging/RPM/ctdb.spec |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/packaging/RPM/ctdb.spec b/packaging/RPM/ctdb.spec
index fedb26e..cb5cd6a 100644
--- a/packaging/RPM/ctdb.spec
+++ b/packaging/RPM/ctdb.spec
@@ -118,7 +118,7 @@ fi
%{_includedir}/ctdb_private.h
%changelog
-* Mon Aug 11 2008: Version 1.0.55
+* Mon Aug 11 2008 : Version 1.0.55
- Fix the releaseip message we seond to samba.
* Fri Aug 8 2008 : Version 1.0.54
- fix a looping error in the transaction code
--
CTDB repository
[SCM] CTDB repository - branch 1.0.55 created - c94b295b078dc009c18aa416d0de232a12241014
The branch, 1.0.55 has been created at c94b295b078dc009c18aa416d0de232a12241014 (commit) - Log - commit c94b295b078dc009c18aa416d0de232a12241014 Author: Ronnie Sahlberg [EMAIL PROTECTED] Date: Mon Aug 11 10:36:38 2008 +1000 fix the date soe rpmbuild works commit 29aaa339ef745208fb0b746db5cbc3a32d0d81b2 Author: Ronnie Sahlberg [EMAIL PROTECTED] Date: Mon Aug 11 10:33:22 2008 +1000 new version 1.0.55 --- -- CTDB repository
[SCM] CTDB repository - tag ctdb-1.0.55 created - c94b295b078dc009c18aa416d0de232a12241014
The tag, ctdb-1.0.55 has been created at c94b295b078dc009c18aa416d0de232a12241014 (commit) - Log - commit c94b295b078dc009c18aa416d0de232a12241014 Author: Ronnie Sahlberg [EMAIL PROTECTED] Date: Mon Aug 11 10:36:38 2008 +1000 fix the date soe rpmbuild works --- -- CTDB repository
