[Samba] NT_STATUS_ACCESS_DENIED
Hi all, I have a samba PDC (with ldap), all ok for several months since today users experience very slow login, in my log I have : [2008/12/03 11:00:18, 0] auth/auth_util.c:create_builtin_administrators(792) create_builtin_administrators: Failed to create Administrators [2008/12/03 11:00:18, 0] auth/auth_util.c:create_builtin_users(758) create_builtin_users: Failed to create Users net sam createbuiltingroup Users give NT_STATUS_ACCESS_DENIED and wbinfo -g Error looking up domain groups until yesterday all was ok, what can be the origin of this problems? I think isn't a configuration issue, I repeat myself the same configuration is working since several months, a google search give several results with similar problems but seems none is able to solve thanks for your help, regards Nicola -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Samba ADS Error Session setup failed: Call returned zero bytes (EOF)
Thanks for your response Volker, I will inv further .. -- View this message in context: http://www.nabble.com/Samba-ADS-Error-%22Session-setup-failed%3A-Call-returned-zero-bytes-%28EOF%29%22-tp20793719p20810286.html Sent from the Samba - General mailing list archive at Nabble.com. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Unable to join ADS domain with 3.3.0rc1 on Suse 11.0 linux
I'm setting up anew server with 3.3.0rc1 and cannot join my AD domain. It may not be a problem strictly linked to the samba versiom, for my Active Directory administrators have tightened and enforced security policies since last time I joined a linux server succefully. BTW, this is what I get with net join command: namenor:/usr/src/local/samba/samba-3.3.0rc1/source # net ads join -S gilgamesh.mcs.it -U Administrator -d10 [2008/12/03 12:00:06, 5] lib/debug.c:debug_dump_status(407) INFO: Current debug levels: all: True/10 tdb: False/0 printdrivers: False/0 lanman: False/0 smb: False/0 rpc_parse: False/0 rpc_srv: False/0 rpc_cli: False/0 passdb: False/0 sam: False/0 auth: False/0 winbind: False/0 vfs: False/0 idmap: False/0 quota: False/0 acls: False/0 locking: False/0 msdfs: False/0 dmapi: False/0 registry: False/0 [2008/12/03 12:00:06, 3] param/loadparm.c:lp_load_ex(8790) lp_load_ex: refreshing parameters [2008/12/03 12:00:06, 3] param/loadparm.c:init_globals(4626) Initialising global parameters [2008/12/03 12:00:06, 3] param/params.c:pm_process(569) params.c:pm_process() - Processing configuration file /etc/samba/smb.conf [2008/12/03 12:00:06, 3] param/loadparm.c:do_section(7453) Processing section [global] doing parameter security = ADS doing parameter realm = mcs2003.it doing parameter workgroup = MCS2003 doing parameter netbios name = NAMENOR [2008/12/03 12:00:06, 4] param/loadparm.c:handle_netbios_name(6806) handle_netbios_name: set global_myname to: NAMENOR doing parameter server string = Samba: version %v, host %h doing parameter password server = * doing parameter name resolve order = wins bcast doing parameter printing = cups doing parameter printcap name = cups doing parameter printcap cache time = 750 doing parameter cups options = raw doing parameter map to guest = Bad User doing parameter idmap uid = 3000-8004 doing parameter idmap gid = 800-1988 doing parameter winbind enum groups = yes doing parameter logon path = \\%L\profiles\.msprofile doing parameter logon home = \\%L\%U\.9xprofile doing parameter logon drive = P: doing parameter unix extensions = Yes doing parameter encrypt passwords = Yes doing parameter usershare allow guests = No [2008/12/03 12:00:06, 4] param/loadparm.c:lp_load_ex(8834) pm_process() returned Yes [2008/12/03 12:00:06, 7] param/loadparm.c:lp_servicenumber(9039) lp_servicenumber: couldn't find homes [2008/12/03 12:00:06, 10] param/loadparm.c:set_server_role(8012) set_server_role: role = ROLE_DOMAIN_MEMBER [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(104) Attempting to register new charset UCS-2LE [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(112) Registered charset UCS-2LE [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(104) Attempting to register new charset UTF-16LE [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(112) Registered charset UTF-16LE [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(104) Attempting to register new charset UCS-2BE [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(112) Registered charset UCS-2BE [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(104) Attempting to register new charset UTF-16BE [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(112) Registered charset UTF-16BE [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(104) Attempting to register new charset UTF8 [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(112) Registered charset UTF8 [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(104) Attempting to register new charset UTF-8 [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(112) Registered charset UTF-8 [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(104) Attempting to register new charset ASCII [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(112) Registered charset ASCII [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(104) Attempting to register new charset 646 [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(112) Registered charset 646 [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(104) Attempting to register new charset ISO-8859-1 [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(112) Registered charset ISO-8859-1 [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(104) Attempting to register new charset UCS2-HEX [2008/12/03 12:00:06, 5] lib/iconv.c:smb_register_charset(112) Registered charset UCS2-HEX [2008/12/03 12:00:06, 5] lib/charcnv.c:charset_name(82) Substituting charset 'UTF-8' for LOCALE [2008/12/03 12:00:06, 5] lib/charcnv.c:charset_name(82) Substituting charset 'UTF-8' for LOCALE [2008/12/03 12:00:06, 5] lib/charcnv.c:charset_name(82) Substituting charset 'UTF-8' for LOCALE [2008/12/03 12:00:06, 5] lib/charcnv.c:charset_name(82)
Re: [Samba] Konica Printer: Scan to File (Samba SMB share) fails
Greetings! * Patrick Ben Koetter [EMAIL PROTECTED]: Yes it is the full log and yes it's weird. Excuse my ignorance, the log level setting is a copy and paste setting: log level = 3 passdb:5 auth:10 winbind:2 What should in- or decrease to get more usefull logging? Just ignore those different levels. Just log level = 10... Here's debug output at level 10: http://www.state-of-mind.de/log.smbd.txt I restarted the smb server and left the output in the log as it may be helpful. Does anybody have an idea, why the Konica Scanner (see: log link above) fails to write to the [scanner] share? Thanks, [EMAIL PROTECTED] -- state of mind Agentur für Kommunikation, Design und Softwareentwicklung Patrick KoetterTel: 089 45227227 Echinger Strasse 3 Fax: 089 45227226 85386 Eching Web: http://www.state-of-mind.de Amtsgericht MünchenPartnerschaftsregister PR 563 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] mounting windows homedir when using winbind
I've got samba with winbind set up, local machine is acting as domain member. getnet returns windows users/groups, wbinfo confirms that local machine acts is domain member, logging through ssh with pam_winbind set u works etc. On another machine, windoes xp also being domain member, I've got homedir share mounted antomatically as U: from //server/users. When I try to mount this share from Linux domain member it does mount (by smbmount) or I can connect to it (by smbclient) when providing correct credentials, however any access to it returns access denied. Here goes example: [EMAIL PROTECTED]:~ smbclient -U DOMAIN+USER //server/users OS=[Windows Server 2003 3790 Service Pack 2] Server=[Windows Server 2003 5.2] smb: \ ls NT_STATUS_ACCESS_DENIED listing \* One more time - this share works perfectly ok when mounted from windows. I can also happily mount and use any other share from this server, when conencting with windows credentials - except homedir, which is mounted on windows automatically by windows profile script. Samba version is 3.0.24-2.23. smb.conf, as minimal as possible, is included below. Any ideas? Regards, Zdenek [global] workgroup = DOMAIN realm = DOMAIN.LOCAL preferred master = no server string = test samba server security = ADS encrypt passwords = yes log level = 3 log file = /var/log/samba/%m max log size = 50 winbind separator = + printcap name = none printing = none idmap uid = 4-5 idmap gid = 4-5 template shell = /bin/bash template homedir = /tmp winbind enum users = yes winbind enum groups = yes [homes] comment = Home Directories valid users = %S read only = No browseable = No -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] mounting windows homedir when using winbind - more info
Just discovered that in dmesg: For smbmount, appears when I try do to ls mounted_dir and get permission denied: smb_proc_readdir_long: error=-13, breaking and for mount.cifs, appears at the same moment: CIFS VFS: Calculated size 0x27 vs actual length 0x48 CIFS VFS: bad smb size detected for Mid=8 -- Doladowanie telefonu. Szybko i wygodnie. Sprawdz http://link.interia.pl/f1fa8 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Can change password but cannot force password change
The setup: Two pdc's- pdcA is local, pdcB is remote. Openldap- local, both pdc's talk to it. The situation: I set a user's pwdLastSet to zero to force a password change upon login. If the user is logging into a machine talking to pdcA, it asks them to change their password. If the user is logging into a machine talking to pdcB, it acts like the user doesn't exist. However, if that user has an already set password, they can login to either pdc. Even further confusing me is that the users can change their password when talking to either pdc. Amazingly enough, the logs don't tell me anything, ldap logs or pdc logs. The only difference between the pdc's is one pdcA is Ubuntu Hardy while pdcB is Ubuntu Feisty. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] File permissions
Greetings, I'm running into a file permission issue. I have a share called data configured simply as: [data] read only = no path = /mnt/data For test purposes, I have a file called t.jpg. -rwx-- 1 bek bek63793 2008-12-03 11:17 t.jpg I'm logged in as matt on my local computer. If I try to open this file, I can't (which is what I expected). However, I can delete this file.. why? Based on everything I've read, the file system permissions take precedence over Samba permissions. So, my understanding is that even if write list = matt, but the file is owned by 'bek', with permissions of 700, I would still be unable to modify/delete/read/whatever that file. Am I wrong? Any help is appreciated. Thanks! - Matt -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] File permissions
On Wed, Dec 3, 2008 at 12:42 PM, [EMAIL PROTECTED] wrote: Greetings, I'm running into a file permission issue. I have a share called data configured simply as: [data] read only = no path = /mnt/data For test purposes, I have a file called t.jpg. -rwx-- 1 bek bek63793 2008-12-03 11:17 t.jpg I'm logged in as matt on my local computer. If I try to open this file, I can't (which is what I expected). However, I can delete this file.. why? What are the permissions of the folder that this file is in? John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] File permissions
755 root.matt I changed that to 755 root.root and changed the file permissions to 770 bek.trusted (matt is part of the 'trusted' group). Now I can open the file, but can't delete it.. I expected to be able to open it and delete it.. John Drescher [EMAIL PROTECTED] 12/03/2008 11:49 AM To [EMAIL PROTECTED] cc samba@lists.samba.org Subject Re: [Samba] File permissions On Wed, Dec 3, 2008 at 12:42 PM, [EMAIL PROTECTED] wrote: Greetings, I'm running into a file permission issue. I have a share called data configured simply as: [data] read only = no path = /mnt/data For test purposes, I have a file called t.jpg. -rwx-- 1 bek bek63793 2008-12-03 11:17 t.jpg I'm logged in as matt on my local computer. If I try to open this file, I can't (which is what I expected). However, I can delete this file.. why? What are the permissions of the folder that this file is in? John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] File permissions
There are Acls Posix on the file or folder that the file is in? Regards, - iarly Selbir ( Ski0s ) On Wed, Dec 3, 2008 at 2:49 PM, John Drescher [EMAIL PROTECTED] wrote: On Wed, Dec 3, 2008 at 12:42 PM, [EMAIL PROTECTED] wrote: Greetings, I'm running into a file permission issue. I have a share called data configured simply as: [data] read only = no path = /mnt/data For test purposes, I have a file called t.jpg. -rwx-- 1 bek bek63793 2008-12-03 11:17 t.jpg I'm logged in as matt on my local computer. If I try to open this file, I can't (which is what I expected). However, I can delete this file.. why? What are the permissions of the folder that this file is in? John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] File permissions
So then explicit file permissions mean nothing? After changing the parent directory to 770 and root.trusted, I was able to delete the file regardless of what the actual file permissions are.. John Drescher [EMAIL PROTECTED] 12/03/2008 12:00 PM To [EMAIL PROTECTED] cc samba@lists.samba.org Subject Re: [Samba] File permissions On Wed, Dec 3, 2008 at 12:56 PM, [EMAIL PROTECTED] wrote: 755 root.matt I changed that to 755 root.root and changed the file permissions to 770 bek.trusted (matt is part of the 'trusted' group). Now I can open the file, but can't delete it.. I expected to be able to open it and delete it.. Must have write permissions on the folder to delete. John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] File permissions
On Wed, Dec 3, 2008 at 1:06 PM, [EMAIL PROTECTED] wrote: So then explicit file permissions mean nothing? After changing the parent directory to 770 and root.trusted, I was able to delete the file regardless of what the actual file permissions are.. See here about *nix file permissions: http://www.elated.com/articles/understanding-permissions/ John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] File permissions
On Wed, Dec 03, 2008 at 11:56:26AM -0600, [EMAIL PROTECTED] wrote: 755 root.matt I changed that to 755 root.root and changed the file permissions to 770 bek.trusted (matt is part of the 'trusted' group). Now I can open the file, but can't delete it.. I expected to be able to open it and delete it.. Permission to delete a file in POSIX is an attribute of the containing directory (that's what you're modifying) not the file itself. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] File permissions
On Wed, Dec 3, 2008 at 12:56 PM, [EMAIL PROTECTED] wrote: 755 root.matt I changed that to 755 root.root and changed the file permissions to 770 bek.trusted (matt is part of the 'trusted' group). Now I can open the file, but can't delete it.. I expected to be able to open it and delete it.. Must have write permissions on the folder to delete. John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
RE: [Samba] NT_STATUS_ACCESS_DENIED
What does 'net ads testjoin' say? Sounds like the trust is broken. Whevever we've seen those errors, we've fixed them by remove and rejoining the computer to the domain. -- Eric Robinson -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Mailing List SVR Sent: Wednesday, December 03, 2008 2:07 AM To: Samba List Subject: [Samba] NT_STATUS_ACCESS_DENIED Hi all, I have a samba PDC (with ldap), all ok for several months since today users experience very slow login, in my log I have : [2008/12/03 11:00:18, 0] auth/auth_util.c:create_builtin_administrators(792) create_builtin_administrators: Failed to create Administrators [2008/12/03 11:00:18, 0] auth/auth_util.c:create_builtin_users(758) create_builtin_users: Failed to create Users net sam createbuiltingroup Users give NT_STATUS_ACCESS_DENIED and wbinfo -g Error looking up domain groups until yesterday all was ok, what can be the origin of this problems? I think isn't a configuration issue, I repeat myself the same configuration is working since several months, a google search give several results with similar problems but seems none is able to solve thanks for your help, regards Nicola -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba Disclaimer - December 3, 2008 This email and any files transmitted with it are confidential and intended solely for Mailing List SVR,Samba List. If you are not the named addressee you should not disseminate, distribute, copy or alter this email. Any views or opinions presented in this email are solely those of the author and might not represent those of . Warning: Although has taken reasonable precautions to ensure no viruses are present in this email, the company cannot accept responsibility for any loss or damage arising from the use of this email or attachments. This disclaimer was added by Policy Patrol: http://www.policypatrol.com/ -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Authentication with -A for smbclient
I can log in to a remote machine with the following command: [EMAIL PROTECTED] svnhook]$ smbclient //baobab/users blahblah -U joez -D joez Domain=[BUDAPEST] OS=[Windows 5.0] Server=[Windows 2000 LAN Manager] smb: \joez\ As you see my password is blahblah and my user name is joez. I have put this information into a file: [EMAIL PROTECTED] ~]$ cat ~/.smbcredentials username = joez password = blahblah domain = BUDAPEST Then I tried the following command using -A and the credentials file instead of specifying the user and the password on the command line: [EMAIL PROTECTED] ~]$ smbclient //baobab/users -A ~/.smbcredentials -D joez session setup failed: NT_STATUS_LOGON_FAILURE What am I doing wrong? I can send a detailed debugging output (-d 10) if the above information is not sufficient. I am using this version of smbclient: [EMAIL PROTECTED] ~]$ smbclient --version Version 3.0.24-7.fc5 K. -- Doladowanie telefonu. Szybko i wygodnie. Sprawdz http://link.interia.pl/f1fa8 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] File permissions
please, if posible, post the output of the following two commands: #getfacl name_of_folder_where_file_is_in and # getfacl name_of_file_that_you_want_delete_and_alter Regards, - iarly Selbir ( Ski0s ) On Wed, Dec 3, 2008 at 2:56 PM, [EMAIL PROTECTED] wrote: 755 root.matt I changed that to 755 root.root and changed the file permissions to 770 bek.trusted (matt is part of the 'trusted' group). Now I can open the file, but can't delete it.. I expected to be able to open it and delete it.. John Drescher [EMAIL PROTECTED] 12/03/2008 11:49 AM To [EMAIL PROTECTED] cc samba@lists.samba.org Subject Re: [Samba] File permissions On Wed, Dec 3, 2008 at 12:42 PM, [EMAIL PROTECTED] wrote: Greetings, I'm running into a file permission issue. I have a share called data configured simply as: [data] read only = no path = /mnt/data For test purposes, I have a file called t.jpg. -rwx-- 1 bek bek63793 2008-12-03 11:17 t.jpg I'm logged in as matt on my local computer. If I try to open this file, I can't (which is what I expected). However, I can delete this file.. why? What are the permissions of the folder that this file is in? John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Can change password but cannot force password change
On Wed, Dec 03, 2008 at 10:16:16AM -0600, Bryan Payne wrote: The setup: Two pdc's- pdcA is local, pdcB is remote. Openldap- local, both pdc's talk to it. The situation: I set a user's pwdLastSet to zero to force a password change upon login. If the user is logging into a machine talking to pdcA, it asks them to change their password. If the user is logging into a machine talking to pdcB, it acts like the user doesn't exist. However, if that user has an already set password, they can login to either pdc. Even further confusing me is that the users can change their password when talking to either pdc. Amazingly enough, the logs don't tell me anything, ldap logs or pdc logs. The only difference between the pdc's is one pdcA is Ubuntu Hardy while pdcB is Ubuntu Feisty. Strange. Can you get a debug level 10 log of both cases so we can track where they diverge ? Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Off Domain Login Problem
At the small non-profit I support I have a Mac OS X Server (10.4) supporting about 15 Windows XP clients. I use Open Directory for user management and the OS X Server is the PDC for the Windows domain. I have it set-up to use remote home folders on the server so any user can log in from any machine on the network. After a bumpy start, this is working very well. The users are not power users but have come to embrace the concept of there stuff not being tied to a specific machine. Now I have two Windows XP laptops to add to the domain. They work fine while connected to the domain but can not authenticate while being used off site (e.g. disconnected from the domain). The local security policy on the laptop is set to cache the domain login but it always says it can not find the domain. Is there something in the Samba config I am missing? If possible I want to avoid setting up the user as a local user on the laptop since they would now have stuff in two places. If I do manage to get disconnected authentication to work, I also wonder what would happen with file synchronization. Will the two sets of use files merge? Will one folder overwrite the other? What about same name/diff modified dates? Any thoughts/advice from someone who has tried a similar set-up that would be greatly appreciated. Thanks. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] mounting smb share
Hello All, Under FreeBSD, how can I mount a share on Windows using Kerberos auth? My Kerberos config is valid as I tested with smbclient -k and it works fine. I -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Christmas gift idea!
Christmas gift idea! Do you love your girlfrieend? http://cid-891c47676ce465f1.spaces.live.com/blog/cns!891C47676CE465F1!106.entry Words of krishna, yudhishthira said, 'it is even ye kurus, there is none amongst you, save myself, that from fear of disgrace and the desire of maintaining king, of bhimasena, who stirred not an inch though their lives from robbers, comes to be regarded. PLEASE READ THIS IMPORTANT ETIQUETTE MESSAGE BEFORE POSTING: http://www.catb.org/~esr/faqs/smart-questions.html
[SCM] Samba Shared Repository - branch master updated - afa0d6b0b14e0ef2293bd8468ffc1d6330abdb5b
The branch, master has been updated
via afa0d6b0b14e0ef2293bd8468ffc1d6330abdb5b (commit)
from 85b8cccab072bab263061654b677bc84826646c9 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit afa0d6b0b14e0ef2293bd8468ffc1d6330abdb5b
Author: Stefan Metzmacher [EMAIL PROTECTED]
Date: Wed Dec 3 09:07:00 2008 +0100
libwbclient: avoid usage talloc_init() in library code
talloc_init() is a compat function for the old samba3
non-hierachical talloc implementation. It enables
the talloc null tracking which should never be done
by library code.
metze
---
Summary of changes:
source3/nsswitch/libwbclient/wbc_sid.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/nsswitch/libwbclient/wbc_sid.c
b/source3/nsswitch/libwbclient/wbc_sid.c
index ac929b1..92de22e 100644
--- a/source3/nsswitch/libwbclient/wbc_sid.c
+++ b/source3/nsswitch/libwbclient/wbc_sid.c
@@ -40,22 +40,18 @@ wbcErr wbcSidToString(const struct wbcDomainSid *sid,
uint32_t id_auth;
int i;
char *tmp = NULL;
- TALLOC_CTX *ctx = NULL;
if (!sid) {
wbc_status = WBC_ERR_INVALID_SID;
BAIL_ON_WBC_ERROR(wbc_status);
}
- ctx = talloc_init(wbcSidToString);
- BAIL_ON_PTR_ERROR(ctx, wbc_status);
-
id_auth = sid-id_auth[5] +
(sid-id_auth[4] 8) +
(sid-id_auth[3] 16) +
(sid-id_auth[2] 24);
- tmp = talloc_asprintf(ctx, S-%d-%d, sid-sid_rev_num, id_auth);
+ tmp = talloc_asprintf(NULL, S-%d-%d, sid-sid_rev_num, id_auth);
BAIL_ON_PTR_ERROR(tmp, wbc_status);
for (i=0; isid-num_auths; i++) {
@@ -66,13 +62,13 @@ wbcErr wbcSidToString(const struct wbcDomainSid *sid,
tmp = tmp2;
}
- *sid_string=talloc_strdup(NULL, tmp);
- BAIL_ON_PTR_ERROR((*sid_string), wbc_status);
+ *sid_string = tmp;
+ tmp = NULL;
wbc_status = WBC_ERR_SUCCESS;
done:
- talloc_free(ctx);
+ talloc_free(tmp);
return wbc_status;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3222-gf84cbb1
The branch, v3-2-test has been updated
via f84cbb18a018d4c28fb98f00a38a7b7df48768c0 (commit)
from 1ba197a3054c6d997ceca6f124039d3cabf00289 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit f84cbb18a018d4c28fb98f00a38a7b7df48768c0
Author: Stefan Metzmacher [EMAIL PROTECTED]
Date: Wed Dec 3 09:07:00 2008 +0100
libwbclient: avoid usage talloc_init() in library code
talloc_init() is a compat function for the old samba3
non-hierachical talloc implementation. It enables
the talloc null tracking which should never be done
by library code.
metze
(cherry picked from commit afa0d6b0b14e0ef2293bd8468ffc1d6330abdb5b)
(cherry picked from commit 37a92ed0eb2c8cf7f3eac1d90ba5300cbce45186)
---
Summary of changes:
source/nsswitch/libwbclient/wbc_sid.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/nsswitch/libwbclient/wbc_sid.c
b/source/nsswitch/libwbclient/wbc_sid.c
index ca5eab4..4c6b039 100644
--- a/source/nsswitch/libwbclient/wbc_sid.c
+++ b/source/nsswitch/libwbclient/wbc_sid.c
@@ -40,22 +40,18 @@ wbcErr wbcSidToString(const struct wbcDomainSid *sid,
uint32_t id_auth;
int i;
char *tmp = NULL;
- TALLOC_CTX *ctx = NULL;
if (!sid) {
wbc_status = WBC_ERR_INVALID_SID;
BAIL_ON_WBC_ERROR(wbc_status);
}
- ctx = talloc_init(wbcSidToString);
- BAIL_ON_PTR_ERROR(ctx, wbc_status);
-
id_auth = sid-id_auth[5] +
(sid-id_auth[4] 8) +
(sid-id_auth[3] 16) +
(sid-id_auth[2] 24);
- tmp = talloc_asprintf(ctx, S-%d-%d, sid-sid_rev_num, id_auth);
+ tmp = talloc_asprintf(NULL, S-%d-%d, sid-sid_rev_num, id_auth);
BAIL_ON_PTR_ERROR(tmp, wbc_status);
for (i=0; isid-num_auths; i++) {
@@ -66,13 +62,13 @@ wbcErr wbcSidToString(const struct wbcDomainSid *sid,
tmp = tmp2;
}
- *sid_string=talloc_strdup(NULL, tmp);
- BAIL_ON_PTR_ERROR((*sid_string), wbc_status);
+ *sid_string = tmp;
+ tmp = NULL;
wbc_status = WBC_ERR_SUCCESS;
done:
- talloc_free(ctx);
+ talloc_free(tmp);
return wbc_status;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - fcbf88115c217cfe5090f8d60ab7627681c648c8
The branch, master has been updated
via fcbf88115c217cfe5090f8d60ab7627681c648c8 (commit)
from afa0d6b0b14e0ef2293bd8468ffc1d6330abdb5b (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit fcbf88115c217cfe5090f8d60ab7627681c648c8
Author: Stefan Metzmacher [EMAIL PROTECTED]
Date: Wed Dec 3 17:41:09 2008 +0100
s4: add some useful link and the patch for the ntp_signd support
metze
---
Summary of changes:
source4/ntp_signd/README |7 +
source4/ntp_signd/ntp-dev-4.2.5p125.diff | 579 ++
2 files changed, 586 insertions(+), 0 deletions(-)
create mode 100644 source4/ntp_signd/README
create mode 100644 source4/ntp_signd/ntp-dev-4.2.5p125.diff
Changeset truncated at 500 lines:
diff --git a/source4/ntp_signd/README b/source4/ntp_signd/README
new file mode 100644
index 000..585459b
--- /dev/null
+++ b/source4/ntp_signd/README
@@ -0,0 +1,7 @@
+Here are some pointers to the needed ntp version.
+
+https://support.ntp.org/bugs/show_bug.cgi?id=1028
+
+The patch against ntp-dev-4.2.5p125
+https://support.ntp.org/bugs/attachment.cgi?id=457
+
diff --git a/source4/ntp_signd/ntp-dev-4.2.5p125.diff
b/source4/ntp_signd/ntp-dev-4.2.5p125.diff
new file mode 100644
index 000..40669fb
--- /dev/null
+++ b/source4/ntp_signd/ntp-dev-4.2.5p125.diff
@@ -0,0 +1,579 @@
+Only in ntp-samba: autom4te.cache
+Only in ntp-samba: config.h
+Only in ntp-samba: config.log
+Only in ntp-samba: config.status
+Only in ntp-samba/ElectricFence: .deps
+Only in ntp-samba/ElectricFence: Makefile
+Only in ntp-samba: .gcc-warning
+Only in ntp-samba/include/isc: Makefile
+Only in ntp-samba/include: Makefile
+diff -ur ntp-dev-4.2.5p125/include/ntp_config.h ntp-samba/include/ntp_config.h
+--- ntp-dev-4.2.5p125/include/ntp_config.h 2008-07-17 07:20:58.0
+1000
ntp-samba/include/ntp_config.h 2008-08-28 21:59:06.0 +1000
+@@ -92,6 +92,7 @@
+ int requested_key;
+ int revoke;
+ queue *trusted_key_list;
++char *ntp_signd_socket;
+ };
+
+ struct filegen_node {
+diff -ur ntp-dev-4.2.5p125/include/ntpd.h ntp-samba/include/ntpd.h
+--- ntp-dev-4.2.5p125/include/ntpd.h 2008-05-18 21:11:28.0 +1000
ntp-samba/include/ntpd.h 2008-08-28 21:59:06.0 +1000
+@@ -259,6 +259,8 @@
+ extern intconfig_priority;
+ #endif
+
++extern char const *ntp_signd_socket;
++
+ /* ntp_control.c */
+ extern intnum_ctl_traps;
+ extern keyid_tctl_auth_keyid; /* keyid used for
authenticating write requests */
+@@ -471,3 +473,15 @@
+ extern struct refclock *refclock_conf[]; /* refclock configuration table */
+ extern u_char num_refclock_conf;
+ #endif
++
++/* ntp_signd.c */
++#ifdef HAVE_NTP_SIGND
++extern void
++send_via_ntp_signd(
++ struct recvbuf *rbufp, /* receive packet pointer */
++ int xmode,
++ keyid_t xkeyid,
++ int flags,
++ struct pkt *xpkt
++ );
++#endif
+diff -ur ntp-dev-4.2.5p125/include/ntp.h ntp-samba/include/ntp.h
+--- ntp-dev-4.2.5p125/include/ntp.h2008-08-10 22:37:56.0 +1000
ntp-samba/include/ntp.h2008-08-28 21:59:06.0 +1000
+@@ -447,6 +447,7 @@
+ #ifdefOPENSSL
+ #define FLAG_ASSOC0x4000 /* autokey request */
+ #endif /* OPENSSL */
++#define FLAG_ADKEY 0x0001 /* Authenticated (or wants reply to
be authenticated) using AD authentication */
+
+ /*
+ * Definitions for the clear() routine. We use memset() to clear
+Only in ntp-samba/include: ntp.h.orig
+Only in ntp-samba: libtool
+Only in ntp-samba: Makefile
+diff -ur ntp-dev-4.2.5p125/ntpd/Makefile.am ntp-samba/ntpd/Makefile.am
+--- ntp-dev-4.2.5p125/ntpd/Makefile.am 2008-05-18 21:11:29.0 +1000
ntp-samba/ntpd/Makefile.am 2008-08-28 21:59:06.0 +1000
+@@ -65,7 +65,7 @@
+ ntp_crypto.c ntp_filegen.c \
+ ntp_intres.c ntp_loopfilter.c ntp_monitor.c ntp_peer.c \
+ ntp_proto.c ntp_refclock.c ntp_request.c \
+- ntp_restrict.c ntp_timer.c ntp_util.c \
++ ntp_restrict.c ntp_timer.c ntp_util.c ntp_signd.c \
+ ppsapi_timepps.h \
+ refclock_acts.c refclock_arbiter.c refclock_arc.c refclock_as2201.c \
+ refclock_atom.c refclock_bancomm.c refclock_chronolog.c \
+diff -ur ntp-dev-4.2.5p125/ntpd/ntp_config.c ntp-samba/ntpd/ntp_config.c
+--- ntp-dev-4.2.5p125/ntpd/ntp_config.c2008-08-10 22:37:54.0
+1000
ntp-samba/ntpd/ntp_config.c2008-08-28 22:03:52.0 +1000
+@@ -148,6 +148,7 @@
+ #endif
+
+ const char *config_file;
++const char *ntp_signd_socket;
+ #ifdef HAVE_NETINFO
+ struct netinfo_config_state *config_netinfo = NULL;
+ int check_netinfo = 1;
+@@ -276,6 +277,11 @@
+ my_config.auth.crypto_cmd_list = NULL;
+ my_config.auth.keys = NULL;
+ my_config.auth.keysdir = NULL;
++#ifdef
[SCM] Samba Shared Repository - branch master updated - 1eb743ab8e8b1141f99fabd3e4a46895c6dcc17e
The branch, master has been updated
via 1eb743ab8e8b1141f99fabd3e4a46895c6dcc17e (commit)
from fcbf88115c217cfe5090f8d60ab7627681c648c8 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 1eb743ab8e8b1141f99fabd3e4a46895c6dcc17e
Author: Tim Prouty [EMAIL PROTECTED]
Date: Tue Dec 2 23:29:57 2008 -0800
s3: Change sockaddr util function names for consistency
Also eliminates name conflicts with OneFS system libraries
---
Summary of changes:
lib/util/util_net.c|2 +-
source3/client/client.c|2 +-
source3/include/proto.h|4 ++--
source3/lib/interface.c| 12 ++--
source3/lib/util_sock.c| 10 +-
source3/libads/kerberos.c |6 +++---
source3/libsmb/cliconnect.c|2 +-
source3/libsmb/clidfs.c|4 ++--
source3/libsmb/libsmb_server.c |6 +++---
source3/libsmb/namequery.c | 10 +-
source3/libsmb/namequery_dc.c |4 ++--
source3/rpcclient/rpcclient.c |2 +-
source3/torture/locktest.c |4 ++--
source3/torture/masktest.c |4 ++--
source3/torture/torture.c |2 +-
source3/utils/net.c|2 +-
source3/utils/smbcacls.c |2 +-
source3/utils/smbcquotas.c |2 +-
source3/utils/smbfilter.c |2 +-
source3/winbindd/winbindd_cm.c |2 +-
20 files changed, 42 insertions(+), 42 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/util/util_net.c b/lib/util/util_net.c
index 228393a..d1dadc2 100644
--- a/lib/util/util_net.c
+++ b/lib/util/util_net.c
@@ -360,7 +360,7 @@ bool same_net(const struct sockaddr *ip1,
* Are two sockaddr 's the same family and address ? Ignore port etc.
*/
-bool addr_equal(const struct sockaddr *ip1,
+bool sockaddr_equal(const struct sockaddr *ip1,
const struct sockaddr *ip2)
{
if (ip1-sa_family != ip2-sa_family) {
diff --git a/source3/client/client.c b/source3/client/client.c
index 39f8f90..da78916 100644
--- a/source3/client/client.c
+++ b/source3/client/client.c
@@ -4623,7 +4623,7 @@ static int do_message_op(void)
snprintf(name_type_hex, sizeof(name_type_hex), #%X, name_type);
fstrcat(server_name, name_type_hex);
-zero_addr(ss);
+zero_sockaddr(ss);
if (have_ip)
ss = dest_ss;
diff --git a/source3/include/proto.h b/source3/include/proto.h
index f2bbb07..d9430e2 100644
--- a/source3/include/proto.h
+++ b/source3/include/proto.h
@@ -1396,13 +1396,13 @@ bool is_loopback_ip_v4(struct in_addr ip);
bool is_loopback_addr(const struct sockaddr *pss);
bool is_zero_addr(const struct sockaddr *pss);
void zero_ip_v4(struct in_addr *ip);
-void zero_addr(struct sockaddr_storage *pss);
+void zero_sockaddr(struct sockaddr_storage *pss);
void in_addr_to_sockaddr_storage(struct sockaddr_storage *ss,
struct in_addr ip);
bool same_net(const struct sockaddr *ip1,
const struct sockaddr *ip2,
const struct sockaddr *mask);
-bool addr_equal(const struct sockaddr *ip1,
+bool sockaddr_equal(const struct sockaddr *ip1,
const struct sockaddr *ip2);
bool is_address_any(const struct sockaddr *psa);
uint16_t get_sockaddr_port(const struct sockaddr_storage *pss);
diff --git a/source3/lib/interface.c b/source3/lib/interface.c
index f533ec9..48fa4d3 100644
--- a/source3/lib/interface.c
+++ b/source3/lib/interface.c
@@ -33,7 +33,7 @@ bool ismyaddr(const struct sockaddr *ip)
{
struct interface *i;
for (i=local_interfaces;i;i=i-next) {
- if (addr_equal((struct sockaddr *)i-ip,ip)) {
+ if (sockaddr_equal((struct sockaddr *)i-ip,ip)) {
return true;
}
}
@@ -65,7 +65,7 @@ static struct interface *iface_find(const struct sockaddr *ip,
if (same_net(ip, (struct sockaddr *)i-ip, (struct
sockaddr *)i-netmask)) {
return i;
}
- } else if (addr_equal((struct sockaddr *)i-ip, ip)) {
+ } else if (sockaddr_equal((struct sockaddr *)i-ip, ip)) {
return i;
}
}
@@ -93,7 +93,7 @@ void setup_linklocal_scope_id(struct sockaddr *pss)
{
struct interface *i;
for (i=local_interfaces;i;i=i-next) {
- if (addr_equal((struct sockaddr *)i-ip,pss)) {
+ if (sockaddr_equal((struct sockaddr *)i-ip,pss)) {
struct sockaddr_in6 *psa6 =
(struct sockaddr_in6 *)pss;
psa6-sin6_scope_id = if_nametoindex(i-name);
@@ -388,7 +388,7 @@ static void interpret_interface(char *token)
}
for (i=0;itotal_probed;i++) {
-
[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3223-g10dd8a5
The branch, v3-2-test has been updated
via 10dd8a54ea7ea2cf86de5e20a62912298e0c4acc (commit)
from f84cbb18a018d4c28fb98f00a38a7b7df48768c0 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit 10dd8a54ea7ea2cf86de5e20a62912298e0c4acc
Author: Tim Prouty [EMAIL PROTECTED]
Date: Wed Dec 3 10:37:03 2008 -0800
Change sockaddr util function names for consistency and to eliminate name
conflicts
---
Summary of changes:
source/client/client.c|2 +-
source/lib/interface.c| 10 +-
source/lib/util_sock.c| 14 +++---
source/libads/kerberos.c |6 +++---
source/libsmb/cliconnect.c|2 +-
source/libsmb/clidfs.c|4 ++--
source/libsmb/libsmb_server.c |6 +++---
source/libsmb/namequery.c | 10 +-
source/libsmb/namequery_dc.c |4 ++--
source/rpcclient/rpcclient.c |2 +-
source/torture/locktest.c |4 ++--
source/torture/masktest.c |4 ++--
source/torture/torture.c |2 +-
source/utils/net.c|2 +-
source/utils/smbcacls.c |2 +-
source/utils/smbcquotas.c |2 +-
source/utils/smbfilter.c |2 +-
source/winbindd/winbindd_cm.c |2 +-
18 files changed, 40 insertions(+), 40 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/client/client.c b/source/client/client.c
index dc5e0f5..1954bef 100644
--- a/source/client/client.c
+++ b/source/client/client.c
@@ -4614,7 +4614,7 @@ static int do_message_op(void)
snprintf(name_type_hex, sizeof(name_type_hex), #%X, name_type);
fstrcat(server_name, name_type_hex);
-zero_addr(ss);
+zero_sockaddr(ss);
if (have_ip)
ss = dest_ss;
diff --git a/source/lib/interface.c b/source/lib/interface.c
index 2e7c270..15fed9e 100644
--- a/source/lib/interface.c
+++ b/source/lib/interface.c
@@ -33,7 +33,7 @@ bool ismyaddr(const struct sockaddr_storage *ip)
{
struct interface *i;
for (i=local_interfaces;i;i=i-next) {
- if (addr_equal(i-ip,ip)) {
+ if (sockaddr_equal(i-ip,ip)) {
return true;
}
}
@@ -65,7 +65,7 @@ static struct interface *iface_find(const struct
sockaddr_storage *ip,
if (same_net(ip, i-ip, i-netmask)) {
return i;
}
- } else if (addr_equal(i-ip, ip)) {
+ } else if (sockaddr_equal(i-ip, ip)) {
return i;
}
}
@@ -93,7 +93,7 @@ void setup_linklocal_scope_id(struct sockaddr_storage *pss)
{
struct interface *i;
for (i=local_interfaces;i;i=i-next) {
- if (addr_equal(i-ip,pss)) {
+ if (sockaddr_equal(i-ip,pss)) {
struct sockaddr_in6 *psa6 =
(struct sockaddr_in6 *)pss;
psa6-sin6_scope_id = if_nametoindex(i-name);
@@ -388,7 +388,7 @@ static void interpret_interface(char *token)
}
for (i=0;itotal_probed;i++) {
- if (addr_equal(ss, probed_ifaces[i].ip)) {
+ if (sockaddr_equal(ss, probed_ifaces[i].ip)) {
add_interface(probed_ifaces[i]);
return;
}
@@ -441,7 +441,7 @@ static void interpret_interface(char *token)
make_net(ss_net, ss, ss_mask);
/* Maybe the first component was a broadcast address. */
- if (addr_equal(ss_bcast, ss) || addr_equal(ss_net, ss)) {
+ if (sockaddr_equal(ss_bcast, ss) || sockaddr_equal(ss_net, ss)) {
for (i=0;itotal_probed;i++) {
if (same_net(ss, probed_ifaces[i].ip, ss_mask)) {
/* Temporarily replace netmask on
diff --git a/source/lib/util_sock.c b/source/lib/util_sock.c
index e20768e..e64b003 100644
--- a/source/lib/util_sock.c
+++ b/source/lib/util_sock.c
@@ -234,7 +234,7 @@ bool interpret_string_addr(struct sockaddr_storage *pss,
}
#endif
- zero_addr(pss);
+ zero_sockaddr(pss);
if (!interpret_string_addr_internal(res, str, flags|AI_ADDRCONFIG)) {
return false;
@@ -334,7 +334,7 @@ void zero_ip_v4(struct in_addr *ip)
Set an address to INADDR_ANY.
**/
-void zero_addr(struct sockaddr_storage *pss)
+void zero_sockaddr(struct sockaddr_storage *pss)
{
memset(pss, '\0', sizeof(*pss));
/* Ensure we're at least a valid sockaddr-storage. */
@@ -429,8 +429,8 @@ bool same_net(const struct sockaddr_storage *ip1,
Are two sockaddr_storage's the same family and address ? Ignore port etc.
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4591-gf2a3617
The branch, v3-3-test has been updated
via f2a3617778cab1695a09f065840907e1227b6d86 (commit)
from 37a92ed0eb2c8cf7f3eac1d90ba5300cbce45186 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -
commit f2a3617778cab1695a09f065840907e1227b6d86
Author: Tim Prouty [EMAIL PROTECTED]
Date: Wed Dec 3 10:37:03 2008 -0800
Change sockaddr util function names for consistency and to eliminate name
conflicts
---
Summary of changes:
source/client/client.c|2 +-
source/include/proto.h|4 ++--
source/lib/interface.c| 10 +-
source/lib/util_sock.c| 14 +++---
source/libads/kerberos.c |6 +++---
source/libsmb/cliconnect.c|2 +-
source/libsmb/clidfs.c|4 ++--
source/libsmb/libsmb_server.c |6 +++---
source/libsmb/namequery.c | 10 +-
source/libsmb/namequery_dc.c |4 ++--
source/rpcclient/rpcclient.c |2 +-
source/torture/locktest.c |4 ++--
source/torture/masktest.c |4 ++--
source/torture/torture.c |2 +-
source/utils/net.c|2 +-
source/utils/smbcacls.c |2 +-
source/utils/smbcquotas.c |2 +-
source/utils/smbfilter.c |2 +-
source/winbindd/winbindd_cm.c |2 +-
19 files changed, 42 insertions(+), 42 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/client/client.c b/source/client/client.c
index 3048d95..d05a82a 100644
--- a/source/client/client.c
+++ b/source/client/client.c
@@ -4615,7 +4615,7 @@ static int do_message_op(void)
snprintf(name_type_hex, sizeof(name_type_hex), #%X, name_type);
fstrcat(server_name, name_type_hex);
-zero_addr(ss);
+zero_sockaddr(ss);
if (have_ip)
ss = dest_ss;
diff --git a/source/include/proto.h b/source/include/proto.h
index 99e9d76..06130c4 100644
--- a/source/include/proto.h
+++ b/source/include/proto.h
@@ -1538,14 +1538,14 @@ bool is_loopback_addr(const struct sockaddr_storage
*pss);
bool is_zero_ip_v4(struct in_addr ip);
bool is_zero_addr(const struct sockaddr_storage *pss);
void zero_ip_v4(struct in_addr *ip);
-void zero_addr(struct sockaddr_storage *pss);
+void zero_sockaddr(struct sockaddr_storage *pss);
bool same_net_v4(struct in_addr ip1,struct in_addr ip2,struct in_addr mask);
void in_addr_to_sockaddr_storage(struct sockaddr_storage *ss,
struct in_addr ip);
bool same_net(const struct sockaddr_storage *ip1,
const struct sockaddr_storage *ip2,
const struct sockaddr_storage *mask);
-bool addr_equal(const struct sockaddr_storage *ip1,
+bool sockaddr_equal(const struct sockaddr_storage *ip1,
const struct sockaddr_storage *ip2);
bool is_address_any(const struct sockaddr_storage *psa);
uint16_t get_sockaddr_port(const struct sockaddr_storage *pss);
diff --git a/source/lib/interface.c b/source/lib/interface.c
index 2e7c270..15fed9e 100644
--- a/source/lib/interface.c
+++ b/source/lib/interface.c
@@ -33,7 +33,7 @@ bool ismyaddr(const struct sockaddr_storage *ip)
{
struct interface *i;
for (i=local_interfaces;i;i=i-next) {
- if (addr_equal(i-ip,ip)) {
+ if (sockaddr_equal(i-ip,ip)) {
return true;
}
}
@@ -65,7 +65,7 @@ static struct interface *iface_find(const struct
sockaddr_storage *ip,
if (same_net(ip, i-ip, i-netmask)) {
return i;
}
- } else if (addr_equal(i-ip, ip)) {
+ } else if (sockaddr_equal(i-ip, ip)) {
return i;
}
}
@@ -93,7 +93,7 @@ void setup_linklocal_scope_id(struct sockaddr_storage *pss)
{
struct interface *i;
for (i=local_interfaces;i;i=i-next) {
- if (addr_equal(i-ip,pss)) {
+ if (sockaddr_equal(i-ip,pss)) {
struct sockaddr_in6 *psa6 =
(struct sockaddr_in6 *)pss;
psa6-sin6_scope_id = if_nametoindex(i-name);
@@ -388,7 +388,7 @@ static void interpret_interface(char *token)
}
for (i=0;itotal_probed;i++) {
- if (addr_equal(ss, probed_ifaces[i].ip)) {
+ if (sockaddr_equal(ss, probed_ifaces[i].ip)) {
add_interface(probed_ifaces[i]);
return;
}
@@ -441,7 +441,7 @@ static void interpret_interface(char *token)
make_net(ss_net, ss, ss_mask);
/* Maybe the first component was a broadcast address. */
- if (addr_equal(ss_bcast, ss) || addr_equal(ss_net, ss)) {
+ if (sockaddr_equal(ss_bcast, ss) ||
Build status as of Thu Dec 4 00:00:01 2008
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2008-12-03 00:00:32.0 + +++ /home/build/master/cache/broken_results.txt 2008-12-04 00:00:08.0 + @@ -1,4 +1,4 @@ -Build status as of Wed Dec 3 00:00:02 2008 +Build status as of Thu Dec 4 00:00:01 2008 Build counts: Tree Total Broken Panic @@ -6,17 +6,17 @@ ccache 29 7 0 ctdb 0 0 0 distcc 1 0 0 -ldb 28 29 0 -libreplace 26 10 0 +ldb 29 29 0 +libreplace 27 10 0 lorikeet-heimdal 26 18 0 pidl 17 2 0 ppp 12 0 0 -rsync29 11 0 +rsync28 11 0 samba-docs 0 0 0 -samba-gtk4 5 0 -samba_3_X_devel 27 20 1 +samba-gtk5 5 0 +samba_3_X_devel 27 21 1 samba_3_X_test 27 19 0 -samba_4_0_test 26 26 1 +samba_4_0_test 28 25 1 smb-build27 6 0 talloc 29 29 0 tdb 27 9 0
[SCM] Samba Shared Repository - branch master updated - dbfcd3f97c02a19c48360b4f477570997f8aa870
The branch, master has been updated via dbfcd3f97c02a19c48360b4f477570997f8aa870 (commit) via 58440122853b65048793efd90ee45916e25c08c1 (commit) via f79aae70dd10877311243b5b2a55e1f130bd54b6 (commit) via 6f7f4b428a86921e9532c62856873a19202f286d (commit) via 08ce0604757315367f26a2c0869d59dd229c3ffe (commit) via 2caa4fe08e157a01012b425a68cc25c381d5f354 (commit) via 61b4597e3c9016b3fdd540857abf3b72963ad4b2 (commit) via f995a7af2a06ccff29f23f1b099e0a84bc948f6e (commit) via f38d7f20a865b1ff5f7b039dd284d91b2ba7ec26 (commit) from 1eb743ab8e8b1141f99fabd3e4a46895c6dcc17e (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit dbfcd3f97c02a19c48360b4f477570997f8aa870 Author: Tim Prouty [EMAIL PROTECTED] Date: Mon Dec 1 14:13:14 2008 -0800 s3: Fix FILE_FLAG_POSIX_SEMANTICS handling underneath SMB_VFS_CREATE_FILE commit 58440122853b65048793efd90ee45916e25c08c1 Author: Tim Prouty [EMAIL PROTECTED] Date: Mon Dec 1 12:47:31 2008 -0800 s3: Change SMB_VFS_CREATE_FILE to take a create_file_flags argument This replaces the is_dos_path bool with a more future-proof argument. The next step is to plumb INTERNAL_OPEN_ONLY through this flag instead of overridding the oplock_request. commit f79aae70dd10877311243b5b2a55e1f130bd54b6 Author: Tim Prouty [EMAIL PROTECTED] Date: Sat Nov 22 19:40:09 2008 -0800 s3: Simplify the create_file_unix_path-open_file_ntcreate path Also removed open_file_ntcreate/open_file from proto.h so they can no longer be called directly. commit 6f7f4b428a86921e9532c62856873a19202f286d Author: Tim Prouty [EMAIL PROTECTED] Date: Sat Nov 22 19:37:24 2008 -0800 s3: Modify direct caller of open_file to call SMB_VFS_CREATE_FILE commit 08ce0604757315367f26a2c0869d59dd229c3ffe Author: Tim Prouty [EMAIL PROTECTED] Date: Thu Nov 20 18:55:24 2008 -0800 s3: Modify direct callers of open_file_ntcreate and open_directory to call SMB_VFS_CREATE_FILE commit 2caa4fe08e157a01012b425a68cc25c381d5f354 Author: Tim Prouty [EMAIL PROTECTED] Date: Wed Nov 19 18:03:27 2008 -0800 s3: Modify direct callers of create_file_unix_path to call SMB_VFS_CREATE_FILE commit 61b4597e3c9016b3fdd540857abf3b72963ad4b2 Author: Tim Prouty [EMAIL PROTECTED] Date: Sun Nov 23 14:37:37 2008 -0800 s3: Add SMB_VFS_CREATE_FILE to vfs_full_audit module commit f995a7af2a06ccff29f23f1b099e0a84bc948f6e Author: Tim Prouty [EMAIL PROTECTED] Date: Wed Nov 19 17:55:28 2008 -0800 s3: Add new is_dos_path argument to SMB_VFS_CREATE_FILE Now unix paths can be differentiated from windows paths so the underlying create_file implementations can convert paths correctly. commit f38d7f20a865b1ff5f7b039dd284d91b2ba7ec26 Author: Tim Prouty [EMAIL PROTECTED] Date: Mon Oct 20 17:43:45 2008 -0700 s3: Add SMB_VFS_CREATE_FILE to the vfs layer Modify all callers of create_file to go through SMB_VFS_CREATE_FILE --- Summary of changes: source3/include/proto.h| 75 +++--- source3/include/smb.h |5 + source3/include/vfs.h | 22 +++ source3/include/vfs_macros.h |3 + source3/modules/vfs_default.c | 28 source3/modules/vfs_full_audit.c | 64 source3/printing/nt_printing.c | 78 +++--- source3/rpc_server/srv_srvsvc_nt.c |6 +- source3/smbd/nttrans.c | 98 ++--- source3/smbd/open.c| 283 ++-- source3/smbd/posix_acls.c | 29 +++-- source3/smbd/reply.c | 259 source3/smbd/trans2.c | 195 +++-- 13 files changed, 709 insertions(+), 436 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/include/proto.h b/source3/include/proto.h index d9430e2..63fe4d4 100644 --- a/source3/include/proto.h +++ b/source3/include/proto.h @@ -8100,73 +8100,34 @@ bool map_open_params_to_ntcreate(const char *fname, int deny_mode, int open_func uint32 *pshare_mode, uint32 *pcreate_disposition, uint32 *pcreate_options); -NTSTATUS open_file_ntcreate(connection_struct *conn, - struct smb_request *req, - const char *fname, - SMB_STRUCT_STAT *psbuf, - uint32 access_mask, /* access bits (FILE_READ_DATA etc.) */ - uint32 share_access,/* share constants (FILE_SHARE_READ etc) */ - uint32 create_disposition, /* FILE_OPEN_IF etc. */ - uint32 create_options, /* options such as delete on close.
[SCM] CTDB repository - branch master updated - ctdb-1.0.65-17-gaeb09b0
The branch, master has been updated
via aeb09b08e060be6f833d84ba88abfb168cc5f50e (commit)
via 194abb41e1a0036956a9401efcae8b14ed66c532 (commit)
from 979e78cfd96d74686af6f55f726c395a75275803 (commit)
http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=master
- Log -
commit aeb09b08e060be6f833d84ba88abfb168cc5f50e
Author: root [EMAIL PROTECTED]
Date: Thu Dec 4 15:03:40 2008 +1100
fix an incorrect path
commit 194abb41e1a0036956a9401efcae8b14ed66c532
Author: Ronnie Sahlberg [EMAIL PROTECTED]
Date: Thu Dec 4 14:35:00 2008 +1100
add a description of the recovery-process
---
Summary of changes:
Makefile.in |1 +
doc/recovery-process.txt | 484 ++
packaging/RPM/ctdb.spec |1 +
3 files changed, 486 insertions(+), 0 deletions(-)
create mode 100644 doc/recovery-process.txt
Changeset truncated at 500 lines:
diff --git a/Makefile.in b/Makefile.in
index 779bd8b..f7b4fb9 100755
--- a/Makefile.in
+++ b/Makefile.in
@@ -187,6 +187,7 @@ install: all
${INSTALLCMD} -m 644 config/functions $(DESTDIR)$(etcdir)/ctdb
${INSTALLCMD} -m 755 config/statd-callout $(DESTDIR)$(etcdir)/ctdb
${INSTALLCMD} -m 644 config/events.d/README
$(DESTDIR)/$(docdir)/ctdb/README.eventscripts
+ ${INSTALLCMD} -m 644 doc/recovery-process.txt
$(DESTDIR)/$(docdir)/ctdb/recovery-process.txt
${INSTALLCMD} -m 755 config/events.d/00.ctdb
$(DESTDIR)$(etcdir)/ctdb/events.d
${INSTALLCMD} -m 755 config/events.d/10.interface
$(DESTDIR)$(etcdir)/ctdb/events.d
${INSTALLCMD} -m 755 config/events.d/20.multipathd
$(DESTDIR)$(etcdir)/ctdb/events.d
diff --git a/doc/recovery-process.txt b/doc/recovery-process.txt
new file mode 100644
index 000..d0294a3
--- /dev/null
+++ b/doc/recovery-process.txt
@@ -0,0 +1,484 @@
+Valid as of 1.0.66, may/will change in the future
+
+
+RECMASTER
+=
+Recovery Master, this is one of the nodes in the cluster that has been
designated to
+be the recovery master.
+The recovery master is responsible for performing full checks of cluster and
cluster node consistency and is also responsible for performing the actual
database recovery procedure.
+
+Only one node at a time can be the recovery master.
+This is ensured by CTDB using a lock on a single file in the shared gpfs
filesystem:
+ /etc/sysconfig/ctdb :
+ ...
+ # Options to ctdbd. This is read by /etc/init.d/ctdb
+ # you must specify the location of a shared lock file across all the
+ # nodes. This must be on shared storage
+ # there is no default here
+ CTDB_RECOVERY_LOCK=/gpfs/.ctdb/shared
+ ...
+
+In order to prevent that two nodes become recovery master at the same time
(==split brain)
+CTDB here relies on GPFS that GPFS will guarantee coherent locking across the
cluster.
+Thus CTDB relies on that GPFS MUST only allow one ctdb process on one node to
take out and
+hold this lock.
+
+The recovery master is designated through an election process.
+
+
+VNNMAP
+==
+The VNNMAP is a list of all nodes in the cluster that is currently part of the
cluster
+and participates in hosting the cluster databases.
+All nodes that are CONNECTED but not BANNED be present in the VNNMAP.
+
+The VNNMAP is the list of LMASTERS for the cluster as reported by 'ctdb
status'
+ ...
+ Size:3
+ hash:0 lmaster:0
+ hash:1 lmaster:1
+ hash:2 lmaster:2
+ ...
+
+
+CLUSTER MONITORING
+==
+All nodes in the cluster monitor its own health and its own consistency
regards to the
+recovery master. How and what the nodes monitor for differs between the node
which is
+the recovery master and normal nodes.
+This monitoring it to ensure that the cluster is healthy and consistent.
+This is not related to monitoring of inidividual node health, a.k.a.
eventscript monitroing.
+
+At the end of each step in the process are listed some of the most common and
important
+error messages that can be generated during that step.
+
+
+NORMAL NODE CLUSTER MONITORING
+--
+Monitoring is performed in the dedicated recovery daemon process.
+The implementation can be found in server/ctdb_recoverd.c:monitor_cluster()
+This is an overview of the more important tasks during monitoring.
+These tests are to verify that the local node is consistent with the recovery
master.
+
+Once every second the following monitoring loop is performed :
+
+1, Verify that the parent ctdb daemon on the local node is still running.
+ If it is not, the recovery daemon logs an error and terminates.
+ CTDB daemon is no longer available. Shutting down recovery daemon
+
+2, Check if any of the nodes has been recorded to have misbehaved too many
times.
+ If so we ban the node and log a message :
+ Node %u has caused %u failures in %.0f seconds - banning it for %u seconds
+
+3,
