Re: [Samba] getent acting unreliable with idmap_ad
Hi Robert, thanks for your reply. On Fri, 2010-07-30 at 17:45 +0200, Robert Grasso wrote: Hello, I personally solved my stability issues when, rather than letting Samba find automatically the AD servers, I stated them clearly : - I stated clearly my password server = in smb.conf I already list my servers in password server =, altough I do have the impression that Samba may have problems with my 2008R2 servers. I'll try playing with the settings. - I stated clearly my /etc/krb5.conf Do you mean fill in /etc/krb5.conf properly or should I refer to it somewhere in the smb.conf file? I'm sure my krb5.conf is correct is I was using it in my old setup using kerberos+ldap authentication. I found some reference on the Internet to an smb.conf variable use kerberos keytab = yes however this doesn't seem to be accepted for Samba 3.4.7 I am running on CentOS 5.5, samba 3.0.33. Apart from that : I have installed SFU on my Windows 2003 AD servers; to me, it seems that getent passwd username yields a result for the accounts which have an Unix account declared in AD through the Unix attributes, and only for these ones (?). I think that's expected behaviour. idmap_ad looks upo uid/gid from AD but doesn't create its own mapping if it doesn't find one. So any user that doesn't have a proper unix uid/gid field won't show up. I also noticed idmap_ad looks at the Windows Primary Group as gid in stead of the group field on the unix tab. Therefor the Windows Primary Group also needs to have a valid unix id assigned. Nico -- With kind regards Nico De Ranter Senior System Administrator Techsoft Centre Technology and Software Centre Europe The Corporate Village - Da Vincilaan 7-D1 - B-1935 Zaventem - Belgium Phone:+32 (0)2 700 8641 Fax: +32 (0)2 700 8622 E-mail:nico.deran...@eu.sony.com A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 - RPR Brussels Fortis - BIC GEBABEBB - IBAN BE41293037680010 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] mounting as cifs not working in Debian, works in Windows though
H.S. [mailto:hs.sa...@gmail.com] wrote: On 30/07/10 05:02 AM, Moray Henderson wrote: H.S. [mailto:hs.sa...@gmail.com] wrote: I have a Debian machine running Unstable acting as a samba server. The server was installed a few days ago after a reinstall of the OS. The older installation's samba configs were backed up and restored after installation. The Samba shares are accessible if I access them from a Windows 7 client. The shares, however, cannot be accessed from a Debian client (newly installed amd64 Testing). The error I get from the Debian client SNIP What am I missing here? Things to check: Rather than mounting, can you use smbclient to access the share? Do you see any better errors in the logs of either client or server? Is client running SELinux or equivalent? I can browse the shares via dolphin in KDE. I can use smbclient and it appears to work: $ smbclient -L //192.168.0.8 -U hs Enter hs's password: Domain=[SMBWG] OS=[Unix] Server=[Samba 3.4.8] Sharename Type Comment - --- print$ Disk Printer Drivers PicturesDisk Pictures Repository IPC$IPC IPC Service (red server) hs Disk Home Directories Domain=[SMBWG] OS=[Unix] Server=[Samba 3.4.8] Server Comment ---- RED red server Workgroup Master ---- SMBWG red No, there is no selinux running on samba server. The server's log also do not show anything abnormal. I get info regarding the smbclient stuff, but no info regarding the error 13 that cifs mounting is giving me. How about SELinux on the client - that may deny permission for remote mounts if the mount point has the wrong context. Can you mount other filesystems (USB stick, for example) via sudo? Your original example said: ~$ sudo mount -v -t cifs -o user=username //sambaserver/Share ~/mnt/Share Password: username's password here mount.cifs kernel mount options: ip=192.168.0.8,unc=//sambaserver/Share,,ver=1,user=username,pass= *** * mount error(13): Permission denied Was mount.cifs picking up the correct password there? Can you sudo to a shell, and give the mount command with all the options on the command line? Moray. To err is human. To purr, feline -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Must restart nmbd to connect
Hello I'm seeing this issue when connecting from XPSP3 to Ubuntu 10.04 running Samba 3.4.7 installed through apt-get: After booting Ubuntu, if I try to connect to a share from XP, I get this error: === C:\net use x: \\linux\www /user:me System error 59 has occurred. An unexpected network error occurred. === When I run ps aux, I notice that for some reason, smbd is running two processes (status = S and Ss): === root 762 0.0 0.4 15328 3980 ?Ss 10:39 0:00 smbd -F root 833 0.0 0.1 15328 1176 ?S10:39 0:00 smbd -F root 944 0.0 0.1 8660 1644 ?Ss 10:39 0:00 nmbd -D === I can connect successfully if I restart nmbd: === # /etc/init.d/nmbd restart === But then, nmbd is also running two processes :-/ FYI, Ubuntu uses runlevel N 2, and /etc/rc2.d/ only contains one link to nmbd and smbd each. Has someone seen this problem? Thank you. PS: FWIW, here's my dead-simple smb.conf: === [global] workgroup = WORKGROUP netbios name = LINUX server string = Samba Server %v security = user log level = 3 [www] comment = WWW directory path = /var/www browsable = yes read only = no available = yes public = yes writable = yes create mask = 0644 === -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Must restart nmbd to connect
On Mon, 02 Aug 2010 11:21:13 +0200, Gilles gilles.gana...@free.fr wrote: After booting Ubuntu, if I try to connect to a share from XP, I get this error: === C:\net use x: \\linux\www /user:me System error 59 has occurred. An unexpected network error occurred. === When I run the command after rebooting Ubuntu, nothing shows up /var/log/samba/log.smbd, but here's what it says in log.nmbd: [2010/08/02 11:47:30, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name LINUX20 [2010/08/02 11:47:30, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name LINUX00 [2010/08/02 11:47:31, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name LINUX20 [2010/08/02 11:47:31, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name LINUX00 [2010/08/02 11:47:32, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name LINUX20 [2010/08/02 11:47:32, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name LINUX00 [2010/08/02 11:47:33, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name LINUX00 [2010/08/02 11:47:33, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name WWW.00 [2010/08/02 11:47:33, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name LINUX00 [2010/08/02 11:47:34, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name WWW.00 [2010/08/02 11:47:34, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name LINUX00 [2010/08/02 11:47:34, 3] nmbd/nmbd_incomingrequests.c:453(process_name_query_request) process_name_query_request: Name query from 192.168.0.1 on subnet 192.168.0.3 for name WWW.00 Does someone understand what's going on? Thanks. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] wbinfo -u and -g work, wbinfo -s works only for some users
Well, I still had problem running your script - didn't quite know how to specify the server and other parameters... But it was a starting point - it lead me to install latest 'smbldap-tools' and using those I added a 'test' user. Then I compared LDAP entires of newly created user to old users and noticed, that old users are missing a couple of 'objectClass' statements: objectClass: inetOrgPerson objectClass: posixAccount objectClass: sambaSamAccount objectClass: shadowAccount vs. objectClass: top objectClass: person objectClass: organizationalPerson objectClass: inetOrgPerson objectClass: posixAccount objectClass: shadowAccount objectClass: sambaSamAccount I added missing objectClass-es to all users and as it seems everything works well now. Thanks, Danilo PS: I guess I'll have to update the LDAP Account Manager too... On 27. 07. 2010 15:16, Jason Gerfen wrote: My apologies... Here is a working copy as an attachment. I will also fix the blog post I have up about it. Keep in mind it does require a couple of tools installed to function properly. i.e. wbinfo ldapsearch ldapmodify Also a note on how it works. It uses wbinfo to detect any account in active directory which does not have the unix extension properties for the uid,gid,default shell, homedir, as well as any DN attribute which uses first name last name, (DN=first last,CN=Users) which seems to cause problems with the UID 2 SID verification process, and modifies only those accounts. Using 'wizard' mode will allow you to test it on one account and once that works you can specify a OU within Active Directory and this will perform the operations on any account which fails the UID 2 SID verification. Let me know if you experience any problems with it. On 07/27/10 02:29, Danilo Godec wrote: While my situation is a bit different (no AD server, Samba is PDC for the domain, using OpenLDAP for users, groups, ...), I tried running your Perl script in 'Wizard' mode, but it fails (using perl 5.8.3): # ./UID2SID.pl syntax error at ./UID2SID.pl line 204, near = ; syntax error at ./UID2SID.pl line 239, near = ; syntax error at ./UID2SID.pl line 380, near = ; syntax error at ./UID2SID.pl line 404, near = ) syntax error at ./UID2SID.pl line 410, near } Execution of ./UID2SID.pl aborted due to compilation errors. Regards, Danilo On 26. 07. 2010 15:54, Jason Gerfen wrote: Here is a document and perl script I developed to resolve UID to SID mappings in Samba Active Directory authentication. http://zerointeger.tumblr.com/post/589762841/samba-and-active-directory Let me know if that helps any. On 07/26/10 07:01, Danilo Godec wrote: Got a problem after upgrading Samba from 3.0 to 3.5 - have a bunch of users and groups in LDAP and things work for the most part. However, when people try to change permissions from within Windows, some usernames or groupnames are shown properly, but other are not - they see the SID. Following up I noticed, that I can get a list of all users with 'wbinfo -u' and that I can get a SID for every user with 'wbinfo -n $USER'. However, for about 70% of all SIDs listed a 'reverse lookup' with 'wbinf -s $SID' doesn't work: S-1-5-21-239950015-4237961228-1280988766-3060 Could not lookup sid S-1-5-21-239950015-4237961228-1280988766-3060 It works for some and it turns out that this relates to what usernames are visible in Windows... I checked my LDAP and compared some of the users that work to some of those that don't, but there are no apparent differences. Any ideas? Regards, Danilo -- Danilo Godec, sistemska podpora / system administration Predlog! Obiscite prenovljeno spletno stran www.agenda.si ODPRTA KODA IN LINUX STORITVE : POSLOVNE RESITVE : UPRAVLJANJE IT : INFRASTRUKTURA IT : IZOBRAZEVANJE : PROGRAMSKA OPREMA Visit our updated web page at www.agenda.si OPEN SOURCE AND LINUX SERVICES : BUSINESS SOLUTIONS : IT MANAGEMENT : IT INFRASTRUCTURE : TRAINING : SOFTWARE -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] getent acting unreliable with idmap_ad
Hi Robert, On Mon, 2010-08-02 at 11:32 +0200, Robert Grasso wrote: Hello Nico, I am unsure I will be able to help you further with this topic, I am not a Samba nor AD master ... Thanks for trying anyway. Very much appreciated :-) I already list my servers in password server =, altough I do have the impression that Samba may have problems with my 2008R2 servers. I'll try playing with the settings. I cannot tell for 2008R2, we don't have this version yet ... - I stated clearly my /etc/krb5.conf Do you mean fill in /etc/krb5.conf properly or should I refer to it somewhere in the smb.conf file? I'm sure my krb5.conf is correct is I was using it in my old setup using kerberos+ldap authentication. I found some reference on the Internet to an smb.conf variable use kerberos keytab = yes however this doesn't seem to be accepted for Samba 3.4.7 I just filled it up properly, but did not mention Kerberos in any way in smb.conf Doh, that's what I have too. Any chance you could send me a copy of your smb.conf? Nico -- With kind regards Nico De Ranter Senior System Administrator Techsoft Centre Technology and Software Centre Europe The Corporate Village - Da Vincilaan 7-D1 - B-1935 Zaventem - Belgium Phone:+32 (0)2 700 8641 Fax: +32 (0)2 700 8622 E-mail:nico.deran...@eu.sony.com A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 - RPR Brussels Fortis - BIC GEBABEBB - IBAN BE41293037680010 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] printer Advanced tab grayed
The command groups DOMAIN\myADaccount will give you the groups of which 'myADaccount' is a member. 'domain admins' needs to be one of them if that account is to grant rights. Dale On 08/02/2010 2:44 AM, Frédéric SOSSON wrote: User myADaccount has full rights on domain\user is it enough to grant SePrintOperatorPrivilege ? 2010/7/30 Dale Schroederd...@briannassaladdressing.com: Is 'myADaccount' a domain admin capable of granting rights? Perhaps give us the global section of your smb.conf. I have no experience with win2008, so if that's the problem, I have nothing to offer there. Dale On 07/30/2010 4:54 AM, Frédéric SOSSON wrote: Hi, when I try run # net -S myDC -U myADaccount rpc rights grant 'domain\user' SePrintOperatorPrivilege Password I got Failed to grant privileges for domain\user (NT_STATUS_INVALID_PARAMETER) My domain controller is Windows2008R2 (windows 2000 domain runlevel) any idea? regards, 2010/7/29 Dale Schroederd...@briannassaladdressing.com: See SePrintOperatorPrivilege in: http://www.samba.org/samba/docs/man/Samba-HOWTO-Collection/rights.html Dale On 07/29/2010 9:35 AM, Frédéric SOSSON wrote: Hello, I would like to upload windows printer driver to my Samba through the printer Advanced tab as described in that doc http://www.samba.org/samba/docs/man/Samba-Guide/happy.html#id2582657 but this tab is totally grayed. I can imagine it's a permission issue but I'm not sure at all. Any idea, Frederic -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] HOWTO centOS 5.5 samba4 dns dynamic update/Replication
Dear all, after the feedbacks. I renew this HOWTO with replacation of a second SAMBA 4 PDC. We have 2 CentOS 5.5 servers on which we build a SAMBA4 forest with 2 Servers replication. We have one hosts called node1 and the second node2 Step1: On node1: Do not install the named coming with CentOs. This version can not do dns updates Install needs for samba. yum install libacl* libbb* gnutls* readline* python* gdb* autoconf* . Named installation: Here is a description on what to do: http://jason.roysdon.net/2009/10/16/building-bind-9-6-on-rhel5-centos5-for-d nssec-nsec3-support/ . The steps, yum -y install make gcc rpm-build libtool openssl-devel libcap-devel libidn-devel libxml2-devel openldap-devel postgresql-devel sqlite-devel mysql-devel krb5-devel xmlto . For named to compile correctly you need this 2 packages too: yum -y install curl* . You need python-dns-1.7.1-1.el5.noarch.rpm. You find it here:download.fedora.redhat.com/pub/fedora/epel/5/i386/python-dns-1.7.1-1.el 5.noarch.rpm. Download it and make a, rpm -ivh python-dns-1.7.1-1.el5.noarch.rpm. cd /usr/src/redhat/SRPMS. wget -c ftp://mirrors.kernel.org/pub/fedora/updates/12/SRPMS/bind-9.6.*.src. rpm. wget -c ftp://mirrors.kernel.org/pub/fedora/releases/12/Fedora/source/SRPMS/dnssec-c onf-*.src.rpm. rpm -ivh --nomd5 bind-9.6.*.src.rpm dnssec-conf-*.src.rpm. cd /usr/src/redhat/SPECS. rpmbuild -ba ./bind.spec. The built bind RPM is now in /usr/src/redhat/RPMS/i386/ or /usr/src/redhat/RPMS/x86_64/ depending on your Arch. rpmbuild --ba ./dnssec-conf.spec . The built dnssec-conf RPM is now in /usr/src/redhat/RPMS/noarch/. cd /usr/src/redhat/RPMS/*86*. rpm -Uvh bind-9.6.*.rpm bind-utils-9.6.*.rpm bind-libs-9.6.*.rpm ../noarch/dnssec-conf-1.21-*.noarch.rpm. Now bind is installed Config-File in /etc/named.conf I disabled in options: //dnssec-enable yes; //dnssec-validation yes; //dnssec-lookaside . trust-anchor dlv.isc.org.; Because I did not need them. To make bind work you have to add user named to the group named (To avoid this you can add the user named and group named before you compile named!!!). Set the rights to make named work correctly: chmod 770 /etc/named.conf. chmod 770 /etc/named.rfc1912.zones. chown root:named /etc/named.conf. chown named:named /etc/named.rfc1912.zones. chmod -R 770 /var/named. chown -R named:named /var/named. chown named:named /etc/rndc.key. chown named:named /var/run/named/. Now download and install samba: url: http://wiki.samba.org/index.php/Samba4/HOWTO. mkdir samba4. cd samba4. rsync -avz samba.org::ftp/unpacked/samba_4_0_test/ . cd /source4. ./autogen.sh . ./configure.devloper . Make . make install . Samba4 is now installed in /usr/local/samba . Provision it: cd /samba4/source4 . ./setup/provision --realm=samdom.example.com --domain=SAMDOM --adminpass=SOMEPASSWORD --server-role='domain controller' . In my case: ./setup/provision --realm=tuebingen.tst.loc --domain=TUEBINGEN--adminpass=SOMEPASSWORD --server-role='domain controller' . Now you nedd to add the PATH to roots .bash_profile in /root: -- PATH=$PATH:$HOME/bin:/usr/local/samba/bin:/usr/local/samba/sbin . which samba must answer: /usr/local/samba/sbin/samba Now you must set the lib paths: echo /usr/local/samba/lib /etc/ld.so.conf.d/samba4.conf. Then: type ldconfig . The next things to do( named should have read and write) : Cd /usr/local/samba/private . Chown named:named krb5.conf . Chown -R named:named /usr/local/samba/private/dns. Chown named:named named.conf . Chown named:named named.conf.update . Chown named:named dns.keytab . Cp krb5.conf /etc # this will overwrite the org. krb5.conf. cd /etc/sysconfig . Vi named There add a line at the bootom: KEYTAB_FILE=/usr/local/samba/private/dns.keytab. export KEYTAB_FILE. Now you must update your /etc/named.conf , Be sure to have em listen on a IP not only 127.0.0.1: Here is mine: options { listen-on port 53 { 127.0.0.1;192.168.134.27; };# --- ip of the samba4 server listen-on-v6 port 53 { ::1; }; directory /var/named; dump-file /var/named/data/cache_dump.db; statistics-file /var/named/data/named_stats.txt; memstatistics-file /var/named/data/named_mem_stats.txt; allow-query { localhost;allyoursubnetshere; }; #---do not forget to list your subnets here. recursion yes; forwarders { 192.168.134.253; };##put here your first dns if you have }; logging { channel default_debug { file data/named.run; severity dynamic; }; }; zone . IN { type hint; file named.ca; }; include /usr/local/samba/private/named.conf;samba4 link include /etc/named.rfc1912.zones; In your /etc/resolv.conf you have one single entry: → nameserver localhost Now you have to put in your globals /usr/local/smba/etc/smb.conf Interfaces=eth0 Now samba -I -M single And you are done!!! Samba_dnsupdate --verbose will give you: [r...@node1 etc]#
Re: [Samba] Kerberos: Principal may not act as server ERROR
Just bumping up to see if anyone else has seen this issue. Also noticed following errors in samba log. Wonder if these are related? Failed to modify SPNs on CN=NODE1-LIME,CN=Computers,DC=sambalime,DC=stratus,DC=com: error in module acl: insufficient access rights (50) ldb_wrap open of sam.ldb Failed to modify SPNs on CN=NODE1-LIME,CN=Computers,DC=sambalime,DC=stratus,DC=com: error in module acl: insufficient access rights (50) added interface ip=10.90.0.71 nmask=255.255.255.0 ldb_wrap open of sam.ldb Failed to modify SPNs on CN=NODE1-LIME,CN=Computers,DC=sambalime,DC=stratus,DC=com: error in module acl: insufficient access rights (50) ldb_wrap open of sam.ldb Failed to modify SPNs on CN=NODE1-LIME,CN=Computers,DC=sambalime,DC=stratus,DC=com: error in module acl: insufficient access rights (50) added interface ip=10.90.0.71 nmask=255.255.255.0 ldb_wrap open of sam.ldb Failed to modify SPNs on CN=NODE1-LIME,CN=Computers,DC=sambalime,DC=stratus,DC=com: error in module acl: insufficient access rights (50) ipv4:10.90.0.88:49232 closed connection to service IPC$ -Ajay -Original Message- From: samba-boun...@lists.samba.org [mailto:samba-boun...@lists.samba.org] On Behalf Of Aggarwal, Ajay Sent: Thursday, July 29, 2010 12:55 PM To: samba@lists.samba.org Subject: [Samba] Kerberos: Principal may not act as server ERROR Our environment: samba4 (alpha12) running on centos 5.4. We are experimenting with Hyper-V 2008 R2 Failover Clustering, which requires Active Directory. We are trying to see if samba-4 will work as the AD server. We are trying to create 2 node failover cluster. Both nodes have joined the domain successfully (with samba-4 as the DC). But subsequent steps of creating the Failover Cluster are failing and we see following error in samba log Kerberos: TGS-REQ administra...@sambalime.stratus.com from ipv4:10.90.0.87:49614 for administra...@sambalime.stratus.com [canonicalize, renewable, forwardable] Kerberos: Principal may not act as server -- administra...@sambalime.stratus.com Kerberos: Failed building TGS-REP to ipv4:10.90.0.87:49614 Terminating connection - 'kdc_tcp_call_loop: tstream_read_pdu_blob_recv() - NT_STATUS_CONNECTION_DISCONNECTED' single_terminate: reason[kdc_tcp_call_loop: tstream_read_pdu_blob_recv() - NT_STATUS_CONNECTION_DISCONNECTED] Is something wrong with our configuration (smb.conf)? -Ajay -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba4 Replication Policies
This is only an idea. Could it be a way to put the Scripts and the Policies directories on a drbd-disk Active-active to have scripts and policies the same on both dcs? --- EDV Daniel Müller Leitung EDV Tropenklinik Paul-Lechler-Krankenhaus Paul-Lechler-Str. 24 72076 Tübingen Tel.: 07071/206-463, Fax: 07071/206-499 eMail: muel...@tropenklinik.de Internet: www.tropenklinik.de --- -Ursprüngliche Nachricht- Von: samba-boun...@lists.samba.org [mailto:samba-boun...@lists.samba.org] Im Auftrag von Daniel Müller Gesendet: Samstag, 31. Juli 2010 10:50 An: samba@lists.samba.org Betreff: [Samba] Samba4 Replication Policies Hello To all, I set up 2 samba4 dc with replication. All working well users/groupsare in both controllers. But what I am missing are the group-policies I set up on a ou basis on the first controller . Are the policies replicated and how? Can I do it manuell?! The folder /usr/local/samba/var/locks/sysvol/tuebingen.tst.loc does only have Scripts, no Policies on my second joined dc. Greetings Daniel -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Must restart nmbd to connect
On Mon, 02 Aug 2010 11:49:37 +0200, Gilles gilles.gana...@free.fr wrote: Does someone understand what's going on? Thanks for the help through e-mail. For those interested, the bug might be due to a race condition between the smbd and nmbd init scripts: But adding the mkdir line, and even changing the symlinks in /etc/rc2.d/ to make sure that smbd is started before nmbd (S20 and S80, respectively)... 1) makes no difference, and 2) prevented nmbd from booting: = # cat /etc/init/nmbd.conf pre-start script #Added to solve bug where nmbd wouldn't start after reboot mkdir /var/run/samba NMBD_DISABLED=`testparm -s --parameter-name='disable netbios' 2/dev/null` [ x$NMBD_DISABLED = xYes ] { stop; exit 0; } install -o root -g root -m 755 -d /var/run/samba end script = # ll /etc/rc2.d/ lrwxrwxrwx 1 root root 14 2010-08-02 10:20 S20nmbd - ../init.d/nmbd* lrwxrwxrwx 1 root root 14 2010-08-02 00:26 S20smbd - ../init.d/smbd* = rm S20nmbd ln -s ../init.d/nmbd S80nmbd = rebooted : ps aux : Still NOK = apt-get update apt-get upgrade dpkg -l | grep -i samba 3.4.7~dfsg-1ubuntu3 = less /var/log/samba/log.smbd less /var/log/samba/log.nmbd less /var/log/messages Nothing = # /etc/init.d/nmbd restart Rather than invoking init scripts through /etc/init.d, use the service(8) utility, e.g. service nmbd restart [...] start: Job failed to start = # restart nmbd restart: Unknown instance: = # start nmbd start: Job failed to start = # /etc/init.d/nmbd start Rather than invoking init scripts through /etc/init.d, use the service(8) utility, e.g. service nmbd start [...] start: Job failed to start = # joe /etc/init/nmbd.conf Commented out line = # /etc/init.d/nmbd start Rather than invoking init scripts through /etc/init.d, use the service(8) utility, e.g. service nmbd start [...] nmbd start/running, process 5448 = I find it hard to believe that such an important package is broken. Maybe it's another issue. Thank you. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Build status as of Mon Aug 2 06:00:01 2010
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2010-08-01 00:00:02.0 -0600 +++ /home/build/master/cache/broken_results.txt 2010-08-02 00:00:03.0 -0600 @@ -1,13 +1,13 @@ -Build status as of Sun Aug 1 06:00:02 2010 +Build status as of Mon Aug 2 06:00:01 2010 Build counts: Tree Total Broken Panic build_farm 0 0 0 -ccache 32 2 0 +ccache 32 9 0 ldb 32 10 0 libreplace 32 11 0 lorikeet 0 0 0 -pidl 19 19 0 +pidl 18 18 0 ppp 12 0 0 rsync32 14 0 samba-docs 0 0 0 @@ -16,7 +16,7 @@ samba_3_master 32 32 6 samba_3_next 32 32 6 samba_4_0_test 32 32 0 -samba_4_0_waf 36 33 1 +samba_4_0_waf 36 34 1 talloc 32 7 0 tdb 30 8 0
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 911db76... s3: Use cups-config --libs from e4b32cb... s4:ldap.py - remove superflous spaces http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 911db761148329f3bfc84ee68e0747215d0e8b2d Author: Volker Lendecke v...@samba.org Date: Mon Aug 2 11:03:13 2010 +0200 s3: Use cups-config --libs --- Summary of changes: source3/configure.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/configure.in b/source3/configure.in index 4b92cd6..294cd53 100644 --- a/source3/configure.in +++ b/source3/configure.in @@ -818,7 +818,7 @@ if test x$enable_cups != xno; then ac_save_PRINT_LIBS=$PRINT_LIBS CFLAGS=$CFLAGS `$CUPS_CONFIG --cflags` LDFLAGS=$LDFLAGS `$CUPS_CONFIG --ldflags` - PRINT_LIBS=$PRINT_LIBS -lcups + PRINT_LIBS=$PRINT_LIBS `$CUPS_CONFIG --libs` AC_CHECK_HEADERS(cups/cups.h cups/language.h) if test x$ac_cv_header_cups_cups_h = xyes -a \ x$ac_cv_header_cups_language_h = xyes; then -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via eccf498... s3: Use cups-config --libs from 1b069a9... s3: Remove cli from struct finfo http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit eccf498e95b9b4cb67078e0ac62360a81646619c Author: Volker Lendecke v...@samba.org Date: Mon Aug 2 11:03:13 2010 +0200 s3: Use cups-config --libs --- Summary of changes: source3/configure.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/configure.in b/source3/configure.in index 4c479ce..a1b6e9e 100644 --- a/source3/configure.in +++ b/source3/configure.in @@ -818,7 +818,7 @@ if test x$enable_cups != xno; then ac_save_PRINT_LIBS=$PRINT_LIBS CFLAGS=$CFLAGS `$CUPS_CONFIG --cflags` LDFLAGS=$LDFLAGS `$CUPS_CONFIG --ldflags` - PRINT_LIBS=$PRINT_LIBS -lcups + PRINT_LIBS=$PRINT_LIBS `$CUPS_CONFIG --libs` AC_CHECK_HEADERS(cups/cups.h cups/language.h) if test x$ac_cv_header_cups_cups_h = xyes -a \ x$ac_cv_header_cups_language_h = xyes; then -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 322b524... s3-build: fix some c++ build warnings. from 911db76... s3: Use cups-config --libs http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 322b52419485b882658c53c21f86e5bdfa82b71f Author: Günther Deschner g...@samba.org Date: Sun Aug 1 15:34:52 2010 +0200 s3-build: fix some c++ build warnings. Guenther --- Summary of changes: source3/librpc/rpc/dcerpc_gssapi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/librpc/rpc/dcerpc_gssapi.c b/source3/librpc/rpc/dcerpc_gssapi.c index c9496ab..2de46b5 100644 --- a/source3/librpc/rpc/dcerpc_gssapi.c +++ b/source3/librpc/rpc/dcerpc_gssapi.c @@ -310,7 +310,7 @@ static char *gse_errstr(TALLOC_CTX *mem_ctx, OM_uint32 maj, OM_uint32 min) goto done; } gss_maj = gss_display_status(gss_min, min, GSS_C_MECH_CODE, -discard_const(gss_mech_krb5), +(gss_OID)discard_const(gss_mech_krb5), msg_ctx, msg_min); if (gss_maj) { goto done; @@ -394,7 +394,7 @@ NTSTATUS gse_seal(TALLOC_CTX *mem_ctx, struct gse_context *gse_ctx, if (!signature-length) { return NT_STATUS_INTERNAL_ERROR; } - signature-data = talloc_size(mem_ctx, signature-length); + signature-data = (uint8_t *)talloc_size(mem_ctx, signature-length); if (!signature-data) { return NT_STATUS_NO_MEMORY; } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 45952b5... spoolss: fix potential crash bug in spoolss_PrinterEnumValues push path. via ff1c5b3... s3-spoolss: remove unused MAX_OPEN_PRINTER_EXS define. from 322b524... s3-build: fix some c++ build warnings. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 45952b56797982d27731b20d97f5648c9414814a Author: Günther Deschner g...@samba.org Date: Mon Aug 2 15:52:09 2010 +0200 spoolss: fix potential crash bug in spoolss_PrinterEnumValues push path. Guenther commit ff1c5b37f619ed3373b65af72c026a36de4b94c9 Author: Günther Deschner g...@samba.org Date: Mon Aug 2 15:31:10 2010 +0200 s3-spoolss: remove unused MAX_OPEN_PRINTER_EXS define. Guenther --- Summary of changes: librpc/idl/spoolss.idl |2 +- source3/rpc_server/srv_spoolss_nt.c |4 2 files changed, 1 insertions(+), 5 deletions(-) Changeset truncated at 500 lines: diff --git a/librpc/idl/spoolss.idl b/librpc/idl/spoolss.idl index 028015b..c61cba5 100644 --- a/librpc/idl/spoolss.idl +++ b/librpc/idl/spoolss.idl @@ -2855,7 +2855,7 @@ cpp_quote(#define spoolss_security_descriptor security_descriptor) [value(2*strlen_m_term(value_name))] uint32 value_name_len; winreg_Type type; [relative,subcontext(0),subcontext_size(data_length),flag(NDR_REMAINING)] DATA_BLOB *data; - [value(data-length)] uint32 data_length; + [value(data ? data-length : 0)] uint32 data_length; } spoolss_PrinterEnumValues; [public,noopnum,noprint] WERROR _spoolss_EnumPrinterDataEx( diff --git a/source3/rpc_server/srv_spoolss_nt.c b/source3/rpc_server/srv_spoolss_nt.c index 9ef1ff1..1d9632f 100644 --- a/source3/rpc_server/srv_spoolss_nt.c +++ b/source3/rpc_server/srv_spoolss_nt.c @@ -54,10 +54,6 @@ #undef DBGC_CLASS #define DBGC_CLASS DBGC_RPC_SRV -#ifndef MAX_OPEN_PRINTER_EXS -#define MAX_OPEN_PRINTER_EXS 50 -#endif - static Printer_entry *printers_list; typedef struct _counter_printer_0 { -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 6463281... s4-smbtorture: remove another old and now invalid s3 special case during spoolss testing. from 45952b5... spoolss: fix potential crash bug in spoolss_PrinterEnumValues push path. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 6463281f36edc796e51960d4b0c896af24e1b3c2 Author: Günther Deschner g...@samba.org Date: Mon Aug 2 16:08:30 2010 +0200 s4-smbtorture: remove another old and now invalid s3 special case during spoolss testing. Guenther --- Summary of changes: source4/torture/rpc/spoolss.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/torture/rpc/spoolss.c b/source4/torture/rpc/spoolss.c index b648483..a444c84 100644 --- a/source4/torture/rpc/spoolss.c +++ b/source4/torture/rpc/spoolss.c @@ -5009,13 +5009,6 @@ static bool test_SetPrinterDataEx_matrix(struct torture_context *tctx, s = 0x; } - if (torture_setting_bool(tctx, samba3, false)) { - if ((types[t] == REG_MULTI_SZ) s == 0) { - torture_warning(tctx, samba3 does not handle 4 byte emtpy REG_MULTI_SZ buffers); - continue; - } - } - switch (types[t]) { case REG_BINARY: data = blob; -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via d3fff45... s3-spoolss: Fixed a segfault if a value has no data. via 307bd43... s3-spoolss: Move some debug message to a higher level. via 4412baf... s3-spoolss: Fixed some C++ build warnings. via 772fbce... s3-spoolss: Use a stackframe to allocat memory. from 6463281... s4-smbtorture: remove another old and now invalid s3 special case during spoolss testing. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit d3fff4590420a3b2d1858e6c8dbaf4df93447a46 Author: Andreas Schneider a...@samba.org Date: Mon Aug 2 13:49:59 2010 +0200 s3-spoolss: Fixed a segfault if a value has no data. commit 307bd439d7f5df828923189c02fcbe30124d1e01 Author: Andreas Schneider a...@samba.org Date: Mon Aug 2 13:21:47 2010 +0200 s3-spoolss: Move some debug message to a higher level. commit 4412bafa4460bbafe2170f980e8ce88937422529 Author: Andreas Schneider a...@samba.org Date: Mon Aug 2 12:38:57 2010 +0200 s3-spoolss: Fixed some C++ build warnings. commit 772fbce9ffd7ec9de7d33e29d96852dce7f35c43 Author: Andreas Schneider a...@samba.org Date: Mon Aug 2 12:09:03 2010 +0200 s3-spoolss: Use a stackframe to allocat memory. This is faster and should be more secure to use if something goes wrong. --- Summary of changes: source3/rpc_server/srv_spoolss_nt.c |2 +- source3/rpc_server/srv_spoolss_util.c | 75 + 2 files changed, 40 insertions(+), 37 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/rpc_server/srv_spoolss_nt.c b/source3/rpc_server/srv_spoolss_nt.c index 1d9632f..b62a7c0 100644 --- a/source3/rpc_server/srv_spoolss_nt.c +++ b/source3/rpc_server/srv_spoolss_nt.c @@ -528,7 +528,7 @@ static bool set_printer_hnd_name(TALLOC_CTX *mem_ctx, sname, info2); if ( !W_ERROR_IS_OK(result) ) { - DEBUG(0,(set_printer_hnd_name: failed to lookup printer [%s] -- result [%s]\n, + DEBUG(2,(set_printer_hnd_name: failed to lookup printer [%s] -- result [%s]\n, sname, win_errstr(result))); continue; } diff --git a/source3/rpc_server/srv_spoolss_util.c b/source3/rpc_server/srv_spoolss_util.c index c5fad1a..3a9523c 100644 --- a/source3/rpc_server/srv_spoolss_util.c +++ b/source3/rpc_server/srv_spoolss_util.c @@ -397,7 +397,7 @@ static WERROR winreg_printer_enumvalues(TALLOC_CTX *mem_ctx, WERROR result = WERR_OK; NTSTATUS status; - tmp_ctx = talloc_new(mem_ctx); + tmp_ctx = talloc_stackframe(); if (tmp_ctx == NULL) { return WERR_NOMEM; } @@ -443,7 +443,7 @@ static WERROR winreg_printer_enumvalues(TALLOC_CTX *mem_ctx, struct spoolss_PrinterEnumValues val; struct winreg_ValNameBuf name_buf; enum winreg_Type type = REG_NONE; - uint8_t *data = NULL; + uint8_t *data; uint32_t data_size; uint32_t length; char n = '\0';; @@ -453,7 +453,10 @@ static WERROR winreg_printer_enumvalues(TALLOC_CTX *mem_ctx, name_buf.length = 0; data_size = max_valbufsize; - data = (uint8_t *) TALLOC(tmp_ctx, data_size); + data = NULL; + if (data_size) { + data = (uint8_t *) TALLOC(tmp_ctx, data_size); + } length = 0; status = rpccli_winreg_EnumValue(pipe_handle, @@ -463,7 +466,7 @@ static WERROR winreg_printer_enumvalues(TALLOC_CTX *mem_ctx, name_buf, type, data, -data_size, +data_size ? data_size : NULL, length, result); if (W_ERROR_EQUAL(result, WERR_NO_MORE_ITEMS) ) { @@ -557,7 +560,7 @@ static WERROR winreg_printer_enumkeys(TALLOC_CTX *mem_ctx, WERROR result = WERR_OK; NTSTATUS status; - tmp_ctx = talloc_new(mem_ctx); + tmp_ctx = talloc_stackframe(); if (tmp_ctx == NULL) { return WERR_NOMEM; } @@ -1323,7 +1326,7 @@ WERROR winreg_create_printer(TALLOC_CTX *mem_ctx, WERROR result = WERR_OK; TALLOC_CTX *tmp_ctx; - tmp_ctx = talloc_new(mem_ctx); + tmp_ctx = talloc_stackframe(); if (tmp_ctx == NULL) { return WERR_NOMEM; } @@ -1630,7
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 31782e5... s4:librpc/rpc: avoid using DCERPC_NDR_REF_ALLOC for epm_Map() via b1a584f... s4:torture/libnet: avoid dereferencing dcerpc_binding_handle internals from d3fff45... s3-spoolss: Fixed a segfault if a value has no data. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 31782e52955f4f9301611a1e94b52b880f2ae302 Author: Stefan Metzmacher me...@samba.org Date: Mon Aug 2 10:21:36 2010 +0200 s4:librpc/rpc: avoid using DCERPC_NDR_REF_ALLOC for epm_Map() metze commit b1a584f9dc67bee1ecde408620dd815be3533091 Author: Stefan Metzmacher me...@samba.org Date: Mon Aug 2 09:53:27 2010 +0200 s4:torture/libnet: avoid dereferencing dcerpc_binding_handle internals metze --- Summary of changes: source4/librpc/rpc/dcerpc_util.c |4 ++-- source4/torture/libnet/utils.c |9 + 2 files changed, 7 insertions(+), 6 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/librpc/rpc/dcerpc_util.c b/source4/librpc/rpc/dcerpc_util.c index 280115e..1210b58 100644 --- a/source4/librpc/rpc/dcerpc_util.c +++ b/source4/librpc/rpc/dcerpc_util.c @@ -118,6 +118,7 @@ struct epm_map_binding_state { struct GUID guid; struct epm_twr_t twr; struct epm_twr_t *twr_r; + uint32_t num_towers; struct epm_Map r; }; @@ -142,8 +143,6 @@ static void continue_epm_recv_binding(struct composite_context *ctx) c-status = dcerpc_pipe_connect_b_recv(ctx, c, s-pipe); if (!composite_is_ok(c)) return; - s-pipe-conn-flags |= DCERPC_NDR_REF_ALLOC; - /* prepare requested binding parameters */ s-binding-object = s-table-syntax_id; @@ -156,6 +155,7 @@ static void continue_epm_recv_binding(struct composite_context *ctx) s-r.in.entry_handle = s-handle; s-r.in.max_towers= 1; s-r.out.entry_handle = s-handle; + s-r.out.num_towers = s-num_towers; /* send request for an endpoint mapping - a rpc request on connected pipe */ subreq = dcerpc_epm_Map_r_send(s, c-event_ctx, diff --git a/source4/torture/libnet/utils.c b/source4/torture/libnet/utils.c index 372482d..88cebf1 100644 --- a/source4/torture/libnet/utils.c +++ b/source4/torture/libnet/utils.c @@ -107,7 +107,6 @@ bool test_domain_open(struct torture_context *tctx, * when deleting users. */ static bool _get_account_name_for_user_rdn(struct torture_context *tctx, - struct dcerpc_binding_handle *b, const char *user_rdn, TALLOC_CTX *mem_ctx, const char **_account_name) @@ -116,7 +115,7 @@ static bool _get_account_name_for_user_rdn(struct torture_context *tctx, struct ldb_context *ldb; TALLOC_CTX *tmp_ctx; bool test_res = true; - struct dcerpc_pipe *p = talloc_get_type_abort(b-private_data, struct dcerpc_pipe); + const char *hostname = torture_setting_string(tctx, host, NULL); int ldb_ret; struct ldb_result *ldb_res; const char *account_name = NULL; @@ -125,10 +124,12 @@ static bool _get_account_name_for_user_rdn(struct torture_context *tctx, NULL }; + torture_assert(tctx, hostname != NULL, Failed to get hostname); + tmp_ctx = talloc_new(tctx); torture_assert(tctx, tmp_ctx != NULL, Failed to create temporary mem context); - url = talloc_asprintf(tmp_ctx, ldap://%s/;, p-binding-target_hostname); + url = talloc_asprintf(tmp_ctx, ldap://%s/;, hostname); torture_assert_goto(tctx, url != NULL, test_res, done, Failed to allocate URL for ldb); ldb = ldb_wrap_connect(tmp_ctx, @@ -178,7 +179,7 @@ bool test_user_cleanup(struct torture_context *tctx, struct samr_Ids rids, types; const char *account_name; - if (!_get_account_name_for_user_rdn(tctx, b, user_rdn, mem_ctx, account_name)) { + if (!_get_account_name_for_user_rdn(tctx, user_rdn, mem_ctx, account_name)) { torture_result(tctx, TORTURE_FAIL, __location__: Failed to find samAccountName for %s, user_rdn); return false; -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via b6e9d8d... idl: Fixed a possible crash bug. from 31782e5... s4:librpc/rpc: avoid using DCERPC_NDR_REF_ALLOC for epm_Map() http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit b6e9d8d406974ec2f4593fd0147113fe86b883f9 Author: Andreas Schneider a...@samba.org Date: Mon Aug 2 18:32:40 2010 +0200 idl: Fixed a possible crash bug. --- Summary of changes: librpc/idl/winreg.idl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/librpc/idl/winreg.idl b/librpc/idl/winreg.idl index c3e5279..48fddb7 100644 --- a/librpc/idl/winreg.idl +++ b/librpc/idl/winreg.idl @@ -188,7 +188,7 @@ import lsa.idl, security.idl, misc.idl; [in]uint32 enum_index, [in,out,ref]winreg_ValNameBuf *name, [in,out,unique] winreg_Type *type, - [in,out,unique,size_is(*size),length_is(*length)] uint8 *value, + [in,out,unique,size_is(size ? *size : 0),length_is(length ? *length : 0),range(0,0x400)] uint8 *value, [in,out,unique] uint32 *size, [in,out,unique] uint32 *length ); -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 3064482... s4-smbtorture: remove another old and now invalid s3 special case during spoolss testing. via ad68e45... spoolss: fix potential crash bug in spoolss_PrinterEnumValues push path. via a48b47b... s3-spoolss: remove unused MAX_OPEN_PRINTER_EXS define. via 902e66e... s3-printing: remove unused get_local_printer_publishing_data() call. via 654f86e... s3-build: avoid to globally include printing and spoolss headers. via df552f2... s4-smbtorture: remove ifdefed symlink test, this is already skipped internally in the s3 case. via 9d0c7f9... Revert s4-torture: Disable setting REG_BINARY printer data with size 0. from eccf498... s3: Use cups-config --libs http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 30644821c0fe426ab27c3d809f39f20f2b3dc724 Author: Günther Deschner g...@samba.org Date: Mon Aug 2 16:08:30 2010 +0200 s4-smbtorture: remove another old and now invalid s3 special case during spoolss testing. Guenther (cherry picked from commit 6463281f36edc796e51960d4b0c896af24e1b3c2) commit ad68e45b505331683a2510de20f113a7c20e68e1 Author: Günther Deschner g...@samba.org Date: Mon Aug 2 15:52:09 2010 +0200 spoolss: fix potential crash bug in spoolss_PrinterEnumValues push path. Guenther (cherry picked from commit 45952b56797982d27731b20d97f5648c9414814a) commit a48b47b46a7326dc51266822554cf28d089e5afe Author: Günther Deschner g...@samba.org Date: Mon Aug 2 15:31:10 2010 +0200 s3-spoolss: remove unused MAX_OPEN_PRINTER_EXS define. Guenther (cherry picked from commit ff1c5b37f619ed3373b65af72c026a36de4b94c9) commit 902e66e06d7067d95cd59db8039fd83331093212 Author: Günther Deschner g...@samba.org Date: Sat Jul 31 00:54:45 2010 +0200 s3-printing: remove unused get_local_printer_publishing_data() call. Guenther (cherry picked from commit 9e224a53f418eb4d2c87f1b8d8c47e348665) commit 654f86e7ce5c93b4eeba04b1de45687ed77c7880 Author: Günther Deschner g...@samba.org Date: Sat Jul 31 00:47:20 2010 +0200 s3-build: avoid to globally include printing and spoolss headers. This shrinks precompiled headers by 3MB and will slightly speed up any build. Guenther (cherry picked from commit 813fbbd68c50811ad3776140e409d31b60dba76f) commit df552f2f90d4370f07b377925dabfe1a4b90e6e9 Author: Günther Deschner g...@samba.org Date: Fri Jul 30 11:24:23 2010 +0200 s4-smbtorture: remove ifdefed symlink test, this is already skipped internally in the s3 case. Guenther (cherry picked from commit a6e1fa23adaa31579366ec3445949cbde0520ac5) commit 9d0c7f9dcb9a7a90912b1a42b112fa1c50278efc Author: Günther Deschner g...@samba.org Date: Fri Jul 30 11:23:06 2010 +0200 Revert s4-torture: Disable setting REG_BINARY printer data with size 0. This reverts commit 104c419345a42a9a02ae25df482f449dc41a6380. (cherry picked from commit 89071133e34cd5264bfc55d77d4ee77dc3604a9f) --- Summary of changes: librpc/idl/spoolss.idl |2 +- source3/include/includes.h |1 - source3/include/proto.h |4 source3/include/registry.h |2 ++ source3/include/smb.h |1 - source3/libads/ldap_printer.c | 15 +-- source3/printing/notify.c |2 ++ source3/printing/nt_printing.c |3 ++- source3/printing/nt_printing_tdb.c |2 +- source3/printing/printing.c |2 ++ source3/registry/reg_backend_db.c |1 + source3/rpc_client/init_spoolss.c |2 +- source3/rpc_server/srv_spoolss_nt.c |4 source3/rpcclient/cmd_spoolss.c |1 + source3/rpcclient/cmd_test.c|1 + source3/smbd/reply.c|1 + source3/smbd/server_reload.c|1 + source3/utils/net_rpc_printer.c |1 + source3/utils/smbcontrol.c |2 ++ source4/torture/rpc/spoolss.c | 13 - 20 files changed, 20 insertions(+), 41 deletions(-) Changeset truncated at 500 lines: diff --git a/librpc/idl/spoolss.idl b/librpc/idl/spoolss.idl index 028015b..c61cba5 100644 --- a/librpc/idl/spoolss.idl +++ b/librpc/idl/spoolss.idl @@ -2855,7 +2855,7 @@ cpp_quote(#define spoolss_security_descriptor security_descriptor) [value(2*strlen_m_term(value_name))] uint32 value_name_len; winreg_Type type; [relative,subcontext(0),subcontext_size(data_length),flag(NDR_REMAINING)] DATA_BLOB *data; - [value(data-length)] uint32 data_length; + [value(data ? data-length : 0)] uint32 data_length; } spoolss_PrinterEnumValues; [public,noopnum,noprint] WERROR _spoolss_EnumPrinterDataEx( diff --git
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via eab6d8c... s3-spoolss: remove duplicate (and incorrect) header. from b6e9d8d... idl: Fixed a possible crash bug. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit eab6d8c390f34ab331115a190735cb010ca59829 Author: Günther Deschner g...@samba.org Date: Tue Aug 3 00:12:27 2010 +0200 s3-spoolss: remove duplicate (and incorrect) header. Guenther --- Summary of changes: source3/printing/nt_printing.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c index c9ce969..f0460f3 100644 --- a/source3/printing/nt_printing.c +++ b/source3/printing/nt_printing.c @@ -30,7 +30,6 @@ #include ../librpc/gen_ndr/ndr_spoolss.h #include rpc_server/srv_spoolss_util.h #include nt_printing.h -#include ../rpc_server/srv_spoolss_util.h /* Map generic permissions to printer object specific permissions */ -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via f827904... s4-schema: More verbose error log when subClassOf is not found in schema via a268e08... s4: fix comment typos from eab6d8c... s3-spoolss: remove duplicate (and incorrect) header. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit f8279045964cd0140be23b436ead1169096a8d18 Author: Kamen Mazdrashki kame...@samba.org Date: Tue Aug 3 04:26:57 2010 +0300 s4-schema: More verbose error log when subClassOf is not found in schema Error message show failing classSchema object but not the specific value for the failure, which makes diagnostics by log files really hard. commit a268e0846f1bc37a3dd63d2085884edc91b83e2a Author: Kamen Mazdrashki kame...@samba.org Date: Tue Aug 3 04:14:45 2010 +0300 s4: fix comment typos --- Summary of changes: source4/dsdb/schema/schema_inferiors.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/dsdb/schema/schema_inferiors.c b/source4/dsdb/schema/schema_inferiors.c index b3f5f31..d2c134e 100644 --- a/source4/dsdb/schema/schema_inferiors.c +++ b/source4/dsdb/schema/schema_inferiors.c @@ -1,5 +1,5 @@ /* - Unix SMB/CIFS mplementation. + Unix SMB/CIFS implementation. implement possibleInferiors calculation @@ -49,7 +49,7 @@ static const char **schema_supclasses(const struct dsdb_schema *schema, return NULL; } - /* Cope with 'top SUP top', ie top is subClassOf top */ + /* Cope with 'top SUP top', i.e. top is subClassOf top */ if (schema_class-subClassOf strcmp(schema_class-lDAPDisplayName, schema_class-subClassOf) == 0) { schema_class-supclasses = list; @@ -163,7 +163,9 @@ static int schema_create_subclasses(const struct dsdb_schema *schema) struct dsdb_class *schema_class2 = discard_const_p(struct dsdb_class, dsdb_class_by_lDAPDisplayName(schema, schema_class-subClassOf)); if (schema_class2 == NULL) { - DEBUG(0,(ERROR: no subClassOf for '%s'\n, schema_class-lDAPDisplayName)); + DEBUG(0,(ERROR: no subClassOf '%s' for '%s'\n, +schema_class-subClassOf, +schema_class-lDAPDisplayName)); return LDB_ERR_OPERATIONS_ERROR; } if (schema_class2 schema_class != schema_class2) { @@ -181,7 +183,7 @@ static int schema_create_subclasses(const struct dsdb_schema *schema) for (schema_class=schema-classes; schema_class; schema_class=schema_class-next) { schema_class-subclasses = str_list_unique(schema_subclasses_recurse(schema, schema_class)); - /* Initilise the subClass order, to ensure we can't have uninitilised sort on the subClass hirarchy */ + /* Initialize the subClass order, to ensure we can't have uninitialized sort on the subClass hierarchy */ schema_class-subClass_order = 0; } -- Samba Shared Repository