Re: [Samba] Default Keyboard Layout changed to english.
Hi, second week and still not a single response I would really appriciate it, if someone would actually answer (even to ask for more info or suggest something at least). PS: Since i didn't do anything to windows machines it has to be samba (or linux) related. It goes even that far, that users can't run some adobe apps (Soundbooth, Elements Premiere) while logged in with roaming profiles (it was ok before). Hoping for a miracle, Kalev 3.03.2011 14:40, Kalev Riivik kirjutas: Hello, it's been allmost a week since i wrote to this list and i haven't gotten a single replay yet, so i thought i'd ask, if nobody knows what the problem is or is my questrion that stupid, that there's no point in answering? UPDATE: I also discovered, that after the update, roaming profile users (xp machines) can't see/change their desktop backgrounds and if they try to open image files from desktop... the window opens and closes right away (works fine if u open picture from shared pictures but if u copy the same picture to desktop then it won't open). PS: And i haven't made any kind of changes to xp computers (besides leaving and rejoining domain after update). Also... if users (xp roaming again) add Estonian keyboard, then when they log out and in again... its set to English once more. (On normal computer i would just delete the English keyboard and add Estonian as default but i can't do that here because even if i remove english keyboard, it still remains... luckly if i have two kb-s set, then there's a icon on taskbar that allows me to switch it to Estonian... for a while anyway). With regards, Kalev 25.02.2011 10:58, Kalev Riivik kirjutas: Hello, i upgraded debian from lenny to squeeze and i managed to mess up config file or update (cuz i'm quite noob when it comes to linux). I'm gonna try to explain best to my abillity, how i got where i am right now (bear in mind that this is my first time in this list). Since smbpasswd and pdbedit had mysteriously vanished after upgrade, i did reinstall to samba (3.5.6 PDC with roaming profiles). Since i did backup of entire /etc folder i put the old smb.conf back, but what happened was that nobody was able to log in (from xp). So what i had to do, was leave and rejoin the domain with all of the computers. After that it appeared that i had to input everyone's password again. Then some people were able to log in and others were not after a bit of research i found out that those people that couldn't log in had special (estonian) characters in their name (like äöüõ or šž etc), so i added unix charset = UTF8 to the smb.conf and it seemed to work (later replaced UTF8 with ISO-8859-15 and it still worked). The problem i'm having, is that when I (or anybody else) logs into xp machine with roaming profile, the default keyboard layout is set to US and they can't change it (but that might be because of gpedit policies i set up in xp machines). When i log in with local user (to xp) then keyboard is fine. I did try to find solution on the internet, but the posts i found about this problem were without answers. Any kind of help is appriciated With regards, Kalev -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] getpeername failed. Error was Transport endpoint is not connected (3.0.37)
Hi All, I have a Solaris 10 server (Sun Fire T5520) that has recently been patched with Samba 3.0.37 but is not able to share any drives to Windows clients. Instead, the /var/samba/log/log.smbd is showing the following errros: getpeername failed. Error was Transport endpoint is not connected Denied connection from 0.0.0.0 (0.0.0.0) [2011/03/10 21:10:04, 1] smbd/process.c:(1076) [2011/03/10 21:10:04, 0] lib/util_sock.c:(1224) write_data: write failure in writing to client 0.0.0.0. Error Broken pipe Error writing 5 bytes to client. -1. (Broken pipe) It would be very much appreciate some guidances on how to resolve this issue. Thanks, Jack -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Updated Samba 3.4.2 on Solaris 10 but still returns 3.0.37?
Hi Forum members, I have successfully updated Samba from 3.0.37 to 3.4.2 (samba-3.4.2-sol10-sparc-local) on a Solaris 10 server (Sun Fire T5520) but /usr/sfw/bin/smbstatus still return version 3.0.37.Many thanks, Jack What is the command to restart all Samba services for 3.4.2 so that the latest version could take effect? -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Default Keyboard Layout changed to english.
On 10 March 2011 11:45:17 UTC, Kalev Riivik kal...@iisaku.edu.ee wrote: Hi, second week and still not a single response I would really appriciate it, if someone would actually answer (even to ask for more info or suggest something at least). My guess is that you are doing something of which no-one on the list has any experience. Incidentally the way you posted implied that you felt you were entitled to a response, which is (in my experience) liable to make people (who are giving their free time, remember) less likely to help. This is a community project, a community list. If you want to pay for support then there are companies out there who will help you with that and to whom you can then go and demand a response to your problem. For what it's worth, I've no experience with roaming profiles but if every time they log out the settings get reset it sounds as though you have a permissions problem (ie they can't write the settings back). Geoff -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Default Keyboard Layout changed to english.
On Thu, Mar 10, 2011 at 12:45 PM, Kalev Riivik kal...@iisaku.edu.ee wrote: Hi, second week and still not a single response I would really appriciate it, if someone would actually answer (even to ask for more info or suggest something at least). PS: Since i didn't do anything to windows machines it has to be samba (or linux) related. It goes even that far, that users can't run some adobe apps (Soundbooth, Elements Premiere) while logged in with roaming profiles (it was ok before). the keyboard layout is a client setting, so I find it very hard to believe that whatever happened to your samba pdc has made that change. Apparently it is saved in the xp hosts in: HKEY_CURRENT_USER\Keyboard Layout\ You could set a user manually the way it should be, take a look in that key and export the values. Then with a login script import them to the other users. It most certainly is not a samba problem, though. -- natxo PS: nowadays, with free (as in free beer) virtualization techniques, not having a test environment does not have any excuse. You should have tested the upgrade before running it in your production environment. Not doing is your fault, not ours. Do not pretend this is samba's fault when it really is a question of bad planning and implementation on your part. If you had read the changelogs, (yes, those pesky things you should read before upgrading anything), you should have seen what had happened to smbpasswd and pdbedit. Tip: the info in a debian system is in /usr/share/doc/samba/NEWS.Debian.gz -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Default Keyboard Layout changed to english.
On Thu, 10 Mar 2011 13:45:17 +0200 Kalev Riivik kal...@iisaku.edu.ee wrote: KR i upgraded debian from lenny to squeeze and i managed to mess up KR config file or update (cuz i'm quite noob when it comes to linux). KR I'm gonna try to explain best to my abillity, how i got where i am KR right now (bear in mind that this is my first time in this list). KR Since smbpasswd and pdbedit had mysteriously vanished after upgrade, KR i did reinstall to samba (3.5.6 PDC with roaming profiles). Since i KR did backup of entire /etc folder i put the old smb.conf back, but KR what happened was that nobody was able to log in (from xp). So what i KR had to do, was leave and rejoin the domain with all of the computers. KR After that it appeared that i had to input everyone's password again. KR Then some people were able to log in and others were not after a KR bit of research i found out that those people that couldn't log in KR had special (estonian) characters in their name (like äöüõ or šž KR etc), so i added unix charset = UTF8 to the smb.conf and it seemed KR to work (later replaced UTF8 with ISO-8859-15 and it still worked). KR KR The problem i'm having, is that when I (or anybody else) logs into xp KR machine with roaming profile, the default keyboard layout is set to KR US and they can't change it (but that might be because of gpedit KR policies i set up in xp machines). When i log in with local user (to KR xp) then keyboard is fine. I did try to find solution on the KR internet, but the posts i found about this problem were without KR answers. Any kind of help is appriciated KR to fix the keyboard issue (this as nothing to do with the upgrade of the server but with the installation of the client and probably users didn't had the password they thought they had) run the following command on every client reg.exe ADD HKU\.DEFAULT\Keyboard Layout\Preload /v 1 /t REG_SZ /d 041d /f --^ replace 041d (swedish) with the code for estonian. I leave that to you and google. Your other problem is that you probably didn't preserve the SID of you domain and ended up with a new domain (that's why you needed to rejoin clients) the profile of all your user is a new one NTUSER.DAT contains now to sets of registry keys. one corresponding to your old SID and the one to the new. try to restore the original SID on the server. Best regards! -- Jean-Jacques Moulis Tel: (013) 281684 ISYFax: (013) 139282 Linköping UniversityE-mail: j...@isy.liu.se 581 83 Linköping -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Sharing a caching NFS mount with samba?
On Wed, Mar 9, 2011 at 4:30 PM, Andrew Wilkinson drukar...@gmail.comwrote: On Wed, Mar 9, 2011 at 3:19 PM, Andrew Wilkinson drukar...@gmail.comwrote: On Wed, Mar 9, 2011 at 9:46 AM, Volker Lendecke volker.lende...@sernet.de wrote: On Wed, Mar 09, 2011 at 09:42:47AM -0800, Andrew Wilkinson wrote: Is there any more information I can give that might help anyone better understand the scenario? Samba does normal posix calls. Can you point out in strace which of the calls breaks the caching? Volker -- SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-37-0, fax: +49-551-37-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen I'm sorry to say I'm not very familiar with what I should be looking for in the strace outputs. However, on comparing the outputs of the samba process and a cp process that successfully hit the cache, the only real differences I'm noting are that cp is using read() and samba is using pread(). Samba also does some mojo with fcntl, I believe setting locks on ranges of the file. If you'd like, I can give you those strace logs. Thanks! -Andy As a point of interest, the option read raw = no appears to allow the use of the cache. The hits seem to expire more quickly than they should, though, it seems like. If I don't touch a file for more than a minute or so, it copies the whole thing again. Thanks, -Andy Putting this back on the list because I accidentally derailed it. Thanks for calling that to my attention, Volker! -Andy -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Squid with AD Authendication problem (windows 2003)- please help
Dear alex,
Thanks for your support,
my output is
[root@PROXY ~]# wbinfo -t
checking the trust secret via RPC calls succeeded
[root@PROXY ~]#
Please help me to solve the error.
- Original Message
From: Александр Фахрутдинов alex_m...@mail.ru
To: Sharik M sharikonl...@yahoo.com
Sent: Thu, March 10, 2011 1:23:20 PM
Subject: Re: [Samba] Squid with AD Authendication problem (windows 2003)-
please
help
Please show output of this command:
wbinfo -t
- Original Message
From: Sharik M sharikonl...@yahoo.com
To: samba@lists.samba.org
Sent: Thu, March 10, 2011 6:07:43 AM
Subject: Squid with AD Authendication problem (windows 2003)- please help
I have configured squid with AD authentication its working fine but I am
getting lots of error for authentication failed.
squid-2.5.STABLE14-1.4E
samba-3.0.10-1.4E.11
Windows 2003 Domain Audit log failure.
Pre-authentication failed:
User Name: proxy$
User ID: DOMAIN\proxy$
Service Name: krbtgt/DOMAIN.HOME
Pre-Authentication Type: 0x0
Failure Code: 0x19
Client Address: 10.1.5.12
For more information, see Help and Support Center at
http://go.microsoft.com/fwlink/events.asp.
/etc/samba/smb.conf
[global]
workgroup = DOMAIN
netbios name = PROXY
realm = DOMAIN.HOME
server string = Linux Samba Server
security = ads
encrypt passwords = Yes
password server = 10.1.5.11
log file = /var/log/samba/%m.log
max log size = 0
socket options = TCP_NODELAY SO_RCVBUF=8192 SO_SNDBUF=8192
preferred master = False
local master = No
domain master = False
dns proxy = No
wins server = 10.1.5.11
# winbind separator = /
winbind enum users = yes
winbind enum groups = yes
winbind use default domain = yes
idmap uid = 1-2
idmap gid = 1-2
client schannel = no
log file = /var/log/samba/%m.log
max log size = 50
[homes]
comment = Home Directories
browseable = no
writable = yes
[printers]
comment = All Printers
path = /var/spool/samba
browseable = no
guest ok = no
writable = no
printable = yes
/etc/krb5.conf
[logging]
default = FILE:/var/log/krb5libs.log
kdc = FILE:/var/log/krb5kdc.log
admin_server = FILE:/var/log/kadmind.log
[libdefaults]
#ticket_lifetime = 24000
default_realm = DOMAIN.HOME
dns_lookup_realm = false
dns_lookup_kdc = false
[realms]
DOMAIN.HOME = {
kdc = 10.1.5.11
admin_server = 10.1.5.11
default_domain = DOMAIN.HOME
}
[domain_realm]
.DOMAIN.home = DOMAIN.HOME
DOMAIN.home = DOMAIN.HOME
[kdc]
profile = /var/kerberos/krb5kdc/kdc.conf
[appdefaults]
pam = {
debug = false
ticket_lifetime = 36000
renew_lifetime = 36000
forwardable = true
krb4_convert = false
}
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Sharing a caching NFS mount with samba?
On Wed, Mar 9, 2011 at 4:30 PM, Andrew Wilkinson drukar...@gmail.comwrote: On Wed, Mar 9, 2011 at 3:19 PM, Andrew Wilkinson drukar...@gmail.comwrote: On Wed, Mar 9, 2011 at 9:46 AM, Volker Lendecke volker.lende...@sernet.de wrote: On Wed, Mar 09, 2011 at 09:42:47AM -0800, Andrew Wilkinson wrote: Is there any more information I can give that might help anyone better understand the scenario? Samba does normal posix calls. Can you point out in strace which of the calls breaks the caching? Volker -- SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-37-0, fax: +49-551-37-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen I'm sorry to say I'm not very familiar with what I should be looking for in the strace outputs. However, on comparing the outputs of the samba process and a cp process that successfully hit the cache, the only real differences I'm noting are that cp is using read() and samba is using pread(). Samba also does some mojo with fcntl, I believe setting locks on ranges of the file. If you'd like, I can give you those strace logs. Thanks! -Andy As a point of interest, the option read raw = no appears to allow the use of the cache. The hits seem to expire more quickly than they should, though, it seems like. If I don't touch a file for more than a minute or so, it copies the whole thing again. Thanks, -Andy This is apparently not the whole answer, as trying to duplicate things on another computer does not appear to have had the same effect. Of potential note, the computer that (sorta) works is running kernel 2.6.34 and samba 3.4.12 (gentoo with xen-sources), and the computer that may not work is running kernel 2.6.35 and samba 3.4.7 (ubuntu). Any other thoughts? Thanks, -Andy -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Winbind user ID's on multiple servers
-Original Message- From: samba-boun...@lists.samba.org [mailto:samba-boun...@lists.samba.org] On Behalf Of Javier Conti Sent: Wednesday, March 09, 2011 4:28 PM To: TAKAHASHI Motonobu Cc: samba@lists.samba.org; Mike Auleta Subject: Re: [Samba] Winbind user ID's on multiple servers On Mar 10, 2011 12:16 AM, TAKAHASHI Motonobu mo...@monyo.com wrote: 2011/3/10 Javier Conti javier.co...@gmail.com: On 9 March 2011 20:13, Mike Auleta michael_aul...@condenast.com wrote: We're looking at setting up Linux Authentication to our AD servers using winbind and need to know if there is a way to keep all the user IDs in sync across the Linux servers. The way I see it now, the user ID is assigned numerically depending on the order users log in to a server. Could make for issues if NFS mounted directories are involved. Hi, I'm using AD 2008 R2 as PDC, and have been successful using the following configuration in /etc/samba/smb.conf on the client: [global] (snip) idmap backend = ad idmap config MYDOMAIN : backend = ad idmap config MYDOMAIN : range = 1 - 2 idmap config MYDOMAIN : schema_mode = rfc2307 winbind nss info = rfc2307 Since this configuration uses the Posix attributes found in the rfc2307 schema, I have the uidNumber attribute of users and the gidNumber attribute of groups populated with the IDs used in Unix (and in the range between 1 and 2). idmap backend should be a writeable backend such as tdb or ldap. If someone manages user and groups on the AD, thus assigning uidNumbers and gidNumbers on it, is it still necessary (or a real advantage) for the idmap backend to be writeable? Just wondering... Javier Anyway, to synclonize UID, you can also use rid or ldap instead of ad. If you simply want to sync UIDs, rid is a better choice, I think. For example: idmap config DOMAIN:range = 100 - 199 idmap config DOMAIN:base_rid = 0 idmap config DOMAIN:backend = rid Please refer to manpages in the detail. This is why, if you have a single domain and no weird setup, RID mapping is best. You get consistent mapping across all domain member servers and it's easy to port stuff around. I messed around with the other stuff and SFU, but RID is the easiest by far. -=Andrew -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] getpeername failed. Error was Transport endpoint is notconnected (3.0.37)
Hi All, I have a Solaris 10 server (Sun Fire T5520) that has recently been patched with Samba 3.0.37 but is not able to share any drives to Windows clients. Instead, the /var/samba/log/log.smbd is showing the following errros: getpeername failed. Error was Transport endpoint is not connected Denied connection from 0.0.0.0 (0.0.0.0) [2011/03/10 21:10:04, 1] smbd/process.c:(1076) [2011/03/10 21:10:04, 0] lib/util_sock.c:(1224) write_data: write failure in writing to client 0.0.0.0. Error Broken pipe Error writing 5 bytes to client. -1. (Broken pipe) It would be very much appreciate some guidances on how to resolve this issue. This error is very old, and seems to be related to samba binding to multiple ports (139 and 445). You only need 445 in most modern worlds, unless you're a PDC from what I can tell. I stuck this in my smb.conf file: # restrict ports to avoid # getpeername failed. Error was Transport endpoint is not connected and # Error writing 4 bytes to client. -1. (Transport endpoint is not connected) # errors from port 139 legacy mode - PDC may need 139 open smb ports = 445 -=Andrew -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Winbind user ID's on multiple servers
This addressed exactly what I was trying to accomplish. Rid mapping is your friend for this. -Original Message- From: Andrew Masterson [mailto:andrew.master...@nuvistaenergy.com] Sent: Thursday, March 10, 2011 1:54 PM To: Javier Conti Cc: samba@lists.samba.org; Auleta, Michael Subject: RE: [Samba] Winbind user ID's on multiple servers -Original Message- From: samba-boun...@lists.samba.org [mailto:samba-boun...@lists.samba.org] On Behalf Of Javier Conti Sent: Wednesday, March 09, 2011 4:28 PM To: TAKAHASHI Motonobu Cc: samba@lists.samba.org; Mike Auleta Subject: Re: [Samba] Winbind user ID's on multiple servers On Mar 10, 2011 12:16 AM, TAKAHASHI Motonobu mo...@monyo.com wrote: 2011/3/10 Javier Conti javier.co...@gmail.com: On 9 March 2011 20:13, Mike Auleta michael_aul...@condenast.com wrote: We're looking at setting up Linux Authentication to our AD servers using winbind and need to know if there is a way to keep all the user IDs in sync across the Linux servers. The way I see it now, the user ID is assigned numerically depending on the order users log in to a server. Could make for issues if NFS mounted directories are involved. Hi, I'm using AD 2008 R2 as PDC, and have been successful using the following configuration in /etc/samba/smb.conf on the client: [global] (snip) idmap backend = ad idmap config MYDOMAIN : backend = ad idmap config MYDOMAIN : range = 1 - 2 idmap config MYDOMAIN : schema_mode = rfc2307 winbind nss info = rfc2307 Since this configuration uses the Posix attributes found in the rfc2307 schema, I have the uidNumber attribute of users and the gidNumber attribute of groups populated with the IDs used in Unix (and in the range between 1 and 2). idmap backend should be a writeable backend such as tdb or ldap. If someone manages user and groups on the AD, thus assigning uidNumbers and gidNumbers on it, is it still necessary (or a real advantage) for the idmap backend to be writeable? Just wondering... Javier Anyway, to synclonize UID, you can also use rid or ldap instead of ad. If you simply want to sync UIDs, rid is a better choice, I think. For example: idmap config DOMAIN:range = 100 - 199 idmap config DOMAIN:base_rid = 0 idmap config DOMAIN:backend = rid Please refer to manpages in the detail. This is why, if you have a single domain and no weird setup, RID mapping is best. You get consistent mapping across all domain member servers and it's easy to port stuff around. I messed around with the other stuff and SFU, but RID is the easiest by far. -=Andrew This e-mail, including attachments, is intended for the person(s) or company named and may contain confidential and/or legally privileged information. Unauthorized disclosure, copying or use of this information may be unlawful and is prohibited. If you are not the intended recipient, please delete this message and notify the sender. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] WINS Server TIme out registering IP
I am seeing the following messages logged every 20 min on a Centos 5.5 Samba 3.5.7 (SerNet RPMs) PDC. wins server = yes is set and the 172.17.1.50 address is the address of the PDC. From a Windows client perspective the the domain is functioning as expected. There is a Samba BDC and mulitple Win2008 R2 member servers in the domain. Are they anything to be concerned about? [2011/03/11 07:45:32.336148, 2] nmbd/nmbd_nameregister.c:192(wins_registration_timeout) wins_registration_timeout: WINS server 127.0.0.1 timed out registering IP 172.17.1.50 [2011/03/11 07:45:32.336288, 2] nmbd/nmbd_nameregister.c:192(wins_registration_timeout) wins_registration_timeout: WINS server 127.0.0.1 timed out registering IP 172.17.1.50 [2011/03/11 07:45:32.336372, 2] nmbd/nmbd_nameregister.c:192(wins_registration_timeout) wins_registration_timeout: WINS server 127.0.0.1 timed out registering IP 172.17.1.50 [2011/03/11 07:45:32.336417, 2] nmbd/nmbd_nameregister.c:192(wins_registration_timeout) wins_registration_timeout: WINS server 127.0.0.1 timed out registering IP 172.17.1.50 [2011/03/11 07:45:32.336479, 2] nmbd/nmbd_nameregister.c:192(wins_registration_timeout) wins_registration_timeout: WINS server 127.0.0.1 timed out registering IP 172.17.1.50 [2011/03/11 07:45:32.336536, 2] nmbd/nmbd_nameregister.c:192(wins_registration_timeout) wins_registration_timeout: WINS server 127.0.0.1 timed out registering IP 172.17.1.50 [2011/03/11 07:45:32.336575, 2] nmbd/nmbd_nameregister.c:192(wins_registration_timeout) wins_registration_timeout: WINS server 127.0.0.1 timed out registering IP 172.17.1.50 [2011/03/11 07:45:32.336613, 2] nmbd/nmbd_nameregister.c:192(wins_registration_timeout) wins_registration_timeout: WINS server 127.0.0.1 timed out registering IP 172.17.1.50 [2011/03/11 07:45:32.336671, 2] nmbd/nmbd_nameregister.c:192(wins_registration_timeout) wins_registration_timeout: WINS server 127.0.0.1 timed out registering IP 172.17.1.50 [2011/03/11 07:45:32.336725, 2] nmbd/nmbd_nameregister.c:192(wins_registration_timeout) wins_registration_timeout: WINS server 127.0.0.1 timed out registering IP 172.17.1.50 Thanks Mike -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] WINS Server TIme out registering IP
On Thu, Mar 10, 2011 at 2:59 PM, Mike Brady mike.br...@devnull.net.nz wrote: wins server = yes is set man smb.conf wins server = the ip address of the wins server (unneeded on the actual wins server) wins support = yes (on the actual wins server) -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] is possible change the PDC IP address without damage the domain?
Hi. I have a virtualized PDC, and now i need asign a dedicated server to that service. The problem is: the IP on the virtualized server dont use the same range of the local network. To add the new PDC server, we need use an IP on the same local network, but i dont know how can affect that the existent domain. Actual PDC IP. 10.0.0.2 Local Network : 192.168.12.0/24. access to the domain server using the GW 192.168.12.2 now i need assign to the new PDC server the IP 192.168.12.10, but continue using the same domain. Is that possible? thanks and regards. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] is possible change the PDC IP address without damage the domain?
On Thu, Mar 10, 2011 at 4:07 PM, kazabe kaz...@gmail.com wrote: Hi. I have a virtualized PDC, and now i need asign a dedicated server to that service. The problem is: the IP on the virtualized server dont use the same range of the local network. To add the new PDC server, we need use an IP on the same local network, but i dont know how can affect that the existent domain. Actual PDC IP. 10.0.0.2 Local Network : 192.168.12.0/24. access to the domain server using the GW 192.168.12.2 now i need assign to the new PDC server the IP 192.168.12.10, but continue using the same domain. Is that possible? Yes. Just make the change. If you use a DNS server make sure you update the pdc records in that. John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] is possible change the PDC IP address without damage the domain?
2011/3/10 John Drescher dresche...@gmail.com Yes. Just make the change. If you use a DNS server make sure you update the pdc records in that. John I have the dns updating dinamically with the dhcp, including the PTR registers. the trust relationship can be affected changing the IP? (i have stations with windows XP and 7) thanks and regards. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] is possible change the PDC IP address without damage the domain?
Yes. Just make the change. If you use a DNS server make sure you update the pdc records in that. John I have the dns updating dinamically with the dhcp, including the PTR registers. the trust relationship can be affected changing the IP? (i have stations with windows XP and 7) No it will not affect the trust relationship. John -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Sharing a caching NFS mount with samba?
On Thu, Mar 10, 2011 at 10:03:58AM -0800, Andrew Wilkinson wrote: This is apparently not the whole answer, as trying to duplicate things on another computer does not appear to have had the same effect. Of potential note, the computer that (sorta) works is running kernel 2.6.34 and samba 3.4.12 (gentoo with xen-sources), and the computer that may not work is running kernel 2.6.35 and samba 3.4.7 (ubuntu). Any other thoughts? No, except that this sounds more like a kernel issue than a Samba one. The kernel folks should be able to decipher the straces and show what Samba could do differently. With best regards, Volker Lendecke -- SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-37-0, fax: +49-551-37-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] WINS Server TIme out registering IP
Quoting Chris Smith smb...@chrissmith.org: On Thu, Mar 10, 2011 at 2:59 PM, Mike Brady mike.br...@devnull.net.nz wrote: wins server = yes is set man smb.conf wins server = the ip address of the wins server (unneeded on the actual wins server) wins support = yes (on the actual wins server) -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba Sorry, I do have wins support = yes on the PDC. Faulty memory on my part. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] WINS Server TIme out registering IP
On Thu, Mar 10, 2011 at 5:44 PM, Mike Brady mike.br...@devnull.net.nz wrote: Sorry, I do have wins support = yes on the PDC. Faulty memory on my part. Do you also have a wins server = a.b.c.d entry on the PDC? If so remove it and restart Samba. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] What are these samba errors about?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 opensuse v11.3 linux 2.6.34.7-0.7-desktop x86_64 samba Version 3.5.4-5.3.1-2489-SUSE-SL11.3 These message have started appearing the system logs /var/log/messages and /var/log/warn since Mar 2, 2011. They seem to occur about every 13 minutes (780 seconds). What could it mean? Is it serious? - [ sample log entries ] Mar 9 20:15:50 sma-station14l smbd[3711]: [2011/03/09 20:15:50.196387, 0] smbd/server.c:281(remove_child_pid) Mar 9 20:15:50 sma-station14l smbd[3711]: Could not find child 10046 - ignoring Mar 9 20:28:50 sma-station14l smbd[3711]: [2011/03/09 20:28:50.885876, 0] smbd/server.c:281(remove_child_pid) Mar 9 20:28:50 sma-station14l smbd[3711]: Could not find child 10326 - ignoring - [ end ] - -- James Moe moe dot james at sohnen-moe dot com 520.743.3936 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk15XmAACgkQzTcr8Prq0ZNZZwCeK6WZVoDHv/28y15ZuLgPFAYI R1cAniIVut9y85gKW8Klq5wipN06kVF7 =7Xyf -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] getpeername failed. Error was Transport endpoint is notconnected (3.0.37)
I find I have to have both ports open- then again my main samba servers are configured as DC's. I don't know about member servers, but DC file server are using SMB-over-NetBIOS-over-IP (NT4 style) - I don't think they can support pure SMB-over-TCP/IP. I had tried setting to 139 only- I think some XP and Win 7 clients make an initial connection to port 445 then get redirected. If I disabled Netbios on the XP clients, they can't connect to a samba DC. -Original Message- From: samba-boun...@lists.samba.org [mailto:samba-boun...@lists.samba.org] On Behalf Of Andrew Masterson Sent: Thursday, March 10, 2011 1:56 PM To: Jack Bush; samba@lists.samba.org Subject: Re: [Samba] getpeername failed. Error was Transport endpoint is notconnected (3.0.37) Hi All, I have a Solaris 10 server (Sun Fire T5520) that has recently been patched with Samba 3.0.37 but is not able to share any drives to Windows clients. Instead, the /var/samba/log/log.smbd is showing the following errros: getpeername failed. Error was Transport endpoint is not connected Denied connection from 0.0.0.0 (0.0.0.0) [2011/03/10 21:10:04, 1] smbd/process.c:(1076) [2011/03/10 21:10:04, 0] lib/util_sock.c:(1224) write_data: write failure in writing to client 0.0.0.0. Error Broken pipe Error writing 5 bytes to client. -1. (Broken pipe) It would be very much appreciate some guidances on how to resolve this issue. This error is very old, and seems to be related to samba binding to multiple ports (139 and 445). You only need 445 in most modern worlds, unless you're a PDC from what I can tell. I stuck this in my smb.conf file: # restrict ports to avoid # getpeername failed. Error was Transport endpoint is not connected and # Error writing 4 bytes to client. -1. (Transport endpoint is not connected) # errors from port 139 legacy mode - PDC may need 139 open smb ports = 445 -=Andrew -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 494d497 tevent: change version to 0.9.11
via b7d5ddf tevent/poll: use fde-additional_flags to hold the array
index
via 20284f2 tevent: change tevent_fd-additional_flags to uint64_t
from 494aed5 s4:lib/socket: use sockaddr_in6 in ipv6_tcp_accept()
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 494d497b99df08603555ff6a981482937d44b124
Author: Stefan Metzmacher me...@samba.org
Date: Wed Mar 2 15:24:40 2011 +0100
tevent: change version to 0.9.11
metze
Autobuild-User: Stefan Metzmacher me...@samba.org
Autobuild-Date: Thu Mar 10 10:24:49 CET 2011 on sn-devel-104
commit b7d5ddfa61d3b4c797dcee64cb23eb97cc55759c
Author: Stefan Metzmacher me...@samba.org
Date: Wed Mar 2 15:22:09 2011 +0100
tevent/poll: use fde-additional_flags to hold the array index
metze
commit 20284f2a8429b5250ffb70e7124fa81115385c58
Author: Stefan Metzmacher me...@samba.org
Date: Wed Mar 2 15:20:46 2011 +0100
tevent: change tevent_fd-additional_flags to uint64_t
metze
---
Summary of changes:
.../ABI/{tevent-0.9.10.sigs = tevent-0.9.11.sigs} |0
lib/tevent/tevent_internal.h |2 +-
lib/tevent/tevent_poll.c | 23 +--
lib/tevent/wscript |2 +-
4 files changed, 8 insertions(+), 19 deletions(-)
copy lib/tevent/ABI/{tevent-0.9.10.sigs = tevent-0.9.11.sigs} (100%)
Changeset truncated at 500 lines:
diff --git a/lib/tevent/ABI/tevent-0.9.10.sigs
b/lib/tevent/ABI/tevent-0.9.11.sigs
similarity index 100%
copy from lib/tevent/ABI/tevent-0.9.10.sigs
copy to lib/tevent/ABI/tevent-0.9.11.sigs
diff --git a/lib/tevent/tevent_internal.h b/lib/tevent/tevent_internal.h
index 3d71bfd..9227f90 100644
--- a/lib/tevent/tevent_internal.h
+++ b/lib/tevent/tevent_internal.h
@@ -162,7 +162,7 @@ struct tevent_fd {
const char *handler_name;
const char *location;
/* this is private for the events_ops implementation */
- uint16_t additional_flags;
+ uint64_t additional_flags;
void *additional_data;
};
diff --git a/lib/tevent/tevent_poll.c b/lib/tevent/tevent_poll.c
index cda028a..712255b 100644
--- a/lib/tevent/tevent_poll.c
+++ b/lib/tevent/tevent_poll.c
@@ -35,7 +35,7 @@ struct poll_event_context {
*/
struct pollfd *fds;
struct tevent_fd **fd_events;
- int num_fds;
+ uint64_t num_fds;
/* information for exiting from the event loop */
int exit_code;
@@ -64,7 +64,7 @@ static int poll_event_fd_destructor(struct tevent_fd *fde)
struct tevent_context *ev = fde-event_ctx;
struct poll_event_context *poll_ev = NULL;
struct tevent_fd *moved_fde;
- long del_idx;
+ uint64_t del_idx = fde-additional_flags;
if (ev == NULL) {
goto done;
@@ -73,15 +73,10 @@ static int poll_event_fd_destructor(struct tevent_fd *fde)
poll_ev = talloc_get_type_abort(
ev-additional_data, struct poll_event_context);
- /*
-* Assume a void * can carry enough bits to hold num_fds.
-*/
- del_idx = (long)(fde-additional_data);
-
moved_fde = poll_ev-fd_events[poll_ev-num_fds-1];
poll_ev-fd_events[del_idx] = moved_fde;
poll_ev-fds[del_idx] = poll_ev-fds[poll_ev-num_fds-1];
- moved_fde-additional_data = (void *)del_idx;
+ moved_fde-additional_flags = del_idx;
poll_ev-num_fds -= 1;
done:
@@ -149,10 +144,7 @@ static struct tevent_fd *poll_event_add_fd(struct
tevent_context *ev,
pfd-events |= (POLLOUT);
}
- /*
-* Assume a void * can carry enough bits to hold num_fds.
-*/
- fde-additional_data = (void *)(long)poll_ev-num_fds;
+ fde-additional_flags = poll_ev-num_fds;
poll_ev-fd_events[poll_ev-num_fds] = fde;
poll_ev-num_fds += 1;
@@ -169,7 +161,7 @@ static void poll_event_set_fd_flags(struct tevent_fd *fde,
uint16_t flags)
{
struct poll_event_context *poll_ev = talloc_get_type_abort(
fde-event_ctx-additional_data, struct poll_event_context);
- long idx;
+ uint64_t idx = fde-additional_flags;
uint16_t pollflags = 0;
if (flags TEVENT_FD_READ) {
@@ -179,7 +171,6 @@ static void poll_event_set_fd_flags(struct tevent_fd *fde,
uint16_t flags)
pollflags |= (POLLOUT);
}
- idx = (long)(fde-additional_data);
poll_ev-fds[idx].events = pollflags;
fde-flags = flags;
@@ -237,11 +228,9 @@ static int poll_event_loop_poll(struct tevent_context *ev,
the handler to remove itself when called */
for (fde = ev-fd_events; fde; fde = fde-next) {
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via cdb9e4b libwbclient: Add some input check
via c22151e libwbclient: Remove a pointless check
from 494d497 tevent: change version to 0.9.11
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit cdb9e4b8fec1bc8b3e8af05c10b436e6d84b57d3
Author: Volker Lendecke v...@samba.org
Date: Wed Mar 9 10:58:47 2011 +0100
libwbclient: Add some input check
Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Thu Mar 10 11:10:30 CET 2011 on sn-devel-104
commit c22151ea3a7fe0e07e46802ec7cd57ba1694262f
Author: Volker Lendecke v...@samba.org
Date: Tue Mar 8 18:24:08 2011 +0100
libwbclient: Remove a pointless check
---
Summary of changes:
nsswitch/libwbclient/wbc_sid.c |3 ++-
nsswitch/wb_common.c |4
2 files changed, 6 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/nsswitch/libwbclient/wbc_sid.c b/nsswitch/libwbclient/wbc_sid.c
index e94d874..e8148aa 100644
--- a/nsswitch/libwbclient/wbc_sid.c
+++ b/nsswitch/libwbclient/wbc_sid.c
@@ -152,8 +152,9 @@ wbcErr wbcStringToSid(const char *str,
}
sid-sub_auths[sid-num_auths++] = x;
- if ((*q!='-') || (*q=='\0'))
+ if (*q != '-') {
break;
+ }
p = q + 1;
}
diff --git a/nsswitch/wb_common.c b/nsswitch/wb_common.c
index 2a1795c..dcfc8a5 100644
--- a/nsswitch/wb_common.c
+++ b/nsswitch/wb_common.c
@@ -514,6 +514,10 @@ static int winbindd_read_reply(struct winbindd_response
*response)
return -1;
}
+ if (response-length sizeof(struct winbindd_response)) {
+ return -1;
+ }
+
/* We actually send the pointer value of the extra_data field from
the server. This has no meaning in the client's address space
so we clear it out. */
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 22fcb8e s4:lib/tls/wscript - exclude known broken GNUTLS releases via f5ce61e lib/util/fault.c - call_backtrace - no need to have backtrace_size as size_t via e00893d s4:extended_dn_store LDB module - use the new request as generic memory contexts via 0cec610 s4:repl_meta_data LDB module - always ask manually for the current partition control via 68fbfa2 s4:partition LDB module - the current partition control should only be added if requested via 78b46c5 s4:partition LDB module - extended operations - make the initialisation check consistent via e52c900 s4:partition LDB module - move the data check a bit higher via 4e6b8e0 s4:partition LDB module - partition_replicate doesn't handle the search requests via 210cab9 s4:partition LDB module - partition_sequence_number - remove meaningless ifs via 96600e5 s4:simple_ldap_map LDB module - enhance current partition control checks via e669295 s4:repl_meta_data LDB module - don't remove the partition control twice via e754f0c s4:repl_meta_data LDB module - remove the current partition control unless it was requested via 42da193 s4:new_partition LDB module - splitting up an if operation via 83517d2 s4:instancetype LDB module - perform here only the instanceType constraint checks via 8ce1314 s4:instancetype LDB module - don't impede control requests via f68d542 s4:instancetype LDB module - use ldb pointer for referencing the LDB context via 8872a62 s4:partition LDB module - fill in parent requests for inheriting the flags via b7ecc33 ldb:ldb_controls.c - ldb_save_controls - allow that saver can also be NULL via 78c9eb1 ldb:ldb_controls.c - always allocate enough space via 851396a s4:partition LDB module - add some comments via 79c65cc s4:new_partition LDB module - fix comments via d2acd72 s4:partition_init LDB module - fix a typo via 82067b1 s4:partition LDB module - fix typo via 7aa0219 s4:setup/provision - fix an output message from cdb9e4b libwbclient: Add some input check http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 22fcb8e4945ac43fda6f6891ea00f36a53e52102 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Wed Mar 9 09:29:30 2011 +0100 s4:lib/tls/wscript - exclude known broken GNUTLS releases This definitely fixes bug #7218. Autobuild-User: Matthias Dieter Wallnöfer m...@samba.org Autobuild-Date: Thu Mar 10 11:58:27 CET 2011 on sn-devel-104 commit f5ce61ea57e4851999eb0a2a805a5e2aab5b86e4 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Wed Mar 9 09:09:15 2011 +0100 lib/util/fault.c - call_backtrace - no need to have backtrace_size as size_t The function backtrace returns an int. commit e00893d8395ed813a5bc9dd7bf28f29de369db46 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sun Mar 6 21:46:02 2011 +0100 s4:extended_dn_store LDB module - use the new request as generic memory contexts To prevent memory leaks under valgrind. commit 0cec6107d870ba2e67859b824306cde0686691cb Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Mar 5 14:42:40 2011 +0100 s4:repl_meta_data LDB module - always ask manually for the current partition control Otherwise the partition LDB module doesn't give it back anymore. commit 68fbfa2237a570a48d2ae3a5421cdcacae6e6d34 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Mar 5 14:25:59 2011 +0100 s4:partition LDB module - the current partition control should only be added if requested That means if the informations before a request are unknown (repl_meta_data LDB module) then an empty control (no data) has to be sent. commit 78b46c533a36cdfa6c5f8ab305f13c5aa142b819 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sun Mar 6 15:56:48 2011 +0100 s4:partition LDB module - extended operations - make the initialisation check consistent To the other operations. commit e52c900b63bf61daf64e5495241a257a40998a06 Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sun Mar 6 15:56:06 2011 +0100 s4:partition LDB module - move the data check a bit higher It can be performed a bit earlier. commit 4e6b8e0a181b2fa78fd72e7e2724ad5acd81672b Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sun Mar 6 15:37:51 2011 +0100 s4:partition LDB module - partition_replicate doesn't handle the search requests That is done by partition_search. commit 210cab9bf0a72b670d20ea16f1f483e41b5a503c Author: Matthias Dieter Wallnöfer m...@samba.org Date: Sat Mar 5 19:02:43 2011 +0100 s4:partition LDB module - partition_sequence_number - remove meaningless ifs These current partition controls are always added for the
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 969c7bd frstrans.idl: add idl for RawGetFileDataAsync() and RdcGetFileDataAsync() via d79fb90 pidl: add support for 'pipe' at the NDR layer via f43e757 pidl/idl.yp: fill 'pipe' elements with array and count via 91ef694 pidl:NDR/Client: skip all functions if pipe elements are used via f383497 pidl:NDR/Client: skip sync functions if pipe elements are used via 7537f9c pidl:Python: don't generate functions with pipe elements via 29bd658 pidl:Samba3/ClientNDR: don't generate stubs for functions with pipe elements via eaa7ecd pidl/NDR: add ContainsPipe() function via 7d45183 librpc/tools/ndrdump: add support for dcerpc 'pipe' elements in functions via 2a47ed8 librpc/ndr: add ndr_push_pipe_chunk_trailer() and ndr_check_pipe_chunk_trailer() via eceea86 librpc/ndr: add ndr_interface_call_pipe via 6e4e3f5 pidl/Typelist: add is_fixed_size_scalar() via 6ef40f3 pidl/Typelist: dnsp_name and dnsp_string are scalar references from 22fcb8e s4:lib/tls/wscript - exclude known broken GNUTLS releases http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 969c7bd77bdda55b9a07fc6381c4c1f562861cbe Author: Stefan Metzmacher me...@samba.org Date: Sat Sep 18 19:45:27 2010 +0200 frstrans.idl: add idl for RawGetFileDataAsync() and RdcGetFileDataAsync() metze Autobuild-User: Stefan Metzmacher me...@samba.org Autobuild-Date: Thu Mar 10 15:18:22 CET 2011 on sn-devel-104 commit d79fb9098bc3ce37daa8ab6d51dc62ad0bc2ad26 Author: Stefan Metzmacher me...@samba.org Date: Tue Sep 21 01:44:38 2010 +0200 pidl: add support for 'pipe' at the NDR layer metze commit f43e757096750dc2844af49363981fd0246d9f48 Author: Stefan Metzmacher me...@samba.org Date: Tue Sep 21 19:30:08 2010 +0200 pidl/idl.yp: fill 'pipe' elements with array and count metze commit 91ef69435167f44d1353e15cef2eb4969b53d27c Author: Stefan Metzmacher me...@samba.org Date: Mon Oct 11 08:03:18 2010 +0200 pidl:NDR/Client: skip all functions if pipe elements are used We don't support pipe at the dcerpc level yet. metze commit f383497436dbbadfdcb1062fee0c111eca50df7d Author: Stefan Metzmacher me...@samba.org Date: Mon Oct 11 08:03:18 2010 +0200 pidl:NDR/Client: skip sync functions if pipe elements are used metze commit 7537f9c9bb78992850a641973a8df818d2fcaf25 Author: Stefan Metzmacher me...@samba.org Date: Mon Oct 11 07:54:59 2010 +0200 pidl:Python: don't generate functions with pipe elements metze commit 29bd658634e9afe0037170a2f3ad2512f9106761 Author: Stefan Metzmacher me...@samba.org Date: Mon Oct 11 07:53:48 2010 +0200 pidl:Samba3/ClientNDR: don't generate stubs for functions with pipe elements metze commit eaa7ecdda7938e12db94f5ecbb978e5e7bca5f16 Author: Stefan Metzmacher me...@samba.org Date: Tue Sep 21 02:20:14 2010 +0200 pidl/NDR: add ContainsPipe() function metze commit 7d451838b978b7a88bc45a9fc878b99af59be7c3 Author: Stefan Metzmacher me...@samba.org Date: Tue Sep 21 08:34:31 2010 +0200 librpc/tools/ndrdump: add support for dcerpc 'pipe' elements in functions metze commit 2a47ed81066ccf7573b80e0a85bce8eb9866c628 Author: Stefan Metzmacher me...@samba.org Date: Tue Sep 21 05:18:02 2010 +0200 librpc/ndr: add ndr_push_pipe_chunk_trailer() and ndr_check_pipe_chunk_trailer() metze commit eceea8641e9079534a15ce01d24ef94acbe49d98 Author: Stefan Metzmacher me...@samba.org Date: Sun Sep 19 13:56:13 2010 +0200 librpc/ndr: add ndr_interface_call_pipe metze commit 6e4e3f57e43189fa2944c841982621594d167d2d Author: Stefan Metzmacher me...@samba.org Date: Tue Mar 8 15:45:33 2011 +0100 pidl/Typelist: add is_fixed_size_scalar() metze commit 6ef40f31992455c7603f0722846cfab4fe4fa0bc Author: Stefan Metzmacher me...@samba.org Date: Tue Mar 8 15:44:31 2011 +0100 pidl/Typelist: dnsp_name and dnsp_string are scalar references metze --- Summary of changes: librpc/idl/frstrans.idl | 12 ++- librpc/ndr/libndr.h | 18 +++ librpc/ndr/ndr.c | 34 + librpc/tools/ndrdump.c | 78 ++- pidl/idl.yp | 26 - pidl/lib/Parse/Pidl/IDL.pm | 86 - pidl/lib/Parse/Pidl/NDR.pm | 149 -- pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm | 11 ++ pidl/lib/Parse/Pidl/Samba4/Header.pm | 26 pidl/lib/Parse/Pidl/Samba4/NDR/Client.pm | 66 +- pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm | 213 +- pidl/lib/Parse/Pidl/Samba4/Python.pm | 11 ++-
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 902fb32 frstrans.idl: add idl for RawGetFileDataAsync() and RdcGetFileDataAsync() via 5f6ed3f pidl: add support for 'pipe' at the NDR layer via 35615f0 pidl/idl.yp: fill 'pipe' elements with array and count via 926d537 pidl:NDR/Client: skip all functions if pipe elements are used via 0b479cb pidl:NDR/Client: skip sync functions if pipe elements are used via 0536914 pidl:Python: don't generate functions with pipe elements via 9dcd0b0 pidl:Samba3/ClientNDR: don't generate stubs for functions with pipe elements via a24476d pidl/NDR: add ContainsPipe() function via a1fc75a librpc/tools/ndrdump: add support for dcerpc 'pipe' elements in functions via 3dbb218 librpc/ndr: add ndr_push_pipe_chunk_trailer() and ndr_check_pipe_chunk_trailer() via 101c57e librpc/ndr: add ndr_interface_call_pipe via 6c07d0a pidl/Typelist: add is_fixed_size_scalar() via 7d5c980 pidl/Typelist: dnsp_name and dnsp_string are scalar references from a938c1c s3:test: ignore setup directory parameter in the net registry roundtrip test http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 902fb321f8d76e59f15710e3c3e27c81d2a0946d Author: Stefan Metzmacher me...@samba.org Date: Sat Sep 18 19:45:27 2010 +0200 frstrans.idl: add idl for RawGetFileDataAsync() and RdcGetFileDataAsync() metze Autobuild-User: Stefan Metzmacher me...@samba.org Autobuild-Date: Thu Mar 10 15:18:22 CET 2011 on sn-devel-104 (cherry picked from commit 969c7bd77bdda55b9a07fc6381c4c1f562861cbe) commit 5f6ed3f151d3678775d120b01a45009d8846e7e7 Author: Stefan Metzmacher me...@samba.org Date: Tue Sep 21 01:44:38 2010 +0200 pidl: add support for 'pipe' at the NDR layer metze (cherry picked from commit d79fb9098bc3ce37daa8ab6d51dc62ad0bc2ad26) commit 35615f011c91344d737db0830f8549cf2ac9ef67 Author: Stefan Metzmacher me...@samba.org Date: Tue Sep 21 19:30:08 2010 +0200 pidl/idl.yp: fill 'pipe' elements with array and count metze (cherry picked from commit f43e757096750dc2844af49363981fd0246d9f48) commit 926d537728e04f55f62ea7a82ec224a9c81457c6 Author: Stefan Metzmacher me...@samba.org Date: Mon Oct 11 08:03:18 2010 +0200 pidl:NDR/Client: skip all functions if pipe elements are used We don't support pipe at the dcerpc level yet. metze (cherry picked from commit 91ef69435167f44d1353e15cef2eb4969b53d27c) commit 0b479cb9052b8e50dfdd470eaf179253d2000267 Author: Stefan Metzmacher me...@samba.org Date: Mon Oct 11 08:03:18 2010 +0200 pidl:NDR/Client: skip sync functions if pipe elements are used metze (cherry picked from commit f383497436dbbadfdcb1062fee0c111eca50df7d) commit 05369146cbfd781fa4942d765955b30b756b7768 Author: Stefan Metzmacher me...@samba.org Date: Mon Oct 11 07:54:59 2010 +0200 pidl:Python: don't generate functions with pipe elements metze (cherry picked from commit 7537f9c9bb78992850a641973a8df818d2fcaf25) commit 9dcd0b0ebb760851b87156160c1962e5e848c633 Author: Stefan Metzmacher me...@samba.org Date: Mon Oct 11 07:53:48 2010 +0200 pidl:Samba3/ClientNDR: don't generate stubs for functions with pipe elements metze (cherry picked from commit 29bd658634e9afe0037170a2f3ad2512f9106761) commit a24476d527397a14a6225502fb436601de93b4a2 Author: Stefan Metzmacher me...@samba.org Date: Tue Sep 21 02:20:14 2010 +0200 pidl/NDR: add ContainsPipe() function metze (cherry picked from commit eaa7ecdda7938e12db94f5ecbb978e5e7bca5f16) commit a1fc75a9fbddd397b8640f8476adcd9f23ad04ce Author: Stefan Metzmacher me...@samba.org Date: Tue Sep 21 08:34:31 2010 +0200 librpc/tools/ndrdump: add support for dcerpc 'pipe' elements in functions metze (cherry picked from commit 7d451838b978b7a88bc45a9fc878b99af59be7c3) commit 3dbb2187444306db5a505e13f9c02973faf6dfec Author: Stefan Metzmacher me...@samba.org Date: Tue Sep 21 05:18:02 2010 +0200 librpc/ndr: add ndr_push_pipe_chunk_trailer() and ndr_check_pipe_chunk_trailer() metze (cherry picked from commit 2a47ed81066ccf7573b80e0a85bce8eb9866c628) commit 101c57e90d9feb653de182164ab6c3def79eef71 Author: Stefan Metzmacher me...@samba.org Date: Sun Sep 19 13:56:13 2010 +0200 librpc/ndr: add ndr_interface_call_pipe metze (cherry picked from commit eceea8641e9079534a15ce01d24ef94acbe49d98) commit 6c07d0a6010268f795de908f28ec97c93fddad46 Author: Stefan Metzmacher me...@samba.org Date: Tue Mar 8 15:45:33 2011 +0100 pidl/Typelist: add is_fixed_size_scalar() metze (cherry picked from commit 6e4e3f57e43189fa2944c841982621594d167d2d) commit 7d5c980030116e11a5714722d5920e7e8a69e747 Author: Stefan Metzmacher me...@samba.org Date: Tue Mar 8 15:44:31 2011
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 257f049 s3: sid-domain_sid in winbindd_samr sam_rids_to_names
via 16b007c Quite some callers of sid_split_rid do not care about the
rid
via 8d0e241 s3: Fix paranoia check in sam_rids_to_names
from 969c7bd frstrans.idl: add idl for RawGetFileDataAsync() and
RdcGetFileDataAsync()
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 257f0491cbcc6d8a7d05520ccb3ffa7dd7c27273
Author: Volker Lendecke v...@samba.org
Date: Thu Mar 10 16:23:20 2011 +0100
s3: sid-domain_sid in winbindd_samr sam_rids_to_names
Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Thu Mar 10 19:33:47 CET 2011 on sn-devel-104
commit 16b007c2232cc8432fa9e93409e16367d72b149e
Author: Volker Lendecke v...@samba.org
Date: Thu Mar 10 16:19:17 2011 +0100
Quite some callers of sid_split_rid do not care about the rid
commit 8d0e2415309ee15fbf509d44caf3e1df5b900620
Author: Volker Lendecke v...@samba.org
Date: Thu Mar 10 16:07:36 2011 +0100
s3: Fix paranoia check in sam_rids_to_names
---
Summary of changes:
libcli/security/util_sid.c |4 +++-
source3/auth/token_util.c|4 +---
source3/lib/util_sid.c |3 +--
source3/libads/ldap.c|3 +--
source3/passdb/lookup_sid.c |3 +--
source3/passdb/machine_sid.c |3 +--
source3/passdb/util_builtin.c|5 ++---
source3/passdb/util_unixsids.c |6 ++
source3/passdb/util_wellknown.c |5 ++---
source3/winbindd/winbindd_samr.c | 18 --
10 files changed, 22 insertions(+), 32 deletions(-)
Changeset truncated at 500 lines:
diff --git a/libcli/security/util_sid.c b/libcli/security/util_sid.c
index 535e81c..cf1f7f3 100644
--- a/libcli/security/util_sid.c
+++ b/libcli/security/util_sid.c
@@ -167,7 +167,9 @@ bool sid_split_rid(struct dom_sid *sid, uint32_t *rid)
{
if (sid-num_auths 0) {
sid-num_auths--;
- *rid = sid-sub_auths[sid-num_auths];
+ if (rid != NULL) {
+ *rid = sid-sub_auths[sid-num_auths];
+ }
return true;
}
return false;
diff --git a/source3/auth/token_util.c b/source3/auth/token_util.c
index 4f617c4..4942740 100644
--- a/source3/auth/token_util.c
+++ b/source3/auth/token_util.c
@@ -849,8 +849,6 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx,
const char *username,
* correct info. AD might prohibit winbind looking up that
* information. */
- uint32 dummy;
-
/* We must always assign the *uid. */
if (!sid_to_uid(user_sid, uid)) {
DEBUG(1, (winbindd case, sid_to_uid for %s (%s)
failed\n,
@@ -868,7 +866,7 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx,
const char *username,
}
sid_copy(group_sids[0], user_sid);
- sid_split_rid(group_sids[0], dummy);
+ sid_split_rid(group_sids[0], NULL);
sid_append_rid(group_sids[0], DOMAIN_RID_USERS);
if (!sid_to_gid(group_sids[0], gid)) {
diff --git a/source3/lib/util_sid.c b/source3/lib/util_sid.c
index 0a026a1..f6210c1 100644
--- a/source3/lib/util_sid.c
+++ b/source3/lib/util_sid.c
@@ -95,10 +95,9 @@ bool sid_linearize(char *outbuf, size_t len, const struct
dom_sid *sid)
bool non_mappable_sid(struct dom_sid *sid)
{
struct dom_sid dom;
- uint32 rid;
sid_copy(dom, sid);
- sid_split_rid(dom, rid);
+ sid_split_rid(dom, NULL);
if (dom_sid_equal(dom, global_sid_Builtin))
return True;
diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
index c1af5b5..3ce7a7e 100644
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -3644,11 +3644,10 @@ ADS_STATUS ads_leave_realm(ADS_STRUCT *ads, const char
*hostname)
* domsid */
struct dom_sid domsid;
- uint32 dummy_rid;
sid_copy(domsid, tmp_user_sid);
- if (!sid_split_rid(domsid, dummy_rid)) {
+ if (!sid_split_rid(domsid, NULL)) {
ads_msgfree(ads, res);
return ADS_ERROR_LDAP(LDAP_NO_MEMORY);
}
diff --git a/source3/passdb/lookup_sid.c b/source3/passdb/lookup_sid.c
index 0901319..23566b6 100644
--- a/source3/passdb/lookup_sid.c
+++ b/source3/passdb/lookup_sid.c
@@ -259,7 +259,6 @@ bool lookup_name(TALLOC_CTX *mem_ctx,
if (IS_DC winbind_lookup_name(, name, sid, type)) {
struct dom_sid dom_sid;
- uint32 tmp_rid;
enum lsa_SidType domain_type;
if (type == SID_NAME_DOMAIN) {
@@ -273,7 +272,7 @@ bool lookup_name(TALLOC_CTX
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via a13560b s3: sid-domain_sid in winbindd_samr sam_rids_to_names
via 0ea36b1 Quite some callers of sid_split_rid do not care about the
rid (cherry picked from commit 16b007c2232cc8432fa9e93409e16367d72b149e)
via 01c3c04 s3: Fix paranoia check in sam_rids_to_names (cherry picked
from commit 8d0e2415309ee15fbf509d44caf3e1df5b900620)
from 902fb32 frstrans.idl: add idl for RawGetFileDataAsync() and
RdcGetFileDataAsync()
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit a13560ba9d373b89c7050a096be058f13ff2b33b
Author: Volker Lendecke v...@samba.org
Date: Thu Mar 10 16:23:20 2011 +0100
s3: sid-domain_sid in winbindd_samr sam_rids_to_names
Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Thu Mar 10 19:33:47 CET 2011 on sn-devel-104
(cherry picked from commit 257f0491cbcc6d8a7d05520ccb3ffa7dd7c27273)
commit 0ea36b18c1c7503854e4b9576ffb4cc24ef1afb9
Author: Volker Lendecke v...@samba.org
Date: Thu Mar 10 16:19:17 2011 +0100
Quite some callers of sid_split_rid do not care about the rid
(cherry picked from commit 16b007c2232cc8432fa9e93409e16367d72b149e)
commit 01c3c044ceae2da194792f6ec140b2af29240678
Author: Volker Lendecke v...@samba.org
Date: Thu Mar 10 16:07:36 2011 +0100
s3: Fix paranoia check in sam_rids_to_names
(cherry picked from commit 8d0e2415309ee15fbf509d44caf3e1df5b900620)
---
Summary of changes:
libcli/security/util_sid.c |4 +++-
source3/auth/token_util.c|4 +---
source3/lib/util_sid.c |3 +--
source3/libads/ldap.c|3 +--
source3/passdb/lookup_sid.c |3 +--
source3/passdb/machine_sid.c |3 +--
source3/passdb/util_builtin.c|5 ++---
source3/passdb/util_unixsids.c |6 ++
source3/passdb/util_wellknown.c |5 ++---
source3/winbindd/winbindd_samr.c | 18 --
10 files changed, 22 insertions(+), 32 deletions(-)
Changeset truncated at 500 lines:
diff --git a/libcli/security/util_sid.c b/libcli/security/util_sid.c
index 535e81c..cf1f7f3 100644
--- a/libcli/security/util_sid.c
+++ b/libcli/security/util_sid.c
@@ -167,7 +167,9 @@ bool sid_split_rid(struct dom_sid *sid, uint32_t *rid)
{
if (sid-num_auths 0) {
sid-num_auths--;
- *rid = sid-sub_auths[sid-num_auths];
+ if (rid != NULL) {
+ *rid = sid-sub_auths[sid-num_auths];
+ }
return true;
}
return false;
diff --git a/source3/auth/token_util.c b/source3/auth/token_util.c
index 4a702ef..3694188 100644
--- a/source3/auth/token_util.c
+++ b/source3/auth/token_util.c
@@ -849,8 +849,6 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx,
const char *username,
* correct info. AD might prohibit winbind looking up that
* information. */
- uint32 dummy;
-
/* We must always assign the *uid. */
if (!sid_to_uid(user_sid, uid)) {
DEBUG(1, (winbindd case, sid_to_uid for %s (%s)
failed\n,
@@ -868,7 +866,7 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx,
const char *username,
}
sid_copy(group_sids[0], user_sid);
- sid_split_rid(group_sids[0], dummy);
+ sid_split_rid(group_sids[0], NULL);
sid_append_rid(group_sids[0], DOMAIN_RID_USERS);
if (!sid_to_gid(group_sids[0], gid)) {
diff --git a/source3/lib/util_sid.c b/source3/lib/util_sid.c
index 0a026a1..f6210c1 100644
--- a/source3/lib/util_sid.c
+++ b/source3/lib/util_sid.c
@@ -95,10 +95,9 @@ bool sid_linearize(char *outbuf, size_t len, const struct
dom_sid *sid)
bool non_mappable_sid(struct dom_sid *sid)
{
struct dom_sid dom;
- uint32 rid;
sid_copy(dom, sid);
- sid_split_rid(dom, rid);
+ sid_split_rid(dom, NULL);
if (dom_sid_equal(dom, global_sid_Builtin))
return True;
diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
index c1af5b5..3ce7a7e 100644
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -3644,11 +3644,10 @@ ADS_STATUS ads_leave_realm(ADS_STRUCT *ads, const char
*hostname)
* domsid */
struct dom_sid domsid;
- uint32 dummy_rid;
sid_copy(domsid, tmp_user_sid);
- if (!sid_split_rid(domsid, dummy_rid)) {
+ if (!sid_split_rid(domsid, NULL)) {
ads_msgfree(ads, res);
return ADS_ERROR_LDAP(LDAP_NO_MEMORY);
}
diff --git a/source3/passdb/lookup_sid.c b/source3/passdb/lookup_sid.c
index cd5cd7d..c0abea0 100644
--- a/source3/passdb/lookup_sid.c
+++
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 8953c7d s3-selftest: add another flaky s3-torture test to
knownfail, this time OPLOCK4.
via af2538d s3-build: remove -I../lib/addns.
via c809824 waf-selftest: allow to call make test
SUBUNIT_FORMATTER=cat.
via 88ff230 s3-waf: fix typo.
via 6076f4b s3-selftest: run a couple of dgram NBT tests against s3.
from 257f049 s3: sid-domain_sid in winbindd_samr sam_rids_to_names
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 8953c7dc266b8ccd03a42e53f38e29610181dd00
Author: Günther Deschner g...@samba.org
Date: Thu Mar 10 23:56:14 2011 +0100
s3-selftest: add another flaky s3-torture test to knownfail, this time
OPLOCK4.
Guenther
Autobuild-User: Günther Deschner g...@samba.org
Autobuild-Date: Fri Mar 11 00:42:27 CET 2011 on sn-devel-104
commit af2538d16fdb8154dbb2d4720104a0fadfebf04f
Author: Günther Deschner g...@samba.org
Date: Fri Mar 4 13:16:40 2011 +0100
s3-build: remove -I../lib/addns.
Guenther
commit c8098246be66a96c5a9dfceab957c3d879746246
Author: Günther Deschner g...@samba.org
Date: Fri Mar 4 14:22:35 2011 +0100
waf-selftest: allow to call make test SUBUNIT_FORMATTER=cat.
Guenther
commit 88ff230ae9543fc22068392f44d8b6033e365abf
Author: Günther Deschner g...@samba.org
Date: Thu Mar 10 15:33:43 2011 +0100
s3-waf: fix typo.
Guenther
commit 6076f4b472bdb392fdea163602d577ca2119fcab
Author: Günther Deschner g...@samba.org
Date: Thu Mar 10 23:17:54 2011 +0100
s3-selftest: run a couple of dgram NBT tests against s3.
Guenther
---
Summary of changes:
source3/.clang_complete|2 +-
source3/configure.in |1 -
source3/selftest/knownfail |2 ++
source3/selftest/tests.py |4 +++-
source3/selftest/wscript |4 +++-
source3/utils/net_ads.c|2 +-
source3/utils/net_dns.c|3 +--
source3/wscript|2 +-
source4/selftest/wscript |4 +++-
9 files changed, 15 insertions(+), 9 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/.clang_complete b/source3/.clang_complete
index a13b5cd..c3f2f30 100644
--- a/source3/.clang_complete
+++ b/source3/.clang_complete
@@ -1,2 +1,2 @@
--I. -I./.. -Iinclude -I./../lib/replace -I./../lib/tevent -I./../lib/addns
-I./librpc -I./../lib/talloc -I../lib/tdb/include
+-I. -I./.. -Iinclude -I./../lib/replace -I./../lib/tevent -I./librpc
-I./../lib/talloc -I../lib/tdb/include
-Iinclude/includes.h.gch
diff --git a/source3/configure.in b/source3/configure.in
index 8d32a1b..74df9d4 100644
--- a/source3/configure.in
+++ b/source3/configure.in
@@ -37,7 +37,6 @@ LIBS=${LIBS} ${TEVENT_LIBS}
SAMBA_CPPFLAGS=-Iinclude -I${srcdir-.}/include -I. -I${srcdir-.}
SAMBA_CPPFLAGS=${SAMBA_CPPFLAGS} -I${srcdir-.}/../lib/replace
SAMBA_CPPFLAGS=${SAMBA_CPPFLAGS} ${TEVENT_CFLAGS}
-SAMBA_CPPFLAGS=${SAMBA_CPPFLAGS} -I${srcdir-.}/../lib/addns
SAMBA_CPPFLAGS=${SAMBA_CPPFLAGS} -I${srcdir-.}/librpc
SAMBA_CPPFLAGS=${SAMBA_CPPFLAGS} -I${srcdir-.}/..
diff --git a/source3/selftest/knownfail b/source3/selftest/knownfail
index 574910c..df2ec9b 100644
--- a/source3/selftest/knownfail
+++ b/source3/selftest/knownfail
@@ -7,3 +7,5 @@ samba3.posix_s3.rpc.spoolss.printer.*addprinterex.print_test #
another intermitt
samba3.posix_s3.smb2.lock.*.rw-exclusive # another intermittent failure
.*driver.add_driver_timestamps # we only can store dates, not timestamps
samba3.raw.mux.* #This test is flaky on the async lock time
+samba3.smbtorture_s3.*OPLOCK4 # fails sometimes on sn-devel
+samba3.posix_s3.nbt.dgram.*netlogon2
diff --git a/source3/selftest/tests.py b/source3/selftest/tests.py
index d9ea831..4094a57 100755
--- a/source3/selftest/tests.py
+++ b/source3/selftest/tests.py
@@ -176,7 +176,9 @@ rap = [rap.basic, rap.rpc, rap.printing, rap.sam]
unix = [unix.info2, unix.whoami]
-tests= base + raw + smb2 + rpc + unix + local + winbind + rap
+nbt = [nbt.dgram ]
+
+tests= base + raw + smb2 + rpc + unix + local + winbind + rap + nbt
sub = subprocess.Popen(%s --version 2 /dev/null % smb4torture,
stdout=subprocess.PIPE, stdin=subprocess.PIPE, shell=True)
sub.communicate()
diff --git a/source3/selftest/wscript b/source3/selftest/wscript
index 9a9cf90..f1c6510 100644
--- a/source3/selftest/wscript
+++ b/source3/selftest/wscript
@@ -85,7 +85,9 @@ def cmd_testonly(opt):
env.TESTS = Options.options.TESTS
-env.SUBUNIT_FORMATTER = '${PYTHON} -u ${srcdir}/selftest/format-subunit
--prefix=${SELFTEST_PREFIX} --immediate'
+env.SUBUNIT_FORMATTER = os.getenv('SUBUNIT_FORMATTER')
+if not env.SUBUNIT_FORMATTER:
+env.SUBUNIT_FORMATTER = '${PYTHON} -u
${srcdir}/selftest/format-subunit --prefix=${SELFTEST_PREFIX} --immediate'
env.FILTER_XFAIL = '${PYTHON} -u
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 0726b29 s3:idmap_ldap: fix a few typos in a comment from 8953c7d s3-selftest: add another flaky s3-torture test to knownfail, this time OPLOCK4. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 0726b29e5967f2d3fba21b6556b4d8c102ab3621 Author: Michael Adam ob...@samba.org Date: Wed Mar 2 17:10:48 2011 +0100 s3:idmap_ldap: fix a few typos in a comment and use the chance to reformat the comment properly... Autobuild-User: Michael Adam ob...@samba.org Autobuild-Date: Fri Mar 11 01:29:09 CET 2011 on sn-devel-104 --- Summary of changes: source3/winbindd/idmap_ldap.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/winbindd/idmap_ldap.c b/source3/winbindd/idmap_ldap.c index 8444d01..aaac75f 100644 --- a/source3/winbindd/idmap_ldap.c +++ b/source3/winbindd/idmap_ldap.c @@ -513,9 +513,10 @@ static NTSTATUS idmap_ldap_db_init(struct idmap_domain *dom, goto done; } - /* set the destructor on the context, so that resource are properly - freed if the contexts is released */ - + /* +* Set the destructor on the context, so that resources are +* properly freed when the context is released. +*/ talloc_set_destructor(ctx, idmap_ldap_close_destructor); dom-private_data = ctx; -- Samba Shared Repository
