Re: [Samba] Samba 3.5.8 / Windows error and system errors while mapping network drive on some PC's

2011-04-16 Thread Volker Lendecke
On Fri, Apr 15, 2011 at 12:36:04PM -0400, Dodson, Eric (COT) wrote:
 Problem: We have a share defined using Samba 3.5.8 on AIX 6.1. Several
 people can map a Windows Network Drive to the share and it works fine.
 Several other people get Windows errors or system errors when trying to
 map a drive to the same share.

Sorry, but the amount of information you are able to give us
is not sufficient to diagnose the problem. What is needed is
a network trace and full, unmodified debug level 10 logs of
smbd. You should make a contract with someone from
http://www.samba.org/samba/support/ including an NDA so that
you can send the information there.

With best regards,

Volker Lendecke

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-37-0, fax: +49-551-37-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Authenticating against local PAM configuration

2011-04-16 Thread Volker Lendecke
On Fri, Apr 15, 2011 at 02:38:45PM -0500, Madhusudan Singh wrote:
 As I mentioned earlier, easy or not, winbind has in the past not proven to
 be stable and easy or not, I want to avoid using it.
 
 The facts of the case are - I have a robust LDAP based authentication that
 is working.
 
 Can I just ask Samba to use the local PAM configuration (regardless of what
 it is) ? That way, if this windows environment changes authentication
 mechanisms again, I will have only thing to fix instead of the mess that ADS
 is (plus, I will need to ask our IT folks to come do a net ads join for us).

If you mean to use PAM for password checking, then
unfortunately it is not possible. The PAM API expects plain
text passwords from the application, something which Samba
does not have. Probably you just can't export CIFS from
Linux if PAM is your only option.

With best regards,

Volker Lendecke

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-37-0, fax: +49-551-37-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[Samba] Problem with CentOS 5.6 samba3x packages

2011-04-16 Thread Taylor, Jonn
All,

I installed samba3x packages from the updates repo and when I run net
join command I get the following error.

net: symbol lookup error: net: undefined symbol: tdb_check

 samba3x 
x86_64  
3.5.4-0.70.el5_6.1 
installed17 M
 samba3x-client  
x86_64  
3.5.4-0.70.el5_6.1 
installed46 M
 samba3x-common  
x86_64  
3.5.4-0.70.el5_6.1 
installed49 M
 samba3x-doc 
x86_64  
3.5.4-0.70.el5_6.1 
installed17 M
 samba3x-domainjoin-gui  
x86_64  
3.5.4-0.70.el5_6.1 
installed52 k
 samba3x-swat
x86_64  
3.5.4-0.70.el5_6.1 
installed13 M
 samba3x-winbind 
x86_64  
3.5.4-0.70.el5_6.1 
installed12 M
 libsmbclient
x86_64  
3.0.33-3.29.el5_6.2
installed   2.2 M

Jonn
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Problem with CentOS 5.6 samba3x packages

2011-04-16 Thread Taylor, Jonn
Fixed it by following https://bugzilla.redhat.com/show_bug.cgi?id=613371

Jonn

On 04/16/2011 06:28 PM, Taylor, Jonn wrote:
 All,

 I installed samba3x packages from the updates repo and when I run net
 join command I get the following error.

 net: symbol lookup error: net: undefined symbol: tdb_check

  samba3x 
 x86_64  
 3.5.4-0.70.el5_6.1 
 installed17 M
  samba3x-client  
 x86_64  
 3.5.4-0.70.el5_6.1 
 installed46 M
  samba3x-common  
 x86_64  
 3.5.4-0.70.el5_6.1 
 installed49 M
  samba3x-doc 
 x86_64  
 3.5.4-0.70.el5_6.1 
 installed17 M
  samba3x-domainjoin-gui  
 x86_64  
 3.5.4-0.70.el5_6.1 
 installed52 k
  samba3x-swat
 x86_64  
 3.5.4-0.70.el5_6.1 
 installed13 M
  samba3x-winbind 
 x86_64  
 3.5.4-0.70.el5_6.1 
 installed12 M
  libsmbclient
 x86_64  
 3.0.33-3.29.el5_6.2
 installed   2.2 M

 Jonn
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[Samba] KDC and samba4

2011-04-16 Thread Andrew Dumaresq

Hi,

I'm using  GIT pull from a few days ago.

I am trying to get ssh working with kerberos when samba is the KDC.  I 
am having trouble getting my machine keytabs to work.  Here's some of 
the problems I have:


1)
root@morannon:~# samba-tool export keytab /tmp/test.keytab
added interface ip=192.168.1.11 nmask=255.255.255.0
added interface ip=127.0.0.1 nmask=255.0.0.0
added interface ip=192.168.1.11 nmask=255.255.255.0
added interface ip=127.0.0.1 nmask=255.0.0.0
ldb_wrap open of secrets.ldb
root@morannon:~# klist -k -t /tmp/test.keytab
Keytab name: WRFILE:/tmp/test.keytab
KVNO Timestamp Principal
 - 


   1 04/16/11 20:04:19 dumareja@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 dumareja@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 dumareja@DUMARESQ.LOCAL
   2 04/16/11 20:04:19 dumaresq@DUMARESQ.LOCAL
   2 04/16/11 20:04:19 dumaresq@DUMARESQ.LOCAL
   2 04/16/11 20:04:19 dumaresq@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 emma@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 emma@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 emma@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 julia@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 julia@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 julia@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 ANCALAGON$@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 ANCALAGON$@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 ANCALAGON$@DUMARESQ.LOCAL
   3 04/16/11 20:04:19 ARAGORN$@DUMARESQ.LOCAL
   3 04/16/11 20:04:19 ARAGORN$@DUMARESQ.LOCAL
   3 04/16/11 20:04:19 ARAGORN$@DUMARESQ.LOCAL
   4 04/16/11 20:04:19 GANDALF$@DUMARESQ.LOCAL
   4 04/16/11 20:04:19 GANDALF$@DUMARESQ.LOCAL
   4 04/16/11 20:04:19 GANDALF$@DUMARESQ.LOCAL
   3 04/16/11 20:04:19 GOLLUM$@DUMARESQ.LOCAL
   3 04/16/11 20:04:19 GOLLUM$@DUMARESQ.LOCAL
   3 04/16/11 20:04:19 GOLLUM$@DUMARESQ.LOCAL
   3 04/16/11 20:04:19 ARWEN$@DUMARESQ.LOCAL
   3 04/16/11 20:04:19 ARWEN$@DUMARESQ.LOCAL
   3 04/16/11 20:04:19 ARWEN$@DUMARESQ.LOCAL
   4 04/16/11 20:04:19 FRODO$@DUMARESQ.LOCAL
   4 04/16/11 20:04:19 FRODO$@DUMARESQ.LOCAL
   4 04/16/11 20:04:19 FRODO$@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 MORANNON$@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 MORANNON$@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 MORANNON$@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 Administrator@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 Administrator@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 Administrator@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 dns-morannon@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 dns-morannon@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 dns-morannon@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 krbtgt@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 krbtgt@DUMARESQ.LOCAL
   1 04/16/11 20:04:19 krbtgt@DUMARESQ.LOCAL
root@morannon:~# samba-tool machinepw 'MORANNON$@DUMARESQ.LOCAL'
ldb_wrap open of secrets.ldb
ERROR: search returned 0 records, expected 1
root@morannon:~# samba-tool machinepw 'MORANNON$'
ldb_wrap open of secrets.ldb
ERROR: search returned 0 records, expected 1


2)  (This is likely related to my previous problem)
I extracted the host keytab from Samba (using ktpass.sh with no 
password) and put the extract info in /etc/krb5.keytab

 klist -k
Keytab name: WRFILE:/etc/krb5.keytab
KVNO Principal
 
--

   1 host/morannon.dumaresq.local@DUMARESQ.LOCAL

but when I try to use that to to run kinit I get this:
 kinit -k
kinit: Client 'host/morannon.dumaresq.local@DUMARESQ.LOCAL' not found in 
Kerberos database while getting initial credentials



I've tried both capital and not capital HOST, I've tried every 
combination of FQDNs and such none of it seems to help.


as a result I can't use ssh to connect using kerberos.

Just make sure I didn't have a DNS issue or something like that I 
shutdown samba and installed a standard kdc  I was able to get 
everything working just fine.  This obviously breaks samba quite badly 
and I as far as I can tell samba4 can't use external kerberos.


Any ideas?

Thanks



--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[Samba] Samba connection problem

2011-04-16 Thread tonight23
Hi,everyone,

I'm currently sharing files with Samba,but  i can't collect the samba 
server.the samba server is a centos5.5 and the client is a windows 7 PC.

I can't find any resolution for this

this is the log

[2011/04/17 11:13:27, 1] smbd/service.c:make_connection_snum(1077)
  192.168.1.14 (192.168.1.14) connect to service public initially as user 
nobody  
(uid=99, gid=99) (pid 9026)
[2011/04/17 11:13:28, 1] smbd/service.c:make_connection_snum(1077)
  192.168.1.14 (192.168.1.14) connect to service exchage initially as user 
nobod   
  y (uid=99, gid=99) (pid 9026)
[2011/04/17 11:13:55, 1] smbd/service.c:close_cnum(1274)
  192.168.1.14 (192.168.1.14) closed connection to service public
[2011/04/17 11:13:55, 1] smbd/service.c:close_cnum(1274)
  192.168.1.14 (192.168.1.14) closed connection to service exchage
[2011/04/17 11:14:25, 0] lib/util_sock.c:read_data(534)
  read_data: read failure for 4 bytes to client 192.168.1.14. Error = 
Connection  
reset by peer


this is my smb.conf 

[global]
workgroup = WORKGROUP
server string = Samba Server
hosts allow = 192.168.1.14
security = share
encrypt passwords = yes
smb passwd file = /etc/samba/smbpasswd

[homes]
comment = Home Directories
browseable = no
writable = yes
valid users = %S
create mode = 0664
directory mode = 0755

 [caiwu]
  comment   =   caiwu
  path   =   /home/samba/caiwu
  public   =   no
  valid   users   =   @caiwu,@lingdao,network02
  write   list   =   caiwu01
  printable   =   no

 [lingdao]
  comment   =   lingdao
  path   =   /home/samba/lingdao
  public   =   no
  browseable   =   no
  valid   users   =   @lingdao,network02
  printable   =   no
  
[exchage]
  comment   =   Exchange   File   Directory
  path   =   /home/samba/exchange
  public   =   yes
  writable   =   yes
 
 [public]
  comment   =   Read   Only   Public
  path   =   /home/samba/public
  public   =   yes
  read   only   =   yes
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


autobuild: intermittent test failure detected

2011-04-16 Thread Andrew Tridgell
The autobuild test system has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey/2011-04-16-0851/flakey.log

The samba3 build logs are available here:

   http://git.samba.org/autobuild.flakey/2011-04-16-0851/samba3.stderr
   http://git.samba.org/autobuild.flakey/2011-04-16-0851/samba3.stdout

The source4 build logs are available here:

   http://git.samba.org/autobuild.flakey/2011-04-16-0851/samba4.stderr
   http://git.samba.org/autobuild.flakey/2011-04-16-0851/samba4.stdout
  
The top commit at the time of the failure was:

commit 82fdad8a4c1e45d171a75b133eff8f9768edd682
Author: Jeremy Allison j...@samba.org
Date:   Fri Apr 15 16:30:17 2011 -0700

Trying to track down the SMB2 error. Add an invariant test.

Autobuild-User: Jeremy Allison j...@samba.org
Autobuild-Date: Sat Apr 16 02:15:38 CEST 2011 on sn-devel-104


[SCM] Samba Shared Repository - branch master updated

2011-04-16 Thread Andrew Bartlett
The branch, master has been updated
   via  2c55a99 util: Build samba-util without unresolved symbols.
   via  d1cbb9f s4-heimdal: Allow any kvno to match when searching the 
keytab.
   via  1f53442 s3-gse Allow GSSAPI wrapper to compile against Heimdal
   via  93f8f7b selftest: Allow the top level build to run the samba4 or 
samba3 tests
   via  ee4a7b3 s4-heimdal_build: Add extra HAVE defines needed for the 
source3 krb5 code
   via  d9e29c0 selftest Remove selftest of the test subsystem
   via  47b7c6f selftest: Move Samba4 selftest wscript to the top level
   via  1870d25 selftest Add binary mappings for samba3 selftest
   via  48bb69e selftest: Start using the binary mapping at the python 
layer as well
   via  4fd6ebf selftest: Remove duplication between BUILDIR and BINDIR
   via  cfb44f6 selftest: Remove unused BUILDDIR_ABS environment variable
   via  831955d selftest: Provide a single bindir_path function across all 
targets
  from  82fdad8 Trying to track down the SMB2 error. Add an invariant test.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 2c55a995fef133c1854058ed5de83185b9325895
Author: Brad Hards br...@frogmouth.net
Date:   Thu Apr 14 16:12:19 2011 +1000

util: Build samba-util without unresolved symbols.

This is useful for the Samba4 case where external users otherwise need to 
link to
(private) libsamba-util-common.

Signed-off-by: Andrew Bartlett abart...@samba.org

Autobuild-User: Andrew Bartlett abart...@samba.org
Autobuild-Date: Sat Apr 16 12:29:33 CEST 2011 on sn-devel-104

commit d1cbb9f5ceb40d0634891086ef1939b3b76daa4f
Author: Andrew Bartlett abart...@samba.org
Date:   Sat Apr 16 15:44:23 2011 +1000

s4-heimdal: Allow any kvno to match when searching the keytab.

Windows does not use a KVNO when it checks it's passwords, and MIT
doesn't check the KVNO when no acceptor identity is specified (looping
over all keys in the keytab).

Andrew Bartlett

commit 1f534422cc09ca72f924643c7518c7f90241a732
Author: Andrew Bartlett abart...@samba.org
Date:   Sat Apr 16 09:22:08 2011 +1000

s3-gse Allow GSSAPI wrapper to compile against Heimdal

commit 93f8f7b579d92c943dfd89011c35f843a566968b
Author: Andrew Bartlett abart...@samba.org
Date:   Sat Apr 16 08:47:50 2011 +1000

selftest: Allow the top level build to run the samba4 or samba3 tests

This is selected with for example

./buildtools/bin/waf test --target=samba3

Andrew Bartlett

commit ee4a7b3530d00ce514f43dc5e7e2a3b886a86de6
Author: Andrew Bartlett abart...@samba.org
Date:   Sat Apr 16 08:46:25 2011 +1000

s4-heimdal_build: Add extra HAVE defines needed for the source3 krb5 code

commit d9e29c0250a052474936540e3768de2dcdaaeac9
Author: Andrew Bartlett abart...@samba.org
Date:   Fri Apr 15 16:58:50 2011 +1000

selftest Remove selftest of the test subsystem

The intereactions between selftest.pl and the target are now too
complex to unit test like this any more.

Andrew Bartlett

commit 47b7c6fccf944ae2ae4bdbfa983adfa1d12204df
Author: Andrew Bartlett abart...@samba.org
Date:   Fri Apr 15 16:42:35 2011 +1000

selftest: Move Samba4 selftest wscript to the top level

commit 1870d254956ec56b8116a923adc38f8aae675963
Author: Andrew Bartlett abart...@samba.org
Date:   Fri Apr 15 16:39:53 2011 +1000

selftest Add binary mappings for samba3 selftest

This will help us have a top level 'make test', working around the
fact that the --eanble-s3build has different names for some of these
binaries, without fixing the names forever (we can just change the
mapping later).

Andrew Bartlett

commit 48bb69ef001be8270ddf145fa4884a2c5ddc2645
Author: Andrew Bartlett abart...@samba.org
Date:   Fri Apr 15 15:17:58 2011 +1000

selftest: Start using the binary mapping at the python layer as well

commit 4fd6ebf544f90a6d18e6828eb3edc7b75f3b90a2
Author: Andrew Bartlett abart...@samba.org
Date:   Fri Apr 15 12:41:22 2011 +1000

selftest: Remove duplication between BUILDIR and BINDIR

Just have BINDIR, and have it default to ./bin

Andrew Bartlett

commit cfb44f63a4eadfd34c0cf7b003b677e43284376f
Author: Andrew Bartlett abart...@samba.org
Date:   Fri Apr 15 12:28:21 2011 +1000

selftest: Remove unused BUILDDIR_ABS environment variable

commit 831955ddf2d2d11b27318d8960d44c6ae9da624f
Author: Andrew Bartlett abart...@samba.org
Date:   Fri Apr 15 12:27:30 2011 +1000

selftest: Provide a single bindir_path function across all targets

This will allow a mapping to be made between things like smbtorture4
- smbtorture that is correct for the different build environments.

Andrew Bartlett

---

Summary of changes:
 lib/util/wscript_build  |   

[SCM] Samba Shared Repository - branch master updated

2011-04-16 Thread Jelmer Vernooij
The branch, master has been updated
   via  9f9d183 Remove broken link.
  from  2c55a99 util: Build samba-util without unresolved symbols.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 9f9d183c18527be72dc05cf543d735af15f9d4e8
Author: Jelmer Vernooij jel...@samba.org
Date:   Sat Apr 16 13:46:07 2011 +0200

Remove broken link.

Autobuild-User: Jelmer Vernooij jel...@samba.org
Autobuild-Date: Sat Apr 16 14:59:15 CEST 2011 on sn-devel-104

---

Summary of changes:
 docs-xml/Samba3-HOWTO/TOSHARG-Problems.xml |4 
 1 files changed, 0 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/docs-xml/Samba3-HOWTO/TOSHARG-Problems.xml 
b/docs-xml/Samba3-HOWTO/TOSHARG-Problems.xml
index 8f1d3c1..9620e6c 100644
--- a/docs-xml/Samba3-HOWTO/TOSHARG-Problems.xml
+++ b/docs-xml/Samba3-HOWTO/TOSHARG-Problems.xml
@@ -219,10 +219,6 @@ information on how to do this. Copy the files from a 
working Netmon installation
 titleUseful URLs/title
 itemizedlist
 
-listitemparaSee how Scott Merrill simulates a BDC behavior at 
-   ulink noescape=1 url=http://www.skippy.net/linux/smb-howto.html;
-   http://www.skippy.net/linux/smb-howto.html/ulink. /para/listitem
-
 listitemparaFTP site for older SMB specs, 
ulink noescape=1 url=ftp://ftp.microsoft.com/developr/drg/CIFS/;
ftp://ftp.microsoft.com/developr/drg/CIFS//ulink/para/listitem.


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated

2011-04-16 Thread Volker Lendecke
The branch, master has been updated
   via  ca5dcf2 s3: guest sesssetup is only 13 words (cherry picked from 
commit 69650a2aaa8649570261df7efccb35ad76d7cfc1)
   via  35c7123 s3: Remove an unused variable
   via  10a552a s3: Use tevent_req_nterror properly in a few places
  from  9f9d183 Remove broken link.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit ca5dcf241289fb3489bf9da9ea5dfd1de0a67fab
Author: Volker Lendecke v...@samba.org
Date:   Sat Apr 2 23:53:27 2011 +0200

s3: guest sesssetup is only 13 words
(cherry picked from commit 69650a2aaa8649570261df7efccb35ad76d7cfc1)

Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Sat Apr 16 16:20:08 CEST 2011 on sn-devel-104

commit 35c71231accaa2f24a70f4066b967fa4999428f1
Author: Volker Lendecke v...@samba.org
Date:   Sat Apr 16 15:27:53 2011 +0200

s3: Remove an unused variable

commit 10a552a9570bd274796639ba80d46d2d22828271
Author: Volker Lendecke v...@samba.org
Date:   Sat Apr 2 16:02:23 2011 +0200

s3: Use tevent_req_nterror properly in a few places

---

Summary of changes:
 source3/lib/tldap.c   |3 ---
 source3/libsmb/cliconnect.c   |2 +-
 source3/libsmb/clireadwrite.c |   18 ++
 3 files changed, 7 insertions(+), 16 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/tldap.c b/source3/lib/tldap.c
index 2f45a05..cd1dea5 100644
--- a/source3/lib/tldap.c
+++ b/source3/lib/tldap.c
@@ -558,7 +558,6 @@ static void tldap_msg_received(struct tevent_req *subreq)
subreq, struct tldap_context);
struct tevent_req *req;
struct tldap_msg_state *state;
-   struct tevent_context *ev;
struct asn1_data *data;
uint8_t *inbuf;
ssize_t received;
@@ -617,8 +616,6 @@ static void tldap_msg_received(struct tevent_req *subreq)
state-inbuf = talloc_move(state, inbuf);
state-data = talloc_move(state, data);
 
-   ev = state-ev;
-
talloc_set_destructor(req, NULL);
tldap_msg_unset_pending(req);
num_pending = talloc_array_length(ld-pending);
diff --git a/source3/libsmb/cliconnect.c b/source3/libsmb/cliconnect.c
index aa9207f..e3d97b6 100644
--- a/source3/libsmb/cliconnect.c
+++ b/source3/libsmb/cliconnect.c
@@ -169,7 +169,7 @@ static uint32 cli_session_setup_capabilities(struct 
cli_state *cli)
 
 struct cli_session_setup_guest_state {
struct cli_state *cli;
-   uint16_t vwv[16];
+   uint16_t vwv[13];
struct iovec bytes;
 };
 
diff --git a/source3/libsmb/clireadwrite.c b/source3/libsmb/clireadwrite.c
index 59f8ac3..e243f8a 100644
--- a/source3/libsmb/clireadwrite.c
+++ b/source3/libsmb/clireadwrite.c
@@ -148,8 +148,7 @@ struct tevent_req *cli_read_andx_send(TALLOC_CTX *mem_ctx,
}
 
status = cli_smb_req_send(subreq);
-   if (!NT_STATUS_IS_OK(status)) {
-   tevent_req_nterror(req, status);
+   if (tevent_req_nterror(req, status)) {
return tevent_req_post(req, ev);
}
return req;
@@ -282,8 +281,7 @@ static void cli_readall_done(struct tevent_req *subreq)
NTSTATUS status;
 
status = cli_read_andx_recv(subreq, received, buf);
-   if (!NT_STATUS_IS_OK(status)) {
-   tevent_req_nterror(req, status);
+   if (tevent_req_nterror(req, status)) {
return;
}
 
@@ -569,8 +567,7 @@ static void cli_pull_read_done(struct tevent_req *subreq)
 
status = state-sink((char *)top_subreq-buf,
 top_subreq-received, state-priv);
-   if (!NT_STATUS_IS_OK(status)) {
-   tevent_req_nterror(state-req, status);
+   if (tevent_req_nterror(state-req, status)) {
return;
}
state-pushed += top_subreq-received;
@@ -1013,8 +1010,7 @@ struct tevent_req *cli_write_andx_send(TALLOC_CTX 
*mem_ctx,
}
 
status = cli_smb_req_send(subreq);
-   if (!NT_STATUS_IS_OK(status)) {
-   tevent_req_nterror(req, status);
+   if (tevent_req_nterror(req, status)) {
return tevent_req_post(req, ev);
}
return req;
@@ -1114,8 +1110,7 @@ static void cli_writeall_written(struct tevent_req 
*subreq)
 
status = cli_write_andx_recv(subreq, written);
TALLOC_FREE(subreq);
-   if (!NT_STATUS_IS_OK(status)) {
-   tevent_req_nterror(req, status);
+   if (tevent_req_nterror(req, status)) {
return;
}
 
@@ -1313,8 +1308,7 @@ static void cli_push_written(struct tevent_req *subreq)
status = cli_writeall_recv(subreq);
TALLOC_FREE(subreq);
TALLOC_FREE(substate);
-   if (!NT_STATUS_IS_OK(status)) {
-   tevent_req_nterror(req,