[Samba] [Announce] Samba 3.5.9 Available for Download
=== There can't be a crisis next week. My schedule is already full. Henry A. Kissinger == Release Announcements = This is the latest stable release of Samba 3.5. Major enhancements in Samba 3.5.9 include: o Sgid bit lost on folder rename (bug #7996). o ACL can get lost when files are being renamed (bug #7987). o Respect allow trusted domains = no in Winbind (bug #6966). Changes since 3.5.8: o Jeremy Allison j...@samba.org * BUG 6911: Kerberos authentication from Vista to Samba fails when security blob size is greater than 16 kB. * BUG 7080: Quota only shown when logged as root. * BUG 7528: Fix Solaris with NIS autohome. * BUG 7987: ACL can get lost when files are being renamed. * BUG 7996: sgid bit lost on folder rename. * BUG 8040: Fix 'smbclient' segfaults when a Cyrillic netbios name or workgroup is configured. * BUG 8072: Fix panic in create_file_acl_common. * BUG 8038: Fix is_myname_or_ipaddr() to be robust against strange DNS setups. * BUG 8083: inherit owner = yes doesn't interact correctly with vfs_acl_xattr or vfs_acl_tdb module. * BUG 8088: Fix segfault in rpccli_samr_chng_pswd_auth_crap if any input blobs are null. * BUG 8111: CIFS VFS: Fix unexpected error on SMB posix open. * BUG 8157: Fix parsing CUPS printcap files in std_pcap_cache_reload(). * BUG 8163: Fix our asn.1 parser to handle negative numbers. * BUG 8211: inherit owner = yes doesn't interact correctly with inherit permissions = yes. o Christian Ambach a...@samba.org * BUG 8008: Fix a segfault in the krb5 locator plugin. * BUG 8012: Use getgrset() instead of initgroups() + getgroups() when getgrouplist() is not defined. * BUG 8031: Convert gpfs:sharemodes and gpfs:leases parameters from a global setting to a per share setting. o Andrew Bartlett abart...@samba.org * BUG 7893: Don't ever ask for machine$ principals as a target. o Björn Baumbach b...@sernet.de * BUG 8074: Fix debug message. o Dmitry Butskoy dmi...@butskoy.name * BUG 6966: Respect allow trusted domains = no in Winbind. o Marc A. Dahlhaus m...@wol.de * BUG 8047: Fix mdns registration if interfaces= is used. o Günther Deschner g...@samba.org * BUG 7993: Make sure we don't crash when publishing a single printer. * BUG 8085: Fix incorrect timeout handling in ncacn_ip_tcp client code. * BUG 8132: Fix filling printers location field when using CUPS. o David Disseldorp dd...@suse.de * BUG 7836: Make newly added printers visible to clients. * BUG 7994: Use printcap IDL for IPC. o Björn Jacke b...@sernet.de * BUG 7825: Fix GNU ld version detection with old gcc releases. * BUG 8033: Add explicit configure option whether to enable dmapi support or not. o Sergey Korsak s...@1plus1.net * BUG 8099: setpwent() actually does endpwent() on FreeBSD. o Volker Lendecke v...@samba.org * BUG 8009: Fix getting username in 'net rap session'. * BUG 8011: Fix memory corruption in shadow_copy2. * BUG 8016: Fix gpfs_get_xattr. * BUG 8042: File creation on OS/X. * BUG 8054: Winbind cache stores/retrieves wrong sizes for 16-bit ints. * BUG 8066: Fix wrong output in 'smbget'. * BUG 8087: Fix wbcChangeUserPasswordEx in RESPONSE mode. o Nikolay Martynov mar.ko...@gmail.com * BUG 8010: Fix inode generation so nautilus can count total dir size correctly. o Jim McDonough j...@samba.org * BUG 6364: Pull realm from supplied username on libnet join. * BUG 8166: Don't lockout users when offline. o Stefan Metzmacher me...@samba.org * BUG 7383: Normalize IPv4 mapped IPv6 addresses in both directions. * BUG 8034: SEC_STD_DELETE is always granted to the owner of a file. o Larry Reid lcr...@jadesystems.ca * BUG 8055: Can't see Parts of DFS CIFS share. o Simo Sorce i...@samba.org * BUG 7610: winbindd_cache.tdb grows too large when scaled. o Martin Vogt martin.v...@itwm.fraunhofer.de * BUG 6762: Fix ctdb on gpfs error with MS Office. ## Reporting bugs Development Discussion ### Please discuss this release on the samba-technical mailing list or by joining the #samba-technical IRC channel on irc.freenode.net. If you do report problems then please try to send high quality feedback. If you don't provide vital information to help us track down the problem then you will probably be ignored. All bug reports should be filed under the Samba 3.5 product in the project's Bugzilla database (https://bugzilla.samba.org/).
[Samba] Active Directory member server
I am trying to setup samba as a Windows front end to a CUPS print server. We seem to be having some problems getting the server registered in the domain and for users to be able to connect to the server. Our problems seems to stem from the fact that we add our machines to one domain which has a one way trust to a different domain which is where all of the user account reside and authentication is handled. I was able to get the net adc join command to work by using the primary domain administrator credentials. Any help on getting the correct runes into my smb.conf and krb5.conf files greatly appreciated. My krb5.conf file is as follows [libdefaults] default_realm = X.NET dns_lookup_realm = false dns_lookup_kdc = false ticket_lifetime = 24h forwardable = yes [realms] A.X.NET = { kdc = dc01.a.x.net kdc = dc02.a.x.net admin_server = dc02.a.x.net } [domain_realm] .a.x.net = A.X.NET My smb.conf file is as follows [global] workgroup = A realm = a.x.net security = ADS encrypt passwords = yes Many Thanks James -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Another Samba and Win 7
I'm running Samba 3.3.8 and only using it for shares. I am able to connect and mount the shared drive in Win7. However, if I attempt to do any operations on that volume, there is a long delay, usually followed by a connection reset. The information I've seen up to this point is related to joining a windows 7 machine to the samba domain. In this case, I'd just like to mount a shared volume. Any thoughts or direction to an existing/past thread would be greatly appreciated. Terry The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance HelpLine at http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Samba4 + Kerberos cross-realms + ldap
Quick and easy question: I have a network which already has its own kerberos + ldap servers running and I want to setup a samba4 box as AD. So, from conversations here and on irc, the best thing to do is to setup the samba4's built-in kerberos to do cross-realm authentication with the other kerberos server. Now, how would those crossed users look like in samba? Or, how would they be created in the samba4 ldap so they would have, among other things, a local home directory (or wherever the homedir; it just have to be in a place samba can find, know what to do with it, and do it) which would the be exported? -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] UID mapping
Hi, I'm trying to convert an old system on Solaris 10 that uses the smbpasswd file authentication method to a system that authenticates against Active Directory. I've managed to get winbind working but of course this just allocates UIDs as it sees fit whereas the smbpasswd file method used the UID from the /etc/passwd file. The user codes on the Solaris server match the user codes in AD but if I just switch over to winbind the UIDs will not match. If there were only a small number of users I could simply change the ownership of the users home directories to match the winbind allocated UID but unfortunately there are thousands of users and so this would be a mammoth task. I've has a look at various bits of documentation but can't get my head around the best strategy. Has anyone needed to do something similar and if so how did you go about it? Also the users' home directories are distributed around multiple directories and I would prefer to continue to use the home directory information from /etc/passwd as opposed to using template homedir (although I assume that I could leave the directories in place and just set up links to them). I've had also had a look at the PADL nss_ldap stuff but can't get it to compile, it seems to be looking for SASL, would the SASL version on the Sun Freeware site work? Martin. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] quite dramatic and sudden problem...
Hi all I'm running since a couple of years a samba ver 3.0.33-3.29.el5_6.2 On a Red Hat 5 with kernel 2.6.18. Samba is member of a domain, with short name BNNAS03; some shares are using domain users, some are anonymous, open to a list of IPs. Suddenly is happening that, from my win7 computer is all ok if I call is with \\bnnas03 I see all shares, I can access and so on. If I call with its IP \\10.101.40.3 I get the error no process is at the other end of pipe. Same with many computers running win 2003 or 2008. So computers out of domain who were calling it \\10.101.40.3 cannot access their shares anymore :( The only recent changing in network is that old win2003 domain controllers have been replaced by new ones win2008. Wbinfo -u gets all users and groups regulary Any idea other that trying to use another security type in samba?? Thank you so much in advance This is my conf. file [global] workgroup = POL realm = POL.DOM server string = BNNAS03 (Samba %v) security = ADS map to guest = Bad Password log file = /var/log/samba/%m.log max log size = 50 socket options = TCP_NODELAY IPTOS_LOWDELAY load printers = No printcap name = /dev/null disable spoolss = Yes show add printer wizard = No idmap uid = 1-2 idmap gid = 1-2 winbind cache time = 10 winbind use default domain = Yes winbind nss info = rfc2307 and this is one of my shares (anonymous access) [gcpavalonanon] comment = Condivisione path = /storage/samba/GCP/avalon force group = gcp read only = No create mask = 0777 directory mask = 0777 guest ok = Yes hosts allow = 10.101.37.23, 10.101.37.22, 10.101.37.24, 10.107.59.51, 10.107.59.52, 10.101.1.10 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] quite dramatic and sudden problem...
On Tue, Jun 14, 2011 at 08:00:47PM +0200, Alessandro Tinivelli wrote: Hi all I'm running since a couple of years a samba ver 3.0.33-3.29.el5_6.2 On a Red Hat 5 with kernel 2.6.18. Samba is member of a domain, with short name BNNAS03; some shares are using domain users, some are anonymous, open to a list of IPs. Suddenly is happening that, from my win7 computer is all ok if I call is with \\bnnas03 I see all shares, I can access and so on. If I call with its IP \\10.101.40.3 I get the error no process is at the other end of pipe. Same with many computers running win 2003 or 2008. Any panic messages from smbd in /var/log/messages of /var/log/samba/ ? Volker -- SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-37-0, fax: +49-551-37-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] quite dramatic and sudden problem...
I had a similar experience a few years back... mine turned out to be that the network mask on the linux machine didn't match the office network mask. Sometimes machines would work, sometimes not, such a simple thing took forever to figure out because we kept tyring to sort out why the windows7 machines didn't want to talk with the samba machines. Maybe not your issue, but perhaps it's something equally simple for you? On Tue, 14 Jun 2011 20:00:47 +0200 Alessandro Tinivelli alessandro.tinive...@monrif.net wrote: Hi all I'm running since a couple of years a samba ver 3.0.33-3.29.el5_6.2 On a Red Hat 5 with kernel 2.6.18. Samba is member of a domain, with short name BNNAS03; some shares are using domain users, some are anonymous, open to a list of IPs. Suddenly is happening that, from my win7 computer is all ok if I call is with \\bnnas03 I see all shares, I can access and so on. If I call with its IP \\10.101.40.3 I get the error no process is at the other end of pipe. Same with many computers running win 2003 or 2008. So computers out of domain who were calling it \\10.101.40.3 cannot access their shares anymore :( The only recent changing in network is that old win2003 domain controllers have been replaced by new ones win2008. Wbinfo -u gets all users and groups regulary Any idea other that trying to use another security type in samba?? Thank you so much in advance This is my conf. file [global] workgroup = POL realm = POL.DOM server string = BNNAS03 (Samba %v) security = ADS map to guest = Bad Password log file = /var/log/samba/%m.log max log size = 50 socket options = TCP_NODELAY IPTOS_LOWDELAY load printers = No printcap name = /dev/null disable spoolss = Yes show add printer wizard = No idmap uid = 1-2 idmap gid = 1-2 winbind cache time = 10 winbind use default domain = Yes winbind nss info = rfc2307 and this is one of my shares (anonymous access) [gcpavalonanon] comment = Condivisione path = /storage/samba/GCP/avalon force group = gcp read only = No create mask = 0777 directory mask = 0777 guest ok = Yes hosts allow = 10.101.37.23, 10.101.37.22, 10.101.37.24, 10.107.59.51, 10.107.59.52, 10.101.1.10 -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- Jack Downes j...@nwmt.us -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] HP Laserjet WinXP driver install on samba 3.2.5 -- explorer.exe crash
Hi folks, I have a samba PDC with about 5 printers (from HP, Kyocera and Canon) and except the one HP Laserjet 2055 PCL6 all drivers (installed via 'Add Printer Wizard Driver Installation') for all printers did install well and without major issues in the print$-driver-share. With this driver all seems well until I finally hit the ok-button in the printer properties dialog after the copying of the driver to the samba server finished... then a few seconds nothing happens, and then either a crash with Explorer.exe has encountered a problem and needs to close or the Data Execution Prevention thingy shouts around (when not disabled), with essentially the same thing: explorer closed. If I try to access the printer properties after that not-so-successful-driver-install I get this message Function address 0xNN caused a protection fault. Some or all property page(s) may not be displayed. and nothing at all is shown. If I try to add the printer on a WinXP workstation nevertheless with something like rundll32 printui.dll,PrintUIEntry /in /n \\SERVER\printerl, the driver installs ok, but as soon as I try to open the properties dialog of that printer OR try to print something from e.g. word.exe, the whole application (from which I tried to print) or explorer.exe crashes as well... As it seems I can install the driver manually on the workstation and then it works without crashing anything... For sure I tried this procedure on at least three different workstations in all sorts of combinations, the outcome is always the same. All WinXP SP3 current, does anyone have an idea what goes wrong there and if there is a possible fix? I know that samba version is rather old (Debian oldstable lenny) and I will upgrade the whole box in the next few days, but that needs some planning before and it would be nice if the printer thing would be resolved then. :) regards Michael -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] 20 char usersname on windows 7
Hi Friends, I have a samba PDC running as a domain of 200 pc. Samba uses LDAP as a backend. The windows are attached to windows xp domain, and we have no problem. Now we need to migrate from Windows XP to Windows 7. The problem is that we have users whose name is longer than 20 characters. In tests we have done, these users (username 20 chars), can not log in to computers with Windows 7. However, in Windows XP, they log in without problems. Obviously, users with less than 20 characters log in without problems on windows7. Any ideas? Thanks -- Jorge C. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] 20 char usersname on windows 7
On Tue, Jun 14, 2011 at 04:08:57PM -0400, Jorge Concha C. wrote: I have a samba PDC running as a domain of 200 pc. Samba uses LDAP as a backend. The windows are attached to windows xp domain, and we have no problem. Now we need to migrate from Windows XP to Windows 7. The problem is that we have users whose name is longer than 20 characters. In tests we have done, these users (username 20 chars), can not log in to computers with Windows 7. However, in Windows XP, they log in without problems. Obviously, users with less than 20 characters log in without problems on windows7. Any ideas? https://bugzilla.samba.org/show_bug.cgi?id=7343 Known problem, very likely a Windows bug. Volker -- SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen phone: +49-551-37-0, fax: +49-551-37-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] UID mapping
Martin Rootes wrote: Hi, I'm trying to convert an old system on Solaris 10 that uses the smbpasswd file authentication method to a system that authenticates against Active Directory. I've managed to get winbind working but of course this just allocates UIDs as it sees fit whereas the smbpasswd file method used the UID from the /etc/passwd file. The user codes on the Solaris server match the user codes in AD but if I just switch over to winbind the UIDs will not match. If there were only a small number of users I could simply change the ownership of the users home directories to match the winbind allocated UID but unfortunately there are thousands of users and so this would be a mammoth task. I've has a look at various bits of documentation but can't get my head around the best strategy. Has anyone needed to do something similar and if so how did you go about it? Also the users' home directories are distributed around multiple directories and I would prefer to continue to use the home directory information from /etc/passwd as opposed to using template homedir (although I assume that I could leave the directories in place and just set up links to them). I've had also had a look at the PADL nss_ldap stuff but can't get it to compile, it seems to be looking for SASL, would the SASL version on the Sun Freeware site work? Would not filling out the rfc2307 information in the AD not be the way forward? Then winbind would not be allocating UID's but using what was set in the AD which you could match with your current settings. In addition you could have your home directories wherever you want on a per user basis depending on what you have set in the AD. If you are going to be using AD then it is best not to fight it, and any AD server after 2003 R2 has the rfc2307 scheme extensions activated, you just need to populate the fields. Though I appreciate that sometimes this can be easier said than done if you don't have control over the AD servers. JAB. -- Jonathan A. Buzzard Email: jonathan (at) buzzard.me.uk Fife, United Kingdom. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] UID mapping
On Tue, 14 Jun 2011 23:28:49 +0100, Jonathan Buzzard wrote: Martin Rootes wrote: Hi, I'm trying to convert an old system on Solaris 10 that uses the smbpasswd file authentication method to a system that authenticates against Active Directory. I've managed to get winbind working but of course this just allocates UIDs as it sees fit whereas the smbpasswd file method used the UID from the /etc/passwd file. The user codes on the Solaris server match the user codes in AD but if I just switch over to winbind the UIDs will not match. If there were only a small number of users I could simply change the ownership of the users home directories to match the winbind allocated UID but unfortunately there are thousands of users and so this would be a mammoth task. I've has a look at various bits of documentation but can't get my head around the best strategy. Has anyone needed to do something similar and if so how did you go about it? Also the users' home directories are distributed around multiple directories and I would prefer to continue to use the home directory information from /etc/passwd as opposed to using template homedir (although I assume that I could leave the directories in place and just set up links to them). I've had also had a look at the PADL nss_ldap stuff but can't get it to compile, it seems to be looking for SASL, would the SASL version on the Sun Freeware site work? Would not filling out the rfc2307 information in the AD not be the way forward? Then winbind would not be allocating UID's but using what was set in the AD which you could match with your current settings. In addition you could have your home directories wherever you want on a per user basis depending on what you have set in the AD. If you are going to be using AD then it is best not to fight it, and any AD server after 2003 R2 has the rfc2307 scheme extensions activated, you just need to populate the fields. Though I appreciate that sometimes this can be easier said than done if you don't have control over the AD servers. JAB. -- Jonathan A. Buzzard Email: jonathan (at) buzzard.me.uk Fife, United Kingdom. I have been working on exactly this problem. I looked into the rfc2307scheme extensions and it looked like a lot of trouble. The samba HowTo has this to say about it. The use of this method is messy. The information provided in the following is for guidance only and is very definitely not complete. This method does work; it is used in a number of large sites and has an acceptable level of performance. see samba.org/samba/docs/man/Samba-HOWTO-Collection/idmapper.html I also noticed that, to quote the HowTo again If winbindd is not running, smbd (which calls winbindd) will fall back to using purely local information from /etc/passwd and /etc/group and no dynamic mapping will be used. On an operating system that has been enabled with the NSS, the resolution of user and group information will be accomplished via NSS. see www.samba.org/samba/docs/man/Samba-HOWTO-Collection/winbind.html . This is the solution that I am now implementing. It looks to be working but I still have some testing to do. This is the way that another system works here and we have had no trouble with it. If you have multiple domains then you have to be vary careful doing this. We have one master OpenLDAP server and we create accounts on all domains from that. We know that John on one domain is the same person as John on all the others. The linux samba servers are just setup so that nss gets account info from the master LDAP server but the smb.conf gets Auth info from the AD Domian controller. Password changing on the windows and linux machines have been disabled and all password changes are done through a website. This site then updates the LDAP and AD passwords. Peter -- -- Peter Shevchenko Email:peter.shevche...@rsise.anu.edu.au IT Administrator ANU College of Engineering and Computer Science -- /home/users/petershev/signature-file.txt -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 8096b1a s3:smbd/quotas: add #include system/filesys.h (bug #8224) from 9923a8c s3:proto.h: remove prototypes of error functions moved to common code. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 8096b1a9a4b1518467e7a85bb9000904a76c1ac4 Author: Stefan Metzmacher me...@samba.org Date: Tue Jun 14 08:27:34 2011 +0200 s3:smbd/quotas: add #include system/filesys.h (bug #8224) This should fix the build on FreeBSD metze Autobuild-User: Stefan Metzmacher me...@samba.org Autobuild-Date: Tue Jun 14 09:38:49 CEST 2011 on sn-devel-104 --- Summary of changes: source3/smbd/quotas.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/smbd/quotas.c b/source3/smbd/quotas.c index c9f85b6..4151662 100644 --- a/source3/smbd/quotas.c +++ b/source3/smbd/quotas.c @@ -26,6 +26,7 @@ #include includes.h #include smbd/smbd.h +#include system/filesys.h #undef DBGC_CLASS #define DBGC_CLASS DBGC_QUOTA -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via d575b2b samba-tool: disable validation on removing an empty attribute in dbcheck via 2320221 pyldb: make ldb operations more consistent via 8741f03 pyldb: added validate option to ldb.modify() from 8096b1a s3:smbd/quotas: add #include system/filesys.h (bug #8224) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit d575b2b0aba0aeaf73d82e2ed58150110db4025b Author: Andrew Tridgell tri...@samba.org Date: Tue Jun 14 16:43:10 2011 +1000 samba-tool: disable validation on removing an empty attribute in dbcheck Autobuild-User: Andrew Tridgell tri...@samba.org Autobuild-Date: Tue Jun 14 10:49:34 CEST 2011 on sn-devel-104 commit 23202211050b3b3d41632d2bf2795249644d7e8a Author: Andrew Tridgell tri...@samba.org Date: Tue Jun 14 16:41:35 2011 +1000 pyldb: make ldb operations more consistent This changes the controls option on ldb operations to be a keyword argument, which is more consistent with general python conventions. This also fixes the pydoc output to include the controls option. commit 8741f039955853c092c45cc7f2cedca2384b4c57 Author: Andrew Tridgell tri...@samba.org Date: Tue Jun 14 16:39:49 2011 +1000 pyldb: added validate option to ldb.modify() This allows validation of ldb messages in a ldb modify operation to be bypassed, by setting validate=False. This is useful in the dbcheck tool to allow for removing invalid empty attributes from the database --- Summary of changes: source4/lib/ldb/pyldb.c | 57 ++ source4/scripting/python/samba/netcmd/dbcheck.py |2 +- 2 files changed, 37 insertions(+), 22 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/lib/ldb/pyldb.c b/source4/lib/ldb/pyldb.c index 68f9098..61662f6 100644 --- a/source4/lib/ldb/pyldb.c +++ b/source4/lib/ldb/pyldb.c @@ -819,7 +819,7 @@ static PyObject *py_ldb_connect(PyLdbObject *self, PyObject *args, PyObject *kwa Py_RETURN_NONE; } -static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args) +static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args, PyObject *kwargs) { PyObject *py_msg; PyObject *py_controls = Py_None; @@ -829,8 +829,12 @@ static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args) struct ldb_message *msg; int ret; TALLOC_CTX *mem_ctx; + bool validate=true; + const char * const kwnames[] = { message, controls, validate, NULL }; - if (!PyArg_ParseTuple(args, O|O, py_msg, py_controls)) + if (!PyArg_ParseTupleAndKeywords(args, kwargs, O|Ob, +discard_const_p(char *, kwnames), +py_msg, py_controls, validate)) return NULL; mem_ctx = talloc_new(NULL); @@ -855,11 +859,13 @@ static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args) } msg = PyLdbMessage_AsMessage(py_msg); - ret = ldb_msg_sanity_check(ldb_ctx, msg); - if (ret != LDB_SUCCESS) { - PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, ldb_ctx); - talloc_free(mem_ctx); - return NULL; + if (validate) { + ret = ldb_msg_sanity_check(ldb_ctx, msg); + if (ret != LDB_SUCCESS) { + PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, ldb_ctx); + talloc_free(mem_ctx); + return NULL; + } } ret = ldb_build_mod_req(req, ldb_ctx, mem_ctx, msg, parsed_controls, @@ -958,7 +964,7 @@ static struct ldb_message *PyDict_AsMessage(TALLOC_CTX *mem_ctx, return msg; } -static PyObject *py_ldb_add(PyLdbObject *self, PyObject *args) +static PyObject *py_ldb_add(PyLdbObject *self, PyObject *args, PyObject *kwargs) { PyObject *py_obj; int ret; @@ -968,8 +974,11 @@ static PyObject *py_ldb_add(PyLdbObject *self, PyObject *args) PyObject *py_controls = Py_None; TALLOC_CTX *mem_ctx; struct ldb_control **parsed_controls; + const char * const kwnames[] = { message, controls, NULL }; - if (!PyArg_ParseTuple(args, O|O, py_obj, py_controls )) + if (!PyArg_ParseTupleAndKeywords(args, kwargs, O|O, +discard_const_p(char *, kwnames), +py_obj, py_controls)) return NULL; mem_ctx = talloc_new(NULL); @@ -1047,7 +1056,7 @@ static PyObject *py_ldb_add(PyLdbObject *self, PyObject *args) Py_RETURN_NONE; } -static PyObject *py_ldb_delete(PyLdbObject *self, PyObject *args) +static PyObject *py_ldb_delete(PyLdbObject *self, PyObject *args, PyObject *kwargs) {
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 7639684 s3-utils: fix crash in net cache get from d575b2b samba-tool: disable validation on removing an empty attribute in dbcheck http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 7639684f273e33e2b7f26660b3ec9d3f9979c5a7 Author: Christian Ambach a...@samba.org Date: Tue Jun 14 09:09:07 2011 +0200 s3-utils: fix crash in net cache get free the blob correctly Autobuild-User: Christian Ambach a...@samba.org Autobuild-Date: Tue Jun 14 12:01:59 CEST 2011 on sn-devel-104 --- Summary of changes: source3/utils/net_cache.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/utils/net_cache.c b/source3/utils/net_cache.c index 88aff4e..afcb7a1 100644 --- a/source3/utils/net_cache.c +++ b/source3/utils/net_cache.c @@ -244,7 +244,7 @@ static int net_cache_get(struct net_context *c, int argc, const char **argv) if (gencache_get_data_blob(keystr, value, timeout, NULL)) { print_cache_entry(keystr, value, timeout, NULL); - SAFE_FREE(value.data); + data_blob_free(value); return 0; } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated via d1880d2 WHATSNEW: Update changes since 3.5.8. from b5011e4 Fix re-opened bug 8083 - inherit owner = yes doesn't interact correctly with vfs_acl_xattr or vfs_acl_tdb module. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log - commit d1880d237bdf79b036623ebf5ae477838c9482c9 Author: Karolin Seeger ksee...@samba.org Date: Tue Jun 14 13:15:37 2011 +0200 WHATSNEW: Update changes since 3.5.8. Karolin --- Summary of changes: WHATSNEW.txt |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 209cc63..f9b4a46 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -8,7 +8,10 @@ This is the latest stable release of Samba 3.5. Major enhancements in Samba 3.5.9 include: -o +o Sgid bit lost on folder rename (bug #7996). +o ACL can get lost when files are being renamed (bug #7987). +o Respect allow trusted domains = no in Winbind (bug #6966). + Changes since 3.5.8: @@ -32,6 +35,8 @@ o Jeremy Allison j...@samba.org * BUG 8111: CIFS VFS: Fix unexpected error on SMB posix open. * BUG 8157: Fix parsing CUPS printcap files in std_pcap_cache_reload(). * BUG 8163: Fix our asn.1 parser to handle negative numbers. +* BUG 8211: inherit owner = yes doesn't interact correctly with inherit + permissions = yes. o Christian Ambach a...@samba.org @@ -100,6 +105,7 @@ o Jim McDonough j...@samba.org o Stefan Metzmacher me...@samba.org +* BUG 7383: Normalize IPv4 mapped IPv6 addresses in both directions. * BUG 8034: SEC_STD_DELETE is always granted to the owner of a file. -- Samba Shared Repository
[SCM] Samba Shared Repository - annotated tag release-3-5-9 created
The annotated tag, release-3-5-9 has been created at 22659ad6b09063b7fb2c99bc39d1972496144645 (tag) tagging 2fbc5382ef48755b09c60e9dfa66fd1b2e880c18 (commit) replaces release-3-5-8 tagged by Karolin Seeger on Tue Jun 14 13:19:26 2011 +0200 - Log - tag release-3-5-9 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.15 (GNU/Linux) iD8DBQBN90PWbzORW2Vot+oRAvHRAKCx7ED5a1VrYA0JTNsRbuqIOG1S1wCguViS wR837R97lkbmbCJwU/n5WbY= =pzOc -END PGP SIGNATURE- Andrew Bartlett (2): s3-libads Default to NOT using the server-supplied principal from SPNEGO s3-libsmb Don't ever ask for machine$ principals as a target. Björn Baumbach (1): s3-modules: Fix debug message (bug #8074) Björn Jacke (3): s3: add explicit configure option whether or not to enable dmapi support s3/vfs_gpfs: s/syncops/gpfs s3/configure: fix GNU ld version detection with old gcc releases Christian Ambach (3): nsswitch: fix a segfault in the krb5 locator plugin s3: use getgrset() when it is available s3:vfs:gpfs convert sharemodes/leases parameter David Disseldorp (8): alpha_strcpy() is a utility function which reportedly: Strips out all but 'a-Z0-9' and the character in other_safe_chars and replaces with '_'. Revert Revert s3-printing: reload shares after pcap cache fill Revert Revert s3-printing: update parent smbd pcap cache s3-printing: remove pcap_cache_loaded asserts s3-printing: an empty cups printer list is treated as an error idl: define printcap IPC message format s3-printing: use printcap IDL for IPC s3-printing: remove duplicate cups response processing code Dmitry Butskoy (1): Fix bug 6966 - allow trusted domains = no not respected in winbind. Günther Deschner (6): s3-docs: document all wbinfo options. s3-cli_pipe: fix timeout in rpc_pipe_open_tcp_port(). s3-printing: very obvious fix for cups_pull_comment_location(). s3-printing: Fix double free of cups request. s3-printing: make cups_pull_comment_location() work again. s3-net: make sure we dont crash when publishing a single printer. Jeremy Allison (20): Fix bug #8005 - smbtorture4 BASE-TCONDEV fails when tested on Samba Fix bug #7996 - sgid bit lost on folder rename. Fix bug 8040 - smbclient segfaults when a Cyrillic netbios name or workgroup is configured. Fix bug #7080 - Quota only shown when logged as root. Fix bug #7987 - ACL can get lost when files are being renamed. Fix bug 8088 - rpccli_samr_chng_pswd_auth_crap segfaults if any input blobs are null. Fix bug 8072 - PANIC: create_file_acl_common frees handle two times. Fix is_myname_or_ipaddr() to be robust against strange DNS setups. Fix bug 8111 - CIFS VFS: unexpected error on SMB posix open Fix bug #8157 - std_pcap_cache_reload() fails to parse a cups printcap file correctly. Fix our asn.1 parser to handle negative numbers. Fix bug #6911 - Kerberos authentication from vista to samba fails when security blob size is greater than 16 kB Fix bug #8083 - inherit owner = yes doesn't interact correctly with vfs_acl_xattr or vfs_acl_tdb module. Fix bug #7528 - Solaris with NIS autohome. Part 1 of bugfix for #8211 - inherit owner = yes doesn't interact correctly with inherit permissions = yes and POSIX ACLs Part 2 of bugfix for #8211 - inherit owner = yes doesn't interact correctly with inherit permissions = yes and POSIX ACLs Part 3 of bugfix for #8211 - inherit owner = yes doesn't interact correctly with inherit permissions = yes and POSIX ACLs Part 4 of bugfix for #8211 - inherit owner = yes doesn't interact correctly with inherit permissions = yes and POSIX ACLs Part 5 of bugfix for #8211 - inherit owner = yes doesn't interact correctly with inherit permissions = yes and POSIX ACLs Fix re-opened bug 8083 - inherit owner = yes doesn't interact correctly with vfs_acl_xattr or vfs_acl_tdb module. Jim McDonough (2): s3-libnet: fix bug #6364: Pull realm from supplied username on libnet join s3-winbind: BUG 8166 - Don't lockout users when offline. Karolin Seeger (6): VERSION: Bump version number up to 3.5.9. WHATSNEW: Start release notes for 3.5.9. Revert s3-spoolss: Added EN ISO 216, A0 and A1 to builtin forms. WHATSNEW: Start to add changes since 3.5.8. WHATSNEW: Add more changes since 3.5.8. WHATSNEW: Update changes since 3.5.8. Larry Reid (1): Fix for servers that don't put a path separator at the end of the service. Marc A. Dahlhaus (1): s3: Fix Bug 8047 -- Fix mdns registration if interfaces= is used Martin Vogt (1): Fix bug #6762 - ctdb on gpfs error with MS Office. Nikolay Martynov (1): Fix inode generation so nautilus can count total dir size correctly Sergey Korsak (1): s3:
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via 956ddfd Announce Samba 3.5.9. from d8da42e Announce Samba 3.6.0rc2. http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit 956ddfdb49f5bdcd9ac7f3e6c3270bf49ae6bbfb Author: Karolin Seeger ksee...@samba.org Date: Tue Jun 14 13:57:29 2011 +0200 Announce Samba 3.5.9. Karolin --- Summary of changes: generated_news/latest_10_bodies.html| 24 ++--- generated_news/latest_10_headlines.html |4 +- generated_news/latest_2_bodies.html | 28 ++ history/header_history.html |1 + history/samba-3.5.9.html| 139 +++ 5 files changed, 161 insertions(+), 35 deletions(-) create mode 100755 history/samba-3.5.9.html Changeset truncated at 500 lines: diff --git a/generated_news/latest_10_bodies.html b/generated_news/latest_10_bodies.html index 5b45b32..60e81d6 100644 --- a/generated_news/latest_10_bodies.html +++ b/generated_news/latest_10_bodies.html @@ -1,3 +1,13 @@ + h5a name=3.5.914 June 2011/a/h5 + p class=headlineSamba 3.5.9 Available for Download/p + pThis is the latest stable release of the Samba 3.5 series./p + +pThe uncompressed tarballs and patch files have been signed +using GnuPG (ID 6568B7EA). The source code can be +a href=http://samba.org/samba/ftp/stable/samba-3.5.9.tar.gz;downloaded +now/a. A a href=http://samba.org/samba/ftp/patches/patch-3.5.8-3.5.9.diffs.gz;patch against Samba 3.5.8/a is also available. See a href=http://samba.org/samba/history/samba-3.5.9.html;the release notes for more info/a./p + + h5a name=3.6.0rc27 June 2011/a/h5 p class=headlineSamba 3.6.0rc2 Available for Download/p pSamba 3.6.0rc2 is available for download. This is the @@ -129,17 +139,3 @@ using GnuPG (ID 6568B7EA). The source code can be a href=http://www.samba.org/samba/ftp/stable/samba-3.3.15.tar.gz;downloaded now/a. See a href=http://www.samba.org/samba/history/samba-3.3.15.html;the release notes for more info/a./p - -h5a name=3.4.11 23 January 2011/a/h5 -p class=headlineSamba 3.4.11 Available for Download/p -pThis is the latest stable release of the Samba 3.4 series./p - -pThe uncompressed tarballs and patch files have been signed -using GnuPG (ID 6568B7EA). The source code can be -a href=http://samba.org/samba/ftp/stable/samba-3.4.11.tar.gz;downloaded -now/a. A a -href=http://samba.org/samba/ftp/patches/patch-3.4.10-3.4.11.diffs.gz;patch -against -Samba 3.4.10/a is also available. See a -href=http://samba.org/samba/history/samba-3.4.11.html;the -release notes for more info/a./p diff --git a/generated_news/latest_10_headlines.html b/generated_news/latest_10_headlines.html index e91199c..2d9b600 100644 --- a/generated_news/latest_10_headlines.html +++ b/generated_news/latest_10_headlines.html @@ -1,4 +1,6 @@ ul + li 14 June 2011 a href=#3.5.9Samba 3.5.9 Available for Download/a/li + li 7 June 2011 a href=#3.6.0rc2Samba 3.6.0rc2 Available for Download/a/li li 17 May 2011 a href=#3.6.0rc1Samba 3.6.0rc1 Available for Download/a/li @@ -16,6 +18,4 @@ li 28 February 2011 a href=#3.4.12Samba 3.4.12 Available for Download/a/li li 28 February 2011 a href=#3.3.15Samba 3.3.15 Available for Download/a/li - - li 23 January 2011 a href=#3.4.11Samba 3.4.11 Available for Download/a/li /ul diff --git a/generated_news/latest_2_bodies.html b/generated_news/latest_2_bodies.html index 97b91b1..606fa49 100644 --- a/generated_news/latest_2_bodies.html +++ b/generated_news/latest_2_bodies.html @@ -1,3 +1,12 @@ + h5a name=3.5.914 June 2011/a/h5 + p class=headlineSamba 3.5.9 Available for Download/p + pThis is the latest stable release of the Samba 3.5 series./p + +pThe uncompressed tarballs and patch files have been signed +using GnuPG (ID 6568B7EA). The source code can be +a href=http://samba.org/samba/ftp/stable/samba-3.5.9.tar.gz;downloaded +now/a. A a href=http://samba.org/samba/ftp/patches/patch-3.5.8-3.5.9.diffs.gz;patch against Samba 3.5.8/a is also available. See a href=http://samba.org/samba/history/samba-3.5.9.html;the release notes for more info/a./p + h5a name=3.6.0rc27 June 2011/a/h5 p class=headlineSamba 3.6.0rc2 Available for Download/p pSamba 3.6.0rc2 is available for download. This is the @@ -16,22 +25,3 @@ Precompiled packages will be made available on a volunteer basis and can be found in the a href=http://samba.org/samba/ftp/Binary_Packages/;Binary_Packages download area/a./p - - h5a name=3.6.0rc117 May 2011/a/h5 - p class=headlineSamba 3.6.0rc1 Available for Download/p - pSamba 3.6.0rc1 is available for download. This is the - first release candidate of the next upgrade production release version of Samba 3.6.0. -
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via ec99588 Update latest stable release. from 956ddfd Announce Samba 3.5.9. http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit ec99588e88665582a0f582b25c427a0a28e06cb9 Author: Karolin Seeger ksee...@samba.org Date: Tue Jun 14 14:05:45 2011 +0200 Update latest stable release. Karolin --- Summary of changes: latest_stable_release.html |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/latest_stable_release.html b/latest_stable_release.html index ba6fec5..85d1a0b 100644 --- a/latest_stable_release.html +++ b/latest_stable_release.html @@ -1,5 +1,5 @@ p - a href=/samba/ftp/stable/samba-3.5.8.tar.gzSamba 3.5.8 (gzipped)/abr - a href=/samba/history/samba-3.5.8.htmlRelease Notes/a middot; - a href=/samba/ftp/stable/samba-3.5.8.tar.ascSignature/a + a href=/samba/ftp/stable/samba-3.5.9.tar.gzSamba 3.5.9 (gzipped)/abr + a href=/samba/history/samba-3.5.9.htmlRelease Notes/a middot; + a href=/samba/ftp/stable/samba-3.5.9.tar.ascSignature/a /p -- Samba Website Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 1514900 s3-docs: Fix a typo found by Samba-JP oota rib...@samba.gr.jp via 48fc585 s3-docs: Fix a duplicate list entry from 7639684 s3-utils: fix crash in net cache get http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 15149002b64b26a8135094677121599a000b3b9d Author: Volker Lendecke v...@samba.org Date: Tue Jun 14 12:53:42 2011 +0200 s3-docs: Fix a typo found by Samba-JP oota rib...@samba.gr.jp Autobuild-User: Volker Lendecke vlen...@samba.org Autobuild-Date: Tue Jun 14 14:06:22 CEST 2011 on sn-devel-104 commit 48fc58596d77b1227bd9d71fb6e7fb3180e6c650 Author: Volker Lendecke v...@samba.org Date: Tue Jun 14 12:50:57 2011 +0200 s3-docs: Fix a duplicate list entry Thanks to Samba-JP oota rib...@samba.gr.jp --- Summary of changes: docs-xml/manpages-3/net.8.xml |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/manpages-3/net.8.xml b/docs-xml/manpages-3/net.8.xml index fac9ba6..2c6c11e 100644 --- a/docs-xml/manpages-3/net.8.xml +++ b/docs-xml/manpages-3/net.8.xml @@ -795,12 +795,6 @@ appear in your system. paraList all interdomain trust relationships./para /refsect3 -refsect3 -titleRPC TRUSTDOM LIST/title - -paraList all interdomain trust relationships./para - -/refsect3 /refsect2 refsect2 @@ -809,7 +803,7 @@ appear in your system. refsect3 titleRPC TRUST CREATE/title -paraCreate a trust trust object by calling lsaCreateTrustedDomainEx2. +paraCreate a trust object by calling lsaCreateTrustedDomainEx2. The can be done on a single server or on two servers at once with the possibility to use a random trust password./para -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via df6b877 s3: Fix connecting to ctdb as non-root via 2817eed s3: Fix count_current_connections from 1514900 s3-docs: Fix a typo found by Samba-JP oota rib...@samba.gr.jp http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit df6b877cc2a868f0a05192f1c524831c177fa1cb Author: Volker Lendecke v...@samba.org Date: Tue Jun 14 17:52:42 2011 +0200 s3: Fix connecting to ctdb as non-root This is at least one instance which I could identify Autobuild-User: Volker Lendecke vlen...@samba.org Autobuild-Date: Tue Jun 14 19:06:39 CEST 2011 on sn-devel-104 commit 2817eed7412380116766a75718c90e635f6c93f4 Author: Volker Lendecke v...@samba.org Date: Tue Jun 14 17:50:41 2011 +0200 s3: Fix count_current_connections False is not really a valid return value for int.. --- Summary of changes: source3/smbd/connection.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/smbd/connection.c b/source3/smbd/connection.c index 8560a5d..f1ec301 100644 --- a/source3/smbd/connection.c +++ b/source3/smbd/connection.c @@ -101,6 +101,7 @@ static int count_fn(struct db_record *rec, int count_current_connections( const char *sharename, bool clear ) { struct count_stat cs; + int ret; cs.curr_connections = 0; cs.name = sharename; @@ -111,10 +112,18 @@ int count_current_connections( const char *sharename, bool clear ) * as it leads to deadlock. */ - if (connections_forall(count_fn, cs) == -1) { + /* +* become_root() because we might have to open connections.tdb +* via ctdb, which is not possible without root. +*/ + become_root(); + ret = connections_forall(count_fn, cs); + unbecome_root(); + + if (ret == -1) { DEBUG(0,(count_current_connections: traverse of connections.tdb failed\n)); - return False; + return 0; } return cs.curr_connections; -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated via a32956a WHATSNEW: Start release notes for 3.5.10. via 767cf9e VERSION: Bump version up to 3.5.10. from d1880d2 WHATSNEW: Update changes since 3.5.8. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log - commit a32956ad21b70d10a5b2a8516e39cbd35aa09045 Author: Karolin Seeger ksee...@samba.org Date: Tue Jun 14 19:11:21 2011 +0200 WHATSNEW: Start release notes for 3.5.10. Karolin commit 767cf9e13421c00a658dac93ef77353587539344 Author: Karolin Seeger ksee...@samba.org Date: Tue Jun 14 19:08:58 2011 +0200 VERSION: Bump version up to 3.5.10. Karolin --- Summary of changes: WHATSNEW.txt| 45 +++-- source3/VERSION |2 +- 2 files changed, 44 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index f9b4a46..7132a02 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,3 +1,44 @@ + == + Release Notes for Samba 3.5.10 + , 2011 + == + + +This is the latest stable release of Samba 3.5. + +Major enhancements in Samba 3.5.10 include: + +o + +Changes since 3.5.9: + + +o + + +## +Reporting bugs Development Discussion +### + +Please discuss this release on the samba-technical mailing list or by +joining the #samba-technical IRC channel on irc.freenode.net. + +If you do report problems then please try to send high quality +feedback. If you don't provide vital information to help us track down +the problem then you will probably be ignored. All bug reports should +be filed under the Samba 3.5 product in the project's Bugzilla +database (https://bugzilla.samba.org/). + + +== +== Our Code, Our Bugs, Our Responsibility. +== The Samba Team +== + + +Release notes for older releases follow: + + = Release Notes for Samba 3.5.9 June 14, 2011 @@ -142,8 +183,8 @@ database (https://bugzilla.samba.org/). == -Release notes for older releases follow: - +-- + = Release Notes for Samba 3.5.8 diff --git a/source3/VERSION b/source3/VERSION index 328a8ac..1e20933 100644 --- a/source3/VERSION +++ b/source3/VERSION @@ -25,7 +25,7 @@ SAMBA_VERSION_MAJOR=3 SAMBA_VERSION_MINOR=5 -SAMBA_VERSION_RELEASE=9 +SAMBA_VERSION_RELEASE=10 # Bug fix releases use a letter for the patch revision # -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-5-stable updated
The branch, v3-5-stable has been updated via 4aa69fe WHATSNEW: Start release notes for 3.5.10. via 28411d0 VERSION: Bump version up to 3.5.10. from 2fbc538 WHATSNEW: Update changes since 3.5.8. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-stable - Log - commit 4aa69fe76514ddfb26ee22e9744819c3e193aadb Author: Karolin Seeger ksee...@samba.org Date: Tue Jun 14 19:11:21 2011 +0200 WHATSNEW: Start release notes for 3.5.10. Karolin (cherry picked from commit a32956ad21b70d10a5b2a8516e39cbd35aa09045) commit 28411d0eac2f96234420bfca515a175b05e3e979 Author: Karolin Seeger ksee...@samba.org Date: Tue Jun 14 19:08:58 2011 +0200 VERSION: Bump version up to 3.5.10. Karolin (cherry picked from commit 767cf9e13421c00a658dac93ef77353587539344) --- Summary of changes: WHATSNEW.txt| 45 +++-- source3/VERSION |2 +- 2 files changed, 44 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index f9b4a46..7132a02 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,3 +1,44 @@ + == + Release Notes for Samba 3.5.10 + , 2011 + == + + +This is the latest stable release of Samba 3.5. + +Major enhancements in Samba 3.5.10 include: + +o + +Changes since 3.5.9: + + +o + + +## +Reporting bugs Development Discussion +### + +Please discuss this release on the samba-technical mailing list or by +joining the #samba-technical IRC channel on irc.freenode.net. + +If you do report problems then please try to send high quality +feedback. If you don't provide vital information to help us track down +the problem then you will probably be ignored. All bug reports should +be filed under the Samba 3.5 product in the project's Bugzilla +database (https://bugzilla.samba.org/). + + +== +== Our Code, Our Bugs, Our Responsibility. +== The Samba Team +== + + +Release notes for older releases follow: + + = Release Notes for Samba 3.5.9 June 14, 2011 @@ -142,8 +183,8 @@ database (https://bugzilla.samba.org/). == -Release notes for older releases follow: - +-- + = Release Notes for Samba 3.5.8 diff --git a/source3/VERSION b/source3/VERSION index e79324d..b6c1cd1 100644 --- a/source3/VERSION +++ b/source3/VERSION @@ -25,7 +25,7 @@ SAMBA_VERSION_MAJOR=3 SAMBA_VERSION_MINOR=5 -SAMBA_VERSION_RELEASE=9 +SAMBA_VERSION_RELEASE=10 # Bug fix releases use a letter for the patch revision # -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 531edfd s3-winbind: Fix paranoia checks in winbindd_samr.c. from 4d47e12 Fix re-opened bug 8083 - inherit owner = yes doesn't interact correctly with vfs_acl_xattr or vfs_acl_tdb module. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 531edfdd1924bfb2ef486820f7f5787098bd953a Author: Andreas Schneider a...@samba.org Date: Fri May 20 15:42:46 2011 +0200 s3-winbind: Fix paranoia checks in winbindd_samr.c. This fixes looking up the correct unix user instead of allocation a new uid and creating it. Fix bug #8215 (winbind unix username lookup doesn't work correctly). --- Summary of changes: source3/winbindd/winbindd_samr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c index ee5ff08..98997b6 100644 --- a/source3/winbindd/winbindd_samr.c +++ b/source3/winbindd/winbindd_samr.c @@ -762,8 +762,8 @@ static NTSTATUS sam_rids_to_names(struct winbindd_domain *domain, ZERO_STRUCT(lsa_policy); /* Paranoia check */ - if (!sid_check_is_builtin(domain_sid) - !sid_check_is_domain(domain_sid) + if (!sid_check_is_in_builtin(domain_sid) + !sid_check_is_in_our_domain(domain_sid) !sid_check_is_unix_users(domain_sid) !sid_check_is_unix_groups(domain_sid) !sid_check_is_in_wellknown_domain(domain_sid)) { -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via bad9f47 bug in source3/winbindd/winbindd_sids_to_xids.c from 531edfd s3-winbind: Fix paranoia checks in winbindd_samr.c. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit bad9f4781133583811420768ebcea9a28597cb7a Author: Herb Lewis hle...@panasas.com Date: Thu Jun 9 23:17:11 2011 -0700 bug in source3/winbindd/winbindd_sids_to_xids.c I'm having trouble getting my system setup to do submits right now but I discovered a bug in the subject file that causes winbindd lookup sids command to assign incorrect unix ids. The change to sid_peek_rid fixes the case where you call lookup sids with sids s1 s2 s3 which cause them to be cached. then call with s1 s2 s4 and s4 will get the unix id of s1. The other change fixes the case where a sid that was not translated gets a value returned instead of being listed as unmapped. Could someone review this and push to master and 3.6 for me? Fix bug #8216 (winbind returns wrong results with sids2xids). --- Summary of changes: source3/winbindd/winbindd_sids_to_xids.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/winbindd/winbindd_sids_to_xids.c b/source3/winbindd/winbindd_sids_to_xids.c index 68616fa..9c38b5a 100644 --- a/source3/winbindd/winbindd_sids_to_xids.c +++ b/source3/winbindd/winbindd_sids_to_xids.c @@ -201,7 +201,7 @@ static void winbindd_sids_to_xids_lookupsids_done(struct tevent_req *subreq) break; }; t-domain_index = n-sid_index; - sid_peek_rid(state-sids[i], t-rid); + sid_peek_rid(state-non_cached[i], t-rid); t-unix_id = (uint64_t)-1; } @@ -268,6 +268,9 @@ NTSTATUS winbindd_sids_to_xids_recv(struct tevent_req *req, } } else { unix_id = state-ids.ids[num_non_cached].unix_id; + if (unix_id == -1) { + found = false; + } switch(state-ids.ids[num_non_cached].type) { case WBC_ID_TYPE_UID: type = 'U'; -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 88ed4b9 s3:net conf addshare: do not stat-check the share path. from bad9f47 bug in source3/winbindd/winbindd_sids_to_xids.c http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 88ed4b9fbd2d517a3e589c104f8f3662ccdd0043 Author: Michael Adam ob...@samba.org Date: Fri Jun 10 13:51:06 2011 +0200 s3:net conf addshare: do not stat-check the share path. Allow paths with % macros and paths that do not (yet...) exist. Fix bug #8217 (net conf addshare should not stat the share path). --- Summary of changes: source3/utils/net_conf.c | 17 - 1 files changed, 0 insertions(+), 17 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/utils/net_conf.c b/source3/utils/net_conf.c index 2c6ccda..0416404 100644 --- a/source3/utils/net_conf.c +++ b/source3/utils/net_conf.c @@ -585,7 +585,6 @@ static int net_conf_addshare(struct net_context *c, const char *comment = NULL; const char *guest_ok = no; const char *writeable = no; - SMB_STRUCT_STAT sbuf; TALLOC_CTX *mem_ctx = talloc_stackframe(); if (c-display_usage) { @@ -685,22 +684,6 @@ static int net_conf_addshare(struct net_context *c, goto done; } - if (sys_stat(path, sbuf, false) != 0) { - d_fprintf(stderr, - _(ERROR: cannot stat path '%s' to ensure - this is a directory.\n - Error was '%s'.\n), - path, strerror(errno)); - goto done; - } - - if (!S_ISDIR(sbuf.st_ex_mode)) { - d_fprintf(stderr, - _(ERROR: path '%s' is not a directory.\n), - path); - goto done; - } - /* * start a transaction */ -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via d0bb41a s3-param Mark 'time offset' as deprecated from 88ed4b9 s3:net conf addshare: do not stat-check the share path. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit d0bb41a66008e12baa0a6c5800f0db5ff9134fc4 Author: Andrew Bartlett abart...@samba.org Date: Sat Jun 11 13:49:29 2011 +1000 s3-param Mark 'time offset' as deprecated Andrew Bartlett --- Summary of changes: docs-xml/smbdotconf/misc/timeoffset.xml |4 +++- source3/param/loadparm.c|2 +- 2 files changed, 4 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/smbdotconf/misc/timeoffset.xml b/docs-xml/smbdotconf/misc/timeoffset.xml index 1afc514..e466267 100644 --- a/docs-xml/smbdotconf/misc/timeoffset.xml +++ b/docs-xml/smbdotconf/misc/timeoffset.xml @@ -4,10 +4,12 @@ advanced=1 developer=1 xmlns:samba=http://www.samba.org/samba/DTD/samba-doc; description - paraThis parameter is a setting in minutes to add + paraThis deprecated parameter is a setting in minutes to add to the normal GMT to local time conversion. This is useful if you are serving a lot of PCs that have incorrect daylight saving time handling./para + + noteparaThis option is deprecated, and will be removed in the next major release/para/note /description value type=default0/value diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c index 77b67f1..1ec68ad 100644 --- a/source3/param/loadparm.c +++ b/source3/param/loadparm.c @@ -4146,7 +4146,7 @@ static struct parm_struct parm_table[] = { .ptr= extra_time_offset, .special= NULL, .enum_list = NULL, - .flags = FLAG_ADVANCED, + .flags = FLAG_ADVANCED | FLAG_DEPRECATED, }, { .label = NIS homedir, -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 4380549 Remove Samba4-specific documentation from the 3.6 release tree via e97d7dc Remove Makefile and configure for top level build in v3-6-test from d0bb41a s3-param Mark 'time offset' as deprecated http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 43805498205ee10cfba670c170ea5d3b0e08e7bd Author: Andrew Bartlett abart...@samba.org Date: Mon Jun 13 20:29:17 2011 +1000 Remove Samba4-specific documentation from the 3.6 release tree The last 2 patches address bug #8221 (Remove top level waf configure and Makefile and Samba4 documentation). commit e97d7dc5bda0b233919ba22df129afae2fa32cf1 Author: Andrew Bartlett abart...@samba.org Date: Mon Jun 13 20:27:59 2011 +1000 Remove Makefile and configure for top level build in v3-6-test This will avoid confusion about which to use in this release. Andrew Bartlett --- Summary of changes: Makefile| 75 - WHATSNEW4.txt | 141 - configure | 14 - configure.developer |6 - howto-ol-backend-s4.txt | 131 howto4.txt |7 - prog_guide4.txt | 777 --- upgrading-samba4.txt| 18 -- 8 files changed, 0 insertions(+), 1169 deletions(-) delete mode 100644 Makefile delete mode 100644 WHATSNEW4.txt delete mode 100755 configure delete mode 100755 configure.developer delete mode 100644 howto-ol-backend-s4.txt delete mode 100644 howto4.txt delete mode 100644 prog_guide4.txt delete mode 100644 upgrading-samba4.txt Changeset truncated at 500 lines: diff --git a/Makefile b/Makefile deleted file mode 100644 index cbbf045..000 --- a/Makefile +++ /dev/null @@ -1,75 +0,0 @@ -# simple makefile wrapper to run waf - -WAF_BINARY=./buildtools/bin/waf -WAF=WAF_MAKE=1 $(WAF_BINARY) - -all: - $(WAF) build - -install: - $(WAF) install - -uninstall: - $(WAF) uninstall - -test: - $(WAF) test $(TEST_OPTIONS) - -help: - @echo NOTE: to run extended waf options use $(WAF_BINARY) or modify your PATH - $(WAF) --help - -subunit-test: - $(WAF) test --filtered-subunit $(TEST_OPTIONS) - -testenv: - $(WAF) test --testenv $(TEST_OPTIONS) - -quicktest: - $(WAF) test --quick $(TEST_OPTIONS) - -dist: - touch .tmplock - WAFLOCK=.tmplock $(WAF) dist - -distcheck: - touch .tmplock - WAFLOCK=.tmplock $(WAF) distcheck - -clean: - $(WAF) clean - -distclean: - $(WAF) distclean - -reconfigure: configure - $(WAF) reconfigure - -show_waf_options: - $(WAF) --help - -# some compatibility make targets -everything: all - -testsuite: all - -check: test - -torture: all - -# this should do an install as well, once install is finished -installcheck: test - -etags: - $(WAF) etags - -ctags: - $(WAF) ctags - -# this allows for things like make bin/smbtorture -bin/%:: FORCE - $(WAF) --targets=`basename $@` -FORCE: - -pydoctor: - $(WAF) pydoctor diff --git a/WHATSNEW4.txt b/WHATSNEW4.txt deleted file mode 100644 index 6758715..000 --- a/WHATSNEW4.txt +++ /dev/null @@ -1,141 +0,0 @@ -What's new in Samba 4 alpha14 -= - -Samba 4 is the ambitious next version of the Samba suite that is being -developed in parallel to the stable 3.x series. The main emphasis in -this branch is support for the Active Directory logon protocols used -by Windows 2000 and above. - -Samba4 alpha14 follows on from the alpha release series we have been -publishing since September 2007. - -WARNINGS - - -Samba4 alpha14 is not a final Samba release. That is more a reference -to Samba4's lack of the features we expect you will need than a -statement of code quality, but clearly it hasn't seen a broad -deployment yet. If you were to upgrade Samba3 (or indeed Windows) to -Samba4, you would find many things work, but that other key features -you may have relied on simply are not there yet. - -For example, while Samba 3 is an excellent member of a Active -Directory domain, Samba4 is happier as a domain controller, and it is -in this role where it has seen deployment into production. - -Samba4 is subjected to an awesome battery of tests on an -automated basis, we have found Samba4 to be very stable in it's -behaviour. We have to recommend against upgrading production servers -from Samba 3 to Samba 4 at this stage, because there may be the features on -which you may rely that are not present, or the mapping of -your configuration and user database may not be complete. - -If you are upgrading, or looking to develop, test or deploy Samba4, you should -backup all configuration and data. - -NEW FEATURES - - -Samba4 supports the server-side of the Active Directory logon
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated via 4829da5 s3-docs Add documentation for 'client use spnego principal' from a32956a WHATSNEW: Start release notes for 3.5.10. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log - commit 4829da5bd4989b7e4b7e858af1770f13d9d2e647 Author: Andrew Bartlett abart...@samba.org Date: Tue Jun 14 22:16:02 2011 +1000 s3-docs Add documentation for 'client use spnego principal' --- Summary of changes: .../security/clientusepsnegoprincipal.xml | 28 1 files changed, 28 insertions(+), 0 deletions(-) create mode 100644 docs-xml/smbdotconf/security/clientusepsnegoprincipal.xml Changeset truncated at 500 lines: diff --git a/docs-xml/smbdotconf/security/clientusepsnegoprincipal.xml b/docs-xml/smbdotconf/security/clientusepsnegoprincipal.xml new file mode 100644 index 000..6ec1eb1 --- /dev/null +++ b/docs-xml/smbdotconf/security/clientusepsnegoprincipal.xml @@ -0,0 +1,28 @@ +samba:parameter name=client use spnego principal + context=G +type=boolean + advanced=1 developer=1 + xmlns:samba=http://www.samba.org/samba/DTD/samba-doc; +description +paraThis parameter determines whether or not +citerefentryrefentrytitlesmbclient/refentrytitle +manvolnum8/manvolnum/citerefentry and other samba components +acting as a client will attempt to use the server-supplied +principal sometimes given in the SPNEGO exchange./para + +paraIf enabled, Samba can attempt to use Kerberos to contact +servers known only by IP address. Kerberos relies on names, so +ordinarily cannot function in this situation. /para + +paraIf disabled, Samba will use the name used to look up the +server when asking the KDC for a ticket. This avoids situations +where a server may impersonate another, soliciting authentication +as one principal while being known on the network as another. +/para + +paraNote that Windows XP SP2 and later versions already follow +this behaviour, and Windows Vista and later servers no longer +supply this 'rfc4178 hint' principal on the server side./para +/description +value type=defaultno/value +/samba:parameter -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via b843d0e s3-utils: fix crash in net cache get from 4380549 Remove Samba4-specific documentation from the 3.6 release tree http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit b843d0eb5112e6bd4290100f28639ec3644d6944 Author: Christian Ambach a...@samba.org Date: Tue Jun 14 09:09:07 2011 +0200 s3-utils: fix crash in net cache get free the blob correctly Autobuild-User: Christian Ambach a...@samba.org Autobuild-Date: Tue Jun 14 12:01:59 CEST 2011 on sn-devel-104 (cherry picked from commit 7639684f273e33e2b7f26660b3ec9d3f9979c5a7) Fix bug #8231 (crash in net cache get). --- Summary of changes: source3/utils/net_cache.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/utils/net_cache.c b/source3/utils/net_cache.c index 88aff4e..afcb7a1 100644 --- a/source3/utils/net_cache.c +++ b/source3/utils/net_cache.c @@ -244,7 +244,7 @@ static int net_cache_get(struct net_context *c, int argc, const char **argv) if (gencache_get_data_blob(keystr, value, timeout, NULL)) { print_cache_entry(keystr, value, timeout, NULL); - SAFE_FREE(value.data); + data_blob_free(value); return 0; } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 8552972 s3:smbd/quotas: add #include system/filesys.h (bug #8224) from b843d0e s3-utils: fix crash in net cache get http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 85529729dd0fa9283d891b41fa36b1cc3c33147e Author: Stefan Metzmacher me...@samba.org Date: Tue Jun 14 08:27:34 2011 +0200 s3:smbd/quotas: add #include system/filesys.h (bug #8224) This should fix the build on FreeBSD metze Autobuild-User: Stefan Metzmacher me...@samba.org Autobuild-Date: Tue Jun 14 09:38:49 CEST 2011 on sn-devel-104 (cherry picked from commit 8096b1a9a4b1518467e7a85bb9000904a76c1ac4) --- Summary of changes: source3/smbd/quotas.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/smbd/quotas.c b/source3/smbd/quotas.c index c9f85b6..4151662 100644 --- a/source3/smbd/quotas.c +++ b/source3/smbd/quotas.c @@ -26,6 +26,7 @@ #include includes.h #include smbd/smbd.h +#include system/filesys.h #undef DBGC_CLASS #define DBGC_CLASS DBGC_QUOTA -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via ea2b9ca s3:librpc/ndr/util.h: add license/copyright header and inclusion guard via 8d3242e s3:registry/reg_parse_internal.c: add copyright information via 8e41d9e s3:registry/reg_parse_internal.h: add copyright information via 223ac56 source3/rpc_client/util_netlogon.h: fix licence/copyright via e21b603 source3/rpc_client/init_spoolss.h: fix licence/copyright via c36af8a source3/rpc_client/init_samr.h: fix licence/copyright via 5a46867 source3/rpc_client/init_netlogon.h: fix licence/copyright via bb3bdb2 source3/rpc_client/init_lsa.h: fix licence/copyright via e702682 source3/rpc_client/cli_spoolss.h: fix licence/copyright via 166ab6b source3/rpc_client/cli_netlogon.h: fix licence/copyright via cd8c579 source3/printing/pcap.h: fix licence/copyright via 0b6188f source3/printing/load.h: fix licence/copyright via 8a7b045 source3/libsmb/proto.h: fix licence/copyright via 7f9deab source3/libsmb/nmblib.h: fix licence/copyright via 2cba14c source3/libsmb/libsmb.h: fix licence/copyright via db27eca source3/libsmb/errormap_wbc.h: fix licence/copyright via 13fd046 source3/libsmb/clidgram.h: fix licence/copyright via 694a4ad source3/libnet/libnet_join.h: fix licence/copyright via 1bcd966 source3/libads/ldap_schema.h: fix licence/copyright via 8c48a80 source3/libads/cldap.h: fix licence/copyright via 59b7746 source3/libads/ads_status.h: fix licence/copyright via b589dcb source3/libads/ads_ldap_protos.h: fix licence/copyright via de5a6d0 source3/lib/privileges.h: fix licence/copyright via e1e0d22 source3/lib/netapi/libnetapi.h: fix licence/copyright via c1376d9 source3/intl/lang_tdb.h: fix licence/copyright via 5abff68 source3/include/smb_ldap.h: fix licence/copyright via 7f79135 source3/include/smb_krb5.h: fix licence/copyright via be6e87a source3/include/mangle.h: fix licence/copyright via ce2e6c2 source3/include/krb5_protos.h: fix licence/copyright via dddb416 source3/include/krb5_env.h: fix licence/copyright via 22c72ef nsswitch/winbind_client.h: fix licence/copyright via a345094 nsswitch/pam_winbind.h: fix licence/copyright. via e1caa9a librpc/ndr/ndr_table.h: fix licence/copyright via eea146d librpc/ndr/ndr_spoolss_buf.h: fix licence/copyright via e7df230 librpc/ndr/ndr_dns.h: fix licence/copyright via e8612ae librpc/ndr/ndr_compression.h: fix licence/copyright via c24e122 librpc/ndr/ndr_backupkey.h: fix licence/copyright via 2a800cb libds/common/flag_mapping.h: fix licence/copyright via b072da9 libcli/smbreadline/smbreadline.h: fix licence/copyright via 4802e60 libcli/nbt/nbt_proto.h: fix licence/copyright via 6922e32 libcli/ldap/ldap_ndr.h: fix licence/copyright via 592aaaf libcli/auth/msrpc_parse.h: fix licence/copyright via 50ba4af lib/util/wrap_xattr.h: fix licence/copyright via 2bd94a7 lib/util/util_tdb.h: fix licence/copyright via 3f0333d lib/util/util_ldb.h: fix licence/copyright via 3475b72 lib/util/time.h: fix licence/copyright via f0a7824 lib/util/data_blob.h: fix licence/copyright via bc89988 auth/auth_sam_reply.h: fix licence/copyright via 47e7800 s3:passdb: add GPL/copyright header to machine_sid.h (cherry picked from commit c0fc7aa129c25664c76b3fdb4b9150c63fe3dd70) via 7aeb6d8 s3:nmbd: add _NMBD_NMBD_H_ guard to nmbd.h (cherry picked from commit fdd225c3e41ed5a81ef02d39ac037818bde49c03) via 17567a5 s3:nmbd: add GPL/Copyright header to nmbd.h (cherry picked from commit 75cfafd69864fccacd1e6c3ca8d27b42a48dbe1c) via 290352d s3:rpc_server: add _RPC_SERVER_SRV_ACCESS_CHECK_H_ guard to srv_access_check.h (cherry picked from commit e40331552137f513c6c2404d96adcf421212ec86) via b39087c s3:rpc_server: add GPL/Copyright header to rpc_server/srv_access_check.h (cherry picked from commit 942ae874b85570f44b3257c8d229792ede7f8fd9) via 6c837ef s3: add _LIB_IDMAP_CACHE_H_ guard to lib/idmap_cache.h (cherry picked from commit c2887f060954bd0e77bc6f3ac8fedec38e26c168) via addf5ff s3: add GPL/Copyright header to lib/idmap_cache.h (cherry picked from commit 2b8803d458465508d0f4299248d858b9c393323e) via ee0bc9e s3:lib/eventlog/proto.h: add _LIB_EVENTLOG_PROTO_H_ guard (cherry picked from commit 36feb8a240a7f061e25223364c1f7ca8476a029f) via 9389133 s3:lib/eventlog/proto.h: add GPL/Copyright header (cherry picked from commit 00530e3d0166641a4f9716067e3c5d1146b0db17) via c833668 s3:libgpo/gpo_proto.h: add _LIBGPO_GPO_PROTO_H_ guard (cherry picked from commit 6ef8122cba3566d4ed177612066cbbe1b8684677) via 8347a04 s3:libgpo/gpo_proto.h: add GPL/Copyright header (cherry picked from commit
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 2dec07d s3:libsmb/cli_np_tstream: s/TSTREAM_CLI_NP_BUF_SIZE/TSTREAM_CLI_NP_MAX_BUF_SIZE via b13df1f s3:libsmb:cli_np_tstream: use dynamic talloc buffers via a64603f s3:libsmb/cli_np_tstream: use larger buffers to avoid a bug NT4 servers (bug #8195) from ea2b9ca s3:librpc/ndr/util.h: add license/copyright header and inclusion guard http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 2dec07d94d9616501ce84c53896179c764949f93 Author: Stefan Metzmacher me...@samba.org Date: Tue Jun 7 18:49:55 2011 +0200 s3:libsmb/cli_np_tstream: s/TSTREAM_CLI_NP_BUF_SIZE/TSTREAM_CLI_NP_MAX_BUF_SIZE This isn't the fixed buffer size anymore, as we use dynamic beffer it's just the maximum size. metze (cherry picked from commit 957cfd23e1781e342edde07fc01dbec279088afa) The last 3 patches address bug #8195 (rpc client code doesn't work against NT4, when we need to fragment requests). commit b13df1f6b987148d6743703929b9112cb25e2338 Author: Stefan Metzmacher me...@samba.org Date: Tue Jun 7 18:45:54 2011 +0200 s3:libsmb:cli_np_tstream: use dynamic talloc buffers Having 8192 bytes on an idle connection is a bit to much, so we better use dynamic buffers using talloc, which also avoids a memcpy in the common SMBtrans readv codepath. metze (cherry picked from commit ad1cf187fdbcd726c6c74085308784fe4ecca883) commit a64603f6633d61036fc6a7e626a4738cfe413b52 Author: Stefan Metzmacher me...@samba.org Date: Tue Jun 7 18:27:41 2011 +0200 s3:libsmb/cli_np_tstream: use larger buffers to avoid a bug NT4 servers (bug #8195) NT4 servers return NT_STATUS_PIPE_BUSY if we try a SMBtrans and the SMBwriteX before hasn't transmited the whole DCERPC fragment. W2K and above is happy with that. As a result we try to match the behavior of Windows and older Samba clients, they use write and read buffers of 4280 bytes instead of 1024 bytes. On Windows only the SMBtrans based read uses 1024 (while we also use 4280 there). metze Autobuild-User: Stefan Metzmacher me...@samba.org Autobuild-Date: Tue Jun 7 20:25:32 CEST 2011 on sn-devel-104 (cherry picked from commit c3ac298a1fe4f5cada6d09376e2d4a3df271a093) --- Summary of changes: source3/libsmb/cli_np_tstream.c | 66 ++- 1 files changed, 51 insertions(+), 15 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/libsmb/cli_np_tstream.c b/source3/libsmb/cli_np_tstream.c index 99a7e4f..208f663 100644 --- a/source3/libsmb/cli_np_tstream.c +++ b/source3/libsmb/cli_np_tstream.c @@ -28,9 +28,24 @@ static const struct tstream_context_ops tstream_cli_np_ops; /* - * Window uses 1024 hardcoded for read size and trans max data + * Windows uses 4280 (the max xmit/recv size negotiated on DCERPC). + * This is fits into the max_xmit negotiated at the SMB layer. + * + * On the sending side they may use SMBtranss if the request does not + * fit into a single SMBtrans call. + * + * Windows uses 1024 as max data size of a SMBtrans request and then + * possibly reads the rest of the DCERPC fragment (up to 3256 bytes) + * via a SMBreadX. + * + * For now we just ask for the full 4280 bytes (max data size) in the SMBtrans + * request to get the whole fragment at once (like samba 3.5.x and below did. + * + * It is important that we use do SMBwriteX with the size of a full fragment, + * otherwise we may get NT_STATUS_PIPE_BUSY on the SMBtrans request + * from NT4 servers. (See bug #8195) */ -#define TSTREAM_CLI_NP_BUF_SIZE 1024 +#define TSTREAM_CLI_NP_MAX_BUF_SIZE 4280 struct tstream_cli_np { struct cli_state *cli; @@ -48,7 +63,7 @@ struct tstream_cli_np { struct { off_t ofs; size_t left; - uint8_t buf[TSTREAM_CLI_NP_BUF_SIZE]; + uint8_t *buf; } read, write; }; @@ -348,9 +363,26 @@ static void tstream_cli_np_writev_write_next(struct tevent_req *req) tstream_context_data(state-stream, struct tstream_cli_np); struct tevent_req *subreq; + size_t i; + size_t left = 0; + + for (i=0; i state-count; i++) { + left += state-vector[i].iov_len; + } + + if (left == 0) { + TALLOC_FREE(cli_nps-write.buf); + tevent_req_done(req); + return; + } cli_nps-write.ofs = 0; - cli_nps-write.left = TSTREAM_CLI_NP_BUF_SIZE; + cli_nps-write.left = MIN(left, TSTREAM_CLI_NP_MAX_BUF_SIZE); + cli_nps-write.buf = talloc_realloc(cli_nps, cli_nps-write.buf, + uint8_t, cli_nps-write.left); + if
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 5d736d8 s3:utils/net_*registry: use c99 initializers which are supported by old gcc 2.95 compilers (bug #8226) from df6b877 s3: Fix connecting to ctdb as non-root http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 5d736d87778754de7043d902c7d1d5db1c46cb02 Author: Stefan Metzmacher me...@samba.org Date: Wed Jun 15 02:34:53 2011 +0200 s3:utils/net_*registry: use c99 initializers which are supported by old gcc 2.95 compilers (bug #8226) metze Autobuild-User: Stefan Metzmacher me...@samba.org Autobuild-Date: Wed Jun 15 03:48:41 CEST 2011 on sn-devel-104 --- Summary of changes: source3/utils/net_registry.c |8 +--- source3/utils/net_rpc_registry.c |4 +++- 2 files changed, 8 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/utils/net_registry.c b/source3/utils/net_registry.c index ab8fb4e..086c4e7 100644 --- a/source3/utils/net_registry.c +++ b/source3/utils/net_registry.c @@ -1039,9 +1039,11 @@ static int net_registry_import(struct net_context *c, int argc, .createkey = (reg_import_callback_createkey_t)import_create_key, .deletekey = (reg_import_callback_deletekey_t)import_delete_key, .deleteval = (reg_import_callback_deleteval_t)import_delete_val, - .setval.registry_value = (reg_import_callback_setval_registry_value_t) - import_create_val, - .setval_type = REGISTRY_VALUE, + .setval = { + .registry_value = (reg_import_callback_setval_registry_value_t) + import_create_val, + }, + .setval_type = REGISTRY_VALUE, .data= import_ctx }; diff --git a/source3/utils/net_rpc_registry.c b/source3/utils/net_rpc_registry.c index fedc432..9195bd4 100644 --- a/source3/utils/net_rpc_registry.c +++ b/source3/utils/net_rpc_registry.c @@ -1959,7 +1959,9 @@ static NTSTATUS rpc_registry_import_internal(struct net_context *c, .createkey = (reg_import_callback_createkey_t)import_create_key, .deletekey = (reg_import_callback_deletekey_t)import_delete_key, .deleteval = (reg_import_callback_deleteval_t)import_delete_val, - .setval.blob = (reg_import_callback_setval_blob_t)import_create_val, + .setval = { + .blob = (reg_import_callback_setval_blob_t)import_create_val, + }, .setval_type = BLOB, .data = import_ctx }; -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 8c14dec build: fixed development symlinks for libraries in subdirectories via 720da3c build: fixed dependencies on install prefix for pc files and python scripts from 5d736d8 s3:utils/net_*registry: use c99 initializers which are supported by old gcc 2.95 compilers (bug #8226) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 8c14decdb8cbc5622d7cf9804bef857d0538ede0 Author: Andrew Tridgell tri...@samba.org Date: Wed Jun 15 14:13:04 2011 +1000 build: fixed development symlinks for libraries in subdirectories this fixes the symlink for libsmbclient.so Autobuild-User: Andrew Tridgell tri...@samba.org Autobuild-Date: Wed Jun 15 07:23:10 CEST 2011 on sn-devel-104 commit 720da3cb9131d4e3bdd0352538f0c5d52c4655c8 Author: Andrew Tridgell tri...@samba.org Date: Wed Jun 15 13:53:19 2011 +1000 build: fixed dependencies on install prefix for pc files and python scripts waf can't automatically determine these dependencies as the construction of the files is via a python function thanks to Andrew for noticing this bug --- Summary of changes: buildtools/wafsamba/pkgconfig.py |1 + buildtools/wafsamba/samba_install.py |4 ++-- buildtools/wafsamba/wafsamba.py |2 ++ 3 files changed, 5 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/buildtools/wafsamba/pkgconfig.py b/buildtools/wafsamba/pkgconfig.py index 09bfcb9..8a3f807 100644 --- a/buildtools/wafsamba/pkgconfig.py +++ b/buildtools/wafsamba/pkgconfig.py @@ -53,6 +53,7 @@ def PKG_CONFIG_FILES(bld, pc_files, vnum=None): rule=subst_at_vars, source=f+'.in', target=f) +bld.add_manual_dependency(bld.path.find_or_declare(f), bld.env['PREFIX']) t.vars = [] if t.env.RPATH_ON_INSTALL: t.env.LIB_RPATH = t.env.RPATH_ST % t.env.LIBDIR diff --git a/buildtools/wafsamba/samba_install.py b/buildtools/wafsamba/samba_install.py index d755d01..26d0a37 100644 --- a/buildtools/wafsamba/samba_install.py +++ b/buildtools/wafsamba/samba_install.py @@ -137,9 +137,9 @@ def install_library(self): os.path.join(self.path.abspath(bld.env), inst_name)) if install_link and install_link != install_name: # and the symlink if needed -bld.symlink_as(os.path.join(install_path, install_link), install_name) +bld.symlink_as(os.path.join(install_path, install_link), os.path.basename(install_name)) if dev_link: -bld.symlink_as(os.path.join(install_path, dev_link), install_name) +bld.symlink_as(os.path.join(install_path, dev_link), os.path.basename(install_name)) @feature('cshlib') diff --git a/buildtools/wafsamba/wafsamba.py b/buildtools/wafsamba/wafsamba.py index 43b7f61..d76afc4 100644 --- a/buildtools/wafsamba/wafsamba.py +++ b/buildtools/wafsamba/wafsamba.py @@ -692,6 +692,8 @@ def install_file(bld, destdir, file, chmod=MODE_644, flat=False, rule=copy_and_fix_python_path, source=file, target=inst_file) +bld.add_manual_dependency(bld.path.find_or_declare(inst_file), bld.env[PYTHONARCHDIR]) +bld.add_manual_dependency(bld.path.find_or_declare(inst_file), bld.env[PYTHONDIR]) file = inst_file if base_name: file = os.path.join(base_name, file) -- Samba Shared Repository