[Samba] Samba 3.0, fuse-hdfs and write problems

2011-12-09 Thread alo alt
Hi folks,

I research at the moment a connection over fuse and samba for
hadoop-cluster. Its my private playground, but I have some issues I can't
figure out why they happen.

I use RHEL5.7, packetlist:
rpm -qa|grep samba
samba-3.0.33-3.29.el5_7.4.x86_64
samba-common-3.0.33-3.29.el5_7.4.x86_64

2 servers, one provides samba-shares and one I use as client.

Samba-Server (HOST2):
FuseFS:
hadoop-fuse-dfs#dfs://HOSTNAME:9000 /123/hdfs fuse usetrash,rw 0 0

mount:
fuse on /123/hdfs type fuse
(rw,nosuid,nodev,allow_other,default_permissions)

the mount /123 is accessible over ssh, cp, rsnyc from any host. Now I was
using NFS for populating, but the performance was not as I expected. So I
switched to samba and get real good results for reading.

Cifs-Client(HOST1):
mount -t cifs -o username=BLUBB,domain=hdfs,rw,uid=104 //lHOST2/hdfs /test

config:

[global]
workgroup = MYGROUP
server string = Samba Server Version %v
socket options = TCP_NODELAY SO_RCVBUF=8192 SO_SNDBUF=8192
security = user
smb passwd file = /etc/samba/smbpasswd
#passdb backend = tdbsam


[hdfs]
comment = hhh
path = /123
public = yes
writable = yes
printable = no
create mask = 0744
force user = hdfs
force group = nobody

I want only hdfs exported ;)

read-performance with rsync:
rsync -av /test/hdfs/user/flume/weblogs/2011-12-07/ .

sent 2047644 bytes  received 92606 bytes  17377158.46 bytes/sec
total size is 20475835998

(19GB, 16 MB/s)

find . -type f |wc -l
4665

plain over rsync -essh  I get around 20mb/s, so I can live with. But
now the part I spent days without a solution:

I perform a lot of write tests. I have a 10GB plain file (dd if of), thats
I use for all write tests. Now, if I try to copy the file from host1 (cifs
client), which hangs without socket options at 128MB. The interest part
there ist - 129MB are the blocksize in my hadoop-cluster. I played with
socket options and now the copy stops at 728MB. I get a nmb-error in
messages:
Dec  8 14:38:42 HOST2 nmbd[12609]: [2011/12/08 14:38:42, 0]
nmbd/nmbd.c:terminate(58)
Dec  8 14:38:42 HOST2 nmbd[12609]:   Got SIGTERM: going down...
Dec  8 14:42:46 HOST2 kernel: INFO: task ls:12663 blocked for more than 120
seconds.

after the system freezes, HOST1 going into load 41 up. vmstat und iostat
say nothing, cp is going into state Z (zombie). Has anybody a advice? Could
be that the process is overloaded and die?

A problem with fuse I could imagine, because if I copy the same file over
scp from HOST1 = HOST2 into hdfs I get a speed of 41 MB/s without any
errors.

thanks,
 - Alex

-- 
Alexander Lorenz
http://mapredit.blogspot.com

*P **Think of the environment: please don't print this email unless you
really need to.*
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[Samba] Samba + acl,user_xattr

2011-12-09 Thread Dmitry Mordovin

Hello All!

Can't make Samba use acl and extended user attributes to save DOS file 
attributes.


Please, help me configure properly.

My steps on Windows XP:
1 - Open share
2 - Open property of file 1122/22.bmp
3 - Check file attribute: hidden
4 - Click Apply
5 - Click Close

6 - Open property again
7 - Attribute Hidden not checked.

Samba dont save attributes!!!

getfattr -d /mnt/public/1122/22.bmp
Show no any attributes for 22.bmp file

*Environment*

Server configuration:

OS: Ubuntu 10.04.3 LTS 2.6.32-36-generic
Samba: 3.6.1
Share: /mnt/public
Mount: /dev/sda3 on /mnt/public type ext3 (rw,acl,user_xattr)

Unix file permissions:

ls -la /mnt/public/
total 18
drwxrwxrwx 2 nobody nogroup  1024 2011-12-09 14:45 1122
drwx-- 2 root   root12288 2011-12-09 14:43 lost+found

ls -la /mnt/public/1122
total 218
-rwxrwxrwx 1 nobody nogroup 220074 2011-12-09 14:45 22.bmp

Samba config:

[global]
workgroup = HOME
security = share
max log size = 1024
store dos attributes = yes
map archive = no
map read only = no
map hidden = no
map system = no
create mode = 777
directory mode = 777

[homes]
browseable = no
printable = no
store dos attributes = yes

[public]
path = /mnt/public
comment = 
read only = no
guest ok = yes
follow symlinks = no
store dos attributes = yes
writable = yes
map archive = no
map read only = no
map hidden = no
map system = no
create mode = 777
directory mode = 777



Samba configure params: --prefix=/usr/local/samba
...
checking whether to support ACLs... auto
configure: checking whether ACL support is available:
checking for acl_get_file in -lacl... yes
checking for getxattr in -lattr... yes
checking for POSIX ACL support... yes
configure: Using posix ACLs
checking for acl_get_perm_np... no
...

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Samba + acl,user_xattr

2011-12-09 Thread Jonathan Buzzard
On Fri, 2011-12-09 at 16:05 +0400, Dmitry Mordovin wrote:

[SNIP]

 Samba config:
 
 [global]
 workgroup = HOME
 security = share
 max log size = 1024
 store dos attributes = yes
 map archive = no
 map read only = no
 map hidden = no
 map system = no
 create mode = 777
 directory mode = 777
 
 [homes]
 browseable = no
 printable = no
 store dos attributes = yes
 
 [public]
 path = /mnt/public
 comment = 
 read only = no
 guest ok = yes
 follow symlinks = no
 store dos attributes = yes
 writable = yes
 map archive = no
 map read only = no
 map hidden = no
 map system = no
 create mode = 777
 directory mode = 777

I see no vfs objects = acl_xattr in your Samba config. Without that it
won't work as there is nothing telling Samba where to store the ACL
information.

JAB.

-- 
Jonathan A. Buzzard Email: jonathan (at) buzzard.me.uk
Fife, United Kingdom.


-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Samba + acl,user_xattr

2011-12-09 Thread Dmitry Mordovin

On 12/09/2011 04:26 PM, Jonathan Buzzard wrote:

On Fri, 2011-12-09 at 16:05 +0400, Dmitry Mordovin wrote:

[SNIP]


Samba config:

[global]
workgroup = HOME
security = share
max log size = 1024
store dos attributes = yes
map archive = no
map read only = no
map hidden = no
map system = no
create mode = 777
directory mode = 777

[homes]
browseable = no
printable = no
store dos attributes = yes

[public]
path = /mnt/public
comment = 
read only = no
guest ok = yes
follow symlinks = no
store dos attributes = yes
writable = yes
map archive = no
map read only = no
map hidden = no
map system = no
create mode = 777
directory mode = 777

I see no vfs objects = acl_xattr in your Samba config. Without that it
won't work as there is nothing telling Samba where to store the ACL
information.

JAB.



Added to global section

vfs objects = acl_xattr


No changes. Still dont store DOS attr.

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Samba 3.0, fuse-hdfs and write problems

2011-12-09 Thread alo alt
Hi,

fixed.
/case closed

I write monday a article about.

- alex


On Fri, Dec 9, 2011 at 9:40 AM, alo alt wget.n...@googlemail.com wrote:

 Hi folks,

 I research at the moment a connection over fuse and samba for
 hadoop-cluster. Its my private playground, but I have some issues I can't
 figure out why they happen.

 I use RHEL5.7, packetlist:
 rpm -qa|grep samba
 samba-3.0.33-3.29.el5_7.4.x86_64
 samba-common-3.0.33-3.29.el5_7.4.x86_64

 2 servers, one provides samba-shares and one I use as client.

 Samba-Server (HOST2):
 FuseFS:
 hadoop-fuse-dfs#dfs://HOSTNAME:9000 /123/hdfs fuse usetrash,rw 0 0

 mount:
 fuse on /123/hdfs type fuse
 (rw,nosuid,nodev,allow_other,default_permissions)

 the mount /123 is accessible over ssh, cp, rsnyc from any host. Now I was
 using NFS for populating, but the performance was not as I expected. So I
 switched to samba and get real good results for reading.

 Cifs-Client(HOST1):
 mount -t cifs -o username=BLUBB,domain=hdfs,rw,uid=104 //lHOST2/hdfs /test

 config:

 [global]
 workgroup = MYGROUP
 server string = Samba Server Version %v
 socket options = TCP_NODELAY SO_RCVBUF=8192 SO_SNDBUF=8192
 security = user
 smb passwd file = /etc/samba/smbpasswd
 #passdb backend = tdbsam


 [hdfs]
 comment = hhh
 path = /123
 public = yes
 writable = yes
 printable = no
 create mask = 0744
 force user = hdfs
 force group = nobody

 I want only hdfs exported ;)

 read-performance with rsync:
 rsync -av /test/hdfs/user/flume/weblogs/2011-12-07/ .

 sent 2047644 bytes  received 92606 bytes  17377158.46 bytes/sec
 total size is 20475835998

 (19GB, 16 MB/s)

 find . -type f |wc -l
 4665

 plain over rsync -essh  I get around 20mb/s, so I can live with. But
 now the part I spent days without a solution:

 I perform a lot of write tests. I have a 10GB plain file (dd if of), thats
 I use for all write tests. Now, if I try to copy the file from host1 (cifs
 client), which hangs without socket options at 128MB. The interest part
 there ist - 129MB are the blocksize in my hadoop-cluster. I played with
 socket options and now the copy stops at 728MB. I get a nmb-error in
 messages:
 Dec  8 14:38:42 HOST2 nmbd[12609]: [2011/12/08 14:38:42, 0]
 nmbd/nmbd.c:terminate(58)
 Dec  8 14:38:42 HOST2 nmbd[12609]:   Got SIGTERM: going down...
 Dec  8 14:42:46 HOST2 kernel: INFO: task ls:12663 blocked for more than
 120 seconds.

 after the system freezes, HOST1 going into load 41 up. vmstat und iostat
 say nothing, cp is going into state Z (zombie). Has anybody a advice? Could
 be that the process is overloaded and die?

 A problem with fuse I could imagine, because if I copy the same file over
 scp from HOST1 = HOST2 into hdfs I get a speed of 41 MB/s without any
 errors.

 thanks,
  - Alex

 --
 Alexander Lorenz
 http://mapredit.blogspot.com

 *P **Think of the environment: please don't print this email unless you
 really need to.*





-- 
Alexander Lorenz
http://mapredit.blogspot.com

*P **Think of the environment: please don't print this email unless you
really need to.*
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] bind errors for latest samba 4 checkout

2011-12-09 Thread Dale Schroeder

On 12/09/2011 12:05 AM, steve wrote:

Hi Dale, hi everyone.

Thanks. I now have the managed keys cleared:

Dec  9 06:57:33 hh3 named[3125]: managed-keys-zone ./IN: loaded serial 0



Stop bind and see if /var/run/named/named.pid remains. You may have a
stale pid that needs removing manually.




I had a go at that:

rm /var/run/named/named.pid
rm: cannot remove `/var/run/named/named.pid': Too many levels of 
symbolic links


This looks promising

http://www.whitemiceconsulting.com/2011_10_01_archive.html



I have:

lrwxrwxrwx  1 root  root14 Dec  9 05:36 named - /var/run/named

Removing /var/run/named clears the error but it returns on restarting 
named.


Also the:

Dec  9 06:57:33 hh3 named[3125]: command channel listening on 
127.0.0.1#953
Dec  9 06:57:33 hh3 named[3125]: couldn't add command channel ::1#953: 
address not available


See if this is applicable to your situation.

https://lists.isc.org/pipermail/bind-users/2005-March/055877.html

Dale



remains

As I say, dns is working fine. I'd just like to clear the errors.

Thanks
Steve

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] winbind: how to fix uid/SID mapping following migration to a new DC

2011-12-09 Thread Jean-Yves Avenard
Hi


On Friday, 9 December 2011, Jonathan Buzzard jonat...@buzzard.me.uk wrote:


 Your two ranges are overlapping and it just don't work if you do that. I have 
 no idea why and it is not well documented why it does not work. Also you have 
 to the plain idmap backend config line setup as a tdb backend. Something 
 like this what you need.

   idmap backend = tdb
   idmap uid = 200-299
   idmap gid = 200-299
   idmap config ALLORATECH : backend = ad
   idmap config ALLORATECH : schema_mode = rfc2307
   idmap config ALLORATECH : readonly = yes
   idmap config ALLORATECH : range = 1000-199

 Seems to come up fairly regularly this one and I can tell you it took me ages 
 to work out a working configuration. This has been really stable for me 
 however other than some random winbind deaths which I papered over with 
 monit. Though a more recent 3.5.x version of Samba might fix that as there 
 seems to have been a lot of bug fixes for it.

 Note this is for 3.5.x and it has all been changed again in 3.6.x so god only 
 knows how you configure it for that.


Thanks for your answer.

If you do it that way, will it use the uidNumber LDAP entry as uid for
the domain user?

Also, what is the read only config for?

Thanks
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] VFS ACL modules - question to developers

2011-12-09 Thread Björn JACKE
On 2011-12-05 at 10:27 -0800 Jeremy Allison sent off:
 We could extend the acl_tdb and acl_xattr modules so
 that they never consider the underlying file system permissions,
 but that would completely divorce the Windows permissions
 from the local filesystem permissions. We dont' do that
 yet (it would need some additional coding) as no one has
 ever demanded that as a feature.

isn't this what acl_xattr:ignore system acls = yes is supposed to do?

Björn
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[Samba] ANNOUNCE: cifs-utils release 5.2 available for download

2011-12-09 Thread Jeff Layton
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Things have been relatively quiet lately. Time for a release!

Highlights:

* A lot of manpage updates, additions and corrections

* cifs.idmap can now map uid/gid to SID in addition to the other way around

* getcifsacl/setcifsacl are now installed by default in /usr/bin
  instead of /usr/sbin. The manpages are now in section 1.

* cifs.upcall has a new scheme for picking the SPN on krb5 mounts. The
  hostname is now always lowercased. If we fail to get a ticket using
  an unqualified name, it now attempts to guess the domain name.

webpage:http://linux-cifs.samba.org/cifs-utils/
tarball:ftp://ftp.samba.org/pub/linux-cifs/cifs-utils/
git:git://git.samba.org/cifs-utils.git
gitweb: http://git.samba.org/?p=cifs-utils.git;a=summary

Detailed list of changes since 5.1:

commit 62a1005814793dd7fa5e819d6619065ae8edf240
Author: Jeff Layton jlay...@samba.org
Date:   Fri Sep 23 14:00:14 2011 -0400

autoconf: bump version to 5.1.1 for interim builds

Signed-off-by: Jeff Layton jlay...@samba.org

commit f9df5f8e629176db7a1812f7914a45e2977c3e4c
Author: Jeff Layton jlay...@samba.org
Date:   Sat Sep 24 08:01:16 2011 -0400

acltools: install them in $bindir, not $sbindir

Move the manpages to section 1 since getcifsacl and setcifsacl are user,
not sysadmin tools. Get rid of the useless sed calls on the manpages.
They don't have any explicit paths in them that need replacing.

Also get rid of the 4.0 in the footers of all the manpages.

Signed-off-by: Jeff Layton jlay...@samba.org

commit 814a5e1868e8a557cbff8181a480fb84b45abae7
Author: Jeff Layton jlay...@samba.org
Date:   Tue Oct 18 07:35:21 2011 -0400

manpage: move SEE ALSO section in setcifsacl.1 nearer to bottom

The convention is to have that close to the bottom of the manpage. In
this case, we want it after the EXAMPLES section.

Signed-off-by: Jeff Layton jlay...@samba.org

commit ca20bbff426d3b84c23df1df71d7a227206e
Author: Suresh Jayaraman sjayara...@suse.de
Date:   Tue Oct 18 08:01:21 2011 -0400

cifs-utils: mention the kernel version that introduced setcifsacl

Reviewed-by: Shirish Pargaonkar shirishpargaon...@gmail.com
Signed-off-by: Suresh Jayaraman sjayara...@suse.de

commit d9c1bf93015e6939d16a319411566de1563a93ca
Author: Suresh Jayaraman sjayara...@suse.de
Date:   Tue Oct 18 08:01:26 2011 -0400

cifs-utils: manpage: mention the kernel version that introduced getcifsacl

Reviewed-by: Shirish Pargaonkar shirishpargaon...@gmail.com
Signed-off-by: Suresh Jayaraman sjayara...@suse.de

commit a31ff1481f4dc633d2f32d1e0772d1da9b5dee46
Author: Suresh Jayaraman sjayara...@suse.de
Date:   Tue Oct 18 08:01:30 2011 -0400

cifs-utils: manpage: mention the required kernel version to make cifs.idmap 
work

Cc: Shirish Pargaonkar shirishpargaon...@gmail.com
Signed-off-by: Suresh Jayaraman sjayara...@suse.de

commit c55ad41d1a11e897b4db166f800d4abd71d86652
Author: Shirish Pargaonkar shirishpargaon...@gmail.com
Date:   Wed Oct 19 14:18:07 2011 -0400

mount.cifs: Add mount options for backup intent and their manpages (try #8)

Add mount options backupuid and backugid and their manpage contents.
Check for either a valid uid/gid or valid user/group name.

Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com

commit e92709981e5d3e927a0ba823d7c94d7cf0940897
Author: Jeff Layton jlay...@samba.org
Date:   Wed Oct 19 14:18:12 2011 -0400

manpage: cleanups to new backupuid/gid sections

Minor cleanups and consistency fixes...

Cc: Shirish Pargaonkar shirishpargaon...@gmail.com
Signed-off-by: Jeff Layton jlay...@samba.org

commit 71c358b25c9bcd9b030a8f6844eecd42488e6724
Author: Shirish Pargaonkar shirishpargaon...@gmail.com
Date:   Wed Oct 19 14:18:12 2011 -0400

cifs.idmap: Add uid/gid to SID mapping functions (try #3)

Add functions to map a uid and gid to a SID.  These functions are
similar to SID to uid and gid mapping functions. A SID is what is
returned to the cifs module.

Signed-off-by: Shirish Pargaonkar shirishpargaon...@gmail.com

commit b6eb2f2f9f5ce0c64c57e2f59ef2ce80932decca
Author: Jeff Layton jlay...@samba.org
Date:   Wed Oct 19 14:25:31 2011 -0400

manpage: document new rsize= behavior

With the addition of async readpages in 3.2 kernels, the behavior of
the rsize= option has changed.

Signed-off-by: Jeff Layton jlay...@samba.org

commit fa488d9fd2a0d722cfcccea6c84599366b58b0de
Author: Jeff Layton jlay...@samba.org
Date:   Sat Nov 12 09:58:02 2011 -0500

cifs.upcall: silence unused parameter warning

cifs.upcall.c: In function ‘cifs_krb5_principal_get_realm’:
cifs.upcall.c:80:57: warning: unused parameter ‘context’ 
[-Wunused-parameter]

Signed-off-by: Jeff Layton jlay...@samba.org

commit d540fe20e3943293f493a80529da012d00782ebe
Author: Jeff 

[SCM] Samba Shared Repository - branch master updated

2011-12-09 Thread Matthias Dieter Wallnöfer
The branch, master has been updated
   via  1b741b2 s4:dsdb/common/util.c - test LDB result against LDB_SUCCESS 
as we are always doing
  from  c01efc1 s4 dns: Update requests with QCLASS != IN or ALL trigger 
NOTIMPLEMENTED errors

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 1b741b2bcc8b085be9f092b6d7e203661b571c43
Author: Matthias Dieter Wallnöfer m...@samba.org
Date:   Thu Dec 1 09:33:10 2011 +0100

s4:dsdb/common/util.c - test LDB result against LDB_SUCCESS as we are 
always doing

Autobuild-User: Matthias Dieter Wallnöfer m...@samba.org
Autobuild-Date: Fri Dec  9 12:00:03 CET 2011 on sn-devel-104

---

Summary of changes:
 source4/dsdb/common/util.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/dsdb/common/util.c b/source4/dsdb/common/util.c
index 826a1e4..38391a9 100644
--- a/source4/dsdb/common/util.c
+++ b/source4/dsdb/common/util.c
@@ -1306,7 +1306,7 @@ struct ldb_dn *samdb_ntds_settings_dn(struct ldb_context 
*ldb)
}
 
ret = ldb_search(ldb, tmp_ctx, root_res, ldb_dn_new(tmp_ctx, ldb, ), 
LDB_SCOPE_BASE, root_attrs, NULL);
-   if (ret) {
+   if (ret != LDB_SUCCESS) {
DEBUG(1,(Searching for dsServiceName in rootDSE failed: %s\n, 
 ldb_errstring(ldb)));
goto failed;


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated

2011-12-09 Thread Volker Lendecke
The branch, master has been updated
   via  ad5d315 s3-dbwrap: Fix a typo
  from  1b741b2 s4:dsdb/common/util.c - test LDB result against LDB_SUCCESS 
as we are always doing

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit ad5d3153226d0d24788dfde2007a93f019cc6c0d
Author: Volker Lendecke v...@samba.org
Date:   Fri Dec 9 11:12:59 2011 +0100

s3-dbwrap: Fix a typo

Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Fri Dec  9 13:37:51 CET 2011 on sn-devel-104

---

Summary of changes:
 source3/lib/dbwrap/dbwrap.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/dbwrap/dbwrap.c b/source3/lib/dbwrap/dbwrap.c
index 83c02f5..a806c6a 100644
--- a/source3/lib/dbwrap/dbwrap.c
+++ b/source3/lib/dbwrap/dbwrap.c
@@ -87,7 +87,7 @@ static int delete_record(struct db_record *rec, void *data)
 }
 
 /*
- * Fallback wipe ipmlementation using traverse and delete if no genuine
+ * Fallback wipe implementation using traverse and delete if no genuine
  * wipe operation is provided
  */
 static int dbwrap_fallback_wipe(struct db_context *db)


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated

2011-12-09 Thread Stefan Metzmacher
The branch, master has been updated
   via  4e57bb0b s4:libcli/smb2: mark a request as error if we can't ship it
   via  4486336 s4:libcli/raw: mark a request as error if we can't ship it
  from  ad5d315 s3-dbwrap: Fix a typo

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 4e57bb0b364e84f3cc8928f0f1a29055d69c7efd
Author: Stefan Metzmacher me...@samba.org
Date:   Fri Dec 9 11:05:47 2011 +0100

s4:libcli/smb2: mark a request as error if we can't ship it

metze

Autobuild-User: Stefan Metzmacher me...@samba.org
Autobuild-Date: Fri Dec  9 15:13:11 CET 2011 on sn-devel-104

commit 4486336bd820c8be6145e3946dc831bda16602ca
Author: Stefan Metzmacher me...@samba.org
Date:   Fri Dec 9 11:05:47 2011 +0100

s4:libcli/raw: mark a request as error if we can't ship it

metze

---

Summary of changes:
 source4/libcli/raw/clitransport.c |2 ++
 source4/libcli/smb2/transport.c   |2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/libcli/raw/clitransport.c 
b/source4/libcli/raw/clitransport.c
index f1f41bc..a9ff8f3 100644
--- a/source4/libcli/raw/clitransport.c
+++ b/source4/libcli/raw/clitransport.c
@@ -337,6 +337,8 @@ void smbcli_transport_send(struct smbcli_request *req)
 
status = smb1cli_req_chain_submit(req-subreqs, num_subreqs);
if (!NT_STATUS_IS_OK(status)) {
+   req-status = status;
+   req-state = SMBCLI_REQUEST_ERROR;
smbXcli_conn_disconnect(transport-conn, status);
}
 }
diff --git a/source4/libcli/smb2/transport.c b/source4/libcli/smb2/transport.c
index 55281d2..59d49f7 100644
--- a/source4/libcli/smb2/transport.c
+++ b/source4/libcli/smb2/transport.c
@@ -227,6 +227,8 @@ void smb2_transport_send(struct smb2_request *req)
TALLOC_FREE(transport-compound.reqs);
 
if (!NT_STATUS_IS_OK(status)) {
+   req-status = status;
+   req-state = SMB2_REQUEST_ERROR;
smbXcli_conn_disconnect(transport-conn, status);
}
 }


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated

2011-12-09 Thread Volker Lendecke
The branch, master has been updated
   via  092f1b9 tevent: tevent_schedule_immediate never fails
  from  4e57bb0b s4:libcli/smb2: mark a request as error if we can't ship it

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 092f1b974433a45c2a24148ca098821ed8e406d8
Author: Volker Lendecke v...@samba.org
Date:   Fri Dec 9 13:38:17 2011 +0100

tevent: tevent_schedule_immediate never fails

Autobuild-User: Volker Lendecke vlen...@samba.org
Autobuild-Date: Fri Dec  9 16:47:23 CET 2011 on sn-devel-104

---

Summary of changes:
 lib/tevent/tevent.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/tevent/tevent.c b/lib/tevent/tevent.c
index a87865b..5247b5e 100644
--- a/lib/tevent/tevent.c
+++ b/lib/tevent/tevent.c
@@ -402,7 +402,6 @@ struct tevent_immediate 
*_tevent_create_immediate(TALLOC_CTX *mem_ctx,
 
 /*
   schedule an immediate event
-  return NULL on failure
 */
 void _tevent_schedule_immediate(struct tevent_immediate *im,
struct tevent_context *ev,


-- 
Samba Shared Repository