Re: [Samba] Re: Samba segs when serving files from a windows partition on OpenBSD-4.2
On Tue, 13 May 2008, Jeremy Allison wrote: On Tue, May 13, 2008 at 05:56:56PM +0100, Stephen Borrill wrote: As a data point, I'm getting crashes on NetBSD 3.1 and samba 3.0.28a on a FFSv2 partition. Removing the lib/replace/repdir_getdirentries.c gets it working (even without "directory name cache size = 0"). I'm not sure of the canonical way to remove it, the patch at https://bugzilla.samba.org/attachment.cgi?id=2905 does not work, nor does removing repdir.m4 entirely. I ended up editing source/Makefile and removing the .o files from LIBREPLACE_OBJ. We'll remove lib/replace/repdir_getdirentries.c for 3.0.29 and 3.2 final. Thanks. Great. Have you a canonical patch for 3.0.28a and I'll commit it to pkgsrc? -- Stephen -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Re: Samba segs when serving files from a windows partition on OpenBSD-4.2
On Tue, May 13, 2008 at 01:10:29PM -0700, Jeremy Allison wrote: > > Certain? I think mbalmer wanted to send a Samba-patch for > > systems without his bugfix (i.e. all bsd systems in > > production right now). Or did I miss that patch? > > I thouhgt the patch he wanted was removing that code, > but I could be mistaken. Right now I've got a little chat with mbalmer on irc. It seems that we can indeed remove that code completely. Volker pgpu2IcNNWm2W.pgp Description: PGP signature -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Re: Samba segs when serving files from a windows partition on OpenBSD-4.2
On Tue, May 13, 2008 at 09:44:03PM +0200, Volker Lendecke wrote: > On Tue, May 13, 2008 at 10:20:47AM -0700, Jeremy Allison wrote: > > > https://bugzilla.samba.org/attachment.cgi?id=2905 does not work, nor does > > > removing repdir.m4 entirely. I ended up editing source/Makefile and > > > removing the .o files from LIBREPLACE_OBJ. > > > > We'll remove lib/replace/repdir_getdirentries.c for 3.0.29 and > > 3.2 final. Thanks. > > Certain? I think mbalmer wanted to send a Samba-patch for > systems without his bugfix (i.e. all bsd systems in > production right now). Or did I miss that patch? I thouhgt the patch he wanted was removing that code, but I could be mistaken. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Re: Samba segs when serving files from a windows partition on OpenBSD-4.2
On Tue, May 13, 2008 at 10:20:47AM -0700, Jeremy Allison wrote: > > https://bugzilla.samba.org/attachment.cgi?id=2905 does not work, nor does > > removing repdir.m4 entirely. I ended up editing source/Makefile and > > removing the .o files from LIBREPLACE_OBJ. > > We'll remove lib/replace/repdir_getdirentries.c for 3.0.29 and > 3.2 final. Thanks. Certain? I think mbalmer wanted to send a Samba-patch for systems without his bugfix (i.e. all bsd systems in production right now). Or did I miss that patch? Volker pgpD5HF5OLqPU.pgp Description: PGP signature -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] Re: Samba segs when serving files from a windows partition on OpenBSD-4.2
On Tue, May 13, 2008 at 05:56:56PM +0100, Stephen Borrill wrote: > > As a data point, I'm getting crashes on NetBSD 3.1 and samba 3.0.28a on a > FFSv2 partition. > > Removing the lib/replace/repdir_getdirentries.c gets it working (even > without "directory name cache size = 0"). I'm not sure of the canonical > way to remove it, the patch at > https://bugzilla.samba.org/attachment.cgi?id=2905 does not work, nor does > removing repdir.m4 entirely. I ended up editing source/Makefile and > removing the .o files from LIBREPLACE_OBJ. We'll remove lib/replace/repdir_getdirentries.c for 3.0.29 and 3.2 final. Thanks. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] Re: Samba segs when serving files from a windows partition on OpenBSD-4.2
On Tue, Apr 29, Jeremy Allison wrote: On Mon, Apr 28, 2008 at 09:05:29PM +0100, Edd Barrett wrote: I am sure that the OpenBSD team will be interested in fixing these bugs if they still exist, as they take pride making good quality code. I can't speak for NetBSD or FreeBSD. As for the "directory name cache size = 0" it does not work for me. On OpenBSD. I used this configuration: [global] workgroup = MYGROUP server string = Samba Server security = share log file = /var/log/smbd.%m directory name cache size = 0 [public] comment = Public Stuff path = /mnt/hot/sd0i public = yes writable = yes printable = no I tested this with samba-latest.tgz from your web-page. If I change the path to someplace else on a UFS slice, all is well. Did you remove the lib/replace/repdir_getdirentries.c code as well ? The aborts will still trigger even with "directory name cache size = 0" if that code is in place. As a data point, I'm getting crashes on NetBSD 3.1 and samba 3.0.28a on a FFSv2 partition. Removing the lib/replace/repdir_getdirentries.c gets it working (even without "directory name cache size = 0"). I'm not sure of the canonical way to remove it, the patch at https://bugzilla.samba.org/attachment.cgi?id=2905 does not work, nor does removing repdir.m4 entirely. I ended up editing source/Makefile and removing the .o files from LIBREPLACE_OBJ. I note the changes in OpenBSD and NetBSD to fix the seekdir() problem, but they didn't seem to help me. -- Dr. Stephen Borrill -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
