Re: [Samba] new printing patch for 3.0.10 may fix the 'failure to remove print jobs from queue list display'
On Wed, 26 Jan 2005 16:25:35 +0100, Alex de Vaal [EMAIL PROTECTED] wrote:
On Wed 5 Jan 2005, at 17:57, Gerald (Jerry) Carter wrote:
I've uploaded a new draft of the printing patch for 3.0.10
to http://www.samba.org/~jerry/patches/post-3.0.10/
The only change is a small fix to fix the register_message_flags()
error messages in the logs. After some thought, I think this
might address the 'jobs failing to be removed from the queue
list' bug. If people could test and let me know, I would
appreciate it.
I'm using 3.0.11pre1 (compiled on the 18th) and looking at the source
it looks like the patch is in (printing.c is dated Jan 4 21:30).
Printing with cups.
I am experiencing similar behaviour. I have 40 or so users pounding on
a number printers, and by the end of the day some of them show upwards
of 800 jobs in queue.
I am seeing things like attempt to delete job 3575 not seen by lpr
in the logs.
smb.conf contains
[global]
load printers = yes
printing = cups
printcap = cups
printcap cache time = 60
printer admin = @prtadmin
[printers]
comment = All Printers
browseable = no
path = /var/spool/samba
printable = yes
public = yes
guest ok = yes
writable = no
create mode = 0700
printer admin = root, @prtadmin
If anyone can throw me some clues I'd be very grateful.
Thanks,
David
Hi Jerry,
The patch (version #2) is working; when I print from an XP client to a CUPS
queue
(queue on hold), the print icon appears in the taskbar of the XP client.
When I remove
the print job from the CUPS queue, within 30 seconds the print icon on the
XP client
disappears.
I also added this patch from Jerome Borsboom to your patch.
--- samba-3.0.10/source/printing/printing.c 2005-01-10
15:07:27.060999122 +0100
+++ samba-3.0.10.new/source/printing/printing.c 2005-01-10
15:07:36.784464292 +0100
@@ -1077,6 +1077,7 @@
if ( !print_cache_expired(sharename, False) ) {
DEBUG(5,(print_queue_update_internal: print cache for %s is
still ok\n, sharename));
+ release_print_db( pdb );
return;
}
Is your printing patch Ok to use in production environments?
I saw that in the SAMBA_3_0 branch that printing/printing.c is changed with
your patch, but your patch also patches:
param/loadparm.c
smbd/lanman.c
smbd/negprot.c
smbd/reply.c
smbd/server.c
but I can see that these files are not updated with your patch in the
SAMBA_3_0
branch, or am I wrong?
Regards,
Alex.
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/listinfo/samba
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] new printing patch for 3.0.10 may fix the 'failure to remove print jobs from queue list display'
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 David Landgren wrote: | | I'm using 3.0.11pre1 (compiled on the 18th) and looking at the source | it looks like the patch is in (printing.c is dated Jan 4 21:30). | Printing with cups. | | I am experiencing similar behaviour. I have 40 or so users | pounding on a number printers, and by the end of the day some | of them show upwards of 800 jobs in queue. | | I am seeing things like attempt to delete job 3575 not | seen by lpr in the logs. Please test 3.0.11rc1 when it is released tomorrow and let me know if you still see the issue. That release will have integrated all the current printing fixes. cheers, jerry = Alleviating the pain of Windows(tm) --- http://www.samba.org GnuPG Key- http://www.plainjoe.org/gpg_public.asc I never saved anything for the swim back. Ethan Hawk in Gattaca -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFB+R3rIR7qMdg1EfYRAkHiAJ9BRgloCYd9kwxRuNUXMbWCqb61KACgo5+l 4koEgwzYAm946gFSr/g+1dQ= =vM97 -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] new printing patch for 3.0.10 may fix the 'failure to remove print jobs from queue list display'
| I'm using 3.0.11pre1 (compiled on the 18th) and looking at the source | it looks like the patch is in (printing.c is dated Jan 4 21:30). | Printing with cups. | | I am experiencing similar behaviour. I have 40 or so users | pounding on a number printers, and by the end of the day some | of them show upwards of 800 jobs in queue. | | I am seeing things like attempt to delete job 3575 not | seen by lpr in the logs. Please test 3.0.11rc1 when it is released tomorrow and let me know if you still see the issue. That release will have integrated all the current printing fixes. I assume you mean 3.0.11rc3. I shall, and will report back. Thanks, David -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] new printing patch for 3.0.10 may fix the 'failure to remove print jobs from queue list display'
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 David Landgren wrote: || I'm using 3.0.11pre1 (compiled on the 18th) and looking at the source || it looks like the patch is in (printing.c is dated Jan 4 21:30). || Printing with cups. || || I am experiencing similar behaviour. I have 40 or so users || pounding on a number printers, and by the end of the day some || of them show upwards of 800 jobs in queue. || || I am seeing things like attempt to delete job 3575 not || seen by lpr in the logs. | |Please test 3.0.11rc1 when it is released tomorrow and let |me know if you still see the issue. That release will have |integrated all the current printing fixes. | | | I assume you mean 3.0.11rc3. I shall, and will report back. No :-) 3.0.11pre2 was released on Jan 21. 3.0.11rc1 will be released tomorrow (assuming today goes well). cheers, jerry = Alleviating the pain of Windows(tm) --- http://www.samba.org GnuPG Key- http://www.plainjoe.org/gpg_public.asc I never saved anything for the swim back. Ethan Hawk in Gattaca -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFB+SCEIR7qMdg1EfYRAqioAKDrRY1fbx1WJDhKjgEwtNFXRzgyDwCgowsq hWGFSLNK6M8ziwIsh/Nxgs0= =wKAu -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
Re: [Samba] new printing patch for 3.0.10 may fix the 'failure to remove print jobs from queue list display'
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alex de Vaal wrote: | The patch (version #2) is working; when I print from an | XP client to a CUPS queue (queue on hold), the print icon | appears in the taskbar of the XP client. When I remove | the print job from the CUPS queue, within 30 seconds the | print icon on the XP client disappears. | | I also added this patch from Jerome Borsboom to your patch. Thanks for the updates. Jerome's patch has also been integrated into 3.0.11pre2. | Is your printing patch Ok to use in production environments? I hope so. We're getting close to the final 3.10.11 release and so far things look good. | | I saw that in the SAMBA_3_0 branch that printing/printing.c | is changed with your patch, but your patch also patches: | | param/loadparm.c | smbd/lanman.c | smbd/negprot.c | smbd/reply.c | smbd/server.c | | but I can see that these files are not updated with | your patch in the SAMBA_3_0 branch, or am I wrong? smbd/lanman.c used the printing interface in some for or another and had to be updated. the change in loadparm was to default 'lpq cache time' to 30 seconds instead of 10. the change to smbd/server.c was to not launch the background LPQ daemon when you run 'smbd -i' the fix in smbd/reply.c and smbd/negprot.c was to fix the 'tdb fetch failed' error messages. cheers, jerry = Alleviating the pain of Windows(tm) --- http://www.samba.org GnuPG Key- http://www.plainjoe.org/gpg_public.asc I never saved anything for the swim back. Ethan Hawk in Gattaca -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFB+SHdIR7qMdg1EfYRAs/0AJwKp/V4cH+5nPulAfJ/dPyIFuNPiACgwK6/ z11qTjiSL8CGM7QcHjkr7Fw= =B7Kl -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] new printing patch for 3.0.10 may fix the 'failure to remove print jobs from queue list display'
On Wed 5 Jan 2005, at 17:57, Gerald (Jerry) Carter wrote:
I've uploaded a new draft of the printing patch for 3.0.10
to http://www.samba.org/~jerry/patches/post-3.0.10/
The only change is a small fix to fix the register_message_flags()
error messages in the logs. After some thought, I think this
might address the 'jobs failing to be removed from the queue
list' bug. If people could test and let me know, I would
appreciate it.
Hi Jerry,
The patch (version #2) is working; when I print from an XP client to a CUPS
queue
(queue on hold), the print icon appears in the taskbar of the XP client.
When I remove
the print job from the CUPS queue, within 30 seconds the print icon on the
XP client
disappears.
I also added this patch from Jerome Borsboom to your patch.
--- samba-3.0.10/source/printing/printing.c 2005-01-10
15:07:27.060999122 +0100
+++ samba-3.0.10.new/source/printing/printing.c 2005-01-10
15:07:36.784464292 +0100
@@ -1077,6 +1077,7 @@
if ( !print_cache_expired(sharename, False) ) {
DEBUG(5,(print_queue_update_internal: print cache for %s is
still ok\n, sharename));
+ release_print_db( pdb );
return;
}
Is your printing patch Ok to use in production environments?
I saw that in the SAMBA_3_0 branch that printing/printing.c is changed with
your patch, but your patch also patches:
param/loadparm.c
smbd/lanman.c
smbd/negprot.c
smbd/reply.c
smbd/server.c
but I can see that these files are not updated with your patch in the
SAMBA_3_0
branch, or am I wrong?
Regards,
Alex.
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/listinfo/samba
[Samba] new printing patch for 3.0.10 may fix the 'failure to remove print jobs from queue list display'
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I've uploaded a new draft of the printing patch for 3.0.10 to http://www.samba.org/~jerry/patches/post-3.0.10/ The only change is a small fix to fix the register_message_flags() error messages in the logs. After some thought, I think this might address the 'jobs failing to be removed from the queue list' bug. If people could test and let me know, I would appreciate it. cheers, jerry - - Alleviating the pain of Windows(tm) --- http://www.samba.org GnuPG Key- http://www.plainjoe.org/gpg_public.asc If we're adding to the noise, turn off this song--Switchfoot (2003) -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFB3CptIR7qMdg1EfYRAnruAKDEqHvZfHDA+OxyuQjquT+R6RXLSgCdHUpz er3/vj9lCMQxNotsYGHSuFU= =YW+/ -END PGP SIGNATURE- -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/listinfo/samba
