RE: [Samba] Idmap back compatible issue

2007-04-23 Thread Li, Ying (ESG) 
Sorry, I missed a checking condition for dom_list. Attached is a new
version of the patch.

Thanks.
-Ying
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

Re: [Samba] Idmap back compatible issue

2007-04-22 Thread Gerald (Jerry) Carter 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Gerald (Jerry) Carter wrote:
> Li, Ying (ESG) wrote:
> 
>>> I believe that many users take the default setting without specific
>>> idmap backend option, if there is no particular idmap requirement. I'd
>>> like to recommend considering the first situation as back compatible
>>> issue. At lease let it takes the default tdb backend when no idmap
>>> domains presented,  no idmap backend in smb.conf.
>>>
>>> Here is a patch for this. Could somebody look at it?
> 
> Looks right to me.  I'll add this for 3.0.25rc2.

Gahh!  This is wrong and breaks the rc2 release!

The problem is that now it always sets a compat backend
of tdb even if specifying idmap domains .  I've patch the
SAMBA_3_0* trees and this will be fixed in the 3.0.25-final.




cheers, jerry
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGLE0yIR7qMdg1EfYRAq+rAJ9AJXQNtiJzeyqygRehX60AM9UcEACeMXEk
nCeaLBdRowKVpg3omqqjek0=
=qEut
-END PGP SIGNATURE-
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

Re: [Samba] Idmap back compatible issue

2007-04-22 Thread Gerald (Jerry) Carter 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Ying,

> Here is a patch for this. Could somebody look at it?

btw...please send patches as attachments next time.  Thanks.


> 
> # diff -U 3 idmap.c idmap.c_my
> --- idmap.c 2007-04-12 11:52:07.0 -0700
> +++ idmap.c_my  2007-04-12 11:51:49.0 -0700
> @@ -321,6 +321,14 @@
> *p = '\0';
> compat_params = p + 1;
> }
> +   } else {
> +   /* Back compatible: without idmap domains and explicit
> idmap backend
> +* Taking default idmap backend: tdb
> +*/
> +   DEBUG(3, ("idmap_init: No idmap domains, No idmap
> backend dom_list=%s\n", *dom_list));
> +   compat = 1;
> +   compat_backend = talloc_strdup( idmap_ctx, "tdb");
> +   compat_params = compat_backend;
> }
> 
> if ( ! dom_list) {
> 
> Thanks.
> -Ying




cheers, jerry
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGKzH5IR7qMdg1EfYRAiLkAJ9BQCgqtxZ32hLvucEjloRmgKgkwACg228F
SSjghFgT+nPlfdbh0kIktLY=
=R3im
-END PGP SIGNATURE-
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

Re: [Samba] Idmap back compatible issue

2007-04-22 Thread Gerald (Jerry) Carter 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Li, Ying (ESG) wrote:

> I believe that many users take the default setting without specific
> idmap backend option, if there is no particular idmap requirement. I'd
> like to recommend considering the first situation as back compatible
> issue. At lease let it takes the default tdb backend when no idmap
> domains presented,  no idmap backend in smb.conf.
> 
> Here is a patch for this. Could somebody look at it?

Looks right to me.  I'll add this for 3.0.25rc2.



jerry
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGKzGSIR7qMdg1EfYRArbpAKDc1Adhv3oMYv83xm4nNNQ49oqHegCeI4Id
UxqzrqxSeU8EOnM3G/y8R04=
=/bzx
-END PGP SIGNATURE-
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba