CVS update: samba/source/client
Date: Sun Sep 29 06:44:13 2002 Author: sharpe Update of /data/cvs/samba/source/client In directory dp.samba.org:/tmp/cvs-serv17645/client Modified Files: client.c Log Message: Make sure that variable does not shadow a parameter. Revisions: client.c1.222 => 1.223 http://www.samba.org/cgi-bin/cvsweb/samba/source/client/client.c?r1=1.222&r2=1.223
CVS update: samba/source/lib
Date: Sun Sep 29 06:07:58 2002 Author: abartlet Update of /data/cvs/samba/source/lib In directory dp.samba.org:/tmp/cvs-serv14761/lib Modified Files: util_sid.c Log Message: Remove sam/api.c. In order to reduce complexity, this patch removes the upper layer of the SAM API. Also, we remove the function pointers on the sam context - there really is no point making these replaceable - that's for the modules. Move a number of functions in include/interface.c around to allow for use of 'static' and to keep the external API in one chunk, at the bottem. All these functions were renamed to remove the context_sam -> sam Consequential changes in the samtest module, and back out metze's change for ACB filtering, becouse I think it belongs in the SAM backeds. (But I will take debate on this one). Changes to the lib/util_sid.c code to create a 'system' token, and make it a SAM_ASSERT() enforced requirement to have a token on those calls that specify it. samtest now uses this. We should have a samtest call to set your own token. We also need to extend our se_access code to cover the things that Win2k is returning in it's access tokens. Currently our system token doesn't pass, due to unexpected flags. (When running sam_ads against Win2k) Andrew Bartlett Revisions: util_sid.c 1.60 => 1.61 http://www.samba.org/cgi-bin/cvsweb/samba/source/lib/util_sid.c?r1=1.60&r2=1.61
CVS update: samba/source/torture
Date: Sun Sep 29 06:07:58 2002 Author: abartlet Update of /data/cvs/samba/source/torture In directory dp.samba.org:/tmp/cvs-serv14761/torture Modified Files: cmd_sam.c samtest.c Log Message: Remove sam/api.c. In order to reduce complexity, this patch removes the upper layer of the SAM API. Also, we remove the function pointers on the sam context - there really is no point making these replaceable - that's for the modules. Move a number of functions in include/interface.c around to allow for use of 'static' and to keep the external API in one chunk, at the bottem. All these functions were renamed to remove the context_sam -> sam Consequential changes in the samtest module, and back out metze's change for ACB filtering, becouse I think it belongs in the SAM backeds. (But I will take debate on this one). Changes to the lib/util_sid.c code to create a 'system' token, and make it a SAM_ASSERT() enforced requirement to have a token on those calls that specify it. samtest now uses this. We should have a samtest call to set your own token. We also need to extend our se_access code to cover the things that Win2k is returning in it's access tokens. Currently our system token doesn't pass, due to unexpected flags. (When running sam_ads against Win2k) Andrew Bartlett Revisions: cmd_sam.c 1.10 => 1.11 http://www.samba.org/cgi-bin/cvsweb/samba/source/torture/cmd_sam.c?r1=1.10&r2=1.11 samtest.c 1.11 => 1.12 http://www.samba.org/cgi-bin/cvsweb/samba/source/torture/samtest.c?r1=1.11&r2=1.12
CVS update: samba/source/sam
Date: Sun Sep 29 06:07:58 2002 Author: abartlet Update of /data/cvs/samba/source/sam In directory dp.samba.org:/tmp/cvs-serv14761/sam Modified Files: interface.c Removed Files: api.c Log Message: Remove sam/api.c. In order to reduce complexity, this patch removes the upper layer of the SAM API. Also, we remove the function pointers on the sam context - there really is no point making these replaceable - that's for the modules. Move a number of functions in include/interface.c around to allow for use of 'static' and to keep the external API in one chunk, at the bottem. All these functions were renamed to remove the context_sam -> sam Consequential changes in the samtest module, and back out metze's change for ACB filtering, becouse I think it belongs in the SAM backeds. (But I will take debate on this one). Changes to the lib/util_sid.c code to create a 'system' token, and make it a SAM_ASSERT() enforced requirement to have a token on those calls that specify it. samtest now uses this. We should have a samtest call to set your own token. We also need to extend our se_access code to cover the things that Win2k is returning in it's access tokens. Currently our system token doesn't pass, due to unexpected flags. (When running sam_ads against Win2k) Andrew Bartlett Revisions: interface.c 1.18 => 1.19 http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/interface.c?r1=1.18&r2=1.19 api.c 1.5 => NONE http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/api.c?rev=1.5
CVS update: samba/source/include
Date: Sun Sep 29 06:07:58 2002 Author: abartlet Update of /data/cvs/samba/source/include In directory dp.samba.org:/tmp/cvs-serv14761/include Modified Files: sam.h Log Message: Remove sam/api.c. In order to reduce complexity, this patch removes the upper layer of the SAM API. Also, we remove the function pointers on the sam context - there really is no point making these replaceable - that's for the modules. Move a number of functions in include/interface.c around to allow for use of 'static' and to keep the external API in one chunk, at the bottem. All these functions were renamed to remove the context_sam -> sam Consequential changes in the samtest module, and back out metze's change for ACB filtering, becouse I think it belongs in the SAM backeds. (But I will take debate on this one). Changes to the lib/util_sid.c code to create a 'system' token, and make it a SAM_ASSERT() enforced requirement to have a token on those calls that specify it. samtest now uses this. We should have a samtest call to set your own token. We also need to extend our se_access code to cover the things that Win2k is returning in it's access tokens. Currently our system token doesn't pass, due to unexpected flags. (When running sam_ads against Win2k) Andrew Bartlett Revisions: sam.h 1.13 => 1.14 http://www.samba.org/cgi-bin/cvsweb/samba/source/include/sam.h?r1=1.13&r2=1.14
CVS update: samba/source
Date: Sun Sep 29 06:07:58 2002 Author: abartlet Update of /data/cvs/samba/source In directory dp.samba.org:/tmp/cvs-serv14761 Modified Files: Makefile.in Log Message: Remove sam/api.c. In order to reduce complexity, this patch removes the upper layer of the SAM API. Also, we remove the function pointers on the sam context - there really is no point making these replaceable - that's for the modules. Move a number of functions in include/interface.c around to allow for use of 'static' and to keep the external API in one chunk, at the bottem. All these functions were renamed to remove the context_sam -> sam Consequential changes in the samtest module, and back out metze's change for ACB filtering, becouse I think it belongs in the SAM backeds. (But I will take debate on this one). Changes to the lib/util_sid.c code to create a 'system' token, and make it a SAM_ASSERT() enforced requirement to have a token on those calls that specify it. samtest now uses this. We should have a samtest call to set your own token. We also need to extend our se_access code to cover the things that Win2k is returning in it's access tokens. Currently our system token doesn't pass, due to unexpected flags. (When running sam_ads against Win2k) Andrew Bartlett Revisions: Makefile.in 1.545 => 1.546 http://www.samba.org/cgi-bin/cvsweb/samba/source/Makefile.in?r1=1.545&r2=1.546
Re: CVS update: samba/source/libsmb
On Sun, 29 Sep 2002, Jelmer Vernooij wrote: > On Sun, Sep 29, 2002 at 10:07:40AM +0930, Richard Sharpe wrote about 'Re: CVS >update: samba/source/libsmb': > > On Sat, 28 Sep 2002 [EMAIL PROTECTED] wrote: > > > > > Date: Sat Sep 28 21:42:51 2002 > > > Author: jelmer > > > > Update of /home/cvs/samba/source/libsmb > > > In directory dp.samba.org:/tmp/cvs-serv11934/libsmb > > > > Modified Files: > > > Tag: SAMBA_3_0 > > > libsmb_cache.c libsmb_compat.c > > > Log Message: > > > > Change libsmbclient.h -> ../include/libsmbclient.h in 3.0 as well > > This is probably the wrong fix. The right fix is to have -Iinclude at the > > right place on CFLAGS or CPPFLAGS or whereever. > No. Some distributions (for example, debian), put a libsmbclient.h > file in /usr/include. stdio.h/unistd.h/etc come from this directory as well, so we > can't exclude it.. Oops, I meant -I./include ... :-) Regards - Richard Sharpe, [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED]
CVS update: samba/source/sam
Date: Sun Sep 29 01:01:44 2002 Author: abartlet Update of /data/cvs/samba/source/sam In directory dp.samba.org:/tmp/cvs-serv28354/sam Modified Files: sam_ads.c Log Message: Updates for sam_ads by metze - add the start of domain policy searching, and a small fix for the previous merge. Andrew Bartlett Revisions: sam_ads.c 1.2 => 1.3 http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/sam_ads.c?r1=1.2&r2=1.3
Re: CVS update: samba/source/libsmb
Jelmer Vernooij wrote: > > On Sun, Sep 29, 2002 at 10:07:40AM +0930, Richard Sharpe wrote about 'Re: CVS >update: samba/source/libsmb': > > On Sat, 28 Sep 2002 [EMAIL PROTECTED] wrote: > > > > Date: Sat Sep 28 21:42:51 2002 > > > Author: jelmer > > > > Update of /home/cvs/samba/source/libsmb > > > In directory dp.samba.org:/tmp/cvs-serv11934/libsmb > > > > Modified Files: > > > Tag: SAMBA_3_0 > > > libsmb_cache.c libsmb_compat.c > > > Log Message: > > > > Change libsmbclient.h -> ../include/libsmbclient.h in 3.0 as well > > This is probably the wrong fix. The right fix is to have -Iinclude at the > > right place on CFLAGS or CPPFLAGS or whereever. > No. Some distributions (for example, debian), put a libsmbclient.h > file in /usr/include. stdio.h/unistd.h/etc come from this directory as well, so we > can't exclude it.. What Richard means is put *our* -Iinclude before the system -I/usr/include in the CFLAGS. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
Re: CVS update: samba/source/libsmb
On Sun, Sep 29, 2002 at 10:07:40AM +0930, Richard Sharpe wrote about 'Re: CVS update: samba/source/libsmb': > On Sat, 28 Sep 2002 [EMAIL PROTECTED] wrote: > > Date: Sat Sep 28 21:42:51 2002 > > Author: jelmer > > Update of /home/cvs/samba/source/libsmb > > In directory dp.samba.org:/tmp/cvs-serv11934/libsmb > > Modified Files: > > Tag: SAMBA_3_0 > > libsmb_cache.c libsmb_compat.c > > Log Message: > > Change libsmbclient.h -> ../include/libsmbclient.h in 3.0 as well > This is probably the wrong fix. The right fix is to have -Iinclude at the > right place on CFLAGS or CPPFLAGS or whereever. No. Some distributions (for example, debian), put a libsmbclient.h file in /usr/include. stdio.h/unistd.h/etc come from this directory as well, so we can't exclude it.. -- Jelmer Vernooij <[EMAIL PROTECTED]> Pending (unfinished) patches http://samba.org/~jelmer/diffs.php
Re: CVS update: samba/source/sam
On Sun, Sep 29, 2002 at 10:01:33AM +1000, Andrew Bartlett wrote about 'Re: CVS update: samba/source/sam': > Jelmer Vernooij wrote: > > On Sat, Sep 28, 2002 at 10:26:19AM -0400, [EMAIL PROTECTED] wrote about 'CVS >update: samba/source/sam': > > > I need to work out with Jelmer an appropriate way to ensure we still have an > > > example external build, and if this should move back out again. > > What 'example external build' do you mean ? > Well, when sam_skel was in examples, we had somthing people could start > with to build a plugin, without much modification. > If I build sam_skel as part of the normal build, we don't have this > example any more... > Perhaps we should just put the makefile in source/sam/ ? I think we should probably have make rules in the Makefile in source/ to build plugins. These modules shouldn't be built by default(make all) - so one has to type "make plugins/sam_ads.so" or "make sam/sam_ads.so" to compile it.. Jelmer -- Jelmer Vernooij <[EMAIL PROTECTED]> Pending (unfinished) patches http://samba.org/~jelmer/diffs.php
Re: CVS update: samba/source/sam
Jelmer Vernooij wrote: > > On Sat, Sep 28, 2002 at 10:26:19AM -0400, [EMAIL PROTECTED] wrote about 'CVS >update: samba/source/sam': > > I need to work out with Jelmer an appropriate way to ensure we still have an > > example external build, and if this should move back out again. > What 'example external build' do you mean ? Well, when sam_skel was in examples, we had somthing people could start with to build a plugin, without much modification. If I build sam_skel as part of the normal build, we don't have this example any more... Perhaps we should just put the makefile in source/sam/ ? Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
Re: CVS update: samba/source/libsmb
On Sat, 28 Sep 2002 [EMAIL PROTECTED] wrote: > > Date: Sat Sep 28 21:42:51 2002 > Author: jelmer > > Update of /home/cvs/samba/source/libsmb > In directory dp.samba.org:/tmp/cvs-serv11934/libsmb > > Modified Files: > Tag: SAMBA_3_0 > libsmb_cache.c libsmb_compat.c > Log Message: > > Change libsmbclient.h -> ../include/libsmbclient.h in 3.0 as well This is probably the wrong fix. The right fix is to have -Iinclude at the right place on CFLAGS or CPPFLAGS or whereever. Regards - Richard Sharpe, [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED]
CVS update: samba/source/torture
Date: Sat Sep 28 22:58:44 2002 Author: jelmer Update of /home/cvs/samba/source/torture In directory dp.samba.org:/tmp/cvs-serv20430/torture Modified Files: cmd_sam.c Log Message: Fix 'plugin' command Revisions: cmd_sam.c 1.9 => 1.10 http://www.samba.org/cgi-bin/cvsweb/samba/source/torture/cmd_sam.c?r1=1.9&r2=1.10
CVS update: samba/source/sam
Date: Sat Sep 28 22:54:16 2002 Author: jelmer Update of /home/cvs/samba/source/sam In directory dp.samba.org:/tmp/cvs-serv20186/sam Modified Files: interface.c Log Message: Fix typos + report FIXME Revisions: interface.c 1.17 => 1.18 http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/interface.c?r1=1.17&r2=1.18
CVS update: samba/source/libsmb
Date: Sat Sep 28 21:42:51 2002 Author: jelmer Update of /home/cvs/samba/source/libsmb In directory dp.samba.org:/tmp/cvs-serv11934/libsmb Modified Files: Tag: SAMBA_3_0 libsmb_cache.c libsmb_compat.c Log Message: Change libsmbclient.h -> ../include/libsmbclient.h in 3.0 as well Revisions: libsmb_cache.c 1.2.2.2 => 1.2.2.3 http://www.samba.org/cgi-bin/cvsweb/samba/source/libsmb/libsmb_cache.c?r1=1.2.2.2&r2=1.2.2.3 libsmb_compat.c 1.2.2.1 => 1.2.2.2 http://www.samba.org/cgi-bin/cvsweb/samba/source/libsmb/libsmb_compat.c?r1=1.2.2.1&r2=1.2.2.2
CVS update: samba/source/torture
Date: Sat Sep 28 21:17:34 2002 Author: jelmer Update of /home/cvs/samba/source/torture In directory dp.samba.org:/tmp/cvs-serv10412/torture Modified Files: cmd_sam.c Log Message: Patch from metze to fix enum_accounts Revisions: cmd_sam.c 1.8 => 1.9 http://www.samba.org/cgi-bin/cvsweb/samba/source/torture/cmd_sam.c?r1=1.8&r2=1.9
CVS update: samba/source/libsmb
Date: Sat Sep 28 20:44:23 2002 Author: jht Update of /data/cvs/samba/source/libsmb In directory dp.samba.org:/tmp/cvs-serv8614 Modified Files: libsmb_cache.c libsmb_compat.c Log Message: Fixing path to libsmbclient.h so it never gets crossed with a system installed one. Revisions: libsmb_cache.c 1.3 => 1.4 http://www.samba.org/cgi-bin/cvsweb/samba/source/libsmb/libsmb_cache.c?r1=1.3&r2=1.4 libsmb_compat.c 1.2 => 1.3 http://www.samba.org/cgi-bin/cvsweb/samba/source/libsmb/libsmb_compat.c?r1=1.2&r2=1.3
CVS update: samba/source/libsmb
Date: Sat Sep 28 20:09:30 2002 Author: jelmer Update of /home/cvs/samba/source/libsmb In directory dp.samba.org:/tmp/cvs-serv5912/libsmb Modified Files: libsmbclient.c Log Message: Include ../include/libsmbclient.h instead of just libsmbclient.h - we don't want to include the globally installed libsmbclient.h - found by jht Revisions: libsmbclient.c 1.59 => 1.60 http://www.samba.org/cgi-bin/cvsweb/samba/source/libsmb/libsmbclient.c?r1=1.59&r2=1.60
CVS update: samba/source/libsmb
Date: Sat Sep 28 20:06:42 2002 Author: jelmer Update of /home/cvs/samba/source/libsmb In directory dp.samba.org:/tmp/cvs-serv5688/libsmb Modified Files: Tag: SAMBA_3_0 libsmbclient.c Log Message: Include ../include/libsmbclient.h instead of just libsmbclient.h - we don't want to include the globally installed libsmbclient.h - found by jht Revisions: libsmbclient.c 1.50.2.2 => 1.50.2.3 http://www.samba.org/cgi-bin/cvsweb/samba/source/libsmb/libsmbclient.c?r1=1.50.2.2&r2=1.50.2.3
Re: CVS update: samba/source/sam
On Sat, Sep 28, 2002 at 10:26:19AM -0400, [EMAIL PROTECTED] wrote about 'CVS update: samba/source/sam': > I need to work out with Jelmer an appropriate way to ensure we still have an > example external build, and if this should move back out again. What 'example external build' do you mean ? Jelmer -- Jelmer Vernooij <[EMAIL PROTECTED]> Pending (unfinished) patches http://samba.org/~jelmer/diffs.php
CVS update: samba/source/libsmb
Date: Sat Sep 28 15:01:58 2002 Author: vlendec Update of /data/cvs/samba/source/libsmb In directory dp.samba.org:/tmp/cvs-serv17138 Modified Files: cliconnect.c Log Message: Ok, hopefully final fix for this one. abartlet told a bit about the history. Volker Revisions: cliconnect.c1.109 => 1.110 http://www.samba.org/cgi-bin/cvsweb/samba/source/libsmb/cliconnect.c?r1=1.109&r2=1.110
CVS update: samba/source/libads
Date: Sat Sep 28 14:42:32 2002 Author: abartlet Update of /data/cvs/samba/source/libads In directory dp.samba.org:/tmp/cvs-serv15928/libads Modified Files: disp_sec.c krb5_setpw.c ldap.c sasl.c Log Message: Try to compile as much as possible with only ldap, but not kerberos. Revisions: disp_sec.c 1.4 => 1.5 http://www.samba.org/cgi-bin/cvsweb/samba/source/libads/disp_sec.c?r1=1.4&r2=1.5 krb5_setpw.c1.8 => 1.9 http://www.samba.org/cgi-bin/cvsweb/samba/source/libads/krb5_setpw.c?r1=1.8&r2=1.9 ldap.c 1.80 => 1.81 http://www.samba.org/cgi-bin/cvsweb/samba/source/libads/ldap.c?r1=1.80&r2=1.81 sasl.c 1.9 => 1.10 http://www.samba.org/cgi-bin/cvsweb/samba/source/libads/sasl.c?r1=1.9&r2=1.10
CVS update: samba/source/include
Date: Sat Sep 28 14:41:12 2002 Author: abartlet Update of /data/cvs/samba/source/include In directory dp.samba.org:/tmp/cvs-serv15759/include Modified Files: sam.h Log Message: Forgot to commit this in the patch changing back the create_user API. Revisions: sam.h 1.12 => 1.13 http://www.samba.org/cgi-bin/cvsweb/samba/source/include/sam.h?r1=1.12&r2=1.13
CVS update: samba/source/sam
Date: Sat Sep 28 14:26:19 2002 Author: abartlet Update of /data/cvs/samba/source/sam In directory dp.samba.org:/tmp/cvs-serv14921/sam Modified Files: api.c interface.c sam_ads.c Added Files: sam_skel.c Log Message: Back out one of the API changes, now I recall how it was meant to work. (New accounts are created on thier internal talloc context, not a supplied one and not the one beloning to the SAM) Also actaully add the sam_skel to the tree. I need to work out with Jelmer an appropriate way to ensure we still have an example external build, and if this should move back out again. Andrew Bartlett Revisions: sam_skel.c NONE => 1.1 http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/sam_skel.c?rev=1.1 api.c 1.4 => 1.5 http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/api.c?r1=1.4&r2=1.5 interface.c 1.16 => 1.17 http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/interface.c?r1=1.16&r2=1.17 sam_ads.c 1.1 => 1.2 http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/sam_ads.c?r1=1.1&r2=1.2
CVS update: samba/source/auth
Date: Sat Sep 28 13:29:51 2002 Author: abartlet Update of /data/cvs/samba/source/auth In directory dp.samba.org:/tmp/cvs-serv11382/auth Modified Files: pass_check.c Log Message: Second stab at Volker's 'make shadow passwords work' patch. Basicly, the password and the salt must be taken from the same place in both passwd and shadow based systems. Taking salt from one, and password from the other just doesn't work. So pull them from passwd, then overwrite them if need be. When modifying this file, watch the #ifdef hell - as vl found out, some variables are globals - but only with #ifndef WITH_PAM, and the code jumps all over the place with the password cracker. Getting double-reviews of any change to this file highly advised, it is one of our most system-specifc areas of code. (So now I get to take the blame for this one... :-) Andrew Bartlett Revisions: pass_check.c1.34 => 1.35 http://www.samba.org/cgi-bin/cvsweb/samba/source/auth/pass_check.c?r1=1.34&r2=1.35
Re: CVS update: samba/source/auth
On Sat, Sep 28, 2002 at 10:50:07PM +1000, Andrew Bartlett wrote: > How is this for a better patch? Compiles and works for me with NT4SP0 and HEAD smbclient. Now we broke smbclient version 2.2.1a with unicode=yes on smbd. :-( Volker msg00604/pgp0.pgp Description: PGP signature
Re: CVS update: samba/source/auth
Andrew Bartlett wrote:
>
> Volker Lendecke wrote:
> >
> > On Fri, Sep 27, 2002 at 07:56:20PM -0400, [EMAIL PROTECTED] wrote:
> > > Back our volker's patch as was breaking the build.
> >
> > Sorry for breaking it. On my machine it compiled well
>
> Not as actually commited - you had an undeclared variable in there.
>
> >, I even tested against
> > smbclient, NT4 and W2k. At least on Linux with shadow passwords you do not get
> > the password salt from /etc/passwd but from /etc/shadow. On my machine an 'x'
> > ended up in the salt, which was definitely not what crypt wanted to see.
> >
> > What kind of fix do you propose? Changing to a default of encrypted passwords
> > should IMHO not mean we do not support plaintext at all anymore.
>
> I don't mind fixing it - I was mainly worried about the compile
> failure. Things that don't compile don't ususally look tested ;-)
>
> I also just want to look over it carefully, as much for my own benifit
> in understanding this crazy stuff.
How is this for a better patch?
Andrew Bartlett
--
Andrew Bartlett [EMAIL PROTECTED]
Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED]
Student Network Administrator, Hawker College [EMAIL PROTECTED]
http://samba.org http://build.samba.org http://hawkerc.net
? auth/auth_ntlmssp.c
Index: auth/pass_check.c
===
RCS file: /data/cvs/samba/source/auth/pass_check.c,v
retrieving revision 1.34
diff -u -r1.34 pass_check.c
--- auth/pass_check.c 27 Sep 2002 23:56:20 - 1.34
+++ auth/pass_check.c 28 Sep 2002 12:48:37 -
@@ -634,6 +634,7 @@
/* Also the place to keep the 'password' no matter what
crazy struct it started in... */
fstrcpy(this_crypted, pass->pw_passwd);
+ fstrcpy(this_salt, pass->pw_passwd);
#ifdef HAVE_GETSPNAM
{
@@ -645,8 +646,10 @@
perhaps for IPC password changing requests */
spass = getspnam(pass->pw_name);
- if (spass && spass->sp_pwdp)
+ if (spass && spass->sp_pwdp) {
fstrcpy(this_crypted, spass->sp_pwdp);
+ fstrcpy(this_salt, spass->sp_pwdp);
+ }
}
#elif defined(IA_UINFO)
{
@@ -703,9 +706,6 @@
}
}
#endif
-
- /* extract relevant info */
- fstrcpy(this_salt, pass->pw_passwd);
#if defined(HAVE_TRUNCATED_SALT)
/* crypt on some platforms (HPUX in particular)
CVS update: samba/source/include
Date: Sat Sep 28 12:27:04 2002 Author: abartlet Update of /data/cvs/samba/source/include In directory dp.samba.org:/tmp/cvs-serv6117/include Modified Files: ads.h sam.h Log Message: Add the beginings of sam_ads to the tree. This module, primarilly the work of "Stefan (metze) Metzmacher" <[EMAIL PROTECTED]>, uses the Active Directory schema to store the user/group/other information. I've been testing it against a real AD server, and it is intended to work with OpenLDAP as well. I've moved a few functions around in our other libads code, which has made it easier to tap into that existing code. Also, I've made some changes to the SAM interface, I hope there are not too many objections... To ensure we don't get silly bugs in the skel module, it is now in the default compile. This way you should not forget to update it :-) Andrew Bartlett Revisions: ads.h 1.19 => 1.20 http://www.samba.org/cgi-bin/cvsweb/samba/source/include/ads.h?r1=1.19&r2=1.20 sam.h 1.11 => 1.12 http://www.samba.org/cgi-bin/cvsweb/samba/source/include/sam.h?r1=1.11&r2=1.12
CVS update: samba/source/libads
Date: Sat Sep 28 12:27:04 2002 Author: abartlet Update of /data/cvs/samba/source/libads In directory dp.samba.org:/tmp/cvs-serv6117/libads Modified Files: ads_ldap.c ads_struct.c ldap.c ldap_utils.c Log Message: Add the beginings of sam_ads to the tree. This module, primarilly the work of "Stefan (metze) Metzmacher" <[EMAIL PROTECTED]>, uses the Active Directory schema to store the user/group/other information. I've been testing it against a real AD server, and it is intended to work with OpenLDAP as well. I've moved a few functions around in our other libads code, which has made it easier to tap into that existing code. Also, I've made some changes to the SAM interface, I hope there are not too many objections... To ensure we don't get silly bugs in the skel module, it is now in the default compile. This way you should not forget to update it :-) Andrew Bartlett Revisions: ads_ldap.c 1.1 => 1.2 http://www.samba.org/cgi-bin/cvsweb/samba/source/libads/ads_ldap.c?r1=1.1&r2=1.2 ads_struct.c1.18 => 1.19 http://www.samba.org/cgi-bin/cvsweb/samba/source/libads/ads_struct.c?r1=1.18&r2=1.19 ldap.c 1.79 => 1.80 http://www.samba.org/cgi-bin/cvsweb/samba/source/libads/ldap.c?r1=1.79&r2=1.80 ldap_utils.c1.2 => 1.3 http://www.samba.org/cgi-bin/cvsweb/samba/source/libads/ldap_utils.c?r1=1.2&r2=1.3
CVS update: samba/source/sam
Date: Sat Sep 28 12:27:04 2002 Author: abartlet Update of /data/cvs/samba/source/sam In directory dp.samba.org:/tmp/cvs-serv6117/sam Modified Files: api.c interface.c Added Files: sam_ads.c Log Message: Add the beginings of sam_ads to the tree. This module, primarilly the work of "Stefan (metze) Metzmacher" <[EMAIL PROTECTED]>, uses the Active Directory schema to store the user/group/other information. I've been testing it against a real AD server, and it is intended to work with OpenLDAP as well. I've moved a few functions around in our other libads code, which has made it easier to tap into that existing code. Also, I've made some changes to the SAM interface, I hope there are not too many objections... To ensure we don't get silly bugs in the skel module, it is now in the default compile. This way you should not forget to update it :-) Andrew Bartlett Revisions: sam_ads.c NONE => 1.1 http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/sam_ads.c?rev=1.1 api.c 1.3 => 1.4 http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/api.c?r1=1.3&r2=1.4 interface.c 1.15 => 1.16 http://www.samba.org/cgi-bin/cvsweb/samba/source/sam/interface.c?r1=1.15&r2=1.16
CVS update: samba/source/torture
Date: Sat Sep 28 12:27:04 2002 Author: abartlet Update of /data/cvs/samba/source/torture In directory dp.samba.org:/tmp/cvs-serv6117/torture Modified Files: cmd_sam.c Log Message: Add the beginings of sam_ads to the tree. This module, primarilly the work of "Stefan (metze) Metzmacher" <[EMAIL PROTECTED]>, uses the Active Directory schema to store the user/group/other information. I've been testing it against a real AD server, and it is intended to work with OpenLDAP as well. I've moved a few functions around in our other libads code, which has made it easier to tap into that existing code. Also, I've made some changes to the SAM interface, I hope there are not too many objections... To ensure we don't get silly bugs in the skel module, it is now in the default compile. This way you should not forget to update it :-) Andrew Bartlett Revisions: cmd_sam.c 1.7 => 1.8 http://www.samba.org/cgi-bin/cvsweb/samba/source/torture/cmd_sam.c?r1=1.7&r2=1.8
CVS update: samba/source
Date: Sat Sep 28 12:27:04 2002 Author: abartlet Update of /data/cvs/samba/source In directory dp.samba.org:/tmp/cvs-serv6117 Modified Files: Makefile.in Log Message: Add the beginings of sam_ads to the tree. This module, primarilly the work of "Stefan (metze) Metzmacher" <[EMAIL PROTECTED]>, uses the Active Directory schema to store the user/group/other information. I've been testing it against a real AD server, and it is intended to work with OpenLDAP as well. I've moved a few functions around in our other libads code, which has made it easier to tap into that existing code. Also, I've made some changes to the SAM interface, I hope there are not too many objections... To ensure we don't get silly bugs in the skel module, it is now in the default compile. This way you should not forget to update it :-) Andrew Bartlett Revisions: Makefile.in 1.544 => 1.545 http://www.samba.org/cgi-bin/cvsweb/samba/source/Makefile.in?r1=1.544&r2=1.545
Re: CVS update: samba/source/auth
Volker Lendecke wrote: > > On Fri, Sep 27, 2002 at 07:56:20PM -0400, [EMAIL PROTECTED] wrote: > > Back our volker's patch as was breaking the build. > > Sorry for breaking it. On my machine it compiled well Not as actually commited - you had an undeclared variable in there. >, I even tested against > smbclient, NT4 and W2k. At least on Linux with shadow passwords you do not get > the password salt from /etc/passwd but from /etc/shadow. On my machine an 'x' > ended up in the salt, which was definitely not what crypt wanted to see. > > What kind of fix do you propose? Changing to a default of encrypted passwords > should IMHO not mean we do not support plaintext at all anymore. I don't mind fixing it - I was mainly worried about the compile failure. Things that don't compile don't ususally look tested ;-) I also just want to look over it carefully, as much for my own benifit in understanding this crazy stuff. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
Re: CVS update: samba/source/auth
On Fri, Sep 27, 2002 at 07:56:20PM -0400, [EMAIL PROTECTED] wrote: > Back our volker's patch as was breaking the build. Sorry for breaking it. On my machine it compiled well, I even tested against smbclient, NT4 and W2k. At least on Linux with shadow passwords you do not get the password salt from /etc/passwd but from /etc/shadow. On my machine an 'x' ended up in the salt, which was definitely not what crypt wanted to see. What kind of fix do you propose? Changing to a default of encrypted passwords should IMHO not mean we do not support plaintext at all anymore. Volker msg00596/pgp0.pgp Description: PGP signature
Re: CVS update: samba/source/libsmb
Volker Lendecke wrote: > > On Sat, Sep 28, 2002 at 09:58:38AM +1000, Andrew Bartlett wrote: > > This patch looks wrong. > > Ok, the function was wrong before. The first cli_push_string is simply not > needed. It was there before, I did not look closely enough to notice that it's > redundant. > > > Why is the password being cli_push_string()ed twice, and why is it any > > different to any other string in Samba (which gets made unicode > > automaticly as required). > > cli_push_string calls push_string directly, simply passing though the 'flags'. > These flags say which charset the target string is in. So the call to > cli_push_string has to say itself whether there should be unicode on the wire > or not. The problem I see here is that this might be samba-only behaviour. I do > not know any proprietary server that does unicode and plaintext passwords. But we push other strings onto the wire, like paths, shares, filenames etc. These are all in ASCII or unicode based on the remote server's capabilities, so why is this string any different? As to 'no other servers do', simply hack up smbclient to ignore the encrypted passwords bit, and test. Or use smbfilter to see how MS goes with MS doing this. Or set Samba to 'encrypt passwords = no on the server, and grab an NT4 client's sniffer trace). Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
CVS update: samba/source/libsmb
Date: Sat Sep 28 12:14:17 2002 Author: vlendec Update of /data/cvs/samba/source/libsmb In directory dp.samba.org:/tmp/cvs-serv6111 Modified Files: cliconnect.c Log Message: Thanks to abartlet I looked at that function a bit closer. What did the first cli_push_string do? I suspect that it's a leftover from times when the password length was needed at some point. Volker Revisions: cliconnect.c1.108 => 1.109 http://www.samba.org/cgi-bin/cvsweb/samba/source/libsmb/cliconnect.c?r1=1.108&r2=1.109
Re: CVS update: samba/source/libsmb
On Sat, Sep 28, 2002 at 09:58:38AM +1000, Andrew Bartlett wrote: > This patch looks wrong. Ok, the function was wrong before. The first cli_push_string is simply not needed. It was there before, I did not look closely enough to notice that it's redundant. > Why is the password being cli_push_string()ed twice, and why is it any > different to any other string in Samba (which gets made unicode > automaticly as required). cli_push_string calls push_string directly, simply passing though the 'flags'. These flags say which charset the target string is in. So the call to cli_push_string has to say itself whether there should be unicode on the wire or not. The problem I see here is that this might be samba-only behaviour. I do not know any proprietary server that does unicode and plaintext passwords. Volker msg00593/pgp0.pgp Description: PGP signature
CVS update: samba/source/lib
Date: Sat Sep 28 12:11:19 2002 Author: abartlet Update of /data/cvs/samba/source/lib In directory dp.samba.org:/tmp/cvs-serv5924/lib Modified Files: util_seaccess.c Log Message: Add const. Revisions: util_seaccess.c 1.34 => 1.35 http://www.samba.org/cgi-bin/cvsweb/samba/source/lib/util_seaccess.c?r1=1.34&r2=1.35
CVS update: samba/source/passdb
Date: Sat Sep 28 12:09:21 2002 Author: abartlet Update of /data/cvs/samba/source/passdb In directory dp.samba.org:/tmp/cvs-serv5714/passdb Modified Files: secrets.c Log Message: Add const. Revisions: secrets.c 1.46 => 1.47 http://www.samba.org/cgi-bin/cvsweb/samba/source/passdb/secrets.c?r1=1.46&r2=1.47
