Re: svn commit: samba r6219 - in branches/SAMBA_4_0/source: librpc/rpcntvfs/posix
> Author: sharpe > Date: 2005-04-05 19:53:07 + (Tue, 05 Apr 2005) > New Revision: 6219 > > WebSVN: > http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6219 > > Log: > > This change allows us to fall back to authenticating without > DCERPC_SCHANNEL_128 if we fail. Thus, it allows us to work with Windows > NT DCs ... > > > Modified: >branches/SAMBA_4_0/source/librpc/rpc/dcerpc_schannel.c >branches/SAMBA_4_0/source/ntvfs/posix/pvfs_search.c > Modified: branches/SAMBA_4_0/source/ntvfs/posix/pvfs_search.c > === > --- branches/SAMBA_4_0/source/ntvfs/posix/pvfs_search.c 2005-04-05 > 17:49:16 UTC (rev 6218) > +++ branches/SAMBA_4_0/source/ntvfs/posix/pvfs_search.c 2005-04-05 > 19:53:07 UTC (rev 6219) > @@ -266,7 +266,7 @@ > talloc_free(file); > } > > - pvfs_list_hibernate(dir); > + /*pvfs_list_hibernate(dir);*/ do really wanted this to be commited?
svn commit: samba r6222 - in branches/SAMBA_4_0/source/lib/socket_wrapper: .
Author: tridge Date: 2005-04-06 10:06:08 + (Wed, 06 Apr 2005) New Revision: 6222 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6222 Log: fixed the socket wrapper code for getsockname() Modified: branches/SAMBA_4_0/source/lib/socket_wrapper/socket_wrapper.c Changeset: Modified: branches/SAMBA_4_0/source/lib/socket_wrapper/socket_wrapper.c === --- branches/SAMBA_4_0/source/lib/socket_wrapper/socket_wrapper.c 2005-04-06 03:08:25 UTC (rev 6221) +++ branches/SAMBA_4_0/source/lib/socket_wrapper/socket_wrapper.c 2005-04-06 10:06:08 UTC (rev 6222) @@ -321,7 +321,7 @@ struct socket_info *si = find_socket_info(s); if (!si) { - return real_getpeername(s, name, addrlen); + return real_getsockname(s, name, addrlen); } memcpy(name, si->myname, si->myname_len);
svn commit: samba r6223 - in branches/SAMBA_4_0/source: libcli libcli/dgram librpc/idl torture torture/nbt
Author: tridge Date: 2005-04-06 11:17:08 + (Wed, 06 Apr 2005) New Revision: 6223 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6223 Log: added a bit more datagram infrastructure and the beginnings of a test suite. The NBT-DGRAM test does a UDP/138 netlogon request, to which a windows server sends a reply, but the windows server sends the reply to the wrong port (it always sends to 138), so the test suite doesn't see it. Added: branches/SAMBA_4_0/source/libcli/dgram/netlogon.c branches/SAMBA_4_0/source/torture/nbt/dgram.c Modified: branches/SAMBA_4_0/source/libcli/config.mk branches/SAMBA_4_0/source/libcli/dgram/libdgram.h branches/SAMBA_4_0/source/libcli/dgram/mailslot.c branches/SAMBA_4_0/source/librpc/idl/nbt.idl branches/SAMBA_4_0/source/torture/config.mk branches/SAMBA_4_0/source/torture/torture.c Changeset: Sorry, the patch is too large (399 lines) to include; please use WebSVN to see it! WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6223
svn commit: samba r6224 - in trunk/source: include passdb rpc_server
Author: jmcd Date: 2005-04-06 13:47:21 + (Wed, 06 Apr 2005) New Revision: 6224 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6224 Log: merge patch I'd checked in on 3.0: Volker's work on ldapsam trusted lookuprids Modified: trunk/source/include/passdb.h trunk/source/passdb/pdb_interface.c trunk/source/passdb/pdb_ldap.c trunk/source/rpc_server/srv_samr_nt.c Changeset: Sorry, the patch is too large (567 lines) to include; please use WebSVN to see it! WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6224
svn commit: samba r6225 - in branches/SAMBA_3_0/source: auth client groupdb include lib libsmb modules nmbd nsswitch param passdb printing rpc_server smbd tdb utils web
Author: herb Date: 2005-04-06 16:28:04 + (Wed, 06 Apr 2005) New Revision: 6225 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6225 Log: get rid of warnings from my compiler about nested externs Modified: branches/SAMBA_3_0/source/auth/auth_compat.c branches/SAMBA_3_0/source/auth/auth_sam.c branches/SAMBA_3_0/source/client/client.c branches/SAMBA_3_0/source/client/clitar.c branches/SAMBA_3_0/source/groupdb/mapping.c branches/SAMBA_3_0/source/include/smb_macros.h branches/SAMBA_3_0/source/lib/substitute.c branches/SAMBA_3_0/source/lib/util.c branches/SAMBA_3_0/source/lib/util_seaccess.c branches/SAMBA_3_0/source/lib/wins_srv.c branches/SAMBA_3_0/source/libsmb/cliconnect.c branches/SAMBA_3_0/source/libsmb/clientgen.c branches/SAMBA_3_0/source/libsmb/clilist.c branches/SAMBA_3_0/source/libsmb/nmblib.c branches/SAMBA_3_0/source/modules/vfs_fake_perms.c branches/SAMBA_3_0/source/nmbd/nmbd.c branches/SAMBA_3_0/source/nmbd/nmbd_subnetdb.c branches/SAMBA_3_0/source/nmbd/nmbd_synclists.c branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c branches/SAMBA_3_0/source/nsswitch/winbindd_util.c branches/SAMBA_3_0/source/param/loadparm.c branches/SAMBA_3_0/source/param/params.c branches/SAMBA_3_0/source/passdb/pdb_ldap.c branches/SAMBA_3_0/source/printing/nt_printing.c branches/SAMBA_3_0/source/printing/printfsp.c branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c branches/SAMBA_3_0/source/rpc_server/srv_netlog_nt.c branches/SAMBA_3_0/source/rpc_server/srv_pipe.c branches/SAMBA_3_0/source/rpc_server/srv_samr_nt.c branches/SAMBA_3_0/source/rpc_server/srv_spoolss_nt.c branches/SAMBA_3_0/source/rpc_server/srv_srvsvc_nt.c branches/SAMBA_3_0/source/smbd/dir.c branches/SAMBA_3_0/source/smbd/error.c branches/SAMBA_3_0/source/smbd/fake_file.c branches/SAMBA_3_0/source/smbd/lanman.c branches/SAMBA_3_0/source/smbd/negprot.c branches/SAMBA_3_0/source/smbd/nttrans.c branches/SAMBA_3_0/source/smbd/open.c branches/SAMBA_3_0/source/smbd/oplock.c branches/SAMBA_3_0/source/smbd/oplock_linux.c branches/SAMBA_3_0/source/smbd/posix_acls.c branches/SAMBA_3_0/source/smbd/process.c branches/SAMBA_3_0/source/smbd/reply.c branches/SAMBA_3_0/source/smbd/server.c branches/SAMBA_3_0/source/smbd/service.c branches/SAMBA_3_0/source/smbd/sesssetup.c branches/SAMBA_3_0/source/smbd/trans2.c branches/SAMBA_3_0/source/tdb/tdbbackup.c branches/SAMBA_3_0/source/utils/net.c branches/SAMBA_3_0/source/web/diagnose.c Changeset: Sorry, the patch is too large (1541 lines) to include; please use WebSVN to see it! WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6225
svn commit: samba r6226 - in branches/SAMBA_4_0: .
Author: sharpe Date: 2005-04-06 16:48:28 + (Wed, 06 Apr 2005) New Revision: 6226 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6226 Log: A couple of small typos ... Modified: branches/SAMBA_4_0/prog_guide.txt Changeset: Modified: branches/SAMBA_4_0/prog_guide.txt === --- branches/SAMBA_4_0/prog_guide.txt 2005-04-06 16:28:04 UTC (rev 6225) +++ branches/SAMBA_4_0/prog_guide.txt 2005-04-06 16:48:28 UTC (rev 6226) @@ -207,7 +207,7 @@ In Samba3 many of the core wire structures in the SMB protocol were never explicitly defined in Samba. Instead, our parse and generation functions just worked directly with wire buffers. The biggest problem -with this is that is tied our parse code with out "business logic" +with this is that is tied our parse code with our "business logic" much too closely, which meant the code got extremely confusing to read. @@ -395,7 +395,7 @@ each SMB. As an example go and have a look at reply_getatr_send() and -reply_getatr() in smbd/reply.c. Read them? Good. +reply_getatr() in smb_server/reply.c. Read them? Good. Notice that reply_getatr() sets up the req->async structure to contain the send function. Thats how the backend gets to do an async reply, it
svn commit: samba r6227 - in trunk/swat/js: .
Author: deryck Date: 2005-04-06 21:45:32 + (Wed, 06 Apr 2005) New Revision: 6227 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6227 Log: Correct fix for testing page load before dynamically loading another page in the help menu. --deryck (remembering the fable--"slow and steady wins the race") :-) Modified: trunk/swat/js/domPipe.js Changeset: Modified: trunk/swat/js/domPipe.js === --- trunk/swat/js/domPipe.js2005-04-06 16:48:28 UTC (rev 6226) +++ trunk/swat/js/domPipe.js2005-04-06 21:45:32 UTC (rev 6227) @@ -33,7 +33,8 @@ sandbox.setAttribute('id', 'stage'); page.appendChild(sandbox); - var curtain = document.getElementById('stage'); + // Don't declare this one local, either + curtain = document.getElementById('stage'); curtain.style.position = 'absolute'; curtain.style.top = '-1200px'; } @@ -100,8 +101,9 @@ // Ensure iframe has finished loading before cut-n-paste function checkStage(target) { - if (stage.document.getElementsByTagName('body')[0]) { + if ( (stage.document.getElementsByTagName('body')[0]) && (stage.document.getElementsByTagName('body')[0].childNodes.length >= 1) ) { getPage(target); + page.removeChild(curtain) clearInterval(docCheck); } } @@ -111,6 +113,7 @@ { var target; + // Pass id as quoted string if not 'page' if (id == 'page') { target = id; } else {
svn commit: samba r6228 - in branches/SAMBA_3_0/source: include rpc_client rpc_parse rpc_server
Author: jerry Date: 2005-04-06 22:27:55 + (Wed, 06 Apr 2005) New Revision: 6228 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6228 Log: remove BUFHDR2 and clean up LsaEnumTrustedDomains() Tested client and server code. Modified: branches/SAMBA_3_0/source/include/rpc_lsa.h branches/SAMBA_3_0/source/include/rpc_misc.h branches/SAMBA_3_0/source/rpc_client/cli_lsarpc.c branches/SAMBA_3_0/source/rpc_parse/parse_lsa.c branches/SAMBA_3_0/source/rpc_parse/parse_misc.c branches/SAMBA_3_0/source/rpc_parse/parse_reg.c branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c Changeset: Sorry, the patch is too large (549 lines) to include; please use WebSVN to see it! WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6228
svn commit: samba r6229 - in branches/SAMBA_4_0/source: librpc/rpc ntvfs/posix
Author: sharpe Date: 2005-04-06 23:22:52 + (Wed, 06 Apr 2005) New Revision: 6229 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6229 Log: Back out these changes ... Modified: branches/SAMBA_4_0/source/librpc/rpc/dcerpc_schannel.c branches/SAMBA_4_0/source/ntvfs/posix/pvfs_search.c Changeset: Modified: branches/SAMBA_4_0/source/librpc/rpc/dcerpc_schannel.c === --- branches/SAMBA_4_0/source/librpc/rpc/dcerpc_schannel.c 2005-04-06 22:27:55 UTC (rev 6228) +++ branches/SAMBA_4_0/source/librpc/rpc/dcerpc_schannel.c 2005-04-06 23:22:52 UTC (rev 6229) @@ -162,21 +162,7 @@ DEBUG(1, ("Failed to setup credentials for account %s: %s\n", cli_credentials_get_username(credentials), nt_errstr(status))); - /* -* If we get back NT_STATUS_ACCESS_DENIED and we asked for -* DCERPC_SCHANNEL_128, then try again without -*/ - if (NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED) && - p->conn->flags & DCERPC_SCHANNEL_128) { - DEBUG(1, ("Retrying to setup credentials without DCERPC_SCHANNEL_128\n")); - p->conn->flags &= ~DCERPC_SCHANNEL_128; - status = dcerpc_schannel_key(tmp_ctx, -p, credentials, -chan_type); - } - if (!NT_STATUS_IS_OK(status)) { - return status; - } + return status; } return dcerpc_bind_auth_password(p, uuid, version, Modified: branches/SAMBA_4_0/source/ntvfs/posix/pvfs_search.c === --- branches/SAMBA_4_0/source/ntvfs/posix/pvfs_search.c 2005-04-06 22:27:55 UTC (rev 6228) +++ branches/SAMBA_4_0/source/ntvfs/posix/pvfs_search.c 2005-04-06 23:22:52 UTC (rev 6229) @@ -266,7 +266,7 @@ talloc_free(file); } - /*pvfs_list_hibernate(dir);*/ + pvfs_list_hibernate(dir); return NT_STATUS_OK; }
svn commit: samba r6230 - in branches/SAMBA_3_0/source/lib: .
Author: herb Date: 2005-04-06 23:50:48 + (Wed, 06 Apr 2005) New Revision: 6230 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6230 Log: don't know how this ever worked! the compiler complained we were comparing an integer to a pointer and it was right. Modified: branches/SAMBA_3_0/source/lib/util_unistr.c Changeset: Modified: branches/SAMBA_3_0/source/lib/util_unistr.c === --- branches/SAMBA_3_0/source/lib/util_unistr.c 2005-04-06 23:22:52 UTC (rev 6229) +++ branches/SAMBA_3_0/source/lib/util_unistr.c 2005-04-06 23:50:48 UTC (rev 6230) @@ -113,7 +113,7 @@ if (len1 == 0) return 0; len2 = convert_string(CH_DOS, CH_UCS2, buf, len1, &c2, 2,False); if (len2 != 2) return 0; - return (c == c2); + return (c == *c2); }
Build status as of Thu Apr 7 00:00:02 2005
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2005-04-06 00:00:22.0 + +++ /home/build/master/cache/broken_results.txt 2005-04-07 00:00:40.0 + @@ -1,4 +1,4 @@ -Build status as of Wed Apr 6 00:00:02 2005 +Build status as of Thu Apr 7 00:00:02 2005 Build counts: Tree Total Broken Panic @@ -8,8 +8,8 @@ rsync37 4 0 samba1 1 0 samba-docs 0 0 0 -samba4 41 12 0 -samba_3_039 10 0 +samba4 41 14 0 +samba_3_039 15 0 Currently broken builds: Host Tree Compiler Status @@ -19,14 +19,20 @@ rhonwynsamba4 gcc-4.0ok/ 2/?/? rhonwynsamba_3_0gcc-4.0ok/ 2/?/? rhonwynsamba4 tccok/ 2/?/? -aretnapsamba_3_0gccok/ok/ok/ 1 +aretnapsamba_3_0gccok/ 1/?/? aretnapccache iccok/ok/ok/ 1 +aretnapsamba_3_0icc 127/?/?/? +gc4samba_3_0gccok/ 1/?/? +manhattan samba4 cc 127/?/?/? +manhattan samba_3_0cc ok/ 1/?/? +sbfsamba_3_0gccok/ 1/?/? gwen distcc cc ok/ 1/?/? gwen samba4 cc ok/ 1/?/? gwen samba_3_0cc ok/ 1/?/? us4samba_3_0cc ok/ 1/?/? us4samba_3_0gccok/ 1/?/? flock samba4 gccok/ 1/?/? +flock samba_3_0gccok/ 1/?/? shubnigurath samba4 cc ok/ 1/?/? gc20 samba4 gccok/ 2/?/? sun1 rsynccc ok/ok/ok/ 2 @@ -46,5 +52,6 @@ m30samba4 gccok/ 2/?/? m30samba_3_0gccok/ok/ok/ 1 metze02sambagcc 77/?/?/? +l390vme1 samba4 gccok/ 2/?/? opippp gccok/ 2/?/?
svn commit: samba r6231 - in branches/SAMBA_3_0/source/lib: .
Author: jerry Date: 2005-04-07 03:24:02 + (Thu, 07 Apr 2005) New Revision: 6231 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6231 Log: Herb, I think this checkin was a mistake. Are you sure this is what you meant to change? Fix build breakage Modified: branches/SAMBA_3_0/source/lib/util_unistr.c Changeset: Modified: branches/SAMBA_3_0/source/lib/util_unistr.c === --- branches/SAMBA_3_0/source/lib/util_unistr.c 2005-04-06 23:50:48 UTC (rev 6230) +++ branches/SAMBA_3_0/source/lib/util_unistr.c 2005-04-07 03:24:02 UTC (rev 6231) @@ -113,7 +113,7 @@ if (len1 == 0) return 0; len2 = convert_string(CH_DOS, CH_UCS2, buf, len1, &c2, 2,False); if (len2 != 2) return 0; - return (c == *c2); + return (c == c2); }
svn commit: samba r6232 - in branches/SAMBA_3_0/source: include registry rpc_client rpc_parse rpc_server rpcclient
Author: jerry Date: 2005-04-07 04:58:38 + (Thu, 07 Apr 2005) New Revision: 6232 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6232 Log: more cleanups; remove BUFFER3; rename BUFFER4 -> RPC_DATA_BLOB; rename REG_CREATE_VALE -> REG_SET_VALUE Modified: branches/SAMBA_3_0/source/include/rpc_misc.h branches/SAMBA_3_0/source/include/rpc_netlogon.h branches/SAMBA_3_0/source/include/rpc_reg.h branches/SAMBA_3_0/source/registry/reg_db.c branches/SAMBA_3_0/source/rpc_client/cli_reg.c branches/SAMBA_3_0/source/rpc_parse/parse_misc.c branches/SAMBA_3_0/source/rpc_parse/parse_net.c branches/SAMBA_3_0/source/rpc_parse/parse_reg.c branches/SAMBA_3_0/source/rpc_server/srv_reg_nt.c branches/SAMBA_3_0/source/rpcclient/cmd_reg.c Changeset: Sorry, the patch is too large (739 lines) to include; please use WebSVN to see it! WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6232