Build status as of Thu Jul 30 06:00:02 2009
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2009-07-29 00:00:02.0 -0600 +++ /home/build/master/cache/broken_results.txt 2009-07-30 00:00:23.0 -0600 @@ -1,4 +1,4 @@ -Build status as of Wed Jul 29 06:00:01 2009 +Build status as of Thu Jul 30 06:00:02 2009 Build counts: Tree Total Broken Panic @@ -13,10 +13,10 @@ rsync1 1 0 samba-docs 0 0 0 samba-web0 0 0 -samba_3_current 29 18 0 -samba_3_master 32 26 5 +samba_3_current 29 17 0 +samba_3_master 32 27 5 samba_3_next 31 28 0 -samba_4_0_test 33 27 2 -talloc 1 1 0 -tdb 1 1 0 +samba_4_0_test 33 27 3 +talloc 2 2 0 +tdb 2 2 0
[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-1194-g47baa5d
The branch, v3-4-test has been updated
via 47baa5de907c0162dec079c3636e7728f93c8b2f (commit)
from 9d7b8b29854beafed4ec70b2db1d26dc3786cc71 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test
- Log -
commit 47baa5de907c0162dec079c3636e7728f93c8b2f
Author: Jeremy Allison j...@samba.org
Date: Thu Jul 30 08:55:01 2009 +0200
s3/cldap: Improve debug messages.
This patch was made to debug bug #6437.
---
Summary of changes:
source3/libads/cldap.c | 15 +++
1 files changed, 11 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/libads/cldap.c b/source3/libads/cldap.c
index d66e35c..ae087d9 100644
--- a/source3/libads/cldap.c
+++ b/source3/libads/cldap.c
@@ -151,14 +151,19 @@ static int recv_cldap_netlogon(TALLOC_CTX *mem_ctx,
}
if (ret == 0) {
- DEBUG(1,(no reply received to cldap netlogon\n));
+ DEBUG(1,(no reply received to cldap netlogon
+ (select timeout %u sec)\n,
+ (unsigned int)timeout.tv_sec));
data_blob_free(blob);
return -1;
}
ret = read(sock, blob.data, blob.length);
if (ret = 0) {
- DEBUG(1,(no reply received to cldap netlogon\n));
+ DEBUG(1,(no reply received to cldap netlogon
+ (ret = %d: Error = %s)\n,
+ ret,
+ ret == -1 ? strerror(errno) : ));
data_blob_free(blob);
return -1;
}
@@ -251,8 +256,10 @@ bool ads_cldap_netlogon(TALLOC_CTX *mem_ctx,
sock = open_udp_socket(server, LDAP_PORT );
if (sock == -1) {
- DEBUG(2,(ads_cldap_netlogon: Failed to open udp socket to
%s\n,
-server));
+ DEBUG(2,(ads_cldap_netlogon: Failed to open udp socket to %s.
+ Error %s\n,
+ server,
+ strerror(errno) ));
return False;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-0-stable updated - release-3-0-35-52-g6a3362e
The branch, v3-0-stable has been updated via 6a3362e13bf0613e86454d4f12b2b1b486e282fa (commit) via 4cad817a8ed70df3db75a9d728414dfd7104ae1a (commit) via 7f260289490635806cd8765e66e2b61ba6c098f2 (commit) via adde5bcb0fa6a609bc2555ff4c51f837646f6b3b (commit) via 2823322c5c0883887f693b0de7dfe8873237a877 (commit) via 54e25e1fbfcb0141c866d9811da883b4f8197f43 (commit) via d4febf79859acd19647a89e589f72588598509b2 (commit) via f86dc6a0eaefbda0e83e2c25d5b553356fbf5ca8 (commit) via 4d4943a762377b57d5d15b368315c6f35fabf44f (commit) via 3df3c08071f690c8e9aca88da2eea8aed88473cd (commit) via 746dde02c829adb56ca639f5a6e4d44be9468018 (commit) via 568ef20412f4e2bf0872da5beb08fcbe1aa3fc5e (commit) via 803aa8da6d2a7f32359a090062ab468cf8d6ce32 (commit) via 09d7055c12e4a90eb74417ff37bb3359272607fd (commit) via 9fe089291df30035974b750b4da7e6fa20b9c8a5 (commit) via 3b6017fa7cae1a2cda488da0cc2dee7b08b63267 (commit) via 41f8c6547298635adf990bd4db60e498d74d9fc4 (commit) via d73ee18c15a1c1369b5a8c0ae88f6ec704d21404 (commit) via 213581c68f67800858958ca79cb6de73fa57b507 (commit) via 868ffe754db8ab59341c71b3cce2cd9600939185 (commit) via 767f2dd0eb73f616351d54ea350b8b6de97334b9 (commit) via 2a6f8e88150df48271fbe663b5702d725bcac3eb (commit) via 99ad00efd7d3d0990ec20e0f278d63cf55167d0c (commit) via b658c263e12077cde44a5cc8aa9cec0461115a95 (commit) via 453ab3457a652d273a0c69f1408eac1e031695dd (commit) via 1ee9e31a71ab7942bb2c38ce695e8ace1b4235ed (commit) via dcbeddb3fad94eea4d623c13d4eb51b86f0f6fe3 (commit) via 0be10db1016cb0a2fc2631840efd276377980798 (commit) via ba1b99243c70807a49d2e6f14d9a31a029144ff8 (commit) via 37d3a86f63b3c749a443720eaa5692a5ffb08b6c (commit) via 27c0adceb1a9fe7a2ce310f105e244ecec477921 (commit) via 335c3cdbd5d84d01d52fe4f8b823f3ecce9139f3 (commit) via 51c9822b0cffeabd6cdd6b17e96e97dccc3c6517 (commit) via 1da87f537554dc26563417d95bf5885630a336f4 (commit) via bf2432428342c6702cf9ed0d38a34d8ff4ed0a36 (commit) via a79fdce48072ae073375ac2b988e6c4f19be2dff (commit) via 80cbbb5bd696f54b3af6e61b233ec0ebaaae63c4 (commit) via fbe7ef5e77364aba41ac7e49de200103ef7cf9ec (commit) via 2208d1311ce84a1714854d1e7b11cd22b0aa9ad1 (commit) via b44feac63b819e0f67deaafd3151dfa3ff8ae1a5 (commit) via 4d8e759e8f2f7dec0c9d0b3e59720bce30f60fb1 (commit) via 9801f78c0b605f0063f0bdcd7afbac723504fd67 (commit) via f20d4922ecabd99289c5fc624a2b8982cd36f971 (commit) via 76a2c3bc1361466da5b63fa1f98b2091158768a1 (commit) via b48bc3383f8a0d02b48a71143e0a8b29183bb394 (commit) via bbf83dfc9ecf5e2f0018a9d2ba219b07563a5e27 (commit) via 1ea39aee0e340038c67b83fc777278d34deee286 (commit) via 50bac5bd91b94294cf2a7c74919cbf97d81292c7 (commit) via 48d9974adf6cff6cc75821f4f62f1b20365b9780 (commit) via 8aa2373eff1c9e3d72233e8809598d07f764cd1e (commit) via 5069cd11a1897a6e314faf7eb095a5d2e405523e (commit) via 8992deabb4977de46d049941ac3830c2bcef40e2 (commit) from 857b6fb063b9968134cc664430ff5d33a992da4a (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-stable - Log - commit 6a3362e13bf0613e86454d4f12b2b1b486e282fa Author: Karolin Seeger ksee...@samba.org Date: Mon Jun 29 12:22:08 2009 +0200 VERSION: Raise version number up to 3.0.36. Karolin (cherry picked from commit d6c81c70c45348c86433dd64297e1a659535c155) commit 4cad817a8ed70df3db75a9d728414dfd7104ae1a Author: Volker Lendecke v...@samba.org Date: Tue Jun 16 11:14:29 2009 +0200 Workaround for KB932762 (cherry picked from commit a15c816ba5fd4dcedd68beb1fcb0540de325c1cb) commit 7f260289490635806cd8765e66e2b61ba6c098f2 Author: Karolin Seeger ksee...@samba.org Date: Wed May 27 18:12:23 2009 +0200 s3/docs: Correct version number. Karolin (cherry picked from commit ccded3263ad1135cc707e24cc78d0fd95e2e88d3) commit adde5bcb0fa6a609bc2555ff4c51f837646f6b3b Author: Karolin Seeger ksee...@samba.org Date: Mon May 4 15:17:30 2009 +0200 s3/docs: Fix typo. Karolin (cherry picked from commit c2eb0d87a2436614741119ebd14fda05b42a2ddd) (cherry picked from commit 98c238a54dbe3e64262252a9fb38b382c53c1bcf) (cherry picked from commit b118a70a9fc96e8ae5e51ebc8abc9076b07fdf27) (cherry picked from commit 4d569a5bcdf7549daa5f8be7a7006c296f8a35ea) commit 2823322c5c0883887f693b0de7dfe8873237a877 Author: Karolin Seeger ksee...@samba.org Date: Sun May 3 09:55:46 2009 +0200 s3/docs: Fix typos. That fixes bug #4247. Thanks to David McNeill davemc [at] mcpond.co.nz for reporting! Karolin (cherry picked from commit
[SCM] Samba Shared Repository - branch v3-0-test updated - release-3-0-32-175-g0fd1c63
The branch, v3-0-test has been updated via 0fd1c6370f8d163edd9d3a99f00e2a6e5e322ba9 (commit) from d6c81c70c45348c86433dd64297e1a659535c155 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test - Log - commit 0fd1c6370f8d163edd9d3a99f00e2a6e5e322ba9 Author: Karolin Seeger ksee...@samba.org Date: Thu Jul 30 10:11:57 2009 +0200 WHATSNEW: Start WHATSNEW for 3.0.36. Karolin --- Summary of changes: WHATSNEW.txt | 109 -- 1 files changed, 106 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 01905e2..2ad423a 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,4 +1,109 @@ == + Release Notes for Samba 3.0.36 + August, 5 2009 + == + + +This is the latest bugfix release of the Samba 3.0 series. + +Please note, that the 3.0 series will be DISCONTINUED after this release! +There will be neither any bugfix release nor any security release. Updating +to the latest release series is strongly recommended. For more information +on current Samba releases, please see + +http://wiki.samba.org/index.php/Samba3_Release_Planning + + +Major enhancements included in Samba 3.0.36 are: + + o Fix Winbind crash on 'getent group' (bug #5906). + o Excel save operation corrupts file ACLs (bug #4308). + o Prevent segmentation fault on joining a very long domain name. + + +## +Changes +### + +Changes since 3.0.35 + + + +o Michael Adam ob...@samba.org +* BUG 5906: Fix Winbind crash on 'getent group'. +* BUG 6066: netinet/ip.h present but cannot be compiled on Solaris. + + +o Jeremy Allison j...@samba.org +* BUG 4308: Excel save operation corrupts file ACLs. +* BUG 6099: In order to allow Win7 to connect to a Samba NT style +* BUG 6279: Fix Winbind crash. + PDC we set the flags before we know if it's an error or not. +* Fix logic error in try_chown. +* Correctly use chroot(). +* Fix bug in processing of open modes in POSIX open. + + +o Günther Deschner g...@samba.org +* Don't install the cifs.upcall binary twice. + + +o Steve French smfre...@gmail.com +* BUG 4640: Fix guest mounts in mount-cifs. +* Fix mount.cifs handling of -V option. + + +o Bhaskar Jain (bhajain) bhaj...@cisco.com +* Prevent segmentation fault on joining a very long domain name. + + +o Günter Kukkukk li...@kukkukk.com +* Don't try and delete a default ACL from a file. + + +o Volker Lendecke v...@samba.org +* Add workaround for MS KB932762. + + +o Shirish Pargaonkar shirishpargaon...@gmail.com +* BUG 4370: Clean-up entries in /etc/mtab after unmount. +* Add fakemount (-f) and nomtab (-n) flags to mount.cifs. + + +o Ted Percival ted.perci...@quest.com +* Fix a crash during name resolution when log level = 10 + and libc segfaults if printf is passed NULL for a %s arg + (eg. Solaris). + + +o Miguel Suarez miguel.sua...@stratus.com +* BUG 6085: Fix build of vfs_default. + + +o Yasuma Takeda yas...@osstech.co.jp +* BUG 6098: When the DNS server is invalid, the ads_find_dc() does not work + correctly. + + +## +Reporting bugs Development Discussion +### + +As 3.0 bugs will not be fixed any longer, it does not make sense to +create bug reports for this version. If there are any issues, please +retry with the latest Samba version and file a bug report for that +version if the issue still exists. + +== +== Our Code, Our Bugs, Our Responsibility. +== The Samba Team +== + + +Release notes for older releases follow: +- + + == Release Notes for Samba 3.0.35 June, 23 2009 == @@ -43,9 +148,7 @@ database (https://bugzilla.samba.org/). == The Samba Team == - -Release notes for older releases follow: -- +-- == Release Notes for Samba 3.0.34 -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-0-stable updated - release-3-0-35-53-gc417f71
The branch, v3-0-stable has been updated via c417f71b355dc09a45c8043c5f1a424a4eb4e217 (commit) from 6a3362e13bf0613e86454d4f12b2b1b486e282fa (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-stable - Log - commit c417f71b355dc09a45c8043c5f1a424a4eb4e217 Author: Karolin Seeger ksee...@samba.org Date: Thu Jul 30 10:11:57 2009 +0200 WHATSNEW: Start WHATSNEW for 3.0.36. Karolin (cherry picked from commit 0fd1c6370f8d163edd9d3a99f00e2a6e5e322ba9) --- Summary of changes: WHATSNEW.txt | 109 -- 1 files changed, 106 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 01905e2..2ad423a 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,4 +1,109 @@ == + Release Notes for Samba 3.0.36 + August, 5 2009 + == + + +This is the latest bugfix release of the Samba 3.0 series. + +Please note, that the 3.0 series will be DISCONTINUED after this release! +There will be neither any bugfix release nor any security release. Updating +to the latest release series is strongly recommended. For more information +on current Samba releases, please see + +http://wiki.samba.org/index.php/Samba3_Release_Planning + + +Major enhancements included in Samba 3.0.36 are: + + o Fix Winbind crash on 'getent group' (bug #5906). + o Excel save operation corrupts file ACLs (bug #4308). + o Prevent segmentation fault on joining a very long domain name. + + +## +Changes +### + +Changes since 3.0.35 + + + +o Michael Adam ob...@samba.org +* BUG 5906: Fix Winbind crash on 'getent group'. +* BUG 6066: netinet/ip.h present but cannot be compiled on Solaris. + + +o Jeremy Allison j...@samba.org +* BUG 4308: Excel save operation corrupts file ACLs. +* BUG 6099: In order to allow Win7 to connect to a Samba NT style +* BUG 6279: Fix Winbind crash. + PDC we set the flags before we know if it's an error or not. +* Fix logic error in try_chown. +* Correctly use chroot(). +* Fix bug in processing of open modes in POSIX open. + + +o Günther Deschner g...@samba.org +* Don't install the cifs.upcall binary twice. + + +o Steve French smfre...@gmail.com +* BUG 4640: Fix guest mounts in mount-cifs. +* Fix mount.cifs handling of -V option. + + +o Bhaskar Jain (bhajain) bhaj...@cisco.com +* Prevent segmentation fault on joining a very long domain name. + + +o Günter Kukkukk li...@kukkukk.com +* Don't try and delete a default ACL from a file. + + +o Volker Lendecke v...@samba.org +* Add workaround for MS KB932762. + + +o Shirish Pargaonkar shirishpargaon...@gmail.com +* BUG 4370: Clean-up entries in /etc/mtab after unmount. +* Add fakemount (-f) and nomtab (-n) flags to mount.cifs. + + +o Ted Percival ted.perci...@quest.com +* Fix a crash during name resolution when log level = 10 + and libc segfaults if printf is passed NULL for a %s arg + (eg. Solaris). + + +o Miguel Suarez miguel.sua...@stratus.com +* BUG 6085: Fix build of vfs_default. + + +o Yasuma Takeda yas...@osstech.co.jp +* BUG 6098: When the DNS server is invalid, the ads_find_dc() does not work + correctly. + + +## +Reporting bugs Development Discussion +### + +As 3.0 bugs will not be fixed any longer, it does not make sense to +create bug reports for this version. If there are any issues, please +retry with the latest Samba version and file a bug report for that +version if the issue still exists. + +== +== Our Code, Our Bugs, Our Responsibility. +== The Samba Team +== + + +Release notes for older releases follow: +- + + == Release Notes for Samba 3.0.35 June, 23 2009 == @@ -43,9 +148,7 @@ database (https://bugzilla.samba.org/). == The Samba Team == - -Release notes for older releases follow: -- +-- == Release Notes for Samba 3.0.34 -- Samba Shared Repository
[SCM] SAMBA-CTDB repository - branch v3-4-ctdb updated - 61d4603fa63d537ea8dc741c7d20fd8d8979daff
The branch, v3-4-ctdb has been updated discards 3ac8fc7835b1f1335c0c5c6df215302a21567bc3 (commit) discards 1941ba51b4b528d2ed0c53f692a67ddb1ab64403 (commit) discards 7e0cdb8161a1d8d9187f8d5a5baf83002ea0bd77 (commit) discards 3b747bbc3f6eced28f4ad12a0dc489bff4336d42 (commit) discards 8d022f0e7439202cb84dd3e3666d143bb33d13c5 (commit) discards a7af2b601696edf68051e80b4aafab6d220919ce (commit) discards cfc6641b04210b3adeaa9a176f3061622d60567f (commit) discards 7e8e52e6ae1138ae7633f7fc7bcf967d8d47424c (commit) discards f5b246a6e2adf01455f681c00b76cdceb3579f1a (commit) discards 224188a5e1388d70049ecc2c30b8b26f1acb84dc (commit) discards 0f9bd4f53c26bbb93e799f275d3af7a725af3251 (commit) discards 7b531a429af4f4579c66cada693f660764bbc56f (commit) discards 089ea402f6b49b05fc3ab8f5699236b0e009a5cb (commit) discards 6d873a37931d9bcd508878d56d86c4e14f8ed2c8 (commit) discards 22c77c7c224381d53067f4fc9feeb058e46ee43a (commit) discards 28c703cac6fbd1850527de5e324deb28082242c2 (commit) discards 7f66849198d39086fbf0c6632fe5c4e7d7496df3 (commit) discards 04045dfe48527bd74d25eb7694baca9e55cd7e60 (commit) discards d6fd406056bc92641a2da3576952e71294f4ffe4 (commit) discards d78f5d205ca8ae8d0aa85bdf3eb4c1a748b35f00 (commit) discards 1844a7be04eaa31e36fbc7a2e49eba516cb20ab8 (commit) discards 49e0d351fe48b15d81ec334868ed96f5a1d6cf90 (commit) discards f3fec89beb1b7419ab5cd400cb1c6dd9d8e92392 (commit) discards 01757a2a8fb1b8b20c6e01176b9a8a8a3ecac4e5 (commit) discards b45f30c39eb7ced23eef08c72ee342b08bd15832 (commit) discards 05912bf1769553cd2428c7052736be4a6aea8f53 (commit) discards 631087534fcfe95863f44eb9785e5e1164ff9ef2 (commit) discards 1a141805e306ec240551f69e9335d5d67fb04e37 (commit) discards 46751cbb11bce6bd3490f29685c78a15560cb072 (commit) discards f11a2d4586abb8f1e93e60ddb3f37cc3b81d (commit) discards d1bd3c2cd1c14f23ddf11571b7154fb2ef012b1e (commit) discards 3a08e589cce587e631a43c2b50356e61a1974a73 (commit) discards 19a656bf6f8678495ef8d29eef852e4523a4d9e5 (commit) discards a8f7a08658c78e287d6eb62d9741288f771d3d73 (commit) discards 10e3748d62d1ff4f4783cd652e23d074f45e914c (commit) discards ca2c65b3b584bd8122d23747b241dc205806a96d (commit) discards 68959548a900fbfc070d9e30163cf372a640d2d1 (commit) discards 3aa1c9d476a148e7db55b698df6c38db6bd4a4c9 (commit) discards 901c609148bdfd5d793be2793c7198d983bc843b (commit) discards 9143e5bbe0751cee964523ad65b33ac1cf005aed (commit) discards ec3ee8d4511f304217d980fa9590ccae907d6731 (commit) discards d7f97d0baa243e09963d4201f5bbee85cd477f2a (commit) discards c0688cd8bddd4b2e3360f337bc11efaa428f5d9f (commit) discards b7e4a36e1e65d4383994702823a2d2549944f8d0 (commit) discards 5b93068bc629fe4f7429482cc0b96bb0e23e4b1f (commit) discards 10ccf32db7ef02e93ca47f754cecdd4409533654 (commit) discards c57298c7432922bf755643a1cd97195ebfe9b313 (commit) via 61d4603fa63d537ea8dc741c7d20fd8d8979daff (commit) via 8120aae051110261803feeab65499e1b23a9f08d (commit) via 759b728adc67e8b8ca38f72ea8f2ff2375e3b7d7 (commit) via 52208accc6fd120165ddb7f074fa02df27c3d74b (commit) via 42f1945d79a7741169a25eedbc423c2058b94586 (commit) via 1a08cdf9fba23efe1ea63d590571687d17cf156b (commit) via 4cb4a00c0fb3ece75a4468924110261b16f17bfb (commit) via 576ca4a63bc1b77d4a68e4387c914cde0fb4ec65 (commit) via 983901f109bcd88590e8f2349f40ff83075727df (commit) via 204402797ed255925867a153908e48168afae866 (commit) via c711710817bf3b15dd8ebe3363639691c25da026 (commit) via 98b857231ccf4ca703a96585c66ac6b77ee25010 (commit) via 317b0e0a2b2d43f58bb403d50d7a118dc4ceaf5b (commit) via fade5e05af76f6239a9d2a7bad13b28098af7fc9 (commit) via 35ea0b0aea66f8428232993299666aadcec33c17 (commit) via 7eabfa6caed85dbdea27ac176995ba65630d21fa (commit) via da1696b3295ccdafcb7f4e09748b2aa50bbda280 (commit) via fef23a107fc26e9d409254f7d435116165289928 (commit) via 59d64dbbc1204a7e5fab045f964673fccb537db9 (commit) via c2d0989ae9df6db09baf4703e9d5c490a9a1011e (commit) via e8601a7d941820648d40bc63398f8701020f7b17 (commit) via 7be4bdc4b1db87b90c63453959d7cba775c270cf (commit) via 41c5e6a548ae4a39a610afc048abbd775f3bbf54 (commit) via 3a5e2fb152627ec545b167e9775e1b6bf10762a0 (commit) via 67d0ac684b2b9eec249981102a1e460f462c12ae (commit) via 6dfaa943317cba71d49e3084e2c86b8dd67a0128 (commit) via f8ec6de00d645a0a879713e69020f8401d53082e (commit) via 5331f3f3bec0c4e1d576af56c1d75586f2ccf239 (commit) via 041e9179c1f02fc2f927f6e9297eeb6679552cb3 (commit) via 9af023f6480478cbab248495a749edccc6b18219 (commit) via bac45d947dc439c55f66d0b2223710bc10894b22 (commit) via 6d5a0a2d082b03844dc5b09dc0fbf14230931068 (commit) via 3fd9b3228775953cac28c53f4b9e640cb159de41 (commit)
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-687-gc9803ee
The branch, master has been updated via c9803ee26ad1b2f92f2ce7653ce16ac84d0b3eb6 (commit) via 2f7108bcaed0cdcd3c8f4663267f84e256736495 (commit) via a9a52f3b62d6bf6d87840232fcbb8cdcf5d8b3c4 (commit) via 3af57c66b35a13b94fe090ea3f46f2f2ad22b077 (commit) via 346c5cca441a7bbc68250e08e7960df37faf2ddf (commit) via 35806ebe67d4ca7759bfd1ea69eddc44d6d4fde1 (commit) via a7f6c839bafeb8c163cec1c8b73603637621faa7 (commit) via cb55ec6dcbc09d6f1850846a3cf6f2f4190a0b9b (commit) via 8e43ea647bf2514baec9ab7f726a3201ac4226d3 (commit) via 137a4015f04ea172c2610c9f5c9dd8295e1e4e0f (commit) via 3a7b04361e594a0a35229a7762d30daa3d4264bb (commit) via bdb23c73d90c9a218fa39af114b900f1d8dd2c51 (commit) via 51f9d1ecd53f490f2a7383a7e1931ce6d9933e21 (commit) from 6e044a22cf232798efbd40a2b55fd9556483d403 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit c9803ee26ad1b2f92f2ce7653ce16ac84d0b3eb6 Author: Kai Blin k...@samba.org Date: Thu Jul 30 12:18:36 2009 +0200 s3 po: Regenerate msg files. commit 2f7108bcaed0cdcd3c8f4663267f84e256736495 Author: Kai Blin k...@samba.org Date: Thu Jul 30 12:17:46 2009 +0200 s3 net: i18n support for net lua commit a9a52f3b62d6bf6d87840232fcbb8cdcf5d8b3c4 Author: Kai Blin k...@samba.org Date: Thu Jul 30 12:10:56 2009 +0200 s3 net: i18n support for net lookup commit 3af57c66b35a13b94fe090ea3f46f2f2ad22b077 Author: Kai Blin k...@samba.org Date: Thu Jul 30 12:07:31 2009 +0200 s3 net: i18n for net join commit 346c5cca441a7bbc68250e08e7960df37faf2ddf Author: Kai Blin k...@samba.org Date: Thu Jul 30 12:04:53 2009 +0200 s3 net: i18n support for net idmap commit 35806ebe67d4ca7759bfd1ea69eddc44d6d4fde1 Author: Kai Blin k...@samba.org Date: Thu Jul 30 11:53:59 2009 +0200 s3 po: Make adding translated files less tedious commit a7f6c839bafeb8c163cec1c8b73603637621faa7 Author: Kai Blin k...@samba.org Date: Thu Jul 30 11:30:33 2009 +0200 s3 net: i18n support for net help commit cb55ec6dcbc09d6f1850846a3cf6f2f4190a0b9b Author: Kai Blin k...@samba.org Date: Thu Jul 30 11:25:37 2009 +0200 s3 net: Remove uid==0 check from net groupmap commit 8e43ea647bf2514baec9ab7f726a3201ac4226d3 Author: Kai Blin k...@samba.org Date: Thu Jul 30 11:16:32 2009 +0200 s3 net: i18n support for net group and net groupmap commit 137a4015f04ea172c2610c9f5c9dd8295e1e4e0f Author: Kai Blin k...@samba.org Date: Thu Jul 30 09:35:42 2009 +0200 s3 net: i18n support for net file commit 3a7b04361e594a0a35229a7762d30daa3d4264bb Author: Kai Blin k...@samba.org Date: Thu Jul 30 09:14:45 2009 +0200 s3 net: i18n for net eventlog commit bdb23c73d90c9a218fa39af114b900f1d8dd2c51 Author: Kai Blin k...@samba.org Date: Thu Jul 30 09:10:03 2009 +0200 s3 net: i18n support for net dom commit 51f9d1ecd53f490f2a7383a7e1931ce6d9933e21 Author: Kai Blin k...@samba.org Date: Thu Jul 30 09:00:31 2009 +0200 s3 net: i18n support for net conf --- Summary of changes: source3/po/de.msg | 1385 ++- source3/po/en.msg | 1377 ++- source3/po/fr.msg | 1385 ++- source3/po/genmsg | 19 +- source3/po/it.msg | 1385 ++- source3/po/ja.msg | 1385 ++- source3/po/pl.msg | 1385 ++- source3/po/ru.msg | 1385 ++- source3/po/tr.msg | 1385 ++- source3/utils/net_conf.c| 243 source3/utils/net_dom.c | 64 +- source3/utils/net_eventlog.c| 56 +- source3/utils/net_file.c| 18 +- source3/utils/net_group.c | 36 +- source3/utils/net_groupmap.c| 280 + source3/utils/net_help.c|4 +- source3/utils/net_help_common.c | 43 +- source3/utils/net_idmap.c | 143 +++-- source3/utils/net_join.c| 14 +- source3/utils/net_lookup.c | 24 +- source3/utils/net_lua.c | 28 +- 21 files changed, 11578 insertions(+), 466 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/po/de.msg b/source3/po/de.msg index 28a5f0e..8c51cc0 100644 --- a/source3/po/de.msg +++ b/source3/po/de.msg @@ -19,7 +19,7 @@ msgid msgstr Project-Id-Version: swat\n Report-Msgid-Bugs-To: \n -POT-Creation-Date: 2009-07-29 23:59+0200\n +POT-Creation-Date: 2009-07-30 12:18+0200\n PO-Revision-Date: 2007-06-10 11:52+0200\n Last-Translator: Helge Kreutzmann deb...@helgefjell.de\n Language-Team: German
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-688-geda7f35
The branch, master has been updated via eda7f35bc891ca4a7505ec054a2b4591c6edfb38 (commit) from c9803ee26ad1b2f92f2ce7653ce16ac84d0b3eb6 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit eda7f35bc891ca4a7505ec054a2b4591c6edfb38 Author: Jelmer Vernooij jel...@samba.org Date: Thu Jul 30 12:29:21 2009 +0200 Remove RFC's from the release tarballs to make the lives of the Debian maintainers of Samba4 a bit easier. --- Summary of changes: source4/script/mkrelease.sh |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/script/mkrelease.sh b/source4/script/mkrelease.sh index 303dfe6..69ddaa2 100755 --- a/source4/script/mkrelease.sh +++ b/source4/script/mkrelease.sh @@ -11,6 +11,9 @@ OUTDIR=`mktemp -d samba-X` echo SAMBA_VERSION_IS_GIT_SNAPSHOT=no $OUTDIR/source4/VERSION +rm -f $OUTDIR/source4/ldap_server/devdocs/rfc.txt \ + $OUTDIR/source4/heimdal/lib/wind/rfc.txt + #Prepare the tarball for a Samba4 release, with some generated files, #but without Samba3 stuff (to avoid confusion) ( cd $OUTDIR/ || exit 1 -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-689-g6768cfe
The branch, master has been updated
via 6768cfe624fffef13109989e9cc79ccb4df13d19 (commit)
from eda7f35bc891ca4a7505ec054a2b4591c6edfb38 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 6768cfe624fffef13109989e9cc79ccb4df13d19
Author: Jelmer Vernooij jel...@samba.org
Date: Thu Jul 30 20:04:42 2009 +0200
DCE/RPC(Python): Rename py_talloc_import to py_talloc_steal.
Use py_talloc_reference in DCE/RPC code, fixes
access to SAMR pipe.
---
Summary of changes:
lib/talloc/pytalloc.c |6 +++---
lib/talloc/pytalloc.h |9 +
pidl/lib/Parse/Pidl/Samba4/Python.pm |2 +-
source4/lib/registry/pyregistry.c | 14 +++---
source4/librpc/ndr/py_security.c |8
source4/scripting/python/examples/samr.py |2 +-
6 files changed, 21 insertions(+), 20 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/talloc/pytalloc.c b/lib/talloc/pytalloc.c
index 3ce49d6..646aac8 100644
--- a/lib/talloc/pytalloc.c
+++ b/lib/talloc/pytalloc.c
@@ -35,7 +35,7 @@ void py_talloc_dealloc(PyObject* self)
/**
* Import an existing talloc pointer into a Python object.
*/
-PyObject *py_talloc_import_ex(PyTypeObject *py_type, TALLOC_CTX *mem_ctx,
+PyObject *py_talloc_steal_ex(PyTypeObject *py_type, TALLOC_CTX *mem_ctx,
void *ptr)
{
py_talloc_Object *ret = (py_talloc_Object *)py_type-tp_alloc(py_type,
0);
@@ -56,14 +56,14 @@ PyObject *py_talloc_import_ex(PyTypeObject *py_type,
TALLOC_CTX *mem_ctx,
* original parent, and creating a reference to the object in the python
* object
*/
-PyObject *py_talloc_reference(PyTypeObject *py_type, void *ptr)
+PyObject *py_talloc_reference_ex(PyTypeObject *py_type, TALLOC_CTX *mem_ctx,
void *ptr)
{
py_talloc_Object *ret = (py_talloc_Object *)py_type-tp_alloc(py_type,
0);
ret-talloc_ctx = talloc_new(NULL);
if (ret-talloc_ctx == NULL) {
return NULL;
}
- if (talloc_reference(ret-talloc_ctx, ptr) == NULL) {
+ if (talloc_reference(ret-talloc_ctx, mem_ctx) == NULL) {
return NULL;
}
ret-ptr = ptr;
diff --git a/lib/talloc/pytalloc.h b/lib/talloc/pytalloc.h
index 00282c4..3bfb272 100644
--- a/lib/talloc/pytalloc.h
+++ b/lib/talloc/pytalloc.h
@@ -42,13 +42,14 @@ void py_talloc_dealloc(PyObject* self);
#define py_talloc_get_ptr(py_obj) (((py_talloc_Object *)py_obj)-ptr)
#define py_talloc_get_mem_ctx(py_obj) ((py_talloc_Object *)py_obj)-talloc_ctx
-PyObject *py_talloc_import_ex(PyTypeObject *py_type, TALLOC_CTX *mem_ctx, void
*ptr);
-PyObject *py_talloc_reference(PyTypeObject *py_type, void *ptr);
-#define py_talloc_import(py_type, talloc_ptr) py_talloc_import_ex(py_type,
talloc_ptr, talloc_ptr)
+PyObject *py_talloc_steal_ex(PyTypeObject *py_type, TALLOC_CTX *mem_ctx, void
*ptr);
+PyObject *py_talloc_reference_ex(PyTypeObject *py_type, TALLOC_CTX *mem_ctx,
void *ptr);
+#define py_talloc_steal(py_type, talloc_ptr) py_talloc_steal_ex(py_type,
talloc_ptr, talloc_ptr)
+#define py_talloc_reference(py_type, talloc_ptr)
py_talloc_reference_ex(py_type, talloc_ptr, talloc_ptr)
/* Sane default implementation of reprfunc. */
PyObject *py_talloc_default_repr(PyObject *py_obj);
-#define py_talloc_new(type, typeobj) py_talloc_import(typeobj,
talloc_zero(NULL, type))
+#define py_talloc_new(type, typeobj) py_talloc_steal(typeobj,
talloc_zero(NULL, type))
#endif /* _PY_TALLOC_H_ */
diff --git a/pidl/lib/Parse/Pidl/Samba4/Python.pm
b/pidl/lib/Parse/Pidl/Samba4/Python.pm
index d27192d..462f833 100644
--- a/pidl/lib/Parse/Pidl/Samba4/Python.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/Python.pm
@@ -1030,7 +1030,7 @@ sub ConvertObjectToPythonData($;$)
error($location, Unable to determine origin of type `
. mapTypeName($ctype) . ');
return NULL; # FIXME!
}
- return py_talloc_import_ex($ctype_name, $mem_ctx, $cvar);
+ return py_talloc_reference_ex($ctype_name, $mem_ctx, $cvar);
}
fatal($location, unknown type $actual_ctype-{TYPE} for
.mapTypeName($ctype) . : $cvar);
diff --git a/source4/lib/registry/pyregistry.c
b/source4/lib/registry/pyregistry.c
index 30becbb..f68bfd1 100644
--- a/source4/lib/registry/pyregistry.c
+++ b/source4/lib/registry/pyregistry.c
@@ -53,7 +53,7 @@ static PyObject *py_get_predefined_key_by_name(PyObject
*self, PyObject *args)
result = reg_get_predefined_key_by_name(ctx, name, key);
PyErr_WERROR_IS_ERR_RAISE(result);
- return py_talloc_import(PyRegistryKey, key);
+ return py_talloc_steal(PyRegistryKey, key);
}
static PyObject
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-690-g8eff9f9
The branch, master has been updated
via 8eff9f9a3167eb0c2a4c00edf5a4cdbbc06c4dfd (commit)
from 6768cfe624fffef13109989e9cc79ccb4df13d19 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 8eff9f9a3167eb0c2a4c00edf5a4cdbbc06c4dfd
Author: Jelmer Vernooij jel...@samba.org
Date: Thu Jul 30 20:28:29 2009 +0200
python: Cope with the dom_sid2 alias in pidl's python generating code.
This fixes some problems in the samr Python bindings that pidl was
(correctly) warning about.
---
Summary of changes:
pidl/lib/Parse/Pidl/Samba4/Python.pm |8 ++--
source4/scripting/python/examples/samr.py |4 ++--
2 files changed, 8 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/pidl/lib/Parse/Pidl/Samba4/Python.pm
b/pidl/lib/Parse/Pidl/Samba4/Python.pm
index 462f833..78a4ebd 100644
--- a/pidl/lib/Parse/Pidl/Samba4/Python.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/Python.pm
@@ -766,6 +766,11 @@ sub register_module_import($$)
sub use_type_variable($$)
{
my ($self, $orig_ctype) = @_;
+ # FIXME: Have a global lookup table for types that look different on
the
+ # wire than they are named in C?
+ if ($orig_ctype-{NAME} eq dom_sid2) {
+ $orig_ctype-{NAME} = dom_sid;
+ }
my $ctype = resolveType($orig_ctype);
unless (defined($ctype-{BASEFILE})) {
return undef;
@@ -840,8 +845,7 @@ sub ConvertObjectFromPythonData($$;$)
my $ctype_name = $self-use_type_variable($ctype);
unless (defined ($ctype_name)) {
error($location, Unable to determine origin of type `
. mapTypeName($ctype) . ');
- $self-assign($target, NULL);
- # FIXME:
+ $self-pidl(PyErr_SetString(PyExc_TypeError, \Can not
convert C Type . mapType($ctype) . to Python\););
return;
}
$self-pidl(PY_CHECK_TYPE($ctype_name, $cvar, $fail););
diff --git a/source4/scripting/python/examples/samr.py
b/source4/scripting/python/examples/samr.py
index 17ac354..c0e3167 100755
--- a/source4/scripting/python/examples/samr.py
+++ b/source4/scripting/python/examples/samr.py
@@ -67,7 +67,7 @@ def test_EnumDomainUsers(samr, dom_handle):
users = toArray(samr.EnumDomainUsers(dom_handle, 0, 0, -1))
print Found %d users % len(users)
for idx, user in users:
-print \t%s\t(%d) % (user, idx)
+print \t%s\t(%d) % (user.string, idx)
def test_EnumDomainGroups(samr, dom_handle):
test the samr_EnumDomainGroups interface
@@ -75,7 +75,7 @@ def test_EnumDomainGroups(samr, dom_handle):
groups = toArray(samr.EnumDomainGroups(dom_handle, 0, 0))
print Found %d groups % len(groups)
for idx, group in groups:
-print \t%s\t(%d) % (group, idx)
+print \t%s\t(%d) % (group.string, idx)
def test_domain_ops(samr, dom_handle):
test domain specific ops
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-692-g36c0f0f
The branch, master has been updated
via 36c0f0f99aee940668b84c2c70b27f4993d9e6ee (commit)
via a88c281ddc52bfb20cf65245a703233426bb4592 (commit)
from 8eff9f9a3167eb0c2a4c00edf5a4cdbbc06c4dfd (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 36c0f0f99aee940668b84c2c70b27f4993d9e6ee
Author: Rusty Russell ru...@rustcorp.com.au
Date: Thu Jul 30 13:10:33 2009 -0700
realloc() has that horrible overloaded free semantic when size is 0:
current code does a free of the old record in this case, then fail.
commit a88c281ddc52bfb20cf65245a703233426bb4592
Author: Rusty Russell ru...@rustcorp.com.au
Date: Thu Jul 30 13:09:33 2009 -0700
If the record is at the end of the database, pretending it has length 1
might take us out-of-bounds. Only pretend to be length 1 for the malloc.
---
Summary of changes:
lib/tdb/common/io.c |5 +
lib/tdb/common/tdb.c |9 +++--
2 files changed, 8 insertions(+), 6 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/tdb/common/io.c b/lib/tdb/common/io.c
index 661f761..a0b3a3f 100644
--- a/lib/tdb/common/io.c
+++ b/lib/tdb/common/io.c
@@ -383,11 +383,8 @@ unsigned char *tdb_alloc_read(struct tdb_context *tdb,
tdb_off_t offset, tdb_len
unsigned char *buf;
/* some systems don't like zero length malloc */
- if (len == 0) {
- len = 1;
- }
- if (!(buf = (unsigned char *)malloc(len))) {
+ if (!(buf = (unsigned char *)malloc(len ? len : 1))) {
/* Ensure ecode is set for log fn. */
tdb-ecode = TDB_ERR_OOM;
TDB_LOG((tdb, TDB_DEBUG_ERROR,tdb_alloc_read malloc failed
len=%d (%s)\n,
diff --git a/lib/tdb/common/tdb.c b/lib/tdb/common/tdb.c
index b59bb15..b78f74c 100644
--- a/lib/tdb/common/tdb.c
+++ b/lib/tdb/common/tdb.c
@@ -584,8 +584,13 @@ int tdb_append(struct tdb_context *tdb, TDB_DATA key,
TDB_DATA new_dbuf)
if (dbuf.dptr == NULL) {
dbuf.dptr = (unsigned char *)malloc(new_dbuf.dsize);
} else {
- unsigned char *new_dptr = (unsigned char *)realloc(dbuf.dptr,
-dbuf.dsize +
new_dbuf.dsize);
+ unsigned int new_len = dbuf.dsize + new_dbuf.dsize;
+ unsigned char *new_dptr;
+
+ /* realloc '0' is special: don't do that. */
+ if (new_len == 0)
+ new_len = 1;
+ new_dptr = (unsigned char *)realloc(dbuf.dptr, new_len);
if (new_dptr == NULL) {
free(dbuf.dptr);
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-695-g6516543
The branch, master has been updated
via 65165433ecb95a697442fd88723036605ea21186 (commit)
via 84bfd7395c48783fd6fca19effa12561217f65ec (commit)
via e411ec6a8af13ff9213b27212a4bed2db651585d (commit)
from 36c0f0f99aee940668b84c2c70b27f4993d9e6ee (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 65165433ecb95a697442fd88723036605ea21186
Author: Jeremy Allison j...@samba.org
Date: Thu Jul 30 13:19:26 2009 -0700
Fix bug #6529 - Offline files conflict with Vista and Office 2003.
We need to send a notify message when a timestamp is changed that
can't be reflected in the underlying POSIX filesystem.
Jeremy.
commit 84bfd7395c48783fd6fca19effa12561217f65ec
Author: Jeremy Allison j...@samba.org
Date: Thu Jul 30 13:16:40 2009 -0700
Remove the extraneous logic in smb_set_info_standard - we
do the time twiddling logic at the smb_set_file_time level.
Jeremy.
commit e411ec6a8af13ff9213b27212a4bed2db651585d
Author: Jeremy Allison j...@samba.org
Date: Thu Jul 30 13:13:23 2009 -0700
SMB_INFO_STANDARD is not a valid info level on set,
and was being read incorrectly anyway. Remove.
Jeremy.
---
Summary of changes:
source3/include/smb.h |1 +
source3/smbd/trans2.c | 92 +
2 files changed, 25 insertions(+), 68 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/include/smb.h b/source3/include/smb.h
index 1192744..819d3a8 100644
--- a/source3/include/smb.h
+++ b/source3/include/smb.h
@@ -1895,6 +1895,7 @@ struct smb_extended_info {
struct smb_file_time {
struct timespec mtime;
struct timespec atime;
+ struct timespec ctime;
struct timespec create_time;
};
diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index f34e15b..8cbd259 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -5194,6 +5194,8 @@ NTSTATUS smb_set_file_time(connection_struct *conn,
uint32 action =
FILE_NOTIFY_CHANGE_LAST_ACCESS
|FILE_NOTIFY_CHANGE_LAST_WRITE;
+ bool set_createtime = false;
+ bool set_ctime = false;
NTSTATUS status;
if (!VALID_STAT(smb_fname-st)) {
@@ -5201,6 +5203,16 @@ NTSTATUS smb_set_file_time(connection_struct *conn,
}
/* get some defaults (no modifications) if any info is zero or -1. */
+ if (null_timespec(ft-create_time)) {
+ ft-create_time = smb_fname-st.st_ex_btime;
+ } else {
+ set_createtime = true;
+ }
+
+ if (!null_timespec(ft-ctime)) {
+ set_ctime = true;
+ }
+
if (null_timespec(ft-atime)) {
ft-atime= smb_fname-st.st_ex_atime;
action = ~FILE_NOTIFY_CHANGE_LAST_ACCESS;
@@ -5235,6 +5247,10 @@ NTSTATUS smb_set_file_time(connection_struct *conn,
struct timespec ats = smb_fname-st.st_ex_atime;
if ((timespec_compare(ft-atime, ats) == 0)
(timespec_compare(ft-mtime, mts) == 0)) {
+ if (set_createtime || set_ctime) {
+ notify_fname(conn, NOTIFY_ACTION_MODIFIED,
action,
+ smb_fname-base_name);
+ }
return NT_STATUS_OK;
}
}
@@ -6045,38 +6061,6 @@ static NTSTATUS smb_set_posix_lock(connection_struct
*conn,
}
/
- Deal with SMB_INFO_STANDARD.
-/
-
-static NTSTATUS smb_set_info_standard(connection_struct *conn,
- const char *pdata,
- int total_data,
- files_struct *fsp,
- const struct smb_filename *smb_fname)
-{
- struct smb_file_time ft;
- ZERO_STRUCT(ft);
-
- if (total_data 12) {
- return NT_STATUS_INVALID_PARAMETER;
- }
-
- /* create time */
- ft.create_time = interpret_long_date(pdata);
-
- /* access time */
- ft.atime = interpret_long_date(pdata + 8);
-
- /* write time */
- ft.mtime = interpret_long_date(pdata + 16);
-
- DEBUG(10,(smb_set_info_standard: file %s\n,
- smb_fname_str_dbg(smb_fname)));
-
- return smb_set_file_time(conn, fsp, smb_fname, ft, true);
-}
-
-/
Deal with SMB_SET_FILE_BASIC_INFO.
/
@@ -6087,12 +6071,9 @@ static NTSTATUS
smb_set_file_basic_info(connection_struct *conn,
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-696-gfc4e21b
The branch, master has been updated
via fc4e21bdae298095e7ab904fdec657f97743bfe7 (commit)
from 65165433ecb95a697442fd88723036605ea21186 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit fc4e21bdae298095e7ab904fdec657f97743bfe7
Author: Jeremy Allison j...@samba.org
Date: Thu Jul 30 14:27:32 2009 -0700
Tidy up treatment of ctime.
Jeremy.
---
Summary of changes:
source3/smbd/dosmode.c |2 ++
source3/smbd/trans2.c | 12 +++-
2 files changed, 9 insertions(+), 5 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c
index bd0c7df..535532d 100644
--- a/source3/smbd/dosmode.c
+++ b/source3/smbd/dosmode.c
@@ -760,6 +760,8 @@ int file_ntimes(connection_struct *conn, const struct
smb_filename *smb_fname,
time_to_asc(convert_timespec_to_time_t(ft-atime;
DEBUG(6, (file_ntime: modtime: %s,
time_to_asc(convert_timespec_to_time_t(ft-mtime;
+ DEBUG(6, (file_ntime: ctime: %s,
+ time_to_asc(convert_timespec_to_time_t(ft-ctime;
DEBUG(6, (file_ntime: createtime: %s,
time_to_asc(convert_timespec_to_time_t(ft-create_time;
diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index 8cbd259..0daaf7c 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -5209,7 +5209,9 @@ NTSTATUS smb_set_file_time(connection_struct *conn,
set_createtime = true;
}
- if (!null_timespec(ft-ctime)) {
+ if (null_timespec(ft-ctime)) {
+ ft-ctime = smb_fname-st.st_ex_ctime;
+ } else {
set_ctime = true;
}
@@ -5232,10 +5234,10 @@ NTSTATUS smb_set_file_time(connection_struct *conn,
time_to_asc(convert_timespec_to_time_t(ft-atime;
DEBUG(5,(smb_set_filetime: modtime: %s\n ,
time_to_asc(convert_timespec_to_time_t(ft-mtime;
- if (!null_timespec(ft-create_time)) {
- DEBUG(5,(smb_set_file_time: createtime: %s\n ,
- time_to_asc(convert_timespec_to_time_t(ft-create_time;
- }
+ DEBUG(5,(smb_set_filetime: ctime: %s\n ,
+ time_to_asc(convert_timespec_to_time_t(ft-ctime;
+ DEBUG(5,(smb_set_file_time: createtime: %s\n ,
+ time_to_asc(convert_timespec_to_time_t(ft-create_time;
/*
* Try and set the times of this file if
--
Samba Shared Repository
