Build status as of Tue Sep 1 06:00:01 2009
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2009-08-31 00:00:03.0 -0600 +++ /home/build/master/cache/broken_results.txt 2009-09-01 00:00:03.0 -0600 @@ -1,22 +1,22 @@ -Build status as of Mon Aug 31 06:00:02 2009 +Build status as of Tue Sep 1 06:00:01 2009 Build counts: Tree Total Broken Panic build_farm 0 0 0 ccache 2 1 0 distcc 0 0 0 -ldb 25 25 0 -libreplace 1 1 0 +ldb 26 26 0 +libreplace 2 1 0 lorikeet 0 0 0 -pidl 2 2 0 -ppp 1 0 0 -rsync24 11 0 +pidl 1 1 0 +ppp 0 0 0 +rsync26 11 0 samba-docs 0 0 0 samba-web0 0 0 -samba_3_current 22 21 0 -samba_3_master 23 23 1 -samba_3_next 22 22 1 -samba_4_0_test 25 25 4 -talloc 24 24 0 -tdb 23 23 0 +samba_3_current 23 22 0 +samba_3_master 24 23 2 +samba_3_next 24 23 0 +samba_4_0_test 26 26 3 +talloc 26 26 0 +tdb 24 24 0
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-1318-g792b544
The branch, master has been updated
via 792b544e3704c792d969ebe55b950919283df5b1 (commit)
from 94f7c98430372cc3213f56cd1e085e60837c7196 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 792b544e3704c792d969ebe55b950919283df5b1
Author: Günther Deschner
Date: Mon Aug 31 17:12:07 2009 +0200
netlogon: fill in more details for the netr_LogonControlX family of calls.
Guenther
---
Summary of changes:
librpc/gen_ndr/ndr_netlogon.c | 49 ++--
librpc/gen_ndr/netlogon.h | 11 ++--
librpc/idl/netlogon.idl | 13 --
3 files changed, 50 insertions(+), 23 deletions(-)
Changeset truncated at 500 lines:
diff --git a/librpc/gen_ndr/ndr_netlogon.c b/librpc/gen_ndr/ndr_netlogon.c
index 81fc9ac..46247b4 100644
--- a/librpc/gen_ndr/ndr_netlogon.c
+++ b/librpc/gen_ndr/ndr_netlogon.c
@@ -5611,9 +5611,14 @@ _PUBLIC_ void ndr_print_netr_InfoFlags(struct ndr_print
*ndr, const char *name,
{
ndr_print_uint32(ndr, name, r);
ndr->depth++;
- ndr_print_bitmap_flag(ndr, sizeof(uint32_t),
"NETLOGON_CTRL_REPL_NEEDED", NETLOGON_CTRL_REPL_NEEDED, r);
- ndr_print_bitmap_flag(ndr, sizeof(uint32_t),
"NETLOGON_CTRL_REPL_IN_PROGRESS", NETLOGON_CTRL_REPL_IN_PROGRESS, r);
- ndr_print_bitmap_flag(ndr, sizeof(uint32_t),
"NETLOGON_CTRL_REPL_FULL_SYNC", NETLOGON_CTRL_REPL_FULL_SYNC, r);
+ ndr_print_bitmap_flag(ndr, sizeof(uint32_t),
"NETLOGON_REPLICATION_NEEDED", NETLOGON_REPLICATION_NEEDED, r);
+ ndr_print_bitmap_flag(ndr, sizeof(uint32_t),
"NETLOGON_REPLICATION_IN_PROGRESS", NETLOGON_REPLICATION_IN_PROGRESS, r);
+ ndr_print_bitmap_flag(ndr, sizeof(uint32_t),
"NETLOGON_FULL_SYNC_REPLICATION", NETLOGON_FULL_SYNC_REPLICATION, r);
+ ndr_print_bitmap_flag(ndr, sizeof(uint32_t), "NETLOGON_REDO_NEEDED",
NETLOGON_REDO_NEEDED, r);
+ ndr_print_bitmap_flag(ndr, sizeof(uint32_t), "NETLOGON_HAS_IP",
NETLOGON_HAS_IP, r);
+ ndr_print_bitmap_flag(ndr, sizeof(uint32_t), "NETLOGON_HAS_TIMESERV",
NETLOGON_HAS_TIMESERV, r);
+ ndr_print_bitmap_flag(ndr, sizeof(uint32_t),
"NETLOGON_DNS_UPDATE_FAILURE", NETLOGON_DNS_UPDATE_FAILURE, r);
+ ndr_print_bitmap_flag(ndr, sizeof(uint32_t),
"NETLOGON_VERIFY_STATUS_RETURNED", NETLOGON_VERIFY_STATUS_RETURNED, r);
ndr->depth--;
}
@@ -5882,8 +5887,9 @@ static enum ndr_err_code
ndr_push_netr_CONTROL_QUERY_INFORMATION(struct ndr_push
NDR_CHECK(ndr_push_unique_ptr(ndr, r->info4));
break; }
- default:
- return ndr_push_error(ndr, NDR_ERR_BAD_SWITCH,
"Bad switch value %u at %s", level, __location__);
+ default: {
+ break; }
+
}
}
if (ndr_flags & NDR_BUFFERS) {
@@ -5914,7 +5920,8 @@ static enum ndr_err_code
ndr_push_netr_CONTROL_QUERY_INFORMATION(struct ndr_push
break;
default:
- return ndr_push_error(ndr, NDR_ERR_BAD_SWITCH,
"Bad switch value %u at %s", level, __location__);
+ break;
+
}
}
return NDR_ERR_SUCCESS;
@@ -5975,8 +5982,9 @@ static enum ndr_err_code
ndr_pull_netr_CONTROL_QUERY_INFORMATION(struct ndr_pull
}
break; }
- default:
- return ndr_pull_error(ndr, NDR_ERR_BAD_SWITCH,
"Bad switch value %u at %s", level, __location__);
+ default: {
+ break; }
+
}
}
if (ndr_flags & NDR_BUFFERS) {
@@ -6018,7 +6026,8 @@ static enum ndr_err_code
ndr_pull_netr_CONTROL_QUERY_INFORMATION(struct ndr_pull
break;
default:
- return ndr_pull_error(ndr, NDR_ERR_BAD_SWITCH,
"Bad switch value %u at %s", level, __location__);
+ break;
+
}
}
return NDR_ERR_SUCCESS;
@@ -6067,7 +6076,8 @@ _PUBLIC_ void
ndr_print_netr_CONTROL_QUERY_INFORMATION(struct ndr_print *ndr, co
break;
default:
- ndr_print_bad_level(ndr, name, level);
+ break;
+
}
}
@@ -6144,8 +6154,9 @@ static enum ndr_err_code
ndr_push_netr_CONTROL_DATA_INFORMATION(struct ndr_push
NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS,
r->debug_level));
break; }
- default:
- return ndr_push_error(ndr, NDR_ERR_BAD_SWITCH,
"Bad switch value %u at %s", level, __location__);
+ default: {
+
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-1317-g94f7c98
The branch, master has been updated
via 94f7c98430372cc3213f56cd1e085e60837c7196 (commit)
from a3e9b62f440340f075859e080086daec88e226f5 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 94f7c98430372cc3213f56cd1e085e60837c7196
Author: Günther Deschner
Date: Mon Aug 31 17:12:34 2009 +0200
s3-netlogon: add DS_WEB_SERVICE_REQUIRED bit for dsgetdcname calls.
Guenther
---
Summary of changes:
librpc/gen_ndr/ndr_netlogon.c |1 +
librpc/gen_ndr/netlogon.h |1 +
librpc/idl/netlogon.idl |1 +
3 files changed, 3 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/librpc/gen_ndr/ndr_netlogon.c b/librpc/gen_ndr/ndr_netlogon.c
index 95964ca..81fc9ac 100644
--- a/librpc/gen_ndr/ndr_netlogon.c
+++ b/librpc/gen_ndr/ndr_netlogon.c
@@ -6825,6 +6825,7 @@ _PUBLIC_ void ndr_print_netr_DsRGetDCName_flags(struct
ndr_print *ndr, const cha
ndr_print_bitmap_flag(ndr, sizeof(uint32_t), "DS_IS_DNS_NAME",
DS_IS_DNS_NAME, r);
ndr_print_bitmap_flag(ndr, sizeof(uint32_t), "DS_TRY_NEXTCLOSEST_SITE",
DS_TRY_NEXTCLOSEST_SITE, r);
ndr_print_bitmap_flag(ndr, sizeof(uint32_t),
"DS_DIRECTORY_SERVICE_6_REQUIRED", DS_DIRECTORY_SERVICE_6_REQUIRED, r);
+ ndr_print_bitmap_flag(ndr, sizeof(uint32_t), "DS_WEB_SERVICE_REQUIRED",
DS_WEB_SERVICE_REQUIRED, r);
ndr_print_bitmap_flag(ndr, sizeof(uint32_t), "DS_RETURN_DNS_NAME",
DS_RETURN_DNS_NAME, r);
ndr_print_bitmap_flag(ndr, sizeof(uint32_t), "DS_RETURN_FLAT_NAME",
DS_RETURN_FLAT_NAME, r);
ndr->depth--;
diff --git a/librpc/gen_ndr/netlogon.h b/librpc/gen_ndr/netlogon.h
index 9cf3828..64a9b1c 100644
--- a/librpc/gen_ndr/netlogon.h
+++ b/librpc/gen_ndr/netlogon.h
@@ -830,6 +830,7 @@ struct netr_Blob {
#define DS_IS_DNS_NAME ( 0x0002 )
#define DS_TRY_NEXTCLOSEST_SITE ( 0x0004 )
#define DS_DIRECTORY_SERVICE_6_REQUIRED ( 0x0008 )
+#define DS_WEB_SERVICE_REQUIRED ( 0x0010 )
#define DS_RETURN_DNS_NAME ( 0x4000 )
#define DS_RETURN_FLAT_NAME ( 0x8000 )
diff --git a/librpc/idl/netlogon.idl b/librpc/idl/netlogon.idl
index 30a1078..e0eb9ec 100644
--- a/librpc/idl/netlogon.idl
+++ b/librpc/idl/netlogon.idl
@@ -1112,6 +1112,7 @@ interface netlogon
DS_IS_DNS_NAME = 0x0002,
DS_TRY_NEXTCLOSEST_SITE = 0x0004,
DS_DIRECTORY_SERVICE_6_REQUIRED = 0x0008,
+ DS_WEB_SERVICE_REQUIRED = 0x0010,
DS_RETURN_DNS_NAME = 0x4000,
DS_RETURN_FLAT_NAME = 0x8000
} netr_DsRGetDCName_flags;
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-5345-g983c6f2
The branch, v3-3-test has been updated
via 983c6f22f411aab2488fe41b5b06174c55108868 (commit)
from 570a8cf5bb6924905b3ad20353d1e7b0ca087748 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -
commit 983c6f22f411aab2488fe41b5b06174c55108868
Author: Volker Lendecke
Date: Tue Jul 14 23:12:59 2009 +0200
Fix bug 5886
Ok, that's a very long-standing one. I finally got around to install a
recent
OpenLDAP and test the different variants of setting a NULL password etc.
Thanks all for your patience!
Volker
---
Summary of changes:
source/passdb/pdb_ldap.c | 34 ++
1 files changed, 26 insertions(+), 8 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/passdb/pdb_ldap.c b/source/passdb/pdb_ldap.c
index bc485e3..73f3e87 100644
--- a/source/passdb/pdb_ldap.c
+++ b/source/passdb/pdb_ldap.c
@@ -1700,6 +1700,7 @@ static NTSTATUS ldapsam_modify_entry(struct pdb_methods
*my_methods,
char *utf8_password;
char *utf8_dn;
size_t converted_size;
+ int ret;
if (!ldap_state->is_nds_ldap) {
@@ -1731,14 +1732,31 @@ static NTSTATUS ldapsam_modify_entry(struct pdb_methods
*my_methods,
}
if ((ber_printf (ber, "{") < 0) ||
- (ber_printf (ber, "ts", LDAP_TAG_EXOP_MODIFY_PASSWD_ID,
utf8_dn) < 0) ||
- (ber_printf (ber, "ts", LDAP_TAG_EXOP_MODIFY_PASSWD_NEW,
utf8_password) < 0) ||
- (ber_printf (ber, "n}") < 0)) {
- DEBUG(0,("ldapsam_modify_entry: ber_printf returns a
value <0\n"));
- ber_free(ber,1);
- SAFE_FREE(utf8_dn);
- SAFE_FREE(utf8_password);
- return NT_STATUS_UNSUCCESSFUL;
+ (ber_printf (ber, "ts", LDAP_TAG_EXOP_MODIFY_PASSWD_ID,
+utf8_dn) < 0)) {
+ DEBUG(0,("ldapsam_modify_entry: ber_printf returns a "
+"value <0\n"));
+ ber_free(ber,1);
+ SAFE_FREE(utf8_dn);
+ SAFE_FREE(utf8_password);
+ return NT_STATUS_UNSUCCESSFUL;
+ }
+
+ if ((utf8_password != NULL) && (*utf8_password != '\0')) {
+ ret = ber_printf(ber, "ts}",
+LDAP_TAG_EXOP_MODIFY_PASSWD_NEW,
+utf8_password);
+ } else {
+ ret = ber_printf(ber, "}");
+ }
+
+ if (ret < 0) {
+ DEBUG(0,("ldapsam_modify_entry: ber_printf returns a "
+"value <0\n"));
+ ber_free(ber,1);
+ SAFE_FREE(utf8_dn);
+ SAFE_FREE(utf8_password);
+ return NT_STATUS_UNSUCCESSFUL;
}
if ((rc = ber_flatten (ber, &bv))<0) {
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-1229-g86c1dbb
The branch, v3-4-test has been updated
via 86c1dbb473323ef9480cb57584be9e02363e80af (commit)
from 6fb3222504a0d2b42cd9292f9e11b2ff246d5c19 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test
- Log -
commit 86c1dbb473323ef9480cb57584be9e02363e80af
Author: Olaf Flebbe
Date: Mon Aug 17 17:31:01 2009 +0200
make smbcontrol smbd ping work proper checking for arguments handle short
pid_t correctly
Fixes bug #6655.
(cherry picked from commit 5359e397ff190c35414f6961be61a5110e237dd5)
---
Summary of changes:
source3/lib/util.c | 22 --
source3/utils/smbcontrol.c | 13 +
2 files changed, 21 insertions(+), 14 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/lib/util.c b/source3/lib/util.c
index 61a73e6..3d7336f 100644
--- a/source3/lib/util.c
+++ b/source3/lib/util.c
@@ -2743,14 +2743,15 @@ bool procid_is_me(const struct server_id *pid)
struct server_id interpret_pid(const char *pid_string)
{
-#ifdef CLUSTER_SUPPORT
- unsigned int vnn, pid;
struct server_id result;
- if (sscanf(pid_string, "%u:%u", &vnn, &pid) == 2) {
+ int pid;
+#ifdef CLUSTER_SUPPORT
+ unsigned int vnn;
+ if (sscanf(pid_string, "%u:%d", &vnn, &pid) == 2) {
result.vnn = vnn;
result.pid = pid;
}
- else if (sscanf(pid_string, "%u", &pid) == 1) {
+ else if (sscanf(pid_string, "%d", &pid) == 1) {
result.vnn = get_my_vnn();
result.pid = pid;
}
@@ -2758,10 +2759,19 @@ struct server_id interpret_pid(const char *pid_string)
result.vnn = NONCLUSTER_VNN;
result.pid = -1;
}
- return result;
#else
- return pid_to_procid(atoi(pid_string));
+ if (sscanf(pid_string, "%d", &pid) != 1) {
+ result.pid = -1;
+ } else {
+ result.pid = pid;
+ }
#endif
+ /* Assigning to result.pid may have overflowed
+ Map negative pid to -1: i.e. error */
+ if (result.pid < 0) {
+ result.pid = -1;
+ }
+ return result;
}
char *procid_str(TALLOC_CTX *mem_ctx, const struct server_id *pid)
diff --git a/source3/utils/smbcontrol.c b/source3/utils/smbcontrol.c
index fc7d0aa..7fab6eb 100644
--- a/source3/utils/smbcontrol.c
+++ b/source3/utils/smbcontrol.c
@@ -1247,15 +1247,12 @@ static struct server_id parse_dest(const char *dest)
dest = "winbindd";
}
- if (!(strequal(dest, "winbindd") || strequal(dest, "nmbd"))) {
- /* Check for numeric pid number */
+ /* Check for numeric pid number */
+ result = interpret_pid(dest);
- result = interpret_pid(dest);
-
- /* Zero isn't valid if not smbd. */
- if (result.pid && procid_valid(&result)) {
- return result;
- }
+ /* Zero isn't valid if not "all". */
+ if (result.pid && procid_valid(&result)) {
+ return result;
}
/* Look up other destinations in pidfile directory */
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-1228-g6fb3222
The branch, v3-4-test has been updated
via 6fb3222504a0d2b42cd9292f9e11b2ff246d5c19 (commit)
from 2467671ba55c5ac834a8aa7ae8ad736958baab1d (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test
- Log -
commit 6fb3222504a0d2b42cd9292f9e11b2ff246d5c19
Author: Volker Lendecke
Date: Tue Jul 14 23:12:59 2009 +0200
Fix bug 5886
Ok, that's a very long-standing one. I finally got around to install a
recent
OpenLDAP and test the different variants of setting a NULL password etc.
Thanks all for your patience!
Volker
---
Summary of changes:
source3/passdb/pdb_ldap.c | 34 ++
1 files changed, 26 insertions(+), 8 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/passdb/pdb_ldap.c b/source3/passdb/pdb_ldap.c
index 0886a10..cf4889b 100644
--- a/source3/passdb/pdb_ldap.c
+++ b/source3/passdb/pdb_ldap.c
@@ -1700,6 +1700,7 @@ static NTSTATUS ldapsam_modify_entry(struct pdb_methods
*my_methods,
char *utf8_password;
char *utf8_dn;
size_t converted_size;
+ int ret;
if (!ldap_state->is_nds_ldap) {
@@ -1731,14 +1732,31 @@ static NTSTATUS ldapsam_modify_entry(struct pdb_methods
*my_methods,
}
if ((ber_printf (ber, "{") < 0) ||
- (ber_printf (ber, "ts", LDAP_TAG_EXOP_MODIFY_PASSWD_ID,
utf8_dn) < 0) ||
- (ber_printf (ber, "ts", LDAP_TAG_EXOP_MODIFY_PASSWD_NEW,
utf8_password) < 0) ||
- (ber_printf (ber, "n}") < 0)) {
- DEBUG(0,("ldapsam_modify_entry: ber_printf returns a
value <0\n"));
- ber_free(ber,1);
- SAFE_FREE(utf8_dn);
- SAFE_FREE(utf8_password);
- return NT_STATUS_UNSUCCESSFUL;
+ (ber_printf (ber, "ts", LDAP_TAG_EXOP_MODIFY_PASSWD_ID,
+utf8_dn) < 0)) {
+ DEBUG(0,("ldapsam_modify_entry: ber_printf returns a "
+"value <0\n"));
+ ber_free(ber,1);
+ SAFE_FREE(utf8_dn);
+ SAFE_FREE(utf8_password);
+ return NT_STATUS_UNSUCCESSFUL;
+ }
+
+ if ((utf8_password != NULL) && (*utf8_password != '\0')) {
+ ret = ber_printf(ber, "ts}",
+LDAP_TAG_EXOP_MODIFY_PASSWD_NEW,
+utf8_password);
+ } else {
+ ret = ber_printf(ber, "}");
+ }
+
+ if (ret < 0) {
+ DEBUG(0,("ldapsam_modify_entry: ber_printf returns a "
+"value <0\n"));
+ ber_free(ber,1);
+ SAFE_FREE(utf8_dn);
+ SAFE_FREE(utf8_password);
+ return NT_STATUS_UNSUCCESSFUL;
}
if ((rc = ber_flatten (ber, &bv))<0) {
--
Samba Shared Repository
