Build status as of Fri Mar 19 06:00:01 2010
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2010-03-18 00:00:06.0 -0600 +++ /home/build/master/cache/broken_results.txt 2010-03-19 00:00:02.0 -0600 @@ -1,4 +1,4 @@ -Build status as of Thu Mar 18 06:00:05 2010 +Build status as of Fri Mar 19 06:00:01 2010 Build counts: Tree Total Broken Panic @@ -13,9 +13,10 @@ samba-docs 0 0 0 samba-web0 0 0 samba_3_current 32 32 2 -samba_3_master 32 32 2 -samba_3_next 29 29 4 +samba_3_master 32 32 3 +samba_3_next 29 28 4 samba_4_0_test 34 32 0 +samba_4_0_waf 2 2 0 talloc 34 11 0 tdb 32 22 0
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 421a926... s3:libsmb/nterr.c: fix/add NT_STATUS_RPC_* codes
from a949c70... s3-selftest: fix Samba3.pm provisioning after uid/gid
changes.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 421a926237f94ebdb90aaf0cf7678a9804bd5cdc
Author: Stefan Metzmacher
Date: Thu Mar 18 15:27:05 2010 +0100
s3:libsmb/nterr.c: fix/add NT_STATUS_RPC_* codes
metze
---
Summary of changes:
source3/libsmb/nterr.c | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/libsmb/nterr.c b/source3/libsmb/nterr.c
index 6b5cfcd..7efd32e 100644
--- a/source3/libsmb/nterr.c
+++ b/source3/libsmb/nterr.c
@@ -543,11 +543,16 @@ static const nt_err_code_struct nt_errs[] =
{ "STATUS_MORE_ENTRIES", STATUS_MORE_ENTRIES },
{ "STATUS_SOME_UNMAPPED", STATUS_SOME_UNMAPPED },
{ "STATUS_NO_MORE_FILES", STATUS_NO_MORE_FILES },
- { "NT_STATUS_RPC_CANNOT_SUPPORT", NT_STATUS_RPC_CANNOT_SUPPORT },
- { "NT_STATUS_RPC_NT_CALL_FAILED", NT_STATUS_RPC_NT_CALL_FAILED },
- { "NT_STATUS_RPC_NT_PROTOCOL_ERROR", NT_STATUS_RPC_NT_PROTOCOL_ERROR },
- { "NT_STATUS_RPC_NT_PROCNUM_OUT_OF_RANGE",
NT_STATUS_RPC_NT_PROCNUM_OUT_OF_RANGE },
{ "NT_STATUS_RPC_PROTSEQ_NOT_SUPPORTED",
NT_STATUS_RPC_PROTSEQ_NOT_SUPPORTED },
+ { "NT_STATUS_RPC_UNSUPPORTED_NAME_SYNTAX",
NT_STATUS_RPC_UNSUPPORTED_NAME_SYNTAX },
+ { "NT_STAUTS_RPC_UNKNOWN_IF", NT_STAUTS_RPC_UNKNOWN_IF },
+ { "NT_STATUS_RPC_CALL_FAILED", NT_STATUS_RPC_CALL_FAILED },
+ { "NT_STATUS_RPC_PROTOCOL_ERROR", NT_STATUS_RPC_PROTOCOL_ERROR },
+ { "NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE",
NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE },
+ { "NT_STATUS_RPC_CANNOT_SUPPORT", NT_STATUS_RPC_CANNOT_SUPPORT },
+ { "NT_STATUS_RPC_SS_CONTEXT_MISMATCH",
NT_STATUS_RPC_SS_CONTEXT_MISMATCH },
+ { "NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE",
NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE },
+ { "NT_STATUS_RPC_BAD_STUB_DATA", NT_STATUS_RPC_BAD_STUB_DATA },
{ NULL, NT_STATUS(0) }
};
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via a949c70... s3-selftest: fix Samba3.pm provisioning after uid/gid
changes.
from 05cad2e... s3-selftest: make sure we do not have duplicate
uids/gids in nsswrapper.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit a949c70ed821ea18dfd2e7218255638823c8deea
Author: Günther Deschner
Date: Thu Mar 18 15:12:07 2010 +0100
s3-selftest: fix Samba3.pm provisioning after uid/gid changes.
Guenther
---
Summary of changes:
selftest/target/Samba3.pm |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index a3faafc..18e3483 100644
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -549,9 +549,9 @@ sub provision($$)
## create a test account
##
- my $max_uid, $max_gid;
- my $uid_nobody, $uid_root;
- my $gid_nobody, $gid_nogroup, $gid_root;
+ my ($max_uid, $max_gid);
+ my ($uid_nobody, $uid_root);
+ my ($gid_nobody, $gid_nogroup, $gid_root);
if ($unix_uid < 0x - 2) {
$max_uid = 0x;
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 05cad2e... s3-selftest: make sure we do not have duplicate
uids/gids in nsswrapper.
via 38a46fa... s3-selftest: make sure we do not have duplicate
uids/gids in nsswrapper.
from 6a1f8e6... libcli/util: add more NT_STATUS_RPC_* defines
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 05cad2ea2f0963e7845b451d97830528c86e2cda
Author: Günther Deschner
Date: Thu Mar 18 12:12:58 2010 +0100
s3-selftest: make sure we do not have duplicate uids/gids in nsswrapper.
Also make sure we only add root user when needed, Jeremy please check.
Guenther
commit 38a46fa32bfd8007f0fb3e2b607d0e57a012ae95
Author: Günther Deschner
Date: Thu Mar 18 11:27:36 2010 +0100
s3-selftest: make sure we do not have duplicate uids/gids in nsswrapper.
Guenther
---
Summary of changes:
selftest/target/Samba3.pm| 38 +++
source3/script/tests/selftest.sh | 46 +
2 files changed, 64 insertions(+), 20 deletions(-)
Changeset truncated at 500 lines:
diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index cc7713d..a3faafc 100644
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -549,19 +549,47 @@ sub provision($$)
## create a test account
##
+ my $max_uid, $max_gid;
+ my $uid_nobody, $uid_root;
+ my $gid_nobody, $gid_nogroup, $gid_root;
+
+ if ($unix_uid < 0x - 2) {
+ $max_uid = 0x;
+ } else {
+ $max_uid = $unix_uid;
+ }
+
+ $uid_root = $max_uid - 1;
+ $uid_nobody = $max_uid - 2;
+
+ if ($unix_gids[0] < 0x - 3) {
+ $max_gid = 0x;
+ } else {
+ $max_gid = $unix_gids[0];
+ }
+
+ $gid_nobody = $max_gid - 1;
+ $gid_nogroup = $max_gid - 2;
+ $gid_root = $max_gid - 3;
+
open(PASSWD, ">$nss_wrapper_passwd") or die("Unable to open
$nss_wrapper_passwd");
- print PASSWD "nobody:x:65534:65533:nobody gecos:$prefix_abs:/bin/false
-root:x:65533:65532:root gecos:$prefix_abs:/bin/false
+ print PASSWD "nobody:x:$uid_nobody:$gid_nobody:nobody
gecos:$prefix_abs:/bin/false
$unix_name:x:$unix_uid:$unix_gids[0]:$unix_name gecos:$prefix_abs:/bin/false
";
+ if ($unix_uid != 0) {
+ print PASSWD "root:x:$uid_root:$gid_root:root
gecos:$prefix_abs:/bin/false";
+ }
close(PASSWD);
open(GROUP, ">$nss_wrapper_group") or die("Unable to open
$nss_wrapper_group");
- print GROUP "nobody:x:65533:
-nogroup:x:65534:nobody
-root:x:65532:
+ print GROUP "nobody:x:$gid_nobody:
+nogroup:x:$gid_nogroup:nobody
$unix_name-group:x:$unix_gids[0]:
";
+ if ($unix_gids[0] != 0) {
+ print GROUP "root:x:$gid_root:";
+ }
+
close(GROUP);
foreach my $evlog (@eventlog_list) {
diff --git a/source3/script/tests/selftest.sh b/source3/script/tests/selftest.sh
index e481c7e..b4ef432 100755
--- a/source3/script/tests/selftest.sh
+++ b/source3/script/tests/selftest.sh
@@ -325,33 +325,49 @@ EOF
## create a test account
##
-if [ "$USERID" != 0 ]; then
+if [ $USERID -lt $(( 0x - 2 )) ]; then
+ MAXUID=0x
+else
+ MAXUID=$USERID
+fi
+
+UID_ROOT=$(( $MAXUID - 1 ))
+UID_NOBODY=$(( MAXUID - 2 ))
+
+if [ $GROUPID -lt $(( 0x - 3 )) ]; then
+ MAXGID=0x
+else
+ MAXGID=$GROUPID
+fi
+
+GID_NOBODY=$(( $MAXGID - 3 ))
+GID_NOGROUP=$(( $MAXGID - 2 ))
+GID_ROOT=$(( $MAXGID - 1 ))
+
cat >$NSS_WRAPPER_PASSWD<$NSS_WRAPPER_GROUP<$NSS_WRAPPER_PASSWD<>$NSS_WRAPPER_PASSWD<$NSS_WRAPPER_GROUP<>$NSS_WRAPPER_GROUP<
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 6a1f8e6... libcli/util: add more NT_STATUS_RPC_* defines
from 30aa55a... pidl:Samba4/Python: make use of dcerpc_binding_handle
stubs
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 6a1f8e67eb6e15bbafca570ac9b3714681025a1f
Author: Stefan Metzmacher
Date: Wed Mar 17 19:48:56 2010 +0100
libcli/util: add more NT_STATUS_RPC_* defines
metze
---
Summary of changes:
libcli/util/ntstatus.h | 15 +++
source4/libcli/util/nterr.c |8
2 files changed, 19 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/libcli/util/ntstatus.h b/libcli/util/ntstatus.h
index c60e424..dca1490 100644
--- a/libcli/util/ntstatus.h
+++ b/libcli/util/ntstatus.h
@@ -604,9 +604,14 @@ typedef uint32_t NTSTATUS;
#define NT_STATUS_NO_SUCH_JOB NT_STATUS(0xC000 | 0xEDE) /* scheduler */
#define NT_STATUS_RPC_PROTSEQ_NOT_SUPPORTED NT_STATUS(0xC000 | 0x20004)
#define NT_STATUS_RPC_UNSUPPORTED_NAME_SYNTAX NT_STATUS(0xC000 | 0x20026)
-#define NT_STATUS_RPC_NT_CALL_FAILED NT_STATUS(0xC000 | 0x2001B)
-#define NT_STATUS_RPC_NT_PROTOCOL_ERROR NT_STATUS(0xC000 | 0x2001D)
-#define NT_STATUS_RPC_NT_PROCNUM_OUT_OF_RANGE NT_STATUS(0xC000 | 0x2002E)
+#define NT_STAUTS_RPC_UNKNOWN_IF NT_STATUS(0xC000 | 0x20012)
+#define NT_STATUS_RPC_CALL_FAILED NT_STATUS(0xC000 | 0x2001B)
+#define NT_STATUS_RPC_PROTOCOL_ERROR NT_STATUS(0xC000 | 0x2001D)
+#define NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE NT_STATUS(0xC000 | 0x2002E)
+#define NT_STATUS_RPC_CANNOT_SUPPORT NT_STATUS(0xC000 | 0x20041)
+#define NT_STATUS_RPC_SS_CONTEXT_MISMATCH NT_STATUS(0xC000 | 0x30005)
+#define NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE NT_STATUS(0xC00 | 0x3000A)
+#define NT_STATUS_RPC_BAD_STUB_DATA NT_STATUS(0xC000 | 0x3000C)
#define NT_STATUS_ERROR_DS_OBJ_STRING_NAME_EXISTS NT_STATUS(0xC000 |
0x2071)
#define NT_STATUS_ERROR_DS_INCOMPATIBLE_VERSION NT_STATUS(0xC000 |
0x2177)
@@ -714,6 +719,8 @@ extern bool ntstatus_check_dos_mapping;
#define NT_STATUS_IS_LDAP(status) ((NT_STATUS_V(status) & 0xFF00) ==
0xF200)
#define NT_STATUS_LDAP_CODE(status) (NT_STATUS_V(status) & ~0xFF00)
-#define NT_STATUS_RPC_CANNOT_SUPPORT NT_STATUS(0xC000 | 0x20041)
+#define NT_STATUS_IS_RPC(status) \
+ (((NT_STATUS_V(status) & 0x) == 0xC002) || \
+((NT_STATUS_V(status) & 0x) == 0xC003))
#endif /* _NTSTATUS_H */
diff --git a/source4/libcli/util/nterr.c b/source4/libcli/util/nterr.c
index 18191ab..c70c331 100644
--- a/source4/libcli/util/nterr.c
+++ b/source4/libcli/util/nterr.c
@@ -546,6 +546,14 @@ static const nt_err_code_struct nt_errs[] =
{ "NT_STATUS_NO_MORE_ENTRIES", NT_STATUS_NO_MORE_ENTRIES },
{ "NT_STATUS_RPC_PROTSEQ_NOT_SUPPORTED",
NT_STATUS_RPC_PROTSEQ_NOT_SUPPORTED },
{ "NT_STATUS_RPC_UNSUPPORTED_NAME_SYNTAX",
NT_STATUS_RPC_UNSUPPORTED_NAME_SYNTAX },
+ { "NT_STAUTS_RPC_UNKNOWN_IF", NT_STAUTS_RPC_UNKNOWN_IF },
+ { "NT_STATUS_RPC_CALL_FAILED", NT_STATUS_RPC_CALL_FAILED },
+ { "NT_STATUS_RPC_PROTOCOL_ERROR", NT_STATUS_RPC_PROTOCOL_ERROR },
+ { "NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE",
NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE },
+ { "NT_STATUS_RPC_CANNOT_SUPPORT", NT_STATUS_RPC_CANNOT_SUPPORT },
+ { "NT_STATUS_RPC_SS_CONTEXT_MISMATCH",
NT_STATUS_RPC_SS_CONTEXT_MISMATCH },
+ { "NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE",
NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE },
+ { "NT_STATUS_RPC_BAD_STUB_DATA", NT_STATUS_RPC_BAD_STUB_DATA },
{ "NT_STATUS_CURRENT_DOMAIN_NOT_ALLOWED",
NT_STATUS_CURRENT_DOMAIN_NOT_ALLOWED },
{ "NT_STATUS_OBJECTID_NOT_FOUND", NT_STATUS_OBJECTID_NOT_FOUND },
{ "NT_STATUS_DOWNGRADE_DETECTED", NT_STATUS_DOWNGRADE_DETECTED },
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 30aa55a... pidl:Samba4/Python: make use of dcerpc_binding_handle
stubs
via 5e9ce49... s4:librpc/rpc: let pyrpc make use of
dcerpc_binding_handle stubs
via f055fce... pidl:Samba4/Python: remove compiler warnings
via 2624baf... pidl:Samba4/Python: remove compiler warnings when using
-Wc++
from fd86c9b... s4:utils/net/drs: make use of dcerpc_binding_handle stubs
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 30aa55a998016c5d87691b3592435a21107fe33b
Author: Stefan Metzmacher
Date: Thu Mar 18 11:26:19 2010 +0100
pidl:Samba4/Python: make use of dcerpc_binding_handle stubs
metze
commit 5e9ce495eef98b2b27a77bf042514ccb2037d33d
Author: Stefan Metzmacher
Date: Thu Mar 18 11:25:21 2010 +0100
s4:librpc/rpc: let pyrpc make use of dcerpc_binding_handle stubs
metze
commit f055fce74c0f569e8bfcf29e5c4fadb592a7c87d
Author: Stefan Metzmacher
Date: Thu Mar 18 12:36:57 2010 +0100
pidl:Samba4/Python: remove compiler warnings
metze
commit 2624bafca532de66ae1d4976f8c2e99f5f7b250e
Author: Stefan Metzmacher
Date: Thu Mar 18 10:52:05 2010 +0100
pidl:Samba4/Python: remove compiler warnings when using -Wc++
metze
---
Summary of changes:
pidl/lib/Parse/Pidl/Samba4/Python.pm |8
source4/librpc/rpc/dcerpc.h |2 --
source4/librpc/rpc/pyrpc.c |5 -
source4/librpc/rpc/pyrpc.h |4 +++-
4 files changed, 11 insertions(+), 8 deletions(-)
Changeset truncated at 500 lines:
diff --git a/pidl/lib/Parse/Pidl/Samba4/Python.pm
b/pidl/lib/Parse/Pidl/Samba4/Python.pm
index a6c2738..5cf619b 100644
--- a/pidl/lib/Parse/Pidl/Samba4/Python.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/Python.pm
@@ -657,14 +657,14 @@ sub Interface($$$)
my ($infn, $outfn, $fndocstring) =
$self->PythonFunction($d, $interface->{NAME}, $prettyname);
- push (@fns, [$infn, $outfn, "dcerpc_$d->{NAME}",
$prettyname, $fndocstring, $d->{OPNUM}]);
+ push (@fns, [$infn, $outfn, "dcerpc_$d->{NAME}_r",
$prettyname, $fndocstring, $d->{OPNUM}]);
}
$self->pidl("const struct PyNdrRpcMethodDef
py_ndr_$interface->{NAME}\_methods[] = {");
$self->indent;
foreach my $d (@fns) {
my ($infn, $outfn, $callfn, $prettyname, $docstring,
$opnum) = @$d;
- $self->pidl("{ \"$prettyname\", $docstring,
(dcerpc_call_fn)$callfn, (py_data_pack_fn)$infn, (py_data_unpack_fn)$outfn,
$opnum, &ndr_table_$interface->{NAME} },");
+ $self->pidl("{ \"$prettyname\", $docstring,
(py_dcerpc_call_fn)$callfn, (py_data_pack_fn)$infn, (py_data_unpack_fn)$outfn,
$opnum, &ndr_table_$interface->{NAME} },");
}
$self->pidl("{ NULL }");
$self->deindent;
@@ -727,7 +727,7 @@ sub register_module_typeobject($$$)
{
my ($self, $name, $py_name) = @_;
- $self->register_module_object($name, "(PyObject *)$py_name");
+ $self->register_module_object($name, "(PyObject *)(void *)$py_name");
$self->check_ready_type($py_name);
@@ -833,7 +833,7 @@ sub ConvertObjectFromPythonData($$;$)
return;
}
$self->pidl("PY_CHECK_TYPE($ctype_name, $cvar, $fail);");
- $self->assign($target, "py_talloc_get_ptr($cvar)");
+ $self->assign($target, "(".mapTypeName($ctype)."
*)py_talloc_get_ptr($cvar)");
return;
}
diff --git a/source4/librpc/rpc/dcerpc.h b/source4/librpc/rpc/dcerpc.h
index 08210e0..70e90c4 100644
--- a/source4/librpc/rpc/dcerpc.h
+++ b/source4/librpc/rpc/dcerpc.h
@@ -392,8 +392,6 @@ NTSTATUS dcerpc_request(struct dcerpc_pipe *p,
DATA_BLOB *stub_data_in,
DATA_BLOB *stub_data_out);
-typedef NTSTATUS (*dcerpc_call_fn) (struct dcerpc_pipe *, TALLOC_CTX *, void
*);
-
enum dcerpc_transport_t dcerpc_transport_by_endpoint_protocol(int prot);
const char *dcerpc_floor_get_rhs_data(TALLOC_CTX *mem_ctx, struct epm_floor
*epm_floor);
diff --git a/source4/librpc/rpc/pyrpc.c b/source4/librpc/rpc/pyrpc.c
index 00bc683..012f188 100644
--- a/source4/librpc/rpc/pyrpc.c
+++ b/source4/librpc/rpc/pyrpc.c
@@ -57,7 +57,7 @@ static PyObject
*py_dcerpc_run_function(dcerpc_InterfaceObject *iface,
return NULL;
}
- status = md->call(iface->pipe, mem_ctx, r);
+ status = md->call(iface->binding_handle, mem_ctx, r);
if (NT_STATUS_IS_ERR(status)) {
PyErr_SetDCERPCStatus(iface->pipe, status);
talloc_free(mem_ctx);
@@ -356,6 +356,7 @@ PyObject *py_dcerpc_interface_init_helper(PyTypeObject
*
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via fd86c9b... s4:utils/net/drs: make use of dcerpc_binding_handle stubs
via 95cefcf... s4:torture/rpc/browser.c: make use of
dcerpc_binding_handle stubs
via 18fa68f... s4:torture/rpc/ntsvcs.c: make use of
dcerpc_binding_handle stubs
via 7456df5... s4:torture/rpc/frsapi.c: make use of
dcerpc_binding_handle stubs
via 61c62a7... s4:torture/rpc/handles.c: make use of
dcerpc_binding_handle stubs
via cef4643... s4:torture/rpc/handles: check the correct last_fault_code
from 6de83ef... s4:dsdb Move rdn_name down the stack
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit fd86c9b6877ab9e416b82d04bc7cfc42af027d74
Author: Stefan Metzmacher
Date: Thu Mar 18 10:48:24 2010 +0100
s4:utils/net/drs: make use of dcerpc_binding_handle stubs
metze
commit 95cefcfa4a7da51f11c9662057275830b2a4
Author: Stefan Metzmacher
Date: Thu Mar 18 10:27:41 2010 +0100
s4:torture/rpc/browser.c: make use of dcerpc_binding_handle stubs
metze
commit 18fa68f2597a68699a3f87674663fb8df57453b9
Author: Stefan Metzmacher
Date: Thu Mar 18 10:26:43 2010 +0100
s4:torture/rpc/ntsvcs.c: make use of dcerpc_binding_handle stubs
metze
commit 7456df5e75ae383a5ea89578fbc1ef5507771670
Author: Stefan Metzmacher
Date: Thu Mar 18 10:24:56 2010 +0100
s4:torture/rpc/frsapi.c: make use of dcerpc_binding_handle stubs
metze
commit 61c62a7fd12efeea91b11762f59aebe6d9652b3f
Author: Stefan Metzmacher
Date: Thu Mar 18 09:56:32 2010 +0100
s4:torture/rpc/handles.c: make use of dcerpc_binding_handle stubs
metze
commit cef46436fc89d938780a4bdaea4e654b9a4c01b1
Author: Stefan Metzmacher
Date: Thu Mar 18 09:38:57 2010 +0100
s4:torture/rpc/handles: check the correct last_fault_code
metze
---
Summary of changes:
source4/torture/rpc/browser.c | 17 +++---
source4/torture/rpc/frsapi.c | 40 +++-
source4/torture/rpc/handles.c | 97 +
source4/torture/rpc/ntsvcs.c | 22 ---
source4/utils/net/drs/net_drs.c |6 +-
source4/utils/net/drs/net_drs.h |1 +
source4/utils/net/drs/net_drs_kcc.c |2 +-
source4/utils/net/drs/net_drs_replicate.c |2 +-
source4/utils/net/drs/net_drs_showrepl.c |2 +-
9 files changed, 109 insertions(+), 80 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/torture/rpc/browser.c b/source4/torture/rpc/browser.c
index c9bb9d7..34eaf52 100644
--- a/source4/torture/rpc/browser.c
+++ b/source4/torture/rpc/browser.c
@@ -26,6 +26,7 @@
bool test_BrowserrQueryOtherDomains(struct torture_context *tctx,
struct dcerpc_pipe *p)
{
+ struct dcerpc_binding_handle *b = p->binding_handle;
struct BrowserrQueryOtherDomains r;
struct BrowserrSrvInfo info;
struct BrowserrSrvInfo100Ctr ctr100;
@@ -53,7 +54,7 @@ bool test_BrowserrQueryOtherDomains(struct torture_context
*tctx,
info.level = 100;
info.info.info100 = &ctr100;
- status = dcerpc_BrowserrQueryOtherDomains(p, tctx, &r);
+ status = dcerpc_BrowserrQueryOtherDomains_r(b, tctx, &r);
torture_assert_ntstatus_ok(tctx, status, "BrowserrQueryOtherDomains
failed");
torture_assert_werr_ok(tctx, r.out.result, "BrowserrQueryOtherDomains
failed");
torture_assert_int_equal(tctx, *r.out.total_entries, 0,
"BrowserrQueryOtherDomains");
@@ -62,13 +63,13 @@ bool test_BrowserrQueryOtherDomains(struct torture_context
*tctx,
ctr100.entries_read = ARRAY_SIZE(entries100);
ctr100.entries = entries100;
- status = dcerpc_BrowserrQueryOtherDomains(p, tctx, &r);
+ status = dcerpc_BrowserrQueryOtherDomains_r(b, tctx, &r);
torture_assert_ntstatus_ok(tctx, status, "BrowserrQueryOtherDomains
failed");
torture_assert_werr_ok(tctx, r.out.result, "BrowserrQueryOtherDomains
failed");
torture_assert_int_equal(tctx, *r.out.total_entries, 0,
"BrowserrQueryOtherDomains");
info.info.info100 = NULL;
- status = dcerpc_BrowserrQueryOtherDomains(p, tctx, &r);
+ status = dcerpc_BrowserrQueryOtherDomains_r(b, tctx, &r);
torture_assert_ntstatus_ok(tctx, status, "BrowserrQueryOtherDomains
failed");
torture_assert_werr_equal(tctx, WERR_INVALID_PARAM, r.out.result,
"BrowserrQueryOtherDomains failed");
@@ -76,7 +77,7 @@ bool test_BrowserrQueryOtherDomains(struct torture_context
*tctx,
info.level = 101;
info.info.info101 = &ctr101;
- status = dcerpc_BrowserrQueryOtherDomains(p, tctx, &r);
+ status = dcerpc_BrowserrQueryOtherDomains_r(b, tctx, &r);
torture_assert_ntstatus_ok(tc
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 6de83ef... s4:dsdb Move rdn_name down the stack from 0d6d068... s3-printing: Fix "printer admin" functionality. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 6de83ef6277d8506478ce5ff43d33e39541b310c Author: Andrew Bartlett Date: Thu Mar 18 22:03:40 2010 +1100 s4:dsdb Move rdn_name down the stack This is done so that it can be (in future) removed when the OpenLDAP backend is in use and the rdn_val module is used, while keeping as similar semantics as possible between the module stacks. Andrew Bartlett --- Summary of changes: source4/dsdb/samdb/ldb_modules/samba_dsdb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/dsdb/samdb/ldb_modules/samba_dsdb.c b/source4/dsdb/samdb/ldb_modules/samba_dsdb.c index c929d65..8f7e540 100644 --- a/source4/dsdb/samdb/ldb_modules/samba_dsdb.c +++ b/source4/dsdb/samdb/ldb_modules/samba_dsdb.c @@ -175,7 +175,6 @@ static int samba_dsdb_init(struct ldb_module *module) "asq", "extended_dn_store", "extended_dn_in", -"rdn_name", "objectclass", "descriptor", "acl", @@ -186,6 +185,7 @@ static int samba_dsdb_init(struct ldb_module *module) "kludge_acl", "schema_load", "instancetype", +"rdn_name", NULL }; const char **link_modules; -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated
via 5543629... s3-winreg: Fix _winreg_QueryValue crash bugs and
implement windows behavior.
via 6740503... s3-winreg: add some debug statements to
_winreg_QueryValue().
via bd3a850... s3: re-run make samba3-idl.
via f9a5264... winreg: fix winreg_QueryValue IDL.
from e74ced9... s3-printing: Fix "printer admin" functionality.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test
- Log -
commit 55436299da49d995a2d9b3d7b702122ebb2ce156
Author: Günther Deschner
Date: Thu Mar 11 12:21:08 2010 +0100
s3-winreg: Fix _winreg_QueryValue crash bugs and implement windows behavior.
Found by RPC-WINREG smbtorture test.
Guenther
(cherry picked from commit cddc542ba5f30316ff4ee8fa591a54808b7be4c8)
The last 4 patches address bug #7258 (NULL pointer derref crash in
_winreg_QueryValue).
commit 6740503b0bace52d09d2a306f8da8b168c2e7ab0
Author: Günther Deschner
Date: Wed Mar 10 14:17:23 2010 +0100
s3-winreg: add some debug statements to _winreg_QueryValue().
Guenther
(cherry picked from commit c5ba525748fdab6b182e35673983719b7c235127)
commit bd3a8505a90eac76b61b354dfc9565c69c164e95
Author: Günther Deschner
Date: Wed Mar 17 12:06:39 2010 +0100
s3: re-run make samba3-idl.
Guenther
commit f9a52643a5665efd5b11733179e574e3d0282e8b
Author: Günther Deschner
Date: Fri Mar 5 21:56:50 2010 +0100
winreg: fix winreg_QueryValue IDL.
Note that before this change pidl generated code that just dereferenced
size_is
and length_is values from unique pointers without checking whether these
pointers were actually NULL.
With this change, pidl now throws a warning like:
warning: Got pointer for `data_size', expected fully derefenced variable
which is not correct, probably because pidl does not evaluate the C
expression.
Guenther
(cherry picked from commit f258e98e177f0f75bab99654b9f32b10bb7ce37f)
---
Summary of changes:
librpc/gen_ndr/cli_winreg.c|8
librpc/gen_ndr/cli_winreg.h|4 ++--
librpc/gen_ndr/ndr_winreg.c| 24
librpc/gen_ndr/winreg.h|4 ++--
librpc/idl/winreg.idl |2 +-
source3/rpc_server/srv_winreg_nt.c | 27 ++-
6 files changed, 35 insertions(+), 34 deletions(-)
Changeset truncated at 500 lines:
diff --git a/librpc/gen_ndr/cli_winreg.c b/librpc/gen_ndr/cli_winreg.c
index 4264542..1c37f51 100644
--- a/librpc/gen_ndr/cli_winreg.c
+++ b/librpc/gen_ndr/cli_winreg.c
@@ -2743,7 +2743,7 @@ struct tevent_req
*rpccli_winreg_QueryValue_send(TALLOC_CTX *mem_ctx,
struct policy_handle *_handle
/* [in] [ref] */,
struct winreg_String
*_value_name /* [in] [ref] */,
enum winreg_Type *_type /*
[in,out] [unique] */,
-uint8_t *_data /* [in,out]
[unique,length_is(*data_length),size_is(*data_size)] */,
+uint8_t *_data /* [in,out]
[unique,range(0,0x400),length_is(data_length?*data_length:0),size_is(data_size?*data_size:0)]
*/,
uint32_t *_data_size /*
[in,out] [unique] */,
uint32_t *_data_length /*
[in,out] [unique] */)
{
@@ -2823,7 +2823,7 @@ static void rpccli_winreg_QueryValue_done(struct
tevent_req *subreq)
*state->orig.out.type = *state->tmp.out.type;
}
if (state->orig.out.data && state->tmp.out.data) {
- memcpy(state->orig.out.data, state->tmp.out.data,
(*state->tmp.in.data_size) * sizeof(*state->orig.out.data));
+ memcpy(state->orig.out.data, state->tmp.out.data,
(state->tmp.in.data_size?*state->tmp.in.data_size:0) *
sizeof(*state->orig.out.data));
}
if (state->orig.out.data_size && state->tmp.out.data_size) {
*state->orig.out.data_size = *state->tmp.out.data_size;
@@ -2869,7 +2869,7 @@ NTSTATUS rpccli_winreg_QueryValue(struct rpc_pipe_client
*cli,
struct policy_handle *handle /* [in] [ref] */,
struct winreg_String *value_name /* [in]
[ref] */,
enum winreg_Type *type /* [in,out] [unique]
*/,
- uint8_t *data /* [in,out]
[unique,length_is(*data_length),size_is(*data_size)] */,
+ uint8_t *data /* [in,out]
[unique,range(0,0x400),length_is(data_length?*data_length:0),size_is(data_size?*data_size:0)]
*/,
uint32_t
[SCM] Samba Shared Repository - branch v3-4-test updated
The branch, v3-4-test has been updated
via a99d9e7... s3-printing: Fix "printer admin" functionality.
from 78ef22a... s3-spoolss: Fix value-needed calculation
in_spoolss_EnumPrinterData().
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test
- Log -
commit a99d9e7678de17486bf34320ef0fda071b24197a
Author: Jeremy Allison
Date: Thu Mar 18 11:21:15 2010 +0100
s3-printing: Fix "printer admin" functionality.
Fix bug #7255 ("printer admin" parameter does not work as expected).
(cherry picked from commit 0d6d068bc4f76c2816f969fcce6013e1945794d4)
(cherry picked from commit e74ced9f90ade37fa7bd179a91803f775c77e25b)
---
Summary of changes:
source3/printing/nt_printing.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index afb3406..30905fc 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -5734,7 +5734,7 @@ bool print_access_check(struct auth_serversupplied_info
*server_info, int snum,
/* see if we need to try the printer admin list */
-if ((access_granted == 0) &&
+if (!NT_STATUS_IS_OK(status) &&
(token_contains_name_in_list(uidtoname(server_info->utok.uid),
NULL, NULL, server_info->ptok,
lp_printer_admin(snum {
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated
via e74ced9... s3-printing: Fix "printer admin" functionality.
from 400801c... s3-spoolss: Fix value-needed calculation
in_spoolss_EnumPrinterData().
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test
- Log -
commit e74ced9f90ade37fa7bd179a91803f775c77e25b
Author: Jeremy Allison
Date: Thu Mar 18 11:21:15 2010 +0100
s3-printing: Fix "printer admin" functionality.
Fix bug #7255 ("printer admin" parameter does not work as expected).
(cherry picked from commit 0d6d068bc4f76c2816f969fcce6013e1945794d4)
---
Summary of changes:
source3/printing/nt_printing.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index 1f30651..2f4bb71 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -5717,7 +5717,7 @@ bool print_access_check(struct auth_serversupplied_info
*server_info, int snum,
/* see if we need to try the printer admin list */
-if ((access_granted == 0) &&
+if (!NT_STATUS_IS_OK(status) &&
(token_contains_name_in_list(uidtoname(server_info->utok.uid),
NULL, NULL, server_info->ptok,
lp_printer_admin(snum {
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 0d6d068... s3-printing: Fix "printer admin" functionality.
from 55c4511... charset: fixed a problem with the global use of the
iconv_convenience structure
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 0d6d068bc4f76c2816f969fcce6013e1945794d4
Author: Jeremy Allison
Date: Thu Mar 18 11:21:15 2010 +0100
s3-printing: Fix "printer admin" functionality.
Fix bug #7255 ("printer admin" parameter does not work as expected).
---
Summary of changes:
source3/printing/nt_printing.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index c080037..b29000a 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -5720,7 +5720,7 @@ bool print_access_check(struct auth_serversupplied_info
*server_info, int snum,
/* see if we need to try the printer admin list */
-if ((access_granted == 0) &&
+if (!NT_STATUS_IS_OK(status) &&
(token_contains_name_in_list(uidtoname(server_info->utok.uid),
NULL, NULL, server_info->ptok,
lp_printer_admin(snum {
--
Samba Shared Repository
