Build status as of Mon Jun 21 06:00:02 2010
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2010-06-20 00:00:36.0 -0600 +++ /home/build/master/cache/broken_results.txt 2010-06-21 00:00:23.0 -0600 @@ -1,4 +1,4 @@ -Build status as of Sun Jun 20 06:00:07 2010 +Build status as of Mon Jun 21 06:00:02 2010 Build counts: Tree Total Broken Panic
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 3aa8853... s4/dsdb: msg_idx->dn should be allocated in msg_idx mem
context
via cc7e2c1... s4/dsdb: Move schema accessors cleanup in separate
function
via 267645c... s4/dsdb-schema: Index attributes on msDS-IntId value
from ecbe9a7... s4:kdc/db-glue.c - remove unreachable code
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 3aa8853f58b32c5430cd03164a0c2bc26c1b04c0
Author: Kamen Mazdrashki
Date: Sun Jun 20 23:31:43 2010 +0300
s4/dsdb: msg_idx->dn should be allocated in msg_idx mem context
commit cc7e2c10f2b944fd7eac4ff11e9d48fac0043030
Author: Kamen Mazdrashki
Date: Sat Jun 19 12:30:36 2010 +0300
s4/dsdb: Move schema accessors cleanup in separate function
This way dsdb_setup_sorted_accessors() will
free memory allocated for accessor arrays correctly
in case of failure,
commit 267645ca55f7825e87a098c9dc51f132aac1f452
Author: Kamen Mazdrashki
Date: Sat Jun 19 00:00:08 2010 +0300
s4/dsdb-schema: Index attributes on msDS-IntId value
O(n) search for dsdb_attribute by msDS-IntId value was
replaced by binary-search in ordered index.
I've choosen the approach of separate index on msDS-IntId values
as I think it is more clear what we are searching for.
And it should little bit faster as we can clearly determine
in which index to perform the search based on ATTID value -
ATTIDs based on prefixMap and ATTIDs based on msDS-IntId
are in separate ranges.
Other way to implement this index was to merge msDS-IntId values
in attributeID_id index.
This led me to a shorted but not so obvious implementation.
---
Summary of changes:
source4/dsdb/schema/schema.h |2 +
source4/dsdb/schema/schema_query.c |8 ++---
source4/dsdb/schema/schema_set.c | 62 +---
3 files changed, 48 insertions(+), 24 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/dsdb/schema/schema.h b/source4/dsdb/schema/schema.h
index 0cbc218..34423be 100644
--- a/source4/dsdb/schema/schema.h
+++ b/source4/dsdb/schema/schema.h
@@ -209,6 +209,8 @@ struct dsdb_schema {
struct dsdb_attribute **attributes_by_attributeID_id;
struct dsdb_attribute **attributes_by_attributeID_oid;
struct dsdb_attribute **attributes_by_linkID;
+ uint32_t num_int_id_attr;
+ struct dsdb_attribute **attributes_by_msDS_IntId;
struct {
bool we_are_master;
diff --git a/source4/dsdb/schema/schema_query.c
b/source4/dsdb/schema/schema_query.c
index 4ff8418..8ea79ff 100644
--- a/source4/dsdb/schema/schema_query.c
+++ b/source4/dsdb/schema/schema_query.c
@@ -65,11 +65,9 @@ const struct dsdb_attribute
*dsdb_attribute_by_attributeID_id(const struct dsdb_
/* check for msDS-IntId type attribute */
if (dsdb_pfm_get_attid_type(id) == dsdb_attid_type_intid) {
- for (c = schema->attributes; c; c = c->next) {
- if (c->msDS_IntId == id) {
- return c;
- }
- }
+ BINARY_ARRAY_SEARCH_P(schema->attributes_by_msDS_IntId,
+ schema->num_int_id_attr, msDS_IntId, id,
uint32_cmp, c);
+ return c;
}
BINARY_ARRAY_SEARCH_P(schema->attributes_by_attributeID_id,
diff --git a/source4/dsdb/schema/schema_set.c b/source4/dsdb/schema/schema_set.c
index 5ecbad2..0e04f5b 100644
--- a/source4/dsdb/schema/schema_set.c
+++ b/source4/dsdb/schema/schema_set.c
@@ -83,7 +83,7 @@ static int dsdb_schema_set_attributes(struct ldb_context
*ldb, struct dsdb_schem
ldb_oom(ldb);
goto op_error;
}
- msg_idx->dn = ldb_dn_new(msg, ldb, "@INDEXLIST");
+ msg_idx->dn = ldb_dn_new(msg_idx, ldb, "@INDEXLIST");
if (!msg_idx->dn) {
ldb_oom(ldb);
goto op_error;
@@ -221,6 +221,24 @@ static int dsdb_compare_attribute_by_linkID(struct
dsdb_attribute **a1, struct d
return uint32_cmp((*a1)->linkID, (*a2)->linkID);
}
+/**
+ * Clean up Classes and Attributes accessor arrays
+ */
+static void dsdb_sorted_accessors_free(struct dsdb_schema *schema)
+{
+ /* free classes accessors */
+ TALLOC_FREE(schema->classes_by_lDAPDisplayName);
+ TALLOC_FREE(schema->classes_by_governsID_id);
+ TALLOC_FREE(schema->classes_by_governsID_oid);
+ TALLOC_FREE(schema->classes_by_cn);
+ /* free attribute accessors */
+ TALLOC_FREE(schema->attributes_by_lDAPDisplayName);
+ TALLOC_FREE(schema->attributes_by_attributeID_id);
+ TALLOC_FREE(schema->attributes_by_msDS_IntId);
+ TALLOC_FREE(schema->attributes_by_attributeID_oid);
+ TALLOC_FREE(schema->attributes_by_lin
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via ecbe9a7... s4:kdc/db-glue.c - remove unreachable code
via 05f31c3... s4:registry/regf.c - add some casts to suppress build
warnings on Solaris
via 2adfe47... s4:registry/rpc.c - fix Solaris warnings by casts
via 2f49c8f... s4:samr RPC server - fix Solaris build warning
via 871cdec... s4:registry RPC server - quite some build warnings on
Solaris
via 82fd483... s4:lsa_lookup.c - fix type argument
via 0bf26ed... s4:rpc_server/service_rpc.c - fix warnings on Solaris
via c972e6e... s4:rpc_server/service_rpc.c - deactivate the 0-length
struct
from 58715dd... s4:libpolicy - fix printf output specifiers to suppress
warning
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit ecbe9a74c6757415720657fbd3ba207989b47848
Author: Matthias Dieter Wallnöfer
Date: Sun Jun 20 22:17:33 2010 +0200
s4:kdc/db-glue.c - remove unreachable code
Would be nice if someone could check if this fits.
commit 05f31c3f6d790f650c2b449c4726521464911777
Author: Matthias Dieter Wallnöfer
Date: Sun Jun 20 22:14:27 2010 +0200
s4:registry/regf.c - add some casts to suppress build warnings on Solaris
commit 2adfe4730362220afe3874b750e71c6e006b310a
Author: Matthias Dieter Wallnöfer
Date: Sun Jun 20 22:06:51 2010 +0200
s4:registry/rpc.c - fix Solaris warnings by casts
commit 2f49c8f58e213e4b8b3f60bb6e02dfc833bb27f3
Author: Matthias Dieter Wallnöfer
Date: Sun Jun 20 22:03:45 2010 +0200
s4:samr RPC server - fix Solaris build warning
commit 871cdec4141e29f377b11fa7a5c177ac7e2dae80
Author: Matthias Dieter Wallnöfer
Date: Sun Jun 20 21:54:50 2010 +0200
s4:registry RPC server - quite some build warnings on Solaris
commit 82fd4837589bbf5918e672669ed30ad300bf3a4a
Author: Matthias Dieter Wallnöfer
Date: Sun Jun 20 21:49:52 2010 +0200
s4:lsa_lookup.c - fix type argument
commit 0bf26edf6c466bfffa87c47b0acb64cc6f4544f7
Author: Matthias Dieter Wallnöfer
Date: Sun Jun 20 21:46:53 2010 +0200
s4:rpc_server/service_rpc.c - fix warnings on Solaris
commit c972e6ec233fc2023b33da0d707ae035f85faba2
Author: Matthias Dieter Wallnöfer
Date: Sun Jun 20 22:32:04 2010 +0200
s4:rpc_server/service_rpc.c - deactivate the 0-length struct
This should fix the build on Solaris
---
Summary of changes:
source4/kdc/db-glue.c |4
source4/lib/registry/regf.c|4 ++--
source4/lib/registry/rpc.c |8
source4/rpc_server/lsa/lsa_lookup.c|2 +-
source4/rpc_server/samr/dcesrv_samr.c |6 +++---
source4/rpc_server/service_rpc.c |6 --
source4/rpc_server/winreg/rpc_winreg.c |8
7 files changed, 18 insertions(+), 20 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c
index 97820c0..6e06625 100644
--- a/source4/kdc/db-glue.c
+++ b/source4/kdc/db-glue.c
@@ -1125,10 +1125,6 @@ static krb5_error_code
samba_kdc_fetch_krbtgt(krb5_context context,
krb5_warnx(context, "samba_kdc_fetch:
trust_message2entry failed");
}
return ret;
-
-
- /* we should lookup trusted domains */
- return HDB_ERR_NOENTRY;
}
}
diff --git a/source4/lib/registry/regf.c b/source4/lib/registry/regf.c
index 176b256..cfbaadd 100644
--- a/source4/lib/registry/regf.c
+++ b/source4/lib/registry/regf.c
@@ -158,7 +158,7 @@ static DATA_BLOB hbin_alloc(struct regf_data *data,
uint32_t size,
uint32_t *offset)
{
DATA_BLOB ret;
- uint32_t rel_offset = -1; /* Relative offset ! */
+ uint32_t rel_offset = (uint32_t) -1; /* Relative offset ! */
struct hbin_block *hbin = NULL;
unsigned int i;
@@ -1775,7 +1775,7 @@ static WERROR regf_set_value(struct hive_key *key, const
char *name,
struct nk_block *nk = private_data->nk;
struct vk_block vk;
uint32_t i;
- uint32_t tmp_vk_offset, vk_offset, old_vk_offset = -1;
+ uint32_t tmp_vk_offset, vk_offset, old_vk_offset = (uint32_t) -1;
DATA_BLOB values;
ZERO_STRUCT(vk);
diff --git a/source4/lib/registry/rpc.c b/source4/lib/registry/rpc.c
index a596fad..7948f7c 100644
--- a/source4/lib/registry/rpc.c
+++ b/source4/lib/registry/rpc.c
@@ -214,12 +214,12 @@ static WERROR rpc_get_value_by_index(TALLOC_CTX *mem_ctx,
r.in.handle = &mykeydata->pol;
r.in.enum_index = n;
r.in.name = &name;
- r.in.type = type;
+ r.in.type = (enum winreg_Type *) type;
r.in.value = &value;
r.in.size = &val_size;
r.in.length = &zero;
r.out.name = &name;
- r.out.type = type;
+ r.out.type = (enum winreg_Type *) type;
r.out
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 58715dd... s4:libpolicy - fix printf output specifiers to suppress
warning
via 26bcbf6... s4:libpolicy - Solaris compatibility fix
from 91c49c2... s4:ldap.py - test subtree deletes through a new testcase
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 58715dd3652ba53fa85cb5457be5d8c607b3d798
Author: Matthias Dieter Wallnöfer
Date: Sun Jun 20 20:34:48 2010 +0200
s4:libpolicy - fix printf output specifiers to suppress warning
commit 26bcbf6e3542fb350045888473a6e25d661ff6fa
Author: Matthias Dieter Wallnöfer
Date: Sun Jun 20 20:23:56 2010 +0200
s4:libpolicy - Solaris compatibility fix
---
Summary of changes:
source4/lib/policy/gp_filesys.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/lib/policy/gp_filesys.c b/source4/lib/policy/gp_filesys.c
index 78b5c33..b932ee5 100644
--- a/source4/lib/policy/gp_filesys.c
+++ b/source4/lib/policy/gp_filesys.c
@@ -254,7 +254,7 @@ static NTSTATUS gp_get_file (struct smbcli_tree *tree,
const char *remote_src,
/* Bytes read should match the file size, or the copy was incomplete */
if (nread != file_size) {
DEBUG(0, ("Remote/local file size mismatch after copying file: "
- "%s (remote %ld, local %ld).\n",
+ "%s (remote %zu, local %zu).\n",
remote_src, file_size, nread));
talloc_free(buf);
return NT_STATUS_UNSUCCESSFUL;
@@ -402,6 +402,7 @@ static NTSTATUS push_recursive (struct gp_context *gp_ctx,
const char *local_pat
int local_fd, remote_fd;
int buf[1024];
int nread, total_read;
+ struct stat s;
dir = opendir(local_path);
while ((dirent = readdir(dir)) != NULL) {
@@ -418,7 +419,10 @@ static NTSTATUS push_recursive (struct gp_context *gp_ctx,
const char *local_pat
remote_path,
dirent->d_name);
NT_STATUS_HAVE_NO_MEMORY(entry_remote_path);
- if (dirent->d_type == DT_DIR) {
+ if (stat(dirent->d_name, &s) != 0) {
+ return NT_STATUS_UNSUCCESSFUL;
+ }
+ if (s.st_mode & S_IFDIR) {
DEBUG(6, ("Pushing directory %s to %s on sysvol\n",
entry_local_path, entry_remote_path));
smbcli_mkdir(gp_ctx->cli->tree, entry_remote_path);
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 91c49c2... s4:ldap.py - test subtree deletes through a new testcase via 449370d... s4:ldap_backend.c - now also the LDAP server supports controls on delete operations via 9803c89... s4:ldap_backend.c - move function "ldb_mod_req_with_controls" to a better place in the code via fbd0902... s4:subtree_delete LDB module - now do support tree delete operations via 87d0f63... s4:dsdb - add a new dsdb delete function which understands the tree delete control via ad5e19f... ldb:controls - add the "TREE_DELETE" control for allowing subtree deletes via 065579b... ldb:ldb.h - add classifications to the control declarations via e062e73... s4:python LDB __init__.py - remove completely unused "erase_partitions" call via 2fb715b... s4:samldb LDB module - remove "samldb_set_defaultObjectCategory" via c8d2c5f... s4:ldap_backend.c - add some newlines to make logs easier to read via d7ad7ee... ldb:pyldb.c - introduce a "mem_ctx" also on "py_ldb_search" via 00bf608... ldb:pyldb.c - some cleanups and adequations also in "py_ldb_modify" and "py_ldb_rename" via 4cc49d3... s4:ldap_controls.c - remove encoding functions for private recalculate SD control from 0714e23... provision: Look for Samba prefix a bit harder. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 91c49c2fb29a188db24695a78b365aeb4f51db27 Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 17:36:43 2010 +0200 s4:ldap.py - test subtree deletes through a new testcase commit 449370db545f189449dbce75fd73271caf5ab187 Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 15:13:36 2010 +0200 s4:ldap_backend.c - now also the LDAP server supports controls on delete operations commit 9803c89ee28b4b4d6e4514b362aa60adb7f93366 Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 15:09:55 2010 +0200 s4:ldap_backend.c - move function "ldb_mod_req_with_controls" to a better place in the code Under the "add" and over the "delete" function. commit fbd09029581d2f9b6c6f0c2410d768d501f4b75c Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 12:49:04 2010 +0200 s4:subtree_delete LDB module - now do support tree delete operations commit 87d0f636320b3b6818c1703d99b94648f00d0af7 Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 12:43:49 2010 +0200 s4:dsdb - add a new dsdb delete function which understands the tree delete control commit ad5e19f29e3d716579607e706b42a4e7d2ed11c4 Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 12:19:31 2010 +0200 ldb:controls - add the "TREE_DELETE" control for allowing subtree deletes commit 065579b4c6a05de7fd867dbe0eb736b86a6bc5f7 Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 12:08:50 2010 +0200 ldb:ldb.h - add classifications to the control declarations This makes it easier to understand which standard specifies which control. commit e062e7300bd2993b4a5d641ce3128f9c461f6328 Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 13:03:59 2010 +0200 s4:python LDB __init__.py - remove completely unused "erase_partitions" call Seems to be a relict from the past. commit 2fb715b484d1eec3fadbdf3dc79d0fc88f01af52 Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 11:46:55 2010 +0200 s4:samldb LDB module - remove "samldb_set_defaultObjectCategory" As far as I can tell and the test show the DN gets now normalised automatically when stored into the database. Anyway, if we find a case where this doesn't happen then I propose to do it centrally for all DN attributes in common since we should get away from special attribute hacks as far as possible. commit c8d2c5fff017a42ffb75aeaabfa19b8503b9e7af Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 15:33:29 2010 +0200 s4:ldap_backend.c - add some newlines to make logs easier to read commit d7ad7eed24108491bb86271f39ef233826f41352 Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 18:20:00 2010 +0200 ldb:pyldb.c - introduce a "mem_ctx" also on "py_ldb_search" To prevent memory leaks commit 00bf6084817046481e8d049357638387185c39ca Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 18:06:54 2010 +0200 ldb:pyldb.c - some cleanups and adequations also in "py_ldb_modify" and "py_ldb_rename" To make them consistent. commit 4cc49d365fa096e46259d6795b4626603919d69c Author: Matthias Dieter Wallnöfer Date: Sun Jun 20 18:46:51 2010 +0200 s4:ldap_controls.c - remove encoding functions for private recalculate SD control --- Summary of changes: source4/dsdb/common/util.c|7 ++ source4/dsdb/common/util.h|4 +- source4/dsdb/samdb/ldb_modules/samldb.c
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 0714e23... provision: Look for Samba prefix a bit harder. from a875616... Revert "s4:ldb-samba: fix the build without a system ldb" http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 0714e23971f701999f69ed85c65e4f3f33153a97 Author: Jelmer Vernooij Date: Sun Jun 20 17:46:39 2010 +0200 provision: Look for Samba prefix a bit harder. --- Summary of changes: source4/scripting/python/samba/provision.py | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/scripting/python/samba/provision.py b/source4/scripting/python/samba/provision.py index 804bbe7..cfba780 100644 --- a/source4/scripting/python/samba/provision.py +++ b/source4/scripting/python/samba/provision.py @@ -66,10 +66,12 @@ __docformat__ = "restructuredText" def find_setup_dir(): """Find the setup directory used by provision.""" import sys -for suffix in ["share/setup", "share/samba/setup", "setup"]: -ret = os.path.join(sys.prefix, suffix) -if os.path.isdir(ret): -return ret +for prefix in [sys.prefix, +os.path.join(os.path.dirname(__file__), "../../../..")]: +for suffix in ["share/setup", "share/samba/setup", "setup"]: +ret = os.path.join(prefix, suffix) +if os.path.isdir(ret): +return ret # In source tree dirname = os.path.dirname(__file__) ret = os.path.join(dirname, "../../../setup") -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via a875616... Revert "s4:ldb-samba: fix the build without a system ldb"
via e812832... s4:ldb: only do ABI checking for the standalone build
for now
from 52307a1... libpolicy: Fix the build.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit a87561613af3e54503f80d559227f836c17ed263
Author: Stefan Metzmacher
Date: Sun Jun 20 16:22:46 2010 +0200
Revert "s4:ldb-samba: fix the build without a system ldb"
This reverts commit 44c01a5eb45a0cd5ca3de8be5c4680de75418dce.
This caused problems when using a system ldb and as we don't
do ABI checks for ldb-samba4 any more, we don't need this change.
metze
Signed-off-by: Jelmer Vernooij
commit e812832db347269e46b28af31ff7ba3301405117
Author: Stefan Metzmacher
Date: Sun Jun 20 16:13:38 2010 +0200
s4:ldb: only do ABI checking for the standalone build for now
Otherwise we fail to build samba4 with a system ldb.
metze
Signed-off-by: Jelmer Vernooij
---
Summary of changes:
source4/lib/ldb-samba/wscript_build |5
source4/lib/ldb/wscript | 36 +++---
2 files changed, 24 insertions(+), 17 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/lib/ldb-samba/wscript_build
b/source4/lib/ldb-samba/wscript_build
index 970f495..a58316e 100644
--- a/source4/lib/ldb-samba/wscript_build
+++ b/source4/lib/ldb-samba/wscript_build
@@ -4,11 +4,6 @@
# as a built-in module and this delutes the symbols in the ldb library with
# the symbols of all of ldb_ildap's dependencies.
-# However, LDBSAMBA has to be a subsystem, otherwise we end up with an unusable
-# build when building against the system ldb.
-
-# When adding/modifying public symbols in LDBSAMBA, please make sure that
-# lib/ldb/ABI/ldb-samba-X.sigs gets updated.
bld.SAMBA_SUBSYSTEM('LDBSAMBA',
source='ldif_handlers.c ldb_wrap.c',
autoproto='ldif_handlers_proto.h',
diff --git a/source4/lib/ldb/wscript b/source4/lib/ldb/wscript
index df2245f..588b6fe 100644
--- a/source4/lib/ldb/wscript
+++ b/source4/lib/ldb/wscript
@@ -108,18 +108,30 @@ def build(bld):
if not bld.CONFIG_SET('USING_SYSTEM_LDB'):
modules_dir = bld.EXPAND_VARIABLES('${LDB_MODULESDIR}')
-bld.SAMBA_LIBRARY('ldb',
- COMMON_SRC + ' ' + LDB_MAP_SRC,
- deps='tevent',
- includes='include',
- public_headers='include/ldb.h include/ldb_errors.h '\
- 'include/ldb_module.h include/ldb_handlers.h',
- pc_files='ldb.pc',
- cflags='-DLDB_MODULESDIR=\"%s\"' % modules_dir,
- abi_file=abi_file,
- abi_match='!ldb_*module_ops !ldb_*backend_ops ldb_*',
- vnum=VERSION, manpages='man/ldb.3',
- is_bundled=not bld.env.standalone_ldb)
+if bld.env.standalone_ldb:
+bld.SAMBA_LIBRARY('ldb',
+ COMMON_SRC + ' ' + LDB_MAP_SRC,
+ deps='tevent',
+ includes='include',
+ public_headers='include/ldb.h
include/ldb_errors.h '\
+ 'include/ldb_module.h
include/ldb_handlers.h',
+ pc_files='ldb.pc',
+ cflags='-DLDB_MODULESDIR=\"%s\"' % modules_dir,
+ abi_file=abi_file,
+ abi_match='!ldb_*module_ops !ldb_*backend_ops
ldb_*',
+ vnum=VERSION, manpages='man/ldb.3',
+ is_bundled=not bld.env.standalone_ldb)
+else:
+bld.SAMBA_LIBRARY('ldb',
+ COMMON_SRC + ' ' + LDB_MAP_SRC,
+ deps='tevent',
+ includes='include',
+ public_headers='include/ldb.h
include/ldb_errors.h '\
+ 'include/ldb_module.h
include/ldb_handlers.h',
+ pc_files='ldb.pc',
+ cflags='-DLDB_MODULESDIR=\"%s\"' % modules_dir,
+ vnum=VERSION, manpages='man/ldb.3',
+ is_bundled=not bld.env.standalone_ldb)
bld.SAMBA_PYTHON('pyldb', 'pyldb.c',
deps='ldb pyldb_util',
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 52307a1... libpolicy: Fix the build. via e18a172... Add preliminary support for storing changed Group Policies. via 0413322... Refactor policy filesystem code. via b9b85d6... Fix memory allocation with error handling. via 9b5e0fe... Add talloc_frees in error cases in net_gpo.c via c09922c... Code cleanups: GUID generation, lp_dnsdomain instead of lp_realm, missing spaces. via 5c2c8df... Set inherit flag type to bool. via d61f024... Fix 'magic' numbers to be strlen(something) via e86ef68... Change talloc_steal to strdup because function might not expect it. via 674d559... Add GP ini functions. via 3fe793f... Remove iconv convenience in used functions, which were deleted in commit f9ca9e46ad24036bf00cb361a6cef4b2e7e98d7d via e1f2217... Fix net gpo list to use the dsdb with extended DN's. Fixes memberOf group memberships. via 3895b8f... Revert "Add old functionality back which was removed in commit 589a42e2." via 8f74ee0... Add ini parser for GPO's. via c36bd5d... Add net gpo setacl support. Create gp_set_acl function. Show ACL in net gpo show. via 5434171... Fix set GPT security descriptor to match windows' behaviour. via 31aeddf... Fix crash when get_gpo_info returns incorrect data. via 299531c... Add preliminary NT ACL support for GPT (GPO on filesystem). via 60bc5fe... samba4: Add python bindings for samba.policy.get_gplink_options. via 381e824... policy: Add samba.policy.get_gpo_flags binding. via 41fae89... Add gpo create functionality. Also fix gPLink handling bugs via 32ee6f8... Fix mode_t in mkdir. via 2941d2e... Finish net gpo fetch function. Reorder arguments to make them more understandable. Rename getgpo to show. via 2b761c3... Optimize the backslash logic in the path traversal. via f24f472... Fix error in logic, making recursion work past the first level. via 3b11a53... Add fetch function for GPO which fetches all relevant files from the sysvol share. via 6981448... Add getinheritance and setinheritance to net gpo util and library. via a4cb727... Implemented delete group policy link function and corresponding feature in net gpo. via f0353fd... Changed add_gplink to set_gplink, so we can change gPLink options as well. via 40d7181... Add add gPLink function and corresponding net gpo linkadd call. via a1fceac... Rename files to reflect the libpolicy naming convention. Also fix the GNU make build. via b025715... Rename libgpo to lib/policy to avoid confusion with samba3 and add waf build via 626db5c... Add old functionality back which was removed in commit 589a42e2. via 08a7bb4... Add gpo list function for listing applicable GPO's for users/machines. via 6478a1e... Add gPLink and getgpo functionality to net gpo. via 8d5f8f5... Created net gpo and new libgpo for samba 4. This adds the init function which finds a DC and connects to its LDAP. It also can return information on all group policy objects on a DC. from cfee179... s3: Attempt to fix the build on NetBSD http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 52307a11e1f0019f8fbdcce51676282aee21aa39 Author: Jelmer Vernooij Date: Sun Jun 20 15:50:12 2010 +0200 libpolicy: Fix the build. Signed-off-by: Jelmer Vernooij commit e18a172207b433a3f027541d4d5e98cea73dbcb6 Author: Wilco Baan Hofman Date: Mon Jun 7 15:21:53 2010 +0200 Add preliminary support for storing changed Group Policies. Signed-off-by: Jelmer Vernooij commit 04133225c1c3ab53191da50cae39f2019e7f7f01 Author: Wilco Baan Hofman Date: Tue May 25 01:21:45 2010 +0200 Refactor policy filesystem code. * It now uses reusable code to download the GPT. * It creates a list before copying for better error handling. * String_replace is now used instead of manually replacing '\\' with '/' for local paths. * A security check has been added for file names with "../". * It adheres to the 80 column rule, if at all possible. Signed-off-by: Jelmer Vernooij commit b9b85d6b0e23e042d60c83fef477fd4006a20c14 Author: Wilco Baan Hofman Date: Mon May 24 21:36:49 2010 +0200 Fix memory allocation with error handling. Also moved pypolicy.c headers around so as not to generate compile warnings Signed-off-by: Jelmer Vernooij commit 9b5e0fe6bb363aaaba513b0604476616d6cc9fd8 Author: Wilco Baan Hofman Date: Mon May 24 20:11:15 2010 +0200 Add talloc_frees in error cases in net_gpo.c Signed-off-by: Jelmer Vernooij commit c09922cfae1364f2ce8736ae59053805a337658b Author: Wilco Baan Hofman Date: Mon May 24 20:05:42 2010 +0200 Code cleanups: GUID
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via cfee179... s3: Attempt to fix the build on NetBSD
from 9e02764... pydsdb: Mark all SamDB and Schema methods that are in
pydsdb as private, to discourage them being called directly.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit cfee179d03e9c3b8d02a51995bd1c205daabb6c3
Author: Kai Blin
Date: Sun Jun 20 16:29:24 2010 +0200
s3: Attempt to fix the build on NetBSD
Unlike Linux and OSX, NetBSD seems to have *netgrent prototypes in
netgroup.h.
---
Summary of changes:
source3/configure.in |9 ++---
source3/wscript |6 +++---
2 files changed, 9 insertions(+), 6 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/configure.in b/source3/configure.in
index 04ddc03..424c320 100644
--- a/source3/configure.in
+++ b/source3/configure.in
@@ -6423,19 +6423,22 @@ AC_SUBST(FLAGS1)
CFLAGS_SAVE=$CFLAGS
CFLAGS="$CFLAGS -Werror-implicit-function-declaration"
AC_CACHE_CHECK([for setnetgrent prototype],samba_cv_setnetgrent_prototype, [
-AC_TRY_COMPILE([#include],[setnetgrent("foo")],
+AC_TRY_COMPILE([#include
+#include],[setnetgrent("foo")],
samba_cv_setnetgrent_prototype=yes,
samba_cv_setnetgrent_prototype=no)])
if test x"$samba_cv_setnetgrent_prototype" = x"yes"; then
AC_DEFINE(HAVE_SETNETGRENT_PROTOTYPE, 1, [If setnetgrent prototype is
defined])
fi
AC_CACHE_CHECK([for getnetgrent prototype],samba_cv_getnetgrent_prototype, [
-AC_TRY_COMPILE([#include],[char *dom, *user,*host;
getnetgrent(&dom,&user,&host)],
+AC_TRY_COMPILE([#include
+#include],[char *dom, *user,*host;
getnetgrent(&dom,&user,&host)],
samba_cv_getnetgrent_prototype=yes,
samba_cv_getnetgrent_prototype=no)])
if test x"$samba_cv_getnetgrent_prototype" = x"yes"; then
AC_DEFINE(HAVE_GETNETGRENT_PROTOTYPE, 1, [If getnetgrent prototype is
defined])
fi
AC_CACHE_CHECK([for endnetgrent prototype],samba_cv_endnetgrent_prototype, [
-AC_TRY_COMPILE([#include],[endnetgrent()],
+AC_TRY_COMPILE([#include
+#include],[endnetgrent()],
samba_cv_endnetgrent_prototype=yes,
samba_cv_endnetgrent_prototype=no)])
if test x"$samba_cv_endnetgrent_prototype" = x"yes"; then
AC_DEFINE(HAVE_ENDNETGRENT_PROTOTYPE, 1, [If endnetgrent prototype is
defined])
diff --git a/source3/wscript b/source3/wscript
index aec71af..0b31563 100644
--- a/source3/wscript
+++ b/source3/wscript
@@ -364,15 +364,15 @@ utimensat vsyslog _write __write __xstat
conf.CHECK_FUNCS('setnetgrent getnetgrent endnetgrent')
conf.CHECK_CODE('setnetgrent("foo")', 'HAVE_SETNETGRENT_PROTOTYPE',
msg="Checking for setnetgrent prototype",
-headers='netdb.h',
+headers='netdb.h netgroup.h',
cflags="-Werror-implicit-function-declaration")
conf.CHECK_CODE('getnetgrent', 'HAVE_GETNETGRENT_PROTOTYPE',
msg="Checking for getnetgrent prototype",
-headers='netdb.h',
+headers='netdb.h netgroup.h',
cflags="-Werror-implicit-function-declaration")
conf.CHECK_CODE('endnetgrent', 'HAVE_ENDNETGRENT_PROTOTYPE',
msg="Checking for endnetgrent prototype",
-headers='netdb.h',
+headers='netdb.h netgroup.h',
cflags="-Werror-implicit-function-declaration")
#FIXME: Should just be set when krb5 and ldap requirements are fulfilled
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 9e02764... pydsdb: Mark all SamDB and Schema methods that are in pydsdb as private, to discourage them being called directly. via 7b32f65... testparm: Check netbios name and workgroup characters and length. via 5f3d5a3... provision: Properly cancel transactions on the secrets ldb. via 237ab66... selftest: Use scripted testparm. via 7a064b9... pyparam: Support Loadparm.get(p, "global") via a2540fb... ldb: Add ABI file for use when including ildap in the build. via 08a3e8b... testparm: Simplify default option handling. via 338315f... pyparam: Allow specifying None as section name to LoadparmContext.get() to mean default section. via f0ab450... testparm: Fix suppress prompt option. via c0e9a41... testparm: Fix exit value, install. via de3f9e3... s4-python: Add LoadparmService.dump() via 74c66c9... s4-python: Implement LoadParm.dump(). via f051a85... testparm: Split up functions that do multiple things. via 0a07b8e... testparm: Convert to Python. via 8f383fc... s4-python: Remove more unused imports, fix use of sets in upgradehelpers. via 1e35ec4... setnttoken: Remove empty utility. via 3795358... Use standard Python syntax, booleans and set()'s where appropriate. via 66e27e5... Remove unnecessary use of transactions. via 9bcd0da... ldb: Change LDBSAMBA back to subsystem, update comments, use different ABI file based on whether ldb_ildap is included. from 44c01a5... s4:ldb-samba: fix the build without a system ldb http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 9e02764f7c34fd5c9686c7a754a30e9a6ae95769 Author: Jelmer Vernooij Date: Sun Jun 20 15:22:49 2010 +0200 pydsdb: Mark all SamDB and Schema methods that are in pydsdb as private, to discourage them being called directly. commit 7b32f65600988421dc8c825109e225612a3b6166 Author: Jelmer Vernooij Date: Sun Jun 20 15:04:42 2010 +0200 testparm: Check netbios name and workgroup characters and length. commit 5f3d5a3ad873feca66e118e020ed77189a7f2f9c Author: Jelmer Vernooij Date: Sun Jun 20 14:24:54 2010 +0200 provision: Properly cancel transactions on the secrets ldb. commit 237ab66f6c292b62b37af05771913b693b32d885 Author: Jelmer Vernooij Date: Sun Jun 20 14:14:47 2010 +0200 selftest: Use scripted testparm. commit 7a064b9960ab3cfb4ef76a939da7670aa34519a6 Author: Jelmer Vernooij Date: Sun Jun 20 14:14:01 2010 +0200 pyparam: Support Loadparm.get(p, "global") commit a2540fb3cbf8f288b106b03589d097212629b386 Author: Jelmer Vernooij Date: Sun Jun 20 13:54:51 2010 +0200 ldb: Add ABI file for use when including ildap in the build. commit 08a3e8b9f4d4d99cfca65752b0b516e0ec3f8651 Author: Jelmer Vernooij Date: Sun Jun 20 13:51:39 2010 +0200 testparm: Simplify default option handling. commit 338315f4d713e2648419f2eda805748901435204 Author: Jelmer Vernooij Date: Sun Jun 20 13:51:14 2010 +0200 pyparam: Allow specifying None as section name to LoadparmContext.get() to mean default section. commit f0ab4503d6204ede46fad1d7586ad5d655c1c6fa Author: Jelmer Vernooij Date: Sun Jun 20 13:47:36 2010 +0200 testparm: Fix suppress prompt option. commit c0e9a41f67f787f4fecec69dd661d92ecd24e608 Author: Jelmer Vernooij Date: Sun Jun 20 13:41:38 2010 +0200 testparm: Fix exit value, install. commit de3f9e31d34eac6ddc17e298299d5065f9a86e7c Author: Jelmer Vernooij Date: Sun Jun 20 13:40:49 2010 +0200 s4-python: Add LoadparmService.dump() commit 74c66c9a3f6aedbbcdbce66a1d72a3c3b74137f8 Author: Jelmer Vernooij Date: Sun Jun 20 13:29:35 2010 +0200 s4-python: Implement LoadParm.dump(). commit f051a8557f29352b4ec76ab6a8ed4de083f0816f Author: Jelmer Vernooij Date: Sun Jun 20 13:22:26 2010 +0200 testparm: Split up functions that do multiple things. commit 0a07b8ebfe797f062e50fbb901cd8040513af6d2 Author: Jelmer Vernooij Date: Sun Jun 20 13:16:30 2010 +0200 testparm: Convert to Python. commit 8f383fc5c8ca7190c719e58473d609cf9dce9444 Author: Jelmer Vernooij Date: Sun Jun 20 13:15:09 2010 +0200 s4-python: Remove more unused imports, fix use of sets in upgradehelpers. commit 1e35ec43f2dcf08446bdeb62aa6a03827666b154 Author: Jelmer Vernooij Date: Sun Jun 20 12:19:08 2010 +0200 setnttoken: Remove empty utility. commit 3795358aca56f0c961f48b84ffeea4dd286ab914 Author: Jelmer Vernooij Date: Sun Jun 20 12:06:50 2010 +0200 Use standard Python syntax, booleans and set()'s where appropriate. commit 66e27e5214180b473b848201d2dcc7ccc3ad2b04 Author: Jelmer Vernooij Date: Sun Jun 20 11:59:49 2010 +0200 Remove unnecessary use of transactions. commit 9bcd0daba2cdd2acd6fc0e3de44f5138f2f3303f Author: Jelmer Vernooij Date: Sun Jun 20 11:49:08 2010 +0200 ldb: Change
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 44c01a5... s4:ldb-samba: fix the build without a system ldb
from a453b87... s3-waf: Change the (set|get|end)netgrent checks to match
the configure.in checks
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 44c01a5eb45a0cd5ca3de8be5c4680de75418dce
Author: Stefan Metzmacher
Date: Sun Jun 20 11:33:43 2010 +0200
s4:ldb-samba: fix the build without a system ldb
metze
---
Summary of changes:
source4/lib/ldb-samba/wscript_build |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/lib/ldb-samba/wscript_build
b/source4/lib/ldb-samba/wscript_build
index 37cfce2..717a846 100644
--- a/source4/lib/ldb-samba/wscript_build
+++ b/source4/lib/ldb-samba/wscript_build
@@ -1,7 +1,11 @@
#!/usr/bin/env python
-bld.SAMBA_SUBSYSTEM('LDBSAMBA',
+# It is important that this is a library!
+# Otherwise samba specific symbols end up in
+# 'ldb' and we fail the ABI check, when not using
+# a system 'ldb'.
+bld.SAMBA_LIBRARY('LDBSAMBA',
source='ldif_handlers.c ldb_wrap.c',
autoproto='ldif_handlers_proto.h',
public_deps='ldb',
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via a453b87... s3-waf: Change the (set|get|end)netgrent checks to match
the configure.in checks
via ff32f69... s3 configure: Check for (set|get|end)netgrent prototypes
via fa3e50f... build: Allow for a custom message in CHECK_C_PROTOTYPE
from 1f07f53... ldb: Remove last import of dsdb.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit a453b87d68f89c48e0d0545fe240801e4eac1686
Author: Kai Blin
Date: Sun Jun 20 09:49:34 2010 +0200
s3-waf: Change the (set|get|end)netgrent checks to match the configure.in
checks
commit ff32f691bba41afab45efe7e21a2c91bb2c157bb
Author: Kai Blin
Date: Sun Jun 20 09:36:19 2010 +0200
s3 configure: Check for (set|get|end)netgrent prototypes
commit fa3e50fee421a7fe407510627e0fdbcd5f4013c0
Author: Kai Blin
Date: Thu Jun 17 22:41:57 2010 +0200
build: Allow for a custom message in CHECK_C_PROTOTYPE
---
Summary of changes:
buildtools/wafsamba/samba_conftests.py |6 --
source3/configure.in | 25 -
source3/wscript| 21 -
3 files changed, 40 insertions(+), 12 deletions(-)
Changeset truncated at 500 lines:
diff --git a/buildtools/wafsamba/samba_conftests.py
b/buildtools/wafsamba/samba_conftests.py
index a5c1b38..c95a887 100644
--- a/buildtools/wafsamba/samba_conftests.py
+++ b/buildtools/wafsamba/samba_conftests.py
@@ -34,17 +34,19 @@ def CHECK_LARGEFILE(conf, define='HAVE_LARGEFILE'):
@conf
-def CHECK_C_PROTOTYPE(conf, function, prototype, define, headers=None):
+def CHECK_C_PROTOTYPE(conf, function, prototype, define, headers=None,
msg=None):
'''verify that a C prototype matches the one on the current system'''
if not conf.CHECK_DECLS(function, headers=headers):
return False
+if not msg:
+msg = 'Checking C prototype for %s' % function
return conf.CHECK_CODE('%s; void *_x = (void *)%s' % (prototype, function),
define=define,
local_include=False,
headers=headers,
link=False,
execute=False,
- msg='Checking C prototype for %s' % function)
+ msg=msg)
@conf
diff --git a/source3/configure.in b/source3/configure.in
index cda14f5..04ddc03 100644
--- a/source3/configure.in
+++ b/source3/configure.in
@@ -6418,7 +6418,30 @@ AC_SUBST(BUILD_INIPARSER)
AC_SUBST(INIPARSERLIBS)
AC_SUBST(FLAGS1)
-
+###
+# Check for different/missing (set|get|end)netgrent prototypes
+CFLAGS_SAVE=$CFLAGS
+CFLAGS="$CFLAGS -Werror-implicit-function-declaration"
+AC_CACHE_CHECK([for setnetgrent prototype],samba_cv_setnetgrent_prototype, [
+AC_TRY_COMPILE([#include],[setnetgrent("foo")],
+samba_cv_setnetgrent_prototype=yes,
samba_cv_setnetgrent_prototype=no)])
+if test x"$samba_cv_setnetgrent_prototype" = x"yes"; then
+AC_DEFINE(HAVE_SETNETGRENT_PROTOTYPE, 1, [If setnetgrent prototype is
defined])
+fi
+AC_CACHE_CHECK([for getnetgrent prototype],samba_cv_getnetgrent_prototype, [
+AC_TRY_COMPILE([#include],[char *dom, *user,*host;
getnetgrent(&dom,&user,&host)],
+samba_cv_getnetgrent_prototype=yes,
samba_cv_getnetgrent_prototype=no)])
+if test x"$samba_cv_getnetgrent_prototype" = x"yes"; then
+AC_DEFINE(HAVE_GETNETGRENT_PROTOTYPE, 1, [If getnetgrent prototype is
defined])
+fi
+AC_CACHE_CHECK([for endnetgrent prototype],samba_cv_endnetgrent_prototype, [
+AC_TRY_COMPILE([#include],[endnetgrent()],
+samba_cv_endnetgrent_prototype=yes,
samba_cv_endnetgrent_prototype=no)])
+if test x"$samba_cv_endnetgrent_prototype" = x"yes"; then
+AC_DEFINE(HAVE_ENDNETGRENT_PROTOTYPE, 1, [If endnetgrent prototype is
defined])
+fi
+
+CFLAGS=$CFLAGS_SAVE
# Checks for the vfs_fileid module
# Start
diff --git a/source3/wscript b/source3/wscript
index 9bbedea..aec71af 100644
--- a/source3/wscript
+++ b/source3/wscript
@@ -362,15 +362,18 @@ utimensat vsyslog _write __write __xstat
define='HAVE_DIRENT_D_OFF')
conf.CHECK_FUNCS('setnetgrent getnetgrent endnetgrent')
-conf.CHECK_C_PROTOTYPE('setnetgrent',
- 'extern int setnetgrent(const char* netgroup)',
- define='HAVE_SETNETGRENT_PROTOTYPE',
headers='netdb.h')
-conf.CHECK_C_PROTOTYPE('getnetgrent',
- 'extern int getnetgrent(char **host, char **user,
char **domain)',
- define='HAVE_GETNETGRENT_PROTOTYPE',
headers='netdb.h')
-conf.CHECK_C_PROTOTYPE('endnetgrent',
- 'extern void endnetgrent(void)',
-
