Build status as of Fri Oct 29 06:00:02 2010
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2010-10-28 00:00:04.0 -0600 +++ /home/build/master/cache/broken_results.txt 2010-10-29 00:00:03.0 -0600 @@ -1,4 +1,4 @@ -Build status as of Thu Oct 28 06:00:02 2010 +Build status as of Fri Oct 29 06:00:02 2010 Build counts: Tree Total Broken Panic @@ -15,8 +15,8 @@ samba-web0 0 0 samba_3_current 32 30 3 samba_3_master 32 19 0 -samba_3_next 32 31 0 -samba_4_0_test 37 28 0 +samba_3_next 32 30 0 +samba_4_0_test 37 30 0 talloc 32 9 0 tdb 30 11 0
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 4a11cad build: add the -fno-common flags to fix the link pb on mac os X from 090fcb0 s3-waf: add vfs_time_audit to the build. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 4a11cad0e063431eec9cfce385ebacdb22279712 Author: Matthieu Patou Date: Fri Oct 29 01:52:32 2010 +0400 build: add the -fno-common flags to fix the link pb on mac os X Autobuild-User: Matthieu Patou Autobuild-Date: Thu Oct 28 22:35:08 UTC 2010 on sn-devel-104 --- Summary of changes: buildtools/wafsamba/wscript |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/buildtools/wafsamba/wscript b/buildtools/wafsamba/wscript index 4c9c3e7..7c40c8c 100644 --- a/buildtools/wafsamba/wscript +++ b/buildtools/wafsamba/wscript @@ -271,6 +271,8 @@ def configure(conf): else: conf.ADD_CFLAGS('-fPIC', testflags=True) +if sys.platform == 'darwin': +conf.ADD_LDFLAGS('-fno-common', testflags=True) conf.CHECK_INLINE() # check for pkgconfig -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 6e7e7bb s3:registry: move regio.h from include/ to registry/ via 5727944 s3:registry: move the reg_db.h from include/ to registry/ via 70204f6 s3:registry: move prototype from reg_init_smbconf.c to its own header. via a74b734 s3:registry: move prototype from reg_init_full.c to its own header. via f0599af s3:registry: move prototypes from reg_init_basic.c to their own header. via a64095c s3:registry: move reg_api_regf prototypes to their own header file. via 378f481 s3:registry: move the reg_api prototypes to their own header. via 9fcf1f0 s3:registry:reg_api: update (C) via e45d0b7 s3:services_db: convert get_common_service_dispname() to talloc via 020df4a s3:registry: regfio fix the build via cca1ae4 s3:registry: remove now (finally) obsolete reg_util_registry.{c,h} via 4260ef9 s3:services_db: does not need legacy registry code any more. via 798e847 s3:services_db: rewrite svcctl_init_keys() to use reg_api calls instead of legacy via 2f6ee60 s3:services_db: extract core of svcctl_set_secdesc to _internal version via 08146db s3:services_db: create the "Security" subkey if it does not exist in svcctl_set_secdesc() via 9407bbd s3:services_db: remove bogus comments via f573c8a s3:services_db: remove unused legacy function svcctl_fetch_regvalues(). via 7d62c97 s3:rpc_server:ntsvcs: registry is not directly used an more. via ad4d9a2 s3:rpc_server:ntsvcs: use svcctl_lookup_dispname instead of legacy svcctl in _PNP_GetDeviceRegProp via 94d448d s3:rpc_server: registry is not direclty used in the svcctl server any more via 0019d2c s3:srv_ntsvcs_nt: make fill_svc_config() use svcctl_get_string_value() via 02c1ed2 s3:services_db: publish svcctl_get_string_value() via 89255c0 s3:services_db: factor out common code of lookup_dispname and lookup_description via c4b1f96 s3:services_db: change svcctl_lookup_description() to use reg_api functions via e5c2593 s3:services_db: rewrite svcctl_lookup_description() to use a tmp talloc ctx via 74b9ec1 s3:services_db: change svcctl_lookup_dispname() to use reg_api functions via c671942 s3:services_db: make svcctl_lookup_dispname() use a temp talloc ctx via 5e9df32 s3:services_db: change svcctl_get_secdesc() to use reg_api functions via c05cf4c s3:services_db: use temp talloc ctx in svcctl_get_secdesc() via 525bc57 s3:services_db: remove the TALLOC_CTX argument from svcctl_set_secdesc via 3b03e66 s3:services_db: fix a debug message via 3a2de89 s3:services_db: rewrite svcctl_set_secdesc to use tmp talloc ctx via 275f5bf s3:services_db: rewrite svcctl_set_secdesc() using reg_api calls instead of legacy via fa7abb8 s3:services_db: untanlge assignments from check in read_init_file(). via 97a9e13 s3:services_db: untangle assignments from check in construct_service_sd(). via 8f23cc8 s3:registry: move prototypes of unused hilvl functions to ret_api_util.h and comment them out via 77fdb9c s3:registry: move (commented out) hilvl util functions to reg_api_util.c via c299a3c s3:registry: move higher level function reg_open_path to new module reg_api_util from 0e8b6f2 s3: Streamline regdb_normalize_keynames_fn a bit http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 6e7e7bbcf8ebbb742e52f9001b19db785c640f2e Author: Michael Adam Date: Tue Sep 21 09:08:33 2010 +0200 s3:registry: move regio.h from include/ to registry/ commit 57279442344edc6d9c42edd6f77627ee47f03550 Author: Michael Adam Date: Tue Sep 21 08:53:49 2010 +0200 s3:registry: move the reg_db.h from include/ to registry/ commit 70204f6d24275e02b90ec1d13facd6476a02504d Author: Michael Adam Date: Tue Sep 21 08:50:54 2010 +0200 s3:registry: move prototype from reg_init_smbconf.c to its own header. commit a74b73447dc49619a71904c4cadcc5a9b4e4082f Author: Michael Adam Date: Tue Sep 21 08:45:06 2010 +0200 s3:registry: move prototype from reg_init_full.c to its own header. commit f0599afe42087766e7c7e571f3e1e849fce1772f Author: Michael Adam Date: Tue Sep 21 08:37:14 2010 +0200 s3:registry: move prototypes from reg_init_basic.c to their own header. commit a64095c309de4cd0a251baf1cabdfa3594d4c436 Author: Michael Adam Date: Tue Sep 21 08:23:20 2010 +0200 s3:registry: move reg_api_regf prototypes to their own header file. These two calls are currently only used in the WINREG rpc server. And this reqires linking in the regfio code. commit 378f481962cea8899dee1b9167a634d7905f0b93 Author: Michael Adam Date: Tue Sep 21 08:11:18 2010 +0200 s3:registry: move the reg_api prototypes to their own header. commit 9fcf1f0330
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 090fcb0 s3-waf: add vfs_time_audit to the build. via e00671e s3-waf: use LZXPRESS subsystem. via 9dd467b s3-selftest: add vfs_modulesdir variable for both test systems. from 4b2e2f9 s3: Streamline regdb_normalize_keynames_fn a bit http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 090fcb011485411d887b94c7c2a53e398766cfc9 Author: Günther Deschner Date: Thu Oct 28 15:59:36 2010 +0200 s3-waf: add vfs_time_audit to the build. Guenther Autobuild-User: Günther Deschner Autobuild-Date: Thu Oct 28 15:14:27 UTC 2010 on sn-devel-104 commit e00671ee0c5ce1754bf041f2cd4abeacd1dedc61 Author: Günther Deschner Date: Wed Oct 27 16:31:05 2010 +0200 s3-waf: use LZXPRESS subsystem. Guenther commit 9dd467b2d578434c14e4a057fd27d36aafed8563 Author: Günther Deschner Date: Tue Oct 26 15:26:17 2010 +0200 s3-selftest: add vfs_modulesdir variable for both test systems. Guenther --- Summary of changes: selftest/target/Samba3.pm|3 ++- source3/modules/wscript_build|8 source3/script/tests/selftest.sh |3 ++- source3/wscript |3 ++- source3/wscript_build|4 ++-- 5 files changed, 16 insertions(+), 5 deletions(-) Changeset truncated at 500 lines: diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm index c03e188..4c554b5 100644 --- a/selftest/target/Samba3.pm +++ b/selftest/target/Samba3.pm @@ -356,6 +356,7 @@ sub provision($$) my $prefix_abs = abs_path($prefix); my $bindir_abs = abs_path($self->{bindir}); + my $vfs_modulesdir_abs = $bindir_abs; my @dirs = (); @@ -530,7 +531,7 @@ sub provision($$) map readonly = no store dos attributes = yes create mask = 755 - vfs objects = $bindir_abs/xattr_tdb.so $bindir_abs/streams_depot.so + vfs objects = $vfs_modulesdir_abs/xattr_tdb.so $vfs_modulesdir_abs/streams_depot.so printing = vlp print command = $bindir_abs/vlp tdbfile=$lockdir/vlp.tdb print %p %s diff --git a/source3/modules/wscript_build b/source3/modules/wscript_build index d916ec9..8b6af85 100644 --- a/source3/modules/wscript_build +++ b/source3/modules/wscript_build @@ -48,6 +48,7 @@ VFS_DIRSORT_SRC = 'vfs_dirsort.c' VFS_SCANNEDONLY_SRC = 'vfs_scannedonly.c' VFS_CROSSRENAME_SRC = 'vfs_crossrename.c' VFS_LINUX_XFS_SGID_SRC = 'vfs_linux_xfs_sgid.c' +VFS_TIME_AUDIT_SRC = 'vfs_time_audit.c' bld.SAMBA_SUBSYSTEM('NFS4_ACLS', @@ -392,6 +393,13 @@ bld.SAMBA_MODULE('vfs_linux_xfs_sgid', internal_module=bld.SAMBA3_IS_STATIC_MODULE('VFS_LINUX_XFS_SGID'), enabled=bld.SAMBA3_IS_ENABLED_MODULE('VFS_LINUX_XFS_SGID')) +bld.SAMBA_MODULE('vfs_time_audit', + subsystem='vfs', + source=VFS_TIME_AUDIT_SRC, + init_function='', + internal_module=bld.SAMBA3_IS_STATIC_MODULE('VFS_TIME_AUDIT'), + enabled=bld.SAMBA3_IS_ENABLED_MODULE('VFS_TIME_AUDIT')) + CHARSET_WEIRD_SRC = 'weird.c' diff --git a/source3/script/tests/selftest.sh b/source3/script/tests/selftest.sh index fba43e3..e68f208 100755 --- a/source3/script/tests/selftest.sh +++ b/source3/script/tests/selftest.sh @@ -87,6 +87,7 @@ SRCDIR="`dirname $0`/../.." BINDIR="`pwd`/bin" SCRIPTDIR=$SRCDIR/script/tests LIBDIR=$PREFIX_ABS/lib +VFS_MODULESDIR=$BINDIR PIDDIR=$PREFIX_ABS/pid CONFFILE=$LIBDIR/client.conf SAMBA4CONFFILE=$LIBDIR/samba4client.conf @@ -329,7 +330,7 @@ cat >$SERVERCONFFILE<
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 4b2e2f9 s3: Streamline regdb_normalize_keynames_fn a bit via 8b87603 s3: Fix the registry upgrade code from a43261e s3: FILE_WRITE_DATA & friends have gone from includes.h http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 4b2e2f94bb505f3de6411cfc8e01d05b010a2819 Author: Volker Lendecke Date: Thu Oct 28 15:41:30 2010 +0200 s3: Streamline regdb_normalize_keynames_fn a bit Autobuild-User: Volker Lendecke Autobuild-Date: Thu Oct 28 14:32:11 UTC 2010 on sn-devel-104 commit 8b87603de4f40c341d23262b4ffe357248ac4ff3 Author: Volker Lendecke Date: Thu Oct 28 15:30:21 2010 +0200 s3: Fix the registry upgrade code The strings have the 0-terminator as part of the keys. The rest of the registry code would not cope well without. --- Summary of changes: source3/registry/reg_backend_db.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/registry/reg_backend_db.c b/source3/registry/reg_backend_db.c index 43fe374..322cabf 100644 --- a/source3/registry/reg_backend_db.c +++ b/source3/registry/reg_backend_db.c @@ -417,10 +417,8 @@ static int regdb_normalize_keynames_fn(struct db_record *rec, (const char *) rec->key.dptr, keyname)); - new_rec.value.dptr = rec->value.dptr; - new_rec.value.dsize = rec->value.dsize; - new_rec.key.dptr = (unsigned char *) keyname; - new_rec.key.dsize = strlen(keyname); + new_rec.value = rec->value; + new_rec.key = string_term_tdb_data(keyname); new_rec.private_data = rec->private_data; /* Delete the original record and store the normalized key */ -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 0e8b6f2 s3: Streamline regdb_normalize_keynames_fn a bit via 26ae187 s3: Fix the registry upgrade code from 7543ee4 s3: Add a vfs_time_audit module http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 0e8b6f251efcc7d899e06f0d1708d5113d042840 Author: Volker Lendecke Date: Thu Oct 28 15:41:30 2010 +0200 s3: Streamline regdb_normalize_keynames_fn a bit commit 26ae187915556b66b1a112187400043f05c11135 Author: Volker Lendecke Date: Thu Oct 28 15:30:21 2010 +0200 s3: Fix the registry upgrade code The strings have the 0-terminator as part of the keys. The rest of the registry code would not cope well without. --- Summary of changes: source3/registry/reg_backend_db.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/registry/reg_backend_db.c b/source3/registry/reg_backend_db.c index 3fdea10..195f513 100644 --- a/source3/registry/reg_backend_db.c +++ b/source3/registry/reg_backend_db.c @@ -416,10 +416,8 @@ static int regdb_normalize_keynames_fn(struct db_record *rec, (const char *) rec->key.dptr, keyname)); - new_rec.value.dptr = rec->value.dptr; - new_rec.value.dsize = rec->value.dsize; - new_rec.key.dptr = (unsigned char *) keyname; - new_rec.key.dsize = strlen(keyname); + new_rec.value = rec->value; + new_rec.key = string_term_tdb_data(keyname); new_rec.private_data = rec->private_data; /* Delete the original record and store the normalized key */ -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via a43261e s3: FILE_WRITE_DATA & friends have gone from includes.h from 917cc0d unit tests: use skip file to exclude smb2.dir instead of hack http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit a43261e11d92360ef4060cd3559aeab9ebac95fd Author: Volker Lendecke Date: Thu Oct 28 07:50:37 2010 -0600 s3: FILE_WRITE_DATA & friends have gone from includes.h Autobuild-User: Volker Lendecke Autobuild-Date: Thu Oct 28 13:37:06 UTC 2010 on sn-devel-104 --- Summary of changes: source3/modules/gpfs.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/modules/gpfs.c b/source3/modules/gpfs.c index cad765e..493e1fb 100644 --- a/source3/modules/gpfs.c +++ b/source3/modules/gpfs.c @@ -21,6 +21,7 @@ #ifdef HAVE_GPFS +#include "libcli/security/security.h" #include "gpfs_gpl.h" #include "vfs_gpfs.h" -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 917cc0d unit tests: use skip file to exclude smb2.dir instead of hack via 95cbff7 build: Add XPG6 otherwise we have a configure pb on sun Solaris from 2cfee00 s3: Add a vfs_time_audit module http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 917cc0db0ce40b555ef3f752e5a546373316b162 Author: Matthieu Patou Date: Thu Oct 28 12:20:28 2010 +0400 unit tests: use skip file to exclude smb2.dir instead of hack Thanks metze for pointing this. Autobuild-User: Matthieu Patou Autobuild-Date: Thu Oct 28 09:39:11 UTC 2010 on sn-devel-104 commit 95cbff76d6b88174806205fe6a1ad4a91c8d92c6 Author: Matthieu Patou Date: Thu Oct 28 12:09:29 2010 +0400 build: Add XPG6 otherwise we have a configure pb on sun Solaris --- Summary of changes: buildtools/wafsamba/wscript |1 + source4/selftest/skip |1 + source4/selftest/tests.py |2 +- 3 files changed, 3 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/buildtools/wafsamba/wscript b/buildtools/wafsamba/wscript index f134c07..4c9c3e7 100644 --- a/buildtools/wafsamba/wscript +++ b/buildtools/wafsamba/wscript @@ -267,6 +267,7 @@ def configure(conf): # define even during the tests otherwise detection of # boolean is broken conf.DEFINE('_STDC_C99', 1, add_to_cflags=True) +conf.DEFINE('_XPG6', 1, add_to_cflags=True) else: conf.ADD_CFLAGS('-fPIC', testflags=True) diff --git a/source4/selftest/skip b/source4/selftest/skip index e03234b..671269a 100644 --- a/source4/selftest/skip +++ b/source4/selftest/skip @@ -32,6 +32,7 @@ smb2.notify smb2.scan smb2.lease smb2.durable.open +smb2.dir ntvfs.cifs.base.charset ntvfs.cifs.base.iometer ntvfs.cifs.base.casetable diff --git a/source4/selftest/tests.py b/source4/selftest/tests.py index a252a87..9d4d2b3 100755 --- a/source4/selftest/tests.py +++ b/source4/selftest/tests.py @@ -314,7 +314,7 @@ plantestsuite_loadlist("samba4.ntp.signd", "dc:local", [smb4torture, 'ncacn_np:$ # Tests against the NTVFS POSIX backend ntvfsargs = ["--option=torture:sharedelay=1", "--option=torture:oplocktimeout=3", "--option=torture:writetimeupdatedelay=5"] -smb2 = filter(lambda x: "SMB2-DIR" not in x, smb4torture_testsuites("SMB2-")) +smb2 = smb4torture_testsuites("SMB2-") #The QFILEINFO-IPC test needs to be on ipc$ raw = filter(lambda x: "RAW-QFILEINFO-IPC" not in x, smb4torture_testsuites("RAW-")) base = smb4torture_testsuites("BASE-") -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 7543ee4 s3: Add a vfs_time_audit module via 4a6d708 s3: Fix bug 7759 from d7ea0f9 Fix for bug 7755 - SMBC_getdents_ctx() ignores struct alignment rules http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 7543ee478021db6f3a6bbdebc897a09aea565876 Author: Abhidnya P Chirmule Date: Wed Jan 6 19:45:24 2010 +0100 s3: Add a vfs_time_audit module This warns if a file system is slow Autobuild-User: Volker Lendecke Autobuild-Date: Thu Oct 28 08:56:44 UTC 2010 on sn-devel-104 commit 4a6d70875ab0923b3888d5f4e0b43de83b74983f Author: Volodymyr Khomenko Date: Thu Oct 28 09:34:05 2010 +0200 s3: Fix bug 7759 --- Summary of changes: packaging/RHEL-CTDB/samba.spec.tmpl |1 + source3/Makefile.in |5 + source3/configure.in|2 + source3/modules/vfs_default.c | 34 +- source3/modules/vfs_time_audit.c| 2306 +++ 5 files changed, 2332 insertions(+), 16 deletions(-) create mode 100644 source3/modules/vfs_time_audit.c Changeset truncated at 500 lines: diff --git a/packaging/RHEL-CTDB/samba.spec.tmpl b/packaging/RHEL-CTDB/samba.spec.tmpl index 2f32d3d..7ff37fb 100644 --- a/packaging/RHEL-CTDB/samba.spec.tmpl +++ b/packaging/RHEL-CTDB/samba.spec.tmpl @@ -495,6 +495,7 @@ exit 0 %{_libarchdir}/samba/vfs/streams_depot.so %{_libarchdir}/samba/vfs/streams_xattr.so %{_libarchdir}/samba/vfs/syncops.so +%{_libarchdir}/samba/vfs/time_audit.so %{_libarchdir}/samba/vfs/tsmsm.so %{_libarchdir}/samba/vfs/xattr_tdb.so diff --git a/source3/Makefile.in b/source3/Makefile.in index 45dd891..d44bd6f 100644 --- a/source3/Makefile.in +++ b/source3/Makefile.in @@ -814,6 +814,7 @@ VFS_DIRSORT_OBJ = modules/vfs_dirsort.o VFS_SCANNEDONLY_OBJ = modules/vfs_scannedonly.o VFS_CROSSRENAME_OBJ = modules/vfs_crossrename.o VFS_LINUX_XFS_SGID_OBJ = modules/vfs_linux_xfs_sgid.o +VFS_TIME_AUDIT_OBJ = modules/vfs_time_audit.o PLAINTEXT_AUTH_OBJ = auth/pampass.o auth/pass_check.o @@ -2988,6 +2989,10 @@ bin/linux_xfs_sg...@shlibext@: $(BINARY_PREREQS) $(VFS_LINUX_XFS_SGID_OBJ) @echo "Building plugin $@" @$(SHLD_MODULE) $(VFS_LINUX_XFS_SGID_OBJ) +bin/time_aud...@shlibext@: $(BINARY_PREREQS) $(VFS_TIME_AUDIT_OBJ) + @echo "Building plugin $@" + @$(SHLD_MODULE) $(VFS_TIME_AUDIT_OBJ) + # ## IdMap NSS plugins diff --git a/source3/configure.in b/source3/configure.in index 2bc9137..6b6dabb 100644 --- a/source3/configure.in +++ b/source3/configure.in @@ -459,6 +459,7 @@ default_shared_modules="$default_shared_modules vfs_catia" default_shared_modules="$default_shared_modules vfs_scannedonly" default_shared_modules="$default_shared_modules vfs_crossrename" default_shared_modules="$default_shared_modules vfs_linux_xfs_sgid" +default_shared_modules="$default_shared_modules vfs_time_audit" if test "x$developer" = xyes; then default_static_modules="$default_static_modules rpc_rpcecho pdb_ads" @@ -6763,6 +6764,7 @@ SMB_MODULE(vfs_dirsort, \$(VFS_DIRSORT_OBJ), "bin/dirsort.$SHLIBEXT", VFS) SMB_MODULE(vfs_scannedonly, \$(VFS_SCANNEDONLY_OBJ), "bin/scannedonly.$SHLIBEXT", VFS) SMB_MODULE(vfs_crossrename, \$(VFS_CROSSRENAME_OBJ), "bin/crossrename.$SHLIBEXT", VFS) SMB_MODULE(vfs_linux_xfs_sgid, \$(VFS_LINUX_XFS_SGID_OBJ), "bin/linux_xfs_sgid.$SHLIBEXT", VFS) +SMB_MODULE(vfs_time_audit, \$(VFS_TIME_AUDIT_OBJ), "bin/time_audit.$SHLIBEXT", VFS) SMB_SUBSYSTEM(VFS,smbd/vfs.o) diff --git a/source3/modules/vfs_default.c b/source3/modules/vfs_default.c index 2cbb84c..6f5b09a 100644 --- a/source3/modules/vfs_default.c +++ b/source3/modules/vfs_default.c @@ -754,25 +754,27 @@ static int vfswrap_ntimes(vfs_handle_struct *handle, goto out; } - if (null_timespec(ft->atime)) { - ft->atime= smb_fname->st.st_ex_atime; - } + if (ft != NULL) { + if (null_timespec(ft->atime)) { + ft->atime= smb_fname->st.st_ex_atime; + } - if (null_timespec(ft->mtime)) { - ft->mtime = smb_fname->st.st_ex_mtime; - } + if (null_timespec(ft->mtime)) { + ft->mtime = smb_fname->st.st_ex_mtime; + } - if (!null_timespec(ft->create_time)) { - set_create_timespec_ea(handle->conn, - smb_fname, - ft->create_time); - } + if (!null_timespec(ft->create_time)) { + set_create_timespec_ea(handle->conn, + smb_fname, + ft->create_time); + } - if ((tim
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 2cfee00 s3: Add a vfs_time_audit module via 9759559 s3: Fix bug 7759 from b73a05e s4 net: rename to samba-tool in order to not clash with s3 net http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 2cfee006e13d661c9aed68a104db62f487f3e889 Author: Abhidnya P Chirmule Date: Wed Jan 6 19:45:24 2010 +0100 s3: Add a vfs_time_audit module This warns if a file system is slow Autobuild-User: Volker Lendecke Autobuild-Date: Thu Oct 28 08:56:44 UTC 2010 on sn-devel-104 commit 97595597a32900aa064b88f7b5473df3064a6ee4 Author: Volodymyr Khomenko Date: Thu Oct 28 09:34:05 2010 +0200 s3: Fix bug 7759 --- Summary of changes: packaging/RHEL-CTDB/samba.spec.tmpl |1 + source3/Makefile.in |5 + source3/configure.in|2 + source3/modules/vfs_default.c | 34 +- source3/modules/vfs_time_audit.c| 2306 +++ 5 files changed, 2332 insertions(+), 16 deletions(-) create mode 100644 source3/modules/vfs_time_audit.c Changeset truncated at 500 lines: diff --git a/packaging/RHEL-CTDB/samba.spec.tmpl b/packaging/RHEL-CTDB/samba.spec.tmpl index 2f32d3d..7ff37fb 100644 --- a/packaging/RHEL-CTDB/samba.spec.tmpl +++ b/packaging/RHEL-CTDB/samba.spec.tmpl @@ -495,6 +495,7 @@ exit 0 %{_libarchdir}/samba/vfs/streams_depot.so %{_libarchdir}/samba/vfs/streams_xattr.so %{_libarchdir}/samba/vfs/syncops.so +%{_libarchdir}/samba/vfs/time_audit.so %{_libarchdir}/samba/vfs/tsmsm.so %{_libarchdir}/samba/vfs/xattr_tdb.so diff --git a/source3/Makefile.in b/source3/Makefile.in index b287784..411a4c5 100644 --- a/source3/Makefile.in +++ b/source3/Makefile.in @@ -828,6 +828,7 @@ VFS_DIRSORT_OBJ = modules/vfs_dirsort.o VFS_SCANNEDONLY_OBJ = modules/vfs_scannedonly.o VFS_CROSSRENAME_OBJ = modules/vfs_crossrename.o VFS_LINUX_XFS_SGID_OBJ = modules/vfs_linux_xfs_sgid.o +VFS_TIME_AUDIT_OBJ = modules/vfs_time_audit.o PLAINTEXT_AUTH_OBJ = auth/pampass.o auth/pass_check.o @@ -3010,6 +3011,10 @@ bin/linux_xfs_sg...@shlibext@: $(BINARY_PREREQS) $(VFS_LINUX_XFS_SGID_OBJ) @echo "Building plugin $@" @$(SHLD_MODULE) $(VFS_LINUX_XFS_SGID_OBJ) +bin/time_aud...@shlibext@: $(BINARY_PREREQS) $(VFS_TIME_AUDIT_OBJ) + @echo "Building plugin $@" + @$(SHLD_MODULE) $(VFS_TIME_AUDIT_OBJ) + # ## IdMap NSS plugins diff --git a/source3/configure.in b/source3/configure.in index 2db1b39..e67a262 100644 --- a/source3/configure.in +++ b/source3/configure.in @@ -459,6 +459,7 @@ default_shared_modules="$default_shared_modules vfs_catia" default_shared_modules="$default_shared_modules vfs_scannedonly" default_shared_modules="$default_shared_modules vfs_crossrename" default_shared_modules="$default_shared_modules vfs_linux_xfs_sgid" +default_shared_modules="$default_shared_modules vfs_time_audit" if test "x$developer" = xyes; then default_static_modules="$default_static_modules rpc_rpcecho pdb_ads" @@ -6763,6 +6764,7 @@ SMB_MODULE(vfs_dirsort, \$(VFS_DIRSORT_OBJ), "bin/dirsort.$SHLIBEXT", VFS) SMB_MODULE(vfs_scannedonly, \$(VFS_SCANNEDONLY_OBJ), "bin/scannedonly.$SHLIBEXT", VFS) SMB_MODULE(vfs_crossrename, \$(VFS_CROSSRENAME_OBJ), "bin/crossrename.$SHLIBEXT", VFS) SMB_MODULE(vfs_linux_xfs_sgid, \$(VFS_LINUX_XFS_SGID_OBJ), "bin/linux_xfs_sgid.$SHLIBEXT", VFS) +SMB_MODULE(vfs_time_audit, \$(VFS_TIME_AUDIT_OBJ), "bin/time_audit.$SHLIBEXT", VFS) SMB_SUBSYSTEM(VFS,smbd/vfs.o) diff --git a/source3/modules/vfs_default.c b/source3/modules/vfs_default.c index 2cbb84c..6f5b09a 100644 --- a/source3/modules/vfs_default.c +++ b/source3/modules/vfs_default.c @@ -754,25 +754,27 @@ static int vfswrap_ntimes(vfs_handle_struct *handle, goto out; } - if (null_timespec(ft->atime)) { - ft->atime= smb_fname->st.st_ex_atime; - } + if (ft != NULL) { + if (null_timespec(ft->atime)) { + ft->atime= smb_fname->st.st_ex_atime; + } - if (null_timespec(ft->mtime)) { - ft->mtime = smb_fname->st.st_ex_mtime; - } + if (null_timespec(ft->mtime)) { + ft->mtime = smb_fname->st.st_ex_mtime; + } - if (!null_timespec(ft->create_time)) { - set_create_timespec_ea(handle->conn, - smb_fname, - ft->create_time); - } + if (!null_timespec(ft->create_time)) { + set_create_timespec_ea(handle->conn, + smb_fname, + ft->create_time); + } - if ((timespec_compare
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via b73a05e s4 net: rename to samba-tool in order to not clash with s3 net from 5634f55 build: remove warnings about redifinition of boolean use -KPIC on suncc http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit b73a05e4e184238614d73c1519f2880cd946908d Author: Kai Blin Date: Sat Oct 23 19:27:26 2010 -0700 s4 net: rename to samba-tool in order to not clash with s3 net Autobuild-User: Kai Blin Autobuild-Date: Thu Oct 28 07:25:16 UTC 2010 on sn-devel-104 --- Summary of changes: selftest/target/Samba4.pm | 22 +- source4/samba_tool/drs/drs.c| 361 source4/samba_tool/drs/drs.h| 87 source4/samba_tool/drs/drs_bind.c | 136 ++ source4/samba_tool/drs/drs_kcc.c| 170 source4/samba_tool/drs/drs_replicate.c | 252 +++ source4/samba_tool/drs/drs_showrepl.c | 605 ++ source4/samba_tool/gpo.c| 618 +++ source4/samba_tool/password.c | 171 source4/samba_tool/samba_tool.c | 387 + source4/samba_tool/samba_tool.h | 39 ++ source4/samba_tool/vampire.c| 130 ++ source4/samba_tool/wscript_build| 17 + source4/selftest/skip |2 +- source4/selftest/tests.py |2 +- source4/setup/tests/blackbox_group.sh | 78 ++-- source4/setup/tests/blackbox_newuser.sh | 22 +- source4/setup/tests/blackbox_setpassword.sh | 10 +- source4/setup/tests/blackbox_spn.sh | 24 +- source4/torture/drs/python/delete_object.py |8 +- source4/torture/drs/python/fsmo.py |6 +- source4/utils/net/config.mk | 50 --- source4/utils/net/drs/net_drs.c | 361 source4/utils/net/drs/net_drs.h | 87 source4/utils/net/drs/net_drs_bind.c| 136 -- source4/utils/net/drs/net_drs_kcc.c | 170 source4/utils/net/drs/net_drs_replicate.c | 252 --- source4/utils/net/drs/net_drs_showrepl.c| 605 -- source4/utils/net/net.c | 387 - source4/utils/net/net.h | 39 -- source4/utils/net/net_gpo.c | 618 --- source4/utils/net/net_password.c| 171 source4/utils/net/net_vampire.c | 130 -- source4/utils/net/wscript_build | 18 - source4/utils/tests/test_net.sh | 40 -- source4/utils/tests/test_samba_tool.sh | 40 ++ source4/wscript_build |2 +- testprogs/blackbox/test_export_keytab.sh| 10 +- testprogs/blackbox/test_kinit.sh| 18 +- testprogs/blackbox/test_ktpass.sh |4 +- testprogs/blackbox/test_passwords.sh| 36 +- testprogs/blackbox/test_pkinit.sh |4 +- 42 files changed, 3137 insertions(+), 3188 deletions(-) create mode 100644 source4/samba_tool/drs/drs.c create mode 100644 source4/samba_tool/drs/drs.h create mode 100644 source4/samba_tool/drs/drs_bind.c create mode 100644 source4/samba_tool/drs/drs_kcc.c create mode 100644 source4/samba_tool/drs/drs_replicate.c create mode 100644 source4/samba_tool/drs/drs_showrepl.c create mode 100644 source4/samba_tool/gpo.c create mode 100644 source4/samba_tool/password.c create mode 100644 source4/samba_tool/samba_tool.c create mode 100644 source4/samba_tool/samba_tool.h create mode 100644 source4/samba_tool/vampire.c create mode 100644 source4/samba_tool/wscript_build delete mode 100644 source4/utils/net/config.mk delete mode 100644 source4/utils/net/drs/net_drs.c delete mode 100644 source4/utils/net/drs/net_drs.h delete mode 100644 source4/utils/net/drs/net_drs_bind.c delete mode 100644 source4/utils/net/drs/net_drs_kcc.c delete mode 100644 source4/utils/net/drs/net_drs_replicate.c delete mode 100644 source4/utils/net/drs/net_drs_showrepl.c delete mode 100644 source4/utils/net/net.c delete mode 100644 source4/utils/net/net.h delete mode 100644 source4/utils/net/net_gpo.c delete mode 100644 source4/utils/net/net_password.c delete mode 100644 source4/utils/net/net_vampire.c delete mode 100644 source4/utils/net/wscript_build delete mode 100755 source4/utils/tests/test_net.sh create mode 100755 source4/utils/tests/test_samba_tool.sh Changeset truncated at 500 lines: diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm index ba96f08..168fe42 100644 --- a/selftest/target/Samba4.pm +++ b/selftest/target/Samba4.pm @@ -880,11 +880,11 @@ sub provision_member($$$) return undef; }
Re: [SCM] Samba Shared Repository - branch master updated
ekacnet, like metze I would also suggest to revert this patch and simply append the test name to the "selftest/skip" file. Unless there is a really important reason I find such individual hacks inappropriate. And if we'd once opt to reactivate this we could do it in the expected standard place and not changing the buildscript again. Greets, Matthias Stefan (metze) Metzmacher wrote: Hi Matthieu, commit 04d63e973efb5b3e1bf677688f5d61ddf13cee42 Author: Matthieu Patou Date: Wed Oct 27 00:50:41 2010 +0400 unit tests: remove smb2.dir Tridge says that it's a hard to fix pb and that it's not the priority for 4.0.0 ... diff --git a/source4/selftest/tests.py b/source4/selftest/tests.py index 3d3ac34..5877f4f 100755 --- a/source4/selftest/tests.py +++ b/source4/selftest/tests.py @@ -314,7 +314,7 @@ plantestsuite_loadlist("samba4.ntp.signd", "dc:local", [smb4torture, 'ncacn_np:$ # Tests against the NTVFS POSIX backend ntvfsargs = ["--option=torture:sharedelay=1", "--option=torture:oplocktimeout=3", "--option=torture:writetimeupdatedelay=5"] -smb2 = smb4torture_testsuites("SMB2-") +smb2 = filter(lambda x: "SMB2-DIR" not in x, smb4torture_testsuites("SMB2-")) Shouldn't this be done, but just adding the test to the skip file? metze