[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 0d87c0f s3-spoolss: Set DWORD values correctly. from e09f057 s3-lib/sysacls: Do not include an embedded http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 0d87c0fe97056d6e8589f86d9403447e39f12745 Author: Andreas Schneider a...@samba.org Date: Mon May 7 09:36:35 2012 +0200 s3-spoolss: Set DWORD values correctly. Autobuild-User: Andreas Schneider a...@cryptomilk.org Autobuild-Date: Wed May 9 11:13:00 CEST 2012 on sn-devel-104 --- Summary of changes: source3/rpc_server/spoolss/srv_spoolss_nt.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index 34582b2..3a6fc35 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -2305,26 +2305,26 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *mem_ctx, if (!strcasecmp_m(value, W3SvcInstalled)) { *type = REG_DWORD; - data-value = 0x00; + SIVAL(data-value, 0, 0x00); return WERR_OK; } if (!strcasecmp_m(value, BeepEnabled)) { *type = REG_DWORD; - data-value = 0x00; + SIVAL(data-value, 0, 0x00); return WERR_OK; } if (!strcasecmp_m(value, EventLog)) { *type = REG_DWORD; /* formally was 0x1b */ - data-value = 0x00; + SIVAL(data-value, 0, 0x00); return WERR_OK; } if (!strcasecmp_m(value, NetPopup)) { *type = REG_DWORD; - data-value = 0x00; + SIVAL(data-value, 0, 0x00); return WERR_OK; } @@ -2337,9 +2337,9 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *mem_ctx, -- jerry */ if (RA_WINNT == get_remote_arch()) { - data-value = 0x02; + SIVAL(data-value, 0, 0x02); } else { - data-value = 0x03; + SIVAL(data-value, 0, 0x03); } return WERR_OK; @@ -2347,7 +2347,7 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *mem_ctx, if (!strcasecmp_m(value, MinorVersion)) { *type = REG_DWORD; - data-value = 0x00; + SIVAL(data-value, 0, 0x00); return WERR_OK; } @@ -2406,9 +2406,9 @@ static WERROR getprinterdata_printer_server(TALLOC_CTX *mem_ctx, member of a AD domain */ if (lp_security() == SEC_ADS) { - data-value = 0x01; + SIVAL(data-value, 0, 0x01); } else { - data-value = 0x00; + SIVAL(data-value, 0, 0x00); } return WERR_OK; } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 5efc315 s3-docs: Fix bug #7930. from d2f4164 s3-VFS: Fix building out-of-tree modules. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 5efc31595beae5ec661d0bf6d001bcfbf59bc446 Author: Karolin Seeger ksee...@samba.org Date: Tue May 8 16:33:07 2012 +0200 s3-docs: Fix bug #7930. Add hint that setting profile acls = yes on normal shares can cause trouble. Karolin Autobuild-User: Karolin Seeger ksee...@samba.org Autobuild-Date: Tue May 8 18:47:59 CEST 2012 on sn-devel-104 (cherry picked from commit 4cc04a29247a0c4b3de9884890364a5712534073) --- Summary of changes: docs-xml/smbdotconf/protocol/profileacls.xml |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/smbdotconf/protocol/profileacls.xml b/docs-xml/smbdotconf/protocol/profileacls.xml index 1c6f0c9..be89753 100644 --- a/docs-xml/smbdotconf/protocol/profileacls.xml +++ b/docs-xml/smbdotconf/protocol/profileacls.xml @@ -25,7 +25,7 @@ every returned ACL. This will allow any Windows 2000 or XP workstation user to access the profile. /para - + para Note that if you have multiple users logging on to a workstation then in order to prevent them from being able to access @@ -35,6 +35,12 @@ workstation profile code and has an ACL restricting entry to the directory tree to the owning user. /para + + para + Note that this parameter should be set to yes on dedicated profile shares only. + On other shares, it might cause incorrect file ownerships. + /para + /description value type=defaultno/value -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated via f5d9428 s3-docs: Fix bug #7930. from ca9538b s3-VFS: Fix building out-of-tree modules. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log - commit f5d942840bd5e2d728cbf7e4ab4d9dae25cb3323 Author: Karolin Seeger ksee...@samba.org Date: Tue May 8 16:33:07 2012 +0200 s3-docs: Fix bug #7930. Add hint that setting profile acls = yes on normal shares can cause trouble. Karolin Autobuild-User: Karolin Seeger ksee...@samba.org Autobuild-Date: Tue May 8 18:47:59 CEST 2012 on sn-devel-104 (cherry picked from commit 4cc04a29247a0c4b3de9884890364a5712534073) (cherry picked from commit 5efc31595beae5ec661d0bf6d001bcfbf59bc446) --- Summary of changes: docs-xml/smbdotconf/protocol/profileacls.xml |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/smbdotconf/protocol/profileacls.xml b/docs-xml/smbdotconf/protocol/profileacls.xml index 1c6f0c9..be89753 100644 --- a/docs-xml/smbdotconf/protocol/profileacls.xml +++ b/docs-xml/smbdotconf/protocol/profileacls.xml @@ -25,7 +25,7 @@ every returned ACL. This will allow any Windows 2000 or XP workstation user to access the profile. /para - + para Note that if you have multiple users logging on to a workstation then in order to prevent them from being able to access @@ -35,6 +35,12 @@ workstation profile code and has an ACL restricting entry to the directory tree to the owning user. /para + + para + Note that this parameter should be set to yes on dedicated profile shares only. + On other shares, it might cause incorrect file ownerships. + /para + /description value type=defaultno/value -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via d46ddfa s3-smbd: Fix the creation of duplicate SMB_ACL_GROUP entries from 0d87c0f s3-spoolss: Set DWORD values correctly. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit d46ddfa748523b5d75c7ea2bb5664bfb48ab3814 Author: Andrew Bartlett abart...@samba.org Date: Wed May 9 14:35:55 2012 +1000 s3-smbd: Fix the creation of duplicate SMB_ACL_GROUP entries The issue was a simple copy and paste bug, which casued a duplicate SMB_ACL_GROUP to be added when we already had one. Andrew Bartlett Signed-off-by: Jeremy Allison j...@samba.org Autobuild-User: Jeremy Allison j...@samba.org Autobuild-Date: Wed May 9 13:17:29 CEST 2012 on sn-devel-104 --- Summary of changes: source3/smbd/posix_acls.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c index f54bfa1..bbf0eae 100644 --- a/source3/smbd/posix_acls.c +++ b/source3/smbd/posix_acls.c @@ -1510,8 +1510,8 @@ static bool ensure_canon_entry_valid(connection_struct *conn, canon_ace **pp_ace pace-unix_ug.uid == pace_user-unix_ug.uid) { /* Already got one. */ got_duplicate_user = true; - } else if (pace-type == SMB_ACL_USER - pace-unix_ug.uid == pace_user-unix_ug.uid) { + } else if (pace-type == SMB_ACL_GROUP + pace-unix_ug.gid == pace_user-unix_ug.gid) { /* Already got one. */ got_duplicate_group = true; } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via e295905 Fix pam_winbind build against newer iniparser library. from 5efc315 s3-docs: Fix bug #7930. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit e295905f2840b5e814f88cd483b7f5f0fb3b4150 Author: Simo Sorce i...@samba.org Date: Wed May 9 13:55:41 2012 +0200 Fix pam_winbind build against newer iniparser library. iniparser_getstr is deprecated and has been removed in newer libraries available in Fedora. Use iniparse_getstring instead. Autobuild-User: Simo Sorce i...@samba.org Autobuild-Date: Tue Apr 24 02:56:10 CEST 2012 on sn-devel-104 Based on commit adbace20a24b6ae4fbd6d17b7153833f4ac8c88d in master. --- Summary of changes: nsswitch/pam_winbind.c |8 1 files changed, 4 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c index 7005c25..1ab2cbf 100644 --- a/nsswitch/pam_winbind.c +++ b/nsswitch/pam_winbind.c @@ -437,13 +437,13 @@ static int _pam_parse(const pam_handle_t *pamh, ctrl |= WINBIND_SILENT; } - if (iniparser_getstr(d, CONST_DISCARD(char *, global:krb5_ccache_type)) != NULL) { + if (iniparser_getstring(d, CONST_DISCARD(char *, global:krb5_ccache_type)) != NULL) { ctrl |= WINBIND_KRB5_CCACHE_TYPE; } - if ((iniparser_getstr(d, CONST_DISCARD(char *, global:require-membership-of)) + if ((iniparser_getstring(d, CONST_DISCARD(char *, global:require-membership-of)) != NULL) || - (iniparser_getstr(d, CONST_DISCARD(char *, global:require_membership_of)) + (iniparser_getstring(d, CONST_DISCARD(char *, global:require_membership_of)) != NULL)) { ctrl |= WINBIND_REQUIRED_MEMBERSHIP; } @@ -2277,7 +2277,7 @@ static const char *get_conf_item_string(struct pwb_context *ctx, goto out; } - parm_opt = iniparser_getstr(ctx-dict, key); + parm_opt = iniparser_getstring,(ctx-dict, key, NULL); TALLOC_FREE(key); _pam_log_debug(ctx, LOG_INFO, CONFIG file: %s '%s'\n, -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-5-test updated
The branch, v3-5-test has been updated via 76dcbb8 Fix pam_winbind build against newer iniparser library. from f5d9428 s3-docs: Fix bug #7930. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test - Log - commit 76dcbb84e3fa13959df5931d21051695327c29f4 Author: Simo Sorce i...@samba.org Date: Wed May 9 13:55:41 2012 +0200 Fix pam_winbind build against newer iniparser library. iniparser_getstr is deprecated and has been removed in newer libraries available in Fedora. Use iniparse_getstring instead. Autobuild-User: Simo Sorce i...@samba.org Autobuild-Date: Tue Apr 24 02:56:10 CEST 2012 on sn-devel-104 Based on commit adbace20a24b6ae4fbd6d17b7153833f4ac8c88d in master. (cherry picked from commit e295905f2840b5e814f88cd483b7f5f0fb3b4150) --- Summary of changes: nsswitch/pam_winbind.c |8 1 files changed, 4 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c index b802036..a344186 100644 --- a/nsswitch/pam_winbind.c +++ b/nsswitch/pam_winbind.c @@ -437,13 +437,13 @@ static int _pam_parse(const pam_handle_t *pamh, ctrl |= WINBIND_SILENT; } - if (iniparser_getstr(d, CONST_DISCARD(char *, global:krb5_ccache_type)) != NULL) { + if (iniparser_getstring(d, CONST_DISCARD(char *, global:krb5_ccache_type)) != NULL) { ctrl |= WINBIND_KRB5_CCACHE_TYPE; } - if ((iniparser_getstr(d, CONST_DISCARD(char *, global:require-membership-of)) + if ((iniparser_getstring(d, CONST_DISCARD(char *, global:require-membership-of)) != NULL) || - (iniparser_getstr(d, CONST_DISCARD(char *, global:require_membership_of)) + (iniparser_getstring(d, CONST_DISCARD(char *, global:require_membership_of)) != NULL)) { ctrl |= WINBIND_REQUIRED_MEMBERSHIP; } @@ -2290,7 +2290,7 @@ static const char *get_conf_item_string(struct pwb_context *ctx, goto out; } - parm_opt = iniparser_getstr(ctx-dict, key); + parm_opt = iniparser_getstring,(ctx-dict, key, NULL); TALLOC_FREE(key); _pam_log_debug(ctx, LOG_INFO, CONFIG file: %s '%s'\n, -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 67adda0 waf: remove pointless WINBIND_KRB5_LOCATOR env. from d46ddfa s3-smbd: Fix the creation of duplicate SMB_ACL_GROUP entries http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 67adda0d69558c0bd2236478c8c4d2c76417dc4b Author: Günther Deschner g...@samba.org Date: Tue May 8 14:45:02 2012 +0200 waf: remove pointless WINBIND_KRB5_LOCATOR env. Guenther Autobuild-User: Günther Deschner g...@samba.org Autobuild-Date: Wed May 9 15:16:34 CEST 2012 on sn-devel-104 --- Summary of changes: wscript_configure_krb5 |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/wscript_configure_krb5 b/wscript_configure_krb5 index abfd04a..26a92a8 100644 --- a/wscript_configure_krb5 +++ b/wscript_configure_krb5 @@ -22,9 +22,6 @@ if conf.env.KRB5_CONFIG: conf.CHECK_HEADERS('krb5.h krb5/locate_plugin.h', lib='krb5') conf.CHECK_HEADERS('gssapi.h gssapi/gssapi_generic.h gssapi/gssapi.h gssapi/gssapi_ext.h gssapi/gssapi_krb5.h', lib='krb5') -if conf.CONFIG_SET('HAVE_KRB5_LOCATE_PLUGIN_H'): -conf.env['WINBIND_KRB5_LOCATOR'] = 'bin/winbind_krb5_locator.so' - conf.CHECK_FUNCS_IN('krb5_encrypt_data', 'k5crypto') conf.CHECK_FUNCS_IN('des_set_key','crypto') conf.CHECK_FUNCS_IN('copy_Authenticator', 'asn1') -- Samba Shared Repository
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2012-05-09-1600/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2012-05-09-1600/samba3.stderr http://git.samba.org/autobuild.flakey/2012-05-09-1600/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2012-05-09-1600/samba4.stderr http://git.samba.org/autobuild.flakey/2012-05-09-1600/samba4.stdout The top commit at the time of the failure was: commit d46ddfa748523b5d75c7ea2bb5664bfb48ab3814 Author: Andrew Bartlett abart...@samba.org Date: Wed May 9 14:35:55 2012 +1000 s3-smbd: Fix the creation of duplicate SMB_ACL_GROUP entries The issue was a simple copy and paste bug, which casued a duplicate SMB_ACL_GROUP to be added when we already had one. Andrew Bartlett Signed-off-by: Jeremy Allison j...@samba.org Autobuild-User: Jeremy Allison j...@samba.org Autobuild-Date: Wed May 9 13:17:29 CEST 2012 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 5f05eac allow to use system iniparser library. from 67adda0 waf: remove pointless WINBIND_KRB5_LOCATOR env. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 5f05eacd27f0dc512748c14cac5f4d6afb327f99 Author: Günther Deschner g...@samba.org Date: Wed May 9 15:33:04 2012 +0200 allow to use system iniparser library. Guenther Autobuild-User: Günther Deschner g...@samba.org Autobuild-Date: Wed May 9 17:38:33 CEST 2012 on sn-devel-104 --- Summary of changes: buildtools/wafsamba/samba3.py |6 ++ lib/iniparser/src/wscript | 21 + lib/iniparser/src/wscript_build |7 --- nsswitch/wscript_build |2 +- source3/wscript_build |2 +- wscript |1 + wscript_build |2 +- 7 files changed, 31 insertions(+), 10 deletions(-) create mode 100644 lib/iniparser/src/wscript delete mode 100644 lib/iniparser/src/wscript_build Changeset truncated at 500 lines: diff --git a/buildtools/wafsamba/samba3.py b/buildtools/wafsamba/samba3.py index 7f05ffe..b6a9f1b 100644 --- a/buildtools/wafsamba/samba3.py +++ b/buildtools/wafsamba/samba3.py @@ -92,6 +92,12 @@ def s3_fix_kwargs(bld, kwargs): else: extra_includes += [ '../lib/popt' ] +if bld.CONFIG_SET('USING_SYSTEM_INIPARSER'): +(iniparser_includes, iniparser_ldflags, iniparser_cpppath) = library_flags(bld, 'iniparser') +extra_includes += iniparser_cpppath +else: +extra_includes += [ '../lib/iniparser' ] + # s3 builds assume that they will have a bunch of extra include paths includes = [] for d in extra_includes: diff --git a/lib/iniparser/src/wscript b/lib/iniparser/src/wscript new file mode 100644 index 000..c66f298 --- /dev/null +++ b/lib/iniparser/src/wscript @@ -0,0 +1,21 @@ +#!/usr/bin/env python + +import Options + +def configure(conf): +conf.CHECK_HEADERS('float.h') + +if conf.CHECK_BUNDLED_SYSTEM('iniparser', checkfunctions='iniparser_load', headers='iniparser.h'): +conf.define('USING_SYSTEM_INIPARSER', 1) + +def build(bld): +if bld.CONFIG_SET('USING_SYSTEM_INIPARSER'): +return + +bld.SAMBA_LIBRARY('iniparser', + source='''../../iniparser_build/iniparser.c +../../iniparser_build/dictionary.c +../../iniparser_build/strlib.c''', + cflags='', + deps='replace', + private_library=True) diff --git a/lib/iniparser/src/wscript_build b/lib/iniparser/src/wscript_build deleted file mode 100644 index aa15c9f..000 --- a/lib/iniparser/src/wscript_build +++ /dev/null @@ -1,7 +0,0 @@ -#!/usr/bin/env python - -bld.SAMBA_SUBSYSTEM('LIBINIPARSER', -source='../../iniparser_build/iniparser.c ../../iniparser_build/dictionary.c ../../iniparser_build/strlib.c', -deps='replace', -cflags='' -) diff --git a/nsswitch/wscript_build b/nsswitch/wscript_build index f740fdf..0802687 100644 --- a/nsswitch/wscript_build +++ b/nsswitch/wscript_build @@ -24,7 +24,7 @@ bld.SAMBA_LIBRARY('nss_winbind', if bld.CONFIG_SET('WITH_PAM_MODULES') and bld.CONFIG_SET('HAVE_PAM_START'): bld.SAMBA_LIBRARY('pamwinbind', source='pam_winbind.c', - deps='intl talloc wbclient winbind-client LIBINIPARSER pam', + deps='intl talloc wbclient winbind-client iniparser pam', cflags='-DLOCALEDIR=\%s/locale\' % bld.env.DATADIR, realname='pam_winbind.so', install_path='${PAMMODULESDIR}' diff --git a/source3/wscript_build b/source3/wscript_build index 5e85b79..ad19c33 100755 --- a/source3/wscript_build +++ b/source3/wscript_build @@ -1527,7 +1527,7 @@ bld.SAMBA3_BINARY('ntlm_auth' + bld.env.suffix3, deps=''' talloc krb5samba - LIBINIPARSER + iniparser libsmb popt_samba3 LIBNTLMSSP gse gensec''', diff --git a/wscript b/wscript index 3376436..15ac7f5 100755 --- a/wscript +++ b/wscript @@ -105,6 +105,7 @@ def configure(conf): conf.RECURSE('lib/socket_wrapper') conf.RECURSE('lib/uid_wrapper') conf.RECURSE('lib/popt') +conf.RECURSE('lib/iniparser/src') conf.RECURSE('lib/subunit/c') conf.RECURSE('libcli/smbreadline') conf.RECURSE('lib/crypto') diff --git a/wscript_build b/wscript_build index ea242d5..e35ddae 100755 --- a/wscript_build +++ b/wscript_build @@ -48,7 +48,6 @@ bld.RECURSE('source4/libnet') bld.RECURSE('source4/auth') bld.RECURSE('auth') bld.RECURSE('auth/kerberos')
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2012-05-09-1807/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2012-05-09-1807/samba3.stderr http://git.samba.org/autobuild.flakey/2012-05-09-1807/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2012-05-09-1807/samba4.stderr http://git.samba.org/autobuild.flakey/2012-05-09-1807/samba4.stdout The top commit at the time of the failure was: commit 5f05eacd27f0dc512748c14cac5f4d6afb327f99 Author: Günther Deschner g...@samba.org Date: Wed May 9 15:33:04 2012 +0200 allow to use system iniparser library. Guenther Autobuild-User: Günther Deschner g...@samba.org Autobuild-Date: Wed May 9 17:38:33 CEST 2012 on sn-devel-104
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2012-05-09-1807/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2012-05-09-1807/samba3.stderr http://git.samba.org/autobuild.flakey/2012-05-09-1807/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2012-05-09-1807/samba4.stderr http://git.samba.org/autobuild.flakey/2012-05-09-1807/samba4.stdout The top commit at the time of the failure was: commit 5f05eacd27f0dc512748c14cac5f4d6afb327f99 Author: Günther Deschner g...@samba.org Date: Wed May 9 15:33:04 2012 +0200 allow to use system iniparser library. Guenther Autobuild-User: Günther Deschner g...@samba.org Autobuild-Date: Wed May 9 17:38:33 CEST 2012 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 6132cf2 s3:auth/server_info: the primary rid should be in the groups rid array (bug #8798) from 5f05eac allow to use system iniparser library. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 6132cf2a5cd77c79546a2d6cc3fbf3c93f54183b Author: Alejandro Escanero Blanco aescan...@gmail.com Date: Wed May 9 11:35:51 2012 +0200 s3:auth/server_info: the primary rid should be in the groups rid array (bug #8798) Signed-off-by: Stefan Metzmacher me...@samba.org Autobuild-User: Stefan Metzmacher me...@samba.org Autobuild-Date: Wed May 9 19:36:01 CEST 2012 on sn-devel-104 --- Summary of changes: source3/auth/server_info.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/auth/server_info.c b/source3/auth/server_info.c index 2a9fe73..216e5e3 100644 --- a/source3/auth/server_info.c +++ b/source3/auth/server_info.c @@ -263,11 +263,6 @@ static NTSTATUS group_sids_to_info3(struct netr_SamInfo3 *info3, for (i = 0; i num_sids; i++) { ok = sid_peek_check_rid(domain_sid, sids[i], rid); if (ok) { - - /* if it is the primary gid, skip it, we -* obviously already have it */ - if (info3-base.primary_gid == rid) continue; - /* store domain group rid */ groups-rids[groups-count].rid = rid; groups-rids[groups-count].attributes = attributes; -- Samba Shared Repository
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2012-05-10-0408/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2012-05-10-0408/samba3.stderr http://git.samba.org/autobuild.flakey/2012-05-10-0408/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2012-05-10-0408/samba4.stderr http://git.samba.org/autobuild.flakey/2012-05-10-0408/samba4.stdout The top commit at the time of the failure was: commit 6132cf2a5cd77c79546a2d6cc3fbf3c93f54183b Author: Alejandro Escanero Blanco aescan...@gmail.com Date: Wed May 9 11:35:51 2012 +0200 s3:auth/server_info: the primary rid should be in the groups rid array (bug #8798) Signed-off-by: Stefan Metzmacher me...@samba.org Autobuild-User: Stefan Metzmacher me...@samba.org Autobuild-Date: Wed May 9 19:36:01 CEST 2012 on sn-devel-104