date:20120604

[SCM] Samba Shared Repository - branch master updated

2012-06-04 Thread Jeremy Allison

The branch, master has been updated
   via  07fc59f Tests for bug #8972 - Add permission checks to 
run_simple_posix_open_test().
   via  27bb016 Tests for bug #8972 - run the POSIX tests against the 
posix_share.
   via  f57ca68 Tests for bug #8972 - Add a posix_share definition to s4 so 
we can do raw posix permissions checks.
   via  acab344 Tests for bug #8972 - Add a posix_share definition to s3 so 
we can do raw posix permissions checks.
  from  d6cd48f wintest: Fix test-s3.py to use smbclient3 under the name 
smbclient

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 07fc59f78d816c4496623cc37026b82fd6b0bed3
Author: Jeremy Allison 
Date:   Mon Jun 4 20:45:34 2012 -0700

Tests for bug #8972 - Add permission checks to run_simple_posix_open_test().

This requires a share with :

create mask = 0777
force create mode = 0
directory mask = 0777
force directory mode = 0

set so we don't mess with requested permissions.

Autobuild-User: Jeremy Allison 
Autobuild-Date: Tue Jun  5 08:20:03 CEST 2012 on sn-devel-104

commit 27bb01691ca71854ba146fb62b1114e6b612f562
Author: Jeremy Allison 
Date:   Mon Jun 4 20:44:56 2012 -0700

Tests for bug #8972 - run the POSIX tests against the posix_share.

commit f57ca68b1c26d2a93de4a6dc415817b7babcd87f
Author: Jeremy Allison 
Date:   Mon Jun 4 20:44:08 2012 -0700

Tests for bug #8972 - Add a posix_share definition to s4 so we can do raw 
posix permissions checks.

commit acab34484718780dea8818ac0be5d6db78a06275
Author: Jeremy Allison 
Date:   Mon Jun 4 20:43:09 2012 -0700

Tests for bug #8972 - Add a posix_share definition to s3 so we can do raw 
posix permissions checks.

---

Summary of changes:
 selftest/target/Samba3.pm |9 +
 selftest/target/Samba4.pm |8 
 source3/selftest/tests.py |   10 --
 source3/torture/torture.c |   27 +++
 4 files changed, 52 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index 098f532..a84b4e1 100755
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -984,6 +984,15 @@ sub provision($$)
comment = smb username is [%U]
create mask = 777
force create mode = 777
+[posix_share]
+   path = $shrdir
+   comment = smb username is [%U]
+   create mask = 0777
+   force create mode = 0
+   directory mask = 0777
+   force directory mode = 0
+   vfs objects = $vfs_modulesdir_abs/xattr_tdb.so
+
 [print\$]
copy = tmp
";
diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index 97cdbf2..954cf9c 100644
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -745,6 +745,14 @@ sub provision()
create mask = 777
force create mode = 777
 
+[posix_share]
+   path = $ctx->{share}
+   read only = no
+   create mask = 0777
+   force create mode = 0
+   directory mask = 0777
+   force directory mode = 0
+
 [test1]
path = $ctx->{share}/test1
read only = no
diff --git a/source3/selftest/tests.py b/source3/selftest/tests.py
index c131ca2..0d3bf04 100755
--- a/source3/selftest/tests.py
+++ b/source3/selftest/tests.py
@@ -85,8 +85,7 @@ tests=[ "FDPASS", "LOCK1", "LOCK2", "LOCK3", "LOCK4", 
"LOCK5", "LOCK6", "LOCK7",
 "OPEN", "XCOPY", "RENAME", "DELETE", "DELETE-LN", "PROPERTIES", "W2K",
 "TCON2", "IOCTL", "CHKPATH", "FDSESS", "CHAIN1", "CHAIN2",
 "CHAIN3",
-"GETADDRINFO", "POSIX", "UID-REGRESSION-TEST", "SHORTNAME-TEST",
-"POSIX-APPEND",
+"GETADDRINFO", "UID-REGRESSION-TEST", "SHORTNAME-TEST",
 "CASE-INSENSITIVE-CREATE", "SMB2-BASIC", "NTTRANS-FSCTL", 
"SMB2-NEGPROT",
 "CLEANUP1",
 "CLEANUP2",
@@ -97,6 +96,13 @@ for t in tests:
 plantestsuite("samba3.smbtorture_s3.crypt(s3dc).%s" % t, "s3dc", 
[os.path.join(samba3srcdir, "script/tests/test_smbtorture_s3.sh"), t, 
'//$SERVER_IP/tmp', '$USERNAME', '$PASSWORD', smbtorture3, "-e", "-l 
$LOCAL_PATH"])
 plantestsuite("samba3.smbtorture_s3.plain(dc).%s" % t, "dc", 
[os.path.join(samba3srcdir, "script/tests/test_smbtorture_s3.sh"), t, 
'//$SERVER_IP/tmp', '$USERNAME', '$PASSWORD', smbtorture3, "", "-l 
$LOCAL_PATH"])
 
+posix_tests=[ "POSIX", "POSIX-APPEND"]
+
+for t in posix_tests:
+plantestsuite("samba3.smbtorture_s3.plain(s3dc).%s" % t, "s3dc", 
[os.path.join(samba3srcdir, "script/tests/test_smbtorture_s3.sh"), t, 
'//$SERVER_IP/posix_share', '$USERNAME', '$PASSWORD', smbtorture3, "", "-l 
$LOCAL_PATH"])
+plantestsuite("samba3.smbtorture_s3.crypt(s3dc).%s" % t, "s3dc", 
[os.path.join(samba3srcdir, "script/tests/test_smbtorture_s3.sh"), t, 
'//$SERVER_IP/posix_share', '$USERNAME',

[SCM] Samba Shared Repository - branch master updated

2012-06-04 Thread Andrew Bartlett

The branch, master has been updated
   via  d6cd48f wintest: Fix test-s3.py to use smbclient3 under the name 
smbclient
   via  1df3982 WHATSNEW: mention FreeBSD getaddrinfo() issue
   via  b7754f4 s3:build(autoconf): fix "no AC_LANG_SOURCE call detected" 
warnings
   via  d99bbb5 WHATSNEW: Mention trouble with DNS replication
   via  e3d1d6c WHATSNEW: Note FreeBSD improvements
   via  dc799d4 s4-provision: Test for posix ACLs in the actual sysvol path
   via  d2b635c s4-provision: Place xattr.tdb in the actual state directory
   via  68769c2 WHATSNEW: Update for beta1
   via  d561ef2 VERSION: prepare for beta1 by setting and parsing the beta 
version
   via  1a2b65c Add '--use-ntvfs' option to 'samba-tool domain join'
   via  9db04c4 s3-smbd: Remove support for protocols before LANMAN1
   via  3a13581 Remove Manifest.  The information here was outdated
   via  edd7251 libreplace: Add copyrights to ease tracking of this file in 
future
   via  5f58359 libreplace: Remove autoconf build system
  from  4accd23 Fix bug #8972 - Directory group write permission bit is set 
if unix extensions are enabled

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit d6cd48fca6bc69e7c8c5070790ec5d48a6dcf3f6
Author: Andrew Bartlett 
Date:   Tue Jun 5 11:51:18 2012 +1000

wintest: Fix test-s3.py to use smbclient3 under the name smbclient

Autobuild-User: Andrew Bartlett 
Autobuild-Date: Tue Jun  5 06:24:39 CEST 2012 on sn-devel-104

commit 1df39825e4e5e0db3654d1c2eac4697c30457ab2
Author: Andrew Bartlett 
Date:   Tue Jun 5 11:41:52 2012 +1000

WHATSNEW: mention FreeBSD getaddrinfo() issue

commit b7754f4bf7f1204e02baf6086c3cbbd7c6ebf1d9
Author: Martin Schwenke 
Date:   Fri Dec 16 12:43:34 2011 +1100

s3:build(autoconf): fix "no AC_LANG_SOURCE call detected" warnings

Autoconf 2.68 NEWS says:

** The macros AC_PREPROC_IFELSE, AC_COMPILE_IFELSE, AC_LINK_IFELSE, and
   AC_RUN_IFELSE now warn if the first argument failed to use
   AC_LANG_SOURCE or AC_LANG_PROGRAM to generate the conftest file
   contents.  A new macro AC_LANG_DEFINES_PROVIDED exists if you have
   a compelling reason why you cannot use AC_LANG_SOURCE but must
   avoid the warning.

Signed-off-by: Martin Schwenke 

commit d99bbb52e7763601a638ae24033e4b46691582be
Author: Andrew Bartlett 
Date:   Tue Jun 5 11:15:21 2012 +1000

WHATSNEW: Mention trouble with DNS replication

commit e3d1d6c03c04b096b1c4e19eadeb58cf8bdba135
Author: Andrew Bartlett 
Date:   Tue Jun 5 10:34:27 2012 +1000

WHATSNEW: Note FreeBSD improvements

commit dc799d4b42551842a9c1dc863568611d82c6168d
Author: Andrew Bartlett 
Date:   Tue Jun 5 09:58:41 2012 +1000

s4-provision: Test for posix ACLs in the actual sysvol path

This avoids issues in the previous location where lp may not be initialised 
at this point
and instead simply waits until we have a known sysvol path, and test for 
ACL support
there.

Andrew Bartlett

commit d2b635cc2f031364be1f25a7f8fb897a78764e5c
Author: Andrew Bartlett 
Date:   Tue Jun 5 09:56:53 2012 +1000

s4-provision: Place xattr.tdb in the actual state directory

This patch does two things: it fixes up the spelling of "state dir" to
"state directory" so that we actually find the smb.conf parameter, and
we move it to after we process the global settings in case this is
changed in the future.

Andrew Bartlett

commit 68769c26ff1bf7d6b36820c64e71169b35434061
Author: Andrew Bartlett 
Date:   Tue Jun 5 09:21:15 2012 +1000

WHATSNEW: Update for beta1

commit d561ef20b5f87bd3a77939de7175daca45679e29
Author: Andrew Bartlett 
Date:   Tue Jun 5 09:07:44 2012 +1000

VERSION: prepare for beta1 by setting and parsing the beta version

commit 1a2b65cd31243f36f2a0a63bdad7f6d6f39afc1d
Author: Andriy Syrovenko 
Date:   Tue Jun 5 01:32:42 2012 +0300

Add '--use-ntvfs' option to 'samba-tool domain join'

commit 9db04c481d981ee0ab285e0e34f32c49a7e84641
Author: Andrew Bartlett 
Date:   Wed May 30 12:32:56 2012 +1000

s3-smbd: Remove support for protocols before LANMAN1

This falls out of the removal of security=share, because we now require that
a session setup has been performed before (essentially) all other 
operations.

Andrew Bartlett

commit 3a1358121ab0d0d950252a0ec770a08bdda90809
Author: Andrew Bartlett 
Date:   Mon May 28 13:08:45 2012 +1000

Remove Manifest.  The information here was outdated

commit edd725125792e848a9c1230ae4e57246dcda4352
Author: Andrew Bartlett 
Date:   Tue Jun 5 08:00:00 2012 +1000

libreplace: Add copyrights to ease tracking of this file in future

As GIT didn't realise this was a copy out of lib/system.c, this should
make it easier to track the copyright holders on this file.  Herb's
name wasn't on the original file, but was

[SCM] Samba Shared Repository - branch master updated

2012-06-04 Thread Jeremy Allison

The branch, master has been updated
   via  4accd23 Fix bug #8972 - Directory group write permission bit is set 
if unix extensions are enabled
  from  0110623 libreplace: Ensure we link xattr.c on MacOS

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 4accd2396e8a9ac4a7b2191a1d3bc9c84d2e0497
Author: Jeremy Allison 
Date:   Mon Jun 4 17:34:54 2012 -0700

Fix bug #8972 - Directory group write permission bit is set if unix 
extensions are enabled

We can't manipulate file_attributes if it's a posix call. I'll look
at adding a test for this asap.

Autobuild-User: Jeremy Allison 
Autobuild-Date: Tue Jun  5 04:26:11 CEST 2012 on sn-devel-104

---

Summary of changes:
 source3/smbd/open.c |6 --
 1 files changed, 4 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 17721c6..a012675 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -2714,8 +2714,10 @@ static NTSTATUS open_directory(connection_struct *conn,
return NT_STATUS_NOT_A_DIRECTORY;
}
 
-   /* Ensure we have a directory attribute. */
-   file_attributes |= FILE_ATTRIBUTE_DIRECTORY;
+   if (!(file_attributes & FILE_FLAG_POSIX_SEMANTICS)) {
+   /* Ensure we have a directory attribute. */
+   file_attributes |= FILE_ATTRIBUTE_DIRECTORY;
+   }
 
DEBUG(5,("open_directory: opening directory %s, access_mask = 0x%x, "
 "share_access = 0x%x create_options = 0x%x, "


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

[SCM] Samba Shared Repository - branch master updated

[SCM] Samba Shared Repository - branch master updated

3 matches

Site Navigation

Mail list logo

Footer information