[SCM] Samba Shared Repository - branch v4-0-test updated

2012-11-13 Thread Karolin Seeger
The branch, v4-0-test has been updated
   via  c06af93 VERSION: Bump version number up to 4.0.0rc6.
   via  0dd3b9f VERSION: Disable GIT snapshot to prepare rc5 release.
  from  065083c WHATSNEW: Update changes since rc4.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test


- Log -
commit c06af936bc8751701ab48d7165c4b08867f797c0
Author: Karolin Seeger ksee...@samba.org
Date:   Tue Nov 13 08:59:44 2012 +0100

VERSION: Bump version number up to 4.0.0rc6.

And re-enable git snapshots.

Karolin

commit 0dd3b9f83383f5b23a82754d22170138ab417dbf
Author: Karolin Seeger ksee...@samba.org
Date:   Tue Nov 13 08:57:55 2012 +0100

VERSION: Disable GIT snapshot to prepare rc5 release.

Karolin

---

Summary of changes:
 VERSION |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/VERSION b/VERSION
index 00ea5a6..685dbe9 100644
--- a/VERSION
+++ b/VERSION
@@ -87,7 +87,7 @@ SAMBA_VERSION_PRE_RELEASE=
 # e.g. SAMBA_VERSION_RC_RELEASE=1  #
 #  -  3.0.0rc1  #
 
-SAMBA_VERSION_RC_RELEASE=5
+SAMBA_VERSION_RC_RELEASE=6
 
 
 # To mark SVN snapshots this should be set to 'yes'#


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch v4-0-stable updated

2012-11-13 Thread Karolin Seeger
The branch, v4-0-stable has been updated
   via  0dd3b9f VERSION: Disable GIT snapshot to prepare rc5 release.
   via  065083c WHATSNEW: Update changes since rc4.
   via  51e6113 WHATSNEW: Update changes since rc4.
   via  ed87e34 samba-tool: Fix typo in --help output.
   via  88bdfcb lib/krb5_wrap: request enc_types in the correct order (bug 
#9272)
   via  7c92c87 s3-kerberos: add aes enctypes to generated krb5.conf.
   via  3c7f48e s3-krb5: use and request AES keys in kerberos operations.
   via  4cb7d0d doc: describe samlogon cache caveat for winbindd -n
   via  949df3c Revert s3-winbindd: make sure we obey the -n switch also 
for samlogon cache access.
   via  c2bafcf ntp_signd: Only allow group access to the ntp signd 
directory.
   via  fb3f081 ntp_signd: move socket directory to var/lib not var/run for 
permissions change
   via  3199aa1 s4:dsdb/acl_read: make sure confidential attributes require 
CONTROL_ACCESS (bug #8620)
   via  0f2b61b s4:dsdb/acl_read: fix whitespace formatting errors
   via  9139694 s4:dsdb/acl: only give administrators access to attributes 
marked as confidential (bug #8620)
   via  eb1c561 s4:dsdb/acl: reorganize the logic flow in the password 
filtering checks
   via  4da07b7 s4:dsdb/acl: fix search filter cleanup for password 
attributes
   via  2f05e8c WHATSNEW: Update changes since rc4.
   via  69cb802 wafsamba.abi: Fix abi_match with both excludes and includes.
   via  a3d7af1 wafsamba.samba_abi: Add basic unit tests.
   via  d280533 buildtools: Remove extra space from global: line
   via  e443b2d wafsamba.samba_abi: Refactor abi_write_vscript to take file 
argument.
   via  e3a35dc WHATSNEW: Update changes since rc4.
   via  5ed2ca8 s3: Pass down smb_filename to smbacl4_fill_ace4
   via  078b665 s3:nfs4acls filter away inheritance flags on files
   via  16479fe s3:nfs4acls pass down fsp instead of just the filename
   via  ebded09 dsdb: Simplify DsCrackNameOneFilter a bit
   via  bc1a270 dsdb-cracknames: Return DRSUAPI_DS_NAME_STATUS_NO_MAPPING 
when there is no SID
   via  ae15743 dsdb-cracknames: Always use talloc_zero()
   via  19c33c4 WHATSNEW: Update changes since rc4.
   via  9af6c46 s3:smb2_getinfo ensure proper error for not yet present 
quota support
   via  75122f7 WHATSNEW: Start release notes for Samba 4.0.0rc5.
   via  e75c9fa s3:vfs_default: optimize vfswrap_asys_finished() and read 
as much as we can
   via  0bc75df lib/tsocket: optimize syscalls in tstream_readv_pdu_send()
   via  6b051af lib/tsocket: disable the syscall optimization for 
recvfrom/readv by default
   via  4641555 s3:smbd: pass the current time to make_connection[_smb1]()
   via  6195cb6 docs-xml: fix use of smbconfoption tag (fix bug #9345)
   via  6b94f5b s3-param: Move the options needed for running smbd in the 
AD DC to loadparm
   via  4d7ea03 file_server: put set create mask and directory mask in 
fileserver.conf
   via  ab78d76 build(waf): fix the cluster(ctdb) build without system 
talloc installed
   via  fb99d62 build(waf): fix a tab indentation to spaces
   via  5010165 build(waf): Fail configure --with-cluster-support if ctdb 
support is not available.
   via  e8ef7c6 s3-torture:test_ctdbconn: fix the build against older ctdb 
versions
   via  22bf5ba s3:ctdb library: fix the build against older ctdb versions
   via  e1fc90d build(waf): check if we have ctdb_protocol.h in the cluster 
checks
   via  b83df67 build(autoconf): check if we have ctdb_protocol.h in the 
cluster checks
   via  0f31f3c build(autoconf): fix check for ctdb_private.h (bug #9349)
   via  6772b85 auth/kerberos: add HAVE_KRB5 guard to fix non-krb5 build 
after winbindd pac changes
   via  87d4237 libwbclient: bump ABI to 0.11 as wbcAuthenticateUserEx now 
provides PAC parsing
   via  b61e8e9 s4-torture: Complete test for winbindd PAC parsing
   via  d2fb91f auth/kerberos: Adjust log level for failed PAC signature 
verification
   via  b547a8d winbind: Extend wbcAuthenticateUserEx to provide PAC
   via  57907a6 dns_server: Try and use the dns-SERVER account if we were 
configured with it
   via  64c10e7 s3:winbindd: use PROTOCOL_LATEST instead of 
PROTOCOL_SMB2_02 (bug #9175)
   via  99817aa s3:winbindd: disconnection after getting 
NETWORK_SESSION_EXPIRED (bug #9175)
   via  07c279e libcli/smb: add smbXcli_session_set_disconnect_expired() 
(bug #9175)
   via  0ad1019 s3:smb2_read: fix SMBD_SMB2_NUM_IOV_PER_REQ check for 
sendfile() support (bug #9341)
   via  37cabc1 provision: No longer use the wheel group in new AD Domains
   via  daaf7f3 util: remove accidently committed hunk
   via  77ec8dc lib/replace: Fix detection of prctl (cherry picked from 
commit 80f42df4ec9194ff00aeeb3c2cf6acfa1f2ab5c3)
   via  b2a3b7f wscript: Removed executable bit.
   via  e95c162 

[SCM] Samba Shared Repository - annotated tag samba-4.0.0rc5 created

2012-11-13 Thread Karolin Seeger
The annotated tag, samba-4.0.0rc5 has been created
at  2f9260580c9c15102aeac62a9ee2088f6baea475 (tag)
   tagging  0dd3b9f83383f5b23a82754d22170138ab417dbf (commit)
  replaces  samba-4.0.0rc4
 tagged by  Karolin Seeger
on  Tue Nov 13 09:13:12 2012 +0100

- Log -
samba: tag release samba-4.0.0rc5
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.18 (GNU/Linux)

iD8DBQBQogEhbzORW2Vot+oRAjE2AJ4n/MVXK6G3iH01cpNSz+iyCH5qWgCgo81A
tSqPKFPnWxPujYaeM2tREnc=
=hznM
-END PGP SIGNATURE-

Alexander Bokovoy (1):
  Fix release script to build full set of documentation

Andreas Schneider (5):
  BUG 9326: Fix net ads join message for the dns domain.
  packaging: Add NetworkManager dispatcher script for winbind.
  wafsamba: If we define a realname and a soname create a symlink.
  waf: Create a libnss_winbind.so symlink.
  waf: Create a libnss_wins.so symlink.

Andrew Bartlett (45):
  lib/replace: Return size of xattr if size argument is 0
  lib/replace: Improve mkstemp test in autoconf and waf
  lib/replace: Look for special flags needed for c99
  build: Try not build with LDAP if we do not have ldap.h
  build: Fix enabled handling for HAVE_LDAP, we need to use bld.CONFIG_SET
  build: Remove unused IRIX and IRIX6 defines
  lib/util: Remove unbuilt file util_getent.c and BROKEN_GETGRNAM
  build: Rework waf STAT_ST_BLOCKSIZE to match autoconf, with 512 as the 
default
  build: Make waf configure match autoconf for HPUX ACLs
  lib/replace: Remove unused nap and therefore the SCO define
  build: Remove unused define UNIXWARE
  build: Add missing dep on tdb_compat
  build: Fix detection of quotas on macos
  lib/util/charset: Try to find iconv on HP-UX
  lib/util/charset: We do not use fucntions from wchar.h any more
  build: Add waf configure support for non-linux quotas
  build: Remove unused samba_cv_sysquotas_file variable from autoconf 
configure
  build: Set HAVE_SYS_QUOTAS and WITH_QUOTAS if we have any supported 
sysquota backend
  build: Remove unused --with-sys-quotas option
  nsswitch: Add waf tests for solaris special cases
  lib/replace: Add test for what flag we need for -Werror behaviour
  build: Fix quota tests, including move of sysquotas.c to the top level
  build: Remove duplicate check for struct getquota_rslt member 
getquota_rslt_u
  selftest: Always build a linux-style nss_winbind for nss_wrapper
  nsswitch: Build nss_winbind on all supported platforms
  build: Add vfs_media_harmony to the waf build
  build: Remove --disable-shared
  build: Add #define FREEBSD on FreeBSD
  build: Remove support for IDL-generated files in git tree
  pidl: Remove depends_on=PIDL_MISC as it sets -I/ into CFLAGS
  lib/replace: Fix configure on FreeBSD: define_ret is not correct here
  lib/replace: Fix detection of rpcsrv/yp_prot.h on FreeBSD
  ntdb: Try to fix the build on Solaris which does not have err
  lib/replace: Fix detection of prctl
  provision: No longer use the wheel group in new AD Domains
  dns_server: Try and use the dns-SERVER account if we were configured with 
it
  libwbclient: bump ABI to 0.11 as wbcAuthenticateUserEx now provides PAC 
parsing
  auth/kerberos: add HAVE_KRB5 guard to fix non-krb5 build after winbindd 
pac changes
  file_server: put set create mask and directory mask in fileserver.conf
  s3-param: Move the options needed for running smbd in the AD DC to 
loadparm
  dsdb-cracknames: Always use talloc_zero()
  dsdb-cracknames: Return DRSUAPI_DS_NAME_STATUS_NO_MAPPING when there is 
no SID
  buildtools: Remove extra space from global: line
  ntp_signd: move socket directory to var/lib not var/run for permissions 
change
  ntp_signd: Only allow group access to the ntp signd directory.

Björn Baumbach (9):
  s3: make recursive_rmdir function non-static
  s3: vfs_streams_depot: add delete_lost option (bug #9300)
  build(autoconf): fix check for ctdb_private.h (bug #9349)
  build(autoconf): check if we have ctdb_protocol.h in the cluster checks
  build(waf): check if we have ctdb_protocol.h in the cluster checks
  s3:ctdb library: fix the build against older ctdb versions
  s3-torture:test_ctdbconn: fix the build against older ctdb versions
  build(waf): Fail configure --with-cluster-support if ctdb support is 
not available.
  docs-xml: fix use of smbconfoption tag (fix bug #9345)

Björn Jacke (9):
  wafbuild: check for dn_expand also in libinet
  autoconf: check for dn_expand also in libinet
  quota: also log which fs type we found
  wfabuild: fix the -errwarn compile flag test
  wafbuild: merge the missing IBM compiler Werror flag -qhalt=w to waf
  wafbuild: reorder the Werror checks so that the ambigous w2 option is 
being checked last
  

autobuild: intermittent test failure detected

2012-11-13 Thread autobuild
The autobuild test system has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey/2012-11-13-0915/flakey.log

The samba3 build logs are available here:

   http://git.samba.org/autobuild.flakey/2012-11-13-0915/samba3.stderr
   http://git.samba.org/autobuild.flakey/2012-11-13-0915/samba3.stdout

The source4 build logs are available here:

   http://git.samba.org/autobuild.flakey/2012-11-13-0915/samba.stderr
   http://git.samba.org/autobuild.flakey/2012-11-13-0915/samba.stdout
  
The top commit at the time of the failure was:

commit c5f53ed580d92088f544a7d66b8b276fef8f3ab7
Author: Andrew Bartlett abart...@samba.org
Date:   Mon Nov 12 21:49:36 2012 +1100

Revert selftest/skip: add samba.tests.samba_tool.gpo until it's stable

This reverts commit 47bbf9886f0cebf994435a32bafa07e36cce191b.

This test appears to be stable now, but the changes in the previous
commit should allow the real error to be found if it comes back.

As requested by metze.

Andrew Bartlett

Reviewed-by: Jelmer Vernooij jel...@samba.org

Autobuild-User(master): Andrew Bartlett abart...@samba.org
Autobuild-Date(master): Tue Nov 13 01:45:04 CET 2012 on sn-devel-104


[SCM] Samba Website Repository - branch master updated

2012-11-13 Thread Karolin Seeger
The branch, master has been updated
   via  5ab7e00 Announce Samba 4.0.0rc5.
  from  e340cc6 Use correct version number

http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master


- Log -
commit 5ab7e00ab2b62f6202e3eae2bfeec59589a10d88
Author: Karolin Seeger ksee...@samba.org
Date:   Tue Nov 13 09:27:14 2012 +0100

Announce Samba 4.0.0rc5.

Karolin

---

Summary of changes:
 generated_news/latest_10_bodies.html|   21 +
 generated_news/latest_10_headlines.html |4 ++--
 generated_news/latest_2_bodies.html |   20 ++--
 3 files changed, 21 insertions(+), 24 deletions(-)


Changeset truncated at 500 lines:

diff --git a/generated_news/latest_10_bodies.html 
b/generated_news/latest_10_bodies.html
index e37c338..6f092f1 100644
--- a/generated_news/latest_10_bodies.html
+++ b/generated_news/latest_10_bodies.html
@@ -1,3 +1,12 @@
+   h5a name=4.0.0rc513 November 2012/a/h5
+   p class=headlineSamba 4.0.0rc5 Available for Download/p
+   pThis is the fifth release candidate of the Samba 4.0 series./p
+
+pThe uncompressed tarballs and patch files have been signed
+using GnuPG (ID 6568B7EA).  The source code can be
+a 
href=https://download.samba.org/pub/samba/rc/samba-4.0.0rc5.tar.gz;downloaded 
now/a.
+See a 
href=https://download.samba.org/pub/samba/rc/WHATSNEW-4-0-0rc5.txt;the 
release notes for more info/a./p
+
h5a name=3.5.1905 November 2012/a/h5
p class=headlineSamba 3.5.19 Available for Download/p
pThis is the latest stable release of the Samba 3.5 series./p
@@ -84,15 +93,3 @@ See a 
href=https://download.samba.org/pub/samba/rc/WHATSNEW-4-0-0rc1.txt;the
 using GnuPG (ID 6568B7EA).  The source code can be
 a href=http://samba.org/samba/ftp/stable/samba-3.5.17.tar.gz;downloaded
 now/a. A a 
href=http://samba.org/samba/ftp/patches/patch-3.5.16-3.5.17.diffs.gz;patch 
against Samba 3.5.16/a is also available. See a 
href=http://samba.org/samba/history/samba-3.5.17.html;the release notes for 
more info/a./p
-
-   h5a name=3.6.706 August 2012/a/h5
-   p class=headlineSamba 3.6.7 Available for Download/p
-   pThis is the latest stable release of the Samba 3.6 series./p
-
-pThe uncompressed tarballs and patch files have been signed
-using GnuPG (ID 6568B7EA).  The source code can be
-a href=http://samba.org/samba/ftp/stable/samba-3.6.7.tar.gz;downloaded
-now/a. A a 
href=http://samba.org/samba/ftp/patches/patch-3.6.6-3.6.7.diffs.gz;
-patch against Samba 3.6.6/a is also available.
-See a href=http://samba.org/samba/history/samba-3.6.7.html;
-the release notes for more info/a./p
diff --git a/generated_news/latest_10_headlines.html 
b/generated_news/latest_10_headlines.html
index 42d11f6..c8482b4 100644
--- a/generated_news/latest_10_headlines.html
+++ b/generated_news/latest_10_headlines.html
@@ -1,4 +1,6 @@
 ul
+   li 13 November 2012 a href=#4.0.0rc5Samba 4.0.0rc5 Available for 
Download/a/li
+
li 05 November 2012 a href=#3.5.19Samba 3.5.19 Available for 
Download/a/li
 
li 30 October 2012 a href=#4.0.0rc4Samba 4.0.0rc4 Available for 
Download/a/li
@@ -16,6 +18,4 @@
li 13 September 2012 a href=#4.0.0rc1Samba 4.0.0rc1 Available for 
Download/a/li
 
li 13 August 2012 a href=#3.5.17Samba 3.5.17 Available for 
Download/a/li
-
-   li 06 August 2012 a href=#3.6.7Samba 3.6.7 Available for 
Download/a/li
 /ul
diff --git a/generated_news/latest_2_bodies.html 
b/generated_news/latest_2_bodies.html
index 96ff3a2..eba0e2f 100644
--- a/generated_news/latest_2_bodies.html
+++ b/generated_news/latest_2_bodies.html
@@ -1,18 +1,18 @@
-   h5a name=3.5.1905 November 2012/a/h5
-   p class=headlineSamba 3.5.19 Available for Download/p
-   pThis is the latest stable release of the Samba 3.5 series./p
+   h5a name=4.0.0rc513 November 2012/a/h5
+   p class=headlineSamba 4.0.0rc5 Available for Download/p
+   pThis is the fifth release candidate of the Samba 4.0 series./p
 
 pThe uncompressed tarballs and patch files have been signed
 using GnuPG (ID 6568B7EA).  The source code can be
-a href=http://samba.org/samba/ftp/stable/samba-3.5.19.tar.gz;downloaded
-now/a. A a 
href=http://samba.org/samba/ftp/patches/patch-3.5.18-3.5.19.diffs.gz;patch 
against Samba 3.5.18/a is also available. See a 
href=http://samba.org/samba/history/samba-3.5.19.html;the release notes for 
more info/a./p
+a 
href=https://download.samba.org/pub/samba/rc/samba-4.0.0rc5.tar.gz;downloaded 
now/a.
+See a 
href=https://download.samba.org/pub/samba/rc/WHATSNEW-4-0-0rc5.txt;the 
release notes for more info/a./p
 
 
-   h5a name=4.0.0rc430 October 2012/a/h5
-   p class=headlineSamba 4.0.0rc4 Available for Download/p
-   pThis is the fourth release candidate of the Samba 4.0 series./p
+   h5a name=3.5.1905 November 2012/a/h5
+   p 

[SCM] Samba Shared Repository - branch v3-6-test updated

2012-11-13 Thread Karolin Seeger
The branch, v3-6-test has been updated
   via  8ba1bdf s3:winbind: BUG 9386: Failover if netlogon pipe is not 
available.
  from  5fbedc1 lib/krb5_wrap: request enc_types in the correct order (bug 
#9272)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -
commit 8ba1bdfe5ee784c6652c329760a8226e9da4a8a8
Author: Andreas Schneider a...@samba.org
Date:   Fri Nov 9 15:33:09 2012 +0100

s3:winbind: BUG 9386: Failover if netlogon pipe is not available.

Samba continues to query a broken DC while the DC did not finish to
rebuild Sysvol (after a Windows crash, for example). It causes end users
to received strange codes while trying to authenticate, even if there is
a secondary DC available.

Signed-off-by: Andreas Schneider a...@samba.org
Reviewed-by: Stefan Metzmacher me...@samba.org

Autobuild-User(master): Stefan Metzmacher me...@samba.org
Autobuild-Date(master): Mon Nov 12 18:57:18 CET 2012 on sn-devel-104
(cherry picked from commit 3b01dd5f59841b11e9906b8c23345946e0d0ea8c)

---

Summary of changes:
 source3/winbindd/winbindd_pam.c |   52 +-
 1 files changed, 39 insertions(+), 13 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
index 619b632..a966202 100644
--- a/source3/winbindd/winbindd_pam.c
+++ b/source3/winbindd/winbindd_pam.c
@@ -1152,6 +1152,7 @@ static NTSTATUS winbind_samlogon_retry_loop(struct 
winbindd_domain *domain,
struct netr_SamInfo3 **info3)
 {
int attempts = 0;
+   int netr_attempts = 0;
bool retry = false;
NTSTATUS result;
 
@@ -1166,22 +1167,47 @@ static NTSTATUS winbind_samlogon_retry_loop(struct 
winbindd_domain *domain,
result = cm_connect_netlogon(domain, netlogon_pipe);
 
if (!NT_STATUS_IS_OK(result)) {
-   DEBUG(3,(could not open handle to NETLOGON pipe 
(error: %s)\n,
- nt_errstr(result)));
-   if (NT_STATUS_EQUAL(result, NT_STATUS_IO_TIMEOUT)) {
-   if (attempts  0) {
-   DEBUG(3, (This is the second problem 
for this 
-   particular call, forcing the 
close of 
-   this connection\n));
-   invalidate_cm_connection(domain-conn);
-   } else {
-   DEBUG(3, (First call to 
cm_connect_netlogon 
-   has timed out, retrying\n));
-   continue;
-   }
+   DEBUG(3,(Could not open handle to NETLOGON pipe 
+(error: %s, attempts: %d)\n,
+ nt_errstr(result), netr_attempts));
+
+   /* After the first retry always close the connection */
+   if (netr_attempts  0) {
+   DEBUG(3, (This is again a problem for this 
+ particular call, forcing the close 
+ of this connection\n));
+   invalidate_cm_connection(domain-conn);
+   }
+
+   /* After the second retry failover to the next DC */
+   if (netr_attempts  1) {
+   /*
+* If the netlogon server is not reachable then
+* it is possible that the DC is rebuilding
+* sysvol and shutdown netlogon for that time.
+* We should failover to the next dc.
+*/
+   DEBUG(3, (This is the third problem for this 
+ particular call, adding DC to the 
+ negative cache list\n));
+   add_failed_connection_entry(domain-name,
+   domain-dcname,
+   result);
+   saf_delete(domain-name);
+   }
+
+   /* Only allow 3 retries */
+   if (netr_attempts  3) {
+   DEBUG(3, (The connection to netlogon 
+ failed, retrying\n));
+   netr_attempts++;
+   retry = true;
+ 

[SCM] Samba Shared Repository - branch master updated

2012-11-13 Thread Stefan Metzmacher
The branch, master has been updated
   via  095c762 selftest: Add --tmpdir to 'samba-tool gpo create' test
  from  c5f53ed Revert selftest/skip: add samba.tests.samba_tool.gpo until 
it's stable

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 095c7627dfbc1e25665d342699ea004dc8d0880b
Author: Andrew Bartlett abart...@samba.org
Date:   Tue Nov 13 13:31:53 2012 +1100

selftest: Add --tmpdir to 'samba-tool gpo create' test

This was the cause of the flakey test, and was only noticed when
multiple different users ran autobuild at the same time on the same
server.

We use shutil.rmtree to wipe the directory before the tests finishes
as required by the TestCaseInTempDir class.

Andrew Bartlett

Reviewed-by: Stefan Metzmacher me...@samba.org

Autobuild-User(master): Stefan Metzmacher me...@samba.org
Autobuild-Date(master): Tue Nov 13 10:50:56 CET 2012 on sn-devel-104

---

Summary of changes:
 .../python/samba/tests/samba_tool/base.py  |2 +-
 .../scripting/python/samba/tests/samba_tool/gpo.py |   10 --
 2 files changed, 9 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/scripting/python/samba/tests/samba_tool/base.py 
b/source4/scripting/python/samba/tests/samba_tool/base.py
index 26ce459..60ccaa5 100644
--- a/source4/scripting/python/samba/tests/samba_tool/base.py
+++ b/source4/scripting/python/samba/tests/samba_tool/base.py
@@ -29,7 +29,7 @@ from cStringIO import StringIO
 from samba.netcmd.main import cmd_sambatool
 import samba.tests
 
-class SambaToolCmdTest(samba.tests.TestCase):
+class SambaToolCmdTest(samba.tests.TestCaseInTempDir):
 
 def getSamDB(self, *argv):
 a convenience function to get a samdb instance so that we can query 
it
diff --git a/source4/scripting/python/samba/tests/samba_tool/gpo.py 
b/source4/scripting/python/samba/tests/samba_tool/gpo.py
index c2e069d..7ada91f 100644
--- a/source4/scripting/python/samba/tests/samba_tool/gpo.py
+++ b/source4/scripting/python/samba/tests/samba_tool/gpo.py
@@ -20,6 +20,7 @@
 
 import os
 from samba.tests.samba_tool.base import SambaToolCmdTest
+import shutil
 
 class GpoCmdTestCase(SambaToolCmdTest):
 Tests for samba-tool time subcommands
@@ -39,13 +40,18 @@ os.environ[SERVER])
 
 def test_fetch(self):
 Run against a real GPO, and make sure it passes
-(result, out, err) = self.runsubcmd(gpo, fetch, self.gpo_guid, 
-H, ldap://%s; % os.environ[SERVER], --tmpdir, 
os.environ['SELFTEST_PREFIX'])
+(result, out, err) = self.runsubcmd(gpo, fetch, self.gpo_guid, 
-H, ldap://%s; % os.environ[SERVER], --tmpdir, self.tempdir)
 self.assertCmdSuccess(result, Ensuring gpo fetched successfully)
+shutil.rmtree(os.path.join(self.tempdir, policy))
 
 def setUp(self):
 set up a temporary GPO to work with
 super(GpoCmdTestCase, self).setUp()
-(result, out, err) = self.runsubcmd(gpo, create, self.gpo_name, 
-H, ldap://%s; % os.environ[SERVER], -U%s%%%s % (os.environ[USERNAME], 
os.environ[PASSWORD]))
+(result, out, err) = self.runsubcmd(gpo, create, self.gpo_name,
+-H, ldap://%s; % 
os.environ[SERVER],
+-U%s%%%s % 
(os.environ[USERNAME], os.environ[PASSWORD]),
+--tmpdir, self.tempdir)
+shutil.rmtree(os.path.join(self.tempdir, policy))
 self.assertCmdSuccess(result, Ensuring gpo created successfully)
 try:
 self.gpo_guid = {%s} % out.split({)[1].split(})[0]


-- 
Samba Shared Repository


autobuild: intermittent test failure detected

2012-11-13 Thread autobuild
The autobuild test system has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey/2012-11-13-1116/flakey.log

The samba3 build logs are available here:

   http://git.samba.org/autobuild.flakey/2012-11-13-1116/samba3.stderr
   http://git.samba.org/autobuild.flakey/2012-11-13-1116/samba3.stdout

The source4 build logs are available here:

   http://git.samba.org/autobuild.flakey/2012-11-13-1116/samba.stderr
   http://git.samba.org/autobuild.flakey/2012-11-13-1116/samba.stdout
  
The top commit at the time of the failure was:

commit c5f53ed580d92088f544a7d66b8b276fef8f3ab7
Author: Andrew Bartlett abart...@samba.org
Date:   Mon Nov 12 21:49:36 2012 +1100

Revert selftest/skip: add samba.tests.samba_tool.gpo until it's stable

This reverts commit 47bbf9886f0cebf994435a32bafa07e36cce191b.

This test appears to be stable now, but the changes in the previous
commit should allow the real error to be found if it comes back.

As requested by metze.

Andrew Bartlett

Reviewed-by: Jelmer Vernooij jel...@samba.org

Autobuild-User(master): Andrew Bartlett abart...@samba.org
Autobuild-Date(master): Tue Nov 13 01:45:04 CET 2012 on sn-devel-104


[SCM] Samba Shared Repository - branch v4-0-test updated

2012-11-13 Thread Karolin Seeger
The branch, v4-0-test has been updated
   via  e46a6cd s3:winbind: BUG 9386: Failover if netlogon pipe is not 
available.
   via  6c0b864 Use work around for 'winbind use default domain' only if it 
is set
   via  6f25fde build: add DMAPI configure option and checks
   via  182ab92 build(waf): support AIX 6.1
   via  e122c7d Fix bug 9376 - ensure_canon_entry_valid generates duplicate 
SMB_ACL_GROUP, acl_valid fails.
  from  c06af93 VERSION: Bump version number up to 4.0.0rc6.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test


- Log -
commit e46a6cdde950c33a7cc84e0b7249774e5dbd06ae
Author: Andreas Schneider a...@samba.org
Date:   Fri Nov 9 15:33:09 2012 +0100

s3:winbind: BUG 9386: Failover if netlogon pipe is not available.

Samba continues to query a broken DC while the DC did not finish to
rebuild Sysvol (after a Windows crash, for example). It causes end users
to received strange codes while trying to authenticate, even if there is
a secondary DC available.

Signed-off-by: Andreas Schneider a...@samba.org
Reviewed-by: Stefan Metzmacher me...@samba.org

Autobuild-User(master): Stefan Metzmacher me...@samba.org
Autobuild-Date(master): Mon Nov 12 18:57:18 CET 2012 on sn-devel-104
(cherry picked from commit 3b01dd5f59841b11e9906b8c23345946e0d0ea8c)

Autobuild-User(v4-0-test): Karolin Seeger ksee...@samba.org
Autobuild-Date(v4-0-test): Tue Nov 13 11:30:33 CET 2012 on sn-devel-104

commit 6c0b864654001046b8bbb585112e60a7e146cb2a
Author: Sumit Bose sb...@redhat.com
Date:   Mon Oct 29 12:09:22 2012 +0100

Use work around for 'winbind use default domain' only if it is set

Currently in smb_getpwnam() the NetBIOS domain name and the winbind 
separator
character is always added to the user name returned by Get_Pwnam_alloc() if 
it
does not contain the winbind separator character. As comments in the code
indicates this is done as a work around if 'winbind use default domain' is 
set
to yes in the samba configuration.

This make sense if the option is set because otherwise the domain 
information is
lost from the user name. But it causes errors if other services than 
winbind are
used for user lookup, e.g. sssd. sssd can handle different kind of fully
qualified user names as input, e.g. u...@domain.name or DOM\user, but 
returns a
canonical name, by default u...@domain.name.

While it would be possible to get around this issue with a special 
configuration
either on the sssd or samba side I think the cleaner solution is to use the 
work
around only if 'winbind use default domain' is set to yes which is what this
patch does.

Fix bug #9367 - Use work around for 'winbind use default domain' only if it 
is
set.

commit 6f25fde34d3e0b9caed17153bf89badfa4479d19
Author: Christian Ambach a...@samba.org
Date:   Wed Nov 7 18:40:07 2012 +0100

build: add DMAPI configure option and checks

the waf build was missing the --with-dmapi option
and configure checks that are necessary to build the
source3 parts that need DMAPI (e.g. vfs_tsmsm)

Bug: https://bugzilla.samba.org/show_bug.cgi?id=9178

Signed-off-by: Christian Ambach a...@samba.org

commit 182ab925210153285886bd2052cdee96d89d6cdd
Author: Christian Ambach a...@samba.org
Date:   Fri Nov 9 18:58:43 2012 -0600

build(waf): support AIX 6.1

on AIX6.1, we need to define _ALL_SOURCE as well, otherwise
system headers with BSD types like u_int cannot be used

commit e122c7d24b10119c9ea4d65e0099ff1690394457
Author: Arvid Requate requ...@univention.de
Date:   Sat Nov 10 09:21:30 2012 -0800

Fix bug 9376 - ensure_canon_entry_valid generates duplicate SMB_ACL_GROUP, 
acl_valid fails.

s3:smbd: typo in got_duplicate_group check.

Due to a typo in posix_acl.c:ensure_canon_entry_valid_on_set the function
returns invalid ACLs in some cases. Specifically it genereates a 
SMB_ACL_GROUP
for a SMB_ACL_GROUP_OBJ, where the required SMB_ACL_GROUP ace is already
present. This can result in a failure of acl_valid in vfs_acl_xattr.

---

Summary of changes:
 buildtools/wafsamba/wscript |2 +-
 source3/auth/auth_util.c|3 +-
 source3/smbd/posix_acls.c   |2 +-
 source3/winbindd/winbindd_pam.c |   52 +++
 source3/wscript |   64 +++
 source3/wscript_build   |2 +-
 6 files changed, 108 insertions(+), 17 deletions(-)


Changeset truncated at 500 lines:

diff --git a/buildtools/wafsamba/wscript b/buildtools/wafsamba/wscript
index 441e727..17aef27 100755
--- a/buildtools/wafsamba/wscript
+++ b/buildtools/wafsamba/wscript
@@ -322,7 +322,7 @@ def configure(conf):
 else:
 

[SCM] Samba Shared Repository - branch master updated

2012-11-13 Thread Andrew Bartlett
The branch, master has been updated
   via  6f47497 lib/ldb: add missing newline in the output of 
ldb_ldif_write_trace()
   via  11f5d54 s4:samba-tool/testparm: report a CommandError if loading of 
the config file fails
   via  1ecc76b lib/addns: remove compiler warnings
   via  eecc1d2 lib/addns: don't depend on the order in resp-answers[]
   via  b59c5db lib/addns: remove pointless check for resp-num_additionals 
!= 1
  from  095c762 selftest: Add --tmpdir to 'samba-tool gpo create' test

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 6f47497610352f72128bdbcd3b45313ea9a265ab
Author: Stefan Metzmacher me...@samba.org
Date:   Mon Nov 12 11:42:52 2012 +0100

lib/ldb: add missing newline in the output of ldb_ldif_write_trace()

Signed-off-by: Stefan Metzmacher me...@samba.org

Reviewed-by: Andrew Bartlett abart...@samba.org

Autobuild-User(master): Andrew Bartlett abart...@samba.org
Autobuild-Date(master): Tue Nov 13 13:53:31 CET 2012 on sn-devel-104

commit 11f5d54cbb10fd5c5f0e1718427609709c3476f4
Author: Stefan Metzmacher me...@samba.org
Date:   Fri Nov 9 09:01:29 2012 +0100

s4:samba-tool/testparm: report a CommandError if loading of the config file 
fails

Signed-off-by: Stefan Metzmacher me...@samba.org

Reviewed-by: Andrew Bartlett abart...@samba.org

commit 1ecc76b2480c884a66e598ff6b1f9000bb0931c0
Author: Stefan Metzmacher me...@samba.org
Date:   Fri Nov 9 09:08:51 2012 +0100

lib/addns: remove compiler warnings

Signed-off-by: Stefan Metzmacher me...@samba.org

Reviewed-by: Andrew Bartlett abart...@samba.org

commit eecc1d294256210ee8c2f6ab79d21b835258a6d4
Author: Stefan Metzmacher me...@samba.org
Date:   Fri Nov 9 08:59:36 2012 +0100

lib/addns: don't depend on the order in resp-answers[]

Signed-off-by: Stefan Metzmacher me...@samba.org

Reviewed-by: Andrew Bartlett abart...@samba.org

commit b59c5db5f74f56c0536635a41ae51c389109ceb5
Author: Stefan Metzmacher me...@samba.org
Date:   Fri Nov 9 08:55:40 2012 +0100

lib/addns: remove pointless check for resp-num_additionals != 1

We never use resp-additionals, so there's no reason to check.

This fixes dns updates against BIND9 (used in a Samba4 domain).

Signed-off-by: Stefan Metzmacher me...@samba.org

Reviewed-by: Andrew Bartlett abart...@samba.org

---

Summary of changes:
 lib/addns/dnsgss.c|   20 ++--
 lib/ldb/common/ldb_ldif.c |2 +-
 source4/scripting/python/samba/netcmd/testparm.py |5 -
 3 files changed, 19 insertions(+), 8 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/addns/dnsgss.c b/lib/addns/dnsgss.c
index 64a7d85..f7ed1d1 100644
--- a/lib/addns/dnsgss.c
+++ b/lib/addns/dnsgss.c
@@ -92,7 +92,7 @@ static DNS_ERROR dns_negotiate_gss_ctx_int( TALLOC_CTX 
*mem_ctx,
DNS_ERROR err;
 
gss_OID_desc krb5_oid_desc =
-   { 9, (const char *)\x2a\x86\x48\x86\xf7\x12\x01\x02\x02 };
+   { 9, discard_const(\x2a\x86\x48\x86\xf7\x12\x01\x02\x02) };
 
*ctx = GSS_C_NO_CONTEXT;
input_ptr = NULL;
@@ -164,6 +164,8 @@ static DNS_ERROR dns_negotiate_gss_ctx_int( TALLOC_CTX 
*mem_ctx,
struct dns_request *resp;
struct dns_buffer *buf;
struct dns_tkey_record *tkey;
+   struct dns_rrec *tkey_answer = NULL;
+   uint16_t i;
 
err = dns_receive(mem_ctx, conn, buf);
if (!ERR_DNS_IS_OK(err)) goto error;
@@ -174,10 +176,16 @@ static DNS_ERROR dns_negotiate_gss_ctx_int( TALLOC_CTX 
*mem_ctx,
/*
 * TODO: Compare id and keyname
 */
-   
-   if ((resp-num_additionals != 1) ||
-   (resp-num_answers == 0) ||
-   (resp-answers[0]-type != QTYPE_TKEY)) {
+
+   for (i=0; i  resp-num_answers; i++) {
+   if (resp-answers[i]-type != QTYPE_TKEY) {
+   continue;
+   }
+
+   tkey_answer = resp-answers[i];
+   }
+
+   if (tkey_answer == NULL) {
err = ERROR_DNS_INVALID_MESSAGE;
goto error;
}
@@ -222,7 +230,7 @@ DNS_ERROR dns_negotiate_sec_ctx( const char *target_realm,
gss_name_t targ_name;
 
gss_OID_desc nt_host_oid_desc =
-   {10, (const char *)\x2a\x86\x48\x86\xf7\x12\x01\x02\x02\x01};
+   {10, 

[SCM] Samba Shared Repository - branch master updated

2012-11-13 Thread Andrew Bartlett
The branch, master has been updated
   via  a390a58 scripting ntacls: Do not place a SACL in the GPO filesystem 
ACL
   via  3e2584a ntvfs: Fill in sd-type based on the new ACL being added
   via  d6c7e9b smbd: Remove NT4 compatability handling in posix - NT ACL 
conversion
   via  236977b Change get_nt_acl_no_snum() to return an NTSTATUS, not a 
struct security_descriptor *.
   via  a443429 smbd: Correctly set fsp-is_directory before dealing with 
ACLs
   via  dc05ab8 Ensure we Correctly set fsp-is_directory before dealing 
with ACLs.
  from  6f47497 lib/ldb: add missing newline in the output of 
ldb_ldif_write_trace()

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit a390a5878db627a7f0147699fff97a39013816dc
Author: Andrew Bartlett abart...@samba.org
Date:   Tue Nov 13 16:03:27 2012 +1100

scripting ntacls: Do not place a SACL in the GPO filesystem ACL

On a new GPO created on windows, the SACL is not used.

Andrew Bartlett

Reviewed by: Jeremy Allison j...@samba.org

Autobuild-User(master): Andrew Bartlett abart...@samba.org
Autobuild-Date(master): Wed Nov 14 00:34:50 CET 2012 on sn-devel-104

commit 3e2584a86cc610c000f70105f39e7f3fa881aded
Author: Andrew Bartlett abart...@samba.org
Date:   Tue Nov 13 16:45:03 2012 +1100

ntvfs: Fill in sd-type based on the new ACL being added

Previously we would not change the type field, and just relied on what
was in the original ACL based on the default SD.

This is required to ensure the SEC_DESC_DACL_PROTECTED is set
which is in turn required for GPOs to be set correctly
to match what windows does.

Andrew Bartlett

Reviewed by: Jeremy Allison j...@samba.org

commit d6c7e9b1ed6f7befbb2239350bba4547ef781e58
Author: Andrew Bartlett abart...@samba.org
Date:   Mon Nov 12 17:11:34 2012 +1100

smbd: Remove NT4 compatability handling in posix - NT ACL conversion

NT4 is long dead, and we should not change which ACL we return based
on what we think the client is.  The reason we should not do this, is
that if we are using vfs_acl_xattr then the hash will break if we do.
Additionally, it would require that the python VFS interface set the
global remote_arch to fake up being a modern client.

This instead seems cleaner and removes untested code (the tests are
updated to then handle the results of the modern codepath).

The supporting 'acl compatability' parameter is also removed.

Andrew Bartlett

Reviewed by: Jeremy Allison j...@samba.org

commit 236977bf4642c035bb22cfcd1cee481c5f6c6da1
Author: Andrew Bartlett abart...@samba.org
Date:   Tue Nov 13 12:48:53 2012 -0800

Change get_nt_acl_no_snum() to return an NTSTATUS, not a struct 
security_descriptor *.

Internally change the implementation to use SMB_VFS_GET_NT_ACL()
instead of SMB_VFS_FGET_NT_ACL() with a faked-up file struct.

Andrew Bartlett

Reviewed by: Jeremy Allison j...@samba.org

commit a4434297f19a3520d0f2ac242d4e99576d927ecc
Author: Andrew Bartlett abart...@samba.org
Date:   Tue Nov 13 12:34:35 2012 -0800

smbd: Correctly set fsp-is_directory before dealing with ACLs

Change set_nt_acl_no_snum() to correctly set up the fsp.
This does a stat on a real fsp in set_nt_acl_no_snum.

Reviewed by: Jeremy Allison j...@samba.org

commit dc05ab8e19a26265ace720528f7e9341aea62ee2
Author: Andrew Bartlett abart...@samba.org
Date:   Tue Nov 13 12:21:45 2012 -0800

Ensure we Correctly set fsp-is_directory before dealing with ACLs.

Reviewed by: Jeremy Allison j...@samba.org

---

Summary of changes:
 docs-xml/smbdotconf/vfs/aclcompatibility.xml |   17 --
 lib/param/param_functions.c  |1 -
 lib/param/param_table.c  |   19 ---
 source3/include/proto.h  |1 -
 source3/rpc_server/eventlog/srv_eventlog_nt.c|   11 +-
 source3/smbd/posix_acls.c|  170 +++---
 source3/smbd/proto.h |4 +-
 source3/smbd/pysmbd.c|   29 -
 source3/torture/cmd_vfs.c|2 +-
 source4/libcli/pysmb.c   |7 +-
 source4/ntvfs/posix/pvfs_acl.c   |   21 +++
 source4/scripting/python/samba/ntacls.py |1 -
 source4/scripting/python/samba/tests/posixacl.py |   12 +-
 13 files changed, 91 insertions(+), 204 deletions(-)
 delete mode 100644 docs-xml/smbdotconf/vfs/aclcompatibility.xml


Changeset truncated at 500 lines:

diff --git a/docs-xml/smbdotconf/vfs/aclcompatibility.xml 
b/docs-xml/smbdotconf/vfs/aclcompatibility.xml
deleted file mode 100644
index 95f42cf..000
--- 

[SCM] CTDB repository - branch master updated - ctdb-2.0-2-gf243a91

2012-11-13 Thread Amitay Isaacs
The branch, master has been updated
   via  f243a916ee71013f7402b9c396c2ead88eb3aab0 (commit)
  from  5f58c811127a89f162b6a41ddcd6e944801740a5 (commit)

http://gitweb.samba.org/?p=ctdb.git;a=shortlog;h=master


- Log -
commit f243a916ee71013f7402b9c396c2ead88eb3aab0
Author: Martin Schwenke mar...@meltin.net
Date:   Wed Nov 14 10:37:15 2012 +1100

Eventscripts: 10.interface startup event should only process interfaces once

Provided that monitor_interfaces() sets the state of each interface,
there's no need to mark all interfaces as up before running
monitor_interfaces() in the startup event.  monitor_interfaces() will
set the true status of each interface anyway.  The duplication is
unnecessary and may cause extra action in the recovery daemon because
the state of some interfaces is changed an extra time.

Instead, add a comment at the top of the loop in monitor_interfaces()
to warn against early loop exits.

Signed-off-by: Martin Schwenke mar...@meltin.net

---

Summary of changes:
 config/events.d/10.interface |   11 ---
 1 files changed, 4 insertions(+), 7 deletions(-)


Changeset truncated at 500 lines:

diff --git a/config/events.d/10.interface b/config/events.d/10.interface
index dd54f1e..80b1368 100755
--- a/config/events.d/10.interface
+++ b/config/events.d/10.interface
@@ -56,6 +56,10 @@ monitor_interfaces()
fail=false
up_interfaces_found=false
 
+   # Note that this loop must not exit early.  It must process
+   # all interfaces so that the correct state for each interface
+   # is set in CTDB using mark_up/mark_down.  If there is a
+   # problem with an interface then set fail=true and continue.
for iface in $all_interfaces ; do
 
ip addr show $iface 2/dev/null /dev/null || {
@@ -149,14 +153,7 @@ case $1 in
  # called after ctdbd has done its initial recovery
  # and we start the services to become healthy
  startup)
-   # Assume all links are good initially
-   get_all_interfaces
-   for iface in $all_interfaces ; do
-   ctdb setifacelink $iface up /dev/null 2/dev/null
-   done
-   
monitor_interfaces
-
;;
 
 


-- 
CTDB repository


[SCM] Samba Shared Repository - branch master updated

2012-11-13 Thread Jeremy Allison
The branch, master has been updated
   via  d10c737 smbd_open_one_socket does not use the messaging_context 
variable so why pass it in?
   via  ec423dc A small error message fix in source3/smbd/server.c
  from  a390a58 scripting ntacls: Do not place a SACL in the GPO filesystem 
ACL

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit d10c7378d96d322910e87c21a1a3a3b28b229687
Author: Richard Sharpe realrichardsha...@gmail.com
Date:   Tue Nov 13 13:53:35 2012 -0800

smbd_open_one_socket does not use the messaging_context variable so why 
pass it in?

Reviewed by: Jeremy Allison j...@samba.org

Autobuild-User(master): Jeremy Allison j...@samba.org
Autobuild-Date(master): Wed Nov 14 02:19:46 CET 2012 on sn-devel-104

commit ec423dc2eb1aae408b37034fd497ecef285f7fb9
Author: Richard Sharpe realrichardsha...@gmail.com
Date:   Tue Nov 13 11:27:53 2012 -0800

A small error message fix in source3/smbd/server.c

Removes some incorrect info from an error message
(probably from its old place when it was copied).

Reviewed by: Jeremy Allison j...@samba.org

---

Summary of changes:
 source3/smbd/server.c |5 +
 1 files changed, 1 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/server.c b/source3/smbd/server.c
index 7113eae..1cd9288 100644
--- a/source3/smbd/server.c
+++ b/source3/smbd/server.c
@@ -551,7 +551,7 @@ static void smbd_accept_connection(struct tevent_context 
*ev,
return;
 
if (fd == -1) {
-   DEBUG(0,(open_sockets_smbd: accept: %s\n,
+   DEBUG(0,(accept: %s\n,
 strerror(errno)));
return;
}
@@ -662,7 +662,6 @@ static void smbd_accept_connection(struct tevent_context 
*ev,
 
 static bool smbd_open_one_socket(struct smbd_parent_context *parent,
 struct tevent_context *ev_ctx,
-struct messaging_context *msg_ctx,
 const struct sockaddr_storage *ifss,
 uint16_t port)
 {
@@ -792,7 +791,6 @@ static bool open_sockets_smbd(struct smbd_parent_context 
*parent,
 
if (!smbd_open_one_socket(parent,
  ev_ctx,
- msg_ctx,
  ifss,
  port)) {
return false;
@@ -834,7 +832,6 @@ static bool open_sockets_smbd(struct smbd_parent_context 
*parent,
 
if (!smbd_open_one_socket(parent,
  ev_ctx,
- msg_ctx,
  ss,
  port)) {
return false;


-- 
Samba Shared Repository