autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2013-07-19-1145/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2013-07-19-1145/samba3.stderr http://git.samba.org/autobuild.flakey/2013-07-19-1145/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2013-07-19-1145/samba.stderr http://git.samba.org/autobuild.flakey/2013-07-19-1145/samba.stdout The top commit at the time of the failure was: commit 51c68c28b27cd1644187af32cc4f630a7471cd28 Author: Shekhar Amlekar samle...@in.ibm.com Date: Thu Jul 11 21:12:29 2013 +0530 librpc: srvsvc.idl: define level 1005 share info flags define level 1005 share info flags. Reviewed-by: Günther Deschner g...@samba.org Autobuild-User(master): Günther Deschner g...@samba.org Autobuild-Date(master): Thu Jul 18 16:35:51 CEST 2013 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via bb21fc5 Add torture tests to raw.eas to check sending Windows invalid names in the middle of an EA list. via 5d54ac4 Reply with correct trans2 message on a setpathinfo with a bad EA name. via b50b006 Ensure we do pathname processing before SD and EA processing in NTTRANS_CREATE. via 4a43600 Ensure we can't create a file using NTTRANS with an invalid EA list. via 66fb5ee Ensure we can't create a file using TRANS2_OPEN with an invalid EA list. via fe542fc Add error map of STATUS_INVALID_EA_NAME - ERRDOS, ERRbadfile via 50a288c Add the ability to send an NTSTATUS result back with a trans2 reply so we can return a parameter block with an error code. via 21c9296 Ensure we can't create a file using SMB2_CREATE with an invalid EA list. via 66e7b15 Ensure we never return an EA name to a Windows client it can't handle. via f246d69 Ensure set_ea cannot set invalid Windows EA names. via 1766f9e Add ea_list_has_invalid_name() function. from 51c68c2 librpc: srvsvc.idl: define level 1005 share info flags http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit bb21fc51e42c830d7fab4e89d83f8ef4d122fa1a Author: Jeremy Allison j...@samba.org Date: Tue Jul 9 16:37:48 2013 -0700 Add torture tests to raw.eas to check sending Windows invalid names in the middle of an EA list. Add torture tests to probe the set of invalid Windows EA names. Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing : Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org Autobuild-User(master): Andrew Bartlett abart...@samba.org Autobuild-Date(master): Fri Jul 19 11:50:25 CEST 2013 on sn-devel-104 commit 5d54ac414f2130fcbd434b7c96e1efe4a22cc1ff Author: Jeremy Allison j...@samba.org Date: Tue Jul 16 09:14:12 2013 -0700 Reply with correct trans2 message on a setpathinfo with a bad EA name. Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing : Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org commit b50b006ace92bb0781173b1244e84ae7bf64732f Author: Jeremy Allison j...@samba.org Date: Tue Jul 16 11:05:10 2013 -0700 Ensure we do pathname processing before SD and EA processing in NTTRANS_CREATE. Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing : Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org commit 4a4360070589a314667166f86c395878659123e1 Author: Jeremy Allison j...@samba.org Date: Tue Jul 9 15:54:39 2013 -0700 Ensure we can't create a file using NTTRANS with an invalid EA list. Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing : Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org commit 66fb5eeb968e12049381337d7c01401815537a34 Author: Jeremy Allison j...@samba.org Date: Tue Jul 9 15:59:53 2013 -0700 Ensure we can't create a file using TRANS2_OPEN with an invalid EA list. Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing : Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org commit fe542fc170053a370092fcf442075dc44189f23e Author: Jeremy Allison j...@samba.org Date: Wed Jul 10 12:18:36 2013 -0700 Add error map of STATUS_INVALID_EA_NAME - ERRDOS, ERRbadfile (from Windows2012 tests). Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing : Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org commit 50a288cb6a9bfff1d16cf488bbc0eedcb6ad4602 Author: Jeremy Allison j...@samba.org Date: Wed Jul 10 12:38:41 2013 -0700 Add the ability to send an NTSTATUS result back with a trans2 reply so we can return a parameter block with an error code. This is needed when returning a STATUS_INVALID_NAME result (tested from Windows 2012). Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing : Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org commit 21c92969b8d0ad7a77028d24c5b3fea63264e473 Author: Jeremy Allison j...@samba.org Date: Tue Jul 9 16:02:50 2013 -0700 Ensure we can't create a file using SMB2_CREATE with an invalid EA list. Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing : Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org commit
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 44429f9 s3-printing: avoid KRB5CCNAME overwrite in printer
publishing (Bug #7444).
from bb21fc5 Add torture tests to raw.eas to check sending Windows
invalid names in the middle of an EA list.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 44429f948b72e7bcf968da492592c57864f211c7
Author: Günther Deschner g...@samba.org
Date: Fri Jul 19 15:10:05 2013 +0200
s3-printing: avoid KRB5CCNAME overwrite in printer publishing (Bug #7444).
Guenther
Signed-off-by: Günther Deschner g...@samba.org
Reviewed-by: Andreas Schneider a...@samba.org
Autobuild-User(master): Günther Deschner g...@samba.org
Autobuild-Date(master): Fri Jul 19 17:53:08 CEST 2013 on sn-devel-104
---
Summary of changes:
source3/printing/nt_printing_ads.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/printing/nt_printing_ads.c
b/source3/printing/nt_printing_ads.c
index dcd31b7..5d5f564 100644
--- a/source3/printing/nt_printing_ads.c
+++ b/source3/printing/nt_printing_ads.c
@@ -417,6 +417,7 @@ WERROR nt_printer_publish(TALLOC_CTX *mem_ctx,
ADS_STATUS ads_rc;
ADS_STRUCT *ads = NULL;
WERROR win_rc;
+ char *old_krb5ccname = NULL;
sinfo2 = talloc_zero(mem_ctx, struct spoolss_SetPrinterInfo2);
if (!sinfo2) {
@@ -454,6 +455,7 @@ WERROR nt_printer_publish(TALLOC_CTX *mem_ctx,
win_rc = WERR_SERVER_UNAVAILABLE;
goto done;
}
+ old_krb5ccname = getenv(KRB5_ENV_CCNAME);
setenv(KRB5_ENV_CCNAME, MEMORY:prtpub_cache, 1);
SAFE_FREE(ads-auth.password);
ads-auth.password = secrets_fetch_machine_password(lp_workgroup(),
@@ -479,6 +481,11 @@ WERROR nt_printer_publish(TALLOC_CTX *mem_ctx,
done:
ads_destroy(ads);
+ ads_kdestroy(MEMORY:prtpub_cache);
+ unsetenv(KRB5_ENV_CCNAME);
+ if (old_krb5ccname) {
+ setenv(KRB5_ENV_CCNAME, old_krb5ccname, 0);
+ }
return win_rc;
}
@@ -493,6 +500,7 @@ WERROR check_published_printers(struct messaging_context
*msg_ctx)
struct spoolss_PrinterInfo2 *pinfo2;
NTSTATUS status;
WERROR result;
+ char *old_krb5ccname = NULL;
tmp_ctx = talloc_new(NULL);
if (!tmp_ctx) return WERR_NOMEM;
@@ -502,6 +510,7 @@ WERROR check_published_printers(struct messaging_context
*msg_ctx)
DEBUG(3, (ads_init() failed\n));
return WERR_SERVER_UNAVAILABLE;
}
+ old_krb5ccname = getenv(KRB5_ENV_CCNAME);
setenv(KRB5_ENV_CCNAME, MEMORY:prtpub_cache, 1);
SAFE_FREE(ads-auth.password);
ads-auth.password = secrets_fetch_machine_password(lp_workgroup(),
@@ -546,6 +555,10 @@ WERROR check_published_printers(struct messaging_context
*msg_ctx)
done:
ads_destroy(ads);
ads_kdestroy(MEMORY:prtpub_cache);
+ unsetenv(KRB5_ENV_CCNAME);
+ if (old_krb5ccname) {
+ setenv(KRB5_ENV_CCNAME, old_krb5ccname, 0);
+ }
talloc_free(tmp_ctx);
return result;
}
--
Samba Shared Repository
