autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-04-04-0942/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-04-04-0942/samba.stderr http://git.samba.org/autobuild.flakey/2014-04-04-0942/samba.stdout The top commit at the time of the failure was: commit fc4845f481a01e7e12dd9f4de3a8a434234c339c Author: Shekhar Amlekar samle...@in.ibm.com Date: Tue Mar 25 17:06:18 2014 +0530 s3: rpc_server/srvsvc: count open files in NetConnEnum Signed-off-by: Shekhar Amlekar samle...@in.ibm.com Reviewed-by: Jeremy Allison j...@samba.org Reviewed-by: Christof Schmitt c...@samba.org Autobuild-User(master): Jeremy Allison j...@samba.org Autobuild-Date(master): Thu Apr 3 21:19:43 CEST 2014 on sn-devel-104
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via 7bbd363 Add support limitation as requested by Tom from f17f944 Remove more reduandant copany names http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit 7bbd363e16ea8ba8c5fe2ac04df0aebc45e59157 Author: Lars Müller l...@samba.org Date: Fri Apr 4 13:24:32 2014 +0200 Add support limitation as requested by Tom --- Summary of changes: support/us.html |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/support/us.html b/support/us.html index 6e5f6dd..0a8b6e9 100644 --- a/support/us.html +++ b/support/us.html @@ -176,6 +176,8 @@ Specialty samba capabilities: Plain old samba. /pp Special Notes: Be prepared to provide remote login credentials if customer is not located in the Cincinnati area. +Our support offerings are limited to Cincinnati, OH., Dayton, OH., and +Northern KY. /p -- Samba Website Repository
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via 5db2f26 Refine dentar's support offering from 7bbd363 Add support limitation as requested by Tom http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit 5db2f26fef47dee739e2c922adefb7a2821baaf4 Author: Lars Müller l...@samba.org Date: Fri Apr 4 16:19:06 2014 +0200 Refine dentar's support offering --- Summary of changes: support/us.html |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/support/us.html b/support/us.html index 0a8b6e9..dc1cb50 100644 --- a/support/us.html +++ b/support/us.html @@ -174,8 +174,8 @@ server support, Samba support, Hardware support, Operating systems support /pp Specialty samba capabilities: Plain old samba. /pp -Special Notes: Be prepared to provide remote login credentials if customer -is not located in the Cincinnati area. +Special Notes: Be prepared to provide remote login credentials to both +Windows and Linux/UNIX for testing. Our support offerings are limited to Cincinnati, OH., Dayton, OH., and Northern KY. /p -- Samba Website Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 5f8f1be s3-kerberos: make ipv6 support for generated krb5 config
files more robust.
from fc4845f s3: rpc_server/srvsvc: count open files in NetConnEnum
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 5f8f1be7a8595e74218624367bb7b643c2d0bb27
Author: Günther Deschner g...@samba.org
Date: Wed Apr 2 19:37:34 2014 +0200
s3-kerberos: make ipv6 support for generated krb5 config files more robust.
Older MIT Kerberos libraries will add any secondary ipv6 address as
ipv4 address, defining the (default) krb5 port 88 circumvents that.
Guenther
Signed-off-by: Günther Deschner g...@samba.org
Reviewed-by: Andreas Schneider a...@samba.org
Autobuild-User(master): Günther Deschner g...@samba.org
Autobuild-Date(master): Fri Apr 4 16:33:12 CEST 2014 on sn-devel-104
---
Summary of changes:
source3/libads/kerberos.c | 29 +++--
1 files changed, 27 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c
index 649e568..f3c23ea 100644
--- a/source3/libads/kerberos.c
+++ b/source3/libads/kerberos.c
@@ -615,6 +615,31 @@ static void add_sockaddr_unique(struct sockaddr_storage
*addrs, int *num_addrs,
*num_addrs += 1;
}
+/* print_canonical_sockaddr prints an ipv6 addr in the form of
+* [ipv6.addr]. This string, when put in a generated krb5.conf file is not
+* always properly dealt with by some older krb5 libraries. Adding the
hard-coded
+* portnumber workarounds the issue. - gd */
+
+static char *print_canonical_sockaddr_with_port(TALLOC_CTX *mem_ctx,
+ const struct sockaddr_storage
*pss)
+{
+ char *str = NULL;
+
+ str = print_canonical_sockaddr(mem_ctx, pss);
+ if (str == NULL) {
+ return NULL;
+ }
+
+ if (pss-ss_family != AF_INET6) {
+ return str;
+ }
+
+#if defined(HAVE_IPV6)
+ str = talloc_asprintf_append(str, :88);
+#endif
+ return str;
+}
+
static char *get_kdc_ip_string(char *mem_ctx,
const char *realm,
const char *sitename,
@@ -634,7 +659,7 @@ static char *get_kdc_ip_string(char *mem_ctx,
struct netlogon_samlogon_response **responses = NULL;
NTSTATUS status;
char *kdc_str = talloc_asprintf(mem_ctx, %s\tkdc = %s\n, ,
- print_canonical_sockaddr(mem_ctx, pss));
+
print_canonical_sockaddr_with_port(mem_ctx, pss));
if (kdc_str == NULL) {
TALLOC_FREE(frame);
@@ -726,7 +751,7 @@ static char *get_kdc_ip_string(char *mem_ctx,
/* Append to the string - inefficient but not done often. */
new_kdc_str = talloc_asprintf(mem_ctx, %s\tkdc = %s\n,
kdc_str,
- print_canonical_sockaddr(mem_ctx,
dc_addrs[i]));
+
print_canonical_sockaddr_with_port(mem_ctx, dc_addrs[i]));
if (new_kdc_str == NULL) {
goto fail;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v4-1-test updated
The branch, v4-1-test has been updated via dadd863 s3: messages: Implement cleanup of dead records. via bdd6da6 s3:libsmb: SMBC_getatr() if no method worked, try all methods again on next attempt via 4aa742a client: use cli_qpathinfo3 for allinfo via 0874ff2 s3:libsmb: cli_qpathinfo3 use cli_qpathinfo2 for smb2 via e98e835 client: remove a write only variable via 66115ff s3:libsmb: SMBC_getatr use pathinfo3 for second try via 0bea2d2 s3:libsmb: SMBC_getatr do not let ino undefined on success via d15c014 s3:libsmb: SMBC_getatr try pathinfo2 only once via 976030c s3:libsmb: add function cli_qpathinfo3() via f76511c s3:libsmb: add function cli_qpathinfo_standard() via 1f4b445 s3:libsmb: pass creation or birth time in cli_qpathinfo_basic() via b1c6431 rpcclient: abort shadow-copy set on commit failure via 400e4f0 rpcclient: append a trailing slash to FSRVP request UNCs via c9703c9 s3: smbd: Ensure we always go via getgroups_unix_user() when creating an NT token. from 34fcb4e lsa.idl: define lsa.ForestTrustCollisionInfo and ForestTrustCollisionRecord as public structs http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-1-test - Log - commit dadd86364f300d952e3c6ad825c8da04a3f45e5d Author: Jeremy Allison j...@samba.org Date: Wed Apr 2 16:45:25 2014 -0700 s3: messages: Implement cleanup of dead records. When a smbd process dies, pending messages.tdb records for this process might not get cleaned up. Implement a cleanup for dead records that is triggered after a smbd dies uncleanly; the records for that PID are deleted. Based on a patchset from Christof Schmitt c...@samba.org. Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Christof Schmitt c...@samba.org (cherry picked from commit 837671f47670b16726aa96ba7a0902974a1037eb) Bug: https://bugzilla.samba.org/show_bug.cgi?id=10534 Cleanup messages.tdb record after unclean smbd shutdown Autobuild-User(v4-1-test): Karolin Seeger ksee...@samba.org Autobuild-Date(v4-1-test): Fri Apr 4 23:07:07 CEST 2014 on sn-devel-104 commit bdd6da6d93689cd94d9b7f92e43f01f6cdbd58d9 Author: Gregor Beck gb...@sernet.de Date: Fri Oct 18 15:32:55 2013 +0200 s3:libsmb: SMBC_getatr() if no method worked, try all methods again on next attempt Signed-off-by: Gregor Beck gb...@sernet.de Reviewed-by: Stefan Metzmacher me...@samba.org Reviewed-by: Jeremy Allison j...@samba.org The last 10 patches address bug #10230 - (lib)smbclient fails with NetApp. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10230 commit 4aa742a3d374b578df73594336c79bb49fe11d83 Author: Gregor Beck gb...@sernet.de Date: Mon Oct 14 11:44:36 2013 +0200 client: use cli_qpathinfo3 for allinfo Signed-off-by: Gregor Beck gb...@sernet.de Reviewed-by: Stefan Metzmacher me...@samba.org Reviewed-by: Jeremy Allison j...@samba.org commit 0874ff20b91f62a09173d25bc899a348426c9fd4 Author: Gregor Beck gb...@sernet.de Date: Mon Oct 14 11:43:45 2013 +0200 s3:libsmb: cli_qpathinfo3 use cli_qpathinfo2 for smb2 cli_qpathinfo3 only works (and is only needed as fallback so far) for smb1. Use cli_qpathinfo2 in the smb2 case to make it universally usable. Signed-off-by: Gregor Beck gb...@sernet.de Reviewed-by: Stefan Metzmacher me...@samba.org Reviewed-by: Jeremy Allison j...@samba.org commit e98e83558ef253cf2a380d8f1556254e3707f055 Author: Gregor Beck gb...@sernet.de Date: Fri Oct 11 11:05:06 2013 +0200 client: remove a write only variable Signed-off-by: Gregor Beck gb...@sernet.de Reviewed-by: Stefan Metzmacher me...@samba.org Reviewed-by: Jeremy Allison j...@samba.org commit 66115ff2b39d6ed732c2abf20f4d04d7e89326a1 Author: Gregor Beck gb...@sernet.de Date: Fri Oct 11 11:02:24 2013 +0200 s3:libsmb: SMBC_getatr use pathinfo3 for second try The pathinfo2 call might fail against NetApp because it is sending broken packages. Signed-off-by: Gregor Beck gb...@sernet.de Reviewed-by: Stefan Metzmacher me...@samba.org Reviewed-by: Jeremy Allison j...@samba.org commit 0bea2d23b3af7f2ac063a617c31a8371de7b5fcb Author: Gregor Beck gb...@sernet.de Date: Fri Oct 11 11:00:48 2013 +0200 s3:libsmb: SMBC_getatr do not let ino undefined on success Signed-off-by: Gregor Beck gb...@sernet.de Reviewed-by: Stefan Metzmacher me...@samba.org Reviewed-by: Jeremy Allison j...@samba.org commit d15c014000fe3e215b48e45fdafbde4c7c810a91 Author: Gregor Beck gb...@sernet.de Date: Fri Oct 11 10:59:59 2013 +0200 s3:libsmb: SMBC_getatr try pathinfo2 only once Signed-off-by: Gregor Beck gb...@sernet.de Reviewed-by: Stefan Metzmacher me...@samba.org Reviewed-by: Jeremy Allison j...@samba.org
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via e1df75b5 talloc: Update flags in pytalloc-util pkgconfig file
via a83c524 tevent: Update flags in tevent pkgconfig file
from 5f8f1be s3-kerberos: make ipv6 support for generated krb5 config
files more robust.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit e1df75b5a965829db0c1f76673dcc824447b3ae7
Author: Lukas Slebodnik lsleb...@redhat.com
Date: Fri Apr 4 13:29:39 2014 +0200
talloc: Update flags in pytalloc-util pkgconfig file
After exapnding, @LIB_RPATH@ will be -Wl,-rpatch,/usr/local/lib if rpath is
used on install. But -Wl, will be passed to linker and should not be among
CFLAGS. Other pkgconfig files have @LIB_RPATH@ in the right place.
@see commit 735c1cd2da15167748e92ba6de48fdb5169db587
Signed-off-by: Lukas Slebodnik lsleb...@redhat.com
Reviewed-by: Andrew Bartlett abart...@samba.org
Reviewed-by: Stefan Metzmacher me...@samba.org
Autobuild-User(master): Andrew Bartlett abart...@samba.org
Autobuild-Date(master): Fri Apr 4 23:50:25 CEST 2014 on sn-devel-104
commit a83c5240b1332d5a97dd21ecd3666a9c2ff38643
Author: Lukas Slebodnik lsleb...@redhat.com
Date: Fri Apr 4 13:27:35 2014 +0200
tevent: Update flags in tevent pkgconfig file
After exapnding, @LIB_RPATH@ will be -Wl,-rpatch,/usr/local/lib if rpath is
used on install. But -Wl, will be passed to linker and should not be among
CFLAGS. Other pkgconfig files have @LIB_RPATH@ in the right place.
@see commit 735c1cd2da15167748e92ba6de48fdb5169db587
Signed-off-by: Lukas Slebodnik lsleb...@redhat.com
Reviewed-by: Andrew Bartlett abart...@samba.org
Reviewed-by: Stefan Metzmacher me...@samba.org
---
Summary of changes:
lib/talloc/pytalloc-util.pc.in |4 ++--
lib/tevent/tevent.pc.in|4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/talloc/pytalloc-util.pc.in b/lib/talloc/pytalloc-util.pc.in
index bc704b4..b7426bb 100644
--- a/lib/talloc/pytalloc-util.pc.in
+++ b/lib/talloc/pytalloc-util.pc.in
@@ -6,6 +6,6 @@ includedir=@includedir@
Name: pytalloc-util
Description: Utility functions for using talloc objects with Python
Version: @TALLOC_VERSION@
-Libs: -L${libdir} -lpytalloc-util
-Cflags: @LIB_RPATH@ -I${includedir}
+Libs: @LIB_RPATH@ -L${libdir} -lpytalloc-util
+Cflags: -I${includedir}
URL: http://talloc.samba.org/
diff --git a/lib/tevent/tevent.pc.in b/lib/tevent/tevent.pc.in
index 1091ff0..eb0e564 100644
--- a/lib/tevent/tevent.pc.in
+++ b/lib/tevent/tevent.pc.in
@@ -7,6 +7,6 @@ Name: tevent
Description: An event system library
Version: @PACKAGE_VERSION@
Requires: talloc
-Libs: -L${libdir} -ltevent
-Cflags: @LIB_RPATH@ -I${includedir}
+Libs: @LIB_RPATH@ -L${libdir} -ltevent
+Cflags: -I${includedir}
URL: http://samba.org/
--
Samba Shared Repository
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-04-05-0131/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-04-05-0131/samba.stderr http://git.samba.org/autobuild.flakey/2014-04-05-0131/samba.stdout The top commit at the time of the failure was: commit e1df75b5a965829db0c1f76673dcc824447b3ae7 Author: Lukas Slebodnik lsleb...@redhat.com Date: Fri Apr 4 13:29:39 2014 +0200 talloc: Update flags in pytalloc-util pkgconfig file After exapnding, @LIB_RPATH@ will be -Wl,-rpatch,/usr/local/lib if rpath is used on install. But -Wl, will be passed to linker and should not be among CFLAGS. Other pkgconfig files have @LIB_RPATH@ in the right place. @see commit 735c1cd2da15167748e92ba6de48fdb5169db587 Signed-off-by: Lukas Slebodnik lsleb...@redhat.com Reviewed-by: Andrew Bartlett abart...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org Autobuild-User(master): Andrew Bartlett abart...@samba.org Autobuild-Date(master): Fri Apr 4 23:50:25 CEST 2014 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via c35b31f s3: enforce a positive allocation_file_size for non-empty
files
via 69b7631 vfs: Store ACL control flags in gpfs vfs module.
via a5d5bdc vfs: Support NFS control flags in nfs4_acls.c.
from e1df75b5 talloc: Update flags in pytalloc-util pkgconfig file
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit c35b31f45244a8339684c3b83a7d86eefb80e0da
Author: Björn Baumbach b...@sernet.de
Date: Thu Mar 27 11:17:30 2014 +0100
s3: enforce a positive allocation_file_size for non-empty files
Some file systems do not allocate a block for very
small files. But for non-empty file should report a
positive size.
Pair-Programmed-With: Michael Adam ob...@samba.org
Signed-off-by: Björn Baumbach b...@sernet.de
Reviewed-by: Jeremy Allison j...@samba.org
Autobuild-User(master): Jeremy Allison j...@samba.org
Autobuild-Date(master): Sat Apr 5 03:09:00 CEST 2014 on sn-devel-104
commit 69b7631ca712046eab2bf4d8dae666718c46cb82
Author: Alexander Werth alexander.we...@de.ibm.com
Date: Tue Feb 4 17:50:54 2014 +0100
vfs: Store ACL control flags in gpfs vfs module.
Use literals to allow a compile and execution on gpfs 3.4.
Signed-off-by: Alexander Werth alexander.we...@de.ibm.com
Reviewed-by: Christof Schmitt c...@samba.org
Reviewed-by: Jeremy Allison j...@samba.org
commit a5d5bdc36b7e3c7a73984968013be50682c8eb77
Author: Alexander Werth alexander.we...@de.ibm.com
Date: Mon Jan 20 15:12:42 2014 +0100
vfs: Support NFS control flags in nfs4_acls.c.
The ACL control flags stores in particular the dacl protected bit
which is responsible for the Include inherited permissions from
this object's parent checkbox. This stores the information in the
ACL struct passed to and from file system specific vfs modules.
Signed-off-by: Alexander Werth alexander.we...@de.ibm.com
Reviewed-by: Christof Schmitt c...@samba.org
Reviewed-by: Jeremy Allison j...@samba.org
---
Summary of changes:
source3/modules/nfs4_acls.c | 24 +++-
source3/modules/nfs4_acls.h |4 +
source3/modules/vfs_default.c | 12
source3/modules/vfs_gpfs.c| 137 ++---
4 files changed, 153 insertions(+), 24 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/modules/nfs4_acls.c b/source3/modules/nfs4_acls.c
index 774c40e..cf61af9 100644
--- a/source3/modules/nfs4_acls.c
+++ b/source3/modules/nfs4_acls.c
@@ -49,6 +49,7 @@ typedef struct _SMB_ACE4_INT_T
typedef struct _SMB_ACL4_INT_T
{
uint32 magic;
+ uint16_t controlflags;
uint32 naces;
SMB_ACE4_INT_T *first;
SMB_ACE4_INT_T *last;
@@ -218,6 +219,7 @@ SMB4ACL_T *smb_create_smb4acl(TALLOC_CTX *mem_ctx)
return NULL;
}
theacl-magic = SMB_ACL4_INT_MAGIC;
+ theacl-controlflags = SEC_DESC_SELF_RELATIVE;
/* theacl-first, last = NULL not needed */
return (SMB4ACL_T *)theacl;
}
@@ -288,6 +290,25 @@ uint32 smb_get_naces(SMB4ACL_T *theacl)
return aclint-naces;
}
+uint16_t smbacl4_get_controlflags(SMB4ACL_T *theacl)
+{
+ SMB_ACL4_INT_T *aclint = get_validated_aclint(theacl);
+ if (aclint==NULL)
+ return 0;
+
+ return aclint-controlflags;
+}
+
+bool smbacl4_set_controlflags(SMB4ACL_T *theacl, uint16_t controlflags)
+{
+ SMB_ACL4_INT_T *aclint = get_validated_aclint(theacl);
+ if (aclint==NULL)
+ return false;
+
+ aclint-controlflags = controlflags;
+ return true;
+}
+
static int smbacl4_GetFileOwner(struct connection_struct *conn,
const char *filename,
SMB_STRUCT_STAT *psbuf)
@@ -543,7 +564,7 @@ static NTSTATUS smb_get_nt_acl_nfs4_common(const
SMB_STRUCT_STAT *sbuf,
DEBUG(10,(after make sec_acl\n));
*ppdesc = make_sec_desc(
- mem_ctx, SD_REVISION, SEC_DESC_SELF_RELATIVE,
+ mem_ctx, SD_REVISION, smbacl4_get_controlflags(theacl),
(security_info SECINFO_OWNER) ? sid_owner : NULL,
(security_info SECINFO_GROUP) ? sid_group : NULL,
NULL, psa, sd_size);
@@ -1028,6 +1049,7 @@ NTSTATUS smb_set_nt_acl_nfs4(vfs_handle_struct *handle,
files_struct *fsp,
return map_nt_error_from_unix(errno);
}
+ smbacl4_set_controlflags(theacl, psd-type);
smbacl4_dump_nfs4acl(10, theacl);
if (set_acl_as_root) {
diff --git a/source3/modules/nfs4_acls.h b/source3/modules/nfs4_acls.h
index 1bde81b..68abebf 100644
--- a/source3/modules/nfs4_acls.h
+++ b/source3/modules/nfs4_acls.h
@@ -130,6 +130,10 @@ SMB4ACE_T *smb_next_ace4(SMB4ACE_T *ace);
uint32
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-04-05-0426/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-04-05-0426/samba.stderr http://git.samba.org/autobuild.flakey/2014-04-05-0426/samba.stdout The top commit at the time of the failure was: commit e1df75b5a965829db0c1f76673dcc824447b3ae7 Author: Lukas Slebodnik lsleb...@redhat.com Date: Fri Apr 4 13:29:39 2014 +0200 talloc: Update flags in pytalloc-util pkgconfig file After exapnding, @LIB_RPATH@ will be -Wl,-rpatch,/usr/local/lib if rpath is used on install. But -Wl, will be passed to linker and should not be among CFLAGS. Other pkgconfig files have @LIB_RPATH@ in the right place. @see commit 735c1cd2da15167748e92ba6de48fdb5169db587 Signed-off-by: Lukas Slebodnik lsleb...@redhat.com Reviewed-by: Andrew Bartlett abart...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org Autobuild-User(master): Andrew Bartlett abart...@samba.org Autobuild-Date(master): Fri Apr 4 23:50:25 CEST 2014 on sn-devel-104
