autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-04-27-1220/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-04-27-1220/samba.stderr http://git.samba.org/autobuild.flakey/2014-04-27-1220/samba.stdout The top commit at the time of the failure was: commit 2372bd7d0ce6bfe2ce2cc64c1b368b6cc876c70d Author: Michael Adam ob...@samba.org Date: Fri Apr 11 19:14:41 2014 +0200 autorid: Add allocation from above in alloc range for well known sids This way, we achieve a better determinism for the id mappings of the well knowns without wasting a separate range. Signed-off-by: Michael Adam ob...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org Autobuild-User(master): Michael Adam ob...@samba.org Autobuild-Date(master): Fri Apr 25 17:52:10 CEST 2014 on sn-devel-104
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-04-27-1519/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-04-27-1519/samba.stderr http://git.samba.org/autobuild.flakey/2014-04-27-1519/samba.stdout The top commit at the time of the failure was: commit 2372bd7d0ce6bfe2ce2cc64c1b368b6cc876c70d Author: Michael Adam ob...@samba.org Date: Fri Apr 11 19:14:41 2014 +0200 autorid: Add allocation from above in alloc range for well known sids This way, we achieve a better determinism for the id mappings of the well knowns without wasting a separate range. Signed-off-by: Michael Adam ob...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org Autobuild-User(master): Michael Adam ob...@samba.org Autobuild-Date(master): Fri Apr 25 17:52:10 CEST 2014 on sn-devel-104
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-04-27-1819/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-04-27-1819/samba.stderr http://git.samba.org/autobuild.flakey/2014-04-27-1819/samba.stdout The top commit at the time of the failure was: commit 2372bd7d0ce6bfe2ce2cc64c1b368b6cc876c70d Author: Michael Adam ob...@samba.org Date: Fri Apr 11 19:14:41 2014 +0200 autorid: Add allocation from above in alloc range for well known sids This way, we achieve a better determinism for the id mappings of the well knowns without wasting a separate range. Signed-off-by: Michael Adam ob...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org Autobuild-User(master): Michael Adam ob...@samba.org Autobuild-Date(master): Fri Apr 25 17:52:10 CEST 2014 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 086c06e kerberos: Remove un-used event context argument from
smb_krb5_init_context()
via 7a26989 dsdb: Specify no event context to smb_krb5_init_context()
in dsdb
from 2372bd7 autorid: Add allocation from above in alloc range for well
known sids
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 086c06e361962e1c118d8eed2316e9df7834ae8b
Author: Andrew Bartlett abart...@samba.org
Date: Thu Apr 17 22:35:33 2014 +1200
kerberos: Remove un-used event context argument from smb_krb5_init_context()
The event context here was only specified in the server or admin-tool
context, which does not do network communication, so this only caused
a talloc_reference() and never any useful result.
The actual network communication code sets an event context directly
before making the network call.
Andrew Bartlett
Signed-off-by: Andrew Bartlett abart...@samba.org
Reviewed-by: Jeremy Allison j...@samba.org
Autobuild-User(master): Andrew Bartlett abart...@samba.org
Autobuild-Date(master): Mon Apr 28 02:24:57 CEST 2014 on sn-devel-104
commit 7a26989d4c62f38dcafc2a688b8cbaccc6499480
Author: Andrew Bartlett abart...@samba.org
Date: Thu Apr 17 21:48:30 2014 +1200
dsdb: Specify no event context to smb_krb5_init_context() in dsdb
These routines parse principals and generate keys only, no network
communication is done.
Andrew Bartlett
Signed-off-by: Andrew Bartlett abart...@samba.org
Reviewed-by: Jeremy Allison j...@samba.org
---
Summary of changes:
auth/credentials/credentials_krb5.c|2 +-
source4/auth/gensec/gensec_gssapi.c|1 -
source4/auth/kerberos/krb5_init_context.c | 12
source4/auth/kerberos/krb5_init_context.h |2 +-
source4/dns_server/dlz_bind9.c |2 +-
source4/dsdb/samdb/cracknames.c|2 --
source4/dsdb/samdb/ldb_modules/password_hash.c |1 -
source4/dsdb/samdb/ldb_modules/update_keytab.c |3 ++-
source4/kdc/kdc.c |2 +-
source4/libnet/libnet_export_keytab.c |2 +-
source4/rpc_server/lsa/dcesrv_lsa.c|1 -
source4/torture/auth/pac.c |3 +--
12 files changed, 8 insertions(+), 25 deletions(-)
Changeset truncated at 500 lines:
diff --git a/auth/credentials/credentials_krb5.c
b/auth/credentials/credentials_krb5.c
index 31fc9d2..489a959 100644
--- a/auth/credentials/credentials_krb5.c
+++ b/auth/credentials/credentials_krb5.c
@@ -49,7 +49,7 @@ _PUBLIC_ int cli_credentials_get_krb5_context(struct
cli_credentials *cred,
return 0;
}
- ret = smb_krb5_init_context(cred, NULL, lp_ctx,
+ ret = smb_krb5_init_context(cred, lp_ctx,
cred-smb_krb5_context);
if (ret) {
cred-smb_krb5_context = NULL;
diff --git a/source4/auth/gensec/gensec_gssapi.c
b/source4/auth/gensec/gensec_gssapi.c
index 63fda1f..fdae2a8 100644
--- a/source4/auth/gensec/gensec_gssapi.c
+++ b/source4/auth/gensec/gensec_gssapi.c
@@ -179,7 +179,6 @@ static NTSTATUS gensec_gssapi_start(struct gensec_security
*gensec_security)
}
ret = smb_krb5_init_context(gensec_gssapi_state,
- NULL,
gensec_security-settings-lp_ctx,
gensec_gssapi_state-smb_krb5_context);
if (ret) {
diff --git a/source4/auth/kerberos/krb5_init_context.c
b/source4/auth/kerberos/krb5_init_context.c
index 12aab34..4404b67 100644
--- a/source4/auth/kerberos/krb5_init_context.c
+++ b/source4/auth/kerberos/krb5_init_context.c
@@ -474,7 +474,6 @@ smb_krb5_init_context_basic(TALLOC_CTX *tmp_ctx,
}
krb5_error_code smb_krb5_init_context(void *parent_ctx,
- struct tevent_context *ev,
struct loadparm_context *lp_ctx,
struct smb_krb5_context
**smb_krb5_context)
{
@@ -529,17 +528,6 @@ krb5_error_code smb_krb5_init_context(void *parent_ctx,
}
krb5_set_warn_dest(kctx, logf);
- /* Set use of our socket lib */
- if (ev) {
- struct tevent_context *previous_ev;
- ret = smb_krb5_context_set_event_ctx(*smb_krb5_context,
-ev, previous_ev);
- if (ret) {
- talloc_free(tmp_ctx);
- return ret;
- }
- }
-
/* Set options in kerberos */
krb5_set_dns_canonicalize_hostname(kctx,
diff --git a/source4/auth/kerberos/krb5_init_context.h
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-04-28-0636/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-04-28-0636/samba.stderr http://git.samba.org/autobuild.flakey/2014-04-28-0636/samba.stdout The top commit at the time of the failure was: commit 086c06e361962e1c118d8eed2316e9df7834ae8b Author: Andrew Bartlett abart...@samba.org Date: Thu Apr 17 22:35:33 2014 +1200 kerberos: Remove un-used event context argument from smb_krb5_init_context() The event context here was only specified in the server or admin-tool context, which does not do network communication, so this only caused a talloc_reference() and never any useful result. The actual network communication code sets an event context directly before making the network call. Andrew Bartlett Signed-off-by: Andrew Bartlett abart...@samba.org Reviewed-by: Jeremy Allison j...@samba.org Autobuild-User(master): Andrew Bartlett abart...@samba.org Autobuild-Date(master): Mon Apr 28 02:24:57 CEST 2014 on sn-devel-104
