autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-10-24-0753/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-10-24-0753/samba.stderr http://git.samba.org/autobuild.flakey/2014-10-24-0753/samba.stdout The top commit at the time of the failure was: commit 6be7da3ee6c3d833fbf5d075bfabd04bda7e5097 Author: Volker Lendecke Date: Wed Oct 22 15:11:43 2014 + messaging3: Fix running down a messaging_context When you do a talloc_free(msg_ctx), existing waiters can't and don't have to clean up behind themselves properly anymore. The msg_ctx the cleanup function refers to is just gone. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Fri Oct 24 04:01:32 CEST 2014 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 6be7da3 messaging3: Fix running down a messaging_context
via c9cced0 poll_funcs_tevent: Fix a valgrind error
from 4b09df8 pidl-wireshark: SWITCH_TYPE is not always defined,
SwitchType() will try to find a fallback
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 6be7da3ee6c3d833fbf5d075bfabd04bda7e5097
Author: Volker Lendecke
Date: Wed Oct 22 15:11:43 2014 +
messaging3: Fix running down a messaging_context
When you do a talloc_free(msg_ctx), existing waiters can't and don't have to
clean up behind themselves properly anymore. The msg_ctx the cleanup
function
refers to is just gone.
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Fri Oct 24 04:01:32 CEST 2014 on sn-devel-104
commit c9cced03224011ad25f5fc6b7d737fb2cabd3153
Author: Volker Lendecke
Date: Wed Oct 22 15:02:49 2014 +
poll_funcs_tevent: Fix a valgrind error
The valgrind error happened in poll_funcs_tevent_handle_destructor in
if (handle->ctx->refcount == 0)
handle->ctx was already gone at the time this destructor
was called. It happened because during messaging_init the
messaging_dgm subsystem was free'ed. The unix_msg context and the
poll_funcs_tevent_context are children of messaging_dgm_context. How
was poll_funcs_tevent_handle_destructor still called? While working
on the new notify subsystem I've added some messaging_read_send
tevent_reqs, which register themselves with the dgm_context via
messaging_dgm_register_tevent_context. They were not gone yet. When
later these were also run down due to another talloc_free somewhere else,
this destructor referenced dead memory.
This code now protects the poll_funcs_tevent_handle against the
poll_funcs_tevent_context going away first with the loop
for (h = ctx->handles; h != NULL; h = h->next) {
h->ctx = NULL;
}
in poll_funcs_tevent_context_destructor together with
if (handle->ctx == NULL) {
return 0;
}
in poll_funcs_tevent_handle_destructor.
A side-effect of this code is that messaging_read_send request won't be
satisfied anymore after a reinit_after_fork kicked in. But I think this is
the
right thing anyway: Every process should register its own message handlers
explicitly.
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
---
Summary of changes:
source3/lib/messages.c | 16
source3/lib/poll_funcs/poll_funcs_tevent.c | 28
2 files changed, 36 insertions(+), 8 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/lib/messages.c b/source3/lib/messages.c
index aaaee52..d4c580f 100644
--- a/source3/lib/messages.c
+++ b/source3/lib/messages.c
@@ -267,7 +267,23 @@ static void messaging_recv_cb(const uint8_t *msg, size_t
msg_len,
static int messaging_context_destructor(struct messaging_context *ctx)
{
+ unsigned i;
+
messaging_dgm_destroy();
+
+ for (i=0; inum_new_waiters; i++) {
+ if (ctx->new_waiters[i] != NULL) {
+ tevent_req_set_cleanup_fn(ctx->new_waiters[i], NULL);
+ ctx->new_waiters[i] = NULL;
+ }
+ }
+ for (i=0; inum_waiters; i++) {
+ if (ctx->waiters[i] != NULL) {
+ tevent_req_set_cleanup_fn(ctx->waiters[i], NULL);
+ ctx->waiters[i] = NULL;
+ }
+ }
+
return 0;
}
diff --git a/source3/lib/poll_funcs/poll_funcs_tevent.c
b/source3/lib/poll_funcs/poll_funcs_tevent.c
index ee800ba..565cdaf 100644
--- a/source3/lib/poll_funcs/poll_funcs_tevent.c
+++ b/source3/lib/poll_funcs/poll_funcs_tevent.c
@@ -19,6 +19,7 @@
#include "poll_funcs_tevent.h"
#include "tevent.h"
#include "system/select.h"
+#include "dlinklist.h"
/*
* A poll_watch is asked for by the engine using this library via
@@ -53,7 +54,7 @@ struct poll_funcs_state {
};
struct poll_funcs_tevent_context {
- unsigned refcount;
+ struct poll_funcs_tevent_handle *handles;
struct poll_funcs_state *state;
unsigned slot; /* index into state->contexts[] */
struct tevent_context *ev;
@@ -67,6 +68,7 @@ struct poll_funcs_tevent_context {
* multiple times. So we have to share one poll_funcs_tevent_context.
*/
struct poll_funcs_tevent_handle {
+ struct poll_funcs_tevent_handle *prev, *next;
struct poll_funcs_tevent_context *ctx;
};
@@ -352,7 +354,7 @@ static struct poll_funcs_tevent_context
*poll_funcs_tevent_co
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 4b09df8 pidl-wireshark: SWITCH_TYPE is not always defined,
SwitchType() will try to find a fallback
via 93f262e pidl-wireshark: generate ALIGN_TO_x_BYTES instructions if
the element has the align_x flag
via 3f6ca43 pidl-wireshark: if the structure has the flag no_align then
set also no_align in the dceprc_info structure
via f0a6043 pidl-wireshark: handle 8 bits enum and change the signature
of enum function to pass the exact type
via 49e0dc7 pidl-wireshark: add definition for IPV4/IPV6 types
via 725500f pidl-wireshark: adapt to the new comments in the headers of
wireshark dissectors
from 0fbd854 s3:vfs:aio_pthread: use smbXsrv_connection for
schedule_deferred_open_message_smb
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 4b09df897803e78265fd19f6ff19be6e3d8a3944
Author: Matthieu Patou
Date: Tue Oct 1 12:10:18 2013 -0700
pidl-wireshark: SWITCH_TYPE is not always defined, SwitchType() will try to
find a fallback
Pair-Programmed-With: Stefan Metzmacher
Signed-off-by: Matthieu Patou
Signed-off-by: Stefan Metzmacher
Autobuild-User(master): Stefan Metzmacher
Autobuild-Date(master): Fri Oct 24 01:39:16 CEST 2014 on sn-devel-104
commit 93f262ee6d162bf007b79d2daf9de6c49c6163d1
Author: Matthieu Patou
Date: Fri Oct 18 00:04:28 2013 -0700
pidl-wireshark: generate ALIGN_TO_x_BYTES instructions if the element has
the align_x flag
Signed-off-by: Matthieu Patou
Reviewed-by: Stefan Metzmacher
commit 3f6ca430b067705d556031d52736d5a5d5ae8f55
Author: Matthieu Patou
Date: Fri Oct 11 13:18:37 2013 -0700
pidl-wireshark: if the structure has the flag no_align then set also
no_align in the dceprc_info structure
Some dissection function will try to do alignment if the no_align flag
is not set.
Pair-Programmed-With: Stefan Metzmacher
Signed-off-by: Matthieu Patou
Signed-off-by: Stefan Metzmacher
commit f0a6043fb201940f438f63c809df7186aa307f01
Author: Matthieu Patou
Date: Sun Oct 5 18:25:27 2014 -0700
pidl-wireshark: handle 8 bits enum and change the signature of enum
function to pass the exact type
Instead of passing a uint32 in all cases we pass the exact type
Pair-Programmed-With: Stefan Metzmacher
Change-Id: Ib79f1fa56d5aeb30c6e57eea8f0a48db60f6484d
Signed-off-by: Matthieu Patou
Signed-off-by: Stefan Metzmacher
commit 49e0dc7ad0f3c29df20badacc4294f1adc375aaf
Author: Matthieu Patou
Date: Fri Oct 25 23:11:37 2013 -0700
pidl-wireshark: add definition for IPV4/IPV6 types
Signed-off-by: Matthieu Patou
Reviewed-by: Stefan Metzmacher
commit 725500fc2815a1b00b08c5dd025055266ac97b5a
Author: Matthieu Patou
Date: Sun Oct 5 00:06:49 2014 -0700
pidl-wireshark: adapt to the new comments in the headers of wireshark
dissectors
Change-Id: I4fc398c4d50230d1f0a083827493c1b193c045b9
Signed-off-by: Matthieu Patou
Reviewed-by: Stefan Metzmacher
---
Summary of changes:
pidl/lib/Parse/Pidl/Wireshark/NDR.pm | 112 +++---
1 files changed, 77 insertions(+), 35 deletions(-)
Changeset truncated at 500 lines:
diff --git a/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
b/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
index 10eaa6c..89cbf84 100644
--- a/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
+++ b/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
@@ -150,7 +150,7 @@ sub Enum()
}
$self->pidl_hdr("extern const value_string $valsstring\[];");
- $self->pidl_hdr("int $dissectorname(tvbuff_t *tvb _U_, int offset _U_,
packet_info *pinfo _U_, proto_tree *tree _U_, guint8 *drep _U_, int hf_index
_U_, guint32 *param _U_);");
+ $self->pidl_hdr("int $dissectorname(tvbuff_t *tvb _U_, int offset _U_,
packet_info *pinfo _U_, proto_tree *tree _U_, guint8 *drep _U_, int hf_index
_U_, g$e->{BASE_TYPE} *param _U_);");
$self->pidl_def("const value_string ".$valsstring."[] = {");
foreach (@{$e->{ELEMENTS}}) {
@@ -163,19 +163,19 @@ sub Enum()
$self->pidl_fn_start($dissectorname);
$self->pidl_code("int");
- $self->pidl_code("$dissectorname(tvbuff_t *tvb _U_, int offset _U_,
packet_info *pinfo _U_, proto_tree *tree _U_, guint8 *drep _U_, int hf_index
_U_, guint32 *param _U_)");
+ $self->pidl_code("$dissectorname(tvbuff_t *tvb _U_, int offset _U_,
packet_info *pinfo _U_, proto_tree *tree _U_, guint8 *drep _U_, int hf_index
_U_, g$e->{BASE_TYPE} *param _U_)");
$self->pidl_code("{");
$self->indent;
$self->pidl_code("g$e->{BASE_TYPE} parameter=0;");
- $self->pidl_code("if(param){");
+ $self->pidl_code("if (param) {");
$self->indent;
- $self->pidl_code("paramete
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-10-23-2313/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-10-23-2313/samba.stderr http://git.samba.org/autobuild.flakey/2014-10-23-2313/samba.stdout The top commit at the time of the failure was: commit 95bf43bc6a0b6a4a47b8a556eee3b78446ea4123 Author: Jeremy Allison Date: Tue Oct 21 14:41:32 2014 -0700 s3: libsmbclient - smb2. MacOSX 10 SMB2 server doesn't set STATUS_NO_MORE_FILES when handed a non-wildcard path. Signed-off-by: Jeremy Allison Reviewed-by: Steve French Tested-by: Ralph Boehme Autobuild-User(master): Steve French Autobuild-Date(master): Thu Oct 23 20:44:31 CEST 2014 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 0fbd854 s3:vfs:aio_pthread: use smbXsrv_connection for
schedule_deferred_open_message_smb
from 95bf43b s3: libsmbclient - smb2. MacOSX 10 SMB2 server doesn't set
STATUS_NO_MORE_FILES when handed a non-wildcard path.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 0fbd854204b29ee4315519f64311e0923b88876a
Author: Michael Adam
Date: Tue Oct 21 10:46:56 2014 +0200
s3:vfs:aio_pthread: use smbXsrv_connection for
schedule_deferred_open_message_smb
This fixes an incompatible pointer warning which uncovered
a real bug. This caller was missed when converting the function.
This fix is only temporary, since we use fsp->sconn->client->connections
which is supposed to be the start of the list of transport connections
by a given client treated by this smbd process. Currently there is only
one such connection, but with multi-channel there might be more. So
we will need to improve this in the future.
Signed-off-by: Michael Adam
Reviewed-by: Volker Lendecke
Autobuild-User(master): Volker Lendecke
Autobuild-Date(master): Thu Oct 23 23:10:35 CEST 2014 on sn-devel-104
---
Summary of changes:
source3/modules/vfs_aio_pthread.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/modules/vfs_aio_pthread.c
b/source3/modules/vfs_aio_pthread.c
index d1922b5..7e77297 100644
--- a/source3/modules/vfs_aio_pthread.c
+++ b/source3/modules/vfs_aio_pthread.c
@@ -158,6 +158,7 @@ static void aio_open_handle_completion(struct
tevent_context *event_ctx,
struct aio_open_private_data *opd = NULL;
int jobid = 0;
int ret;
+ struct smbXsrv_connection *xconn;
DEBUG(10, ("aio_open_handle_completion called with flags=%d\n",
(int)flags));
@@ -191,8 +192,15 @@ static void aio_open_handle_completion(struct
tevent_context *event_ctx,
opd->in_progress = false;
+ /*
+* TODO: In future we need a proper algorithm
+* to find the correct connection for a fsp.
+* For now we only have one connection, so this is correct...
+*/
+ xconn = opd->sconn->client->connections;
+
/* Find outstanding event and reschedule. */
- if (!schedule_deferred_open_message_smb(opd->sconn, opd->mid)) {
+ if (!schedule_deferred_open_message_smb(xconn, opd->mid)) {
/*
* Outstanding event didn't exist or was
* cancelled. Free up the fd and throw
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 95bf43b s3: libsmbclient - smb2. MacOSX 10 SMB2 server doesn't set
STATUS_NO_MORE_FILES when handed a non-wildcard path.
from 4bec186 samba-tool group add: Add option --nis-domain and --gid
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 95bf43bc6a0b6a4a47b8a556eee3b78446ea4123
Author: Jeremy Allison
Date: Tue Oct 21 14:41:32 2014 -0700
s3: libsmbclient - smb2. MacOSX 10 SMB2 server doesn't set
STATUS_NO_MORE_FILES when handed a non-wildcard path.
Signed-off-by: Jeremy Allison
Reviewed-by: Steve French
Tested-by: Ralph Boehme
Autobuild-User(master): Steve French
Autobuild-Date(master): Thu Oct 23 20:44:31 CEST 2014 on sn-devel-104
---
Summary of changes:
source3/libsmb/cli_smb2_fnum.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/libsmb/cli_smb2_fnum.c b/source3/libsmb/cli_smb2_fnum.c
index a099e03..de4bd6f 100644
--- a/source3/libsmb/cli_smb2_fnum.c
+++ b/source3/libsmb/cli_smb2_fnum.c
@@ -667,6 +667,7 @@ NTSTATUS cli_smb2_list(struct cli_state *cli,
bool processed_file = false;
TALLOC_CTX *frame = talloc_stackframe();
TALLOC_CTX *subframe = NULL;
+ bool mask_has_wild;
if (smbXcli_conn_has_async_calls(cli->conn)) {
/*
@@ -690,6 +691,8 @@ NTSTATUS cli_smb2_list(struct cli_state *cli,
goto fail;
}
+ mask_has_wild = ms_has_wild(mask);
+
status = cli_smb2_create_fnum(cli,
parent_dir,
0, /* create_flags */
@@ -791,6 +794,17 @@ NTSTATUS cli_smb2_list(struct cli_state *cli,
TALLOC_FREE(subframe);
+ if (!mask_has_wild) {
+ /*
+* MacOSX 10 doesn't set STATUS_NO_MORE_FILES
+* when handed a non-wildcard path. Do it
+* for the server (with a non-wildcard path
+* there should only ever be one file returned.
+*/
+ status = STATUS_NO_MORE_FILES;
+ break;
+ }
+
} while (NT_STATUS_IS_OK(status));
if (NT_STATUS_EQUAL(status, STATUS_NO_MORE_FILES)) {
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 4bec186 samba-tool group add: Add option --nis-domain and --gid
via 4ab6df6 samba-tool: Add exception when trying to add/remove none
existent users from a group.
via 1c7b81e selftest: Fix test samba4.blackbox.group.py
via 5340be1 subunit: report [X/Y at Zs] instead of [X/Y in Zs]
from 88f9f50 Add missing parameters to drs_Replicate in rodc.py
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 4bec1867987845fc40e9a17a283d2affc36e0dc5
Author: Marc Muehlfeld
Date: Sat Oct 18 00:34:35 2014 +0200
samba-tool group add: Add option --nis-domain and --gid
This allows creating RFC2307 enabled groups via samba-tool
Signed-off-by: Marc Muehlfeld
Reviewed-by: Michael Adam
Autobuild-User(master): Michael Adam
Autobuild-Date(master): Thu Oct 23 18:19:35 CEST 2014 on sn-devel-104
commit 4ab6df622c81363b8acb31113016ecfbbe1ec5c4
Author: Marc Muehlfeld
Date: Sun Oct 12 16:32:08 2014 +0200
samba-tool: Add exception when trying to add/remove none existent users
from a group.
This allows a better scripting around samba-tool for adding/removing users
to/from groups. Before the output and the return code had indicated that
everything was successul.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10871
Signed-off-by: Marc Muehlfeld
Reviewed-by: Michael Adam
commit 1c7b81e76824ce78ecc5d700b76b8a68b1beb1bd
Author: Marc Muehlfeld
Date: Sat Oct 18 02:17:22 2014 +0200
selftest: Fix test samba4.blackbox.group.py
The test created two users and in later steps it tried adding two
non-existend users to groups. This fix adds now the two created
accounts to the groups instead.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10871
Signed-off-by: Marc Muehlfeld
Reviewed-by: Michael Adam
commit 5340be1740fa753f9e1471b025c9f29ed2ba2234
Author: Michael Adam
Date: Fri Oct 17 11:17:53 2014 +0200
subunit: report [X/Y at Zs] instead of [X/Y in Zs]
when running test X out of Y after Z secons have passed
Signed-off-by: Michael Adam
Reviewed-by: Matthieu Patou
---
Summary of changes:
python/samba/netcmd/group.py | 15 +--
python/samba/samdb.py | 15 +--
selftest/subunithelper.py |2 +-
source4/setup/tests/blackbox_group.sh | 24
4 files changed, 39 insertions(+), 17 deletions(-)
Changeset truncated at 500 lines:
diff --git a/python/samba/netcmd/group.py b/python/samba/netcmd/group.py
index 1a24e5f..4b5fd27 100644
--- a/python/samba/netcmd/group.py
+++ b/python/samba/netcmd/group.py
@@ -70,6 +70,11 @@ Example2:
sudo samba-tool group add Group2 --group-type=Distribution
Example2 adds a new distribution group to the local server. The command is
run under root using the sudo command.
+
+Example3:
+samba-tool group add Group3 --nis-domain=samdom --gid=12345
+
+Example3 adds a new RFC2307 enabled group for NIS domain samdom and GID 12345
(both options are required to enable this feature).
"""
synopsis = "%prog [options]"
@@ -93,19 +98,24 @@ Example2 adds a new distribution group to the local server.
The command is run
Option("--description", help="Group's description", type=str),
Option("--mail-address", help="Group's email address", type=str),
Option("--notes", help="Groups's notes", type=str),
+Option("--gid-number", help="Group's Unix/RFC2307 GID number",
type=int),
+Option("--nis-domain", help="SFU30 NIS Domain", type=str),
]
takes_args = ["groupname"]
def run(self, groupname, credopts=None, sambaopts=None,
versionopts=None, H=None, groupou=None, group_scope=None,
-group_type=None, description=None, mail_address=None, notes=None):
+group_type=None, description=None, mail_address=None, notes=None,
gid_number=None, nis_domain=None):
if (group_type or "Security") == "Security":
gtype = security_group.get(group_scope,
GTYPE_SECURITY_GLOBAL_GROUP)
else:
gtype = distribution_group.get(group_scope,
GTYPE_DISTRIBUTION_GLOBAL_GROUP)
+if (gid_number is None and nis_domain is not None) or (gid_number is
not None and nis_domain is None):
+raise CommandError('Both --gid-number and --nis-domain have to be
set for a RFC2307-enabled group. Operation cancelled.')
+
lp = sambaopts.get_loadparm()
creds = credopts.get_credentials(lp, fallback_machine=True)
@@ -113,7 +123,8 @@ Example2 adds a new distribution group to the local server.
The command is run
samdb = SamDB(url=H, session_info=system_session(),
credentials=cre
[SCM] Resolv Wrapper Repository - branch master updated
The branch, master has been updated via e124906 cmake: Fix tests on Solaris. via 4af3e98 torture: Fix socket directory name. via 3703225 tests: Fix test_res_ninit() with IPv4 only support. via 1e5333c rwrap: Fix symbol binding on Solaris. via e148623 tests: Use the right array size in tests. via de4d1f4 rwrap: Don't use htons for bitfields. via 2f67bf0 rwrap: Explicitly zero out sin_zero to silence gcc warnings. via b813639 tests: Call res_nclose() in test_res_query_search.c. via a5ddc99 rwrap: Close the resolv.conf file handle. via 0bfdc27 rwrap: Free IPv6 name servers on close. from f9abdf9 rwrap: Move NEXT_KEY out of the NDEBUG ifdef. http://gitweb.samba.org/?p=resolv_wrapper.git;a=shortlog;h=master - Log - commit e12490601efef47cae766fb437c8f070a5acc19f Author: Andreas Schneider Date: Thu Oct 23 12:41:52 2014 +0200 cmake: Fix tests on Solaris. Signed-off-by: Andreas Schneider Reviewed-by: Michael Adam commit 4af3e98588580c1c460e40e2e4b77f8502be65c4 Author: Andreas Schneider Date: Thu Oct 23 12:30:50 2014 +0200 torture: Fix socket directory name. Signed-off-by: Andreas Schneider Reviewed-by: Michael Adam commit 3703225a10919cae84806b86915cd4ba832488dc Author: Andreas Schneider Date: Thu Oct 23 07:51:04 2014 +0200 tests: Fix test_res_ninit() with IPv4 only support. Signed-off-by: Andreas Schneider Reviewed-by: Michael Adam commit 1e5333cb1ea789f1e5cc01433ec7cf01e4ec530f Author: Andreas Schneider Date: Thu Oct 23 07:46:53 2014 +0200 rwrap: Fix symbol binding on Solaris. Signed-off-by: Andreas Schneider Reviewed-by: Michael Adam commit e1486231cd4584c1c3b797457d3e0b9a5e0e1430 Author: Jakub Hrozek Date: Tue Oct 21 18:42:44 2014 +0200 tests: Use the right array size in tests. Several unit tests used the wrong array size, which might cause buffer overflows. This patch unifies on using sizeof(array) since all the arrays are allocated on stack. CID #68270 CID #68269 CID #68267 CID #68265 Signed-off-by: Jakub Hrozek Reviewed-by: Andreas Schneider Reviewed-by: Michael Adam commit de4d1f40645d383fccce4693a1323744636b769a Author: Jakub Hrozek Date: Tue Oct 21 17:23:30 2014 +0200 rwrap: Don't use htons for bitfields. On FreeBSD, using htons to set the bitfield led to warnings such as: resolv_wrapper.c:162:8: warning: implicit truncation from '__uint16_t' (aka 'unsigned short') to bitfield changes value from 256 to 0 [-Wbitfield-constant-conversion] h->qr = htons(1); /* response flag */ ^ Signed-off-by: Jakub Hrozek Reviewed-by: Andreas Schneider Reviewed-by: Michael Adam commit 2f67bf076f7a9f2d85ec24c027fa9d24de5d1e64 Author: Jakub Hrozek Date: Tue Oct 21 15:34:28 2014 +0200 rwrap: Explicitly zero out sin_zero to silence gcc warnings. On some platforms, failure to set the sin_zero structure lead to warnings such as: resolv_wrapper.c:969:5: warning: missing initializer for field ‘sin_zero’ of ‘struct sockaddr_in’ [-Wmissing-field-initializers] }; ^ In file included from /usr/include/arpa/inet.h:22:0, from /.../source/src/resolv_wrapper.c:38: Signed-off-by: Jakub Hrozek Reviewed-by: Andreas Schneider Reviewed-by: Michael Adam commit b813639c1d87369d0de69b3d86ca3aabd8652eba Author: Jakub Hrozek Date: Tue Oct 21 15:27:54 2014 +0200 tests: Call res_nclose() in test_res_query_search.c. The res_query and res_nsearch unit tests didn't call res_nclose as appropriate, leading to a resource leak. Signed-off-by: Jakub Hrozek Reviewed-by: Andreas Schneider Reviewed-by: Michael Adam commit a5ddc993bb098390df324471fda5d70e9b42a361 Author: Jakub Hrozek Date: Tue Oct 21 15:11:16 2014 +0200 rwrap: Close the resolv.conf file handle. CID #68264 The file descriptor of resolv.conf wasn't closed properly. Signed-off-by: Jakub Hrozek Reviewed-by: Andreas Schneider Reviewed-by: Michael Adam commit 0bfdc27620b237f17a0a6c089c616df3e891cf9f Author: Jakub Hrozek Date: Tue Oct 21 15:00:36 2014 +0200 rwrap: Free IPv6 name servers on close. rwrap's res_ninit allocates IPv6 name servers, but res_nclose didn't free them, leading to a resource leak detectable with valgrind. Signed-off-by: Jakub Hrozek Reviewed-by: Andreas Schneider Reviewed-by: Michael Adam --- Summary of changes: ConfigureChecks.cmake | 19 ++- config.h.cmake|2 ++ src/resolv_wrapper.c | 34 ++
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-10-23-1351/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-10-23-1351/samba.stderr http://git.samba.org/autobuild.flakey/2014-10-23-1351/samba.stdout The top commit at the time of the failure was: commit 88f9f50024b624319267ffa3684044d4e20e85c7 Author: Michael Brown Date: Thu Nov 21 10:48:33 2013 -0500 Add missing parameters to drs_Replicate in rodc.py * rodc.py: destination_dsa_guid parameter was neglected in drs_Replicate call * rodc.py: cancel the local_samdb transaction on error Change-Id: I962315a26ec48dc8774bb41db760387a3469c919 Signed-off-by: Garming Sam Reviewed-by: Stefan Metzmacher Autobuild-User(master): Garming Sam Autobuild-Date(master): Thu Oct 23 03:05:00 CEST 2014 on sn-devel-104
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-10-23-1105/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-10-23-1105/samba.stderr http://git.samba.org/autobuild.flakey/2014-10-23-1105/samba.stdout The top commit at the time of the failure was: commit 88f9f50024b624319267ffa3684044d4e20e85c7 Author: Michael Brown Date: Thu Nov 21 10:48:33 2013 -0500 Add missing parameters to drs_Replicate in rodc.py * rodc.py: destination_dsa_guid parameter was neglected in drs_Replicate call * rodc.py: cancel the local_samdb transaction on error Change-Id: I962315a26ec48dc8774bb41db760387a3469c919 Signed-off-by: Garming Sam Reviewed-by: Stefan Metzmacher Autobuild-User(master): Garming Sam Autobuild-Date(master): Thu Oct 23 03:05:00 CEST 2014 on sn-devel-104
