[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 91ff65b vfs_fruit: Fix CID 1273290 Uninitialized scalar variable
from 5b3c71c provision: Give a more helpful message when
find_provision_key_parameters() fails
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 91ff65b2f63061fa66b6bcc3c142c17b03581759
Author: Volker Lendecke v...@samba.org
Date: Fri Mar 6 09:59:25 2015 +
vfs_fruit: Fix CID 1273290 Uninitialized scalar variable
Signed-off-by: Volker Lendecke v...@samba.org
Reviewed-by: Ralph Boehme s...@samba.org
Autobuild-User(master): Volker Lendecke v...@samba.org
Autobuild-Date(master): Fri Mar 6 23:56:36 CET 2015 on sn-devel-104
---
Summary of changes:
source3/modules/vfs_fruit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c
index 4eace1e..0445e04 100644
--- a/source3/modules/vfs_fruit.c
+++ b/source3/modules/vfs_fruit.c
@@ -835,7 +835,8 @@ static ssize_t ad_header_read_rsrc(struct adouble *ad,
const char *path)
if (rc != 0) {
goto exit;
}
- ad_setentrylen(ad, ADEID_RFORK, sbuf.st_ex_size);
+ len = sbuf.st_ex_size;
+ ad_setentrylen(ad, ADEID_RFORK, len);
} else {
/* FIXME: direct sys_pread(), don't have an fsp */
len = sys_pread(fd, ad-ad_data, AD_DATASZ_DOT_UND, 0);
--
Samba Shared Repository
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via c05e3aa Add missing samba/ in ULR from a95abd3 Add VMware lawsuit statement https://git.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit c05e3aac24698fa10cbce2760ebcb179023323c8 Author: Lars Müller l...@samba.org Date: Fri Mar 6 23:42:53 2015 +0100 Add missing samba/ in ULR --- Summary of changes: generated_news/latest_10_bodies.html | 2 +- generated_news/latest_2_bodies.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/generated_news/latest_10_bodies.html b/generated_news/latest_10_bodies.html index 7a916ac..4eefdca 100644 --- a/generated_news/latest_10_bodies.html +++ b/generated_news/latest_10_bodies.html @@ -3,7 +3,7 @@ pWe support the a href=https://sfconservancy.org/;Software Freedom Conservancy/a's legal actions in defense of the GPL. Read our full -a href=https://www.samba.org/news/announcements/2015-03-06_vmware_lawsuit.html;lawsuit statement/a./p +a href=https://www.samba.org/samba/news/announcements/2015-03-06_vmware_lawsuit.html;lawsuit statement/a./p h5a name=4.2.004 March 2015/a/h5 diff --git a/generated_news/latest_2_bodies.html b/generated_news/latest_2_bodies.html index 4812e26..4d6cf69 100644 --- a/generated_news/latest_2_bodies.html +++ b/generated_news/latest_2_bodies.html @@ -3,7 +3,7 @@ pWe support the a href=https://sfconservancy.org/;Software Freedom Conservancy/a's legal actions in defense of the GPL. Read our full -a href=https://www.samba.org/news/announcements/2015-03-06_vmware_lawsuit.html;lawsuit statement/a./p +a href=https://www.samba.org/samba/news/announcements/2015-03-06_vmware_lawsuit.html;lawsuit statement/a./p h5a name=4.2.004 March 2015/a/h5 -- Samba Website Repository
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via 55e2ca9 Add date into the text from c05e3aa Add missing samba/ in ULR https://git.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit 55e2ca93cec8097e04a86a3ca54b7c9fbf1087f2 Author: Lars Müller l...@samba.org Date: Sat Mar 7 00:06:42 2015 +0100 Add date into the text --- Summary of changes: news/announcements/2015-03-06_vmware_lawsuit.html | 2 ++ 1 file changed, 2 insertions(+) Changeset truncated at 500 lines: diff --git a/news/announcements/2015-03-06_vmware_lawsuit.html b/news/announcements/2015-03-06_vmware_lawsuit.html index 513c927..b6682f3 100644 --- a/news/announcements/2015-03-06_vmware_lawsuit.html +++ b/news/announcements/2015-03-06_vmware_lawsuit.html @@ -6,6 +6,8 @@ body +h606 March 2015/h6 + h2Samba supports Christoph Hellwig's lawsuit against VMware/h2 p -- Samba Website Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 87b7a7d script/autobuild.py: build the samba target with --with-profiling-data via b9f9869 s3:smbprofile: profile the system and user space cpu time via 74a16a1 s3:smbprofile: Replace sysv shmem with tdb via 5fa692b s3:smbprofile: specify SMBPROFILE_STATS_SECTION_START() with name vs. display[name] from 7004ccc Implement TestCase.assertIsNotNone for python 2.7. https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 87b7a7dbaa28b29dac316b8b6d953c231529e372 Author: Stefan Metzmacher me...@samba.org Date: Mon Dec 8 10:30:56 2014 +0100 script/autobuild.py: build the samba target with --with-profiling-data In future we may get also runtime tests for profiling... Signed-off-by: Stefan Metzmacher me...@samba.org Reviewed-by: Michael Adam ob...@samba.org Autobuild-User(master): Michael Adam ob...@samba.org Autobuild-Date(master): Mon Dec 15 16:20:14 CET 2014 on sn-devel-104 (cherry picked from commit 4958fcdfa30fd9d8dc51ceafaab35721e61e72c7) commit b9f9869d1bec7cff6682d3cda774dcbb2464223b Author: Stefan Metzmacher me...@samba.org Date: Fri Nov 14 12:52:33 2014 +0100 s3:smbprofile: profile the system and user space cpu time Signed-off-by: Stefan Metzmacher me...@samba.org Reviewed-by: Ralph Boehme s...@samba.org commit 74a16a1094278d2c5c8ac800a4f7ed4553d7ac85 Author: Volker Lendecke v...@samba.org Date: Mon Sep 29 16:08:17 2014 + s3:smbprofile: Replace sysv shmem with tdb What? This patch gets rid of the central shared memory segment referenced by profile_p. Instead, every smbd gets a static profile_area where it collects profiling data. Once a second, every smbd writes this profiling data into a record of its own in a smbprofile.tdb. smbstatus -P does a tdb_traverse on this database and sums up what it finds. Why? At least in my perception sysv IPC has not the best reputation on earth. The code before this patch uses shmat(). Samba ages ago has developed a good abstraction of shared memory: It's called tdb. The main reason why I started this is that I have a request to become more flexible with profiling data. Samba should be able to collect data per share or per user, something which is almost impossible to do with a fixed structure. My idea is to for example install a profile area per share and every second marshall this into one tdb record indexed by share name. smbstatus -P would then also collect the data and either aggregate them or put them into individual per-share statistics. This flexibility in the data model is not really possible with one fixed structure. But isn't it slow? Well, I don't think so. I can't really prove it, but I do believe that on large boxes atomically incrementing a shared memory value for every SMB does show up due to NUMA effects. With this patch the hot code path is completely process-local. Once a second every smbd writes into a central tdb, this of course does atomic operations. But it's once a second, not on every SMB2 read. There's two places where I would like to improve things: With the current code all smbds wake up once a second. With 10,000 potentially idle smbds this will become noticable. That's why the current only starts the timer when something has changed. The second place is the tdb traverse: Right now traverse is blocking in the sense that when it has to switch hash chains it will block. With mutexes, this means a syscall. I have a traverse light in mind that works as follows: It assumes a locked hash chain and then walks the complete chain in one run without unlocking in between. This way the caller can do nonblocking locks in the first round and only do blocking locks in a second round. Also, a lot of syscall overhead will vanish. This way smbstatus -P will have almost zero impact on normal operations. Pair-Programmed-With: Stefan Metzmacher me...@samba.org Signed-off-by: Volker Lendecke v...@samba.org Signed-off-by: Stefan Metzmacher me...@samba.org Reviewed-by: Ralph Boehme s...@samba.org commit 5fa692b4aa36f66a14ae9b1512f881ecef23dca3 Author: Stefan Metzmacher me...@samba.org Date: Fri Nov 28 09:33:13 2014 +0100 s3:smbprofile: specify SMBPROFILE_STATS_SECTION_START() with name vs. display[name] Signed-off-by: Stefan Metzmacher me...@samba.org Reviewed-by: Volker Lendecke v...@samba.org Reviewed-by: Ralph Boehme s...@samba.org --- Summary of changes: script/autobuild.py| 2 +- source3/include/smbprofile.h | 138 +++--- source3/profile/profile.c | 401
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 90d03a6 heimdal: Fix CID 1273430 Double free
from 87b7a7d script/autobuild.py: build the samba target with
--with-profiling-data
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 90d03a65bcb2aae262ad113da420ae63bdf5b4b1
Author: Volker Lendecke v...@samba.org
Date: Thu Mar 5 21:17:31 2015 +0100
heimdal: Fix CID 1273430 Double free
I think Coverity is right here: Before the preceding call to
krb5_make_principal we already krb5_free_principal(ctx, tmp_creds.server)
without wiping out tmp_creds.server. The call to krb5_make_principal only
stores something fresh when it also returns 0 a.k.a. success.
Signed-off-by: Volker Lendecke v...@samba.org
Reviewed-by: David Disseldorp dd...@samba.org
Autobuild-User(master): David Disseldorp dd...@samba.org
Autobuild-Date(master): Fri Mar 6 17:38:09 CET 2015 on sn-devel-104
---
Summary of changes:
source4/heimdal/lib/krb5/get_cred.c | 1 -
1 file changed, 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source4/heimdal/lib/krb5/get_cred.c
b/source4/heimdal/lib/krb5/get_cred.c
index 51550da..29ab6ea 100644
--- a/source4/heimdal/lib/krb5/get_cred.c
+++ b/source4/heimdal/lib/krb5/get_cred.c
@@ -839,7 +839,6 @@ get_cred_kdc_capath_worker(krb5_context context,
ret = krb5_make_principal(context, tmp_creds.server,
tgt_inst, KRB5_TGS_NAME, server_realm, NULL);
if(ret) {
- krb5_free_principal(context, tmp_creds.server);
krb5_free_principal(context, tmp_creds.client);
return ret;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 5b3c71c provision: Give a more helpful message when find_provision_key_parameters() fails via 6fe8cd2 selftest: Improve renamedcs test via 477fce1 s4-lib/cmdline: Fix help for -P / --machine-pass: this no longer implies -k via 63dbf43 samba-tool: Add -P to options.CredentialsOptions from 90d03a6 heimdal: Fix CID 1273430 Double free https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 5b3c71cd9c4d20a04f7505ad904f95d0ecf5ac2e Author: Andrew Bartlett abart...@samba.org Date: Mon Mar 2 13:22:37 2015 +1300 provision: Give a more helpful message when find_provision_key_parameters() fails Signed-off-by: Andrew Bartlett abart...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org Autobuild-User(master): Stefan Metzmacher me...@samba.org Autobuild-Date(master): Fri Mar 6 20:11:52 CET 2015 on sn-devel-104 commit 6fe8cd2fdfa770ceaa4ad87002db9cdc029dd532 Author: Andrew Bartlett abart...@samba.org Date: Fri Feb 27 15:56:22 2015 +1300 selftest: Improve renamedcs test Signed-off-by: Andrew Bartlett abart...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org commit 477fce1f395917616cd2eb144da8571e994382e7 Author: Andrew Bartlett abart...@samba.org Date: Thu Feb 26 12:24:21 2015 +1300 s4-lib/cmdline: Fix help for -P / --machine-pass: this no longer implies -k Signed-off-by: Andrew Bartlett abart...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org commit 63dbf4388a53016a110bd02a31c46e0210eda463 Author: Andrew Bartlett abart...@samba.org Date: Thu Feb 26 12:23:55 2015 +1300 samba-tool: Add -P to options.CredentialsOptions This matches our other binaries, and allows samba-tool commands to run with the machine account. Signed-off-by: Andrew Bartlett abart...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org --- Summary of changes: python/samba/getopt.py | 26 +- python/samba/provision/__init__.py | 7 +-- source4/lib/cmdline/popt_credentials.c | 2 +- testprogs/blackbox/renamedc.sh | 10 ++ 4 files changed, 37 insertions(+), 8 deletions(-) Changeset truncated at 500 lines: diff --git a/python/samba/getopt.py b/python/samba/getopt.py index c3c0800..0f97658 100644 --- a/python/samba/getopt.py +++ b/python/samba/getopt.py @@ -126,8 +126,9 @@ class CredentialsOptions(optparse.OptionGroup): Command line options for specifying credentials. def __init__(self, parser): -self.no_pass = True +self.ask_for_password = True self.ipaddress = None +self.machine_pass = False optparse.OptionGroup.__init__(self, parser, Credentials Options) self.add_option(--simple-bind-dn, metavar=DN, action=callback, callback=self._set_simple_bind_dn, type=str, @@ -140,8 +141,9 @@ class CredentialsOptions(optparse.OptionGroup): self.add_option(-W, --workgroup, metavar=WORKGROUP, action=callback, type=str, help=Workgroup, callback=self._parse_workgroup) -self.add_option(-N, --no-pass, action=store_true, -help=Don't ask for a password) +self.add_option(-N, --no-pass, action=callback, +help=Don't ask for a password, +callback=self._set_no_password) self.add_option(-k, --kerberos, metavar=KERBEROS, action=callback, type=str, help=Use Kerberos, callback=self._set_kerberos) @@ -149,17 +151,29 @@ class CredentialsOptions(optparse.OptionGroup): action=callback, type=str, help=IP address of server, callback=self._set_ipaddress) +self.add_option(-P, --machine-pass, +action=callback, +help=Use stored machine account password, +callback=self._set_machine_pass) self.creds = Credentials() def _parse_username(self, option, opt_str, arg, parser): self.creds.parse_string(arg) +self.machine_pass = False def _parse_workgroup(self, option, opt_str, arg, parser): self.creds.set_domain(arg) def _set_password(self, option, opt_str, arg, parser): self.creds.set_password(arg) -self.no_pass = False +self.ask_for_password = False +self.machine_pass = False + +def _set_no_password(self, option, opt_str, arg, parser): +self.ask_for_password = False + +def _set_machine_pass(self, option, opt_str, arg, parser): +self.machine_pass = True def _set_ipaddress(self, option, opt_str, arg, parser):
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2015-03-06-1943/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2015-03-06-1943/samba.stderr http://git.samba.org/autobuild.flakey/2015-03-06-1943/samba.stdout The top commit at the time of the failure was: commit 90d03a65bcb2aae262ad113da420ae63bdf5b4b1 Author: Volker Lendecke v...@samba.org Date: Thu Mar 5 21:17:31 2015 +0100 heimdal: Fix CID 1273430 Double free I think Coverity is right here: Before the preceding call to krb5_make_principal we already krb5_free_principal(ctx, tmp_creds.server) without wiping out tmp_creds.server. The call to krb5_make_principal only stores something fresh when it also returns 0 a.k.a. success. Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: David Disseldorp dd...@samba.org Autobuild-User(master): David Disseldorp dd...@samba.org Autobuild-Date(master): Fri Mar 6 17:38:09 CET 2015 on sn-devel-104
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via a95abd3 Add VMware lawsuit statement from 9978383 News: Fix link to release notes in 4.2.0 announcement https://git.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit a95abd3e8b6ae74915d9e7905b65d7b1717304d0 Author: Lars Müller l...@samba.org Date: Fri Mar 6 23:30:07 2015 +0100 Add VMware lawsuit statement --- Summary of changes: generated_news/latest_10_bodies.html | 21 +++--- generated_news/latest_10_headlines.html | 4 ++-- generated_news/latest_2_bodies.html | 17 +++ news/announcements/2015-03-06_vmware_lawsuit.html | 26 +++ 4 files changed, 44 insertions(+), 24 deletions(-) create mode 100644 news/announcements/2015-03-06_vmware_lawsuit.html Changeset truncated at 500 lines: diff --git a/generated_news/latest_10_bodies.html b/generated_news/latest_10_bodies.html index 779d7ea..7a916ac 100644 --- a/generated_news/latest_10_bodies.html +++ b/generated_news/latest_10_bodies.html @@ -1,3 +1,11 @@ + h5a name=2015-03-06_vmware_lawsuit06 March 2015/a/h5 + p class=headlineSamba supports Christoph Hellwig's lawsuit against VMware/p + +pWe support the a href=https://sfconservancy.org/;Software Freedom Conservancy/a's +legal actions in defense of the GPL. Read our full +a href=https://www.samba.org/news/announcements/2015-03-06_vmware_lawsuit.html;lawsuit statement/a./p + + h5a name=4.2.004 March 2015/a/h5 p class=headlineSamba 4.2.0 Available for Download/p pThis is the first stable release of the Samba 4.2 series./p @@ -114,16 +122,3 @@ using GnuPG (ID 6568B7EA). The source code can be a href=https://download.samba.org/pub/samba/rc/samba-4.2.0rc3.tar.gz;downloaded now/a. See a href=https://download.samba.org/pub/samba/rc/WHATSNEW-4.2.0rc3.txt; the release notes for more info/a./p - - - h5a name=4.0.2308 December 2014/a/h5 - p class=headlineSamba 4.0.23 Available for Download/p - pThis is the latest stable release of the Samba 4.0 series./p - -pThe uncompressed tarballs and patch files have been signed -using GnuPG (ID 6568B7EA). The source code can be -a href=http://samba.org/samba/ftp/stable/samba-4.0.23.tar.gz;downloaded -now/a. A a href=http://samba.org/samba/ftp/patches/patch-4.0.22-4.0.23.diffs.gz; -patch against Samba 4.0.22/a is also available. See -a href=http://samba.org/samba/history/samba-4.0.23.html; the release notes - for more info/a./p diff --git a/generated_news/latest_10_headlines.html b/generated_news/latest_10_headlines.html index e7ea696..39973b9 100644 --- a/generated_news/latest_10_headlines.html +++ b/generated_news/latest_10_headlines.html @@ -1,4 +1,6 @@ ul + li 06 March 2015 a href=#2015-03-06_vmware_lawsuitSamba - VMware lawsuit to defend the GPL/a/li + li 04 March 2015 a href=#4.2.0Samba 4.2.0 Available for Download/a/li li 02 March 2015 a href=#survey2015Calling all Samba Users: 2015 @@ -21,6 +23,4 @@ li 12 January 2015 a href=#4.1.15Samba 4.1.15 Available for Download/a/li li 20 December 2014 a href=#4.2.0rc3Samba 4.2.0rc3 Available for Download/a/li - - li 15 September 2014 a href=#4.0.22Samba 4.0.22 Available for Download/a/li /ul diff --git a/generated_news/latest_2_bodies.html b/generated_news/latest_2_bodies.html index 0ff09b0..4812e26 100644 --- a/generated_news/latest_2_bodies.html +++ b/generated_news/latest_2_bodies.html @@ -1,3 +1,11 @@ + h5a name=2015-03-06_vmware_lawsuit06 March 2015/a/h5 + p class=headlineSamba supports Christoph Hellwig's lawsuit against VMware/p + +pWe support the a href=https://sfconservancy.org/;Software Freedom Conservancy/a's +legal actions in defense of the GPL. Read our full +a href=https://www.samba.org/news/announcements/2015-03-06_vmware_lawsuit.html;lawsuit statement/a./p + + h5a name=4.2.004 March 2015/a/h5 p class=headlineSamba 4.2.0 Available for Download/p pThis is the first stable release of the Samba 4.2 series./p @@ -7,12 +15,3 @@ using GnuPG (ID 6568B7EA). The source code can be a href=http://samba.org/samba/ftp/stable/samba-4.2.0.tar.gz;downloaded now/a. See a href=http://samba.org/samba/history/samba-4.2.0.html; the release notes for more info/a./p - - -h5a name=survey201502 March 2015/a/h5 - p class=headlineCalling all Samba Users: 2015 User Survey/p - pWhat Samba features do you care about most? Do you have problems or - ideas to tell the Samba Team? Which parts of the documentation are - most important to you?/p - pThe Samba Team invites all users to participate in the - a href=https://www.surveygizmo.com/s3/2020369/Samba-User-Survey-2015;Samba Survey/a./p diff --git a/news/announcements/2015-03-06_vmware_lawsuit.html
