[SCM] pam wrapper repository - branch master updated

[Andreas Schneider]

The branch, master has been updated
   via  d98750e tests: Do not run python test if python is not present
  from  fbb0abf ctest: Drop ctest results via https

https://git.samba.org/?p=pam_wrapper.git;a=shortlog;h=master


- Log -
commit d98750e7294a50262629d11162e23a927688252a
Author: Andreas Schneider 
Date:   Thu Dec 10 17:03:46 2015 +0100

tests: Do not run python test if python is not present

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

---

Summary of changes:
 tests/CMakeLists.txt | 14 --
 1 file changed, 8 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 0055280..30f0eb2 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -47,9 +47,11 @@ set_property(
 PROPERTY
 ENVIRONMENT ${TEST_ENVIRONMENT})
 
-add_test(pypamtest_test ${CMAKE_CURRENT_SOURCE_DIR}/pypamtest_test.py)
-set_property(
-TEST
-pypamtest_test
-PROPERTY
-ENVIRONMENT ${TEST_ENVIRONMENT})
+if (PYTHONLIBS_FOUND)
+add_test(pypamtest_test ${CMAKE_CURRENT_SOURCE_DIR}/pypamtest_test.py)
+set_property(
+TEST
+pypamtest_test
+PROPERTY
+ENVIRONMENT ${TEST_ENVIRONMENT})
+endif()


-- 
pam wrapper repository

autobuild[sn-devel-144]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2015-12-10-0943/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2015-12-10-0943/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2015-12-10-0943/samba.stdout
  
The top commit at the time of the failure was:

commit 3c6ea3293c6aac67bc442f47185fd494714e4806
Author: Quentin Gibeaux 
Date:   Thu Oct 29 13:48:27 2015 +0100

lib/param: handle (ignore) substitution variable in smb.conf

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10722

The function handle_include returns false when trying to include
files that have a substitution variable in filename (like %U),
this patch makes handle_include to ignore this case, to make
samba-tool work when there is such include in samba's configuration.

Error was :
root@ubuntu:/usr/local/samba# grep 'include.*%U' etc/smb.conf
include = %U.conf
root@ubuntu:/usr/local/samba# ./bin/samba-tool user list
Can't find include file %U.conf
ERROR(runtime): uncaught exception - Unable to load default file

Signed-off-by: Quentin Gibeaux 
Reviewed-by: Michael Adam 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Dec  9 02:05:30 CET 2015 on sn-devel-104

[SCM] pam wrapper repository - branch master updated

[Michael Adam]

The branch, master has been updated
   via  59ecbfa py: Make sure we do not use failed uninitialized
   via  52ec969 py: Make sure we do not dereference a NULL pointer
   via  776a184 libpamtest: Do not call pam_end() if tc is not set
   via  927a070 libpamtest: Make sure reply is initialized
  from  d98750e tests: Do not run python test if python is not present

https://git.samba.org/?p=pam_wrapper.git;a=shortlog;h=master


- Log -
commit 59ecbfa4fb64785c24fe3ce4bfa96a23f804eac3
Author: Andreas Schneider 
Date:   Thu Dec 10 17:32:18 2015 +0100

py: Make sure we do not use failed uninitialized

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit 52ec969c2c074f2716c8c3bccd7940a84ddee92b
Author: Andreas Schneider 
Date:   Thu Dec 10 17:30:57 2015 +0100

py: Make sure we do not dereference a NULL pointer

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit 776a18460f3e259a12a8b07ee52d70676fdb7258
Author: Andreas Schneider 
Date:   Thu Dec 10 17:13:52 2015 +0100

libpamtest: Do not call pam_end() if tc is not set

This fixes a build warning.

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit 927a070eb6d80fb155ccc033704522d336789c28
Author: Andreas Schneider 
Date:   Thu Dec 10 17:10:55 2015 +0100

libpamtest: Make sure reply is initialized

Fixes a build warning

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

---

Summary of changes:
 src/libpamtest.c   | 6 +++---
 src/python/pypamtest.c | 9 +++--
 2 files changed, 10 insertions(+), 5 deletions(-)


Changeset truncated at 500 lines:

diff --git a/src/libpamtest.c b/src/libpamtest.c
index 612cdc1..6d6efc6 100644
--- a/src/libpamtest.c
+++ b/src/libpamtest.c
@@ -70,7 +70,7 @@ enum pamtest_err _pamtest_conv(const char *service,
pam_handle_t *ph;
struct pam_conv conv;
size_t tcindex;
-   struct pam_testcase *tc;
+   struct pam_testcase *tc = NULL;
bool call_pam_end = true;
 
conv.conv = conv_fn;
@@ -101,7 +101,7 @@ enum pamtest_err _pamtest_conv(const char *service,
}
}
 
-   if (call_pam_end == true) {
+   if (call_pam_end == true && tc != NULL) {
rv = pam_end(ph, tc->op_rv);
if (rv != PAM_SUCCESS) {
return PAMTEST_ERR_END;
@@ -198,7 +198,7 @@ static int pamtest_simple_conv(int num_msg,
 {
int i, ri;
int ret;
-   struct pam_response *reply;
+   struct pam_response *reply = NULL;
const char *prompt;
struct pamtest_conv_ctx *cctx = \
(struct pamtest_conv_ctx *) appdata_ptr;
diff --git a/src/python/pypamtest.c b/src/python/pypamtest.c
index 1538294..a1b5dd6 100644
--- a/src/python/pypamtest.c
+++ b/src/python/pypamtest.c
@@ -261,7 +261,12 @@ set_pypamtest_exception(PyObject *exc,
/* repr_fmt is fixed and contains just %d expansions, so this is safe */
char test_repr[256] = { '\0' };
const char *strerr;
-   const struct pam_testcase *failed;
+   const struct pam_testcase *failed = NULL;
+
+   if (exc == NULL) {
+   PyErr_BadArgument();
+   return;
+   }
 
strerr = pamtest_strerror(perr);
 
@@ -275,7 +280,7 @@ set_pypamtest_exception(PyObject *exc,
}
}
 
-   if (test_repr[0] != '\0') {
+   if (test_repr[0] != '\0' && failed != NULL) {
PyErr_Format(exc,
 "Error [%d]: Test case %s retured [%d]",
 perr, test_repr, failed->op_rv);


-- 
pam wrapper repository

[SCM] pam wrapper repository - branch master updated

[Michael Adam]

The branch, master has been updated
   via  7267de3 py: Fix strict aliasing rules in initpypamtest()
   via  7505e1c py: Fix strict aliasing rules in set_pypamtest_exception()
  from  59ecbfa py: Make sure we do not use failed uninitialized

https://git.samba.org/?p=pam_wrapper.git;a=shortlog;h=master


- Log -
commit 7267de3e692d4e07645488cde7f54c2d4ffa426d
Author: Andreas Schneider 
Date:   Thu Dec 10 17:36:09 2015 +0100

py: Fix strict aliasing rules in initpypamtest()

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit 7505e1c7f93fae556bb92b19922791bc703b6be1
Author: Andreas Schneider 
Date:   Thu Dec 10 17:35:51 2015 +0100

py: Fix strict aliasing rules in set_pypamtest_exception()

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

---

Summary of changes:
 src/python/pypamtest.c | 26 ++
 1 file changed, 18 insertions(+), 8 deletions(-)


Changeset truncated at 500 lines:

diff --git a/src/python/pypamtest.c b/src/python/pypamtest.c
index a1b5dd6..a773733 100644
--- a/src/python/pypamtest.c
+++ b/src/python/pypamtest.c
@@ -260,6 +260,10 @@ set_pypamtest_exception(PyObject *exc,
PyObject *obj = NULL;
/* repr_fmt is fixed and contains just %d expansions, so this is safe */
char test_repr[256] = { '\0' };
+   union {
+   char *str;
+   PyObject *obj;
+   } pypam_str_object;
const char *strerr;
const struct pam_testcase *failed = NULL;
 
@@ -291,7 +295,8 @@ set_pypamtest_exception(PyObject *exc,
PyErr_SetObject(exc, obj);
}
 
-   Py_XDECREF(test_repr);
+   pypam_str_object.str = test_repr;
+   Py_XDECREF(pypam_str_object.obj);
Py_XDECREF(obj);
 }
 
@@ -1008,6 +1013,10 @@ PyMODINIT_FUNC initpypamtest(void)
 #endif
 {
PyObject *m;
+   union {
+   PyTypeObject *type_obj;
+   PyObject *obj;
+   } pypam_object;
int ret;
 
 #if IS_PYTHON3
@@ -1069,18 +1078,19 @@ PyMODINIT_FUNC initpypamtest(void)
RETURN_ON_ERROR;
}
 
-   if (PyType_Ready(_test_case) < 0) {
+   pypam_object.type_obj = _test_case;
+   if (PyType_Ready(pypam_object.type_obj) < 0) {
RETURN_ON_ERROR;
}
-   Py_INCREF(_test_case);
-   PyModule_AddObject(m, "TestCase", (PyObject *) _test_case);
+   Py_INCREF(pypam_object.obj);
+   PyModule_AddObject(m, "TestCase", pypam_object.obj);
 
-   if (PyType_Ready(_test_result) < 0) {
+   pypam_object.type_obj = _test_result;
+   if (PyType_Ready(pypam_object.type_obj) < 0) {
RETURN_ON_ERROR;
}
-   Py_INCREF(_test_result);
-   PyModule_AddObject(m, "TestResult",
-  (PyObject *) _test_result);
+   Py_INCREF(pypam_object.obj);
+   PyModule_AddObject(m, "TestResult", pypam_object.obj);
 
 #if IS_PYTHON3
return m;


-- 
pam wrapper repository

[SCM] Samba Shared Repository - branch master updated

[Andreas Schneider]

The branch, master has been updated
   via  defa49e s4-torture: Remove obsolte code in backupkey_heimdal rpc 
test
   via  39bd6f0 s4-torture: Improve backupkey test to validate the self 
signed cert
   via  eb11fba s4-torture: Add a GnuTLS based backupkey rpc test
   via  59c11db s4-torture: Rename backupkey test to backupkey_heimdal
   via  97765d4 s4-rpc_server: Add a GnuTLS based backupkey implementation
   via  53e8fee waf: Check for GnuTLS 3.4.7
   via  8e09669 s4-rpc-bkrp: Do not set the ca status
   via  e8ce1f2 s4-rpc_server: Rename dcesrv_backupkey to 
dcesrv_backupkey_heimdal
   via  39ec708 s4-torture: make sure we always verify ndr pull and push of 
bkrp_exported_RSA_key_pair struct.
  from  2f16675 ping_pong: add -l option

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit defa49e00c5921ab44fdab53de73918d0732aeda
Author: Andreas Schneider 
Date:   Thu Dec 3 18:26:09 2015 +0100

s4-torture: Remove obsolte code in backupkey_heimdal rpc test

Signed-off-by: Andreas Schneider 
Reviewed-by: Garming Sam 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Thu Dec 10 11:54:00 CET 2015 on sn-devel-104

commit 39bd6f06660f1c4daf8020f78a9e66335a5b9425
Author: Andreas Schneider 
Date:   Thu Dec 3 18:25:11 2015 +0100

s4-torture: Improve backupkey test to validate the self signed cert

Signed-off-by: Andreas Schneider 
Reviewed-by: Garming Sam 

commit eb11fbaaf71310ec4869f1ca64319012503b11fc
Author: Andreas Schneider 
Date:   Thu Dec 3 18:21:03 2015 +0100

s4-torture: Add a GnuTLS based backupkey rpc test

Signed-off-by: Andreas Schneider 
Reviewed-by: Garming Sam 

commit 59c11db03d4c3e0c53b27d685e406de16c52e2a3
Author: Andreas Schneider 
Date:   Thu Dec 3 18:10:51 2015 +0100

s4-torture: Rename backupkey test to backupkey_heimdal

Signed-off-by: Andreas Schneider 
Reviewed-by: Garming Sam 

commit 97765d48f625738135b6cfe9fb55fa9bc6eba5e0
Author: Andreas Schneider 
Date:   Thu Dec 3 18:04:02 2015 +0100

s4-rpc_server: Add a GnuTLS based backupkey implementation

Signed-off-by: Andreas Schneider 
Reviewed-by: Garming Sam 

commit 53e8feeb6ad06c2345936a69b47769d1117e5e59
Author: Andreas Schneider 
Date:   Thu Dec 3 17:47:14 2015 +0100

waf: Check for GnuTLS 3.4.7

Signed-off-by: Andreas Schneider 
Reviewed-by: Garming Sam 

commit 8e096698af8f9fb35fbca5da20c552bf486d2b5e
Author: Andreas Schneider 
Date:   Wed Dec 9 08:29:45 2015 +0100

s4-rpc-bkrp: Do not set the ca status

Windows doesn't have any CA data set on the certificate.

Signed-off-by: Andreas Schneider 
Reviewed-by: Garming Sam 

commit e8ce1f247762c74cf1a33414afaaeb30cd9293db
Author: Andreas Schneider 
Date:   Thu Dec 3 17:12:05 2015 +0100

s4-rpc_server: Rename dcesrv_backupkey to dcesrv_backupkey_heimdal

Signed-off-by: Andreas Schneider 
Reviewed-by: Garming Sam 

commit 39ec70862214a9810cbbb63f7e99daecbeed6608
Author: Günther Deschner 
Date:   Fri Nov 13 11:15:41 2015 +0100

s4-torture: make sure we always verify ndr pull and push of 
bkrp_exported_RSA_key_pair struct.

Guenther

Signed-off-by: Günther Deschner 
Reviewed-by: Andreas Schneider 
Reviewed-by: Garming Sam 

---

Summary of changes:
 source4/lib/tls/wscript|   26 +-
 source4/rpc_server/backupkey/dcesrv_backupkey.c| 1042 ++--
 ...esrv_backupkey.c => dcesrv_backupkey_heimdal.c} |4 -
 source4/rpc_server/wscript_build   |   24 +-
 source4/torture/ndr/backupkey.c|6 +-
 source4/torture/rpc/backupkey.c|  767 +-
 .../rpc/{backupkey.c => backupkey_heimdal.c}   |  115 +--
 source4/torture/wscript_build  |7 +-
 8 files changed,  insertions(+), 880 deletions(-)
 copy source4/rpc_server/backupkey/{dcesrv_backupkey.c => 
dcesrv_backupkey_heimdal.c} (99%)
 copy source4/torture/rpc/{backupkey.c => backupkey_heimdal.c} (98%)


Changeset truncated at 500 lines:

diff --git a/source4/lib/tls/wscript b/source4/lib/tls/wscript
index 83520a7..2083409 100644
--- a/source4/lib/tls/wscript
+++ b/source4/lib/tls/wscript
@@ -21,14