autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-08-1208/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-08-1208/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-08-1208/samba.stdout The top commit at the time of the failure was: commit 5c53d50784b2d7883f3e1d9ac48bb1fd56ba7f42 Author: Martin Schwenke Date: Fri Nov 4 11:47:18 2016 +1100 ctdb-tests: Add tests for updated Debian style Samba start/stop BUG: https://bugzilla.samba.org/show_bug.cgi?id=12371 Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs Autobuild-User(master): Amitay Isaacs Autobuild-Date(master): Mon Nov 7 08:01:28 CET 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch v4-4-test updated
The branch, v4-4-test has been updated
via bf9e460 vfs:glusterfs: preallocate result for glfs_realpath
from 37e476a s3-winbind: Do not return NO_MEMORY if we have an empty
user list
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-4-test
- Log -
commit bf9e460099d61f3614c2ea34fddc2bbe495083b8
Author: Michael Adam
Date: Fri Oct 21 00:15:06 2016 +0200
vfs:glusterfs: preallocate result for glfs_realpath
https://bugzilla.samba.org/show_bug.cgi?id=12404
This makes us independent of the allocation
method used inside glfs_realpath.
Signed-off-by: Michael Adam
Reviewed-by: Ira Cooper
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Sat Oct 22 00:28:41 CEST 2016 on sn-devel-144
(cherry picked from commit 92a0a56c3852726e0812d260e043957c879aefa4)
Autobuild-User(v4-4-test): Karolin Seeger
Autobuild-Date(v4-4-test): Tue Nov 8 15:35:20 CET 2016 on sn-devel-144
---
Summary of changes:
source3/modules/vfs_glusterfs.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c
index 6548d7e..b8ad196 100644
--- a/source3/modules/vfs_glusterfs.c
+++ b/source3/modules/vfs_glusterfs.c
@@ -1020,7 +1020,20 @@ static int vfs_gluster_fallocate(struct
vfs_handle_struct *handle,
static char *vfs_gluster_realpath(struct vfs_handle_struct *handle,
const char *path)
{
- return glfs_realpath(handle->data, path, 0);
+ char *result = NULL;
+ char *resolved_path = SMB_MALLOC_ARRAY(char, PATH_MAX+1);
+
+ if (resolved_path == NULL) {
+ errno = ENOMEM;
+ return NULL;
+ }
+
+ result = glfs_realpath(handle->data, path, resolved_path);
+ if (result == NULL) {
+ SAFE_FREE(resolved_path);
+ }
+
+ return result;
}
static bool vfs_gluster_lock(struct vfs_handle_struct *handle,
--
Samba Shared Repository
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-08-1606/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-08-1606/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-08-1606/samba.stdout The top commit at the time of the failure was: commit 5c53d50784b2d7883f3e1d9ac48bb1fd56ba7f42 Author: Martin Schwenke Date: Fri Nov 4 11:47:18 2016 +1100 ctdb-tests: Add tests for updated Debian style Samba start/stop BUG: https://bugzilla.samba.org/show_bug.cgi?id=12371 Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs Autobuild-User(master): Amitay Isaacs Autobuild-Date(master): Mon Nov 7 08:01:28 CET 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 0750542 s3-spoolss: Remove printer from registry if it is
unpublished
via 119c15f s3-printing: Improve debug message
from 5c53d50 ctdb-tests: Add tests for updated Debian style Samba
start/stop
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 07505429cc4bb7e56f4dcdcaeb4eabdcd8e550e5
Author: Andreas Schneider
Date: Tue Nov 8 12:20:41 2016 +0100
s3-spoolss: Remove printer from registry if it is unpublished
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11665
Signed-off-by: Andreas Schneider
Reviewed-by: Guenther Deschner
Autobuild-User(master): Andreas Schneider
Autobuild-Date(master): Tue Nov 8 18:05:10 CET 2016 on sn-devel-144
commit 119c15fc4a994e594cc9b0e63557404fd59f3aac
Author: Andreas Schneider
Date: Tue Nov 8 12:20:25 2016 +0100
s3-printing: Improve debug message
Signed-off-by: Andreas Schneider
Reviewed-by: Guenther Deschner
---
Summary of changes:
source3/printing/nt_printing_ads.c | 4 +++-
source3/rpc_server/spoolss/srv_spoolss_nt.c | 34 -
2 files changed, 32 insertions(+), 6 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/printing/nt_printing_ads.c
b/source3/printing/nt_printing_ads.c
index cf4c310..2588e1d 100644
--- a/source3/printing/nt_printing_ads.c
+++ b/source3/printing/nt_printing_ads.c
@@ -569,7 +569,9 @@ WERROR nt_printer_publish(TALLOC_CTX *mem_ctx,
pinfo2->sharename, info2_mask,
sinfo2, NULL, NULL);
if (!W_ERROR_IS_OK(win_rc)) {
- DEBUG(3, ("err %d saving data\n", W_ERROR_V(win_rc)));
+ DBG_NOTICE("Failed to update data for printer [%s] - %s\n",
+ pinfo2->sharename,
+ win_errstr(win_rc));
goto done;
}
diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c
b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index 9f1d44f..deb87a3 100644
--- a/source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c
@@ -4215,6 +4215,7 @@ static WERROR construct_printer_info7(TALLOC_CTX *mem_ctx,
int snum)
{
const struct auth_session_info *session_info;
+ struct spoolss_PrinterInfo2 *pinfo2 = NULL;
char *printer;
WERROR werr;
TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
@@ -4233,7 +4234,7 @@ static WERROR construct_printer_info7(TALLOC_CTX *mem_ctx,
}
if (is_printer_published(tmp_ctx, session_info, msg_ctx,
-servername, printer, NULL)) {
+servername, printer, &pinfo2)) {
struct GUID guid;
struct GUID_txt_buf guid_txt;
werr = nt_printer_guid_get(tmp_ctx, session_info, msg_ctx,
@@ -4246,10 +4247,33 @@ static WERROR construct_printer_info7(TALLOC_CTX
*mem_ctx,
werr = nt_printer_guid_retrieve(tmp_ctx, printer,
&guid);
if (!W_ERROR_IS_OK(werr)) {
- DEBUG(1, ("Failed to retrieve GUID for "
- "printer [%s] from AD - "
- "Is the the printer still "
- "published ?\n", printer));
+ DBG_NOTICE("Failed to retrieve GUID for "
+ "printer [%s] from AD - %s\n",
+ printer,
+ win_errstr(werr));
+ if (W_ERROR_EQUAL(werr, WERR_FILE_NOT_FOUND)) {
+ /*
+* If we did not find it in AD, then it
+* is unpublished and we should reflect
+* this in the registry and return
+* success.
+*/
+ DBG_WARNING("Unpublish printer [%s]\n",
+ pinfo2->sharename);
+ nt_printer_publish(tmp_ctx,
+ session_info,
+ msg_ctx,
+ pinfo2,
+ DSPRINT_UNPUBLISH);
+ r->guid = talloc_strdup(mem_ctx, "");
+
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-08-2011/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-08-2011/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-08-2011/samba.stdout The top commit at the time of the failure was: commit 07505429cc4bb7e56f4dcdcaeb4eabdcd8e550e5 Author: Andreas Schneider Date: Tue Nov 8 12:20:41 2016 +0100 s3-spoolss: Remove printer from registry if it is unpublished BUG: https://bugzilla.samba.org/show_bug.cgi?id=11665 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Tue Nov 8 18:05:10 CET 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-11-08-2108/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-11-08-2108/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-11-08-2108/samba.stdout The top commit at the time of the failure was: commit 07505429cc4bb7e56f4dcdcaeb4eabdcd8e550e5 Author: Andreas Schneider Date: Tue Nov 8 12:20:41 2016 +0100 s3-spoolss: Remove printer from registry if it is unpublished BUG: https://bugzilla.samba.org/show_bug.cgi?id=11665 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Tue Nov 8 18:05:10 CET 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-09-0003/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-09-0003/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-09-0003/samba.stdout The top commit at the time of the failure was: commit 07505429cc4bb7e56f4dcdcaeb4eabdcd8e550e5 Author: Andreas Schneider Date: Tue Nov 8 12:20:41 2016 +0100 s3-spoolss: Remove printer from registry if it is unpublished BUG: https://bugzilla.samba.org/show_bug.cgi?id=11665 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Tue Nov 8 18:05:10 CET 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-11-09-0332/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-11-09-0332/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-11-09-0332/samba.stdout The top commit at the time of the failure was: commit 07505429cc4bb7e56f4dcdcaeb4eabdcd8e550e5 Author: Andreas Schneider Date: Tue Nov 8 12:20:41 2016 +0100 s3-spoolss: Remove printer from registry if it is unpublished BUG: https://bugzilla.samba.org/show_bug.cgi?id=11665 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Tue Nov 8 18:05:10 CET 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-09-0409/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-09-0409/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-09-0409/samba.stdout The top commit at the time of the failure was: commit 07505429cc4bb7e56f4dcdcaeb4eabdcd8e550e5 Author: Andreas Schneider Date: Tue Nov 8 12:20:41 2016 +0100 s3-spoolss: Remove printer from registry if it is unpublished BUG: https://bugzilla.samba.org/show_bug.cgi?id=11665 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Tue Nov 8 18:05:10 CET 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-11-09-0425/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-11-09-0425/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-11-09-0425/samba.stdout The top commit at the time of the failure was: commit 07505429cc4bb7e56f4dcdcaeb4eabdcd8e550e5 Author: Andreas Schneider Date: Tue Nov 8 12:20:41 2016 +0100 s3-spoolss: Remove printer from registry if it is unpublished BUG: https://bugzilla.samba.org/show_bug.cgi?id=11665 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Tue Nov 8 18:05:10 CET 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 82e630d s3-client: Sync in tool cmdline help with smbclient manpage
from 0750542 s3-spoolss: Remove printer from registry if it is
unpublished
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 82e630dc3585f832ac1c4bb2a0a59063f756e4dc
Author: Andreas Schneider
Date: Fri Nov 4 16:00:05 2016 +0100
s3-client: Sync in tool cmdline help with smbclient manpage
From smbclient manpage:
notify
Query a directory for change notifications. This command issues a
recursive filechangenotify call for all possible changes.
Signed-off-by: Andreas Schneider
Reviewed-by: Jeremy Allison
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Wed Nov 9 06:12:23 CET 2016 on sn-devel-144
---
Summary of changes:
source3/client/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source3/client/client.c b/source3/client/client.c
index e7531d3..78862ee 100644
--- a/source3/client/client.c
+++ b/source3/client/client.c
@@ -4162,7 +4162,7 @@ static int cmd_notify(void)
TALLOC_FREE(changes);
}
usage:
- d_printf("notify \n");
+ d_printf("notify \n");
fail:
TALLOC_FREE(frame);
return 1;
--
Samba Shared Repository
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-09-0803/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-09-0803/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-09-0803/samba.stdout The top commit at the time of the failure was: commit 82e630dc3585f832ac1c4bb2a0a59063f756e4dc Author: Andreas Schneider Date: Fri Nov 4 16:00:05 2016 +0100 s3-client: Sync in tool cmdline help with smbclient manpage From smbclient manpage: notify Query a directory for change notifications. This command issues a recursive filechangenotify call for all possible changes. Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Nov 9 06:12:23 CET 2016 on sn-devel-144
