autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-07-0808/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-07-0808/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-07-0808/samba.stdout
  
The top commit at the time of the failure was:

commit 3aecad2ffd1a3ad906ef40d77cca3530042d6a10
Author: Volker Lendecke 
Date:   Thu Dec 1 16:16:14 2016 +

winbind: dom_sid_parse_endp always initializes "endp" when ok

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Dec  7 00:11:03 CET 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-07-0406/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-07-0406/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-07-0406/samba.stdout
  
The top commit at the time of the failure was:

commit 3aecad2ffd1a3ad906ef40d77cca3530042d6a10
Author: Volker Lendecke 
Date:   Thu Dec 1 16:16:14 2016 +

winbind: dom_sid_parse_endp always initializes "endp" when ok

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Dec  7 00:11:03 CET 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

The branch, master has been updated
   via  3aecad2 winbind: dom_sid_parse_endp always initializes "endp" when 
ok
   via  5bded5b idmap_autorid: dom_sid_parse_endp always initializes "endp" 
when ok
   via  a590238 lib: Make dom_sid_parse_endp init "endp" on all "ok" paths
   via  61d5009 idmap_autorid: Add a {} pair in an if-statement
  from  a3add01 printing: Fix building with CUPS version older than 1.7

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 3aecad2ffd1a3ad906ef40d77cca3530042d6a10
Author: Volker Lendecke 
Date:   Thu Dec 1 16:16:14 2016 +

winbind: dom_sid_parse_endp always initializes "endp" when ok

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Dec  7 00:11:03 CET 2016 on sn-devel-144

commit 5bded5b483efa74539e56748a4a54af02dc725e2
Author: Volker Lendecke 
Date:   Thu Dec 1 16:16:14 2016 +

idmap_autorid: dom_sid_parse_endp always initializes "endp" when ok

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit a5902383e3886e874bd270a06673d07386149dfd
Author: Volker Lendecke 
Date:   Thu Dec 1 16:15:29 2016 +

lib: Make dom_sid_parse_endp init "endp" on all "ok" paths

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 61d5009888dd3bf614345a249c8c1e44bca1533f
Author: Volker Lendecke 
Date:   Thu Dec 1 16:11:38 2016 +

idmap_autorid: Add a {} pair in an if-statement

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

---

Summary of changes:
 libcli/security/dom_sid.c| 3 ++-
 source3/winbindd/idmap_autorid.c | 3 ++-
 source3/winbindd/winbindd_util.c | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c
index 8b30ee6..5454c51 100644
--- a/libcli/security/dom_sid.c
+++ b/libcli/security/dom_sid.c
@@ -172,7 +172,7 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid 
*sidout,
sidout->num_auths = 0;
if (*q != '-') {
/* Just id_auth, no subauths */
-   return true;
+   goto done;
}
 
q++;
@@ -200,6 +200,7 @@ bool dom_sid_parse_endp(const char *sidstr,struct dom_sid 
*sidout,
}
q += 1;
}
+done:
if (endp != NULL) {
*endp = q;
}
diff --git a/source3/winbindd/idmap_autorid.c b/source3/winbindd/idmap_autorid.c
index 20cd5b7..1fd6a76 100644
--- a/source3/winbindd/idmap_autorid.c
+++ b/source3/winbindd/idmap_autorid.c
@@ -243,7 +243,7 @@ static NTSTATUS idmap_autorid_id_to_sid(struct 
autorid_global_config *cfg,
map->status = ID_UNKNOWN;
return NT_STATUS_OK;
}
-   if ((q != NULL) && (*q != '\0'))
+   if (*q != '\0') {
if (sscanf(q+1, "%"SCNu32, _range_index) != 1) {
DEBUG(10, ("Domain range index not found, "
   "ignoring mapping request\n"));
@@ -251,6 +251,7 @@ static NTSTATUS idmap_autorid_id_to_sid(struct 
autorid_global_config *cfg,
map->status = ID_UNKNOWN;
return NT_STATUS_OK;
}
+   }
 
TALLOC_FREE(data.dptr);
 
diff --git a/source3/winbindd/winbindd_util.c b/source3/winbindd/winbindd_util.c
index a35b59e..38e4b8b 100644
--- a/source3/winbindd/winbindd_util.c
+++ b/source3/winbindd/winbindd_util.c
@@ -1651,7 +1651,7 @@ bool parse_sidlist(TALLOC_CTX *mem_ctx, const char 
*sidstr,
DEBUG(1, ("Could not parse sid %s\n", p));
return false;
}
-   if ((q == NULL) || (q[0] != '\n')) {
+   if (q[0] != '\n') {
DEBUG(1, ("Got invalid sidstr: %s\n", p));
return false;
}


-- 
Samba Shared Repository

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-07-0009/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-07-0009/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-07-0009/samba.stdout
  
The top commit at the time of the failure was:

commit a3add017e4c6de04c46ea2e5d65be6ad11c059a3
Author: Andreas Schneider 
Date:   Tue Dec 6 09:44:28 2016 +0100

printing: Fix building with CUPS version older than 1.7

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12183

Signed-off-by: Andreas Schneider 
Reviewed-by: Karolin Seeger 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Dec  6 13:54:28 CET 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-06-2003/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-06-2003/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-06-2003/samba.stdout
  
The top commit at the time of the failure was:

commit a3add017e4c6de04c46ea2e5d65be6ad11c059a3
Author: Andreas Schneider 
Date:   Tue Dec 6 09:44:28 2016 +0100

printing: Fix building with CUPS version older than 1.7

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12183

Signed-off-by: Andreas Schneider 
Reviewed-by: Karolin Seeger 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Dec  6 13:54:28 CET 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-06-1605/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-06-1605/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-06-1605/samba.stdout
  
The top commit at the time of the failure was:

commit a3add017e4c6de04c46ea2e5d65be6ad11c059a3
Author: Andreas Schneider 
Date:   Tue Dec 6 09:44:28 2016 +0100

printing: Fix building with CUPS version older than 1.7

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12183

Signed-off-by: Andreas Schneider 
Reviewed-by: Karolin Seeger 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Dec  6 13:54:28 CET 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch v4-5-test updated

[Karolin Seeger]

The branch, v4-5-test has been updated
   via  343718c printing: Fix building with CUPS version older than 1.7
  from  d869ba0 VERSION: Bump version up to 4.5.3...

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-5-test


- Log -
commit 343718c30f372f558f90286cb10be7409b7bfad9
Author: Andreas Schneider 
Date:   Tue Dec 6 09:44:28 2016 +0100

printing: Fix building with CUPS version older than 1.7

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12183

Signed-off-by: Andreas Schneider 
Reviewed-by: Karolin Seeger 

Autobuild-User(v4-5-test): Karolin Seeger 
Autobuild-Date(v4-5-test): Tue Dec  6 14:21:49 CET 2016 on sn-devel-144

---

Summary of changes:
 source3/printing/print_cups.c | 6 ++
 1 file changed, 6 insertions(+)


Changeset truncated at 500 lines:

diff --git a/source3/printing/print_cups.c b/source3/printing/print_cups.c
index 673a150..7c4d35d 100644
--- a/source3/printing/print_cups.c
+++ b/source3/printing/print_cups.c
@@ -31,6 +31,12 @@
 #ifdef HAVE_CUPS
 #include 
 #include 
+#include 
+
+/* CUPS prior to version 1.7 doesn't have HTTP_URI_STATUS_OK */
+#if (CUPS_VERSION_MAJOR == 1) && (CUPS_VERSION_MINOR < 7)
+#define HTTP_URI_STATUS_OK HTTP_URI_OK
+#endif
 
 #if (CUPS_VERSION_MAJOR > 1) || (CUPS_VERSION_MINOR > 5)
 #define HAVE_CUPS_1_6 1


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

[Andreas Schneider]

The branch, master has been updated
   via  a3add01 printing: Fix building with CUPS version older than 1.7
  from  4e32944 ctdb: Add new helper ctdb_etcd_lock

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit a3add017e4c6de04c46ea2e5d65be6ad11c059a3
Author: Andreas Schneider 
Date:   Tue Dec 6 09:44:28 2016 +0100

printing: Fix building with CUPS version older than 1.7

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12183

Signed-off-by: Andreas Schneider 
Reviewed-by: Karolin Seeger 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Dec  6 13:54:28 CET 2016 on sn-devel-144

---

Summary of changes:
 source3/printing/print_cups.c | 6 ++
 1 file changed, 6 insertions(+)


Changeset truncated at 500 lines:

diff --git a/source3/printing/print_cups.c b/source3/printing/print_cups.c
index 673a150..7c4d35d 100644
--- a/source3/printing/print_cups.c
+++ b/source3/printing/print_cups.c
@@ -31,6 +31,12 @@
 #ifdef HAVE_CUPS
 #include 
 #include 
+#include 
+
+/* CUPS prior to version 1.7 doesn't have HTTP_URI_STATUS_OK */
+#if (CUPS_VERSION_MAJOR == 1) && (CUPS_VERSION_MINOR < 7)
+#define HTTP_URI_STATUS_OK HTTP_URI_OK
+#endif
 
 #if (CUPS_VERSION_MAJOR > 1) || (CUPS_VERSION_MINOR > 5)
 #define HAVE_CUPS_1_6 1


-- 
Samba Shared Repository

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-06-1204/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-06-1204/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-06-1204/samba.stdout
  
The top commit at the time of the failure was:

commit 4e32944b785418ef6d16d921391412d8feb37853
Author: Jose A. Rivera 
Date:   Mon Jul 25 14:58:16 2016 -0500

ctdb: Add new helper ctdb_etcd_lock

This introduces a mutex helper called ctdb_etcd_lock, which allows CTDB to
use an existing etcd cluster to provide the functionality of a recovery lock
using the API outlined in ctdb/doc/cluster_mutex_helper.txt.

Signed-off-by: Jose A. Rivera 
Reviewed-by: David Disseldorp 

Autobuild-User(master): José A. Rivera 
Autobuild-Date(master): Mon Dec  5 19:39:10 CET 2016 on sn-devel-144