autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-18-0804/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-18-0804/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-18-0804/samba.stdout
  
The top commit at the time of the failure was:

commit f09f5ae631c64da016072b1c09c172f4673a06cd
Author: Stefan Metzmacher 
Date:   Fri Dec 16 11:09:16 2016 +0100

selftest: make sure we always export KRB5CCNAME

We should not risk the usage of the users global ccache!

This results in unpredictable effects for the user and
selftest itself.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat Dec 17 22:58:28 CET 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-18-0407/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-18-0407/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-18-0407/samba.stdout
  
The top commit at the time of the failure was:

commit f09f5ae631c64da016072b1c09c172f4673a06cd
Author: Stefan Metzmacher 
Date:   Fri Dec 16 11:09:16 2016 +0100

selftest: make sure we always export KRB5CCNAME

We should not risk the usage of the users global ccache!

This results in unpredictable effects for the user and
selftest itself.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat Dec 17 22:58:28 CET 2016 on sn-devel-144

autobuild[sn-devel-144]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2016-12-18-0237/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-12-18-0237/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-12-18-0237/samba.stdout
  
The top commit at the time of the failure was:

commit f09f5ae631c64da016072b1c09c172f4673a06cd
Author: Stefan Metzmacher 
Date:   Fri Dec 16 11:09:16 2016 +0100

selftest: make sure we always export KRB5CCNAME

We should not risk the usage of the users global ccache!

This results in unpredictable effects for the user and
selftest itself.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat Dec 17 22:58:28 CET 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-18-0008/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-18-0008/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-18-0008/samba.stdout
  
The top commit at the time of the failure was:

commit f09f5ae631c64da016072b1c09c172f4673a06cd
Author: Stefan Metzmacher 
Date:   Fri Dec 16 11:09:16 2016 +0100

selftest: make sure we always export KRB5CCNAME

We should not risk the usage of the users global ccache!

This results in unpredictable effects for the user and
selftest itself.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat Dec 17 22:58:28 CET 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

The branch, master has been updated
   via  f09f5ae selftest: make sure we always export KRB5CCNAME
   via  cbbd95c selftest: also export TMPDIR
   via  60a8e70 script/autobuild.py: create tmpdir for each try and export 
it as TMPDIR
   via  49de2f3 script/autobuild.py: cleanup testbase/prefix before each 
retry
   via  b8c6330 script/autobuild.py: remove pointless mkdir/rmdir commands
   via  6f0ffd7 script/autobuild.py: don't add subdirs of testbase to 
cleanup_list
  from  e717ca6 vfs_gpfs: simplify stat_with_capability() ifdef

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit f09f5ae631c64da016072b1c09c172f4673a06cd
Author: Stefan Metzmacher 
Date:   Fri Dec 16 11:09:16 2016 +0100

selftest: make sure we always export KRB5CCNAME

We should not risk the usage of the users global ccache!

This results in unpredictable effects for the user and
selftest itself.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Sat Dec 17 22:58:28 CET 2016 on sn-devel-144

commit cbbd95c7f23787263e5d07b765b1d9cde01bd6b1
Author: Stefan Metzmacher 
Date:   Thu Dec 15 10:31:50 2016 +0100

selftest: also export TMPDIR

This should hopefully avoid usage of /tmp.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

commit 60a8e70fe1cb278295ededc41015b09cecb00d48
Author: Stefan Metzmacher 
Date:   Fri Dec 16 13:35:36 2016 +0100

script/autobuild.py: create tmpdir for each try and export it as TMPDIR

This way the compiler and other tools hopefully don't use /tmp
anymore.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

commit 49de2f3a79bd12a7f7bc17bc5f4bae36d23f2489
Author: Stefan Metzmacher 
Date:   Fri Dec 16 13:35:01 2016 +0100

script/autobuild.py: cleanup testbase/prefix before each retry

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

commit b8c63307bd6b2116c85d0ac9cf249b1e8ef7e0a6
Author: Stefan Metzmacher 
Date:   Fri Dec 16 13:33:42 2016 +0100

script/autobuild.py: remove pointless mkdir/rmdir commands

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

commit 6f0ffd767ce610b28884c76f52f7f80652fd413d
Author: Stefan Metzmacher 
Date:   Fri Dec 16 13:30:57 2016 +0100

script/autobuild.py: don't add subdirs of testbase to cleanup_list

We already have testbase in there.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

---

Summary of changes:
 script/autobuild.py  | 13 +++--
 selftest/selftest.pl |  9 +
 2 files changed, 16 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/script/autobuild.py b/script/autobuild.py
index 356b7fa..3d76130 100755
--- a/script/autobuild.py
+++ b/script/autobuild.py
@@ -276,11 +276,7 @@ class builder(object):
 self.stderr = open(self.stderr_path, 'w')
 self.stdin  = open("/dev/null", 'r')
 self.sdir = "%s/%s" % (testbase, self.tag)
-self.prefix = "%s/prefix/%s" % (testbase, self.tag)
-run_cmd("rm -rf %s" % self.sdir)
-cleanup_list.append(self.sdir)
-cleanup_list.append(self.prefix)
-os.makedirs(self.sdir)
+self.prefix = "%s/%s" % (test_prefix, self.tag)
 run_cmd("rm -rf %s" % self.sdir)
 if cp:
 run_cmd("cp --recursive --link --archive %s %s" % (test_master, 
self.sdir), dir=test_master, show=True)
@@ -712,6 +708,9 @@ if options.retry:
 
 testbase = "%s/b%u" % (options.testbase, os.getpid())
 test_master = "%s/master" % testbase
+test_prefix = "%s/prefix" % testbase
+test_tmpdir = "%s/tmp" % testbase
+os.environ['TMPDIR'] = test_tmpdir
 
 # get the top commit message, for emails
 top_commit_msg = run_cmd("git log -1", dir=gitroot, output=True)
@@ -734,7 +733,9 @@ start_time = time.time()
 while True:
 try:
 run_cmd("rm -rf %s" % test_master)
-cleanup_list.append(test_master)
+run_cmd("rm -rf %s" % test_prefix)
+run_cmd("rm -rf %s" % test_tmpdir)
+os.makedirs(test_tmpdir)
 run_cmd("git clone --recursive --shared %s %s" % (gitroot, 
test_master), show=True, dir=gitroot)
 except Exception:
 cleanup()
diff --git a/selftest/selftest.pl b/selftest/selftest.pl
index 7d71013..c54ea68 100755
--- a/selftest/selftest.pl
+++ b/selftest/selftest.pl
@@ -654,6 +654,7 @@ if ($#testlists == -1) {
 
 

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-17-1609/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-17-1609/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-17-1609/samba.stdout
  
The top commit at the time of the failure was:

commit e717ca65cfb3d8fee28f3ccc1e96d765f637642d
Author: Ralph Boehme 
Date:   Thu Dec 15 18:10:22 2016 +0100

vfs_gpfs: simplify stat_with_capability() ifdef

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Sat Dec 17 12:58:07 CET 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Ralph Böhme]

The branch, master has been updated
   via  e717ca6 vfs_gpfs: simplify stat_with_capability() ifdef
   via  2e8cdda vfs_gpfs: remove updating btime from stat VFS calls
   via  adf4cea vfs_gpfs: update btime in vfs_gpfs_(f)get_dos_attributes
  from  1227065 idmap_autorid: Simplify idmap_autorid_loadconfig

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit e717ca65cfb3d8fee28f3ccc1e96d765f637642d
Author: Ralph Boehme 
Date:   Thu Dec 15 18:10:22 2016 +0100

vfs_gpfs: simplify stat_with_capability() ifdef

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Sat Dec 17 12:58:07 CET 2016 on sn-devel-144

commit 2e8cdda78774d5ecd1b4c4e2e11edf3e0829b3b4
Author: Ralph Boehme 
Date:   Mon Nov 28 12:22:04 2016 +0100

vfs_gpfs: remove updating btime from stat VFS calls

This is now handled by the vfs_gpfs_(f)get_dos_attributes. Getting rid
of this in the stat VFS functions is a huge performance saver. perf
report found that in a kernel copy workload smbd was spending
considerable CPU time in vfs_gpfs_(f|l)stat -> gpfs_get_winattrs.

Most of the time the VFS stat caller is not interested in the btime. The
SMB frontend processing around btime is designed to fetch btime together
with DOS attributes via dos_mode() in all places that need these
attributes. That's the way it is implemented in the default VFS module
and that's what vfs_gpfs now does as well for performance reasons.

This makes vfs_gpfs_fstat a null op and I'm therefor removing it.

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 

commit adf4cea1db46f2898540c041003da5b4bd447f80
Author: Ralph Boehme 
Date:   Thu Dec 15 07:09:58 2016 +0100

vfs_gpfs: update btime in vfs_gpfs_(f)get_dos_attributes

This paves the way for removing btime updates from the stat VFS
functions.

This way we behave like the default VFS module where DOS attributes and
btime are fetched from the same backing store and the frontend is
designed around using dos_mode() -> SMB_VFS_GET_ATTRIBUTES to update
both attributes as necessary in the SMB processing.

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 

---

Summary of changes:
 source3/modules/vfs_gpfs.c | 98 ++
 1 file changed, 12 insertions(+), 86 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c
index 89ce3b7..f7434c9 100644
--- a/source3/modules/vfs_gpfs.c
+++ b/source3/modules/vfs_gpfs.c
@@ -1565,6 +1565,9 @@ static NTSTATUS vfs_gpfs_get_dos_attributes(struct 
vfs_handle_struct *handle,
}
 
*dosmode |= vfs_gpfs_winattrs_to_dosmode(attrs.winAttrs);
+   smb_fname->st.st_ex_calculated_birthtime = false;
+   smb_fname->st.st_ex_btime.tv_sec = attrs.creationTime.tv_sec;
+   smb_fname->st.st_ex_btime.tv_nsec = attrs.creationTime.tv_nsec;
 
return NT_STATUS_OK;
 }
@@ -1597,6 +1600,9 @@ static NTSTATUS vfs_gpfs_fget_dos_attributes(struct 
vfs_handle_struct *handle,
}
 
*dosmode |= vfs_gpfs_winattrs_to_dosmode(attrs.winAttrs);
+   fsp->fsp_name->st.st_ex_calculated_birthtime = false;
+   fsp->fsp_name->st.st_ex_btime.tv_sec = attrs.creationTime.tv_sec;
+   fsp->fsp_name->st.st_ex_btime.tv_nsec = attrs.creationTime.tv_nsec;
 
return NT_STATUS_OK;
 }
@@ -1669,10 +1675,10 @@ static NTSTATUS vfs_gpfs_fset_dos_attributes(struct 
vfs_handle_struct *handle,
return NT_STATUS_OK;
 }
 
-#if defined(HAVE_FSTATAT)
 static int stat_with_capability(struct vfs_handle_struct *handle,
struct smb_filename *smb_fname, int flag)
 {
+#if defined(HAVE_FSTATAT)
int fd = -1;
bool b;
char *dir_name;
@@ -1706,15 +1712,14 @@ static int stat_with_capability(struct 
vfs_handle_struct *handle,
}
 
return ret;
-}
+#else
+   return -1;
 #endif
+}
 
 static int vfs_gpfs_stat(struct vfs_handle_struct *handle,
 struct smb_filename *smb_fname)
 {
-   struct gpfs_winattr attrs;
-   char *fname = NULL;
-   NTSTATUS status;
int ret;
struct gpfs_config_data *config;
 
@@ -1723,73 +1728,17 @@ static int vfs_gpfs_stat(struct vfs_handle_struct 
*handle,
return -1);
 
ret = SMB_VFS_NEXT_STAT(handle, smb_fname);
-#if defined(HAVE_FSTATAT)
if (ret == -1 && errno == EACCES) {
DEBUG(10, ("Trying stat with capability for %s\n",
   

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-17-1203/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-17-1203/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-12-17-1203/samba.stdout
  
The top commit at the time of the failure was:

commit 122706550c67ef778fd4634508bec9e0507a1fe0
Author: Volker Lendecke 
Date:   Mon Dec 5 15:31:56 2016 +

idmap_autorid: Simplify idmap_autorid_loadconfig

autorid_global_config is a fixed small structure that can be 
stack-allocated.

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Fri Dec 16 21:30:28 CET 2016 on sn-devel-144