[SCM] Samba Shared Repository - branch v4-7-test updated

2017-07-25 Thread Karolin Seeger
The branch, v4-7-test has been updated
   via  eb874b9 VERSION: Bump version up to 4.7.0rc4...
   via  ce4fa8f VERSION: Disable GIT_SNAPSHOTS for the 4.7.0rc3 release.
   via  fabbc51 WHATSNEW: Add release notes for Samba 4.7.0rc3.
  from  54088c0 s3: drop build_env

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-7-test


- Log -
commit eb874b948267d9aa76331b8de6768fa4e6ddb3da
Author: Karolin Seeger 
Date:   Tue Jul 25 11:06:45 2017 +0200

VERSION: Bump version up to 4.7.0rc4...

and re-enable GIT_SNAPSHOTS.

Signed-off-by: Karolin Seeger 

commit ce4fa8f669a1667e6b9f7953a7807af312c24d2d
Author: Karolin Seeger 
Date:   Tue Jul 25 11:05:53 2017 +0200

VERSION: Disable GIT_SNAPSHOTS for the 4.7.0rc3 release.

Signed-off-by: Karolin Seeger 

commit fabbc517758f29577d3f650ca92d1c66c9cf595a
Author: Karolin Seeger 
Date:   Tue Jul 25 11:04:54 2017 +0200

WHATSNEW: Add release notes for Samba 4.7.0rc3.

Signed-off-by: Karolin Seeger 

---

Summary of changes:
 VERSION  |  2 +-
 WHATSNEW.txt | 63 ++--
 2 files changed, 62 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/VERSION b/VERSION
index bf2f52f..9c77c15 100644
--- a/VERSION
+++ b/VERSION
@@ -87,7 +87,7 @@ SAMBA_VERSION_PRE_RELEASE=
 # e.g. SAMBA_VERSION_RC_RELEASE=1  #
 #  ->  "3.0.0rc1"  #
 
-SAMBA_VERSION_RC_RELEASE=3
+SAMBA_VERSION_RC_RELEASE=4
 
 
 # To mark SVN snapshots this should be set to 'yes'#
diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index 5d49bb7..3bddec7 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -1,7 +1,7 @@
 Release Announcements
 =
 
-This is the second release candidate of Samba 4.7.  This is *not*
+This is the third release candidate of Samba 4.7.  This is *not*
 intended for production environments and is designed for testing
 purposes only.  Please report any defects via the Samba bug reporting
 system at https://bugzilla.samba.org/.
@@ -78,7 +78,6 @@ LDAP read inconsistency
 See https://bugzilla.samba.org/show_bug.cgi?id=12858 for more details
 and updated advise on database recovery for affected installations.
 
-
 Samba AD with MIT Kerberos
 --
 
@@ -303,6 +302,7 @@ the previous behaviour.  Two new values have been provided,
 and 'disabled', totally disabling NTLM authentication and password
 changes.
 
+
 smb.conf changes
 
 
@@ -330,6 +330,65 @@ KNOWN ISSUES
 
https://wiki.samba.org/index.php/Release_Planning_for_Samba_4.7#Release_blocking_bugs
 
 
+CHANGES SINCE 4.7.0rc2
+==
+
+o  Jeremy Allison 
+   * BUG 12836: s3: smbd: Fix a read after free if a chained SMB1 call goes
+ async.
+   * BUG 12899: s3: libsmb: Reverse sense of 'clear all attributes', ignore
+ attribute change in SMB2 to match SMB1.
+   * BUG 12914: s3: smbclient: Add new command deltree.
+
+o  Ralph Boehme 
+   * BUG 12885: s3/smbd: Let non_widelink_open() chdir() to directories
+ directly.
+   * BUG 12887: Remove SMB_VFS_STRICT_UNLOCK noop from the VFS.
+   * BUG 12891: Enable TDB mutexes in dbwrap and ctdb.
+   * BUG 12897: vfs_fruit: don't use MS NFS ACEs with Windows clients.
+   * BUG 12910: s3/notifyd: Ensure notifyd doesn't return from
+ smbd_notifyd_init.
+
+o  Alexander Bokovoy 
+   * BUG 12905: Build py3 versions of other rpc modules.
+
+o  Günther Deschner 
+   * BUG 12840: vfs_fruit: Add "fruit:model = " parametric option.
+
+o  Dustin L. Howett
+   * BUG 12720: idmap_ad: Retry query_user exactly once if we get
+ TLDAP_SERVER_DOWN.
+
+o  Amitay Isaacs 
+   * BUG 12891: dbwrap_ctdb: Fix calculation of persistent flag.
+
+o  Thomas Jarosch 
+   * BUG 12927: s3: libsmb: Fix use-after-free when accessing pointer *p.
+
+o  Volker Lendecke 
+   * BUG 12925: smbd: Fix a connection run-down race condition.
+
+o  Stefan Metzmacher 
+   * tevent: version 0.9.33: make tevent_req_print() more robust against 
crashes.
+   * ldb: version 1.2.1
+   * BUG 12882: Do not install _ldb_text.py if we have system libldb.
+   * BUG 12890: s3:smbd: consistently use talloc_tos() memory for
+ rpc_pipe_open_interface().
+   * BUG 12900: Fix index out of bound in ldb_msg_find_common_values.
+
+o  Rowland Penny 
+   * BUG 12884: Easily edit a users object in AD, as if using 'ldbedit'.
+
+o  Bernhard M. Wiedemann 
+   * BUG 12906: s3: drop build_env
+
+o  Andreas Schneider 
+   * BUG 12882: waf: Do not install _ldb_text.py if we have system libldb.
+
+o  Martin Schwenke 
+   * BUG 12898: ctdb-common: Set close-on-exec when creating PID file.
+
+
 CHANGES SINCE 4.7.0rc1
 ==
 


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - annotated tag samba-4.7.0rc3 created

2017-07-25 Thread Karolin Seeger
The annotated tag, samba-4.7.0rc3 has been created
at  f75bb2d21b561eefcfc589c0cc894ac81f39b0ad (tag)
   tagging  ce4fa8f669a1667e6b9f7953a7807af312c24d2d (commit)
  replaces  samba-4.7.0rc2
 tagged by  Karolin Seeger
on  Tue Jul 25 11:10:54 2017 +0200

- Log -
samba: tag release samba-4.7.0rc3
-BEGIN PGP SIGNATURE-

iEYEABECAAYFAll3Cx8ACgkQbzORW2Vot+p0EwCgkdBCzgmB0fq2D/GWGfuHg5T0
/KgAnAsVoOZ0x5IHI+Ty01j4JUcAsDbQ
=niGc
-END PGP SIGNATURE-

Alexander Bokovoy (2):
  py3: Make sure to specify METH_VARARGS together with METH_KEYWORDS
  Build py3 versions of other rpc modules

Amitay Isaacs (2):
  dbwrap: CTDB ignores tdb_flags passed to db attach controls
  dbwrap_ctdb: Fix calculation of persistent flag

Andreas Schneider (7):
  waf: Do not install _ldb_text.py if we have system libldb
  unittests: Do not install the test_dummy rpc module
  waf: Only build unit tests with selftest enabled
  unittests: Add missing stdint.h include
  s3:tests: Fix directory creation and deletion of test_local_symlinks()
  s3:tests: Fix directory creation and deletion of test_nosymlinks()
  s3:client: The smbspool krb5 wrapper needs negotiate for authentication

Bernhard M. Wiedemann (1):
  s3: drop build_env

Douglas Bagnall (2):
  ldb: avoid searching empty lists in ldb_msg_find_common_values
  ldb/tests: more thoroughly test empty ldb_msg elements

Dustin L. Howett via samba-technical (1):
  idmap_ad: Retry query_user exactly once if we get TLDAP_SERVER_DOWN

Günther Deschner (1):
  vfs_fruit: add fruit:model =  parametric option

Jeremy Allison (7):
  s3: client: Move struct file_list code to using talloc from malloc.
  s3: smbclient: Add new command deltree.
  docs: Document new smbclient deltree command.
  s3: tests: Add test for new smbclient "deltree" command.
  s3: libsmb: Reverse sense of 'clear all attributes', ignore attribute 
change in SMB2 to match SMB1.
  s3: smbclient: Add a test for the setmode command.
  s3: smbd: Fix a read after free if a chained SMB1 call goes async.

Karolin Seeger (2):
  WHATSNEW: Add release notes for Samba 4.7.0rc3.
  VERSION: Disable GIT_SNAPSHOTS for the 4.7.0rc3 release.

Lukas Slebodnik (2):
  ldb: Use libraries from build dir for testsuite
  ldb: Fix index out of bound in ldb_msg_find_common_values

Martin Schwenke (2):
  WHATSNEW: CTDB changes for 4.7
  ctdb-common: Set close-on-exec when creating PID file

Ralph Boehme (11):
  s3/smbd: let non_widelink_open() chdir() to directories directly
  selftest: add a test for accessing previous version of directories with 
snapdirseverywhere
  s3/vfs: remove SMB_VFS_STRICT_UNLOCK
  s3/vfs: rename SMB_VFS_STRICT_LOCK to SMB_VFS_STRICT_LOCK_CHECK
  ctdb: enable mutexes for volatile TDBs by default
  dbwrap: enable mutexes by default for volatile TDBs
  ctdbd_conn: move CTDB_CONTROL_ENABLE_SEQNUM control to db_open_ctdb
  ctdbd_conn: pass persistent bool instead of tdb_flags
  dbwrap: Ask CTDB for local tdb open flags
  vfs_fruit: don't use MS NFS ACEs with Windows clients
  s3/notifyd: ensure notifyd doesn't return from smbd_notifyd_init

Rowland Penny (3):
  Easily edit a users object in AD, as if using ldbedit.
  Add test for 'samba-tool user edit'
  Add code to run the tests for 'samba-tool user edit'

Stefan Metzmacher (8):
  VERSION: Bump version up to 4.6.0rc3...
  s3:smbd: consistently use talloc_tos() memory for 
rpc_pipe_open_interface()
  WHATSNEW: move the CTDB changes section before the Parameter changes
  WHATSNEW: add a note about the new 'smbclient deltree' command.
  ldb: version 1.2.1
  tevent: avoid calling talloc_get_name(NULL) in tevent_req_default_print()
  tevent: handle passing req = NULL to tevent_req_print()
  tevent: version 0.9.33

Thomas Jarosch (1):
  s3: libsmb: Fix use-after-free when accessing pointer *p.

Volker Lendecke (1):
  smbd: Fix a connection run-down race condition

---


-- 
Samba Shared Repository



[SCM] Samba Website Repository - branch master updated

2017-07-25 Thread Karolin Seeger
The branch, master has been updated
   via  e07d8ff NEWS[4.7.0rc3]: Samba 4.7.0rc3 Available for Download
  from  7fb1854 more download site fixes

https://git.samba.org/?p=samba-web.git;a=shortlog;h=master


- Log -
commit e07d8ffe30fab1b3920a5cd3bb22925324bd0997
Author: Karolin Seeger 
Date:   Tue Jul 25 11:11:09 2017 +0200

NEWS[4.7.0rc3]: Samba 4.7.0rc3 Available for Download

Signed-off-by: Karolin Seeger 

---

Summary of changes:
 posted_news/20170725-091204.4.7.0rc3.body.html | 12 
 posted_news/20170725-091204.4.7.0rc3.headline.html |  3 +++
 2 files changed, 15 insertions(+)
 create mode 100644 posted_news/20170725-091204.4.7.0rc3.body.html
 create mode 100644 posted_news/20170725-091204.4.7.0rc3.headline.html


Changeset truncated at 500 lines:

diff --git a/posted_news/20170725-091204.4.7.0rc3.body.html 
b/posted_news/20170725-091204.4.7.0rc3.body.html
new file mode 100644
index 000..8e024d0
--- /dev/null
+++ b/posted_news/20170725-091204.4.7.0rc3.body.html
@@ -0,0 +1,12 @@
+
+25 July 2017
+Samba 4.7.0rc3 Available for Download
+
+This is the third release candidate of the upcoming Samba 4.7 release series.
+
+
+The uncompressed tarball has been signed using GnuPG (ID 6F33915B6568B7EA).
+The source code can be https://download.samba.org/pub/samba/rc/samba-4.7.0rc3.tar.gz";>downloaded 
now.
+See https://download.samba.org/pub/samba/rc/samba-4.7.0rc3.WHATSNEW.txt";>the 
release notes for more info.
+
+
diff --git a/posted_news/20170725-091204.4.7.0rc3.headline.html 
b/posted_news/20170725-091204.4.7.0rc3.headline.html
new file mode 100644
index 000..861e907
--- /dev/null
+++ b/posted_news/20170725-091204.4.7.0rc3.headline.html
@@ -0,0 +1,3 @@
+
+ 25 July 2017 Samba 4.7.0rc3 Available for 
Download
+


-- 
Samba Website Repository



[SCM] Samba Shared Repository - branch v4-7-stable updated

2017-07-25 Thread Karolin Seeger
The branch, v4-7-stable has been updated
   via  ce4fa8f VERSION: Disable GIT_SNAPSHOTS for the 4.7.0rc3 release.
   via  fabbc51 WHATSNEW: Add release notes for Samba 4.7.0rc3.
   via  54088c0 s3: drop build_env
   via  1335e7a s3: smbd: Fix a read after free if a chained SMB1 call goes 
async.
   via  8d7bf8c s3: libsmb: Fix use-after-free when accessing pointer *p.
   via  60949fc smbd: Fix a connection run-down race condition
   via  0b24182 s3/notifyd: ensure notifyd doesn't return from 
smbd_notifyd_init
   via  7933732 Build py3 versions of other rpc modules
   via  18d0708 py3: Make sure to specify METH_VARARGS together with 
METH_KEYWORDS
   via  2a16228 s3: smbclient: Add a test for the setmode command.
   via  d426120 s3: libsmb: Reverse sense of 'clear all attributes', ignore 
attribute change in SMB2 to match SMB1.
   via  b51aa15 ctdb-common: Set close-on-exec when creating PID file
   via  0f40c21 vfs_fruit: don't use MS NFS ACEs with Windows clients
   via  961266e dbwrap_ctdb: Fix calculation of persistent flag
   via  7439394 dbwrap: Ask CTDB for local tdb open flags
   via  a577510 ctdbd_conn: pass persistent bool instead of tdb_flags
   via  d12832f ctdbd_conn: move CTDB_CONTROL_ENABLE_SEQNUM control to 
db_open_ctdb
   via  fcb08f7 dbwrap: CTDB ignores tdb_flags passed to db attach controls
   via  5afede8 dbwrap: enable mutexes by default for volatile TDBs
   via  28f8439 ctdb: enable mutexes for volatile TDBs by default
   via  683b107 s3/vfs: rename SMB_VFS_STRICT_LOCK to 
SMB_VFS_STRICT_LOCK_CHECK
   via  e44257a s3/vfs: remove SMB_VFS_STRICT_UNLOCK
   via  8559b2e s3:client: The smbspool krb5 wrapper needs negotiate for 
authentication
   via  f6b1a53 vfs_fruit: add fruit:model =  parametric option
   via  3cb73b1 idmap_ad: Retry query_user exactly once if we get 
TLDAP_SERVER_DOWN
   via  892c3aa tevent: version 0.9.33
   via  ce417f5 tevent: handle passing req = NULL to tevent_req_print()
   via  3d87c06 tevent: avoid calling talloc_get_name(NULL) in 
tevent_req_default_print()
   via  50845aa ldb: version 1.2.1
   via  bed75c1 ldb/tests: more thoroughly test empty ldb_msg elements
   via  7eda7c5 ldb: avoid searching empty lists in 
ldb_msg_find_common_values
   via  1f9e8f5 ldb: Fix index out of bound in ldb_msg_find_common_values
   via  9998480 ldb: Use libraries from build dir for testsuite
   via  895bd0d WHATSNEW: add a note about the new 'smbclient deltree' 
command.
   via  9940042 s3:tests: Fix directory creation and deletion of 
test_nosymlinks()
   via  293fa76 s3:tests: Fix directory creation and deletion of 
test_local_symlinks()
   via  3b2d806 s3: tests: Add test for new smbclient "deltree" command.
   via  265070f docs: Document new smbclient deltree command.
   via  d5471ab s3: smbclient: Add new command deltree.
   via  413436b s3: client: Move struct file_list code to using talloc from 
malloc.
   via  28396c1 WHATSNEW: move the CTDB changes section before the 
Parameter changes
   via  7cf9a52 unittests: Add missing stdint.h include
   via  a235bb4 WHATSNEW: CTDB changes for 4.7
   via  dc35068 Add code to run the tests for 'samba-tool user edit'
   via  a1874cd Add test for 'samba-tool user edit'
   via  ec0545f Easily edit a users object in AD, as if using ldbedit.
   via  21f9477 waf: Only build unit tests with selftest enabled
   via  fdd1dc7 s3:smbd: consistently use talloc_tos() memory for 
rpc_pipe_open_interface()
   via  c6d2d56 selftest: add a test for accessing previous version of 
directories with snapdirseverywhere
   via  b1916bf s3/smbd: let non_widelink_open() chdir() to directories 
directly
   via  08f8402 unittests: Do not install the test_dummy rpc module
   via  e1b217c waf: Do not install _ldb_text.py if we have system libldb
   via  3d9dddb VERSION: Bump version up to 4.6.0rc3...
  from  27d4dfb VERSION: Disable GIT_SNAPSHOTS for the 4.7.0rc2 release

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-7-stable


- Log -
---

Summary of changes:
 VERSION|   2 +-
 WHATSNEW.txt   | 110 -
 buildtools/wafsamba/samba_patterns.py  |  14 --
 ctdb/common/pidfile.c  |   8 +
 ctdb/common/tunable.c  |   2 +-
 ctdb/config/ctdbd.conf |   2 +-
 ctdb/doc/ctdb-tunables.7.xml   |   2 +-
 ctdb/doc/ctdb.1.xml|   2 +-
 ctdb/tests/tool/ctdb.listvars.001.sh   |   2 +-
 docs-xml/manpages/smbclient.1.xml  |  10 +
 docs-xml/manpages/vfs_fruit.8.xml 

[SCM] Samba Shared Repository - branch master updated

2017-07-25 Thread Andreas Schneider
The branch, master has been updated
   via  4830902 s3:tests: Add tests for smbspool_krb5_wrapper
   via  dc15954 s3:client: Use KRB5CCNAME in smbspool_krb5_wrapper if set
   via  5c178eb s3:tests: Add test for smbspool
   via  d6518d7 s3:client: Only use kerberos if credential cache exists in 
smbspool
   via  7a73a13 s3:client: Make it possible use smbspool in selftest
   via  a553f12 s3:client: Fix the usage of argv in smbspool
   via  924e7f7 s3:printing: Fix setting the first jobnum
   via  a19b08c s3:printing: Do not segfault in vlp if no command has been 
specified
   via  a841745 uwrap: Update to version 1.2.4
  from  a420b1b selftest: Use NETLOGON_NEG_STRONG_KEYS constant in 
AuthLogTestsNetLogonBadCreds

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 483090200737d34d656b16f9aa2523a3cba7bb17
Author: Andreas Schneider 
Date:   Tue Jul 11 10:59:59 2017 +0200

s3:tests: Add tests for smbspool_krb5_wrapper

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Jul 25 13:17:13 CEST 2017 on sn-devel-144

commit dc15954196e237d10c0fe3e9dd30316e1704ce25
Author: Andreas Schneider 
Date:   Wed Jul 12 16:07:25 2017 +0200

s3:client: Use KRB5CCNAME in smbspool_krb5_wrapper if set

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 

commit 5c178ebc965ed5884082a962ffc86371a448dfa5
Author: Andreas Schneider 
Date:   Tue Jul 11 10:58:11 2017 +0200

s3:tests: Add test for smbspool

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Ralph Boehme 

commit d6518d74dda517c84f7a4a2fe3ad37857fb9d7b0
Author: Andreas Schneider 
Date:   Tue Jul 11 09:41:08 2017 +0200

s3:client: Only use kerberos if credential cache exists in smbspool

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 

commit 7a73a130d55d3369f2d465f8268fca65de29fd37
Author: Andreas Schneider 
Date:   Mon Jul 24 12:27:50 2017 +0200

s3:client: Make it possible use smbspool in selftest

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

commit a553f12418a16c58b278745e3da6329ce24fe3c7
Author: Andreas Schneider 
Date:   Tue Jul 11 10:40:39 2017 +0200

s3:client: Fix the usage of argv in smbspool

We use argv[0] to print the name of the binary, but have shifted it
away. Do not do that.

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 

commit 924e7f7c80b203e147823f802926c323d9402248
Author: Andreas Schneider 
Date:   Wed Jul 12 13:14:08 2017 +0200

s3:printing: Fix setting the first jobnum

This is just something logical. The define is called first jobnum but
the first one was always 101.

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 

commit a19b08c9c315279bc0afec09a0a409de168084b4
Author: Andreas Schneider 
Date:   Wed Jul 12 13:07:08 2017 +0200

s3:printing: Do not segfault in vlp if no command has been specified

We should just print the usage() and return

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 

commit a841745166a54657e72247d2a20a04459e087084
Author: Andreas Schneider 
Date:   Thu Jul 13 08:57:13 2017 +0200

uwrap: Update to version 1.2.4

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 

---

Summary of changes:
 lib/uid_wrapper/uid_wrapper.c  |  303 +-
 lib/uid_wrapper/wscript|2 +-
 source3/client/smbspool.c  |  101 +-
 source3/client/smbspool_krb5_wrapper.c |8 +
 source3/printing/tests/vlp.c   |   11 +-
 source3/script/tests/test_smbspool.sh  |  153 +
 source3/selftest/tests.py  |3 +
 testdata/printing/example.ps   | 8374 
 8 files changed, 8886 insertions(+), 69 deletions(-)
 create mode 100755 source3/script/tests/test_smbspool.sh
 create mode 100644 testdata/printing/example.ps


Changeset truncated at 500 lines:

diff --git a/lib/uid_wrapper/uid_wrapper.c b/lib/uid_wrapper/uid_wrapper.c
index 743d590..0d74d20 100644
--- a/lib/uid_wrapper/uid_wrapper.c
+++ b/lib/uid_wrapper/uid_wrapper.c
@@ -133,9 +133,6 @@ enum uwrap_dbglvl_e {
UWRAP_LOG_TRACE
 };
 
-#ifdef NDEBUG
-# define UWRAP_LOG(...)
-#else /* NDEBUG */
 static void uwrap_log(enum uwrap_dbglvl_e dbglvl, const char *function, const 
char *format, ...) PRINTF_ATTRIBUTE(3, 4);
 # define UWRAP_LOG(dbglvl, ...) uwrap_log((dbglvl), __func__, __VA_ARGS__)
 
@@ -145,42 +142,43 @@ static void uwrap_log(enum uwrap_dbglvl_e dbglvl, const 
char *function, const ch
va_list va;
const char *d;
unsigned int lvl = 0;
+   const char *prefix = "UWRAP";
 
 

[SCM] Samba Shared Repository - branch v4-5-test updated

2017-07-25 Thread Karolin Seeger
The branch, v4-5-test has been updated
   via  3475d11 vfs_ceph: fix cephwrap_chdir()
  from  cfa8c18 s3: smbd: Fix a read after free if a chained SMB1 call goes 
async.

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-5-test


- Log -
commit 3475d11fe95b4b1afc8ba2731f2853503f44c02b
Author: David Disseldorp 
Date:   Fri Jul 14 23:55:29 2017 +0200

vfs_ceph: fix cephwrap_chdir()

When provided a '/' path (i.e. CephFS root), vfs_ceph does a *local*
chdir() to the share path. This breaks smb client directory listings.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=12911

Signed-off-by: David Disseldorp 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Fri Jul 21 19:10:46 CEST 2017 on sn-devel-144

(cherry picked from commit 1dcacff083019810e207a3d123a81fe32d9dde1a)

Autobuild-User(v4-5-test): Karolin Seeger 
Autobuild-Date(v4-5-test): Tue Jul 25 15:53:04 CEST 2017 on sn-devel-144

---

Summary of changes:
 source3/modules/vfs_ceph.c | 7 ---
 1 file changed, 7 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_ceph.c b/source3/modules/vfs_ceph.c
index 59e9b9c..9c7a2fb 100644
--- a/source3/modules/vfs_ceph.c
+++ b/source3/modules/vfs_ceph.c
@@ -750,13 +750,6 @@ static int cephwrap_chdir(struct vfs_handle_struct 
*handle,  const char *path)
 {
int result = -1;
DEBUG(10, ("[CEPH] chdir(%p, %s)\n", handle, path));
-   /*
-* If the path is just / use chdir because Ceph is below / and
-* cannot deal with changing directory above its mount point
-*/
-   if (path && !strcmp(path, "/"))
-   return chdir(path);
-
result = ceph_chdir(handle->data, path);
DEBUG(10, ("[CEPH] chdir(...) = %d\n", result));
WRAP_RETURN(result);


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - branch master updated

2017-07-25 Thread Andreas Schneider
The branch, master has been updated
   via  ee9f437 auth/gensec: finally remove unused gensec_update_ev()
   via  39353c9 auth/gensec: don't allow gensec_update[_ev] to be called on 
a subcontext
   via  a7f4012 auth/gensec: make use of gensec_update_send/recv in 
gensec_update_ev()
   via  8268374 s4:lib/http: rewrite http_send_auth_request_*() using 
gensec_update_send/recv
   via  eb6b2b6 auth/gensec: introduce gensec_security_ops.glue in order to 
avoid depending on GENSEC_OID_SPNEGO being special
   via  692425f auth/gensec: add some useful debugging to 
gensec_update_send/gensec_update_done
   via  97788f4 auth/spnego: Use talloc_get_type_abort() in 
gsensec_spnego_update_out()
   via  62ffe20 auth/spnego: Use talloc_get_type_abort() in 
gsensec_spnego_update_in()
   via  e492950 auth/spnego: Rename gensec_spnego_update_sub_abort()
   via  832e9ff auth/spnego: replace gensec_spnego_neg_loop() by real async 
processing of {start,step,finish}_fn()
   via  75e6728 auth/spnego: split gensec_spnego_server_negTokenTarg() into 
subfunctions
   via  2d1fcde auth/spnego: split gensec_spnego_server_negTokenInit() into 
subfunctions
   via  7ff159e auth/spnego: split gensec_spnego_client_negTokenTarg() into 
subfunctions
   via  e337d4f auth/spnego: split gensec_spnego_client_negTokenInit() into 
subfunctions
   via  e9eb0f3 auth/spnego: split gensec_spnego_create_negTokenInit() into 
subfunctions
   via  c56103e auth/spnego: don't produce an output token for errors in 
gensec_spnego_server_response()
   via  eedb810 auth/spnego: don't call gensec_spnego_server_response() 
with a fatal error
   via  3e6daa3 auth/spnego: generate a valid packet if 
gensec_spnego_client_negTokenTarg() gives MORE_PROCESSING_REQUIRED
   via  a97057d auth/spnego: make sure we don't return OK without 
sub_sec_ready in gensec_spnego_client_negTokenTarg()
   via  f7f9de4 auth/spnego: do an early return for the success case in 
gensec_spnego_client_negTokenTarg()
   via  9b4d44a auth/spnego: use better variable names in 
gensec_spnego_create_negTokenInit()
   via  d9e764e auth/spnego: introduce an early return in 
gensec_spnego_create_negTokenInit()
   via  6a3c50f auth/spnego: add more error checking to 
gensec_spnego_create_negTokenInit()
   via  1ff5381 auth/spnego: rename 'nt_status' to 'status' in 
gensec_spnego_create_negTokenInit()
   via  1010034 auth/spnego: make the debug messages in 
gensec_spnego_create_negTokenInit() more useful
   via  71ca6fc auth/spnego: remove one more useless indentation level in 
gensec_spnego_create_negTokenInit()
   via  3042107 auth/spnego: introduce an early goto reply: for the server 
in gensec_spnego_create_negTokenInit()
   via  248be3b auth/spnego: move the output generation to the end of 
gensec_spnego_create_negTokenInit()
   via  81df16a auth/spnego: make the SPNEGO_FALLBACK continuation 
completely async
   via  9502f53 auth/spnego: invert the fallback logic in 
gensec_spnego_client_negTokenInit()
   via  3bf4946 auth/spnego: split out gensec_spnego_update_pre/post() 
functions
   via  cb8f370 auth/spnego: inline gensec_spnego_parse_negTokenInit() into 
gensec_spnego_server_negTokenInit()
   via  efacdf9 auth/spnego: remove more dead code from 
gensec_spnego_parse_negTokenInit()
   via  ba9c51d auth/spnego: add an early return for OK or MORE PROCESSING 
in gensec_spnego_parse_negTokenInit()
   via  32836a7 auth/spnego: add an early return for a hard error in 
gensec_spnego_parse_negTokenInit()
   via  1523a77 auth/spnego: do an early return when we downgraded the mech 
in gensec_spnego_parse_negTokenInit()
   via  2a846ba auth/spnego: remove one more useless indentation level from 
gensec_spnego_parse_negTokenInit()
   via  f204402 auth/spnego: remove dead code from 
gensec_spnego_parse_negTokenInit()
   via  1c2ed3d auth/spnego: remove unused indentation level from 
gensec_spnego_parse_negTokenInit()
   via  8ddfafd auth/spnego: inline gensec_spnego_parse_negTokenInit() 
client logic into gensec_spnego_client_negTokenInit()
   via  482fe65 auth/spnego: let gensec_spnego_parse_negTokenInit() require 
client provides mechs
   via  7c04ee94 auth/spnego: inline gensec_spnego_update_server() into 
gensec_spnego_update_send()
   via  fe4521d auth/spnego: inline gensec_spnego_update_client() into 
gensec_spnego_update_send()
   via  f85f9da auth/spnego: split out a 
gensec_spnego_server_negTokenTarg() function
   via  e60222d auth/spnego: introduce a 'struct spnego_negTokenTarg *ta' 
helper variable in gensec_spnego_update_server()
   via  909d190 auth/spnego: split out a 
gensec_spnego_client_negTokenTarg() function
   via  7128dd8 auth/spnego: make more use of the 'ta' helper variable in 
gensec_spnego_update_client()
   via  2054008 auth/spnego: split out a 
gensec_spnego_server_negTokenInit() function.

[SCM] Samba Shared Repository - branch v4-6-test updated

2017-07-25 Thread Karolin Seeger
The branch, v4-6-test has been updated
   via  fd96410 vfs_ceph: fix cephwrap_chdir()
  from  a81b8f2 s3: smbd: Fix a read after free if a chained SMB1 call goes 
async.

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-6-test


- Log -
commit fd96410de65a588bc8db5917ea8b865718c40f6c
Author: David Disseldorp 
Date:   Fri Jul 14 23:55:29 2017 +0200

vfs_ceph: fix cephwrap_chdir()

When provided a '/' path (i.e. CephFS root), vfs_ceph does a *local*
chdir() to the share path. This breaks smb client directory listings.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=12911

Signed-off-by: David Disseldorp 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Fri Jul 21 19:10:46 CEST 2017 on sn-devel-144

(cherry picked from commit 1dcacff083019810e207a3d123a81fe32d9dde1a)

Autobuild-User(v4-6-test): Karolin Seeger 
Autobuild-Date(v4-6-test): Tue Jul 25 19:51:08 CEST 2017 on sn-devel-144

---

Summary of changes:
 source3/modules/vfs_ceph.c | 7 ---
 1 file changed, 7 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_ceph.c b/source3/modules/vfs_ceph.c
index 75233ef..e3d22bf 100644
--- a/source3/modules/vfs_ceph.c
+++ b/source3/modules/vfs_ceph.c
@@ -916,13 +916,6 @@ static int cephwrap_chdir(struct vfs_handle_struct 
*handle,  const char *path)
 {
int result = -1;
DBG_DEBUG("[CEPH] chdir(%p, %s)\n", handle, path);
-   /*
-* If the path is just / use chdir because Ceph is below / and
-* cannot deal with changing directory above its mount point
-*/
-   if (path && !strcmp(path, "/"))
-   return chdir(path);
-
result = ceph_chdir(handle->data, path);
DBG_DEBUG("[CEPH] chdir(...) = %d\n", result);
WRAP_RETURN(result);


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - branch master updated

2017-07-25 Thread Ralph Böhme
The branch, master has been updated
   via  e684658 messaging: Remove "struct messaging_backend"
   via  7d24412 messaging: Remove messages_ctdbd.c
   via  af63c0b ctdb_conn: Use messaging_ctdb_connection
   via  d1add22 messaging: Use messaging_ctdb_ref()
   via  67432fb messages_ctdb: Add messaging_ctdb_connection
   via  0c70bcd smbpasswd: Initialize messaging for messaging_ctdb_conn
   via  1cc970b dbwrap_ctdb: Use messaging_ctdbd_connection
   via  e26fa99 messaging: Add messages_ctdb_ref
   via  5afdce0 messaging: Add messaging_ctdb_init/destroy
   via  9cb1379 dbwrap: Avoid dbwrap_merge_dbufs in db_ctdb_storev
   via  fdad620 messages_ctdb: Handle async msgs for nested event contexts
   via  bd1e26f messaging: Add messaging_ctdbd_register_tevent_context
   via  dc390cf ctdbd_conn: Pass "ev" through ctdbd_socket_readable
   via  3ee2e53 ctdbd_conn: Pass "ev" through ctdb_handle_message
   via  db84e7a ctdbd_conn: Pass "ev" through ctdbd_msg_call_back
   via  2676455 ctdbd_conn: Pass "ev" through ctdb connection callbacks
   via  35b4750 messaging: Broadcast messages to all event contexts
   via  33df9c5 messaging: Keep an array of event contexts registered
   via  b561028 messaging: Add DLIST pointers to messaging_rec
   via  17a472b messaging: Factor out messaging_dispatch_waiters
   via  667307c g_lock: remove unused functions g_lock_get() and 
g_lock_get_talloc()
   via  21df140 g_lock: Use parse_record in g_lock_dump
   via  145b9cb g_lock: remove unused functions g_lock_put() and 
g_lock_record_store()
   via  241f31d g_lock: Use dbwrap_do_locked in g_lock_write_data
   via  f540bba torture3: Add verification for g_lock_retry
   via  fc89187 g_lock: Use dbwrap_do_locked in g_lock_lock_retry
   via  946e334 g_lock: Use dbwrap_do_locked for g_lock_lock
   via  8d1e950 g_lock: Avoid talloc in g_lock_trylock
   via  a626f82 g_lock: Initialize variables
   via  e2aa568 g_lock: Implement g_lock_unlock without talloc
   via  8f2a5f1 g_lock: add "struct g_lock" without talloc
   via  2b6015f g_lock: simplify g_lock_trylock
   via  b03ca94 g_lock: Walk locks only once in g_lock_trylock
   via  ecb4283 dbwrap_watch: Implement do_locked
   via  faa5361 dbwrap_watch: Introduce dbwrap_watch_rec
   via  e3a0f0c dbwrap_tdb: Implement do_locked
   via  86dbad3 torture3: Test dbwrap_do_locked
   via  cb2a28e dbwrap: Add dbwrap_do_locked
   via  45f5a55 dbwrap: Factor out the core dbwrap lock order logic
   via  10c59f5 dbwrap: Add dbwrap_record_storev
   via  09915bf dbwrap: Convert backend store to storev
   via  f0598e9 dbwrap: Add dbwrap_merge_dbufs
   via  cfb6568 torture: Add local-g-lock-ping-pong
   via  bfa0732 s3: torture: Add a test for cli_setpathinfo_basic() to 
smbtorture3.
   via  b1e5b89 s3: libsmb: Implement cli_smb2_setatr() by calling 
cli_smb2_setpathinfo().
   via  2a15c70 s3: libsmb: Add cli_smb2_setpathinfo(), to be called by 
cli_setpathinfo_basic().
   via  812006f s3: libsmbclient: Fix cli_setpathinfo_basic() to treat mode 
== -1 as no change.
  from  ee9f437 auth/gensec: finally remove unused gensec_update_ev()

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit e6846584d744974ca1256e52507ba09cc3ffa0ad
Author: Volker Lendecke 
Date:   Wed Jul 5 19:26:22 2017 +0200

messaging: Remove "struct messaging_backend"

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Tue Jul 25 21:35:49 CEST 2017 on sn-devel-144

commit 7d244129cc4db07d9a75ac76bb8572a881a642d2
Author: Volker Lendecke 
Date:   Wed Jul 5 19:24:32 2017 +0200

messaging: Remove messages_ctdbd.c

Replaced by messages_ctdb.[ch]

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

commit af63c0b32dbb726f03cb3b60be663257a6ad5031
Author: Volker Lendecke 
Date:   Fri Jun 16 13:00:59 2017 +0200

ctdb_conn: Use messaging_ctdb_connection

Replace messaging_ctdbd_connection

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

commit d1add225672dfc6b4970a07ca7b1068338f315bb
Author: Volker Lendecke 
Date:   Wed Jul 5 19:20:09 2017 +0200

messaging: Use messaging_ctdb_ref()

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

commit 67432fb9b9220e3826105b5b1b48391696e3ad99
Author: Volker Lendecke 
Date:   Wed Jul 5 19:13:23 2017 +0200

messages_ctdb: Add messaging_ctdb_connection

This will be the replacement for messaging_ctdbd_connection(). This does not
default to initializing messaging but panics. We just don't have correct
default arguments for messaging_init. Implicit multiple messaging and event
contexts is a bug also.

It *might* be that some tools f

autobuild[sn-devel-144]: intermittent test failure detected

2017-07-25 Thread autobuild
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2017-07-26-0012/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-07-26-0012/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-07-26-0012/samba.stdout
  
The top commit at the time of the failure was:

commit e6846584d744974ca1256e52507ba09cc3ffa0ad
Author: Volker Lendecke 
Date:   Wed Jul 5 19:26:22 2017 +0200

messaging: Remove "struct messaging_backend"

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Tue Jul 25 21:35:49 CEST 2017 on sn-devel-144



[SCM] Samba Shared Repository - branch master updated

2017-07-25 Thread Jeremy Allison
The branch, master has been updated
   via  5005a3a libsmb: Enable "cli_notify" for SMB2+
   via  1801134 libsmb: Add cli_smb2_notify
   via  ad33964 libsmb: Add smb2cli_notify()
  from  e684658 messaging: Remove "struct messaging_backend"

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 5005a3a6961d40fe349f76db67c980be7dc9f3ea
Author: Volker Lendecke 
Date:   Tue Jul 25 12:30:47 2017 +0200

libsmb: Enable "cli_notify" for SMB2+

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Jul 26 01:33:25 CEST 2017 on sn-devel-144

commit 18011343d80a28fb46894d712b22c84dce067342
Author: Volker Lendecke 
Date:   Tue Jul 25 12:12:02 2017 +0200

libsmb: Add cli_smb2_notify

We have to do the parsing manually. Looking at librpc/gen_ndr/ndr_notify.c 
we
have the following code snippet:

  size_FileName1_0 = strlen_m(r->FileName1);
  NDR_CHECK(ndr_pull_charset(ndr, NDR_SCALARS, &r->FileName1,
 size_FileName1_0, sizeof(uint16_t),
 CH_UTF16));

which means that we take strlen_m(r->FileName1) before we pull
it off the wire. Not sure how to fix this, but that is clearly
broken pidl output. Once that is fixed, we can convert this
to ndr_pull_struct.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit ad33964f8c85b67a2d2b451bece208d8bfb8cad6
Author: Volker Lendecke 
Date:   Tue Jul 25 12:11:37 2017 +0200

libsmb: Add smb2cli_notify()

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

---

Summary of changes:
 ...{smb2cli_query_directory.c => smb2cli_notify.c} | 140 -
 libcli/smb/smbXcli_base.h  |  26 
 libcli/smb/wscript |   1 +
 source3/libsmb/cli_smb2_fnum.c |  92 ++
 source3/libsmb/cli_smb2_fnum.h |   5 +
 source3/libsmb/clifile.c   |  10 +-
 6 files changed, 187 insertions(+), 87 deletions(-)
 copy libcli/smb/{smb2cli_query_directory.c => smb2cli_notify.c} (51%)


Changeset truncated at 500 lines:

diff --git a/libcli/smb/smb2cli_query_directory.c b/libcli/smb/smb2cli_notify.c
similarity index 51%
copy from libcli/smb/smb2cli_query_directory.c
copy to libcli/smb/smb2cli_notify.c
index e6321ff..0a23cf9 100644
--- a/libcli/smb/smb2cli_query_directory.c
+++ b/libcli/smb/smb2cli_notify.c
@@ -1,7 +1,7 @@
 /*
Unix SMB/CIFS implementation.
smb2 lib
-   Copyright (C) Volker Lendecke 2011
+   Copyright (C) Volker Lendecke 2017
 
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -22,94 +22,69 @@
 #include "lib/util/tevent_ntstatus.h"
 #include "smb_common.h"
 #include "smbXcli_base.h"
+#include "librpc/gen_ndr/ndr_notify.h"
 
-struct smb2cli_query_directory_state {
+struct smb2cli_notify_state {
uint8_t fixed[32];
-   uint8_t dyn_pad[1];
+
struct iovec *recv_iov;
uint8_t *data;
uint32_t data_length;
 };
 
-static void smb2cli_query_directory_done(struct tevent_req *subreq);
-
-struct tevent_req *smb2cli_query_directory_send(TALLOC_CTX *mem_ctx,
-   struct tevent_context *ev,
-   struct smbXcli_conn *conn,
-   uint32_t timeout_msec,
-   struct smbXcli_session *session,
-   struct smbXcli_tcon *tcon,
-   uint8_t level,
-   uint8_t flags,
-   uint32_t file_index,
-   uint64_t fid_persistent,
-   uint64_t fid_volatile,
-   const char *mask,
-   uint32_t outbuf_len)
+static void smb2cli_notify_done(struct tevent_req *subreq);
+
+struct tevent_req *smb2cli_notify_send(TALLOC_CTX *mem_ctx,
+  struct tevent_context *ev,
+  struct smbXcli_conn *conn,
+  uint32_t timeout_msec,
+  struct smbXcli_session *session,
+  struct smbXcli_tcon *tcon,
+  uint32_t output_buffer_length,
+  uint64_t fid_persistent,
+  uint

[SCM] Samba Shared Repository - branch master updated

2017-07-25 Thread Andreas Schneider
The branch, master has been updated
   via  8865ded s3-printing: precreate DriverStore directories.
   via  2621a2d s3-printing: add spoolss_get_short_filesys_environment 
function.
   via  a17cb9e s3-printing: pre-create color and PCC directories under 
print$.
  from  5005a3a libsmb: Enable "cli_notify" for SMB2+

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 8865dede5703a93c71fc2cb9417688f751ea2c69
Author: Günther Deschner 
Date:   Mon Sep 12 21:00:18 2016 +0200

s3-printing: precreate DriverStore directories.

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Wed Jul 26 05:34:15 CEST 2017 on sn-devel-144

commit 2621a2dae945591773e04aa78e97397ec4acaf95
Author: Günther Deschner 
Date:   Thu Sep 8 21:23:54 2016 +0200

s3-printing: add spoolss_get_short_filesys_environment function.

Note this is different from "get_short_archi" and reflects what windows uses
internally.

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andreas Schneider 

commit a17cb9ee09419f3ae8e0541aee83df55c4777bd0
Author: Günther Deschner 
Date:   Fri Sep 2 10:00:01 2016 +0200

s3-printing: pre-create color and PCC directories under print$.

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andreas Schneider 

---

Summary of changes:
 source3/printing/nt_printing.c| 49 +++
 source3/rpc_client/init_spoolss.c | 11 +
 source3/rpc_client/init_spoolss.h |  1 +
 3 files changed, 61 insertions(+)


Changeset truncated at 500 lines:

diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index 47590f6..0a0d3f7 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -80,6 +80,11 @@ static bool print_driver_directories_init(void)
char *driver_path;
bool ok;
TALLOC_CTX *mem_ctx = talloc_stackframe();
+   const char *dir_list[] = {
+   "W32X86/PCC",
+   "x64/PCC",
+   "color"
+   };
 
service = lp_servicenumber("print$");
if (service < 0) {
@@ -125,6 +130,50 @@ static bool print_driver_directories_init(void)
}
}
 
+   for (i = 0; i < ARRAY_SIZE(dir_list); i++) {
+   const char *path;
+
+   path = talloc_asprintf(mem_ctx,
+  "%s/%s",
+  driver_path,
+  dir_list[i]);
+   if (path == NULL) {
+   talloc_free(mem_ctx);
+   return false;
+   }
+
+   ok = directory_create_or_exist(path, 0755);
+   if (!ok) {
+   DEBUG(1, ("Failed to create printer driver "
+ "architecture directory %s\n",
+ path));
+   talloc_free(mem_ctx);
+   return false;
+   }
+   }
+
+   driver_path = state_path("DriverStore");
+   ok = directory_create_or_exist(driver_path, 0755);
+   if (!ok) {
+   DEBUG(1,("failed to create path %s\n", driver_path));
+   talloc_free(mem_ctx);
+   return false;
+   }
+   driver_path = state_path("DriverStore/FileRepository");
+   ok = directory_create_or_exist(driver_path, 0755);
+   if (!ok) {
+   DEBUG(1,("failed to create path %s\n", driver_path));
+   talloc_free(mem_ctx);
+   return false;
+   }
+   driver_path = state_path("DriverStore/Temp");
+   ok = directory_create_or_exist(driver_path, 0755);
+   if (!ok) {
+   DEBUG(1,("failed to create path %s\n", driver_path));
+   talloc_free(mem_ctx);
+   return false;
+   }
+
talloc_free(mem_ctx);
return true;
 }
diff --git a/source3/rpc_client/init_spoolss.c 
b/source3/rpc_client/init_spoolss.c
index e5f70c0..9a4dab6 100644
--- a/source3/rpc_client/init_spoolss.c
+++ b/source3/rpc_client/init_spoolss.c
@@ -435,3 +435,14 @@ WERROR spoolss_create_default_secdesc(TALLOC_CTX *mem_ctx,
 
return WERR_OK;
 }
+
+const char *spoolss_get_short_filesys_environment(const char *environment)
+{
+   if (strequal(environment, SPOOLSS_ARCHITECTURE_x64)) {
+   return "amd64";
+   } else if (strequal(environment, SPOOLSS_ARCHITECTURE_NT_X86)) {
+   return "x86";
+   } else {
+   return NULL;
+   }
+}
diff --git a/source3/rpc_client/init_spoolss.h 
b/source3/rpc_client/init_spoolss.h
index 28dbb1b..376eaef 100644
--- a/source3/rpc_client/init_spoolss.h
+