[SCM] pam wrapper repository - branch master updated

2018-02-12 Thread Andreas Schneider 
The branch, master has been updated
   via  5c36d42 cmake: Build python2 and python3 modules if possible
  from  9beb9f9 cmake: Improve PAM_WRAPPER_LOACATION

https://git.samba.org/?p=pam_wrapper.git;a=shortlog;h=master


- Log -
commit 5c36d4284918a3fcc1c58f29f01ca64c65a66fa7
Author: Andreas Schneider 
Date:   Mon Feb 12 12:01:22 2018 +0100

cmake: Build python2 and python3 modules if possible

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

---

Summary of changes:
 CMakeLists.txt|  5 -
 src/CMakeLists.txt|  4 +---
 src/python/CMakeLists.txt | 15 ++-
 src/python/python2/CMakeLists.txt | 33 +
 src/python/python3/CMakeLists.txt | 33 +
 tests/CMakeLists.txt  | 29 ++---
 tests/pypamtest_test.py   |  5 -
 7 files changed, 95 insertions(+), 29 deletions(-)
 create mode 100644 src/python/python2/CMakeLists.txt
 create mode 100644 src/python/python3/CMakeLists.txt


Changeset truncated at 500 lines:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f03a137..af00610 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -46,11 +46,6 @@ macro_ensure_out_of_source_build("${PROJECT_NAME} requires 
an out of source buil
 set(CMAKE_THREAD_PREFER_PTHREADS ON)
 find_package(Threads)
 
-find_package(PythonInterp)
-set(Python_ADDITIONAL_VERSIONS 2.6 2.7 3.3 3.4 3.6)
-find_package(PythonLibs)
-find_package(PythonSiteLibs)
-
 # config.h checks
 include(ConfigureChecks.cmake)
 configure_file(config.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config.h)
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 76a87d6..e3a1efd 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -69,9 +69,7 @@ install(TARGETS pamtest
 ARCHIVE DESTINATION ${LIB_INSTALL_DIR})
 
 add_subdirectory(modules)
-if (PYTHONLIBS_FOUND)
-add_subdirectory(python)
-endif()
+add_subdirectory(python)
 
 # This needs to be at the end
 set(PAM_WRAPPER_LOCATION 
"${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}pam_wrapper${CMAKE_SHARED_LIBRARY_SUFFIX}"
 PARENT_SCOPE)
diff --git a/src/python/CMakeLists.txt b/src/python/CMakeLists.txt
index cbee2a6..3394a84 100644
--- a/src/python/CMakeLists.txt
+++ b/src/python/CMakeLists.txt
@@ -1,15 +1,4 @@
 project(pypamtest C)
 
-include_directories(${CMAKE_BINARY_DIR})
-include_directories(${pam_wrapper-headers_DIR})
-include_directories(${PYTHON_INCLUDE_DIR})
-
-python_add_module(pypamtest pypamtest.c)
-target_link_libraries(pypamtest pamtest ${PYTHON_LIBRARY})
-
-install(
-TARGETS
-pypamtest
-DESTINATION
-${CMAKE_INSTALL_PREFIX}/${PYTHON_SITELIB}
-)
+add_subdirectory(python2)
+add_subdirectory(python3)
diff --git a/src/python/python2/CMakeLists.txt 
b/src/python/python2/CMakeLists.txt
new file mode 100644
index 000..faceec3
--- /dev/null
+++ b/src/python/python2/CMakeLists.txt
@@ -0,0 +1,33 @@
+project(python2-pamtest C)
+
+unset(PYTHON_EXECUTABLE CACHE)
+unset(PYTHON_INCLUDE_DIR CACHE)
+unset(PYTHON_LIBRARY CACHE)
+unset(PYTHON_SITELIB CACHE)
+unset(PYTHONLIBS_FOUND CACHE)
+unset(PYTHONLIBS_VERSION_STRING CACHE)
+
+set(Python_ADDITIONAL_VERSIONS 2.7 2.6)
+find_package(PythonLibs)
+find_package(PythonInterp)
+find_package(PythonSiteLibs)
+
+if (PYTHONLIBS_FOUND)
+set(PYTHON2_EXECUTABLE ${PYTHON_EXECUTABLE} CACHE FILEPATH 
"PYTHON2_EXECUTABLE")
+set(PYTHON2_INCLUDE_DIR ${PYTHON_INCLUDE_DIR})
+set(PYTHON2_LIBRARY ${PYTHON_LIBRARY})
+set(PYTHON2_SITELIB ${PYTHON_SITELIB})
+
+include_directories(${CMAKE_BINARY_DIR})
+include_directories(${pam_wrapper-headers_DIR})
+include_directories(${PYTHON2_INCLUDE_DIR})
+
+python_add_module(python2-pamtest ${pypamtest_SOURCE_DIR}/pypamtest.c)
+target_link_libraries(python2-pamtest pamtest ${PYTHON2_LIBRARY})
+set_target_properties(python2-pamtest PROPERTIES OUTPUT_NAME "pypamtest")
+
+install(TARGETS
+python2-pamtest
+DESTINATION
+${CMAKE_INSTALL_PREFIX}/${PYTHON2_SITELIB})
+endif()
diff --git a/src/python/python3/CMakeLists.txt 
b/src/python/python3/CMakeLists.txt
new file mode 100644
index 000..1e1599b
--- /dev/null
+++ b/src/python/python3/CMakeLists.txt
@@ -0,0 +1,33 @@
+project(python3-pamtest C)
+
+unset(PYTHON_EXECUTABLE CACHE)
+unset(PYTHON_INCLUDE_DIR CACHE)
+unset(PYTHON_LIBRARY CACHE)
+unset(PYTHON_SITELIB CACHE)
+unset(PYTHONLIBS_FOUND CACHE)
+unset(PYTHONLIBS_VERSION_STRING CACHE)
+
+set(Python_ADDITIONAL_VERSIONS 3.8 3.7 3.6)
+find_package(PythonLibs)
+find_package(PythonInterp)
+find_package(PythonSiteLibs)
+
+if (PYTHONLIBS_FOUND)
+set(PYTHON3_LIBRARY ${PYTHON_LIBRARY})
+set(PYTHON3_INCLUDE_DIR ${PYTHON_INCLUDE_DIR})
+set(PYTHON3_SITELIB

[SCM] Samba Shared Repository - branch master updated

2018-02-12 Thread Jeremy Allison 
The branch, master has been updated
   via  3bbc575 smbd: remove "id" from share_mode_entry
   via  f7e6571 smbd: Pass "file_id" explicitly to send_break_to_none
   via  1e2659e smbd: Pass "file_id" explicitly to send_break_message()
   via  9d7701c srvsvc: Avoid a dependency on share_mode_entry->id
   via  d9e5148 smbd: Avoid a dependency on share_mode_entry->id
   via  ddb1524 smbd: Avoid a dependency on share_mode_entry->id
   via  b7e29d0 smbd: Pass "file_id" explicitly to 
message_to_share_mode_entry()
   via  fc424b2 smbd: Pass "file_id" explicitly into 
share_mode_entry_to_message()
   via  5fdc62b smbd: Remove a redundant check
   via  bab8bf7 smbd: Use "share_mode_data->id", not "share_mode_entry->id"
   via  c1079e3 srvsvc: Use the passed-in file_id
   via  3434b32 smbd: Pass in "file_id" into validate_my_share_entries
   via  9487510 smbd: Pass in "file_id" into share_mode_str()
   via  786e307 srvsvc: Use the passed-in file id, not the one from 
share_mode_entry
   via  f519162 smbd: Pass "file_id" through share_entry_forall
   via  e6187be smbd: Fix a signed/unsigned hickup
  from  1e8ad19 winbindd: Initialize the domain groups member

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 3bbc57564411b031bf3ce55652c9c899642da045
Author: Volker Lendecke 
Date:   Wed Feb 7 14:32:37 2018 +0100

smbd: remove "id" from share_mode_entry

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Feb 13 05:01:38 CET 2018 on sn-devel-144

commit f7e65719a4bc5fa2bede491d40a610b28f873c8a
Author: Volker Lendecke 
Date:   Wed Feb 7 12:28:13 2018 +0100

smbd: Pass "file_id" explicitly to send_break_to_none

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 1e2659e96d4a309e76d1fc2a5a3dabb83a258127
Author: Volker Lendecke 
Date:   Wed Feb 7 12:24:35 2018 +0100

smbd: Pass "file_id" explicitly to send_break_message()

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 9d7701c923bce11c05c879ea3f7cdd2322e3d2bd
Author: Volker Lendecke 
Date:   Wed Feb 7 12:16:10 2018 +0100

srvsvc: Avoid a dependency on share_mode_entry->id

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit d9e51484703e7ff510c534c603d30975d87c895c
Author: Volker Lendecke 
Date:   Wed Feb 7 12:11:10 2018 +0100

smbd: Avoid a dependency on share_mode_entry->id

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit ddb1524669681bffc86090432f01a21621d11d2f
Author: Volker Lendecke 
Date:   Wed Feb 7 11:40:58 2018 +0100

smbd: Avoid a dependency on share_mode_entry->id

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit b7e29d04c6156a6eb5c02b12e53abd1a04d75471
Author: Volker Lendecke 
Date:   Wed Feb 7 11:39:32 2018 +0100

smbd: Pass "file_id" explicitly to message_to_share_mode_entry()

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit fc424b28cd54f4ff5737417db1e1f8059cad80db
Author: Volker Lendecke 
Date:   Wed Feb 7 11:36:51 2018 +0100

smbd: Pass "file_id" explicitly into share_mode_entry_to_message()

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 5fdc62b2369b8463940629dc47c2768f0bcfc29d
Author: Volker Lendecke 
Date:   Wed Feb 7 11:14:31 2018 +0100

smbd: Remove a redundant check

The file ids in all share modes match the share_mode_data's one

We don't have a paranoia check for this, but the share mode is per inode.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit bab8bf7acb71bc54c258c29e7392927afb8b0709
Author: Volker Lendecke 
Date:   Wed Feb 7 11:13:40 2018 +0100

smbd: Use "share_mode_data->id", not "share_mode_entry->id"

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit c1079e3d2a9dd10b11e6b7c9b9852518ea637bb5
Author: Volker Lendecke 
Date:   Wed Feb 7 11:10:14 2018 +0100

srvsvc: Use the passed-in file_id

The one in share_mode_entry will go

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 3434b32b88e656e767a0a1d2fa3988b2fb2311b0
Author: Volker Lendecke 
Date:   Wed Feb 7

[SCM] Samba Shared Repository - branch master updated

2018-02-12 Thread Andreas Schneider 
The branch, master has been updated
   via  1e8ad19 winbindd: Initialize the domain groups member
   via  2abf47c winbindd: Free is_parent before we terminate
   via  a5cd134 winbindd: Free memory before we exit the connect child
  from  b4384b7 winbind: Improve child selection

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 1e8ad19653f11adbcffecde3a5762b28c5e06c8d
Author: Andreas Schneider 
Date:   Fri Feb 9 16:19:53 2018 +0100

winbindd: Initialize the domain groups member

==9405== 4 errors in context 1 of 493:
==9405== Conditional jump or move depends on uninitialised value(s)
==9405==at 0x7507F71: vfprintf (in /lib64/libc-2.12.so)
==9405==by 0x75C515B: __vasprintf_chk (in /lib64/libc-2.12.so)
==9405==by 0x2A8728: dbgtext (stdio2.h:199)
==9405==by 0x22DCBB: winbindd_list_groups_done 
(winbindd_list_groups.c:127)
==9405==by 0x6C7F568: _tevent_req_error (tevent_req.c:167)
==9405==by 0x6C7F568: _tevent_req_error (tevent_req.c:167)
==9405==by 0x6C7F568: _tevent_req_error (tevent_req.c:167)
==9405==by 0x3CDAE8: dcerpc_binding_handle_call_done 
(binding_handle.c:445)
==9405==by 0x6C7F568: _tevent_req_error (tevent_req.c:167)
==9405==by 0x6C7F568: _tevent_req_error (tevent_req.c:167)
==9405==by 0x202701: wbint_bh_raw_call_done (winbindd_dual_ndr.c:139)
==9405==by 0x6C82C60: tevent_common_loop_timer_delay 
(tevent_timed.c:341)
==9405==by 0x6C83CA1: epoll_event_loop_once (tevent_epoll.c:911)
==9405==by 0x6C822D5: std_event_loop_once (tevent_standard.c:114)
==9405==by 0x6C7DC3C: _tevent_loop_once (tevent.c:533)
==9405==by 0x1D8A03: main (winbindd.c:1490)
==9405==  Uninitialised value was created by a heap allocation
==9405==at 0x4A069EE: malloc (vg_replace_malloc.c:270)
==9405==by 0x6A71DCA: _talloc_array (in /usr/lib64/libtalloc.so.2.1.5)
==9405==by 0x22D959: winbindd_list_groups_send 
(winbindd_list_groups.c:69)
==9405==by 0x1D76BC: winbind_client_request_read (winbindd.c:647)
==9405==by 0x23AF2A: wb_req_read_done (wb_reqtrans.c:126)
==9405==by 0x6C83EA5: epoll_event_loop_once (tevent_epoll.c:728)
==9405==by 0x6C822D5: std_event_loop_once (tevent_standard.c:114)
==9405==by 0x6C7DC3C: _tevent_loop_once (tevent.c:533)
==9405==by 0x1D8A03: main (winbindd.c:1490)

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Feb 13 00:25:27 CET 2018 on sn-devel-144

commit 2abf47cfb3153108e3b153fee571ab187f9eb755
Author: Andreas Schneider 
Date:   Fri Feb 9 15:33:39 2018 +0100

winbindd: Free is_parent before we terminate

This makes valgrind happy.

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke 

commit a5cd134ed7634328c9d0b64a45a59c04530c7249
Author: Andreas Schneider 
Date:   Fri Feb 9 15:27:42 2018 +0100

winbindd: Free memory before we exit the connect child

This will make valgrind happy.

Signed-off-by: Andreas Schneider 
Reviewed-by: Volker Lendecke 

---

Summary of changes:
 source3/winbindd/winbindd.c | 9 ++---
 source3/winbindd/winbindd_cm.c  | 5 -
 source3/winbindd/winbindd_list_groups.c | 7 ++-
 3 files changed, 16 insertions(+), 5 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd.c b/source3/winbindd/winbindd.c
index 0a8d146..6e3df1f 100644
--- a/source3/winbindd/winbindd.c
+++ b/source3/winbindd/winbindd.c
@@ -233,11 +233,14 @@ static void winbindd_sig_term_handler(struct 
tevent_context *ev,
  void *siginfo,
  void *private_data)
 {
-   bool *is_parent = talloc_get_type_abort(private_data, bool);
+   bool *p = talloc_get_type_abort(private_data, bool);
+   bool is_parent = *p;
+
+   TALLOC_FREE(p);
 
DEBUG(0,("Got sig[%d] terminate (is_parent=%d)\n",
-signum, (int)*is_parent));
-   terminate(*is_parent);
+signum, is_parent));
+   terminate(is_parent);
 }
 
 /*
diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
index 54416e0..4229647 100644
--- a/source3/winbindd/winbindd_cm.c
+++ b/source3/winbindd/winbindd_cm.c
@@ -199,6 +199,7 @@ static bool fork_child_dc_connect(struct winbindd_domain 
*domain)
pid_t parent_pid = getpid();
char *lfile = NULL;
NTSTATUS status;
+   bool ok;
 
if (domain->dc_probe_pid != (pid_t)-1) {

autobuild[sn-devel-144]: intermittent test failure detected

2018-02-12 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-12-2028/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-12-2028/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-12-2028/samba.stdout
  
The top commit at the time of the failure was:

commit cb920dd8732af30a7f74d5b492ea6ddfc2adfcbd
Author: Douglas Bagnall 
Date:   Fri Feb 9 23:09:41 2018 +1300

tests/samba-tool user wdigest: fix a flapping test

The output of something like

  samba-tool user getpassword $USER --attributes virtualWDigest01

contains an LDIF section with long strings folded on the 77th column.

To unfold this LDIF we were using:

   result = re.sub(r"\n\s*", '', out)

which worked fine EXCEPT when a space in the output happened to land
immediately after the fold and got eaten by the \s*.

Instead we remove just a single space after the line break, because
that is always what fold_string() in lib/ldb/common/ldb_ldif.c
inserts, and for this simple replacement we don't need the re module.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Mon Feb 12 05:21:01 CET 2018 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

2018-02-12 Thread Volker Lendecke 
The branch, master has been updated
   via  b4384b7 winbind: Improve child selection
  from  cb920dd tests/samba-tool user wdigest: fix a flapping test

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit b4384b7f0ecf3b47dd60acaf77636b679e3adc05
Author: Volker Lendecke 
Date:   Fri Feb 9 10:27:55 2018 +0100

winbind: Improve child selection

This improves the situation when a client request blocks a winbind
child. This might be a slow samlogon or lookupnames to a domain that's
far away. With random selection of the child for new request coming in
we could end up with a long queue when other, non-blocked children
could serve those new requests. Choose the shortest queue.

This is an immediate and simple fix. Step two will be to have a
per-domain and not a per-child queue. Right now we're pre-selecting
the check-out queue at Fry's randomly without looking at the queue
length. With this change we're picking the shortest queue. The better
change will be what Fry's really does: One central queue and red/green
lights on the busy/free checkout counters.

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Mon Feb 12 19:51:35 CET 2018 on sn-devel-144

---

Summary of changes:
 source3/winbindd/winbindd_dual.c | 36 +---
 1 file changed, 17 insertions(+), 19 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd_dual.c b/source3/winbindd/winbindd_dual.c
index 33f1393..993166d 100644
--- a/source3/winbindd/winbindd_dual.c
+++ b/source3/winbindd/winbindd_dual.c
@@ -248,33 +248,31 @@ static void wb_child_request_cleanup(struct tevent_req 
*req,
DLIST_REMOVE(winbindd_children, state->child);
 }
 
-static bool winbindd_child_busy(struct winbindd_child *child)
-{
-   return tevent_queue_length(child->queue) > 0;
-}
-
-static struct winbindd_child *find_idle_child(struct winbindd_domain *domain)
+struct winbindd_child *choose_domain_child(struct winbindd_domain *domain)
 {
+   struct winbindd_child *shortest = >children[0];
+   struct winbindd_child *current;
int i;
 
for (i=0; ichildren[i])) {
-   return >children[i];
-   }
-   }
+   size_t shortest_len, current_len;
 
-   return NULL;
-}
+   current = >children[i];
+   current_len = tevent_queue_length(current->queue);
 
-struct winbindd_child *choose_domain_child(struct winbindd_domain *domain)
-{
-   struct winbindd_child *result;
+   if (current_len == 0) {
+   /* idle child */
+   return current;
+   }
 
-   result = find_idle_child(domain);
-   if (result != NULL) {
-   return result;
+   shortest_len = tevent_queue_length(shortest->queue);
+
+   if (current_len < shortest_len) {
+   shortest = current;
+   }
}
-   return >children[rand() % lp_winbind_max_domain_connections()];
+
+   return shortest;
 }
 
 struct dcerpc_binding_handle *dom_child_handle(struct winbindd_domain *domain)


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch v4-8-test updated

2018-02-12 Thread Stefan Metzmacher 
The branch, v4-8-test has been updated
   via  f093cdd ctdb-tests: Set test timeout to an hour
   via  6711e70 ctdb-tests: Fix a typo
   via  74e2d61 ctdb-tests: Add a UNIT pseudo-test-suite
   via  10a ctdb-tests: Only use socket-wrapper for simple, local 
daemon tests
   via  e7af9b0 ctdb-tests: Add timeout for individual tests, default is 10 
minutes
   via  83b2971 ctdb-tests: Avoid race condition in sock_daemon test 5
   via  11acdbe selftest: fix envvars for creation of default user in 
wait_for_start
  from  f20fcac VERSION: Bump version up to 4.8.0rc4...

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-8-test


- Log -
commit f093cdd2afeb54e7927be59839402ecb1e82ce3b
Author: Martin Schwenke 
Date:   Mon Feb 5 15:45:09 2018 +1100

ctdb-tests: Set test timeout to an hour

The current 10 minute timeout is causing autobuild failures in some
environments.

This timeout is simply meant to stop a test run from hanging
indefinitely due to a broken test.  A 1 hour timeout is better than no
timeout.

Signed-off-by: Martin Schwenke 
Reviewed-by: Gary Lockyer 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Thu Feb  8 04:42:56 CET 2018 on sn-devel-144

(cherry picked from commit a3485c41b826e307b31a1113abcea9843ca78540)

The last 6 patches address https://bugzilla.samba.org/show_bug.cgi?id=13265

Autobuild-User(v4-8-test): Stefan Metzmacher 
Autobuild-Date(v4-8-test): Mon Feb 12 15:54:28 CET 2018 on sn-devel-144

commit 6711e701585c162646da9e434908db06f31bf2af
Author: Martin Schwenke 
Date:   Tue Jan 23 20:18:54 2018 +1100

ctdb-tests: Fix a typo

This typo causes the script to be run with the default shell.  If this
is not bash then the shell will fail to parse integration.bash.

This is a regression caused by commit
c607989d91b64d837253aae794b1a3d6013eb3e0.  Clearly nobody has run this
test on Debian for a long time.  :-(

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Wed Jan 24 10:28:52 CET 2018 on sn-devel-144

(cherry picked from commit 8b82d10856160d3b3f172bf7d45ac561002dbcac)

commit 74e2d615d134b56ccdbf4ae8d91c46a1c387eb7c
Author: Martin Schwenke 
Date:   Mon Jan 22 19:48:02 2018 +1100

ctdb-tests: Add a UNIT pseudo-test-suite

This runs all of the unit tests.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 
(cherry picked from commit 50150d75814de6a1e2cb28fb7af72caa31d73e3c)

commit 10a6c00a890b46c22ea87e4653953d0948c2
Author: Martin Schwenke 
Date:   Mon Jan 22 19:14:48 2018 +1100

ctdb-tests: Only use socket-wrapper for simple, local daemon tests

The run_tests.sh -S option now takes the path to the socker-wrapper
shared library.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 
(cherry picked from commit e17d02d4039001563d189b33200c30e3906ce845)

commit e7af9b0baf46e90d63621c709dcc8e85af465f5c
Author: Martin Schwenke 
Date:   Sat Jan 20 17:05:37 2018 +1100

ctdb-tests: Add timeout for individual tests, default is 10 minutes

This will cause a hung test to time out and fail rather than letting a
test run hang indefinitely.  Some tests can take 5 minutes to run, so
10 minutes should be plenty.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 
(cherry picked from commit da3aaf972ab5b339b51ba1e802329b69885ccfe4)

commit 83b2971f002f80f7bbbd098bfe7da70e1b019607
Author: Amitay Isaacs 
Date:   Mon Jan 22 12:54:49 2018 +1100

ctdb-tests: Avoid race condition in sock_daemon test 5

This test fails when it takes more than 10s to run.  This can occur
when the system is loaded and socket-wrapper is used.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 
(cherry picked from commit 33c0f5599d93a34619c8f37945f79a6e399a1b5e)

commit 11acdbe842435d2f7ac4f62cd1b11358dee0ade1
Author: Jamie McClymont 
Date:   Mon Jan 15 15:25:10 2018 +1300

selftest: fix envvars for creation of default user in wait_for_start

Resolves failure of ad_member to start up under ad_dc (if
the user is determined to be needed).

Signed-off-by: Jamie McClymont 
Reviewed-by: Garming Sam

autobuild[sn-devel-144]: intermittent test failure detected

2018-02-12 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-12-1426/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-12-1426/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-12-1426/samba.stdout
  
The top commit at the time of the failure was:

commit cb920dd8732af30a7f74d5b492ea6ddfc2adfcbd
Author: Douglas Bagnall 
Date:   Fri Feb 9 23:09:41 2018 +1300

tests/samba-tool user wdigest: fix a flapping test

The output of something like

  samba-tool user getpassword $USER --attributes virtualWDigest01

contains an LDIF section with long strings folded on the 77th column.

To unfold this LDIF we were using:

   result = re.sub(r"\n\s*", '', out)

which worked fine EXCEPT when a space in the output happened to land
immediately after the fold and got eaten by the \s*.

Instead we remove just a single space after the line break, because
that is always what fold_string() in lib/ldb/common/ldb_ldif.c
inserts, and for this simple replacement we don't need the re module.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Mon Feb 12 05:21:01 CET 2018 on sn-devel-144

[SCM] Samba Shared Repository - branch v4-8-stable updated

2018-02-12 Thread Karolin Seeger 
The branch, v4-8-stable has been updated
   via  4348e64 VERSION: Disable GIT_SNAPSHOT for the 4.8.0rc3 release.
   via  4b6a12e WHATSNEW: Add release notes for Samba 4.8.0rc3.
   via  ca87709 winbindd: WBFLAG_PAM_AUTH_PAC should call 
add_trusted_domain_from_auth() is the result is trusted
   via  7e8ee67 winbindd: rename winbindd_pam_auth_pac_send and let it 
return validation
   via  df6062e winbindd: complete WBFLAG_PAM_AUTH_PAC handling in 
winbindd_pam_auth_crap_send()
   via  c1ab6c5 winbindd: let winbindd_pam_auth_pac_send() compute info6 
from PAC
   via  be33ac4 winbindd: call add_trusted_domain_from_auth() in 
winbindd_pam_auth_crap_done()
   via  8269dc9 winbindd: get netr_SamInfo6 out of 
winbindd_dual_pam_auth_kerberos()
   via  95ca85d s3/rpc_client: add map_info6_to_validation()
   via  e57baf7 s3/auth: add create_info6_from_pac()
   via  f85ff76 s4/auth_winbind: ask for validation level 6
   via  974b4ea winbindd: allow validation level 6 in winbind_SamLogon
   via  dafb614 s3/rpc_client: add copy_netr_SamInfo6() and 
map_validation_to_info6()
   via  b06743e winbindd: introduce a cm_connect_netlogon_secure() which 
gives a valid netlogon_creds_ctx
   via  4dac164 winbindd: handle interactive logons in _winbind_SamLogon()
   via  41c0698 winbindd: pass 'bool interactive' to winbind_dual_SamLogon()
   via  ce965d3 winbindd: add a comment to a parameter in 
_winbind_SamLogon()
   via  fb14f0f winbindd: separate plaintext given and interactive in 
winbind_samlogon_retry_loop()
   via  05b7972 s3/rpc_client: add rpccli_netlogon_interactive_logon()
   via  6fac545 winbindd: add_trusted_domain_from_auth() should not use 
dns_name = ""
   via  c549aa4 wbinfo: avoid segfault in wbinfo_auth_crap() if winbindd is 
not available
   via  2fae412 winbindd: fix debug message in find_default_route_domain() 
on a DC
   via  bf361c5 s4/rpc_server: trigger trusts reload in winbindd after 
successfull trust info acquisition
   via  bf8e88d winbindd: rename MSG_WINBIND_NEW_TRUSTED_DOMAIN to 
MSG_WINBIND_RELOAD_TRUSTED_DOMAINS
   via  cc7592e s4/rpc_server: remove unused data argument from 
MSG_WINBIND_NEW_TRUSTED_DOMAIN
   via  e465b1f winbindd: use add_trusted_domains_dc in 
wb_imsg_new_trusted_domain
   via  523ca1b winbindd: move loading of trusted domains on a DC to a 
seperate function
   via  304c95c winbindd: don't force using LSA_LOOKUP_NAMES_ALL for non 
workstation trusts.
   via  5db31e7 s3:rpc_client: pass down lsa_LookupNamesLevel to 
dcerpc_lsa_lookup_sids_generic()
   via  33d901b winbindd: prepare find_lookup_domain_from_{name,sid}() 
transitive trusts on a DC
   via  296f677 winbindd: prepare find_auth_domain() transitive trusts on a 
DC
   via  d103727 winbindd: remove const from set_routing_domain()
   via  74bbba0 winbindd: use 
Netlogon{Interactive,Network}TransitiveInformation on transitive trusts
   via  5dc2e89 s3:rpc_client: allow passing 
NetlogonNetwork[Transitive]Information to rpccli_netlogon_network_logon()
   via  a895873 s3:rpc_client: allow 
Netlogon{Network,Interactive}TransitiveInformation in 
rpccli_netlogon_password_logon()
   via  0f86338 winbindd: add routing_domain as parameter to 
add_trusted_domain
   via  8cd948f winbindd: add missing can_do_ncacn_ip_tcp initialisation
   via  3a78306 winbindd: remove useless calls to get_trust_credentials() 
before cli_rpc_pipe_open_schannel_with_creds()
   via  ae13d62 winbindd: fix LSA connections via DCERPC_AUTH_SCHANNEL
   via  099b720 winbind: Fix CID 1427626 Uninitialized scalar variable
   via  d800e1c pdb: Fix CID 1427620 Resource leak
   via  4360d83 winbind: Fix CID 1427626 Uninitialized scalar variable
   via  8ee283a pdb: Fix CID 1427624 Resource leak
   via  b368ad2 docs-xml: Add 'samba-tool visualize' to man samba-tool.8.
   via  a9b71ef WHATSNEW: Add section for "samba-tool visualize"
   via  74208be WHATSNEW: Mention new option "apply group policies"
   via  0ae4e26 dbcheck: skip find_missing_forward_links_from_backlinks() 
if the db has the sortedLinks feature
   via  a3a1768 dbcheck: add support for restoring missing forward links
   via  367970e dbcheck: add find_missing_forward_links_from_backlinks()
   via  307ffdc dbcheck: make sure we ask for replPropertyMetaData if we 
need to process any forward link attributes
   via  5f933b9 dbcheck: make sure we always ask for the objectGUID 
attribute explicitly
   via  54b7de0 dbcheck: add a helper function that checks is a value has 
duplicate links
   via  f4cb28b dbcheck: add a dict where we remember attributes with 
duplicate links
   via  8451906 dbcheck: split out check_duplicate_links from check_dn
   via  6564239 dbcheck: store fixed forward link attributes with the 
correct sorting
   via  528cee7 dbcheck: remove ldb.FLAG_MOD_REPLACE when

[SCM] Samba Website Repository - branch master updated

2018-02-12 Thread Karolin Seeger 
The branch, master has been updated
   via  9b0a6df NEWS[4.8.0rc3]: Samba 4.8.0rc3 Available for Download
  from  9bff229 Add Samba 4.7.5 to the list.

https://git.samba.org/?p=samba-web.git;a=shortlog;h=master


- Log -
commit 9b0a6dfbc49e5cf01073febf09eff4a8bb407a4f
Author: Karolin Seeger <ksee...@samba.org>
Date:   Mon Feb 12 11:28:28 2018 +0100

NEWS[4.8.0rc3]: Samba 4.8.0rc3 Available for Download

Signed-off-by: Karolin Seeger <ksee...@samba.org>

---

Summary of changes:
 posted_news/20180212-102952.4.8.0rc3.body.html | 12 
 posted_news/20180212-102952.4.8.0rc3.headline.html |  3 +++
 2 files changed, 15 insertions(+)
 create mode 100644 posted_news/20180212-102952.4.8.0rc3.body.html
 create mode 100644 posted_news/20180212-102952.4.8.0rc3.headline.html


Changeset truncated at 500 lines:

diff --git a/posted_news/20180212-102952.4.8.0rc3.body.html 
b/posted_news/20180212-102952.4.8.0rc3.body.html
new file mode 100644
index 000..b3a4528
--- /dev/null
+++ b/posted_news/20180212-102952.4.8.0rc3.body.html
@@ -0,0 +1,12 @@
+
+12 February 2018
+Samba 4.8.0rc3 Available for Download
+
+This is the third release candidate of the upcoming Samba 4.8 release series.
+
+
+The uncompressed tarball has been signed using GnuPG (ID 6F33915B6568B7EA).
+The source code can be https://download.samba.org/pub/samba/rc/samba-4.8.0rc3.tar.gz;>downloaded 
now.
+See https://download.samba.org/pub/samba/rc/samba-4.8.0rc3.WHATSNEW.txt;>the 
release notes for more info.
+
+
diff --git a/posted_news/20180212-102952.4.8.0rc3.headline.html 
b/posted_news/20180212-102952.4.8.0rc3.headline.html
new file mode 100644
index 000..66e9273
--- /dev/null
+++ b/posted_news/20180212-102952.4.8.0rc3.headline.html
@@ -0,0 +1,3 @@
+
+ 12 February 2018 Samba 4.8.0rc3 Available for 
Download
+


-- 
Samba Website Repository

[SCM] Samba Shared Repository - annotated tag samba-4.8.0rc3 created

2018-02-12 Thread Karolin Seeger 
The annotated tag, samba-4.8.0rc3 has been created
at  3f716fdb1e4d9442e60551cdcb40a42b0c3c0f99 (tag)
   tagging  4348e6471e0a4f17c8564bbb883de83f9197c154 (commit)
  replaces  samba-4.8.0rc2
 tagged by  Karolin Seeger
on  Mon Feb 12 11:28:12 2018 +0100

- Log -
samba: tag release samba-4.8.0rc3
-BEGIN PGP SIGNATURE-

iEYEABECAAYFAlqBbD0ACgkQbzORW2Vot+qmIACbBVUo65z4mmyTuQ7FwaRCDLWV
jHgAnRZvYSxQRz7xvxby7PgPAFsh/ROT
=kIQx
-END PGP SIGNATURE-

Andrew Bartlett (2):
  WHATSNEW: Mention new option "apply group policies"
  WHATSNEW: Add section for "samba-tool visualize"

David Disseldorp (1):
  WHATSNEW: briefly mention the new vfs_virusfilter module

David Mulder (2):
  gpo: Correct documentation
  gpo: Correct WHATSNEW

Günther Deschner (1):
  python: fix the build with python3.

Karolin Seeger (4):
  VERSION: Bump version up to 4.8.0rc3...
  docs-xml: Add 'samba-tool visualize' to man samba-tool.8.
  WHATSNEW: Add release notes for Samba 4.8.0rc3.
  VERSION: Disable GIT_SNAPSHOT for the 4.8.0rc3 release.

Ralph Boehme (18):
  Revert "dbcheck: disable fixing duplicate linked attributes until we can 
recover lost forward links"
  selftest/dbcheck: add a test for corrupt forward links restoration
  dbcheck: rename and reorder err_orphaned_backlink arguments
  dbcheck: add forward_syntax argument to err_orphaned_backlink
  dbcheck: rename err_duplicate_links arguments
  dbcheck: add link direction to error message for duplicate links
  dbcheck: rename err_duplicate_links() to err_recover_forward_links() and 
adjust the output message
  dbcheck: split out check_duplicate_links from check_dn
  dbcheck: add a dict where we remember attributes with duplicate links
  dbcheck: add a helper function that checks is a value has duplicate links
  dbcheck: add find_missing_forward_links_from_backlinks()
  dbcheck: add support for restoring missing forward links
  winbindd: add routing_domain as parameter to add_trusted_domain
  winbindd: move loading of trusted domains on a DC to a seperate function
  winbindd: use add_trusted_domains_dc in wb_imsg_new_trusted_domain
  s4/rpc_server: remove unused data argument from 
MSG_WINBIND_NEW_TRUSTED_DOMAIN
  winbindd: rename MSG_WINBIND_NEW_TRUSTED_DOMAIN to 
MSG_WINBIND_RELOAD_TRUSTED_DOMAINS
  s4/rpc_server: trigger trusts reload in winbindd after successfull trust 
info acquisition

Stefan Metzmacher (41):
  python:tests: use TestCaseInTempDir for "samba.tests.common"
  python:tests: remove test_dsdb_Dn() to test_dsdb_Dn_binary()
  python:tests: add test_dsdb_Dn_sorted() to "samba.tests.common"
  python/common: add __cmp__ function to dsdb_Dn similar to 
parsed_dn_compare()
  dbcheck: only pass obj_dn to err_orphaned_backlink()
  dbcheck: remove ldb.FLAG_MOD_REPLACE when replacing search results for 
forward links
  dbcheck: store fixed forward link attributes with the correct sorting
  dbcheck: make sure we always ask for the objectGUID attribute explicitly
  dbcheck: make sure we ask for replPropertyMetaData if we need to process 
any forward link attributes
  dbcheck: skip find_missing_forward_links_from_backlinks() if the db has 
the sortedLinks feature
  winbindd: fix LSA connections via DCERPC_AUTH_SCHANNEL
  winbindd: remove useless calls to get_trust_credentials() before 
cli_rpc_pipe_open_schannel_with_creds()
  winbindd: add missing can_do_ncacn_ip_tcp initialisation
  s3:rpc_client: allow Netlogon{Network,Interactive}TransitiveInformation 
in rpccli_netlogon_password_logon()
  s3:rpc_client: allow passing NetlogonNetwork[Transitive]Information to 
rpccli_netlogon_network_logon()
  winbindd: use Netlogon{Interactive,Network}TransitiveInformation on 
transitive trusts
  winbindd: remove const from set_routing_domain()
  winbindd: prepare find_auth_domain() transitive trusts on a DC
  winbindd: prepare find_lookup_domain_from_{name,sid}() transitive trusts 
on a DC
  s3:rpc_client: pass down lsa_LookupNamesLevel to 
dcerpc_lsa_lookup_sids_generic()
  winbindd: don't force using LSA_LOOKUP_NAMES_ALL for non workstation 
trusts.
  winbindd: fix debug message in find_default_route_domain() on a DC
  wbinfo: avoid segfault in wbinfo_auth_crap() if winbindd is not available
  winbindd: add_trusted_domain_from_auth() should not use dns_name = ""
  s3/rpc_client: add rpccli_netlogon_interactive_logon()
  winbindd: separate plaintext given and interactive in 
winbind_samlogon_retry_loop()
  winbindd: add a comment to a parameter in _winbind_SamLogon()
  winbindd: pass 'bool interactive' to winbind_dual_SamLogon()
  winbindd: handle interactive logons in _winbind_SamLogon()
  winbindd: introduce a cm_connect_netlogon_secure() which gives a valid

[SCM] Samba Shared Repository - branch v4-8-test updated

2018-02-12 Thread Karolin Seeger 
The branch, v4-8-test has been updated
   via  f20fcac VERSION: Bump version up to 4.8.0rc4...
   via  4348e64 VERSION: Disable GIT_SNAPSHOT for the 4.8.0rc3 release.
   via  4b6a12e WHATSNEW: Add release notes for Samba 4.8.0rc3.
  from  ca87709 winbindd: WBFLAG_PAM_AUTH_PAC should call 
add_trusted_domain_from_auth() is the result is trusted

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-8-test


- Log -
commit f20fcacb56c62f9e6ae3cb71c9cea8d2987f05e9
Author: Karolin Seeger 
Date:   Thu Feb 8 11:47:22 2018 +0100

VERSION: Bump version up to 4.8.0rc4...

and disable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger 

commit 4348e6471e0a4f17c8564bbb883de83f9197c154
Author: Karolin Seeger 
Date:   Thu Feb 8 11:46:41 2018 +0100

VERSION: Disable GIT_SNAPSHOT for the 4.8.0rc3 release.

Signed-off-by: Karolin Seeger 

commit 4b6a12ef3eeecaac66cfacc0e8da5de37a196984
Author: Karolin Seeger 
Date:   Thu Feb 8 11:46:10 2018 +0100

WHATSNEW: Add release notes for Samba 4.8.0rc3.

Signed-off-by: Karolin Seeger 

---

Summary of changes:
 VERSION  |  2 +-
 WHATSNEW.txt | 18 +-
 2 files changed, 18 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/VERSION b/VERSION
index b0ad536..30de02c 100644
--- a/VERSION
+++ b/VERSION
@@ -87,7 +87,7 @@ SAMBA_VERSION_PRE_RELEASE=
 # e.g. SAMBA_VERSION_RC_RELEASE=1  #
 #  ->  "3.0.0rc1"  #
 
-SAMBA_VERSION_RC_RELEASE=3
+SAMBA_VERSION_RC_RELEASE=4
 
 
 # To mark SVN snapshots this should be set to 'yes'#
diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index 3a923b1..6b111c4 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -1,7 +1,7 @@
 Release Announcements
 =
 
-This is the second release candidate of Samba 4.8.  This is *not*
+This is the third release candidate of Samba 4.8.  This is *not*
 intended for production environments and is designed for testing
 purposes only.  Please report any defects via the Samba bug reporting
 system at https://bugzilla.samba.org/.
@@ -221,6 +221,22 @@ smb.conf changes
   winbind trusted domains only   Removed
 
 
+CHANGES SINCE 4.8.0rc2
+==
+
+o  Trever L. Adams 
+   * BUG 13246: Backport Samba VirusFilter.
+
+o  Ralph Boehme 
+   * BUG 13228: dbcheck: Add support for restoring missing forward links.
+
+o  Günther Deschner 
+   * BUG 13221: python: fix the build with python3.
+
+o  Stefan Metzmacher 
+   * BUG 13228: dbcheck: Add support for restoring missing forward links.
+
+
 CHANGES SINCE 4.8.0rc1
 ==
 


-- 
Samba Shared Repository