[SCM] Samba Shared Repository - branch master updated

2018-05-28 Thread Andrew Bartlett
The branch, master has been updated
   via  5b86203 python/samba/netcmd/schema.py: samdb schema update now
   via  4b1a862 python/samba/tests/samba_tool/schema.py: Improve schema 
command testing
   via  2c65184 python/samba/netcmd/schema.py: add schema show_oc for 
attribute
   via  74d85d4 python/samba/netcmd/schema.py: add schema query and 
management.
   via  289ae87 python/samba/netcmd/group.py: add group show
   via  b8e51a8 python/samba/netcmd/{forest.py,main.py}: add configuration 
controls
  from  e56b92b torture: Cope with WINBINDD_SHOW_SEQUENCE failure for fake 
trusts

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 5b8620307edfd2897dd61c7e860d95662c547ecc
Author: William Brown 
Date:   Sat May 19 12:19:58 2018 +1000

python/samba/netcmd/schema.py: samdb schema update now

When we change schema values, we should trigger a schema update to refresh
the changes applied. This is called after a change is made. A helper to
samdb is added so that it's easier for other locations to call additionally.

Signed-off-by: William Brown 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Garming Sam 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue May 29 08:30:52 CEST 2018 on sn-devel-144

commit 4b1a86235ba454b0e5e27ca621d87c8644b2a98c
Author: William Brown 
Date:   Mon May 28 10:30:39 2018 +1000

python/samba/tests/samba_tool/schema.py: Improve schema command testing

Assert the correct stdout content of the schema test commands.

Signed-off-by: William Brown 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Garming Sam 

commit 2c65184270500dc99b1697af6e830d62093a627f
Author: William Brown 
Date:   Sun Apr 29 13:28:42 2018 +1200

python/samba/netcmd/schema.py: add schema show_oc for attribute

Often administrators need to add a specific attribute to an object, but
it may not be possible with the objectClasses present. This tool allows
searching "what objectclasses must or may?" take an attribute to help hint
to an administrator what objectclasses can be added to objects to achieve
the changes they want.

Signed-off-by: William Brown 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Garming Sam 

commit 74d85d4cc246458f51ec9b264310959055f0a0b9
Author: William Brown 
Date:   Sat Apr 28 15:22:29 2018 +1000

python/samba/netcmd/schema.py: add schema query and management.

Schema management in active directory is complex and dangerous. Having
a tool that safely wraps administrative tasks as well as allowing query
of the schema will make this complex topic more accessible to 
administrators.

Signed-off-by: William Brown 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Garming Sam 

commit 289ae87c3bb81b2e1cd30a876a3b694b7264edc5
Author: William Brown 
Date:   Thu Apr 26 13:59:06 2018 +1000

python/samba/netcmd/group.py: add group show

The samba-tool user command can show the ldif of a user. This is
useful for groups also, especially to determine the objectSID and
objectGUID. Add support for group show to samba-tool.

Signed-off-by: William Brown 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Garming Sam 

commit b8e51a8174682149bd8381163a6f1a4658da6271
Author: William Brown 
Date:   Wed Apr 25 17:36:17 2018 +1000

python/samba/netcmd/{forest.py,main.py}: add configuration controls

With samba-tool we should expose ways to easily administer and control
common configuration options. This adds the base framework for modifying
forest settings, generally stored in cn=configuration partition.

An example is:

samba-tool forest directory_service show
samba-tool forest directory_service dsheuristics X

Signed-off-by: William Brown 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Garming Sam 

---

Summary of changes:
 docs-xml/manpages/samba-tool.8.xml  |  50 +
 python/samba/ms_schema.py   |   9 +-
 python/samba/netcmd/domain.py   |  11 +-
 python/samba/netcmd/forest.py   | 162 +
 python/samba/netcmd/group.py|  81 +
 python/samba/netcmd/main.py |   2 +
 python/samba/netcmd/schema.py   | 313 
 python/samba/samdb.py   |  13 ++
 python/samba/tests/samba_tool/forest.py |  66 +++
 python/samba/tests/samba_tool/group.py  |  10 +
 python/samba/tests/samba_tool/schema.py | 113 
 source4/selftest/tests.py   |   2 +
 12 files changed, 819 insertions(+), 13 deletions(-)
 create mode 100644 python/samba/netcmd/forest.py
 create mode 100644 python/samba/netcmd/schema.py
 create mode 100644 python/samba/tests/samba_tool/forest.py
 create mode 100644 pyth

[SCM] Samba Shared Repository - branch master updated

2018-05-28 Thread Andrew Bartlett
The branch, master has been updated
   via  e56b92b torture: Cope with WINBINDD_SHOW_SEQUENCE failure for fake 
trusts
  from  f052b60 talloc: Fix some typos in the comments

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit e56b92bd95a586181625df8b5e198c3d560eceba
Author: Andrew Bartlett 
Date:   Mon May 28 22:35:20 2018 +1200

torture: Cope with WINBINDD_SHOW_SEQUENCE failure for fake trusts

This test has been flapping and we should not be checking the
sequence number of remote trusts in a loop like this.  We can write
a test against the trusts we specifically set up if we want to check
remote sequence numbers (and connectivity) against actually working
domains.

When flapping the previous version of the test gave:

 WARNING!: ../source4/torture/winbind/struct_based.c:812: 
WINBINDD_SHOW_SEQUENCE returned 0, expected 1: WINBINDD_SHOW_SEQUENCE
 WARNING!: WINBINDD_SHOW_SEQUENCE on domain torturedom failed

 Trust list for WINBINDD_SHOW_SEQUENCE was:
 BUILTIN
 S4MEMBER
 SAMBADOMAIN
 torturedom

 WARNING!: ../source4/torture/winbind/struct_based.c:812: 
WINBINDD_SHOW_SEQUENCE returned 0, expected 1: WINBINDD_SHOW_SEQUENCE
 WARNING!: WINBINDD_SHOW_SEQUENCE on domain TORTURE302 failed

 Trust list for WINBINDD_SHOW_SEQUENCE was:
 BUILTIN
 S4MEMBER
 SAMBADOMAIN
 TORTURE302
 TORTURE306

Signed-off-by: Andrew Bartlett 
Reviewed-by: Gary Lockyer 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue May 29 02:31:40 CEST 2018 on sn-devel-144

---

Summary of changes:
 source4/torture/winbind/struct_based.c | 22 +++---
 1 file changed, 19 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/torture/winbind/struct_based.c 
b/source4/torture/winbind/struct_based.c
index 7ea5aa7..9745b62 100644
--- a/source4/torture/winbind/struct_based.c
+++ b/source4/torture/winbind/struct_based.c
@@ -816,11 +816,27 @@ static bool torture_winbind_struct_show_sequence(struct 
torture_context *torture
"domain %s failed\n",
req.domain_name);
 
+   /*
+* Only fail for the first two domain that we
+* check specially below, otherwise we fail on
+* trusts generated by the LSA torture test
+* that do not really exist.
+*/
+   if (i > 1) {
+   /*
+* Do not confirm the sequence numbers
+* below
+*/
+   return true;
+   }
+
torture_comment(torture,
-   "Trust list for "
-   "WINBINDD_SHOW_SEQUENCE was:\n");
+   "Full trust list for "
+   "WINBINDD_SHOW_SEQUENCE "
+   "test was:\n");
for (i=0; domlist[i].netbios_name; i++) {
-   torture_comment(torture, "%s\n",
+   torture_comment(torture,
+   "%s\n",
domlist[i].netbios_name);
}
 


-- 
Samba Shared Repository



autobuild[sn-devel-144]: intermittent test failure detected

2018-05-28 Thread autobuild
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-29-0151/flakey.log

The failure seems to be in the "samba" suite, whose build logs are available 
here:

   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-29-0151/samba.stderr
   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-29-0151/samba.stdout
  
The top commit at the time of the failure was:

commit f052b6057294baed1fdf0e916200d3f653bba8ca
Author: Kai Blin 
Date:   Sun May 27 08:38:19 2018 +0200

talloc: Fix some typos in the comments

Now with even more typos fixed. Thanks Rowland.

Signed-off-by: Kai Blin 
Reviewed-by: Rowland Penny 

Autobuild-User(master): Kai Blin 
Autobuild-Date(master): Mon May 28 16:16:17 CEST 2018 on sn-devel-144

and the last 50 lines of the stdout log were:

[755(4054)/853 at 49m20s] samba.tests.blackbox.traffic_replay(ad_dc_ntvfs)
[756(4060)/853 at 49m29s] samba.tests.blackbox.traffic_learner(ad_dc_ntvfs)
[757(4062)/853 at 49m30s] samba.tests.blackbox.traffic_summary(ad_dc_ntvfs)
[758(4062)/853 at 49m30s] samba.tests.blackbox.smbcontrol(ad_dc_ntvfs:local)
[759(4064)/853 at 49m32s] samba.tests.blackbox.smbcontrol(promoted_dc:local)
[760(4066)/853 at 49m33s] samba4.ldap.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[761(4105)/853 at 49m45s] 
samba4.tokengroups.krb5.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[762(4115)/853 at 49m53s] 
samba4.tokengroups.ntlm.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[763(4124)/853 at 50m1s] samba4.sam.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[764(4141)/853 at 50m5s] 
samba4.user_account_control.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[765(4152)/853 at 50m19s] samba4.schemaInfo.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[766(4154)/853 at 50m22s] samba.tests.dsdb_schema_attributes(ad_dc_ntvfs:local)
[767(4159)/853 at 50m36s] 
samba4.urgent_replication.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[768(4167)/853 at 50m39s] samba4.ldap.dirsync.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[769(4191)/853 at 52m11s] samba4.ldap.match_rules.python(ad_dc_ntvfs)
[770(4225)/853 at 52m38s] 
samba4.ldap.notification.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[771(4228)/853 at 52m45s] samba4.ldap.sites.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[772(4239)/853 at 52m52s] samba4.ldap.sort.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[773(4246)/853 at 53m1s] samba4.ldap.vlv.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[774(4261)/853 at 1h4m26s] 
samba4.ldap.linked_attributes.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[775(4281)/853 at 1h4m32s] samba4.ldap.rodc.python(rodc)(rodc)
[776(4287)/853 at 1h4m37s] samba4.ldap.rodc_rwdc.python(rodc)(rodc:local)
[777(4307)/853 at 1h11m53s] 
samba4.drs.replica_sync_rodc.python(rodc)(rodc:local)
[778(4309)/853 at 1h12m1s] samba4.ldap.password_settings.python(ad_dc_ntvfs)
[779(4321)/853 at 1h12m41s] samba4.ldap_schema.python(ad_dc_ntvfs)(ad_dc_ntvfs)
GSS client Update(krb5)(1) Update failed:  Miscellaneous failure (see text): 
Clock skew too great
UNEXPECTED(error): 
samba4.ldap_schema.python(ad_dc_ntvfs).__main__.SchemaTests.test_generated_mAPIID(ad_dc_ntvfs)
REASON: Exception: Exception: Traceback (most recent call last):
  File 
"/memdisk/autobuild/fl/b2417912/samba/source4/dsdb/tests/python/ldap_schema.py",
 line 1173, in test_generated_mAPIID
self.ldb.modify_ldif(ldif)
  File "bin/python/samba/__init__.py", line 241, in modify_ldif
self.modify(msg, controls)
LdbError: (3, 'ldb_wait from (null) with LDB_WAIT_ALL: Time limit exceeded (3)')

FAILED (0 failures, 1 errors and 0 unexpected successes in 0 testsuites)

A summary with detailed information can be found in:
  ./bin/ab/summary
TOP 10 slowest tests
samba4.ldap.vlv.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 686
samba4.ldap.rodc_rwdc.python(rodc)(rodc:local) -> 436
samba4.rpc.samr.passwords.lockout on ncacn_np with (ad_dc_ntvfs) -> 224
samba4.rpc.samr.passwords.pwdlastset on ncacn_np with (ad_dc_ntvfs) -> 200
samba3.smbtorture_s3.vfs_aio_fork(simpleserver).RW2(simpleserver) -> 137
samba4.raw.notify(ad_dc_ntvfs) -> 107
samba4.ldb.ldaps with options -U"$USERNAME%$PASSWORD"(ad_dc_ntvfs)(ad_dc_ntvfs) 
-> 102
samba4.ldap.dirsync.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 92
samba4.rpc.samlogon on ncacn_np with (ad_dc_ntvfs) -> 74
samba.tests.emulate.traffic_packet(ad_dc_ntvfs) -> 70
ERROR: test failed with exit code 1



[SCM] Samba Shared Repository - branch master updated

2018-05-28 Thread Kai Blin
The branch, master has been updated
   via  f052b60 talloc: Fix some typos in the comments
  from  1531fcd vfs_gpfs: Use full_path_tos instead of talloc_asprintf

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit f052b6057294baed1fdf0e916200d3f653bba8ca
Author: Kai Blin 
Date:   Sun May 27 08:38:19 2018 +0200

talloc: Fix some typos in the comments

Now with even more typos fixed. Thanks Rowland.

Signed-off-by: Kai Blin 
Reviewed-by: Rowland Penny 

Autobuild-User(master): Kai Blin 
Autobuild-Date(master): Mon May 28 16:16:17 CEST 2018 on sn-devel-144

---

Summary of changes:
 lib/talloc/talloc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/talloc/talloc.h b/lib/talloc/talloc.h
index dda308d..7372df1 100644
--- a/lib/talloc/talloc.h
+++ b/lib/talloc/talloc.h
@@ -1898,8 +1898,8 @@ void talloc_set_log_stderr(void);
  *   This affects all children of this context and constrain any
  *   allocation in the hierarchy to never exceed the limit set.
  *   The limit can be removed by setting 0 (unlimited) as the
- *   max_size by calling the funciton again on the sam context.
- *   Memory limits can also be nested, meaning a hild can have
+ *   max_size by calling the function again on the same context.
+ *   Memory limits can also be nested, meaning a child can have
  *   a stricter memory limit than a parent.
  *   Memory limits are enforced only at memory allocation time.
  *   Stealing a context into a 'limited' hierarchy properly


-- 
Samba Shared Repository