autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2018-06-07-1834/flakey.log The failure seems to be in the "samba-nt4" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2018-06-07-1834/samba-nt4.stderr https://git.samba.org/autobuild.flakey.sn-devel-144/2018-06-07-1834/samba-nt4.stdout The top commit at the time of the failure was: commit ae4e54563e69d3cd82ad6cf83ededb130a284c40 Author: Jeremy Allison Date: Thu Jun 7 00:47:30 2018 -0700 WHATSNEW.txt: Updated with VFS ABI changes for 4.9.0. Signed-off-by: Jeremy Allison Reviewed-by: Kai Blin Autobuild-User(master): Kai Blin Autobuild-Date(master): Thu Jun 7 13:48:25 CEST 2018 on sn-devel-144 and the last 50 lines of the stdout log were: [455(2329)/502 at 17m55s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_dc:local) [456(2330)/502 at 17m55s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_dc:local) [457(2331)/502 at 17m55s] samba.wbinfo_simple.change-secret.domain=$DOMAIN(nt4_dc:local) [458(2332)/502 at 17m55s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_dc:local) [459(2333)/502 at 17m55s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_dc:local) [460(2334)/502 at 17m55s] samba.wbinfo_simple.domain-users(nt4_dc:local) [461(2335)/502 at 17m55s] samba.wbinfo_simple.domain-groups(nt4_dc:local) [462(2336)/502 at 17m55s] samba.wbinfo_simple.name-to-sid=$DC_USERNAME(nt4_dc:local) [463(2337)/502 at 17m55s] samba.wbinfo_simple.name-to-sid=$DOMAIN/$DC_USERNAME(nt4_dc:local) [464(2338)/502 at 17m55s] samba.wbinfo_simple.user-info=$DOMAIN/$DC_USERNAME(nt4_dc:local) [465(2339)/502 at 17m55s] samba.wbinfo_simple.user-groups=$DOMAIN/$DC_USERNAME(nt4_dc:local) [466(2340)/502 at 17m56s] samba.wbinfo_simple.authenticate=$DOMAIN/$DC_USERNAME%$DC_PASSWORD(nt4_dc:local) [467(2341)/502 at 17m56s] samba.wbinfo_simple.allocate-uid(nt4_dc:local) [468(2342)/502 at 17m56s] samba.wbinfo_simple.allocate-gid(nt4_dc:local) [469(2343)/502 at 17m56s] samba.wbinfo_sids2xids.(nt4_dc:local)(nt4_dc:local) [470(2344)/502 at 18m2s] samba.ntlm_auth.diagnostics(nt4_dc:local)(nt4_dc:local) [471(2345)/502 at 18m2s] samba.ntlm_auth.(nt4_dc:local)(nt4_dc:local) [472(2364)/502 at 18m3s] samba.wbinfo_simple.ping(nt4_member:local) [473(2365)/502 at 18m4s] samba.wbinfo_simple.separator(nt4_member:local) [474(2366)/502 at 18m4s] samba.wbinfo_simple.own-domain(nt4_member:local) [475(2367)/502 at 18m4s] samba.wbinfo_simple.all-domains(nt4_member:local) [476(2368)/502 at 18m4s] samba.wbinfo_simple.trusted-domains(nt4_member:local) [477(2369)/502 at 18m4s] samba.wbinfo_simple.domain-info=BUILTIN(nt4_member:local) [478(2370)/502 at 18m4s] samba.wbinfo_simple.domain-info=$DOMAIN(nt4_member:local) [479(2371)/502 at 18m4s] samba.wbinfo_simple.online-status(nt4_member:local) [480(2372)/502 at 18m4s] samba.wbinfo_simple.online-status.domain=BUILTIN(nt4_member:local) [481(2373)/502 at 18m4s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_member:local) [482(2374)/502 at 18m4s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_member:local) UNEXPECTED(failure): samba.wbinfo_simple.check-secret.domain=SAMBA-TEST.wbinfo(nt4_member:local) REASON: Exception: Exception: wbcCheckTrustCredentials(SAMBA-TEST): error code was NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND (0xc233) failed to call wbcCheckTrustCredentials: WBC_ERR_AUTH_ERROR Could not check secret checking the trust secret for domain SAMBA-TEST via RPC calls failed FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba3.raw.notify(nt4_dc) -> 98 samba3.smb2.notify(nt4_dc) -> 79 samba3.rpc.samr.passwords.lockout(nt4_dc) -> 61 samba4.rpc.echo on ncacn_np with object(nt4_dc) -> 60 samba3.rpc.samr.passwords.pwdlastset(nt4_dc) -> 49 samba3.smb2.lease(nt4_dc) -> 45 samba3.smb2.oplock(nt4_dc) -> 42 samba3.raw.oplock(nt4_dc) -> 42 samba3.raw.search(nt4_dc) -> 33 samba3.raw.lock(nt4_dc) -> 32 ERROR: test failed with exit code 1
[SCM] Samba Shared Repository - branch v4-8-test updated
The branch, v4-8-test has been updated via a7a51bd smbd: Flush dfree memcache on service reload via f7e53f8 smbd: Cache dfree information based on query path via 3fd685e memcache: Add new cache type for dfree information via 88d19df selftest: Add test for 'dfree cache' via 2e5bc85 selftest: Add dfq_cache share with 'dfree cache time' set from 68999b8 lib/util: Call log_stack_trace() in smb_panic_default() https://git.samba.org/?p=samba.git;a=shortlog;h=v4-8-test - Log - commit a7a51bd9e6db206644a84f69dc6914a0fb266b0d Author: Christof Schmitt Date: Fri May 18 20:51:58 2018 -0700 smbd: Flush dfree memcache on service reload BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison (cherry picked from commit e30d0c0e0d11f65b2d1886be3c0fe9e32eaf3926) Autobuild-User(v4-8-test): Karolin Seeger Autobuild-Date(v4-8-test): Thu Jun 7 14:09:12 CEST 2018 on sn-devel-144 commit f7e53f864b527245081e31982868d3f9f4645630 Author: Christof Schmitt Date: Wed May 16 13:17:52 2018 -0700 smbd: Cache dfree information based on query path Sub directories in a SMB share can have different free space information (e.g. when a different file system is mounted there). Caching the dfree information per SMB share will return invalid data. Address this by switching to memcache and store the cached data based on the query path. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison (cherry picked from commit 8f121747b06ca78cf51801a3931b2ddd1a424c77) commit 3fd685e71ac6c73b0af5a650bb6617d4b56ab762 Author: Christof Schmitt Date: Wed May 16 13:05:36 2018 -0700 memcache: Add new cache type for dfree information BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison (cherry picked from commit f5d05562679f6aa691b98b4a75952f7dda7ed343) commit 88d19df48977fecc874f246798364c2ef5ccc013 Author: Christof Schmitt Date: Wed May 23 11:25:42 2018 -0700 selftest: Add test for 'dfree cache' BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison (cherry picked from commit a55b3d2fcc2f7737a2702bf908dcf1f80969bf21) commit 2e5bc85b3c67e8ccf81648e9d1260448369d5cf2 Author: Christof Schmitt Date: Wed May 23 11:07:54 2018 -0700 selftest: Add dfq_cache share with 'dfree cache time' set BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison (cherry picked from commit 7ffcbd5ce1222971cb9879f78765d87cdc4102a8) --- Summary of changes: lib/util/memcache.h | 3 +- selftest/target/Samba3.pm| 6 ++ source3/script/tests/test_dfree_quota.sh | 35 +++ source3/smbd/dfree.c | 104 +-- source3/smbd/proto.h | 1 + source3/smbd/server_reload.c | 1 + 6 files changed, 130 insertions(+), 20 deletions(-) Changeset truncated at 500 lines: diff --git a/lib/util/memcache.h b/lib/util/memcache.h index 670cbd6..4331c2f 100644 --- a/lib/util/memcache.h +++ b/lib/util/memcache.h @@ -45,7 +45,8 @@ enum memcache_number { SINGLETON_CACHE, SMB1_SEARCH_OFFSET_MAP, SHARE_MODE_LOCK_CACHE, /* talloc */ - VIRUSFILTER_SCAN_RESULTS_CACHE_TALLOC /* talloc */ + VIRUSFILTER_SCAN_RESULTS_CACHE_TALLOC, /* talloc */ + DFREE_CACHE, }; /* diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm index 52c7d3e..7b0303a 100755 --- a/selftest/target/Samba3.pm +++ b/selftest/target/Samba3.pm @@ -2140,6 +2140,12 @@ sub provision($) vfs objects = acl_xattr fake_acls xattr_tdb fake_dfq admin users = $unix_name include = $dfqconffile +[dfq_cache] + path = $shrdir/dfree + vfs objects = acl_xattr fake_acls xattr_tdb fake_dfq + admin users = $unix_name + include = $dfqconffile + dfree cache time = 60 [dfq_owner] path = $shrdir/dfree vfs objects = acl_xattr fake_acls xattr_tdb fake_dfq diff --git a/source3/script/tests/test_dfree_quota.sh b/source3/script/tests/test_dfree_quota.sh index 6e227c4..abd82b4 100755 --- a/source3/script/tests/test_dfree_quota.sh +++ b/source3/script/tests/test_dfree_quota.sh @@ -130,6 +130,35 @@ test_smbclient_dfree() { return $status } +# Issue two queries to different directories in one session to test +# caching effects +test_smbclient_dfree_2() { + name="$1" + share="$2" + dir1="$3" + dir2="$4" + c
[SCM] Samba Shared Repository - branch v4-7-test updated
The branch, v4-7-test has been updated via d3c2cc2 smbd: Flush dfree memcache on service reload via b310f37 smbd: Cache dfree information based on query path via bf63e6f memcache: Add new cache type for dfree information via 5cbb3c3 selftest: Add test for 'dfree cache' via 9d9d959 selftest: Add dfq_cache share with 'dfree cache time' set from f156d20 lib/util: Call log_stack_trace() in smb_panic_default() https://git.samba.org/?p=samba.git;a=shortlog;h=v4-7-test - Log - commit d3c2cc28545b052754a2b77a5df0a7dc86e90766 Author: Christof Schmitt Date: Fri May 18 20:51:58 2018 -0700 smbd: Flush dfree memcache on service reload BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison (cherry picked from commit e30d0c0e0d11f65b2d1886be3c0fe9e32eaf3926) Autobuild-User(v4-7-test): Karolin Seeger Autobuild-Date(v4-7-test): Thu Jun 7 13:54:43 CEST 2018 on sn-devel-144 commit b310f375726afedbc33f9f9033f7f79772898dc9 Author: Christof Schmitt Date: Wed May 16 13:17:52 2018 -0700 smbd: Cache dfree information based on query path Sub directories in a SMB share can have different free space information (e.g. when a different file system is mounted there). Caching the dfree information per SMB share will return invalid data. Address this by switching to memcache and store the cached data based on the query path. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison (cherry picked from commit 8f121747b06ca78cf51801a3931b2ddd1a424c77) commit bf63e6f23721487e1e582154b14ba7b069670d93 Author: Christof Schmitt Date: Wed May 16 13:05:36 2018 -0700 memcache: Add new cache type for dfree information BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison (cherry picked from commit f5d05562679f6aa691b98b4a75952f7dda7ed343) commit 5cbb3c35561b52369335020df7dc4d69bc49fc35 Author: Christof Schmitt Date: Wed May 23 11:25:42 2018 -0700 selftest: Add test for 'dfree cache' BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison (cherry picked from commit a55b3d2fcc2f7737a2702bf908dcf1f80969bf21) commit 9d9d95965b425075d2c602cacc896ebd781b6ff8 Author: Christof Schmitt Date: Wed May 23 11:07:54 2018 -0700 selftest: Add dfq_cache share with 'dfree cache time' set BUG: https://bugzilla.samba.org/show_bug.cgi?id=13446 Signed-off-by: Christof Schmitt Reviewed-by: Jeremy Allison (cherry picked from commit 7ffcbd5ce1222971cb9879f78765d87cdc4102a8) --- Summary of changes: lib/util/memcache.h | 3 +- selftest/target/Samba3.pm| 6 ++ source3/script/tests/test_dfree_quota.sh | 35 +++ source3/smbd/dfree.c | 104 +-- source3/smbd/proto.h | 1 + source3/smbd/server_reload.c | 1 + 6 files changed, 130 insertions(+), 20 deletions(-) Changeset truncated at 500 lines: diff --git a/lib/util/memcache.h b/lib/util/memcache.h index b87746b..c6a5b86 100644 --- a/lib/util/memcache.h +++ b/lib/util/memcache.h @@ -44,7 +44,8 @@ enum memcache_number { SINGLETON_CACHE_TALLOC, /* talloc */ SINGLETON_CACHE, SMB1_SEARCH_OFFSET_MAP, - SHARE_MODE_LOCK_CACHE /* talloc */ + SHARE_MODE_LOCK_CACHE, /* talloc */ + DFREE_CACHE, }; /* diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm index 299d55b..39a8f49 100755 --- a/selftest/target/Samba3.pm +++ b/selftest/target/Samba3.pm @@ -2007,6 +2007,12 @@ sub provision($) vfs objects = acl_xattr fake_acls xattr_tdb fake_dfq admin users = $unix_name include = $dfqconffile +[dfq_cache] + path = $shrdir/dfree + vfs objects = acl_xattr fake_acls xattr_tdb fake_dfq + admin users = $unix_name + include = $dfqconffile + dfree cache time = 60 [dfq_owner] path = $shrdir/dfree vfs objects = acl_xattr fake_acls xattr_tdb fake_dfq diff --git a/source3/script/tests/test_dfree_quota.sh b/source3/script/tests/test_dfree_quota.sh index 6e227c4..abd82b4 100755 --- a/source3/script/tests/test_dfree_quota.sh +++ b/source3/script/tests/test_dfree_quota.sh @@ -130,6 +130,35 @@ test_smbclient_dfree() { return $status } +# Issue two queries to different directories in one session to test +# caching effects +test_smbclient_dfree_2() { + name="$1" + share="$2" + dir1="$3" + dir2="$4" + confs="$5" + expected="$
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via ae4e545 WHATSNEW.txt: Updated with VFS ABI changes for 4.9.0. from 0fb122a tests/demote: replace demote test bash script to python https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit ae4e54563e69d3cd82ad6cf83ededb130a284c40 Author: Jeremy Allison Date: Thu Jun 7 00:47:30 2018 -0700 WHATSNEW.txt: Updated with VFS ABI changes for 4.9.0. Signed-off-by: Jeremy Allison Reviewed-by: Kai Blin Autobuild-User(master): Kai Blin Autobuild-Date(master): Thu Jun 7 13:48:25 CEST 2018 on sn-devel-144 --- Summary of changes: WHATSNEW.txt | 15 +++ 1 file changed, 15 insertions(+) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 574e9b2..b9c80cf 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -72,6 +72,21 @@ to allow better Windows fileserver compatibility in a default install. store dos attributes Default changed yes ea support Default changed yes +VFS interface changes += + +The VFS ABI interface version has changed to 39. Function changes +are: + +SMB_VFS_FSYNC: Removed: Only async versions are used. +SMB_VFS_READ: Removed: Only PREAD or async versions are used. +SMB_VFS_WRITE: Removed: Only PWRITE or async versions are used. +SMB_VFS_CHMOD_ACL: Removed: Only CHMOD is used. +SMB_VFS_FCHMOD_ACL: Removed: Only FCHMOD is used. + +Any external VFS modules will need to be updated to match these +changes in order to work with 4.9.x. + KNOWN ISSUES -- Samba Shared Repository
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2018-06-07-1229/flakey.log The failure seems to be in the "samba-nt4" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2018-06-07-1229/samba-nt4.stderr https://git.samba.org/autobuild.flakey.sn-devel-144/2018-06-07-1229/samba-nt4.stdout The top commit at the time of the failure was: commit 0fb122af5094d568c56b0a7814696f3389813bbd Author: Joe Guo Date: Wed Jun 6 15:01:28 2018 +1200 tests/demote: replace demote test bash script to python Convert bash script to python and add demote and dns remove test on top. Signed-off-by: Joe Guo Reviewed-by: Douglas Bagnall Reviewed-by: Garming Sam Autobuild-User(master): Douglas Bagnall Autobuild-Date(master): Thu Jun 7 04:21:17 CEST 2018 on sn-devel-144 and the last 50 lines of the stdout log were: [179(1004)/502 at 9m57s] samba3.raw.sfileinfo.bug(nt4_dc) [180(1004)/502 at 9m57s] samba3.raw.streams(nt4_dc) [181(1017)/502 at 10m0s] samba3.raw.unlink(nt4_dc) [182(1020)/502 at 10m1s] samba3.raw.write(nt4_dc) [183(1024)/502 at 10m1s] samba3.raw.samba3hide(nt4_dc) [184(1025)/502 at 10m1s] samba3.raw.samba3badpath(nt4_dc) [185(1026)/502 at 10m2s] samba3.raw.sfileinfo.rename(nt4_dc) [186(1027)/502 at 10m2s] samba3.raw.session plain(nt4_dc) [187(1029)/502 at 10m2s] samba3.raw.session enc(nt4_dc) [188(1031)/502 at 10m3s] samba3.raw.samba3caseinsensitive(nt4_dc) [189(1032)/502 at 10m3s] samba3.raw.samba3posixtimedlock(nt4_dc) [190(1033)/502 at 10m8s] samba3.raw.samba3rootdirfid(nt4_dc) [191(1034)/502 at 10m8s] samba3.raw.sfileinfo.end-of-file(nt4_dc) [192(1035)/502 at 10m9s] samba3.raw.samba3checkfsp(nt4_dc) [193(1036)/502 at 10m9s] samba3.raw.samba3closeerr(nt4_dc) [194(1037)/502 at 10m9s] samba3.raw.samba3oplocklogoff(nt4_dc) [195(1038)/502 at 10m9s] samba3.raw.samba3badnameblob(nt4_dc) [196(1039)/502 at 10m9s] samba3.smb2.getinfo(nt4_dc) [197(1045)/502 at 10m10s] samba3.smb2.lock aio(nt4_dc) [198(1066)/502 at 10m12s] samba3.smb2.lock(nt4_dc) [199(1087)/502 at 10m14s] samba3.smb2.read(nt4_dc) [200(1091)/502 at 10m14s] samba3.smb2.create(nt4_dc) [201(1104)/502 at 10m15s] samba3.smb2.acls(nt4_dc) [202(1112)/502 at 10m17s] samba3.smb2.notify(nt4_dc) TESTING CHANGE NOTIFY ON DIRECTORIES Testing notify cancel Testing notify mkdir Testing notify rmdir Testing notify mkdir - rmdir - mkdir - rmdir Testing buffered notify on create of 10 files Testing notify on unlink for the first file UNEXPECTED(failure): samba3.smb2.notify.dir(nt4_dc) REASON: Exception: Exception: (../source4/torture/smb2/notify.c:394) wrong value for notify.smb2.out.num_changes 0x9 should be 0xa FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba3.raw.notify(nt4_dc) -> 99 samba3.raw.oplock(nt4_dc) -> 43 samba3.raw.search(nt4_dc) -> 37 samba3.blackbox.net.rpc.conf(nt4_dc) -> 35 samba3.raw.lock(nt4_dc) -> 33 samba3.smbtorture_s3.crypt_client(nt4_dc).OPLOCK1(nt4_dc) -> 30 samba3.blackbox.net.local.conf(nt4_dc:local) -> 25 samba3.base.lock(nt4_dc) -> 21 samba3.smbtorture_s3.crypt_client(nt4_dc).LOCK1(nt4_dc) -> 17 samba3.base.defer_open(nt4_dc) -> 17 ERROR: test failed with exit code 1