[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 8cad448ab24 selftest/flapping: mark samba3.nbt.dgram.netlogon.* as flapping from 78e1492f218 smbd: move files_struct.lock_failure_seen to a bitfield https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 8cad448ab24bb0290c52405ea5d1ae22a759f587 Author: Noel Power Date: Fri Apr 3 16:05:37 2020 +0100 selftest/flapping: mark samba3.nbt.dgram.netlogon.* as flapping Post SMB1/SMB2 test env split to help in removing smb1 samba3.nbt.dgram.netlogon* fails randomly. It is unrelated as far as we can see to the changes but must be a side affect of runtime order or some such. Signed-off-by: Noel Power Reviewed-by: Ralph Boehme Autobuild-User(master): Noel Power Autobuild-Date(master): Sat Apr 4 01:12:05 UTC 2020 on sn-devel-184 --- Summary of changes: selftest/flapping.d/nbt_dgram | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 selftest/flapping.d/nbt_dgram Changeset truncated at 500 lines: diff --git a/selftest/flapping.d/nbt_dgram b/selftest/flapping.d/nbt_dgram new file mode 100644 index 000..b4e4c3b4ac8 --- /dev/null +++ b/selftest/flapping.d/nbt_dgram @@ -0,0 +1,7 @@ +# following SMB1/SMB2 test env split it seems this test +# fails randomly however it doesn't seem to be directly +# related to the changes (e.g. not protocl negotiation +# specific) Best guess is the order of test having being +# changed (as a result of test moving env) or some other +# strange env related side affect is causing this. +^samba3.nbt.dgram.netlogon.*\(ad_dc\) -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 78e1492f218 smbd: move files_struct.lock_failure_seen to a bitfield via 16a485d1be3 smbd: move files_struct.closing to a bitfield via e940a41c2b2 smbd: move files_struct.use_ofd_locks to a bitfield via 34b4effc04b smbd: move files_struct.backup_intent to a bitfield via 049488f6a51 smbd: move files_struct.is_sparse to a bitfield via 930b7525a66 smbd: move files_struct.delete_on_close to a bitfield via b0824cf35fe smbd: move files_struct.initial_delete_on_close to a bitfield via 1ccd335af5d smbd: move files_struct.aio_write_behind to a bitfield via cb996cd5a35 smbd: move files_struct.is_directory to a bitfield via 65a4302474d smbd: move files_struct.modified to a bitfield via b95c62bc90c smbd: move files_struct.can_write to a bitfield via 8b48969241a smbd: move files_struct.can_read to a bitfield via d22096961be smbd: move files_struct.can_lock to a bitfield via 4d70e92a917 smbd: move files_struct.write_time_forced to a bitfield via 9c2809c5175 smbd: move files_struct.update_write_time_on_close to a bitfield via adaca9597ce smbd: move files_struct.update_write_time_triggered to a bitfield via 7c386c08dcc smbd: move files_struct.kernel_share_modes_taken to a bitfield via fed1bc2293e smbd: reindent if expression in real_write_file() via 8718dae6b8a smbd: fix if expression that checks when to call vfs_fill_sparse() via ea0f1b3be77 smbd: reformat an if expression in smbd_smb2_close() via a72208fc8c9 smbd: reformat a function call in rename_internals_fsp() via 553e576ad97 smbd: reformat an if expression in reply_readbraw() via 5a5bbcd9d99 smbd: reformat calling ensure_canon_entry_valid_on_set() in unpack_canon_ace() via 574255a754a smbd: CHECK_WRITE macro reformatting via 2d56412e28b smbd: CHECK_READ_IOCTL macro reformatting via be6f8e03a07 smbd: CHECK_READ_SMB2 macro reformatting via 61e3576ad85 smbd: CHECK_READ macro reformatting from 23349f9d2c2 selftest: Add list of tests to be ported https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 78e1492f218b94f1fd4085b20bc28bd84c8d6dc7 Author: Ralph Boehme Date: Fri Apr 3 09:48:58 2020 +0200 smbd: move files_struct.lock_failure_seen to a bitfield Updated comment in vfs.h explaining ABI change. Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Fri Apr 3 20:41:34 UTC 2020 on sn-devel-184 commit 16a485d1be39f511a8d36c979e25aa0fcb1ce1b0 Author: Ralph Boehme Date: Fri Apr 3 08:06:27 2020 +0200 smbd: move files_struct.closing to a bitfield Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit e940a41c2b2a80087086e7bd63e36c410225b586 Author: Ralph Boehme Date: Fri Apr 3 08:02:23 2020 +0200 smbd: move files_struct.use_ofd_locks to a bitfield Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit 34b4effc04b44e22809227479da2d794ac88e447 Author: Ralph Boehme Date: Fri Apr 3 08:01:45 2020 +0200 smbd: move files_struct.backup_intent to a bitfield Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit 049488f6a51ffd151cf5588b59cc3784b80b7ba0 Author: Ralph Boehme Date: Fri Apr 3 07:52:10 2020 +0200 smbd: move files_struct.is_sparse to a bitfield Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit 930b7525a669b96231c2bcd72bccf7e4aa4601ed Author: Ralph Boehme Date: Fri Apr 3 07:48:08 2020 +0200 smbd: move files_struct.delete_on_close to a bitfield Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit b0824cf35feb893db9e7ec33aced8194279b1daf Author: Ralph Boehme Date: Fri Apr 3 07:43:38 2020 +0200 smbd: move files_struct.initial_delete_on_close to a bitfield Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit 1ccd335af5d6c6c16d9ab46102b506798bb283fa Author: Ralph Boehme Date: Fri Apr 3 07:39:34 2020 +0200 smbd: move files_struct.aio_write_behind to a bitfield Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit cb996cd5a3570e1cd6bf92776acd7c8cd22ebbfd Author: Ralph Boehme Date: Thu Apr 2 18:21:11 2020 +0200 smbd: move files_struct.is_directory to a bitfield Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit 65a4302474d1e6678ea6d258f981c4fc139aeeb4 Author: Ralph Boehme Date: Thu Apr 2 17:37:02 2020 +0200 smbd: move files_struct.modified to a bitfield Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit b95c62bc90cef5cbb5525c92788eca9641944268 Author: Ralph Boehme Date: Thu Apr 2 17:28:32 2020 +0200 smbd: move
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 23349f9d2c2 selftest: Add list of tests to be ported via 182635bb78b selftest: Don't skip smb1 tests and remove associate skip file via 1840e96597a selftest: Create instructions for generating skip file entries via adba4165a56 selftest/knownfail.d: samba3.blackbox.smbclient_basic.NT1.smbclient via e7b4b349069 selftest/knownfail.d: Add samba4.blackbox.smbclient via 84ba205d1df selftest/knownfail.d: Add samba4.smb.signing disabled via eafdbba6e1f selftest/knownfail.d: Add entries for samba3.unix.whoami via 0721eed9727 selftest/knownfail.d: Add samba3.blackbox.smbclient_s3.NT1 via ecaaef4ff7e selftest/knownfail.d knownfail samba3.blackbox.smbclient_auth.plain via 6d67a89a88c selftest/knownfail.d Add samba3.blackbox.smbclient_ntlm.plain (NT1) via 04639604882 s4/selftest: Move samba4.rpc.join tests to ad_dc_default_smb1 via e362ad23ee6 s4/selftest: Move samba4.ldap.passwordsettings to ad_dc_default_smb1 via 15536417247 s4/selftest: Move samba4.ldap.nested-search to ad_dc_default_smb1 via c83fafacbb6 s4/selftest: Modify samba4.blackbox.chgdcpass to use smbclient(s3) via 89476feec1c s3/selftest: Move samba3.smbtorture_s3.vfs_aio* to fileserver_smb1 via 58623e53485 selftest: Modify fileserver_smb1 with vfs_aio params via 07ccb8c70bb s3/selftest: Move samba3.smbtorture_s3.hidenewfiles to fileserver_smb1 via f7456c8be9c selftest: Add 'hide new files timeout' related data to fileserver_smb1 via 9161cf7495c s3/selftest: Move tests raw.samba3hide, raw.samba3checkfsp & raw.samba3closeerr via 2b1cca4c514 s3/selftest: Move tests raw.samba3hide, raw.samba3checkfsp & raw.samba3closeerr via 65aa21b8e7d s3/selftest Move samba3.smbtorture_s3.plain.RENAME-ACCESS to nt4_dc_smb1 via aa688a8de69 s4/selftest: Move samba.tests.libsmb to nt4_dc_smb1 via 628ff67b723 s3/selftest: Move samba3.unix.whoami to nt4_dc_smb1 via 6820a8cd9a3 s3/selftest Move samba3.smbtorture_s3.plain.MANGLE-ILLEGAL to ad_dc_smb1 via 2668459b90b s3/selftest: Move samba3.smbtorture_s3.plain.POSIX* to nt4_dc_smb1 via 63784fd6ef8 s3/selftest: Move samba3.smbtorture_s3.crypt.POSIX* to nt4_dc_smb1 via a78f7478673 s3/selftest: Move samba3.smbtorture_s3.crypt_server.TORTURE to nt4_dc_smb1 via a20ad8674bc s3/selftest: Move samba3.smbtorture_s3.crypt_client.* to nt4_dc_smb1 via b527816cc9d s3/selftest: Move rpc.samba3.netlogon & rpc.samba3.sessionkey to nt4_dc_smb1 via a762e8c6739 s3/selftest: Move samba3.rpc.lsa.lookupsids to nt4_dc_smb1 via 29c340bcaff s3/selftest: Move samba3.raw.session to nt4_dc_smb1 via 3a9e6782bf8 s3/selftest: Move samba3.raw.search to nt4_dc_smb1 via 9fa64617709 s3/selftest: Move samba3.raw.samba3posixtimedlock to nt4_dc_smb1 via fce023d649f s3/selftest: Move samba3.raw.samba3posixtimedlock to ad_dc_smb1 via 3fd9c4ac092 s3/selftest: Prep commit split handling for raw.samba3posixtimedlock via 9fab393a9c3 s3/selftest: Move raw.samba3checkfsp, raw.samba3hide & raw.samba3closeerr via 4d9506deae8 s3/selftest Move samba.raw.read to nt4_dc_smb1 via e4bdeabf1d4 s3/selftest: Move samba3.raw.notify & samba3.raw.oplock to nt4_dc_smb1 via be21c8b76a3 s3/selftest: Use variable for test env rather than hardcoding via f35120b0286 s3/selftest: Move samba3.raw.chkpath to nt4_dc_smb1 via c9b13ca09fc s3/selftest: Move samba3.raw.acls* to nt4_dc_smb1 via 718fea5cd8c s3/selftest: Move samba3.blackbox.smbclient_s3.NT1.sign to nt4_dc_smb1 via bcca2563416 s3/selftest: Remove unnecssary for loop via 227095bb790 s3/selftest: Move samba3.blackbox.smbclient_ntlm.plain to nt4_dc_smb1 via e848ad1232c s3/selftest: Move samba3.rap.sam to nt4_dc_smb1 via 18ffea5e895 s3/selftest: Move samba3.blackbox.smbclient_large_file*NT1 to nt4_dc_smb1 via f9b1ef8eff1 s3/selftest: Move samba3.blackbox.smbclient_s3.NT1.plain to nt4_dc_smb1 via da0dc866b37 s3/selftest: Remove unnecessary for loop via 691ef77fe88 s3/selftest: Move samba3.blackbox.smbclient_s3.NT1.crypt to nt4_dc_smb1 via c8ddcc822a8 s3/selftest: Remove unnecessary 'for' loop via 0c88b2b1f85 s3/selftest: Move samba3.blackbox.smbclient_auth.plain to _smb1_done via dd7218371a2 s3/selftest: Move samba3.base.rw1 to nt4_dc_smb1 via b05f3476955 s3/selftest: Move samba3.raw.lock & samba3.base.lock to nt4_dc_smb1 via 572bc3e643c s4/selftest: Adjust samba4.blackbox.pkinit to use (s3) smbclient via 4c924893831 s4/selftest: Move samba.tests.net_join_no_spnego to ad_dc_smb1 via 6edb46682df s4/selftest: Move samba.tests.auth_log_pass_change to ad_dc_smb1 via fc1121bc6ba s4/selftest: Move samba.tests.auth_log to
[SCM] Samba Shared Repository - branch v4-12-test updated
The branch, v4-12-test has been updated
via b82cec52708 s3/utils: Fix double free error with smbtree
from 784e4266787 nsswitch: fix use-after-free causing segfault in
_pam_delete_cred
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-12-test
- Log -
commit b82cec527084f826670cb66d0ab3dbae7783dae7
Author: Noel Power
Date: Wed Apr 1 12:26:09 2020 +0100
s3/utils: Fix double free error with smbtree
==3632==
WORKGROUP
\\ATP
\\ATP\IPC$ IPC Service ()
==3632== Invalid read of size 8
==3632==at 0x773C926: poptResetContext (in /usr/lib64/libpopt.so.0.0.0)
==3632==by 0x773E5DD: poptFreeContext (in /usr/lib64/libpopt.so.0.0.0)
==3632==by 0x10A8BC: main (smbtree.c:354)
==3632== Address 0x16085e00 is 640 bytes inside a block of size 784 free'd
==3632==at 0x4C2F1AD: free (vg_replace_malloc.c:530)
==3632==by 0x773E6F7: poptFreeContext (in /usr/lib64/libpopt.so.0.0.0)
==3632==by 0x10A84B: main (smbtree.c:342)
==3632== Block was alloc'd at
==3632==at 0x4C2FE45: calloc (vg_replace_malloc.c:711)
==3632==by 0x773C79A: poptGetContext (in /usr/lib64/libpopt.so.0.0.0)
==3632==by 0x10A829: main (smbtree.c:339)
==3632==
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14332
Signed-off-by: Noel Power
Reviewed-by: Volker Lendecke
Autobuild-User(master): Noel Power
Autobuild-Date(master): Wed Apr 1 18:51:43 UTC 2020 on sn-devel-184
(cherry picked from commit 24b03fd28ed19cea8f875f96b3e300f808dfc4ae)
Autobuild-User(v4-12-test): Karolin Seeger
Autobuild-Date(v4-12-test): Fri Apr 3 12:24:36 UTC 2020 on sn-devel-184
---
Summary of changes:
source3/utils/smbtree.c | 1 -
1 file changed, 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source3/utils/smbtree.c b/source3/utils/smbtree.c
index 8e4caf0e80b..626279a96fd 100644
--- a/source3/utils/smbtree.c
+++ b/source3/utils/smbtree.c
@@ -339,7 +339,6 @@ int main(int argc, char *argv[])
pc = poptGetContext("smbtree", argc, argv_const, long_options,
POPT_CONTEXT_KEEP_FIRST);
while(poptGetNextOpt(pc) != -1);
- poptFreeContext(pc);
popt_burn_cmdline_password(argc, argv);
/* Now do our stuff */
--
Samba Shared Repository
