[SCM] Samba Shared Repository - branch v4-15-test updated

2022-06-09 Thread Jule Anger
The branch, v4-15-test has been updated
   via  a9e40509704 lib/util/gpfswrap: remove unused 
gpfswrap_get_winattrs_path()
   via  948e6556979 vfs_gpfs: use handle based gpfswrap_get_winattrs()
   via  e387fb3202f lib/util/gpfswrap: remove unused gpfswrap_getacl()
   via  3b2cdf5dcdf vfs_gpfs: finally: use gpfswrap_fgetacl() instead of 
gpfswrap_getacl()
   via  4d21f10b32d lib/util/gpfswrap: add gpfswrap_fgetacl()
   via  6510b35db19 vfs_gpfs: pass fsp to gpfs_getacl_with_capability()
   via  85ea14d57e5 vfs_gpfs: pass fsp to vfs_gpfs_getacl()
   via  06e554b22e2 vfs_gpfs: use fsp in gpfsacl_get_posix_acl()
   via  59154a47398 vfs_gpfs: pass fsp to gpfsacl_get_posix_acl()
   via  7ae1fdcbb2f vfs_gpfs: pass fsp to gpfs_get_nfs4_acl()
   via  ae7e33885d7 vfs_gpfs: pass fsp to gpfsacl_emu_chmod()
   via  d8ad3e216e8 vfs_gpfs: indentation and README.Coding fixes
  from  c53efe8b481 s3:libads: Clear previous CLDAP ping flags when reusing 
the ADS_STRUCT

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-15-test


- Log -
commit a9e405097041e962ceecaacf2f4dd0340fbc7ca0
Author: Ralph Boehme 
Date:   Tue May 17 16:52:21 2022 +0200

lib/util/gpfswrap: remove unused gpfswrap_get_winattrs_path()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Jun  3 21:53:31 UTC 2022 on sn-devel-184

(cherry picked from commit 3bd753983c8dac33b483affa859984b7e3350d65)

Autobuild-User(v4-15-test): Jule Anger 
Autobuild-Date(v4-15-test): Thu Jun  9 09:53:47 UTC 2022 on sn-devel-184

commit 948e6556979d033bab07652d1511a3a40fdb5824
Author: Ralph Boehme 
Date:   Tue May 17 16:32:23 2022 +0200

vfs_gpfs: use handle based gpfswrap_get_winattrs()

Fixes detecting offline flag for files in snapshot – no idea if this is
actually expected.

Replaces path based gpfswrap_get_winattrs_path() with handle based version
gpfswrap_get_winattrs(). When dealing with files in snapshots fsp->fsp_name
points to the active dataset, which will cause ENOENT failures if files are
deleted there any only present in the snapshot.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 
(cherry picked from commit 8ae672f955bf07bb97f38b7d2f965f14e8315e9e)

commit e387fb3202f55db86209fe4d53c71497256f83ea
Author: Ralph Boehme 
Date:   Tue May 17 16:27:58 2022 +0200

lib/util/gpfswrap: remove unused gpfswrap_getacl()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 
(cherry picked from commit 9172c5ff6a419e4daef451564650d4a3ce96bfae)

commit 3b2cdf5dcdf26f3c64bbb4814ab19442da78d352
Author: Ralph Boehme 
Date:   Tue May 17 16:02:10 2022 +0200

vfs_gpfs: finally: use gpfswrap_fgetacl() instead of gpfswrap_getacl()

Replaces path based gpfswrap_getacl() with handle based version
gpfswrap_fgetacl(). When dealing with files in snapshots fsp->fsp_name 
points to
the active dataset, which will cause ENOENT failures if files are deleted 
there
any only present in the snapshot:

[2022/05/06 11:32:55.233435,  4, pid=12962, effective(1460548, 273710), 
real(1460548, 0)]
   calling open_file with flags=0x0 flags2=0x800 mode=0644, access_mask = 
0x80, open_access_mask = 0x80
[2022/05/06 11:32:55.233460, 10, pid=12962, effective(1460548, 273710), 
real(1460548, 0), class=vfs]
   gpfs_get_nfs4_acl invoked for dir/subdir/file.txt
[2022/05/06 11:32:55.233495,  5, pid=12962, effective(1460548, 273710), 
real(1460548, 0), class=vfs]
   smbd_gpfs_getacl failed with No such file or directory
[2022/05/06 11:32:55.233521,  9, pid=12962, effective(1460548, 273710), 
real(1460548, 0), class=vfs]
   gpfs_getacl failed for dir/subdir/file.txt with No such file or directory
[2022/05/06 11:32:55.233546, 10, pid=12962, effective(1460548, 273710), 
real(1460548, 0)]
   smbd_check_access_rights_fsp: Could not get acl on dir/subdir/file.txt 
{@GMT-2022.05.04-11.58.53}: NT_STATUS_OBJECT_NAME_NOT_FOUND

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 
(cherry picked from commit a0dc4c9026519c949070dc001e7addad7c7d35ce)

commit 4d21f10b32d009e66e318837ebf47294dc324681
Author: Ralph Boehme 
Date:   Tue May 17 15:43:39 2022 +0200

lib/util/gpfswrap: add gpfswrap_fgetacl()

Adds handle based version of gpfswrap_getacl().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 
(cherry picked from commit d373ff3c01c2c50cd539b78494c0673974a0f046)

[SCM] Samba Shared Repository - branch v4-16-test updated

2022-06-09 Thread Jule Anger
The branch, v4-16-test has been updated
   via  1397656cebf s3:printing: Start samba-bgqd as soon as possible
   via  8507fa6fc7d s3:printing: Initialize the printcap cache as soon as 
the bgqd starts
   via  c3ce1fec590 lib/util/gpfswrap: remove unused 
gpfswrap_get_winattrs_path()
   via  b8cc300d226 vfs_gpfs: use handle based gpfswrap_get_winattrs()
   via  72ef38a9747 lib/util/gpfswrap: remove unused gpfswrap_getacl()
   via  bdb2714671f vfs_gpfs: finally: use gpfswrap_fgetacl() instead of 
gpfswrap_getacl()
   via  1d4f8f3e472 lib/util/gpfswrap: add gpfswrap_fgetacl()
   via  069354e7480 vfs_gpfs: pass fsp to gpfs_getacl_with_capability()
   via  bce1de5580f vfs_gpfs: pass fsp to vfs_gpfs_getacl()
   via  a039780c01c vfs_gpfs: use fsp in gpfsacl_get_posix_acl()
   via  d9222188190 vfs_gpfs: pass fsp to gpfsacl_get_posix_acl()
   via  f752c389740 vfs_gpfs: pass fsp to gpfs_get_nfs4_acl()
   via  2a50ba5ae19 vfs_gpfs: pass fsp to gpfsacl_emu_chmod()
   via  ea39a8894a2 vfs_gpfs: indentation and README.Coding fixes
  from  e3de2bdb859 s3/client: Restore '-E' handling

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-16-test


- Log -
commit 1397656cebf2cdd00a28727ec8f4b65308106440
Author: Andreas Schneider 
Date:   Tue May 31 08:35:00 2022 +0200

s3:printing: Start samba-bgqd as soon as possible

We need some time to fill the printcap cache.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15081

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 
(cherry picked from commit ac16351ff5a0c5b46f461c26516b85e8483bba83)

Autobuild-User(v4-16-test): Jule Anger 
Autobuild-Date(v4-16-test): Thu Jun  9 10:03:29 UTC 2022 on sn-devel-184

commit 8507fa6fc7daa29746ed81578669070a32bd0427
Author: Andreas Schneider 
Date:   Mon May 30 17:22:21 2022 +0200

s3:printing: Initialize the printcap cache as soon as the bgqd starts

As soon as the background daemon starts, we need to initialize the
printcap cache so that rpcd-spoolssd can serve printers.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15081

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 
(cherry picked from commit 3b5b80e99603e4c1d4d1080ed45bd75116a9fa8e)

commit c3ce1fec590d95a2d848bce52b059784eeda430a
Author: Ralph Boehme 
Date:   Tue May 17 16:52:21 2022 +0200

lib/util/gpfswrap: remove unused gpfswrap_get_winattrs_path()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Jun  3 21:53:31 UTC 2022 on sn-devel-184

(cherry picked from commit 3bd753983c8dac33b483affa859984b7e3350d65)

commit b8cc300d226fe6a04ce26d6f91fcd484e4f0403a
Author: Ralph Boehme 
Date:   Tue May 17 16:32:23 2022 +0200

vfs_gpfs: use handle based gpfswrap_get_winattrs()

Fixes detecting offline flag for files in snapshot – no idea if this is
actually expected.

Replaces path based gpfswrap_get_winattrs_path() with handle based version
gpfswrap_get_winattrs(). When dealing with files in snapshots fsp->fsp_name
points to the active dataset, which will cause ENOENT failures if files are
deleted there any only present in the snapshot.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 
(cherry picked from commit 8ae672f955bf07bb97f38b7d2f965f14e8315e9e)

commit 72ef38a9747b576c6640e9b43f7b70e37f5839cb
Author: Ralph Boehme 
Date:   Tue May 17 16:27:58 2022 +0200

lib/util/gpfswrap: remove unused gpfswrap_getacl()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15069

Signed-off-by: Ralph Boehme 
Reviewed-by: Christof Schmitt 
(cherry picked from commit 9172c5ff6a419e4daef451564650d4a3ce96bfae)

commit bdb2714671f5ee168c07d9ab3c549fd7532a5a45
Author: Ralph Boehme 
Date:   Tue May 17 16:02:10 2022 +0200

vfs_gpfs: finally: use gpfswrap_fgetacl() instead of gpfswrap_getacl()

Replaces path based gpfswrap_getacl() with handle based version
gpfswrap_fgetacl(). When dealing with files in snapshots fsp->fsp_name 
points to
the active dataset, which will cause ENOENT failures if files are deleted 
there
any only present in the snapshot:

[2022/05/06 11:32:55.233435,  4, pid=12962, effective(1460548, 273710), 
real(1460548, 0)]
   calling open_file with flags=0x0 flags2=0x800 mode=0644, access_mask = 
0x80, open_access_mask = 0x80
[2022/05/06 11:32:55.233460, 10, pid=12962, effective(1460548, 273710), 
real(1460548, 0), class=vfs]
   gpfs_get_nfs4_acl invoked for dir/subdir/file.txt
[2022/05/06 11:32:55.233495,  5, pid=12962, effective(1460548, 273710), 
real(1460548, 0), class=vfs]
   sm

[SCM] Samba Shared Repository - branch v4-16-test updated

2022-06-09 Thread Jule Anger
The branch, v4-16-test has been updated
   via  bb60c85153b s3:smbd: Out-by-4 error in smbd read reply max_send 
clamp
  from  1397656cebf s3:printing: Start samba-bgqd as soon as possible

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-16-test


- Log -
commit bb60c85153b288b358d288b3ee9f4bceb1304e20
Author: Robert Sprowson 
Date:   Sun Jul 19 12:59:00 2020 +0100

s3:smbd: Out-by-4 error in smbd read reply max_send clamp

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14443

Signed-off-by: Robert Sprowson 
Reviewed-by: Jeremy Allison 
Reviewed-by: Noel Power 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Jun  8 19:50:08 UTC 2022 on sn-devel-184

(cherry picked from commit 174a76cc27f25120af5a86bee3f26d9afad87d8f)

Autobuild-User(v4-16-test): Jule Anger 
Autobuild-Date(v4-16-test): Thu Jun  9 11:14:52 UTC 2022 on sn-devel-184

---

Summary of changes:
 source3/smbd/reply.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index 40313f3209c..d4573d3da55 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -3853,7 +3853,7 @@ static void reply_lockread_locked(struct tevent_req 
*subreq)
/*
 * However the requested READ size IS affected by max_send. 
Insanity JRA.
 */
-   maxtoread = req->xconn->smb1.sessions.max_send - (smb_size + 5*2 + 3);
+   maxtoread = req->xconn->smb1.sessions.max_send - (MIN_SMB_SIZE + 5*2 + 
3);
 
if (numtoread > maxtoread) {
DBG_WARNING("requested read size (%zu) is greater than "
@@ -3949,7 +3949,7 @@ void reply_read(struct smb_request *req)
/*
 * The requested read size cannot be greater than max_send. JRA.
 */
-   maxtoread = xconn->smb1.sessions.max_send - (smb_size + 5*2 + 3);
+   maxtoread = xconn->smb1.sessions.max_send - (MIN_SMB_SIZE + 5*2 + 3);
 
if (numtoread > maxtoread) {
DEBUG(0,("reply_read: requested read size (%u) is greater than 
maximum allowed (%u/%u). \


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - branch v4-16-test updated

2022-06-09 Thread Stefan Metzmacher
The branch, v4-16-test has been updated
   via  56eca407415 ldb: version 2.5.1
  from  bb60c85153b s3:smbd: Out-by-4 error in smbd read reply max_send 
clamp

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-16-test


- Log -
commit 56eca407415dd7c69cde7e66f02f0c95d419721a
Author: Stefan Metzmacher 
Date:   Thu Jun 9 06:49:31 2022 +0200

ldb: version 2.5.1

* Fix build problems

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15071

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider 

Autobuild-User(v4-16-test): Stefan Metzmacher 
Autobuild-Date(v4-16-test): Thu Jun  9 12:14:04 UTC 2022 on sn-devel-184

---

Summary of changes:
 lib/ldb/ABI/{ldb-2.0.5.sigs => ldb-2.5.1.sigs}   | 0
 lib/ldb/ABI/{pyldb-util-2.1.0.sigs => pyldb-util-2.5.1.sigs} | 0
 lib/ldb/wscript  | 2 +-
 3 files changed, 1 insertion(+), 1 deletion(-)
 copy lib/ldb/ABI/{ldb-2.0.5.sigs => ldb-2.5.1.sigs} (100%)
 copy lib/ldb/ABI/{pyldb-util-2.1.0.sigs => pyldb-util-2.5.1.sigs} (100%)


Changeset truncated at 500 lines:

diff --git a/lib/ldb/ABI/ldb-2.0.5.sigs b/lib/ldb/ABI/ldb-2.5.1.sigs
similarity index 100%
copy from lib/ldb/ABI/ldb-2.0.5.sigs
copy to lib/ldb/ABI/ldb-2.5.1.sigs
diff --git a/lib/ldb/ABI/pyldb-util-2.1.0.sigs 
b/lib/ldb/ABI/pyldb-util-2.5.1.sigs
similarity index 100%
copy from lib/ldb/ABI/pyldb-util-2.1.0.sigs
copy to lib/ldb/ABI/pyldb-util-2.5.1.sigs
diff --git a/lib/ldb/wscript b/lib/ldb/wscript
index b811b68861f..f483dd54748 100644
--- a/lib/ldb/wscript
+++ b/lib/ldb/wscript
@@ -2,7 +2,7 @@
 
 APPNAME = 'ldb'
 # For Samba 4.16.x
-VERSION = '2.5.0'
+VERSION = '2.5.1'
 
 import sys, os
 


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - annotated tag ldb-2.5.1 created

2022-06-09 Thread Stefan Metzmacher
The annotated tag, ldb-2.5.1 has been created
at  f67c0845ffde6ad7d9e8e9520657bf7b427550fb (tag)
   tagging  56eca407415dd7c69cde7e66f02f0c95d419721a (commit)
  replaces  samba-4.16.1
 tagged by  Stefan Metzmacher
on  Thu Jun 9 16:16:15 2022 +0200

- Log -
ldb: tag release ldb-2.5.1
-BEGIN PGP SIGNATURE-

iQEzBAABCgAdFiEEkUejOXGVGO6QEby1R5ORYRMIQCUFAmKiAK8ACgkQR5ORYRMI
QCWS/ggAt8E0vhvwM/qtPCusznRMQNDtORTzOj6H5NqjGUNP+5Q4R3rDrvMDSneN
KLlE0zciNIR4UI+NsdCiOspAsvJ/qGgI42yJUGgywvwFPwEbuw4hsjn1VUZv734T
3xYEdmThmzciqYNzSpwxlMoQS5dNf/tXqZr/Eb82k3p7qMrINmUCI56xgB5HWW1a
yLtLBRn7ahkDC8Rn48B4hlK/hcGk1lneNwRc1pIg3+83LBXVrr3mU9RZYW1g0pcu
5G8GponQBYE7x811vTbB5pEc+ddp5e+oJQc1Wo8whr7vGUfbuIutKaANzBqVBYSa
MaKu5SnSI/qMhx9EgtZVNYJ4CxisQg==
=Jpcg
-END PGP SIGNATURE-

Andreas Schneider (5):
  third_party:waf: Print the version of waf at the end of the update script
  third_party: Update waf to verison 2.0.23
  third_party: Update waf to version 2.0.24
  s3:printing: Initialize the printcap cache as soon as the bgqd starts
  s3:printing: Start samba-bgqd as soon as possible

Jeremy Allison (2):
  s4: torture: Add a new test - samba3.smb2.durable-open.stat-open.
  s3: smbd: Allow a durable handle on a leased stat-open.

Jule Anger (1):
  VERSION: Bump version up to Samba 4.16.2...

Noel Power (2):
  s3/script/tests: Test smbclient -E redirects output to stderr
  s3/client: Restore '-E' handling

Ralph Boehme (12):
  vfs_gpfs: indentation and README.Coding fixes
  vfs_gpfs: pass fsp to gpfsacl_emu_chmod()
  vfs_gpfs: pass fsp to gpfs_get_nfs4_acl()
  vfs_gpfs: pass fsp to gpfsacl_get_posix_acl()
  vfs_gpfs: use fsp in gpfsacl_get_posix_acl()
  vfs_gpfs: pass fsp to vfs_gpfs_getacl()
  vfs_gpfs: pass fsp to gpfs_getacl_with_capability()
  lib/util/gpfswrap: add gpfswrap_fgetacl()
  vfs_gpfs: finally: use gpfswrap_fgetacl() instead of gpfswrap_getacl()
  lib/util/gpfswrap: remove unused gpfswrap_getacl()
  vfs_gpfs: use handle based gpfswrap_get_winattrs()
  lib/util/gpfswrap: remove unused gpfswrap_get_winattrs_path()

Robert Sprowson (1):
  s3:smbd: Out-by-4 error in smbd read reply max_send clamp

Samuel Cabrero (1):
  s3:libads: Clear previous CLDAP ping flags when reusing the ADS_STRUCT

Stefan Metzmacher (1):
  ldb: version 2.5.1

Volker Lendecke (3):
  selftest: Test for bug 15062 -- list "username" in netshareenum
  srvsvc: Add a central return point to init_srv_share_info_ctr()
  srvsvc: Announce [username] in NetShareEnum

---


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - branch v4-15-test updated

2022-06-09 Thread Stefan Metzmacher
The branch, v4-15-test has been updated
   via  604f94704f3 ldb: version 2.3.4
   via  f3879b3f09d s3:utils: Fix format error
  from  a9e40509704 lib/util/gpfswrap: remove unused 
gpfswrap_get_winattrs_path()

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-15-test


- Log -
commit 604f94704f30e90ef960aa2be62a14d2e614a002
Author: Stefan Metzmacher 
Date:   Thu Jun 9 06:48:14 2022 +0200

ldb: version 2.3.4

* Fix build problems

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15071

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider 

Autobuild-User(v4-15-test): Stefan Metzmacher 
Autobuild-Date(v4-15-test): Thu Jun  9 15:02:57 UTC 2022 on sn-devel-184

commit f3879b3f09d288170fb742ef90d52c582e44a58a
Author: Andreas Schneider 
Date:   Fri Oct 1 10:46:09 2021 +0200

s3:utils: Fix format error

regedit_hexedit.c:166:39: error: format ‘%X’ expects argument of type 
‘unsigned
int’, but argument 3 has type ‘size_t’ {aka ‘long unsigned int’}
  166 | wprintw(buf->win, "%08X  ", off);
  |~~~^ ~~~
  |   | |
  |   | size_t {aka long 
unsigned int}
  |   unsigned int
  |%08lX

Signed-off-by: Andreas Schneider 
Reviewed-by: Uri Simchoni 

(cherry picked from commit cc3081cebfb65181cd291702cb6a2e727dc999b2)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15091
Reviewed-by: Stefan Metzmacher 

---

Summary of changes:
 lib/ldb/ABI/{ldb-2.0.5.sigs => ldb-2.4.3.sigs}   | 0
 lib/ldb/ABI/{pyldb-util-2.1.0.sigs => pyldb-util-2.4.3.sigs} | 0
 lib/ldb/wscript  | 2 +-
 source3/utils/regedit_hexedit.c  | 2 +-
 4 files changed, 2 insertions(+), 2 deletions(-)
 copy lib/ldb/ABI/{ldb-2.0.5.sigs => ldb-2.4.3.sigs} (100%)
 copy lib/ldb/ABI/{pyldb-util-2.1.0.sigs => pyldb-util-2.4.3.sigs} (100%)


Changeset truncated at 500 lines:

diff --git a/lib/ldb/ABI/ldb-2.0.5.sigs b/lib/ldb/ABI/ldb-2.4.3.sigs
similarity index 100%
copy from lib/ldb/ABI/ldb-2.0.5.sigs
copy to lib/ldb/ABI/ldb-2.4.3.sigs
diff --git a/lib/ldb/ABI/pyldb-util-2.1.0.sigs 
b/lib/ldb/ABI/pyldb-util-2.4.3.sigs
similarity index 100%
copy from lib/ldb/ABI/pyldb-util-2.1.0.sigs
copy to lib/ldb/ABI/pyldb-util-2.4.3.sigs
diff --git a/lib/ldb/wscript b/lib/ldb/wscript
index c470f854b99..312879449e1 100644
--- a/lib/ldb/wscript
+++ b/lib/ldb/wscript
@@ -2,7 +2,7 @@
 
 APPNAME = 'ldb'
 # For Samba 4.15.x
-VERSION = '2.4.2'
+VERSION = '2.4.3'
 
 import sys, os
 
diff --git a/source3/utils/regedit_hexedit.c b/source3/utils/regedit_hexedit.c
index 383736ae2bc..413e563f653 100644
--- a/source3/utils/regedit_hexedit.c
+++ b/source3/utils/regedit_hexedit.c
@@ -163,7 +163,7 @@ void hexedit_refresh(struct hexedit *buf)
size_t i, endline;
 
wmove(buf->win, lineno, 0);
-   wprintw(buf->win, "%08X  ", off);
+   wprintw(buf->win, "%08zX  ", off);
 
endline = BYTES_PER_LINE;
 


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - annotated tag ldb-2.4.3 created

2022-06-09 Thread Stefan Metzmacher
The annotated tag, ldb-2.4.3 has been created
at  613ebcd9199736e0c991714bf4786e3e02872589 (tag)
   tagging  604f94704f30e90ef960aa2be62a14d2e614a002 (commit)
  replaces  samba-4.15.7
 tagged by  Stefan Metzmacher
on  Thu Jun 9 17:35:25 2022 +0200

- Log -
ldb: tag release ldb-2.4.3
-BEGIN PGP SIGNATURE-

iQEzBAABCgAdFiEEkUejOXGVGO6QEby1R5ORYRMIQCUFAmKiEz0ACgkQR5ORYRMI
QCUdOgf/UYQ74dDs/8IeaPEvmAYLPKKnHo4S5Drx6Lmc4nWULPGA+RAUuajJ4HG+
6ybX2+BwSYHluKqiakHueMT06+aOk1/N2FKF9bNUiFBsbmbwaX9x6aRj4LxuRY9I
1HbnxSuqpFxBM7zo6DGPV/1AZXR8maf1VQZb/ZMBbvlwQwRB0w+/qGZuAw89/LA2
aMXxABM3XGBCQb0B3ng4zglkkNNF08TT4z2lUwUOqOvAEt7o3b/ABVN7W5Jj/P0Y
1y1KfPWyIQEll8LJ49MhavFqUmKq8iJ08zBHDB2HYF2YEKwEl7keQuXovMIgxCHO
GM1ysULaZ4zXduGXhbfTW5azFyu3Sg==
=KWhM
-END PGP SIGNATURE-

Andreas Schneider (11):
  s3:passdb: Remove trailing spaces in lookup_sid.c
  s3:passdb: Add support to handle UPNs in lookup_name()
  s3:passdb: Use already defined pointer in lookup_name_smbconf()
  s3:passdb: Refactor lookup_name_smbconf()
  s3:passdb: Also allow to handle UPNs in lookup_name_smbconf()
  third_party: Add a script to update waf
  third_party: Update waf to version 2.0.22
  third_party:waf: Print the version of waf at the end of the update script
  third_party: Update waf to verison 2.0.23
  third_party: Update waf to version 2.0.24
  s3:utils: Fix format error

Christof Schmitt (1):
  vfs_gpfs: Ignore pathref fds for gpfs:recalls check

Jeremy Allison (2):
  s4: torture: Add a new test - samba3.smb2.durable-open.stat-open.
  s3: smbd: Allow a durable handle on a leased stat-open.

Jule Anger (1):
  VERSION: Bump version up to Samba 4.15.8...

Ralph Boehme (12):
  vfs_gpfs: indentation and README.Coding fixes
  vfs_gpfs: pass fsp to gpfsacl_emu_chmod()
  vfs_gpfs: pass fsp to gpfs_get_nfs4_acl()
  vfs_gpfs: pass fsp to gpfsacl_get_posix_acl()
  vfs_gpfs: use fsp in gpfsacl_get_posix_acl()
  vfs_gpfs: pass fsp to vfs_gpfs_getacl()
  vfs_gpfs: pass fsp to gpfs_getacl_with_capability()
  lib/util/gpfswrap: add gpfswrap_fgetacl()
  vfs_gpfs: finally: use gpfswrap_fgetacl() instead of gpfswrap_getacl()
  lib/util/gpfswrap: remove unused gpfswrap_getacl()
  vfs_gpfs: use handle based gpfswrap_get_winattrs()
  lib/util/gpfswrap: remove unused gpfswrap_get_winattrs_path()

Samuel Cabrero (1):
  s3:libads: Clear previous CLDAP ping flags when reusing the ADS_STRUCT

Stefan Metzmacher (1):
  ldb: version 2.3.4

---


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - branch master updated

2022-06-09 Thread Jeremy Allison
The branch, master has been updated
   via  ef1d04762af s3:smbd: Free allocated strings before leaving 
user_in_netgroup() function
   via  b3034f1209a Revert "lib:util: Remove NIS support from 
string_match()"
   via  21796ef8f80 Revert "s3:smbd: Remove NIS support"
   via  f74e284a9d7 Revert "docs-xml: Update documentation for removal of 
NIS support"
   via  dbf3d217e34 Revert "s3:auth: Fix user_in_list() for UNIX groups"
  from  174a76cc27f s3:smbd: Out-by-4 error in smbd read reply max_send 
clamp

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit ef1d04762afb6dd54ffb01020b7bf3236c86be0f
Author: Samuel Cabrero 
Date:   Tue Jun 7 11:06:04 2022 +0200

s3:smbd: Free allocated strings before leaving user_in_netgroup() function

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Jun  9 22:40:43 UTC 2022 on sn-devel-184

commit b3034f1209a6c45873882415c4291dde7eee76db
Author: Samuel Cabrero 
Date:   Fri Jun 3 17:48:21 2022 +0200

Revert "lib:util: Remove NIS support from string_match()"

This partly reverts commit 620de975f147ac9427b51ea0e1e3eabda443d4b6.

Drop chunk including system/nis.h, drop wscript_build modifications,
use getdomainname() from glibc instead of yp_get_default_domain() from
libnsl.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15087

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison 

commit 21796ef8f807d88e01627dc993b757e251788980
Author: Samuel Cabrero 
Date:   Fri Jun 3 15:07:18 2022 +0200

Revert "s3:smbd: Remove NIS support"

This partly reverts commit edda7a329e5bed442418de9782cec9f567092aae.

Revert the chunks related to netgroups and skip NIS support related ones.
Use getdomainname() from glibc instead of yp_get_default_domain() from
libnsl to get the NIS domain name.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15087

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison 

commit f74e284a9d7fa8dc45f22b70dcea27f1aa8bd232
Author: Samuel Cabrero 
Date:   Fri Jun 3 14:12:01 2022 +0200

Revert "docs-xml: Update documentation for removal of NIS support"

This partly reverts commit a72bc3e15d3ed62e9ad2c0a97ce5d6d653abb048.

Revert only the chunks related to netgroups and skip NIS related ones.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15087

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison 

commit dbf3d217e3424fae64d9bd00e4762dc4d2bda6c2
Author: Samuel Cabrero 
Date:   Fri Jun 3 14:01:36 2022 +0200

Revert "s3:auth: Fix user_in_list() for UNIX groups"

This partly reverts commit 6dc463d3e2eb229df1c4f620cfcaf22ac71738d4.

Reverted to allow next revert commits to apply cleanly. Do not recreate
selftest/knownfail.d/usernamemap file.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15087

Signed-off-by: Samuel Cabrero 
Reviewed-by: Jeremy Allison 

---

Summary of changes:
 docs-xml/smbdotconf/security/hostsallow.xml  |   7 ++
 docs-xml/smbdotconf/security/invalidusers.xml|  15 ++-
 docs-xml/smbdotconf/security/usernamemap.xml |   5 +
 docs-xml/smbdotconf/security/validusers.xml  |   7 +-
 docs-xml/smbdotconf/winbind/winbindseparator.xml |   4 +-
 lib/util/access.c|  56 +
 selftest/target/Samba3.pm|   4 +
 source3/auth/user_util.c | 142 +++
 source3/script/tests/test_smbclient_s3.sh|  13 +++
 source3/smbd/share_access.c  |  21 ++--
 source3/wscript  |   4 +
 11 files changed, 242 insertions(+), 36 deletions(-)


Changeset truncated at 500 lines:

diff --git a/docs-xml/smbdotconf/security/hostsallow.xml 
b/docs-xml/smbdotconf/security/hostsallow.xml
index a052e7f79cd..8b4b62268a3 100644
--- a/docs-xml/smbdotconf/security/hostsallow.xml
+++ b/docs-xml/smbdotconf/security/hostsallow.xml
@@ -41,6 +41,13 @@
 
 hosts allow = lapland, 
arvidsjaur
 
+Example 4: allow only hosts in NIS netgroup "foonet", but 
+deny access from one particular host
+
+hosts allow = @foonet
+
+hosts deny = pirate
+
 Note that access still requires suitable user-level 
passwords.
 
 See testparm
diff --git a/docs-xml/smbdotconf/security/invalidusers.xml 
b/docs-xml/smbdotconf/security/invalidusers.xml
index 268cdfad560..b2fb2b9d293 100644
--- a/docs-xml/smbdotconf/security/invalidusers.xml
+++ b/docs-xml/smbdotconf/security/invalidusers.xml
@@ -7,8 +7,21 @@
 to login to this service. This is really a paranoid 
 check to absolutely ensure an improper setting does not breach 
 your security.
+   

[SCM] Samba Shared Repository - branch master updated

2022-06-09 Thread Andrew Bartlett
The branch, master has been updated
   via  e67845a73c9 ci-images: install diffutils prior to building images
   via  aec2076fa79 lib/util: Delegate constant time memcmp to 
gnutls_memcmp()
   via  222e1afc6f9 lib/util: Add test of mem_equal_const_time()
   via  a80d783a341 lib/util: Add test of data_blob_equal_const_time()
   via  8d7a091adcb lib/util: Reduce sum variable to uint8_t
   via  feb36dbebf1 lib/util: Change function to mem_equal_const_time()
   via  a554e2ce53c lib/util: Change function to 
data_blob_equal_const_time()
   via  ae6634c7877 auth: Use constant-time memcmp when comparing sensitive 
buffers
   via  87f68500ed6 lib/util: Move memcmp_const_time() to util.c
   via  ee29c601b25 tests/krb5/test_ldap.py: Increase maximum threshold for 
LDAP timeout
   via  14feb93d481 lib/util: Prefer backtrace_symbols() for internal 
backtraces
   via  bd09537e219 build: Possibly link against libexecinfo for 
backtrace_symbols()
   via  df11826a3b3 build: Make build with --disable-fault-hanlding work 
under --enable-developer
  from  ef1d04762af s3:smbd: Free allocated strings before leaving 
user_in_netgroup() function

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit e67845a73c96db885b9724d52857955b51b74632
Author: Uri Simchoni 
Date:   Wed Jun 8 22:20:03 2022 +0300

ci-images: install diffutils prior to building images

Ensure the podman image used for generating Samba CI images includes
'diff' utility

Signed-off-by: Uri Simchoni 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Thu Jun  9 23:48:42 UTC 2022 on sn-devel-184

commit aec2076fa79b853e26b1fe606570f1c4ae94c79b
Author: Joseph Sutton 
Date:   Wed Jun 8 15:19:58 2022 +1200

lib/util: Delegate constant time memcmp to gnutls_memcmp()

gnutls_memcmp() is mostly identical to our own implementation, except
that ours will not break if supplied with 4 GiB or more of data.
However, using an external function permits us to disclaim
responsibility if some CPU/compiler combination happens to invalidate
our constant-time guarantee.

For reference, gnutls_memcmp() implementation:

https://gitlab.com/gnutls/gnutls/-/blob/78d9820de0d2eb2f8088e359779ee7342f5f089e/lib/safe-memfuncs.c#L41-67

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 

commit 222e1afc6f9a49e99ae767d7572dfd16c236148d
Author: Joseph Sutton 
Date:   Wed May 11 14:06:22 2022 +1200

lib/util: Add test of mem_equal_const_time()

Ensure that it gives the correct results for comparing two memory
regions.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 

commit a80d783a341fd8b88d73e04bf831b91984f87b73
Author: Joseph Sutton 
Date:   Wed May 11 14:05:34 2022 +1200

lib/util: Add test of data_blob_equal_const_time()

Ensure that it gives the correct results for comparing two data blobs.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 

commit 8d7a091adcbd4eaa9e5e736413a179c322f6869d
Author: Joseph Sutton 
Date:   Wed May 11 14:04:25 2022 +1200

lib/util: Reduce sum variable to uint8_t

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 

commit feb36dbebf1f0f48f4d9f2549471d355b4ead788
Author: Joseph Sutton 
Date:   Wed May 11 12:07:43 2022 +1200

lib/util: Change function to mem_equal_const_time()

Since memcmp_const_time() doesn't act as an exact replacement for
memcmp(), and its return value is only ever compared with zero, simplify
it and emphasize the intention of checking equality by returning a bool
instead.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 

commit a554e2ce53cbee584bf3c0944d466cbdf73dd3b2
Author: Joseph Sutton 
Date:   Wed May 11 11:39:14 2022 +1200

lib/util: Change function to data_blob_equal_const_time()

Since data_blob_cmp_const_time() doesn't act as an exact replacement for
data_blob_cmp(), and its return value is only ever compared with zero,
simplify it and emphasize the intention of checking equality by
returning a bool instead.

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 

commit ae6634c78774d2368e815dea650ba71650dd1861
Author: Joseph Sutton 
Date:   Thu Feb 17 15:35:42 2022 +1300

auth: Use constant-time memcmp when comparing sensitive buffers

This helps to avoid timing attacks.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15010

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 

commit 87f68500ed651f393e2fc6c514ab08b561a60a9b
Author: Joseph Sutton 
Date:   Tue May 10 15:57:40 2022 +1200

lib/util: Move memcmp_const_time() to util.c

This allows it to be used in more places without needing to introduce
more dependencies.