[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via b600b0c8d96 s3: smbd: Fix memory leak in smbd_server_connection_terminate_done(). from f6b391e04a4 vfs_gpfs: Protect against timestamps before the Unix epoch https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit b600b0c8d9690cb5eeded1e5925c8e667c11af04 Author: Jeremy Allison Date: Wed Sep 14 17:05:05 2022 -0700 s3: smbd: Fix memory leak in smbd_server_connection_terminate_done(). The function smbd_server_connection_terminate_done() does not free subreq which is allocated in smbXsrv_connection_shutdown_send, this can be a memory leakage if multi-channel is enabled. Suggested fix by haihua yang BUG: https://bugzilla.samba.org/show_bug.cgi?id=15174 Signed-off-by: Jeremy Allison Reviewed-by: Noel Power Autobuild-User(master): Noel Power Autobuild-Date(master): Fri Sep 23 09:51:20 UTC 2022 on sn-devel-184 --- Summary of changes: source3/smbd/smb2_server.c | 1 + 1 file changed, 1 insertion(+) Changeset truncated at 500 lines: diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c index e8a91238baf..1cd5953f116 100644 --- a/source3/smbd/smb2_server.c +++ b/source3/smbd/smb2_server.c @@ -1643,6 +1643,7 @@ static void smbd_server_connection_terminate_done(struct tevent_req *subreq) NTSTATUS status; status = smbXsrv_connection_shutdown_recv(subreq); + TALLOC_FREE(subreq); if (!NT_STATUS_IS_OK(status)) { exit_server("smbXsrv_connection_shutdown_recv failed"); } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via f6b391e04a4 vfs_gpfs: Protect against timestamps before the Unix epoch from d9dda4b7af2 ctdb-scripts: Add debugging variable CTDB_KILLTCP_DEBUGLEVEL https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit f6b391e04a4d5974b908f4f375bd2876083aa7b2 Author: Volker Lendecke Date: Mon Aug 22 15:24:01 2022 +0200 vfs_gpfs: Protect against timestamps before the Unix epoch In addition to b954d181cd2 we should also protect against timestamps before the epoch. Bug: https://bugzilla.samba.org/show_bug.cgi?id=15151 Signed-off-by: Volker Lendecke Reviewed-by: Christof Schmitt Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Fri Sep 23 06:50:17 UTC 2022 on sn-devel-184 --- Summary of changes: source3/modules/vfs_gpfs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c index 1f3d803e1c5..779627f8115 100644 --- a/source3/modules/vfs_gpfs.c +++ b/source3/modules/vfs_gpfs.c @@ -1679,10 +1679,10 @@ static int timespec_to_gpfs_time( return 0; } - if (ts.tv_sec > UINT32_MAX) { - DBG_WARNING("GPFS uses 32-bit unsigned timestamps, " - "%ju is too large\n", - (uintmax_t)ts.tv_sec); + if (ts.tv_sec < 0 || ts.tv_sec > UINT32_MAX) { + DBG_NOTICE("GPFS uses 32-bit unsigned timestamps " + "and cannot handle %jd.\n", + (intmax_t)ts.tv_sec); errno = ERANGE; return -1; } -- Samba Shared Repository