[SCM] Samba Shared Repository - branch master updated

2022-10-03 Thread Jeremy Allison
The branch, master has been updated
   via  a91fa70ad56 tevent: Fix flag clearing
   via  3804161dca1 libsmb: Fix the smbclient readlink command
   via  f471b2c70ed libsmb: Remove unused 
cli_smb2_set_reparse_point_fnum_send/recv
   via  3d2d066c13a libsmb: Convert cli_symlink to cli_fsctl
   via  091ce9c50d6 libsmb: Remove unused 
cli_smb2_get_reparse_point_fnum_send/recv
   via  aaacbd0f2a9 libsmb: Convert cli_readlink() to cli_fsctl_send/recv
   via  dccc060bc9c libsmb: Add cli_fsctl_send/recv
   via  50b13868d4f libsmb: Add cli_smb2_fsctl_send/recv
   via  4388ba47ea2 libsmb: Centralize the SMB2 protocol check
   via  36bd73e836f smbXcli: Align smb2cli_req_create() with tevent_req 
conventions
   via  25bb94e00e2 python: whitespace fixes
   via  4b3bfbaf0f2 torture3: Align integer types
   via  d257c760a53 vfs: Fix a typo
  from  318da783e9d s3: smbtorture3: Add new SMB2-DFS-SHARE-NON-DFS-PATH 
test.

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit a91fa70ad568bbca34dc9d09e098686b8482d0ed
Author: Joseph Sutton 
Date:   Fri Apr 29 12:20:06 2022 +1200

tevent: Fix flag clearing

We presumably meant to clear this bit, rather than clearing all bits
other than it.

Signed-off-by: Joseph Sutton 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Mon Oct  3 21:05:31 UTC 2022 on sn-devel-184

commit 3804161dca1d23ab44b2c22bdf199bf640fd6cb5
Author: Volker Lendecke 
Date:   Thu Sep 29 15:41:30 2022 +0200

libsmb: Fix the smbclient readlink command

We use cli_smb2_qpathinfo_basic() for cli_resolve_path() before
calling cli_readlink(). This fails as it never tries with
FILE_OPEN_REPARSE_POINT, so we never get to the point where we
actually can issue the FSCTL_GET_REPARSE_POINT.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit f471b2c70ed67507a7a6abe70321089617565426
Author: Volker Lendecke 
Date:   Thu Sep 29 12:49:10 2022 +0200

libsmb: Remove unused cli_smb2_set_reparse_point_fnum_send/recv

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 3d2d066c13a5fda4aea4089d3dc78b4828717494
Author: Volker Lendecke 
Date:   Thu Sep 29 12:47:45 2022 +0200

libsmb: Convert cli_symlink to cli_fsctl

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 091ce9c50d6951cfe6bfdbd3cb6461a373ae56dd
Author: Volker Lendecke 
Date:   Thu Sep 29 12:41:54 2022 +0200

libsmb: Remove unused cli_smb2_get_reparse_point_fnum_send/recv

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit aaacbd0f2a95245863fa90bcd0fdbed68f590c7a
Author: Volker Lendecke 
Date:   Thu Sep 29 12:40:45 2022 +0200

libsmb: Convert cli_readlink() to cli_fsctl_send/recv

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit dccc060bc9caba6f3be1a65e213e322ccdfefd94
Author: Volker Lendecke 
Date:   Thu Sep 29 12:22:10 2022 +0200

libsmb: Add cli_fsctl_send/recv

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 50b13868d4fce15cd2348ac9dea1bca3f049e4ad
Author: Volker Lendecke 
Date:   Thu Sep 29 12:21:53 2022 +0200

libsmb: Add cli_smb2_fsctl_send/recv

Slightly refactor the symlink operations later based on this

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 4388ba47ea25213d364402da7ddcd032845d2ad3
Author: Volker Lendecke 
Date:   Thu Sep 29 11:08:12 2022 +0200

libsmb: Centralize the SMB2 protocol check

Instead of checking protocol correctness in every highlevel routine,
we should rely on the lowerlevel one in smbXcli_base.c to give the
INVALID_PARAMETER error return when running on SMB1

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 36bd73e836f733068bdc9bb5df704f825fac7d2e
Author: Volker Lendecke 
Date:   Thu Sep 29 11:00:41 2022 +0200

smbXcli: Align smb2cli_req_create() with tevent_req conventions

We don't return NULL if tevent_req_create() succeeded, and elsewhere
in this function we already pass tevent_req_nterror or
tevent_req_nomem (via set_endtime).

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 25bb94e00e2b82b8637814399241c382212bc180
Author: Volker Lendecke 
Date:   Tue Sep 20 16:21:44 2022 +0200

python: whitespace fixes

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 4b3bfbaf0f2179bc6a8172dbec62128c0db74dbc
Author: Volker Lendecke 
Date:   Thu Sep 29 10:45:19 2022 +0200

torture3: Align integer types

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit d257c760a53246857afa223b528a8066a00c8940
Author: Volker Lendecke 
Date:   Thu Sep 22 10:46:56 2022 +0200

vfs: Fix a typo

Signe

[SCM] Samba Shared Repository - branch master updated

2022-10-03 Thread Andrew Bartlett
The branch, master has been updated
   via  37406b9d97f CVE-2007-4559 python: ensure sanity in our tarfiles
   via  6a5d03e2f7b samba-tool: Use authentication file to pass credentials
   via  bff2bc9c7d6 python-drs: Add client-side debug and fallback for 
GET_ANC
   via  483c48f52d6 s4-libnet: Add messages to object count mismatch 
failures
   via  b0bbc94d412 selftest: Enable "old Samba" mode regarding 
GET_ANC/GET_TGT
   via  314bc44fa9b s4-rpc_server:getncchanges Add "old Samba" mode 
regarding GET_ANC/GET_TGT
   via  7ff743d65dc selftest: Add tests for GetNCChanges GET_ANC using 
samba-tool drs clone-dc-database
   via  62b426243f4 selftest: Prepare for "old Samba" mode regarding 
getncchanges GET_ANC/GET_TGT
  from  a91fa70ad56 tevent: Fix flag clearing

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 37406b9d97f123576c811b9fe22b39b02af62f83
Author: Douglas Bagnall 
Date:   Fri Sep 23 12:32:25 2022 +1200

CVE-2007-4559 python: ensure sanity in our tarfiles

Python's tarfile module is not very careful about paths that step out
of the target directory. We can be a bit better at little cost.

This was reported in 2007[1], and has recently been publicised [2, for
example].

We were informed of this bug in December 2021 by Luis Alberto López
Alvar, but decided then that there were no circumstances under which
this was a security concern. That is, if you can alter the backup
files, you can already do worse things. But there is a case to guard
against an administrator being tricked into trying to restore a file
that isn't based on a real backup.

[1] https://nvd.nist.gov/vuln/detail/CVE-2007-4559
[2] https://www.theregister.com/2022/09/22/python_vulnerability_tarfile/

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15185

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Tue Oct  4 03:48:43 UTC 2022 on sn-devel-184

commit 6a5d03e2f7bfa84eea1f1c44604ab70b1257d349
Author: Nikola Radovanovic 
Date:   Fri Sep 30 09:38:12 2022 +0200

samba-tool: Use authentication file to pass credentials

In order not to pass credentials in clear-text directly over command line, 
this is a patch to store username/password/domain in a file and use it during 
domain join for example.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15031

Signed-off-by: Nikola Radovanovic 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Joseph Sutton 

commit bff2bc9c7d69ec2fbe9339c2353a0a846182f1ea
Author: Andrew Bartlett 
Date:   Thu Sep 15 17:10:24 2022 +1200

python-drs: Add client-side debug and fallback for GET_ANC

Samba 4.5 and earlier will fail to do GET_ANC correctly and will not
replicate non-critical parents of objects with isCriticalSystemObject=TRUE
when DRSUAPI_DRS_CRITICAL_ONLY is set.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15189

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 

commit 483c48f52d6ff5e8149ed12bfeb2b6608c946f01
Author: Andrew Bartlett 
Date:   Tue Sep 20 13:37:30 2022 +1200

s4-libnet: Add messages to object count mismatch failures

This helps explain these better than WERR_GEN_FAILURE.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15189

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 

commit b0bbc94d4124d63b1d5a35ccbc88ffd51d520ba0
Author: Andrew Bartlett 
Date:   Thu Sep 29 14:54:14 2022 +1300

selftest: Enable "old Samba" mode regarding GET_ANC/GET_TGT

The chgdcpass server now emulates older verions of Samba that
fail to implement DRSUAPI_DRS_GET_ANC correctly and totally fails to support
DRSUAPI_DRS_GET_TGT.

We now show this is in effect by the fact that tests now fail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15189

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 

commit 314bc44fa9b8fc99c80bfcfff71f2cec67bbda36
Author: Andrew Bartlett 
Date:   Thu Sep 29 14:53:38 2022 +1300

s4-rpc_server:getncchanges Add "old Samba" mode regarding GET_ANC/GET_TGT

This emulates older verions of Samba that fail to implement
DRSUAPI_DRS_GET_ANC correctly and totally fails to support
DRSUAPI_DRS_GET_TGT.

This will allow testing of a client-side fallback, allowing migration
from sites that run very old Samba versions over DRSUAPI (currently
the only option is to attempt an in-place upgrade).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15189

Signed-off-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 

commit 7ff743d65dcf27ffe0c6861720e8ce531bfa378d
Author: Andrew Bartlett 
Date:   Thu Sep 29 03:05:03 2022 +

selftest: Add tests for GetNCChanges GET_A