[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 6539f1e4cd6 s3:winbindd: Change the TALLOC_CTX to fix the tevent
call depth tracking
from 801772012eb Revert "s3:winbindd: set TEVENT_DEPRECATED as
tevent_thread_call_depth_*() api will change soon"
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 6539f1e4cd6dfb309ff19f403994d9ec52b6bb03
Author: Pavel Filipenský
Date: Wed Jul 19 11:33:56 2023 +0200
s3:winbindd: Change the TALLOC_CTX to fix the tevent call depth tracking
Call depth is not working for winbindd_list_users_send as expected,
it is visible in the flow traces:
-> process_request_send
-> winbindd_list_users_send
-> wb_query_user_list_send
It should look like:
-> process_request_send
-> winbindd_list_users_send
-> wb_query_user_list_send
Tevent call depth tracking internal implementation relies on the fact
that the talloc memory context has type "struct tevent_req".
Then it can obtain the depth from the parent and increment it by one.
The implementation of winbindd_list_users_send() is passing to
wb_query_user_list_send() context of type
"struct winbindd_list_users_state", and from there the parent
"struct tevent_req" cannot be identified.
So we will pass as TALLOC_CTX 'state' instead of 'state->domains'.
After the call, we can reparent back.
Signed-off-by: Pavel Filipenský
Reviewed-by: Stefan Metzmacher
Autobuild-User(master): Pavel Filipensky
Autobuild-Date(master): Thu Jul 20 10:38:19 UTC 2023 on atb-devel-224
---
Summary of changes:
source3/winbindd/winbindd_list_users.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/winbindd/winbindd_list_users.c
b/source3/winbindd/winbindd_list_users.c
index 7acc3f7d761..8630672c323 100644
--- a/source3/winbindd/winbindd_list_users.c
+++ b/source3/winbindd/winbindd_list_users.c
@@ -100,9 +100,15 @@ struct tevent_req *winbindd_list_users_send(TALLOC_CTX
*mem_ctx,
for (i=0; inum_domains; i++) {
struct winbindd_list_users_domstate *d = &state->domains[i];
-
- d->subreq = wb_query_user_list_send(
- state->domains, ev, d->domain);
+ /*
+* Use "state" as a talloc memory context since it has type
+* "struct tevent_req". This is needed to make tevent call depth
+* tracking working as expected.
+* After calling wb_query_user_list_send(), re-parent back to
+* "state->domains" to make TALLOC_FREE(state->domains) working.
+*/
+ d->subreq = wb_query_user_list_send(state, ev, d->domain);
+ d->subreq = talloc_reparent(state, state->domains, d->subreq);
if (tevent_req_nomem(d->subreq, req)) {
TALLOC_FREE(state->domains);
return tevent_req_post(req, ev);
--
Samba Shared Repository
[SCM] Samba Shared Repository - annotated tag talloc-2.4.1 created
The annotated tag, talloc-2.4.1 has been created at 07be14a36896de8f1a31e768853c3b8e1dcb306e (tag) tagging 791e2817e1318237590313f7e372a27c1d48 (commit) replaces tevent-0.14.1 tagged by Stefan Metzmacher on Thu Jul 20 12:47:51 2023 +0200 - Log - talloc: tag release talloc-2.4.1 -BEGIN PGP SIGNATURE- iQEzBAABCgAdFiEEkUejOXGVGO6QEby1R5ORYRMIQCUFAmS5ENcACgkQR5ORYRMI QCWEHAgAtXcN3rjitPAt42/P2i0t1d58H/pK3K+aju6R4a8AEtavzFQCUq0A95jU UQvp1e3xzu2T7MUqC+x8TCbCk7ggmnq7WN+UHtkJrcTJ9xTnnzVQvsI8TEAJ2Ccc UFtuxfLre/MDfHni+HMI5qiRvOuh/0zvYPaMWZZHPT9450kdt2FuxzqS6yl9Al6L TeP32fB+cXy5ZqVh01MmlkSUnfmWYsBtb4mjr4l7tX5aAjO3uyY1n+qvQD3MpVgh 7JiZZLD4UXmoTKjwLf+jvdS8TWDnFhFHr+9zh0QyYYjVIUDncnvT3dwDMWefISxQ ihNjlET+Ct64y73vdvFAmFk7cGNksA== =GEZE -END PGP SIGNATURE- Alexander Bokovoy (2): Add ROLE_IPA_DC into two more places wafsamba: Normalize strings in gdb output when comparing ABI Amir Goldstein (4): s4:torture:basic: fix SET_INFO_* macros in delayed_write_update* lib: add NTTIME_[U|m]SEC macros s4:torture:basic: use milliseconds granularity in delayed_write_update7 torture/smb2: do not use client time in delayed timestamp updates test Andreas Schneider (266): s3:libsmb: Remove unused variable 'i' s3:smbd: Don't assign variable to itself s3:rpcsrv:eventlog: Remove unused variable s3:winbind: Remove unused variable s4:samdb: Remove trailing whitespaces s4:samdb: Remove unused variable nsswitch: Fix getting data out of pam_get_data() lib:ldb-samba: Correctly handle search scope s3:printing: Remove trailing whitespaces in vlp.c s3:printing: Remove unused variable s3:modules: Ignore -Wunused-but-set-variable for autogenerated code s4:modules: Move structs with dynamic arrays to end of struct s3:modules: Initialize pointer with NULL s3:netapi: Remove unused variables s3:utils: Remove unused variable s3:torture: Remove unused variable waf: Add support for MemorySanitizer lib:ldb: Add the location to ldb_kv_parse_data_unpack() debug output lib:ldb: Print a debug message in case we have a corrupted MDB testprogs: Use random usernames for kinit tests testprogs: Use random usernames for export keytab tests testprogs: Use random user names for kpasswd tests python:tests: Correctly escape $ in user_edit.sh python:tests: Use a random username for user_edit.sh tests python:tests: Correctly escape $ in contact_edit.sh python:tests: Use a random username for contact_edit.sh test python:tests: Correctly escape $ in computer_edit.sh python:tests: Use a random machine name for computer_edit.sh test python:tests: Make sure we do not run into issues with already existing users python:tests: Fix domain_backup test with Python 3.11 python:tests: Tell dns.resolver to not read /etc/resolv.conf python:tests: Add missing result checks for samba_tool.gpo tests python:tests: Make sure we delete the OU for movetest s3:utils: Check if the autorid rangesize is a multiple of the range s3:winbind: Improve warning message if we are out of autorid ranges python:netcmd: Decode return value of find_netbios() from bytes into string lib:ldb: Correctly cast pointers for assert_string_equal() ctdb:client: Fix code spelling ctdb:common: Fix code spelling ctdb:include: Remove trailing whitespaces in ctdb_protocol.h ctdb:include: Fix code spelling ctdb:server: Remove trailing whitespaces in ctdb_recover.c ctdb:server: Remove trailing whitespaces in ctdb_server.c ctdb:server: Fix code spelling ctdb:tcp: Fix code spelling ctdb:tests: Fix code spelling ctdb:tool: Fix code spelling ctdb:utils: Remove trailing whitespaces in scsi_io.c ctdb:utils: Fix code spelling s3:utils: Fix grammar in testparm auth: Fix code spelling buildtools: Fix code spelling examples: Remove trailing whitespaces in ol-schema-migrate.pl examples: Remove trailing whitespaces in mklogon.conf examples: Fix code spelling examples: Remove trailing whitespaces in smb.conf.default examples: Improve comment in smb.conf.default s3:libsmb: Remove trailing whitespaces in clientgen.c s3:libsmb: Fix conflicting declaration/implementation s3:waf: Fix One Definition Rule (ODR) violation of libsecrets3 Add .clangd configuration file buildtools: Remove compile_commands.json symlink lib:talloc: Move talloc_get_size() out of the talloc reference group lib:addns: Rename additionals to additional lib:addns: Fix code spelling lib:audit_logging: Fix code spelling lib:cmdline: Fix code spelling lib:compression: Fix code spelling lib:crypto: Improve comment about weak cr
[SCM] Samba Shared Repository - annotated tag tdb-1.4.9 created
The annotated tag, tdb-1.4.9 has been created at 95e54247fd93a9172437dabc75d5bf6cd424b049 (tag) tagging b649c7d3c2b1e13e900c80ff7a20959a70b1c528 (commit) replaces talloc-2.4.1 tagged by Stefan Metzmacher on Thu Jul 20 12:48:38 2023 +0200 - Log - tdb: tag release tdb-1.4.9 -BEGIN PGP SIGNATURE- iQEzBAABCgAdFiEEkUejOXGVGO6QEby1R5ORYRMIQCUFAmS5EQYACgkQR5ORYRMI QCUKPAf/Yqsy0hBvkvcBemxt/HI5V0DFVRnty8R9ot6grZ46qZ/67EGC93mMRDlK 304V+TW2bjtQkPVfPxp5eErc+FDKRfvRNIsqsVLxaK9qAKsOpw54Ik7+7BnPXQu9 xfMN4hoYvTWKEbjXc0Agsu7hL0hOeLT8dThSFEUspzFOOKlTMNXh6NcZEotsw0aQ +IEWjpe+bPVFjFqg4wtdzMRjlmWX3BQ50LHriRrN4okCZ9oHuefiabp7IzsKYJp6 ndhQAYwvnqPTfsWNjtKlXAmJNkoWnO/JHmzoibw03LXPiSLB9yUBPtUVluypT4kk 6B6mOV6EnGcq7Urh7qRyRrvtAsno1A== =I0wR -END PGP SIGNATURE- Stefan Metzmacher (1): tdb: release 1.4.9 --- -- Samba Shared Repository
[SCM] Samba Shared Repository - annotated tag tevent-0.15.0 created
The annotated tag, tevent-0.15.0 has been created at 4d0ff32238d0c395cd4ec3644822726cd2f81f44 (tag) tagging 6a80d170bca0c938f78ab12e37481b52792a9d83 (commit) replaces tdb-1.4.9 tagged by Stefan Metzmacher on Thu Jul 20 12:49:15 2023 +0200 - Log - tevent: tag release tevent-0.15.0 -BEGIN PGP SIGNATURE- iQEzBAABCgAdFiEEkUejOXGVGO6QEby1R5ORYRMIQCUFAmS5ESsACgkQR5ORYRMI QCW+HAf/YmdVwBVMpd6tY1cIrbArgeYOfTl1/LYTDnu449tDbx1gFJwhHWliepmo gVBXYih98ApWKxqvtUBdnmFpN2AbYKvdmvAFU7TRQdu4snH8akjYhwymWWpLu6/q be1jgGRWltTURUTsCwNkfDFXjSsLYfyzVv90brO6krNMynmcn1X6avUNAlfDELu3 aDqULU6hT0nXmlOwc/DloATHLOa/xujiUgtDhF+JXuSProQK3ZnX8ggezuQifJQN ZxUBzmtCDD8fK7SdcSZmdy2g5ohVyOw3HY9bzTDIi8OgOdNGGUqnlBgEyLEf4/m0 ti4lhBQx8iGdKZ55mQzFxwWz9p4qSQ== =IplR -END PGP SIGNATURE- Dmitry Antipov (2): lib:replace: rely on epoll_create1() for epoll interface tevent: rely on epoll_create1() for epoll interface Pavel Filipenský (6): tevent: Move definition of _DEPRECATED_ to the top of tevent.h tevent: Deprecate some tevent_thread_call_depth_*() functions tevent: Flow: pass function name to tevent_req_create() tevent: Flow: store callback function name in tevent_req tevent: Flow: store trigger function name in tevent_queue_entry tevent: Flow: add tevent_thread_call_depth_set_callback() Stefan Metzmacher (16): ldb: remove trailing whitespaces from include/dlinklist.h ldb: clarify LGPL scope of include/dlinklist.h lib/util: dlinklist.h sync with LGPL copy from lib/ldb/include/dlinklist.h tevent: add tevent_dlinklist.h as copy from lib/util/dlinklist.h s3:winbindd: set TEVENT_DEPRECATED as tevent_thread_call_depth_*() api will change soon tevent: Flow: store cancel function name in tevent_req tevent: Flow: store cleanup function name in tevent_req tevent: add fd_speed test tevent: introduce tevent_set_max_debug_level() (default TEVENT_DEBUG_WARNING) tevent: add TEVENT_DEBUG() avoid argument overhead when log is not active... tevent: make use of TEVENT_DEBUG() when using TEVENT_DEBUG_TRACE tevent: avoid epoll_check_reopen() overhead unless required tevent: let epoll_check_reopen() clear all events before reopening them tevent: avoid calling epoll_update_event() again if epoll_check_reopen() already did it tevent: add tevent_common_fd_str() helper tevent: version 0.15.0 --- -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via ca5cc05b22b s3:script: Replace --merge by --merge-by-timestamp in samba-log-parser via 16386bfd4cd docs-xml:manpages: Fix tabs in samba-log-parser.1.xml from 6539f1e4cd6 s3:winbindd: Change the TALLOC_CTX to fix the tevent call depth tracking https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit ca5cc05b22bf92dd7236d2c0d4a424340a0048f3 Author: Pavel Filipenský Date: Wed Jun 28 14:59:29 2023 +0200 s3:script: Replace --merge by --merge-by-timestamp in samba-log-parser For --merge-by-timestamp the traces do not need to contain the traceid header field. Signed-off-by: Pavel Filipenský Reviewed-by: Douglas Bagnall Autobuild-User(master): Pavel Filipensky Autobuild-Date(master): Thu Jul 20 19:14:05 UTC 2023 on atb-devel-224 commit 16386bfd4cd10bbb4a5588973220212287a2f868 Author: Pavel Filipenský Date: Wed Jun 28 16:51:35 2023 +0200 docs-xml:manpages: Fix tabs in samba-log-parser.1.xml Signed-off-by: Pavel Filipenský Reviewed-by: Douglas Bagnall --- Summary of changes: docs-xml/manpages/samba-log-parser.1.xml | 43 - source3/script/samba-log-parser | 103 --- 2 files changed, 106 insertions(+), 40 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/manpages/samba-log-parser.1.xml b/docs-xml/manpages/samba-log-parser.1.xml index ea6fd9150df..7a62cd10a47 100644 --- a/docs-xml/manpages/samba-log-parser.1.xml +++ b/docs-xml/manpages/samba-log-parser.1.xml @@ -20,7 +20,7 @@ options: --traceid ID specify the traceid of the trace records --pid PID specify the pid of winbind client --breakdownbreakdown the traces into per traceid files - --mergemerge logs by timestamp + --merge-by-timestamp merge logs by timestamp --flow show the request/sub-request flow traces --flow-compact show the request/sub-request flow traces without dcerpc details @@ -29,9 +29,9 @@ options: samba-log-parser path --pid=PID - --traceid=ID - --breakdown - --merge + --traceid=ID + --breakdown + --merge-by-timestamp --flow --flow-compact -h|--help @@ -70,31 +70,32 @@ options: --breakdown - Break down all traces to separate files in the current - working directory. For each traceid, three files are created: - traceid.full - traceid.flow - traceid.flowcompact + Break down all traces to separate files in the current + working directory. For each traceid, three files are created: + traceid.full + traceid.flow + traceid.flowcompact - --merge - Sort the trace lines according to the timestamp. - + --merge-by-timestamp + Sort the trace lines according to the timestamp. + Works with log files without traceid header field as well. + --flow - Display the request/sub-request flow. + Display the request/sub-request flow. --flow-compact - Display the request/sub-request flow without dcerpc - call details. + Display the request/sub-request flow without dcerpc + call details. @@ -118,7 +119,7 @@ options: - # samba-log-parser --pid 99 --merge /var/log/samba + # samba-log-parser --pid 99 --merge-by-timestamp /var/log/samba Break down the traces into separate files according to traceid sorted @@ -126,7 +127,15 @@ options: - # samba-log-parser --breakdown --merge /var/log/samba + # samba-log-parser --breakdown --merge-by-timestamp /var/log/samba + + + Sort traces using the timestamp for log files found in the samba log + directory. Traces do not need to contain the traceid header field. + + + + # samba-log-parser --merge-by-timestamp /var/log/samba diff --git a/source3/script/samba-log-parser b/source3/script/samba-log-parser index 1c1d2ced33d..a07dfdb4a6c 100755 --- a/source3/script/samba-log-parser +++ b/source3/script/samba-log-parser @@ -5,11 +5,12 @@ # A script to parse samba (especially winbind) logfiles. # Trace files should be in a non-syslog format (debug syslog format = no). # -#--traceid ... Specify the traceid of the request to parse -#--pid ... Spe
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 0da6cc71054 claims.idl: Fix AD claims encoding via 3109899299e lib/fault: During smb_panic() print process comment and setprocname() title via e401ae44b2f python/samba: Adjust tarfile extraction filter via 5e473cba0d3 WHATSNEW: Mention new unicodePwd only over encrypted LDAP restriction via 3f253002280 WHATSNEW: mention KDC auditing via b9667bc29a6 WHATSNEW: FAST support, Claims compression, SID compression via 6844def6675 WHATSNEW: Mention Heimdal updates via fbed6d80b1f WHATSNEW: Expand detail on what of 2012, 2012R2 and 2016 support is implemented via 29310f27d49 WHATSNEW: PKINIT testing via fb27e01b36f WHATSNEW: Include info on new samba-tool features via 0ee8c263f61 WHATSNEW: Add text on PKINIT Certificate Revocation via 980c1565ed1 s4:param: replace calls to deprecated Python methods from ca5cc05b22b s3:script: Replace --merge by --merge-by-timestamp in samba-log-parser https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 0da6cc710542f534c82d9694e8d85d1fb376e536 Author: Joseph Sutton Date: Thu Jul 20 11:14:23 2023 +1200 claims.idl: Fix AD claims encoding Up to now we have been absorbing the discriminant in the NDR padding, and setting it to zero in the push. But if the discriminant is not set correctly, Windows will refuse to regard any of the claims. Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Fri Jul 21 02:19:48 UTC 2023 on atb-devel-224 commit 3109899299e28884261f54363e84b1090b574e39 Author: Andrew Bartlett Date: Thu Jul 20 14:10:43 2023 +1200 lib/fault: During smb_panic() print process comment and setprocname() title The purpose of this is to make it clear which part of the AD DC (in particular) has faulted without having to deduce it from the stacktrace. Signed-off-by: Andrew Bartlett Reviewed-by: Ralph Boehme commit e401ae44b2f952fc2686065fbfb3a563e3d4066a Author: Noel Power Date: Fri Jul 14 14:53:29 2023 +0100 python/samba: Adjust tarfile extraction filter The 'data_filter' is far too restrictive, this filter doesn't apply any mode bits to directories which in turn will result in unexpected directory permissions of the amongst others msg.[ls]ock directories. With 'data_filter' and a 'patched' python at best we experience CI failures with samba-ad-back1 & samba-ad-back2 CI jobs due to server startup failures, at worst user/admins will need to adjust directory permissions post backup. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15390 Signed-off-by: Noel Power Reviewed-by: Douglas Bagnall Reviewed-by: Andrew Bartlett commit 5e473cba0d3dd842a41789f5d61d8234db54d6b7 Author: Andrew Bartlett Date: Thu Jul 20 15:49:08 2023 +1200 WHATSNEW: Mention new unicodePwd only over encrypted LDAP restriction Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall commit 3f253002280fa562de1c317e616d72ab8b6773c4 Author: Andrew Bartlett Date: Thu Jul 20 15:48:40 2023 +1200 WHATSNEW: mention KDC auditing Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall commit b9667bc29a63179b302a6610848df241239da7a7 Author: Andrew Bartlett Date: Thu Jul 20 15:36:09 2023 +1200 WHATSNEW: FAST support, Claims compression, SID compression Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall commit 6844def66754b87dc4b2647b65ac106382005fa7 Author: Andrew Bartlett Date: Thu Jul 20 15:19:51 2023 +1200 WHATSNEW: Mention Heimdal updates Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall commit fbed6d80b1fc4bb22896a1850ef9f15ddd0bc259 Author: Andrew Bartlett Date: Thu Jul 20 15:01:43 2023 +1200 WHATSNEW: Expand detail on what of 2012, 2012R2 and 2016 support is implemented Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall commit 29310f27d49b7b1a15a2db5966969fd0756484c4 Author: Andrew Bartlett Date: Thu Jul 20 15:01:07 2023 +1200 WHATSNEW: PKINIT testing Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall commit fb27e01b36f6741d88bfc739e693d6d273383100 Author: Andrew Bartlett Date: Thu Jul 20 14:54:02 2023 +1200 WHATSNEW: Include info on new samba-tool features Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall commit 0ee8c263f615baa3b839eeb94236b3f54862233b Author: Andrew Bartlett Date: Wed Jul 19 15:50:43 2023 +1200 WHATSNEW: Add text on PKINIT Certificate Revocation BUG: https://bugzilla.samba.org/show_bug.cgi?id=9612 Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall commit 980c1565ed11e609d415ae4daec50a587c
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 76ad44f446c lib/cmdline: Also redact --newpassword in
samba_cmdline_burn()
via 414b3803bb6 lib/cmdline: Also burn the --password2 parameter if
given
via a53ebc288f4 samba-tool: Use samba.glue.get_burnt_cmdline rather
than regex
via 3f9e4558985 python: Add glue.burn_commandline() method
via 5afd206d1d8 python: Remove const from PyList_AsStringList()
via fd81759e2ed python: Move PyList_AsStringList to common code so we
can reuse
via 848fea1a01a lib/cmdline: Return if the commandline was redacted in
samba_cmdline_burn()
from 0da6cc71054 claims.idl: Fix AD claims encoding
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 76ad44f446c42832e87b2c60a4731a8de3a0018f
Author: Andrew Bartlett
Date: Fri Jul 21 15:39:28 2023 +1200
lib/cmdline: Also redact --newpassword in samba_cmdline_burn()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15289
Signed-off-by: Andrew Bartlett
Reviewed-by: Douglas Bagnall
Autobuild-User(master): Andrew Bartlett
Autobuild-Date(master): Fri Jul 21 06:16:30 UTC 2023 on atb-devel-224
commit 414b3803bb6a1b12c44b52ab1ff64a8b7f61fd03
Author: Andrew Bartlett
Date: Fri Jul 21 14:35:20 2023 +1200
lib/cmdline: Also burn the --password2 parameter if given
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15289
Signed-off-by: Andrew Bartlett
Reviewed-by: Douglas Bagnall
commit a53ebc288f47329c997d52325eeeb5e91ce43b75
Author: Andrew Bartlett
Date: Fri Jul 21 13:30:39 2023 +1200
samba-tool: Use samba.glue.get_burnt_cmdline rather than regex
This use avoids having two different methods to match on command-line
passwords. We already have a dependency on the setproctitle python
module, and this does not change as the (C) libbsd setproctitle()
can't be run from within a python module.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15289
Signed-off-by: Andrew Bartlett
Reviewed-by: Douglas Bagnall
commit 3f9e455898554b726bf1689f743b2d9cb6b59537
Author: Andrew Bartlett
Date: Fri Jul 21 13:29:22 2023 +1200
python: Add glue.burn_commandline() method
This uses samba_cmdline_burn() to as to have common
command line redaction code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15289
Signed-off-by: Andrew Bartlett
Reviewed-by: Douglas Bagnall
commit 5afd206d1d8f0344a2f1fa7a238204d1fb164eda
Author: Andrew Bartlett
Date: Fri Jul 21 14:32:46 2023 +1200
python: Remove const from PyList_AsStringList()
The returned strings are not owned by python, so need not be const.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15289
Signed-off-by: Andrew Bartlett
Reviewed-by: Douglas Bagnall
commit fd81759e2ed44cac3bc67243a39256f953969103
Author: Andrew Bartlett
Date: Fri Jul 21 14:31:30 2023 +1200
python: Move PyList_AsStringList to common code so we can reuse
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15289
Signed-off-by: Andrew Bartlett
Reviewed-by: Douglas Bagnall
commit 848fea1a01a4ddc1598150823d5d0784d3ef0be4
Author: Andrew Bartlett
Date: Fri Jul 21 15:27:00 2023 +1200
lib/cmdline: Return if the commandline was redacted in samba_cmdline_burn()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15289
Signed-off-by: Andrew Bartlett
Reviewed-by: Douglas Bagnall
---
Summary of changes:
lib/cmdline/cmdline.c | 17 +--
lib/cmdline/cmdline.h | 4 ++-
python/modules.c | 35 +
python/modules.h | 7 +
python/pyglue.c| 60
python/samba/getopt.py | 69 --
python/samba/tests/cred_opt.py | 14 ++---
python/wscript | 1 +
source4/auth/pyauth.c | 38 ++-
source4/auth/wscript_build | 4 ++-
10 files changed, 156 insertions(+), 93 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/cmdline/cmdline.c b/lib/cmdline/cmdline.c
index de34a798aaf..db962146bd2 100644
--- a/lib/cmdline/cmdline.c
+++ b/lib/cmdline/cmdline.c
@@ -135,8 +135,9 @@ void samba_cmdline_set_machine_account_fn(
cli_credentials_set_machine_account_fn = fn;
}
-void samba_cmdline_burn(int argc, char *argv[])
+bool samba_cmdline_burn(int argc, char *argv[])
{
+ bool burnt = false;
bool found = false;
bool is_user = false;
char *p = NULL;
@@ -146,9 +147,13 @@ void samba_cmdline_burn(int argc, char *argv[])
for (i = 0; i < argc; i++) {
p = argv[i];
if (p == NULL) {
- return;
+
