Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-261-g431e63c
Hi Tim, commit 18a27a8df223ba8eb0faf6a64384acce174f3ace Author: Tim Prouty tpro...@samba.org Date: Thu Jul 2 10:27:01 2009 -0700 s3 sticky write time: Removed unused args and tighten up a function by making an arg const I don't think it makes sense to apply a const in non-pointers parameters, the function always gets a copy of the callers variable. Also you missed a const in the proto.h for set_sticky_write_time_path() which is present in the function. metze signature.asc Description: OpenPGP digital signature
Re: [SCM] Samba Shared Repository - branch master updated- release-4-0-0alpha8-261-g431e63c
On Jul 7, 2009, at 1:14 AM, Stefan (metze) Metzmacher wrote: Hi Tim, commit 18a27a8df223ba8eb0faf6a64384acce174f3ace Author: Tim Prouty tpro...@samba.org Date: Thu Jul 2 10:27:01 2009 -0700 s3 sticky write time: Removed unused args and tighten up a function by making an arg const I don't think it makes sense to apply a const in non-pointers parameters, the function always gets a copy of the callers variable. Also you missed a const in the proto.h for set_sticky_write_time_path() which is present in the function. Great point. I'll push a patch that fixes this. -Tim
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-261-g431e63c
The branch, master has been updated via 431e63cd8bfff6f67b6e6595ee5a054877709c0d (commit) via 38b081f852db83cf3c2cce41b564449070be4be2 (commit) via fd73ab5782bc086f67f159aac378c8dcb95ed4aa (commit) via 3cb0e521e1be972b6fd08fb86f7fe73da8d5 (commit) via f39232a8fb93cfccfe1533ab613867572ff7f848 (commit) via 18a27a8df223ba8eb0faf6a64384acce174f3ace (commit) via 99bd4fda0cd97eb211549a511a2ff6153c2bde2d (commit) via 0f6e10886f3f778fe301ee981873f29d295d39c5 (commit) via de3246eae2b1234cc7fcb7d4dd6c6863ab9d31b3 (commit) via 258952aa85f2a68e2d2362522f6114c6a439f1e3 (commit) via 133e915a81510f543f6458f377857d4f1b680970 (commit) via 1b8ffb36b131268e602f494aecf34b0866ef7e34 (commit) via e4a85da5708a08f06a50f4f6b95e22d0e148d85e (commit) via 5a09ba460cb757823e1deb8b2f2ae762765846c0 (commit) from c41e5e1342a06456b4a5b101f46a394d6a4252bb (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 431e63cd8bfff6f67b6e6595ee5a054877709c0d Author: Tim Prouty tpro...@samba.org Date: Mon Jul 6 15:26:57 2009 -0700 s3: Update streaminfo implementations now that only base names are passed through the vfs commit 38b081f852db83cf3c2cce41b564449070be4be2 Author: Tim Prouty tpro...@samba.org Date: Mon Jul 6 14:18:05 2009 -0700 s3 smb2: Fix unused variable warning commit fd73ab5782bc086f67f159aac378c8dcb95ed4aa Author: Tim Prouty tpro...@samba.org Date: Fri Jul 3 17:15:30 2009 -0700 s3 audit: Fix a memory leak commit 3cb0e521e1be972b6fd08fb86f7fe73da8d5 Author: Tim Prouty tpro...@samba.org Date: Thu Jul 2 13:39:20 2009 -0700 s3: Plumb smb_filename through SMB_VFS_NTIMES commit f39232a8fb93cfccfe1533ab613867572ff7f848 Author: Tim Prouty tpro...@samba.org Date: Thu Jul 2 13:13:14 2009 -0700 s3 catia: Remove pointless VOPs from catia commit 18a27a8df223ba8eb0faf6a64384acce174f3ace Author: Tim Prouty tpro...@samba.org Date: Thu Jul 2 10:27:01 2009 -0700 s3 sticky write time: Removed unused args and tighten up a function by making an arg const commit 99bd4fda0cd97eb211549a511a2ff6153c2bde2d Author: Tim Prouty tpro...@samba.org Date: Mon Jul 6 14:36:16 2009 -0700 s3: Plumb smb_filename around SMB_VFS_CHFLAGS SMB_VFS_CHFLAGS isn't actually getting the smb_filename struct for now since it only operates on the basefile. This is the strategy for all path-based operations that will never actually operate on a stream. By clarifying the meaning of path based operations that don't take an smb_filename struct, modules that implement streams such as vfs_onefs no longer need to implement SMB_VFS_CHFLAGS to ensure it's only called on the base_name. commit 0f6e10886f3f778fe301ee981873f29d295d39c5 Author: Tim Prouty tpro...@samba.org Date: Wed Jul 1 16:15:52 2009 -0700 s3: Change some filename_convert to pass in NULL for char **fname argument commit de3246eae2b1234cc7fcb7d4dd6c6863ab9d31b3 Author: Tim Prouty tpro...@samba.org Date: Wed Jul 1 16:14:40 2009 -0700 s3: Add ability to pass NULL to filename_convert for the char *fname The goal is to eventually remove the need for the char **fname argument once all callers have standardized on smb_filename. commit 258952aa85f2a68e2d2362522f6114c6a439f1e3 Author: Tim Prouty tpro...@samba.org Date: Thu Jul 2 09:27:44 2009 -0700 s3: Plumb smb_filename through SMB_VFS_UNLINK commit 133e915a81510f543f6458f377857d4f1b680970 Author: Tim Prouty tpro...@samba.org Date: Tue Jun 30 23:08:02 2009 -0700 s3 audit: Remove some recently introduced memory leaks in the audit modules commit 1b8ffb36b131268e602f494aecf34b0866ef7e34 Author: Tim Prouty tpro...@samba.org Date: Tue Jun 30 22:44:39 2009 -0700 s3 audit: Remove the usesless static function declarations from the audit modules commit e4a85da5708a08f06a50f4f6b95e22d0e148d85e Author: Tim Prouty tpro...@samba.org Date: Tue Jun 30 16:41:48 2009 -0700 s3 onefs: Fix failure in POSIX smbtorture test The return value of readlink was a bool instead of an int, which caused the length of the returned value to never be 1. commit 5a09ba460cb757823e1deb8b2f2ae762765846c0 Author: Tim Prouty tpro...@samba.org Date: Tue Jun 30 17:04:38 2009 -0700 s3: Plumb smb_filename through SMB_VFS_RENAME --- Summary of changes: examples/VFS/skel_opaque.c | 17 +- examples/VFS/skel_transparent.c | 17 +- source3/include/proto.h | 25 +- source3/include/vfs.h | 14 +- source3/locking/locking.c |3 +- source3/modules/onefs.h |8 +- source3/modules/onefs_streams.c | 177 --- source3/modules/vfs_acl_tdb.c | 27 +-
