Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-616-g3532882

2009-08-04 Thread Tim Prouty

On Jul 27, 2009, at 7:16 AM, Volker Lendecke wrote:


The branch, master has been updated
  via  3532882d02ff30c1ea47dd433715246351297e4e (commit)
  via  5135ebd6f099518f0a0b5796e8057210be824740 (commit)
  via  d3132e21f3c93043e3d29584f4094b6edfc02c5a (commit)
  via  e30509f037098feac8345f39524902061712039f (commit)
 from  cdd7a5208fbcb65e4a75ee08f8f015530f418c15 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log  
-


commit 5135ebd6f099518f0a0b5796e8057210be824740
Author: Volker Lendecke v...@samba.org
Date:   Mon Jul 27 14:47:41 2009 +0200

   Fix a valgrind error in chain_reply

   construct_reply() references the request after chain_reply has  
freed it.


Hi Volker,

Shouldn't this go into v3-4-test also?

-Tim


[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-616-g3532882

2009-07-27 Thread Volker Lendecke
The branch, master has been updated
   via  3532882d02ff30c1ea47dd433715246351297e4e (commit)
   via  5135ebd6f099518f0a0b5796e8057210be824740 (commit)
   via  d3132e21f3c93043e3d29584f4094b6edfc02c5a (commit)
   via  e30509f037098feac8345f39524902061712039f (commit)
  from  cdd7a5208fbcb65e4a75ee08f8f015530f418c15 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 3532882d02ff30c1ea47dd433715246351297e4e
Author: Volker Lendecke v...@samba.org
Date:   Mon Jul 27 14:28:52 2009 +0200

Lift the event loop in rpc_api_pipe_req() one level into cli_do_rpc_ndr

commit 5135ebd6f099518f0a0b5796e8057210be824740
Author: Volker Lendecke v...@samba.org
Date:   Mon Jul 27 14:47:41 2009 +0200

Fix a valgrind error in chain_reply

construct_reply() references the request after chain_reply has freed it.

commit d3132e21f3c93043e3d29584f4094b6edfc02c5a
Author: Volker Lendecke v...@samba.org
Date:   Sun Jul 26 20:56:58 2009 +0200

Fix a typo

commit e30509f037098feac8345f39524902061712039f
Author: Volker Lendecke v...@samba.org
Date:   Sun Jul 26 20:20:50 2009 +0200

Fix a valgrind error in winbind

When looking for idle clients, we dereferenced state-response. As this is
dynamically allocated now, the proper test is whether state-response 
exists at
all. This is the case when an async operation is in process at that moment.

---

Summary of changes:
 source3/include/proto.h|   11 ++-
 source3/include/smb.h  |2 +
 source3/librpc/rpc/dcerpc.c|8 +-
 source3/rpc_client/cli_pipe.c  |   33 -
 source3/rpc_client/ndr.c   |  146 +++-
 source3/smbd/process.c |   13 +++-
 source3/winbindd/winbindd.c|3 +-
 source3/winbindd/winbindd_cm.c |2 +-
 8 files changed, 141 insertions(+), 77 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/include/proto.h b/source3/include/proto.h
index aed2c4c..3e9f5e8 100644
--- a/source3/include/proto.h
+++ b/source3/include/proto.h
@@ -5262,10 +5262,6 @@ struct tevent_req *rpc_api_pipe_req_send(TALLOC_CTX 
*mem_ctx,
 prs_struct *req_data);
 NTSTATUS rpc_api_pipe_req_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
   prs_struct *reply_pdu);
-NTSTATUS rpc_api_pipe_req(TALLOC_CTX *mem_ctx, struct rpc_pipe_client *cli,
-   uint8 op_num,
-   prs_struct *in_data,
-   prs_struct *out_data);
 struct tevent_req *rpc_pipe_bind_send(TALLOC_CTX *mem_ctx,
  struct event_context *ev,
  struct rpc_pipe_client *cli,
@@ -5615,6 +5611,13 @@ void init_samr_CryptPassword(const char *pwd,
 
 /* The following definitions come from rpc_client/ndr.c  */
 
+struct tevent_req *cli_do_rpc_ndr_send(TALLOC_CTX *mem_ctx,
+  struct tevent_context *ev,
+  struct rpc_pipe_client *cli,
+  const struct ndr_interface_table *table,
+  uint32_t opnum,
+  void *r);
+NTSTATUS cli_do_rpc_ndr_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx);
 NTSTATUS cli_do_rpc_ndr(struct rpc_pipe_client *cli,
TALLOC_CTX *mem_ctx,
const struct ndr_interface_table *table,
diff --git a/source3/include/smb.h b/source3/include/smb.h
index 6ccdd96..1192744 100644
--- a/source3/include/smb.h
+++ b/source3/include/smb.h
@@ -655,6 +655,8 @@ struct smb_request {
 * state information for async smb handling
 */
void *async_priv;
+
+   bool done;
 };
 
 /* Defines for the sent_oplock_break field above. */
diff --git a/source3/librpc/rpc/dcerpc.c b/source3/librpc/rpc/dcerpc.c
index 21a2004..e6c4cb4 100644
--- a/source3/librpc/rpc/dcerpc.c
+++ b/source3/librpc/rpc/dcerpc.c
@@ -69,6 +69,10 @@ struct rpc_request *dcerpc_ndr_request_send(struct 
dcerpc_pipe *p, const struct
return ret;
 }
 
+#if 0
+
+Completely unfinished and unused -- vl :-)
+
 /**
  * Wait for a DCE/RPC request. 
  *
@@ -118,10 +122,6 @@ NTSTATUS dcerpc_ndr_request_recv(struct rpc_request *req)
return NT_STATUS_OK;
 }
 
-#if 0
-
-Completely unfinished and unused -- vl :-)
-
 /**
  * Connect to a DCE/RPC interface.
  * 
diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c
index 70660da..c9f17c6 100644
--- a/source3/rpc_client/cli_pipe.c
+++ b/source3/rpc_client/cli_pipe.c
@@ -2284,39 +2284,6 @@ NTSTATUS rpc_api_pipe_req_recv(struct tevent_req *req, 
TALLOC_CTX *mem_ctx,
return NT_STATUS_OK;
 }
 
-NTSTATUS rpc_api_pipe_req(TALLOC_CTX *mem_ctx, struct rpc_pipe_client *cli,
-