The branch, master has been updated via cc74f213248f910c1c7908b23be07485752e85b9 (commit) from 996a2054fb951139344712ee68774a55fb65ae1e (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit cc74f213248f910c1c7908b23be07485752e85b9 Author: Matthias Dieter Wallnöfer <mwallnoe...@yahoo.de> Date: Wed Aug 5 10:48:25 2009 +0200 s4:torture The test logic for the target was wrong. This should correct it. ----------------------------------------------------------------------- Summary of changes: source4/torture/ldap/basic.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/torture/ldap/basic.c b/source4/torture/ldap/basic.c index ff95ba7..c2a26f8 100644 --- a/source4/torture/ldap/basic.c +++ b/source4/torture/ldap/basic.c @@ -217,7 +217,7 @@ static bool test_error_codes(struct torture_context *tctx, WERROR err; NTSTATUS status; - printf("Testing error codes\n"); + printf("Testing error codes - to make this test pass against SAMBA 4 you have to specify the target!\n"); if (!basedn) { return false; @@ -257,7 +257,7 @@ static bool test_error_codes(struct torture_context *tctx, err = ad_error(rep->r.AddResponse.errormessage, &endptr); err_code_str = win_errstr(err); printf(" - Errorcode: %s; Reason: %s\n", err_code_str, endptr); - if (torture_setting_bool(tctx, "samba4", false)) { + if (!torture_setting_bool(tctx, "samba4", false)) { if ((!W_ERROR_EQUAL(err, WERR_DS_REFERRAL)) || (rep->r.AddResponse.resultcode != 10)) { return false; @@ -298,7 +298,7 @@ static bool test_error_codes(struct torture_context *tctx, err = ad_error(rep->r.ModifyResponse.errormessage, &endptr); err_code_str = win_errstr(err); printf(" - Errorcode: %s; Reason: %s\n", err_code_str, endptr); - if (torture_setting_bool(tctx, "samba4", false)) { + if (!torture_setting_bool(tctx, "samba4", false)) { if ((!W_ERROR_EQUAL(err, WERR_INVALID_PARAM)) || (rep->r.ModifyResponse.resultcode != 53)) { return false; @@ -337,7 +337,7 @@ static bool test_error_codes(struct torture_context *tctx, err = ad_error(rep->r.DelResponse.errormessage, &endptr); err_code_str = win_errstr(err); printf(" - Errorcode: %s; Reason: %s\n", err_code_str, endptr); - if (torture_setting_bool(tctx, "samba4", false)) { + if (!torture_setting_bool(tctx, "samba4", false)) { if ((!W_ERROR_EQUAL(err, WERR_DS_OBJ_NOT_FOUND)) || (rep->r.DelResponse.resultcode != 32)) { return false; -- Samba Shared Repository