SMB2 oplocks

2010-04-07 Thread Stefan (metze) Metzmacher
Hi Jeremy,

> - Log -
> commit 3413cf7a6bd992fa722cc9674176beb15446502b
> Author: Jeremy Allison 
> Date:   Wed Apr 7 19:00:44 2010 -0700
> 
> Start to plumb smb2 into the oplock system. Calls dummy functions for now.

Do you noticed that smbd_smb2_send_oplock_break() already exists and you
just have to call it from send_smb2_break_message()?

metze




signature.asc
Description: OpenPGP digital signature


Re: SMB2 oplocks

2010-04-08 Thread Jeremy Allison
On Thu, Apr 08, 2010 at 08:42:15AM +0200, Stefan (metze) Metzmacher wrote:
> Hi Jeremy,
> 
> > - Log -
> > commit 3413cf7a6bd992fa722cc9674176beb15446502b
> > Author: Jeremy Allison 
> > Date:   Wed Apr 7 19:00:44 2010 -0700
> > 
> > Start to plumb smb2 into the oplock system. Calls dummy functions for 
> > now.
> 
> Do you noticed that smbd_smb2_send_oplock_break() already exists and you
> just have to call it from send_smb2_break_message()?

Yes, I did see it earlier, then forgot when doing
the refactoring :-).

I'm still working on the plumbing, so was more trying
to get the hooks in the SMB1 code right before getting
anything working.

I still need to fix the "delayed open" issue in SMB2
when create returns NT_STATUS_SHARING_VIOLATION first.
Once I've got the code right for that, adding the oplock
work should be relatively easy.

Thanks for the reminder :-)

Jeremy.