svn commit: samba r14155 - branches/SAMBA_3_0/source/utils trunk/source/utils

[jmcd]

Author: jmcd
Date: 2006-03-10 14:20:09 +0000 (Fri, 10 Mar 2006)
New Revision: 14155

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14155

Log:
Fix coverity #115: free storage alloc'ed by sstring_sub()

Modified:
   branches/SAMBA_3_0/source/utils/net_rpc_samsync.c
   trunk/source/utils/net_rpc_samsync.c


Changeset:
Modified: branches/SAMBA_3_0/source/utils/net_rpc_samsync.c
===================================================================
--- branches/SAMBA_3_0/source/utils/net_rpc_samsync.c   2006-03-10 14:18:10 UTC 
(rev 14154)
+++ branches/SAMBA_3_0/source/utils/net_rpc_samsync.c   2006-03-10 14:20:09 UTC 
(rev 14155)
@@ -1636,6 +1636,7 @@
            strcmp(aliasname, "Print Operators") == 0 ||
            strcmp(aliasname, "Backup Operators") == 0 ||
            strcmp(aliasname, "Replicator") == 0) {
+               SAFE_FREE(group_attr);
                return NT_STATUS_OK;
        } else {
                /* Increment the gid for the new group */
@@ -1663,6 +1664,7 @@
        fprintf(add_fd, "\n");
        fflush(add_fd);
 
+       SAFE_FREE(group_attr);
        /* Return */
        return NT_STATUS_OK;
 }

Modified: trunk/source/utils/net_rpc_samsync.c
===================================================================
--- trunk/source/utils/net_rpc_samsync.c        2006-03-10 14:18:10 UTC (rev 
14154)
+++ trunk/source/utils/net_rpc_samsync.c        2006-03-10 14:20:09 UTC (rev 
14155)
@@ -1636,6 +1636,7 @@
            strcmp(aliasname, "Print Operators") == 0 ||
            strcmp(aliasname, "Backup Operators") == 0 ||
            strcmp(aliasname, "Replicator") == 0) {
+               SAFE_FREE(group_attr);
                return NT_STATUS_OK;
        } else {
                /* Increment the gid for the new group */
@@ -1663,6 +1664,7 @@
        fprintf(add_fd, "\n");
        fflush(add_fd);
 
+       SAFE_FREE(group_attr);
        /* Return */
        return NT_STATUS_OK;
 }