Author: jra Date: 2006-03-10 17:52:41 +0000 (Fri, 10 Mar 2006) New Revision: 14168
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14168 Log: Fix Coverity #219. I think this is a false coverity warning as it seems to get confused with assignment and comparison. Clarify the code anyway. Jeremy. Modified: branches/SAMBA_3_0/source/smbd/sesssetup.c Changeset: Modified: branches/SAMBA_3_0/source/smbd/sesssetup.c =================================================================== --- branches/SAMBA_3_0/source/smbd/sesssetup.c 2006-03-10 17:51:35 UTC (rev 14167) +++ branches/SAMBA_3_0/source/smbd/sesssetup.c 2006-03-10 17:52:41 UTC (rev 14168) @@ -1044,7 +1044,10 @@ } else { struct auth_context *plaintext_auth_context = NULL; const uint8 *chal; - if (NT_STATUS_IS_OK(nt_status = make_auth_context_subsystem(&plaintext_auth_context))) { + + nt_status = make_auth_context_subsystem(&plaintext_auth_context); + + if (NT_STATUS_IS_OK(nt_status)) { chal = plaintext_auth_context->get_ntlm_challenge(plaintext_auth_context); if (!make_user_info_for_reply(&user_info,
