Re: svn commit: samba r19842 - in branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl: .

[Jelmer Vernooij]

On Wed, Nov 22, 2006 at 08:34:38PM +0100, Stefan (metze) Metzmacher wrote:
 [EMAIL PROTECTED] schrieb:
  Author: jelmer
  Date: 2006-11-22 16:53:30 + (Wed, 22 Nov 2006)
  New Revision: 19842

  WebSVN: 
  http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19842

  Log:
  Complain about unknown pointer types.
  Fallback to unique when ptr is specified instead of failing.

 Hi Jelmer,

 that's wrong and don't work against windows,

 that's why I added the sptr type, the implements full pointer support
 that works in the epmapper pipe against windows.

 sptr uses 1,2,3,4,5... as pointer values
 unique uses 0x0002,0x00020004, 0x00020008, 0x0002000C ...
 to match what w2k3 do

 please readd 'sptr' as valid pointertype, as pidl supports it and
 should until we have 'ptr' support!
Ah, I was already wondering why we had this strange, non-standard
pointer type!

I'll simply add support for full pointers tomorrow.

Cheers,

Jelmer


signature.asc
Description: Digital signature

svn commit: samba r19842 - in branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl: .

[jelmer]

Author: jelmer
Date: 2006-11-22 16:53:30 + (Wed, 22 Nov 2006)
New Revision: 19842

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19842

Log:
Complain about unknown pointer types.
Fallback to unique when ptr is specified instead of failing.

Modified:
   branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm


Changeset:
Modified: branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm
===
--- branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm2006-11-22 
16:53:28 UTC (rev 19841)
+++ branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/NDR.pm2006-11-22 
16:53:30 UTC (rev 19842)
@@ -1052,9 +1052,14 @@
 
ValidProperties($interface,INTERFACE);
 
-   if (has_property($interface, pointer_default)  
-   $interface-{PROPERTIES}-{pointer_default} eq ptr) {
-   fatal $interface, Full pointers are not supported yet\n;
+   if (has_property($interface, pointer_default)) {
+   if ($interface-{PROPERTIES}-{pointer_default} eq ptr) {
+   nonfatal $interface, Full pointers are not supported 
yet, falling back to unique;
+   $interface-{PROPERTIES}-{pointer_default} = unique;
+   } elsif (not grep 
(/$interface-{PROPERTIES}-{pointer_default}/, 
+   (ref, unique, ptr))) {
+   fatal $interface, Unknown default pointer type 
`$interface-{PROPERTIES}-{pointer_default}';
+   }
}
 
if (has_property($interface, object)) {

Re: svn commit: samba r19842 - in branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl: .

[Stefan (metze) Metzmacher]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

[EMAIL PROTECTED] schrieb:
 Author: jelmer
 Date: 2006-11-22 16:53:30 + (Wed, 22 Nov 2006)
 New Revision: 19842
 
 WebSVN: 
 http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=19842
 
 Log:
 Complain about unknown pointer types.
 Fallback to unique when ptr is specified instead of failing.

Hi Jelmer,

that's wrong and don't work against windows,

that's why I added the sptr type, the implements full pointer support
that works in the epmapper pipe against windows.

sptr uses 1,2,3,4,5... as pointer values
unique uses 0x0002,0x00020004, 0x00020008, 0x0002000C ...
to match what w2k3 do

please readd 'sptr' as valid pointertype, as pidl supports it and
should until we have 'ptr' support!

thanks!

metze
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFFZKZOm70gjA5TCD8RAiHiAJ9fK0ygOPrnIhxxVovtA6Hz97mjUACcCBCO
5R38slxiWQ3aA4Jvd84plOs=
=phOP
-END PGP SIGNATURE-