Re: svn commit: samba r23030 - in branches/SAMBA_4_0/source: auth/gensec auth/kerberos ldap_server libcli/cldap libcli/ldap libcli/util librpc/ndr

2007-05-21 Thread Stefan (metze) Metzmacher
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

[EMAIL PROTECTED] schrieb:
> Author: tridge
> Date: 2007-05-21 06:12:06 + (Mon, 21 May 2007)
> New Revision: 23030
> 
> WebSVN: 
> http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23030
> 
> Log:
> 
> finally fixed up our asn1 code to use better memory allocation. This
> should allow us to fix some long standing memory leaks.

Hi Tridge,

thanks!

can you change:

+   struct asn1_data *asn1 = asn1_init(mem_ctx);

into:

+   struct asn1_data *asn1;


asn1 = asn1_init(mem_ctx);
if (!asn1) error...;

?

metze
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFGUV6Jm70gjA5TCD8RAsdOAJ0Tb8/kTdEAZ1Rs8zvmRrQTSJjW3wCfYxK1
tFyXg+PK4hzA0fn2imEdlSs=
=T0F/
-END PGP SIGNATURE-


svn commit: samba r23030 - in branches/SAMBA_4_0/source: auth/gensec auth/kerberos ldap_server libcli/cldap libcli/ldap libcli/util librpc/ndr

2007-05-20 Thread tridge
Author: tridge
Date: 2007-05-21 06:12:06 + (Mon, 21 May 2007)
New Revision: 23030

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23030

Log:

finally fixed up our asn1 code to use better memory allocation. This
should allow us to fix some long standing memory leaks.

Modified:
   branches/SAMBA_4_0/source/auth/gensec/spnego.c
   branches/SAMBA_4_0/source/auth/gensec/spnego_parse.c
   branches/SAMBA_4_0/source/auth/kerberos/gssapi_parse.c
   branches/SAMBA_4_0/source/ldap_server/ldap_server.c
   branches/SAMBA_4_0/source/libcli/cldap/cldap.c
   branches/SAMBA_4_0/source/libcli/cldap/cldap.h
   branches/SAMBA_4_0/source/libcli/ldap/ldap.c
   branches/SAMBA_4_0/source/libcli/ldap/ldap_client.c
   branches/SAMBA_4_0/source/libcli/ldap/ldap_controls.c
   branches/SAMBA_4_0/source/libcli/util/asn1.c
   branches/SAMBA_4_0/source/librpc/ndr/ndr_drsuapi.c


Changeset:
Sorry, the patch is too large (2268 lines) to include; please use WebSVN to see 
it!
WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23030