Re: [PATCH] add 'modules path' and handle 'configure --with-configdir' right
On Tue, Nov 26, 2002 at 08:06:07AM +0100, Stefan (metze) Metzmacher wrote about 'Re:
[PATCH] add 'modules path' and handle 'configure --with-configdir' right':
here's the next version of the patch. (it's now attached :-)
I've applied a part of your patch, but I'm waiting with the
lp_modules_dir() stuff until we've resolved the problems around the
new module system - the loading of charset modules and ab's comments.
I added --with-sambadatadir witch is default ${datadir}/samba (--with-fhs)
or ${datadir}
${datadir} is ${prefix}/share by default, so $(sambadatadir) is
${prefix}/share/samba or ${prefix}/share.
the valid.dat ... files are now installed to sambadatadir
I'm happy with this patch, but NOT with the name 'sambadatadir' DOES
ANYBODY HAVE ABETTER IDEA?
Need a new capslock key? ;-) Would the name datadir be ok to you - is
there anyone who has problems with putting the *.dat files not in the
libdir ?
How's your winsdb stuff btw?
Jelmer
msg04706/pgp0.pgp
Description: PGP signature
Re: [PATCH] add 'modules path' and handle 'configure --with-configdir' right
msg.pgp Description: PGP message
Re: [PATCH] add 'modules path' and handle 'configure --with-configdir' right
Hi Jelmer,
here's the next version of the patch.
I added --with-sambadatadir witch is default ${datadir}/samba (--with-fhs)
or ${datadir}
${datadir} is ${prefix}/share by default, so $(sambadatadir) is
${prefix}/share/samba or ${prefix}/share.
the valid.dat ... files are now installed to sambadatadir
I'm happy with this patch, but NOT with the name 'sambadatadir' DOES
ANYBODY HAVE ABETTER IDEA?
I removed the modules/Makfile.ext_modules.in stuff
I think we should put ALL header files in include/ and then after make
proto we can install all headers to ${prefix}/include/samba
so that the modules only have to include:
#include samba/includes.h
metze
-
Stefan metze Metzmacher [EMAIL PROTECTED]
Re: [PATCH] add 'modules path' and handle 'configure --with-configdir' right
At 11:23 23.11.2002 +1100, Tim Potter wrote: On Fri, Nov 22, 2002 at 01:21:21PM +0100, Jelmer Vernooij wrote: here's a patch that added the 'modules path' parameter. lp_modules_path() is prefixed to all lp_modules() witch are not start with '/' (not absolute pathes) the default for lp_modules_path() is selectable by ./configure --with-modulesdir=/modules or $(LIBDIR)/samba (when --with-fhs) or $(LIBDIR) make installmodules install the modules to lp_modules_path() make modules now makes proto_exist Thanks a lot! These were on my todo list.I'll take a look at it later today (when I get back home, I'm currently at school) There's already a directory for architecture specific library files - libexec. We haven't needed to use this so much before so it probably isn't supported in configure.in. How about $(LIBEXECDIR)/modules as a location for the vfs modules? --libexecdir=DIRprogram executables in DIR [EPREFIX/libexec] --libdir=DIRobject code libraries in DIR [EPREFIX/lib] I think modules are object code libaries I would preferr to use LIBDIR/samba , LIBDIR/samba/modules , LIBEXECDIR/samba or LIBEXEC/samba/modules (but I would like one of the first two) I also don't like the valid.dat , upcase.dat, lowcase.dat installed to LIBDIR they should go to LIBDIR/samba/ or CONFIGDIR/ (we should always use the subdir samba, exept BINDIR and SBINDIR) because of that I want to change lib_path() to libsamba_path() and dyn_LIDDIR to dyn_LIBSAMBADIR. Tim. metze - Stefan metze Metzmacher [EMAIL PROTECTED]
Re: [PATCH] add 'modules path' and handle 'configure --with-configdir' right
the patch doesn't compile fine. - I forgot to add dyn_MODULESDIR to include/dynconfig.h - in param/loadparm.c szModulesPath shold be char * not char ** - add a warning to modules/Makefile.ext_modules.in : that the users should be careful with editing this file If you want me to send a new patch tell me. metze
Re: [PATCH] add 'modules path' and handle 'configure --with-configdir' right
At 12:00 22.11.2002 +0100, Stefan (metze) Metzmacher wrote: If you want me to send a new patch tell me. anyway I'll send a new patch with a few more fixes. But we have to discuss on IRC... metze - Stefan metze Metzmacher [EMAIL PROTECTED]
Re: [PATCH] add 'modules path' and handle 'configure --with-configdir' right
On Fri, Nov 22, 2002 at 11:36:48AM +0100, Stefan (metze) Metzmacher wrote: Hi Jelmer, here's a patch that added the 'modules path' parameter. lp_modules_path() is prefixed to all lp_modules() witch are not start with '/' (not absolute pathes) the default for lp_modules_path() is selectable by ./configure --with-modulesdir=/modules or $(LIBDIR)/samba (when --with-fhs) or $(LIBDIR) make installmodules install the modules to lp_modules_path() make modules now makes proto_exist Thanks a lot! These were on my todo list.I'll take a look at it later today (when I get back home, I'm currently at school) there's a new file modules/Makefile.ext_modules.in: here can extern modules be added then they're also catches by 'make modules' I'm not so sure about this one - we should rather have a mechanism with which external developers can compile modules without requiring the samba source code - and they can always add their module to Makefile.in and add it to $MODULES there. Jelmer
Re: [PATCH] add 'modules path' and handle 'configure --with-configdir' right
At 13:21 22.11.2002 +0100, Jelmer Vernooij wrote: On Fri, Nov 22, 2002 at 11:36:48AM +0100, Stefan (metze) Metzmacher wrote: Hi Jelmer, here's a patch that added the 'modules path' parameter. lp_modules_path() is prefixed to all lp_modules() witch are not start with '/' (not absolute pathes) the default for lp_modules_path() is selectable by ./configure --with-modulesdir=/modules or $(LIBDIR)/samba (when --with-fhs) or $(LIBDIR) make installmodules install the modules to lp_modules_path() make modules now makes proto_exist Thanks a lot! These were on my todo list.I'll take a look at it later today (when I get back home, I'm currently at school) :-) there's a new file modules/Makefile.ext_modules.in: here can extern modules be added then they're also catches by 'make modules' I'm not so sure about this one - we should rather have a mechanism with which external developers can compile modules without requiring the samba source code - and they can always add their module to Makefile.in and add it to $MODULES there. but if the Makefile.in is updated it's possible to get conflicts... most module need include/proto.h so I think we need the source code, but if you have a better solution it'd be fine too. --- Stefan Metzmacher [EMAIL PROTECTED]
Re: [PATCH] add 'modules path' and handle 'configure --with-configdir' right
On Fri, Nov 22, 2002 at 01:21:21PM +0100, Jelmer Vernooij wrote: here's a patch that added the 'modules path' parameter. lp_modules_path() is prefixed to all lp_modules() witch are not start with '/' (not absolute pathes) the default for lp_modules_path() is selectable by ./configure --with-modulesdir=/modules or $(LIBDIR)/samba (when --with-fhs) or $(LIBDIR) make installmodules install the modules to lp_modules_path() make modules now makes proto_exist Thanks a lot! These were on my todo list.I'll take a look at it later today (when I get back home, I'm currently at school) There's already a directory for architecture specific library files - libexec. We haven't needed to use this so much before so it probably isn't supported in configure.in. How about $(LIBEXECDIR)/modules as a location for the vfs modules? Tim.
