Re: [PATCH]block.c (recycle.c)
At 11:55 02.09.2002 +0300, Alexander Bokovoy wrote: 2. I think it would be nicer to don't use /etc/samba/recycle.conf and use the following in smb.conf: [homes] vfs object = /usr/lib/samba/vfs_recycle.so vfs: recycle: bin = .recycle/%u second : isn't needed. vfs: recycle mode = KEEP_DIRECTORIES|VERSIONS vfs: recycle maxsize = 0 vfs: recycle exclude = *.tmp|*.temp|*.obj|~$*|*.$$$ vfs: recycle excludedir = /tmp|/temp|/trash vfs: recycle noversions = *.doc|*.xls|*.ppt or this: [homes] vfs object = /usr/lib/samba/vfs_recycle.so vfs_recycle: path = .recycle/%u vfs_recycle: mode = KEEP_DIRECTORIES|VERSIONS vfs_recycle: maxsize = 0 vfs_recycle: exclude = *.tmp|*.temp|*.obj|~$*|*.$$$ vfs_recycle: excludedir = /tmp|/temp|/trash vfs_recycle: noversions = *.doc|*.xls|*.ppt This involves adding new parameters to loadparm.c which isn't acceptable actually. Better use parametrical options from above. I think this are parametrical options! (only from an other type) (const char *)lp_parm_string(lp_servicename(SNUM(conn)),vfs,recycle bin)); moved to (const char *)lp_parm_string(lp_servicename(SNUM(conn)),vfs_recycle,path)); metze - Stefan metze Metzmacher [EMAIL PROTECTED]
Re: [PATCH]block.c
Hi Alexander, Am Donnerstag, 29. August 2002 10:27 schrieb Alexander Bokovoy: On Wed, Aug 28, 2002 at 07:46:36PM +0200, Juergen Hasch wrote: Hi Jelmer, I'm not using the block module, it's just that some C compilers don't like C++ comments. This stops building the VFS modules for me. Juergen, could you please send an update for you recycle bin module for HEAD? I've put an updated version on www.elbonia.de/samba/recycle_head.html However I get some errors when compiling under AIX with xlc_r compiler : recycle.c, line 75.10: 1506-196 (E) Initialization between types void* and int(*)(struct connection_struct*,const char*,const char*) is not allowed. recycle.c, line 76.10: 1506-196 (E) Initialization between types void* and void(*)(struct connection_struct*) is not allowed. recycle.c, line 80.10: 1506-196 (E) Initialization between types void* and int(*)(struct connection_struct*,const char*) is not allowed. This happens for other VFS modules, too. GCC doesn't complain here. ...Juergen
Re: [PATCH]block.c (recycle.c)
HI Jürgen, First the update version of recycle.c looks good! But I would like to change something: 1. rename recycle.c to vfs_recycle.c ! All samba module should be prefixed with the subsystem prefix (e.g. vfs_recycle.so , pdb_xml.so, sam_ads.so ...) 2. I think it would be nicer to don't use /etc/samba/recycle.conf and use the following in smb.conf: [homes] vfs object = /usr/lib/samba/vfs_recycle.so vfs: recycle: bin = .recycle/%u vfs: recycle mode = KEEP_DIRECTORIES|VERSIONS vfs: recycle maxsize = 0 vfs: recycle exclude = *.tmp|*.temp|*.obj|~$*|*.$$$ vfs: recycle excludedir = /tmp|/temp|/trash vfs: recycle noversions = *.doc|*.xls|*.ppt or this: [homes] vfs object = /usr/lib/samba/vfs_recycle.so vfs_recycle: path = .recycle/%u vfs_recycle: mode = KEEP_DIRECTORIES|VERSIONS vfs_recycle: maxsize = 0 vfs_recycle: exclude = *.tmp|*.temp|*.obj|~$*|*.$$$ vfs_recycle: excludedir = /tmp|/temp|/trash vfs_recycle: noversions = *.doc|*.xls|*.ppt metze - Stefan metze Metzmacher [EMAIL PROTECTED]
