Re: breakage in cliconnect or thereabouts

2003-03-09 Thread Andrew Bartlett
On Mon, 2003-03-10 at 09:55, Christopher R. Hertel wrote:
> On Mon, Mar 10, 2003 at 08:20:34AM +1100, Andrew Bartlett wrote:
> > On Mon, 2003-03-10 at 08:05, Ronan Waide wrote:
> > > Hi folks,
> > > 
> > >   * libsmb/smb_signing.c, libsmb/smbencrypt.c, Makefile.in,
> > >   include/client.h, libsmb/cliconnect.c, libsmb/clientgen.c:
> > >   Change the way we sign SMB packets, to a function pointer interface.
> > > 
> > >   The intention is to allow for NTLMSSP and kerberos signing of packets,
> > > but for now it's just what I call 'simple' signing. (aka SMB
> > > signing per the SNIA spec)
> > > 
> > >   Andrew Bartlett
> > > 
> > > some part of this change is currently stopping connections to an
> > > NT4SP6 PDC working from Samba. I'm getting "session request to SERVER
> > > failed (Called name not present)"
> > > 
> > > If I find the bug, I'll post further. If not, I'm sure someone else
> > > will catch it :)
> > 
> > Yes - I was clobbering the 'signature' field of the packet, but the
> > session request is NBT, not SMB so doesn't have this field.
> 
> Right.  The "Called Name Not Present" error is at the NBT layer and it 
> would occur well before you would start signing packets.  There is no SMB 
> exchange happening yet at the point at which that error comes up.

I was 'signing' packets with 8 Nulls by default, rather than leaving
them intact.

> Do I remember correctly that there was a post from rsharpe regarding the 
> "*SMBSERVER" name not being tried?

Yep - I fixed smbtorture to use cli_full_connection(), which should have
fixed that.

Andrew Bartlet

-- 
Andrew Bartlett [EMAIL PROTECTED]
Manager, Authentication Subsystems, Samba Team  [EMAIL PROTECTED]
Student Network Administrator, Hawker College   [EMAIL PROTECTED]
http://samba.org http://build.samba.org http://hawkerc.net


signature.asc
Description: This is a digitally signed message part


Re: breakage in cliconnect or thereabouts

2003-03-09 Thread Christopher R. Hertel
On Mon, Mar 10, 2003 at 08:20:34AM +1100, Andrew Bartlett wrote:
> On Mon, 2003-03-10 at 08:05, Ronan Waide wrote:
> > Hi folks,
> > 
> > * libsmb/smb_signing.c, libsmb/smbencrypt.c, Makefile.in,
> >   include/client.h, libsmb/cliconnect.c, libsmb/clientgen.c:
> > Change the way we sign SMB packets, to a function pointer interface.
> > 
> > The intention is to allow for NTLMSSP and kerberos signing of packets,
> > but for now it's just what I call 'simple' signing. (aka SMB
> > signing per the SNIA spec)
> > 
> > Andrew Bartlett
> > 
> > some part of this change is currently stopping connections to an
> > NT4SP6 PDC working from Samba. I'm getting "session request to SERVER
> > failed (Called name not present)"
> > 
> > If I find the bug, I'll post further. If not, I'm sure someone else
> > will catch it :)
> 
> Yes - I was clobbering the 'signature' field of the packet, but the
> session request is NBT, not SMB so doesn't have this field.

Right.  The "Called Name Not Present" error is at the NBT layer and it 
would occur well before you would start signing packets.  There is no SMB 
exchange happening yet at the point at which that error comes up.

Do I remember correctly that there was a post from rsharpe regarding the 
"*SMBSERVER" name not being tried?

Chris -)-

-- 
Samba Team -- http://www.samba.org/ -)-   Christopher R. Hertel
jCIFS Team -- http://jcifs.samba.org/   -)-   ubiqx development, uninq.
ubiqx Team -- http://www.ubiqx.org/ -)-   [EMAIL PROTECTED]
OnLineBook -- http://ubiqx.org/cifs/-)-   [EMAIL PROTECTED]


Re: breakage in cliconnect or thereabouts

2003-03-09 Thread Andrew Bartlett
On Mon, 2003-03-10 at 08:05, Ronan Waide wrote:
> Hi folks,
> 
>   * libsmb/smb_signing.c, libsmb/smbencrypt.c, Makefile.in, include/client.h, 
> libsmb/cliconnect.c, libsmb/clientgen.c:
>   Change the way we sign SMB packets, to a function pointer interface.
> 
>   The intention is to allow for NTLMSSP and kerberos signing of packets, but
>   for now it's just what I call 'simple' signing. (aka SMB signing per the SNIA
>   spec)
> 
>   Andrew Bartlett
> 
> some part of this change is currently stopping connections to an
> NT4SP6 PDC working from Samba. I'm getting "session request to SERVER
> failed (Called name not present)"
> 
> If I find the bug, I'll post further. If not, I'm sure someone else
> will catch it :)

Yes - I was clobbering the 'signature' field of the packet, but the
session request is NBT, not SMB so doesn't have this field.

Andrew Bartlett

-- 
Andrew Bartlett [EMAIL PROTECTED]
Manager, Authentication Subsystems, Samba Team  [EMAIL PROTECTED]
Student Network Administrator, Hawker College   [EMAIL PROTECTED]
http://samba.org http://build.samba.org http://hawkerc.net


signature.asc
Description: This is a digitally signed message part