Ruediger, I'm try to find time and comment on this soon. Should I
comment on github or should you post the patches to the list so I can
reply? I had at least 3 comments from quick glance.
Also, you might should request write access to git so you can commit
these patches yourself if you think you'll be cleaning up for a while;
although I have no problems doing that on your behalf.
Even if you commit yourself, I think your current process is good
though since your touching framework and other people's backends. If
its more than a trivial #ifdef HAVE_HEADER_FILE addition, I also post
framwork/other's backend patches to list before committing.
Chris
On Sun, Jan 22, 2012 at 1:35 AM, Ruediger Meier sweet_f_a at gmx.de wrote:
Hi,
I've spend some time making the net backend win32 portable. Maybe we
could build a useful native (non-cygwin) xsane (saned client) on
Windows now.
Please pull from my private clone
git://github.com/rudimeier/sane-backends.git
branch win32/net
Hope this doesn't break something.
If wanted I would post these patches on this list too.
Ruediger Meier (13):
?bldchn, provide macro SANE_CHECK_NETDB_FUNC
?bldchn, add checks for netdb.h and ws2tcpip.h
?bldchn, use our new macro SANE_CHECK_NETDB_FUNC
?bldchn, checking for socklen_t more safe
?fix sanei_udp, socklen_t was not defined on win32
?bldchn, don't always disable net backend on win32
?net, move some includes from net.h to net.c
?net, add missing includes for win32
?net, re-use sane_set_io_mode
?net, implement O_NONBLOCK stuff for win32
?net, use recv/send instead of read/write
?net, call WSAStartup on win32
?bldchn, SANE_CHECK_IPV6 more portable
?acinclude.m4 ? ? ? ? ? ? | ? 76 +++---
?backend/net.c ? ? ? ? ? ?| ? 54 +++-
?backend/net.h ? ? ? ? ? ?| ? ?3 -
?configure ? ? ? ? ? ? ? ?| ?201
++
?configure.in ? ? ? ? ? ? | ? 22 +-
?include/sane/config.h.in | ? ?9 ++
?sanei/sanei_udp.c ? ? ? ?| ? ?3 +
?7 files changed, 329 insertions(+), 39 deletions(-)
--
1.7.6.1
--
sane-devel mailing list: sane-devel at lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject unsubscribe your_password
? ? ? ? ? ? to sane-devel-request at lists.alioth.debian.org
